Re: Review Request 36908: Added QuotaInfo Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/#review101316 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 2, 2015, 1:38

Re: Review Request 38160: Documented how to expedite event firing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38160/#review101320 --- Patch looks great! Reviews applied: [38161, 38160] All tests

Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38627/ --- Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff. Bugs:

Re: Review Request 38161: Replaced a hard-coded number for registration backoff with a proper constant.

> On Oct. 1, 2015, 6:08 p.m., Ben Mahler wrote: > > src/tests/fault_tolerance_tests.cpp, lines 650-651 > > > > > > I don't think we need this second sentence, since the DEFAULT expresses > > this pretty clearly,

Re: Review Request 38161: Replaced a hard-coded number for registration backoff with a proper constant.

> On Oct. 1, 2015, 6:08 p.m., Ben Mahler wrote: > > src/tests/fault_tolerance_tests.cpp, line 1540 > > > > > > I could have committed the `> >` flattening already for you if it was > > split, also, it would be be

Re: Review Request 38160: Documented how to expedite event firing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38160/ --- (Updated Oct. 2, 2015, 1:26 p.m.) Review request for mesos, Bernd Mathiske and

Review Request 38952: Replaced `> >` with `>>` in fault tolerance tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38952/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 38952: Replaced `> >` with `>>` in fault tolerance tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38952/#review101317 --- Bad patch! Reviews applied: [38161, 38952] Failed command:

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/#review101310 --- Patch looks great! Reviews applied: [37714, 37996, 37997, 37998,

Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff. Bugs:

Re: Review Request 38952: Replaced `> >` with `>>` in fault tolerance tests.

> On Oct. 2, 2015, 3:01 p.m., Neil Conway wrote: > > I agree this is an improvement, but rather than doing this piecemeal, why > > not do it once across the whole codebase? > > > > Might also be worth adding to the style guide. We have discussed that before and the agreement was not to do a

Re: Review Request 38160: Documented how to expedite event firing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38160/#review101329 --- Patch looks great! Reviews applied: [38161, 38952, 38160] All

Re: Review Request 38160: Documented how to expedite event firing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38160/ --- (Updated Oct. 2, 2015, 3:13 p.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 38161: Replaced a hard-coded number for registration backoff with a proper constant.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38161/ --- (Updated Oct. 2, 2015, 3:13 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38952: Replaced `> >` with `>>` in fault tolerance tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38952/#review101323 --- I agree this is an improvement, but rather than doing this

Re: Review Request 38952: Replaced `> >` with `>>` in fault tolerance tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38952/ --- (Updated Oct. 2, 2015, 3:13 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38580: Added docker registry RemotePuller

> On Oct. 1, 2015, 6:53 p.m., Timothy Chen wrote: > > src/slave/containerizer/provisioner/docker/remote_puller.cpp, line 227 > > > > > > I thought you wanted to move this to somewhere shared? We can create a > >

Re: Review Request 38960: Add QuotaInfo Protobuf to CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38960/#review101336 --- Ship it! Ship It! - Alex Clemmer On Oct. 2, 2015, 4:51 p.m.,

Review Request 38961: Simplified resources initialization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38961/ --- Review request for mesos and Bernd Mathiske. Repository: mesos Description

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review101339 --- src/slave/containerizer/provisioner/docker/remote_puller.cpp

Re: Review Request 38960: Add QuotaInfo Protobuf to CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38960/#review101342 --- Patch looks great! Reviews applied: [38960] All tests passed. -

Re: Review Request 38161: Replaced a hard-coded number for registration backoff with a proper constant.

> On Oct. 1, 2015, 6:08 p.m., Ben Mahler wrote: > > src/tests/fault_tolerance_tests.cpp, lines 1547-1551 > > > > > > It looks inconsistent to do this here but not in the other tests this > > patch touches. Now

Review Request 38963: Added initial draft of networking user-doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38963/ --- Review request for mesos, Connor Doyle and Niklas Nielsen. Bugs: MESOS-3561

Re: Review Request 38814: add test cases for sha512 digest verifier

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38814/ --- (Updated Oct. 2, 2015, 11:29 a.m.) Review request for mesos, Jojy Varghese and

Re: Review Request 38416: Allow HTTP response codes to be checked with code.

> On Sept. 25, 2015, 10:52 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/http.hpp, lines 59-60 > > > > > > How about just status()? > > > > We can also avoid Option here by just returning

Review Request 38960: Add QuotaInfo Protobuf to CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38960/ --- Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer,

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Oct. 2, 2015, 5:18 p.m.) Review request for mesos, Jie Yu, Timothy

Re: Review Request 38416: Allow HTTP response codes to be checked with code.

> On Sept. 25, 2015, 10:52 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/http.hpp, lines 59-60 > > > > > > How about just status()? > > > > We can also avoid Option here by just returning

Re: Review Request 38416: Allow HTTP response codes to be checked with code.

> On Sept. 25, 2015, 10:52 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/http.hpp, lines 59-60 > > > > > > How about just status()? > > > > We can also avoid Option here by just returning

Re: Review Request 38577: Added synchronous validation for Call in Agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/ --- (Updated Oct. 2, 2015, 6:42 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 38960: Add QuotaInfo Protobuf to CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38960/#review101335 --- Ship it! Ship It! - Gilbert Song On Oct. 2, 2015, 9:51 a.m.,

Re: Review Request 38963: Added initial draft of networking user-doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38963/#review101347 --- A few things you're missing (haven't read the doc yet): * A link

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review101338 --- src/slave/containerizer/provisioner/docker/registry_client.cpp

Re: Review Request 38161: Replaced a hard-coded number for registration backoff with a proper constant.

> On Oct. 1, 2015, 6:08 p.m., Ben Mahler wrote: > > src/tests/fault_tolerance_tests.cpp, lines 1547-1551 > > > > > > It looks inconsistent to do this here but not in the other tests this > > patch touches. Now

Re: Review Request 38960: Add QuotaInfo Protobuf to CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38960/#review101345 --- Ship it! Good catch, thanks Joseph! - Alexander Rukletsov On

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Oct. 2, 2015, 6:41 p.m.) Review request for mesos, Jie Yu, Timothy

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38901/ --- (Updated Oct. 2, 2015, 1:10 p.m.) Review request for mesos, Jojy Varghese and

Re: Review Request 38844: Added unit tests for Call validation in Agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38844/ --- (Updated Oct. 2, 2015, 6:53 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 38961: Simplified resources initialization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38961/#review101353 --- Patch looks great! Reviews applied: [38961] All tests passed. -

Re: Review Request 38816: add test case for docker remotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38816/ --- (Updated Oct. 2, 2015, 11:59 a.m.) Review request for mesos, Jojy Varghese and

Re: Review Request 38900: Update command executor to support rootfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38900/#review101350 --- src/launcher/executor.cpp (line 97)

Re: Review Request 38814: add test cases for sha512 digest verifier

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38814/#review101361 --- 3rdparty/libprocess/src/tests/digest_tests.cpp (line 130)

Re: Review Request 38844: Added unit tests for Call validation in Agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38844/#review101366 --- Patch looks great! Reviews applied: [38618, 38577, 38844] All

Re: Review Request 38963: Added initial draft of networking user-doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38963/#review101354 --- Bad patch! Reviews applied: [38963] Failed command:

Review Request 38967: Added functionality to generate Java V1 Protobufs and insert them into the existing JAR for now

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38967/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-3575

Re: Review Request 38963: Added initial draft of networking user-doc.

> On Oct. 2, 2015, 11:31 a.m., Joseph Wu wrote: > > A few things you're missing (haven't read the doc yet): > > > > * A link to this from `home.md`. > > * You need to generate this diff manually (via `git diff --binary`) and > > post it. The image won't be included otherwise. (ReviewBot is

Re: Review Request 38967: Added functionality to generate Java V1 Protobufs and insert them into the existing JAR for now

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38967/#review101385 --- src/Makefile.am (line 225)

Re: Review Request 38844: Added unit tests for Call validation in Agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38844/#review101384 --- Ship it! LGTM - Anand Mazumdar On Oct. 2, 2015, 6:53 p.m.,

Re: Review Request 38579: Refactored registry client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/#review101382 --- Thanks for taking this on Jojy! This is going to be a great

Re: Review Request 38941: Moved structs outside RegistryClient

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38941/#review101390 --- Thanks for the small patch! I would have liked to ship this but I

Re: Review Request 38608: Added an http::Connection for connection re-use and pipelining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38608/ --- (Updated Oct. 2, 2015, 11:49 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38608: Added an http::Connection for connection re-use and pipelining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38608/ --- (Updated Oct. 3, 2015, 12:04 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38967: Added functionality to generate Java V1 Protobufs and insert them into the existing JAR for now

> On Oct. 2, 2015, 10:34 p.m., Isabel Jimenez wrote: > > src/Makefile.am, line 225 > > > > > > Could you also add a fix for v1 python proto generation? Checkout my comment here :

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38901/#review101387 --- src/slave/containerizer/provisioner/docker/spec.hpp (line 37)

Re: Review Request 38967: Added functionality to generate Java V1 Protobufs and insert them into the existing JAR for now

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38967/#review101392 --- Patch looks great! Reviews applied: [38967] All tests passed. -

Re: Review Request 38416: Allow HTTP response codes to be checked with code.

> On Sept. 25, 2015, 10:52 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/http.hpp, lines 59-60 > > > > > > How about just status()? > > > > We can also avoid Option here by just returning

Re: Review Request 38579: Refactored registry client

> On Oct. 2, 2015, 11:16 p.m., Ben Mahler wrote: > > src/slave/containerizer/provisioner/docker/registry_client.hpp, lines 75-86 > > > > > > As it stands these comments don't seem to be adding any value over what >