Review Request 39003: Fixed Python protobuf V1 generation

2015-10-05 Thread Isabel Jimenez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39003/
---

Review request for mesos, Anand Mazumdar, Joris Van Remoortere, and Marco 
Massenzio.


Repository: mesos


Description
---

V1 protobus were not being generated for python.


Diffs
-

  src/Makefile.am e698927 

Diff: https://reviews.apache.org/r/39003/diff/


Testing
---

make check and verify v1 protobufs were properly generated


Thanks,

Isabel Jimenez



Re: Review Request 39002: Fixed sed command for Python protos generation.

2015-10-05 Thread Anand Mazumdar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39002/#review101501
---

Ship it!


Ship It!

- Anand Mazumdar


On Oct. 5, 2015, 5:48 p.m., Isabel Jimenez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39002/
> ---
> 
> (Updated Oct. 5, 2015, 5:48 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Joris Van Remoortere, and Marco 
> Massenzio.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The current command didn't complete the protobuf generation and resulted in 
> an empty file.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am e698927 
> 
> Diff: https://reviews.apache.org/r/39002/diff/
> 
> 
> Testing
> ---
> 
> make check and verified that protobufs were properly generated
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>



Re: Review Request 38570: Change documentation image links to absolute paths.

2015-10-05 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38570/
---

(Updated Oct. 5, 2015, 11:11 a.m.)


Review request for mesos, Adam B, Artem Harutyunyan, and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-3183
https://issues.apache.org/jira/browse/MESOS-3183


Repository: mesos


Description
---

Also removes extraneous `?raw=true` from the links.


Diffs (updated)
-

  docs/external-containerizer.md 96932189b74dce1ae28e0bd73d5543d1afaffb0b 
  docs/fetcher-cache-internals.md e8a68d1230420d1afca61f92c1ab6be12a70dbf2 
  docs/maintenance.md a5831ffa092a9ea6decbe2e640bae637c759a308 
  docs/oversubscription.md 5a31b1ff7f003307817732a71f3b0a7c7d60cd24 

Diff: https://reviews.apache.org/r/38570/diff/


Testing
---

Patched `Rakefile` to include images in the website (See JIRA for the patch).
Then rendered with: https://github.com/mesosphere/mesos-website-container

Confirmed that images show up on the modified docs.


Thanks,

Joseph Wu



Review Request 39002: Fixed sed command for Python protos generation.

2015-10-05 Thread Isabel Jimenez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39002/
---

Review request for mesos, Anand Mazumdar, Joris Van Remoortere, and Marco 
Massenzio.


Repository: mesos


Description
---

The current command didn't complete the protobuf generation and resulted in an 
empty file.


Diffs
-

  src/Makefile.am e698927 

Diff: https://reviews.apache.org/r/39002/diff/


Testing
---

make check and verified that protobufs were properly generated


Thanks,

Isabel Jimenez



Re: Review Request 37993: Add explanatory comments for Allocator interface

2015-10-05 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37993/#review101495
---

Ship it!


This is looking very good now!

Thanks for being patient with our comments :)


include/mesos/master/allocator.hpp (line 154)


Typo: s/desing/design/



include/mesos/master/allocator.hpp (line 340)


Missing a period.


- Joseph Wu


On Oct. 3, 2015, 9:24 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37993/
> ---
> 
> (Updated Oct. 3, 2015, 9:24 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, and Michael Park.
> 
> 
> Bugs: MESOS-2224
> https://issues.apache.org/jira/browse/MESOS-2224
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add explanatory comments for Allocator interface
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp 8100f14220599247a340c919a03f29755b5349d8 
> 
> Diff: https://reviews.apache.org/r/37993/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>



Re: Review Request 39002: Fixed sed command for Python protos generation.

2015-10-05 Thread Cong Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39002/#review101499
---

Ship it!


Ship It!

- Cong Wang


On Oct. 5, 2015, 5:48 p.m., Isabel Jimenez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39002/
> ---
> 
> (Updated Oct. 5, 2015, 5:48 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Joris Van Remoortere, and Marco 
> Massenzio.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The current command didn't complete the protobuf generation and resulted in 
> an empty file.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am e698927 
> 
> Diff: https://reviews.apache.org/r/39002/diff/
> 
> 
> Testing
> ---
> 
> make check and verified that protobufs were properly generated
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>



Re: Review Request 38750: Updated changelog for 0.25.0

2015-10-05 Thread Niklas Nielsen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38750/
---

(Updated Oct. 5, 2015, 11:18 a.m.)


Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description
---

Updated changelog for 0.25.0


Diffs (updated)
-

  CHANGELOG fc48cc2aafbfa5342d68401426f246685a5fbef6 

Diff: https://reviews.apache.org/r/38750/diff/


Testing
---


Thanks,

Niklas Nielsen



Re: Review Request 37024: Exposes mesos version information in components.

2015-10-05 Thread Marco Massenzio

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/#review101506
---

Ship it!


Ship It!

- Marco Massenzio


On Oct. 5, 2015, 8 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37024/
> ---
> 
> (Updated Oct. 5, 2015, 8 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1841
> https://issues.apache.org/jira/browse/MESOS-1841
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add an endpoint that exposes component version.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba 
>   src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1 
>   src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f 
>   src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734 
>   src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d 
>   src/slave/main.cpp 364dc7fc7ab2e3cef01aea7267dafa014b60e2b9 
>   src/version/version.hpp PRE-CREATION 
>   src/version/version.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37024/diff/
> 
> 
> Testing
> ---
> 
> Manual test result:
> 
> ```
> $ curl http://localhost:5050/version 2>/dev/null|jq .
> 
> {
>   "version": "0.24.0",
>   "build_user": "haosdent",
>   "build_time": 1439702338,
>   "build_date": "2015-08-16 13:18:58"
> }
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

2015-10-05 Thread Gilbert Song

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38901/
---

(Updated Oct. 5, 2015, 12:21 p.m.)


Review request for mesos, Jojy Varghese and Timothy Chen.


Changes
---

delete unnecessary protobuf


Bugs: MESOS-2972
https://issues.apache.org/jira/browse/MESOS-2972


Repository: mesos


Description
---

Serialize Docker Image Spec as Protobuf


Diffs (updated)
-

  src/CMakeLists.txt 891f951f3107ece29b7923b7a3cc414e2ea56983 
  src/Makefile.am f060998bb08cdb071db5a2e85dfbad805dab45e9 
  src/slave/containerizer/provisioner/docker/message.proto 
bbac2e6c1f40a7ca3f9227baca56a44cd43f58c6 
  src/slave/containerizer/provisioner/docker/spec.hpp PRE-CREATION 
  src/slave/containerizer/provisioner/docker/spec.cpp PRE-CREATION 
  src/tests/containerizer/provisioner_docker_tests.cpp 
d895eb9d0723e52cff8b21ef2deeaef1911d019c 

Diff: https://reviews.apache.org/r/38901/diff/


Testing
---

make check (ubuntu 14.04 + clang++-3.6)


Thanks,

Gilbert Song



Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

2015-10-05 Thread Gilbert Song


> On Oct. 2, 2015, 3:38 p.m., Timothy Chen wrote:
> > src/tests/containerizer/provisioner_docker_tests.cpp, line 361
> > 
> >
> > What's invalid about this JSON?

Because we have to make sure that we have at least one fsLayer blobSum and 
corresponding v1Compatibility, which is validated from validateManifest(const 
DockerImageManifest& manifest).
For here, history, fsLayers and signatures are missed.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38901/#review101387
---


On Oct. 5, 2015, 12:14 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38901/
> ---
> 
> (Updated Oct. 5, 2015, 12:14 p.m.)
> 
> 
> Review request for mesos, Jojy Varghese and Timothy Chen.
> 
> 
> Bugs: MESOS-2972
> https://issues.apache.org/jira/browse/MESOS-2972
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Serialize Docker Image Spec as Protobuf
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 891f951f3107ece29b7923b7a3cc414e2ea56983 
>   src/Makefile.am f060998bb08cdb071db5a2e85dfbad805dab45e9 
>   src/slave/containerizer/provisioner/docker/message.proto 
> bbac2e6c1f40a7ca3f9227baca56a44cd43f58c6 
>   src/slave/containerizer/provisioner/docker/spec.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/spec.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> d895eb9d0723e52cff8b21ef2deeaef1911d019c 
> 
> Diff: https://reviews.apache.org/r/38901/diff/
> 
> 
> Testing
> ---
> 
> make check (ubuntu 14.04 + clang++-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>



Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

2015-10-05 Thread Gilbert Song

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38901/
---

(Updated Oct. 5, 2015, 12:14 p.m.)


Review request for mesos, Jojy Varghese and Timothy Chen.


Bugs: MESOS-2972
https://issues.apache.org/jira/browse/MESOS-2972


Repository: mesos


Description
---

Serialize Docker Image Spec as Protobuf


Diffs (updated)
-

  src/CMakeLists.txt 891f951f3107ece29b7923b7a3cc414e2ea56983 
  src/Makefile.am f060998bb08cdb071db5a2e85dfbad805dab45e9 
  src/slave/containerizer/provisioner/docker/message.proto 
bbac2e6c1f40a7ca3f9227baca56a44cd43f58c6 
  src/slave/containerizer/provisioner/docker/spec.hpp PRE-CREATION 
  src/slave/containerizer/provisioner/docker/spec.cpp PRE-CREATION 
  src/tests/containerizer/provisioner_docker_tests.cpp 
d895eb9d0723e52cff8b21ef2deeaef1911d019c 

Diff: https://reviews.apache.org/r/38901/diff/


Testing
---

make check (ubuntu 14.04 + clang++-3.6)


Thanks,

Gilbert Song



Re: Review Request 38750: Updated changelog for 0.25.0

2015-10-05 Thread Niklas Nielsen


> On Oct. 5, 2015, 9:38 a.m., Michael Park wrote:
> > CHANGELOG, line 47
> > 
> >
> > This ticket was resolved as "Won't Fix". It shouldn't be included in 
> > here, right? I think you mentioned this is due to the limitations of a JIRA 
> > release tool?

Will do


- Niklas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38750/#review101484
---


On Sept. 24, 2015, 10:13 p.m., Niklas Nielsen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38750/
> ---
> 
> (Updated Sept. 24, 2015, 10:13 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated changelog for 0.25.0
> 
> 
> Diffs
> -
> 
>   CHANGELOG 18af16785ca969740bd0eb5e1dee985e2609dfb2 
> 
> Diff: https://reviews.apache.org/r/38750/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>



Re: Review Request 37024: Exposes mesos version information in components.

2015-10-05 Thread Marco Massenzio

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/#review101508
---



src/version/version.cpp (lines 81 - 82)


Minor nit: s/mesos/Apache Mesos and I think you can drop the "This 
endpoint" - "Shows the current version and build information for Apache Mesos"

or something like that...


- Marco Massenzio


On Oct. 5, 2015, 8 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37024/
> ---
> 
> (Updated Oct. 5, 2015, 8 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1841
> https://issues.apache.org/jira/browse/MESOS-1841
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add an endpoint that exposes component version.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba 
>   src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1 
>   src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f 
>   src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734 
>   src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d 
>   src/slave/main.cpp 364dc7fc7ab2e3cef01aea7267dafa014b60e2b9 
>   src/version/version.hpp PRE-CREATION 
>   src/version/version.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37024/diff/
> 
> 
> Testing
> ---
> 
> Manual test result:
> 
> ```
> $ curl http://localhost:5050/version 2>/dev/null|jq .
> 
> {
>   "version": "0.24.0",
>   "build_user": "haosdent",
>   "build_time": 1439702338,
>   "build_date": "2015-08-16 13:18:58"
> }
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 37024: Exposes mesos version information in components.

2015-10-05 Thread Marco Massenzio


> On Oct. 5, 2015, 6:48 p.m., Marco Massenzio wrote:
> > src/version/version.cpp, lines 81-82
> > 
> >
> > Minor nit: s/mesos/Apache Mesos and I think you can drop the "This 
> > endpoint" - "Shows the current version and build information for Apache 
> > Mesos"
> > 
> > or something like that...

Also, can you please make sure that in the commit comment we have a full 
description of the endpoint's returned result (I also think that the 
description above is no longer current?).


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/#review101508
---


On Oct. 5, 2015, 8 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37024/
> ---
> 
> (Updated Oct. 5, 2015, 8 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1841
> https://issues.apache.org/jira/browse/MESOS-1841
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add an endpoint that exposes component version.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba 
>   src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1 
>   src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f 
>   src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734 
>   src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d 
>   src/slave/main.cpp 364dc7fc7ab2e3cef01aea7267dafa014b60e2b9 
>   src/version/version.hpp PRE-CREATION 
>   src/version/version.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37024/diff/
> 
> 
> Testing
> ---
> 
> Manual test result:
> 
> ```
> $ curl http://localhost:5050/version 2>/dev/null|jq .
> 
> {
>   "version": "0.24.0",
>   "build_user": "haosdent",
>   "build_time": 1439702338,
>   "build_date": "2015-08-16 13:18:58"
> }
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 39037: Allow description empty in help information.

2015-10-05 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39037/#review101603
---

Ship it!


Ship It!

- Guangya Liu


On 十月 6, 2015, 4:15 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39037/
> ---
> 
> (Updated 十月 6, 2015, 4:15 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3104
> https://issues.apache.org/jira/browse/MESOS-3104
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allow description empty in help information.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/help.hpp 
> e7dc670648e8abd2fef7be79835f0b71e3e91258 
>   3rdparty/libprocess/src/help.cpp 822c0844c61c7cabfca2b0534a5fb40001bd7cc7 
> 
> Diff: https://reviews.apache.org/r/39037/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 39018: Added JSON parsing for Resources.

2015-10-05 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39018/#review101589
---



include/mesos/resources.hpp (line 73)


s/name:value(role)/name(role):value



include/mesos/v1/resources.hpp (line 73)


s/name:value(role)/name(role):value


- Guangya Liu


On 十月 5, 2015, 9:51 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39018/
> ---
> 
> (Updated 十月 5, 2015, 9:51 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Jie Yu, and Michael 
> Park.
> 
> 
> Bugs: MESOS-2467
> https://issues.apache.org/jira/browse/MESOS-2467
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This includes code changes necessary for JSON parsing of Resources. 
> Documentation changes will be posted soon in another review.
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp 6c3a065945eb56dc88df9c977e5ca11d4cbcbf61 
>   include/mesos/v1/resources.hpp fe8925ac851b74d1b37919f00afc7ed816f47ea5 
>   src/common/resources.cpp 601388c35a1bff37c58e753d1870d53b8d0af2d1 
>   src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697 
>   src/v1/resources.cpp dc868903472f8f3a1ddc56092e3f8f81d953ce39 
> 
> Diff: https://reviews.apache.org/r/39018/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2015-10-05 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/#review101595
---


Patch looks great!

Reviews applied: [39019]

All tests passed.

- Mesos ReviewBot


On Oct. 5, 2015, 10:12 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39019/
> ---
> 
> (Updated Oct. 5, 2015, 10:12 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added dirent compat code for non-Unix systems.
> 
> 
> Diffs
> -
> 
>   
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> 50e35f43d87c69a83a9e7d039d1881404ea8be38 
> 
> Diff: https://reviews.apache.org/r/39019/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 37023: Add an endpoint that exposes component flags.

2015-10-05 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/#review101604
---

Ship it!


Ship It!

- Guangya Liu


On 十月 6, 2015, 4:15 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37023/
> ---
> 
> (Updated 十月 6, 2015, 4:15 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3104
> https://issues.apache.org/jira/browse/MESOS-3104
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add an endpoint that exposes component flags.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660 
>   src/master/master.hpp 4bb65f0b6b77ea7324b0dee943602cfdb0f6a11c 
>   src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b 
>   src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b 
>   src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476 
>   src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c 
> 
> Diff: https://reviews.apache.org/r/37023/diff/
> 
> 
> Testing
> ---
> 
> manual test wich mesos-local.
> ```
> $ curl http://localhost:5050/master/flags 2>/dev/null|jq .
> {
>   "flags": {
> "allocation_interval": "1secs",
> "allocator": "HierarchicalDRF",
> "authenticate": "false",
> "authenticate_slaves": "false",
> "authenticators": "crammd5",
> "framework_sorter": "drf",
> "help": "true",
> "initialize_driver_logging": "true",
> "log_auto_initialize": "true",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "max_slave_ping_timeouts": "5",
> "quiet": "false",
> "recovery_slave_removal_limit": "100%",
> "registry": "replicated_log",
> "registry_fetch_timeout": "1mins",
> "registry_store_timeout": "5secs",
> "registry_strict": "false",
> "root_submissions": "true",
> "slave_ping_timeout": "15secs",
> "slave_reregister_timeout": "10mins",
> "user_sorter": "drf",
> "version": "false",
> "webui_dir": "/home/haosdent/mesos/build/../src/webui",
> "work_dir": "/tmp/mesos",
> "zk_session_timeout": "10secs"
>   }
> }
> ```
> 
> ```
> $ curl http://localhost:5050/slave(1)/flags 2>/dev/null|jq .
> {
>   "flags": {
> "authenticatee": "crammd5",
> "cgroups_cpu_enable_pids_and_tids_count": "false",
> "cgroups_enable_cfs": "false",
> "cgroups_hierarchy": "/sys/fs/cgroup",
> "cgroups_limit_swap": "false",
> "cgroups_root": "mesos",
> "container_disk_watch_interval": "15secs",
> "containerizers": "mesos",
> "default_role": "*",
> "disk_watch_interval": "1mins",
> "docker": "docker",
> "docker_kill_orphans": "true",
> "docker_remove_delay": "6hrs",
> "docker_socket": "/var/run/docker.sock",
> "docker_stop_timeout": "0ns",
> "enforce_container_disk_quota": "false",
> "executor_registration_timeout": "1mins",
> "executor_shutdown_grace_period": "5secs",
> "fetcher_cache_dir": "/tmp/mesos/fetch",
> "fetcher_cache_size": "2GB",
> "frameworks_home": "",
> "gc_delay": "1weeks",
> "gc_disk_headroom": "0.1",
> "hadoop_home": "",
> "help": "false",
> "initialize_driver_logging": "true",
> "isolation": "posix/cpu,posix/mem",
> "launcher_dir": "/home/haosdent/mesos/build/src",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "oversubscribed_resources_interval": "15secs",
> "perf_duration": "10secs",
> "perf_interval": "1mins",
> "qos_correction_interval_min": "0ns",
> "quiet": "false",
> "recover": "reconnect",
> "recovery_timeout": "15mins",
> "registration_backoff_factor": "1secs",
> "resource_monitoring_interval": "1secs",
> "revocable_cpu_low_priority": "true",
> "sandbox_directory": "/mnt/mesos/sandbox",
> "strict": "true",
> "switch_user": "true",
> "version": "false",
> "work_dir": "/tmp/mesos/0"
>   }
> }
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 38919: Validation of Docker Image Manifests

2015-10-05 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38919/#review101600
---


Patch looks great!

Reviews applied: [38901, 38919]

All tests passed.

- Mesos ReviewBot


On Oct. 5, 2015, 8:51 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38919/
> ---
> 
> (Updated Oct. 5, 2015, 8:51 p.m.)
> 
> 
> Review request for mesos, Jojy Varghese and Timothy Chen.
> 
> 
> Bugs: MESOS-3099
> https://issues.apache.org/jira/browse/MESOS-3099
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Validation of Docker Image Manifests
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioner/docker/spec.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/spec.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> d895eb9d0723e52cff8b21ef2deeaef1911d019c 
> 
> Diff: https://reviews.apache.org/r/38919/diff/
> 
> 
> Testing
> ---
> 
> make check (Ubuntu14.04 + clang++-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>



Re: Review Request 38963: Added initial draft of networking user-doc.

2015-10-05 Thread Kapil Arya

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38963/
---

(Updated Oct. 5, 2015, 3:55 p.m.)


Review request for mesos, Connor Doyle and Niklas Nielsen.


Bugs: MESOS-3561
https://issues.apache.org/jira/browse/MESOS-3561


Repository: mesos


Description
---

Added initial draft of networking user-doc.


Diffs
-

  docs/home.md f8c2b62 
  docs/images/networking-architecture.png PRE-CREATION 
  docs/networking-for-mesos-managed-containers.md PRE-CREATION 

Diff: https://reviews.apache.org/r/38963/diff/


Testing (updated)
---

Markdown rendering at 
https://github.com/karya0/mesos/blob/net-user-doc/docs/networking-for-mesos-managed-containers.md


Thanks,

Kapil Arya



Re: Review Request 38580: Added docker registry RemotePuller

2015-10-05 Thread Jojy Varghese

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38580/
---

(Updated Oct. 5, 2015, 9:03 p.m.)


Review request for mesos, Jie Yu, Timothy Chen, and Jiang Yan Xu.


Changes
---

Added simple puller test.


Repository: mesos


Description
---

Integrated remote puller with store. Tests will follow.


Diffs (updated)
-

  src/Makefile.am 8aa456611dd5405336dd7b0c19ba4a942ea1c805 
  src/slave/containerizer/provisioner/docker/local_puller.hpp 
4574e8a04663482625d7b54f765741f221ec13e0 
  src/slave/containerizer/provisioner/docker/local_puller.cpp 
4a0b7d11f013941084571f2d89d835a4668a3d8b 
  src/slave/containerizer/provisioner/docker/puller.hpp 
105b4e75439c2ad4c08e2fd364f288f1d39b9b59 
  src/slave/containerizer/provisioner/docker/puller.cpp 
cb05324689ffa26ce830b513e2d71b55517da3cb 
  src/slave/containerizer/provisioner/docker/registry_client.hpp 
9d5d15455192e2d75fe5cd7fa8755fb8cc67e185 
  src/slave/containerizer/provisioner/docker/registry_client.cpp 
c2040b48ea43fdb29766994c244273d3fa9ee3cd 
  src/slave/containerizer/provisioner/docker/remote_puller.hpp PRE-CREATION 
  src/slave/containerizer/provisioner/docker/remote_puller.cpp PRE-CREATION 
  src/slave/containerizer/provisioner/docker/store.cpp 
cbb67686d45513f0395a0cf1bc5c43cb4935adae 
  src/slave/flags.hpp f76f0f6a0c7a01c7f061a225d7f6ef52be0ee7b5 
  src/slave/flags.cpp 029aa1eb00e1aa3e92c2155925022c17fd905862 
  src/tests/containerizer/provisioner_docker_tests.cpp 
d895eb9d0723e52cff8b21ef2deeaef1911d019c 

Diff: https://reviews.apache.org/r/38580/diff/


Testing
---

make check.


Thanks,

Jojy Varghese



Re: Review Request 38963: Added initial draft of networking user-doc.

2015-10-05 Thread Kapil Arya

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38963/
---

(Updated Oct. 5, 2015, 4:44 p.m.)


Review request for mesos, Connor Doyle and Niklas Nielsen.


Bugs: MESOS-3561
https://issues.apache.org/jira/browse/MESOS-3561


Repository: mesos


Description
---

Added initial draft of networking user-doc.


Diffs (updated)
-

  docs/home.md 86320f6 
  docs/images/networking-architecture.png PRE-CREATION 
  docs/networking-for-mesos-managed-containers.md PRE-CREATION 

Diff: https://reviews.apache.org/r/38963/diff/


Testing
---

Markdown rendering at 
https://github.com/karya0/mesos/blob/net-user-doc/docs/networking-for-mesos-managed-containers.md


Thanks,

Kapil Arya



Review Request 39016: RegistryClient refactor: refactored lambdas

2015-10-05 Thread Jojy Varghese

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39016/
---

Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

RegistryClient refactor: refactored lambdas as per review comments.


Diffs
-

  src/slave/containerizer/provisioner/docker/registry_client.cpp 
c2040b48ea43fdb29766994c244273d3fa9ee3cd 

Diff: https://reviews.apache.org/r/39016/diff/


Testing
---

Make check.


Thanks,

Jojy Varghese



Review Request 39015: RegistryClient refactor: expanded abbreviated names.

2015-10-05 Thread Jojy Varghese

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39015/
---

Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

RegistryClient refactor: expanded abbreviated names.


Diffs
-

  src/slave/containerizer/provisioner/docker/registry_client.hpp 
9d5d15455192e2d75fe5cd7fa8755fb8cc67e185 
  src/slave/containerizer/provisioner/docker/registry_client.cpp 
c2040b48ea43fdb29766994c244273d3fa9ee3cd 

Diff: https://reviews.apache.org/r/39015/diff/


Testing
---

make check.


Thanks,

Jojy Varghese



Re: Review Request 38941: Moved structs outside RegistryClient

2015-10-05 Thread Jojy Varghese

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38941/
---

(Updated Oct. 5, 2015, 9:01 p.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Changes
---

RegistryClient refactor: moved structs outside RegistryClient


Repository: mesos


Description
---

Moved:
  - ManifestResponse
  - FilesystemLayerInfo


Diffs (updated)
-

  src/slave/containerizer/provisioner/docker/registry_client.hpp 
9d5d15455192e2d75fe5cd7fa8755fb8cc67e185 
  src/slave/containerizer/provisioner/docker/registry_client.cpp 
c2040b48ea43fdb29766994c244273d3fa9ee3cd 
  src/tests/containerizer/provisioner_docker_tests.cpp 
d895eb9d0723e52cff8b21ef2deeaef1911d019c 

Diff: https://reviews.apache.org/r/38941/diff/


Testing
---

make check.


Thanks,

Jojy Varghese



Re: Review Request 38963: Added initial draft of networking user-doc.

2015-10-05 Thread Kapil Arya

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38963/
---

(Updated Oct. 5, 2015, 3:52 p.m.)


Review request for mesos, Connor Doyle and Niklas Nielsen.


Changes
---

Addressed Nik's comments.


Bugs: MESOS-3561
https://issues.apache.org/jira/browse/MESOS-3561


Repository: mesos


Description
---

Added initial draft of networking user-doc.


Diffs (updated)
-

  docs/home.md f8c2b62 
  docs/images/networking-architecture.png PRE-CREATION 
  docs/networking-for-mesos-managed-containers.md PRE-CREATION 

Diff: https://reviews.apache.org/r/38963/diff/


Testing
---

Markdown rendering at 
https://github.com/karya0/mesos/blob/net-user-doc/docs/networking.md


Thanks,

Kapil Arya



Review Request 39013: RegistryClient refactor: Fixed comments style.

2015-10-05 Thread Jojy Varghese

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39013/
---

Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

RegistryClient refactor: Fixed comments style.


Diffs
-

  src/slave/containerizer/provisioner/docker/registry_client.hpp 
9d5d15455192e2d75fe5cd7fa8755fb8cc67e185 
  src/slave/containerizer/provisioner/docker/registry_client.cpp 
c2040b48ea43fdb29766994c244273d3fa9ee3cd 

Diff: https://reviews.apache.org/r/39013/diff/


Testing
---

make check.


Thanks,

Jojy Varghese



Review Request 39014: RegistryClient refactor: renamed ManifestResponse

2015-10-05 Thread Jojy Varghese

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39014/
---

Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

RegistryClient refactor: renamed ManifestResponse as per review comments.


Diffs
-

  src/slave/containerizer/provisioner/docker/registry_client.hpp 
9d5d15455192e2d75fe5cd7fa8755fb8cc67e185 
  src/slave/containerizer/provisioner/docker/registry_client.cpp 
c2040b48ea43fdb29766994c244273d3fa9ee3cd 
  src/tests/containerizer/provisioner_docker_tests.cpp 
d895eb9d0723e52cff8b21ef2deeaef1911d019c 

Diff: https://reviews.apache.org/r/39014/diff/


Testing
---

make check.


Thanks,

Jojy Varghese



Review Request 38989: Update docker-containerizer.md.

2015-10-05 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38989/
---

Review request for mesos and Timothy Chen.


Repository: mesos


Description
---

Update docker-containerizer.md.


Diffs
-

  docs/docker-containerizer.md 091a3ace48aca3b34ba5159f5146237d0bc7611c 

Diff: https://reviews.apache.org/r/38989/diff/


Testing
---


Thanks,

haosdent huang



Re: Review Request 38960: Add QuotaInfo Protobuf to CMake.

2015-10-05 Thread Bernd Mathiske

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38960/#review101454
---

Ship it!


Ship It!

- Bernd Mathiske


On Oct. 2, 2015, 9:51 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38960/
> ---
> 
> (Updated Oct. 2, 2015, 9:51 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, 
> and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> QuotaInfo was introduced here: https://reviews.apache.org/r/36908/
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 891f951f3107ece29b7923b7a3cc414e2ea56983 
> 
> Diff: https://reviews.apache.org/r/38960/diff/
> 
> 
> Testing
> ---
> 
> ```
> cmake .. # (OSX)
> make -j8 | grep quota
> ```
> 
> Confirmed that quota protobuf was built.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 37024: Exposes mesos version information in components.

2015-10-05 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/
---

(Updated Oct. 5, 2015, 8 a.m.)


Review request for mesos and Ben Mahler.


Changes
---

Add src/Makefile.am back because review board recover


Bugs: MESOS-1841
https://issues.apache.org/jira/browse/MESOS-1841


Repository: mesos


Description
---

Add an endpoint that exposes component version.


Diffs (updated)
-

  src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba 
  src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1 
  src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f 
  src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734 
  src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d 
  src/slave/main.cpp 364dc7fc7ab2e3cef01aea7267dafa014b60e2b9 
  src/version/version.hpp PRE-CREATION 
  src/version/version.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37024/diff/


Testing
---

Manual test result:

```
$ curl http://localhost:5050/version 2>/dev/null|jq .

{
  "version": "0.24.0",
  "build_user": "haosdent",
  "build_time": 1439702338,
  "build_date": "2015-08-16 13:18:58"
}
```


Thanks,

haosdent huang



Re: Review Request 38337: Extract gz file in fetcher.

2015-10-05 Thread Bernd Mathiske

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38337/#review101456
---



src/launcher/fetcher.cpp (line 70)


Why not use two separate names and avoid the variable update? Suggestion: 
pathWithoutExtension.



src/launcher/fetcher.cpp (line 71)


There are hundreds of occurences of "filename" and only 3 of "fileName". So 
my guess is that we should use "filename" here against your and my better 
judgement :-)



src/tests/fetcher_tests.cpp (line 573)


s/extract_file/extractedFile


- Bernd Mathiske


On Oct. 5, 2015, 12:39 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38337/
> ---
> 
> (Updated Oct. 5, 2015, 12:39 a.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, and Timothy Chen.
> 
> 
> Bugs: MESOS-3407
> https://issues.apache.org/jira/browse/MESOS-3407
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Extract gz file in fetcher.
> 
> 
> Diffs
> -
> 
>   src/launcher/fetcher.cpp 0f1533a0d7dc453e143a15e988d04ca6e55446ff 
>   src/tests/fetcher_tests.cpp 8d13352d0d3f8fb80581e7913c9416b543cfd009 
> 
> Diff: https://reviews.apache.org/r/38337/diff/
> 
> 
> Testing
> ---
> 
> sudo GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="FetcherTest.ExtractGzipFile" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 38160: Documented how to expedite event firing.

2015-10-05 Thread Bernd Mathiske

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38160/#review101457
---

Ship it!


Ship It!

- Bernd Mathiske


On Oct. 2, 2015, 8:13 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38160/
> ---
> 
> (Updated Oct. 2, 2015, 8:13 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/mesos-testing-patterns.md d0d92ff569012677043a03412462cf4384096ba9 
> 
> Diff: https://reviews.apache.org/r/38160/diff/
> 
> 
> Testing
> ---
> 
> doc rendered in Markdown
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 38337: Extract gz file in fetcher.

2015-10-05 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38337/
---

(Updated Oct. 5, 2015, 9:26 a.m.)


Review request for mesos, Adam B, Bernd Mathiske, and Timothy Chen.


Changes
---

Update according @bernd's reviews


Bugs: MESOS-3407
https://issues.apache.org/jira/browse/MESOS-3407


Repository: mesos


Description
---

Extract gz file in fetcher.


Diffs (updated)
-

  src/launcher/fetcher.cpp 0f1533a0d7dc453e143a15e988d04ca6e55446ff 
  src/tests/fetcher_tests.cpp 8d13352d0d3f8fb80581e7913c9416b543cfd009 

Diff: https://reviews.apache.org/r/38337/diff/


Testing
---

sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="FetcherTest.ExtractGzipFile" 
--verbose


Thanks,

haosdent huang



Re: Review Request 38961: Simplified resources initialization.

2015-10-05 Thread Bernd Mathiske

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38961/#review101458
---

Ship it!


Ship It!

- Bernd Mathiske


On Oct. 2, 2015, 10:10 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38961/
> ---
> 
> (Updated Oct. 2, 2015, 10:10 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Simplified resources initialization.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 31ca14621962f8851920b733ba0dec9f1afe8e79 
> 
> Diff: https://reviews.apache.org/r/38961/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Review Request 39034: Fixed "--help" output for "--master" in mesos-slave.

2015-10-05 Thread Neil Conway

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39034/
---

Review request for mesos and Adam B.


Bugs: MESOS-3591
https://issues.apache.org/jira/browse/MESOS-3591


Repository: mesos


Description
---

Fixed "--help" output for "--master" in mesos-slave.


Diffs
-

  src/slave/main.cpp 364dc7fc7ab2e3cef01aea7267dafa014b60e2b9 

Diff: https://reviews.apache.org/r/39034/diff/


Testing
---


Thanks,

Neil Conway



Re: Review Request 37993: Add explanatory comments for Allocator interface

2015-10-05 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37993/#review101566
---

Ship it!


Ship It!

- haosdent huang


On Oct. 6, 2015, 12:26 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37993/
> ---
> 
> (Updated Oct. 6, 2015, 12:26 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, and Michael Park.
> 
> 
> Bugs: MESOS-2224
> https://issues.apache.org/jira/browse/MESOS-2224
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add explanatory comments for Allocator interface
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp 8100f14220599247a340c919a03f29755b5349d8 
> 
> Diff: https://reviews.apache.org/r/37993/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>



Re: Review Request 39034: Fixed "--help" output for "--master" in mesos-slave.

2015-10-05 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39034/#review101567
---

Ship it!


Ship It!

- Guangya Liu


On 十月 6, 2015, 12:53 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39034/
> ---
> 
> (Updated 十月 6, 2015, 12:53 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-3591
> https://issues.apache.org/jira/browse/MESOS-3591
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed "--help" output for "--master" in mesos-slave.
> 
> 
> Diffs
> -
> 
>   src/slave/main.cpp 364dc7fc7ab2e3cef01aea7267dafa014b60e2b9 
> 
> Diff: https://reviews.apache.org/r/39034/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>



Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

2015-10-05 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38877/#review101568
---



src/slave/slave.cpp (line 96)


Should put it before `using mesos::slave::QoSController;`?



src/slave/slave.cpp (line 2389)


I think just print a number is not easy to understand when troubleshoot 
error happens.


- haosdent huang


On Sept. 30, 2015, 6:06 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38877/
> ---
> 
> (Updated Sept. 30, 2015, 6:06 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-3515
> https://issues.apache.org/jira/browse/MESOS-3515
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds the functionality for executors to `Subscribe` via the 
> `api/v1/executor` endpoint. It also stores a marker file as part of the 
> `Subscribe` call if framework `checkpointing` is enabled. This can then be 
> used by the agent when recovering to wait for reconnecting back with the 
> executor.
> 
> Since `Call::Update` is in progress as part of MESOS-3476. I have added a 
> `CHECK` if a executor tries to send a list of unacknowledged tasks as part of 
> the `Subscribe` call.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b 
>   src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476 
>   src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c 
> 
> Diff: https://reviews.apache.org/r/38877/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Re: Review Request 38570: Change documentation image links to absolute paths.

2015-10-05 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38570/#review101569
---


Patch looks great!

Reviews applied: [38570]

All tests passed.

- Mesos ReviewBot


On Oct. 5, 2015, 6:11 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38570/
> ---
> 
> (Updated Oct. 5, 2015, 6:11 p.m.)
> 
> 
> Review request for mesos, Adam B, Artem Harutyunyan, and Vinod Kone.
> 
> 
> Bugs: MESOS-3183
> https://issues.apache.org/jira/browse/MESOS-3183
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also removes extraneous `?raw=true` from the links.
> 
> 
> Diffs
> -
> 
>   docs/external-containerizer.md 96932189b74dce1ae28e0bd73d5543d1afaffb0b 
>   docs/fetcher-cache-internals.md e8a68d1230420d1afca61f92c1ab6be12a70dbf2 
>   docs/maintenance.md a5831ffa092a9ea6decbe2e640bae637c759a308 
>   docs/oversubscription.md 5a31b1ff7f003307817732a71f3b0a7c7d60cd24 
> 
> Diff: https://reviews.apache.org/r/38570/diff/
> 
> 
> Testing
> ---
> 
> Patched `Rakefile` to include images in the website (See JIRA for the patch).
> Then rendered with: https://github.com/mesosphere/mesos-website-container
> 
> Confirmed that images show up on the modified docs.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 37024: Exposes mesos version information in components.

2015-10-05 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/
---

(Updated Oct. 6, 2015, 1:11 a.m.)


Review request for mesos and Ben Mahler.


Changes
---

Update according to @marco and @bmahler reviews


Bugs: MESOS-1841
https://issues.apache.org/jira/browse/MESOS-1841


Repository: mesos


Description
---

Add an endpoint that exposes component version.


Diffs (updated)
-

  src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba 
  src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1 
  src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f 
  src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734 
  src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d 
  src/slave/main.cpp 364dc7fc7ab2e3cef01aea7267dafa014b60e2b9 
  src/version/version.hpp PRE-CREATION 
  src/version/version.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37024/diff/


Testing
---

Manual test result:

```
$ curl http://localhost:5050/version 2>/dev/null|jq .

{
  "version": "0.24.0",
  "build_user": "haosdent",
  "build_time": 1439702338,
  "build_date": "2015-08-16 13:18:58"
}
```


Thanks,

haosdent huang



Re: Review Request 37024: Exposes mesos version information in components.

2015-10-05 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/
---

(Updated Oct. 6, 2015, 1:14 a.m.)


Review request for mesos and Ben Mahler.


Changes
---

Update description


Bugs: MESOS-1841
https://issues.apache.org/jira/browse/MESOS-1841


Repository: mesos


Description (updated)
---

Add an endpoint exposes Apache Mesos build informations and version information.


Diffs
-

  src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba 
  src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1 
  src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f 
  src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734 
  src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d 
  src/slave/main.cpp 364dc7fc7ab2e3cef01aea7267dafa014b60e2b9 
  src/version/version.hpp PRE-CREATION 
  src/version/version.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37024/diff/


Testing
---

Manual test result:

```
$ curl http://localhost:5050/version 2>/dev/null|jq .

{
  "version": "0.24.0",
  "build_user": "haosdent",
  "build_time": 1439702338,
  "build_date": "2015-08-16 13:18:58"
}
```


Thanks,

haosdent huang



Re: Review Request 38873: Added helper functions for evolving old style executor messages to V1 Executor Events

2015-10-05 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38873/#review101573
---

Ship it!


Ship It!

- Guangya Liu


On 十月 5, 2015, 11:09 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38873/
> ---
> 
> (Updated 十月 5, 2015, 11:09 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-3480
> https://issues.apache.org/jira/browse/MESOS-3480
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change implements helper functions for evolving old style Executor 
> messages in `src/messages/messages.proto` to V1 Executor Events defined in 
> `include/mesos/v1/executor/executor.proto`. This is needed for MESOS-3480
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp 9babac3ccbfb2bf9a3989a3ae20cf96e5f3a2903 
>   src/internal/evolve.cpp 625706e089984b32d8298a2eacf2f8af2bca931e 
> 
> Diff: https://reviews.apache.org/r/38873/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Re: Review Request 39013: RegistryClient refactor: Fixed comments style.

2015-10-05 Thread Ben Mahler

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39013/#review101530
---


I'd like to ship these smaller fixes, but they depend on the large refactor 
patch and the patch for new functionality, so I can't apply the change :(

Please put the small cleanup patches at the front of your change so that they 
aren't blocked on your other patches, that way we can incrementally commit 
these :)

- Ben Mahler


On Oct. 5, 2015, 8:58 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39013/
> ---
> 
> (Updated Oct. 5, 2015, 8:58 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> RegistryClient refactor: Fixed comments style.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioner/docker/registry_client.hpp 
> 9d5d15455192e2d75fe5cd7fa8755fb8cc67e185 
>   src/slave/containerizer/provisioner/docker/registry_client.cpp 
> c2040b48ea43fdb29766994c244273d3fa9ee3cd 
> 
> Diff: https://reviews.apache.org/r/39013/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>



Re: Review Request 39013: RegistryClient refactor: Fixed comments style.

2015-10-05 Thread Jojy Varghese

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39013/
---

(Updated Oct. 5, 2015, 9:21 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

reordered patches.


Repository: mesos


Description
---

RegistryClient refactor: Fixed comments style.


Diffs (updated)
-

  src/slave/containerizer/provisioner/docker/registry_client.hpp 
9d5d15455192e2d75fe5cd7fa8755fb8cc67e185 
  src/slave/containerizer/provisioner/docker/registry_client.cpp 
c2040b48ea43fdb29766994c244273d3fa9ee3cd 

Diff: https://reviews.apache.org/r/39013/diff/


Testing
---

make check.


Thanks,

Jojy Varghese



Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

2015-10-05 Thread Timothy Chen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38901/#review101533
---



src/slave/containerizer/provisioner/docker/message.proto (line 79)


End all comments with period. And add a space in the beginning:

// JSON Web key.


- Timothy Chen


On Oct. 5, 2015, 7:21 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38901/
> ---
> 
> (Updated Oct. 5, 2015, 7:21 p.m.)
> 
> 
> Review request for mesos, Jojy Varghese and Timothy Chen.
> 
> 
> Bugs: MESOS-2972
> https://issues.apache.org/jira/browse/MESOS-2972
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Serialize Docker Image Spec as Protobuf
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 891f951f3107ece29b7923b7a3cc414e2ea56983 
>   src/Makefile.am f060998bb08cdb071db5a2e85dfbad805dab45e9 
>   src/slave/containerizer/provisioner/docker/message.proto 
> bbac2e6c1f40a7ca3f9227baca56a44cd43f58c6 
>   src/slave/containerizer/provisioner/docker/spec.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/spec.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> d895eb9d0723e52cff8b21ef2deeaef1911d019c 
> 
> Diff: https://reviews.apache.org/r/38901/diff/
> 
> 
> Testing
> ---
> 
> make check (ubuntu 14.04 + clang++-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>



Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

2015-10-05 Thread Michael Park


> On Sept. 28, 2015, 9:11 a.m., Jan Schlicht wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, line 762
> > 
> >
> > Because this code has been changed from a constructor to a function, we 
> > can do better than calling `ABORT` here. We can change the function 
> > signature to return a `Try` and call `Error` here instead of 
> > `ABORT`. For example see the `write` function in line 55.
> > 
> > The function signature would change to
> > `inline Try protobuf(const google::protobuf::Message& message)`
> 
> Klaus Ma wrote:
> Got your point :).
> Just one concern on how to use it? We did not handle its result if failed 
> in `src`; personally, this's a kind of code practice to avoid undefined 
> protobuf field type. Anyway, I'll update accordingly if necessary.
> 
> Jan Schlicht wrote:
> Well, unfortunately this change means that the code that is using this 
> function has to be changed to handle the error cases. This means checking if 
> the `Try<>` contains a value or an error and react accordingly.
> 
> Klaus Ma wrote:
> Did you check the code diff of #38335? In #38335, any suggestion on the 
> function that return void; those function did not expect json parsing will 
> fail. Personally, it's a bit overkill to re-implement them for json paring 
> error handling which are not expect failed. 
> 
> @alex-mesos, @mcypark, what's your suggestion?

My suggestion here is to leave out the `default:` case since all alternatives 
are being handled. This was discussed in 
[MESOS-26664](https://issues.apache.org/jira/browse/MESOS-2664), and here is an 
[example](https://github.com/apache/mesos/blob/7f352ef886f3116e4bef23b235d87b3182354908/src/common/http.cpp#L53).


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38342/#review100794
---


On Oct. 4, 2015, 11:29 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38342/
> ---
> 
> (Updated Oct. 4, 2015, 11:29 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Michael Park, and Jan Schlicht.
> 
> 
> Bugs: MESOS-3405
> https://issues.apache.org/jira/browse/MESOS-3405
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently, `stout/protobuf.hpp` provides a `JSON::Protobuf` utility which 
> converts a `google::protobuf::Message` into a `JSON::Object`.
> We should add the support for `google::protobuf::RepeatedPtrField` by 
> introducing overloaded functions.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 2285ce9 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 68328a2 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h 8ebb798 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc 34eb6d0 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto 920f5c9 
> 
> Diff: https://reviews.apache.org/r/38342/diff/
> 
> 
> Testing
> ---
> 
> cd 3rdparty/libprocess/3rdparty/stout
> ./boostrap
> ./configure
> make
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>



Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2015-10-05 Thread Alex Clemmer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/
---

(Updated Oct. 5, 2015, 10:12 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

Windows: Added dirent compat code for non-Unix systems.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
50e35f43d87c69a83a9e7d039d1881404ea8be38 

Diff: https://reviews.apache.org/r/39019/diff/


Testing
---


Thanks,

Alex Clemmer



Re: Review Request 38579: Refactored registry client

2015-10-05 Thread Jojy Varghese

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38579/
---

(Updated Oct. 5, 2015, 9:23 p.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Changes
---

Reordered patches.


Repository: mesos


Description
---

- Moved ManifestResponse struct from RegistryClient to namespace.
- Cleanup


Diffs (updated)
-

  src/slave/containerizer/provisioner/docker/registry_client.hpp 
9d5d15455192e2d75fe5cd7fa8755fb8cc67e185 
  src/slave/containerizer/provisioner/docker/registry_client.cpp 
c2040b48ea43fdb29766994c244273d3fa9ee3cd 
  src/tests/containerizer/provisioner_docker_tests.cpp 
d895eb9d0723e52cff8b21ef2deeaef1911d019c 

Diff: https://reviews.apache.org/r/38579/diff/


Testing
---

make check.


Thanks,

Jojy Varghese



Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2015-10-05 Thread Alex Clemmer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/
---

Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

Windows: Added dirent compat code for non-Unix systems.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
50e35f43d87c69a83a9e7d039d1881404ea8be38 

Diff: https://reviews.apache.org/r/39019/diff/


Testing
---


Thanks,

Alex Clemmer



Re: Review Request 39018: Added JSON parsing for Resources.

2015-10-05 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39018/
---

(Updated Oct. 5, 2015, 9:38 p.m.)


Review request for mesos, Adam B, Alexander Rukletsov, Jie Yu, and Michael Park.


Changes
---

Updated description.


Bugs: MESOS-2467
https://issues.apache.org/jira/browse/MESOS-2467


Repository: mesos


Description (updated)
---

This includes code changes necessary for JSON parsing of Resources. 
Documentation changes will be posted soon in another review.


Diffs
-

  include/mesos/resources.hpp 6c3a065945eb56dc88df9c977e5ca11d4cbcbf61 
  src/common/resources.cpp 601388c35a1bff37c58e753d1870d53b8d0af2d1 
  src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697 
  src/v1/resources.cpp dc868903472f8f3a1ddc56092e3f8f81d953ce39 

Diff: https://reviews.apache.org/r/39018/diff/


Testing
---

`make check`


Thanks,

Greg Mann



Re: Review Request 39013: RegistryClient refactor: Fixed comments style.

2015-10-05 Thread Ben Mahler


> On Oct. 5, 2015, 9:07 p.m., Ben Mahler wrote:
> > I'd like to ship these smaller fixes, but they depend on the large refactor 
> > patch and the patch for new functionality, so I can't apply the change :(
> > 
> > Please put the small cleanup patches at the front of your change so that 
> > they aren't blocked on your other patches, that way we can incrementally 
> > commit these :)

s/change/chain/


- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39013/#review101530
---


On Oct. 5, 2015, 8:58 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39013/
> ---
> 
> (Updated Oct. 5, 2015, 8:58 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> RegistryClient refactor: Fixed comments style.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioner/docker/registry_client.hpp 
> 9d5d15455192e2d75fe5cd7fa8755fb8cc67e185 
>   src/slave/containerizer/provisioner/docker/registry_client.cpp 
> c2040b48ea43fdb29766994c244273d3fa9ee3cd 
> 
> Diff: https://reviews.apache.org/r/39013/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>



Review Request 39018: Added JSON parsing for Resources.

2015-10-05 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39018/
---

Review request for mesos, Adam B, Alexander Rukletsov, Jie Yu, and Michael Park.


Bugs: MESOS-2467
https://issues.apache.org/jira/browse/MESOS-2467


Repository: mesos


Description
---

Added JSON parsing for Resources.


Diffs (updated)
-

  include/mesos/resources.hpp 6c3a065945eb56dc88df9c977e5ca11d4cbcbf61 
  src/common/resources.cpp 601388c35a1bff37c58e753d1870d53b8d0af2d1 
  src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697 
  src/v1/resources.cpp dc868903472f8f3a1ddc56092e3f8f81d953ce39 

Diff: https://reviews.apache.org/r/39018/diff/


Testing (updated)
---

`make check`


Thanks,

Greg Mann



Re: Review Request 39018: Added JSON parsing for Resources.

2015-10-05 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39018/
---

(Updated Oct. 5, 2015, 9:51 p.m.)


Review request for mesos, Adam B, Alexander Rukletsov, Jie Yu, and Michael Park.


Changes
---

Copied changes to v1/resources.hpp.


Bugs: MESOS-2467
https://issues.apache.org/jira/browse/MESOS-2467


Repository: mesos


Description
---

This includes code changes necessary for JSON parsing of Resources. 
Documentation changes will be posted soon in another review.


Diffs (updated)
-

  include/mesos/resources.hpp 6c3a065945eb56dc88df9c977e5ca11d4cbcbf61 
  include/mesos/v1/resources.hpp fe8925ac851b74d1b37919f00afc7ed816f47ea5 
  src/common/resources.cpp 601388c35a1bff37c58e753d1870d53b8d0af2d1 
  src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697 
  src/v1/resources.cpp dc868903472f8f3a1ddc56092e3f8f81d953ce39 

Diff: https://reviews.apache.org/r/39018/diff/


Testing
---

`make check`


Thanks,

Greg Mann



Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

2015-10-05 Thread Michael Park


> On Sept. 29, 2015, 4:17 p.m., Alexander Rukletsov wrote:
> > One high level suggestion.
> > 
> > After looking at our http code, I realized that we use the same pattern 
> > again and again, for example:
> > ```
> > JSON::Array array;
> > array.values.reserve(status.network_infos().size()); // MESOS-2353.
> > foreach (const NetworkInfo& info, status.network_infos()) {
> >   array.values.push_back(model(info));
> > }
> > object.values["network_infos"] = std::move(array);
> > ```
> > We cannot use newly added `JSON::protobuf()` here, because a different way 
> > for rendering JSON from protobuf is used. Without digging deep inside, I 
> > know three ways how we create a `JSON` out of a proto in our codebase:
> > - wrap in `JSON::Protobuf()` for individual messages;
> > - wrap in one of the `model()` family functions;
> > - pass as it is for built-in types.
> > 
> > The proposed conversion function covers one of the possible ways. How about 
> > add one more convertion? Something like:
> > ```
> > template 
> > Array protobuf(const google::protobuf::RepeatedPtrField& repeated,
> > const lambda::function(const T&)>& converter)
> > {
> >   static_assert(std::is_convertible::value,
> > "T must be a google::protobuf::Message");
> >   JSON::Array array;
> >   array.values.reserve(repeated.size());
> >   foreach (const T& elem, repeated) {
> > array.values.push_back(converter(elem));
> >   }
> >   
> >   return array;
> > }
> > ```
> > 
> > Then the snippet above could be rewritten as:
> > ```
> > object.values["network_infos"] = 
> > std::move(JSON::protobuf(status.network_infos(), [](const NetworkInfo& 
> > info) { return model(info); });
> > ```
> > 
> > A further improvement would be to accept any iterable collection, not only 
> > `RepeatedPtrField<>`, for example `hashset`.
> > 
> > What do you think?
> 
> Klaus Ma wrote:
> Awesome! I've also try similar proposal, but failed when `function` 
> converting with `template`; your suggestion using lambda is great!
> For the `hashset`, I'd suggest to address it when we have such case in 
> our code :).
> 
> I'll also address your comments above.
> 
> Alexander Rukletsov wrote:
> We do have such cases in our codebase ; ). Here are a few as an example:
> - https://github.com/apache/mesos/blob/master/src/master/http.cpp#L217
> - https://github.com/apache/mesos/blob/master/src/master/http.cpp#L229
> 
> Michael Park wrote:
> I like the idea of taking a projection function as an argument, but let's 
> do it as a separate ticket to keep the scope of this review narrow.
> 
> Klaus Ma wrote:
> I'll log a new ticket to trace projection fuction part.
> 
> Klaus Ma wrote:
> MESOS-3580 is logged to trace this requirement, @alex-mesos, would you 
> shepherd it?
> 
> Alexander Rukletsov wrote:
> Great, thanks! I'm not a Mesos committer, hence I cannot shepherd, but I 
> would love to review and help out with that! Maybe @MPark will agree to 
> shepherd?

@klaus1982: Thanks for filing MESOS-3580. I think we'll probably hold off 
working on that ticket to see if it'll still be useful after the work around 
speeding up JSON parsing/streaming.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38342/#review100964
---


On Oct. 4, 2015, 11:29 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38342/
> ---
> 
> (Updated Oct. 4, 2015, 11:29 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Michael Park, and Jan Schlicht.
> 
> 
> Bugs: MESOS-3405
> https://issues.apache.org/jira/browse/MESOS-3405
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently, `stout/protobuf.hpp` provides a `JSON::Protobuf` utility which 
> converts a `google::protobuf::Message` into a `JSON::Object`.
> We should add the support for `google::protobuf::RepeatedPtrField` by 
> introducing overloaded functions.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 2285ce9 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 68328a2 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h 8ebb798 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc 34eb6d0 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto 920f5c9 
> 
> Diff: https://reviews.apache.org/r/38342/diff/
> 
> 
> Testing
> ---
> 
> cd 3rdparty/libprocess/3rdparty/stout
> ./boostrap
> ./configure
> make
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>



Re: Review Request 38875: Moved the framework/executor exists check before Subscribe call in Agent

2015-10-05 Thread Isabel Jimenez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38875/#review101562
---



src/slave/http.cpp (line 298)


Could you please change the syntax for every case to be consistent with `: 
{` through this switch?


- Isabel Jimenez


On Sept. 30, 2015, 3:39 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38875/
> ---
> 
> (Updated Sept. 30, 2015, 3:39 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-3515
> https://issues.apache.org/jira/browse/MESOS-3515
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactored the `api/v1/executor` endpoint to do executor/framework 
> exists(`NULL`) checks before `Subscribe` since the slave explicitly knows the 
> `frameworkID/executorID` when it launches it. Also modified tests to first 
> spawn a dummy `cat` process and then make a `Subscribe` call to ensure that 
> the Agent knows about the Framework/Executor and not reject it via 
> `BadRequest` due to the `NULL` checks.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b 
>   src/tests/executor_http_api_tests.cpp 
> 31938c295367686d444f8a8aa2c43d2696b481ec 
> 
> Diff: https://reviews.apache.org/r/38875/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Re: Review Request 36180: Avoid multi writers write to same file in PortMappingIsolatorTests.

2015-10-05 Thread Cong Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36180/#review101563
---


Or simply use 'tee -a' instead? Since it should not append anything to that 
file when nc receives nothing.

- Cong Wang


On Oct. 3, 2015, 4:52 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36180/
> ---
> 
> (Updated Oct. 3, 2015, 4:52 p.m.)
> 
> 
> Review request for mesos, Adam B, Ian Downes, Jie Yu, and Michael Park.
> 
> 
> Bugs: MESOS-2765
> https://issues.apache.org/jira/browse/MESOS-2765
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Avoid multi writers write to same file in PortMappingIsolatorTests.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/port_mapping_tests.cpp 
> feca2043503436ac9abac6017ae9059b3fcbed21 
> 
> Diff: https://reviews.apache.org/r/36180/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 38932: Kill health check external command process and continue check after timeout.

2015-10-05 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38932/#review101564
---


Patch looks great!

Reviews applied: [38932]

All tests passed.

- Mesos ReviewBot


On Oct. 5, 2015, 10:18 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38932/
> ---
> 
> (Updated Oct. 5, 2015, 10:18 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3479
> https://issues.apache.org/jira/browse/MESOS-3479
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Kill health check external command process and continue check after timeout.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp 1e4901335854c49e46cd7b132e79ccb11cd72ade 
>   src/health-check/main.cpp 97b25716335ec5719c1100bd73d06b7fc98036c9 
>   src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390 
>   src/tests/health_check_tests.cpp ff6275b19206b49eacb6761f3aeb58dd87651ade 
> 
> Diff: https://reviews.apache.org/r/38932/diff/
> 
> 
> Testing
> ---
> 
> GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="HealthCheckTest.CheckCommandTimeout" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 37993: Add explanatory comments for Allocator interface

2015-10-05 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37993/
---

(Updated 十月 6, 2015, 12:26 a.m.)


Review request for mesos, Adam B, Alexander Rukletsov, and Michael Park.


Bugs: MESOS-2224
https://issues.apache.org/jira/browse/MESOS-2224


Repository: mesos


Description
---

Add explanatory comments for Allocator interface


Diffs (updated)
-

  include/mesos/master/allocator.hpp 8100f14220599247a340c919a03f29755b5349d8 

Diff: https://reviews.apache.org/r/37993/diff/


Testing
---


Thanks,

Guangya Liu



Re: Review Request 38963: Added initial draft of networking user-doc.

2015-10-05 Thread Kapil Arya


> On Oct. 5, 2015, 12:15 p.m., Niklas Nielsen wrote:
> > docs/networking.md, lines 95-96
> > 
> >
> > (And makes it to the scheduler :) Is that worth mentioning here?

It's mentioned in the next bullet point :).


> On Oct. 5, 2015, 12:15 p.m., Niklas Nielsen wrote:
> > docs/networking.md, line 102
> > 
> >
> > Would it make sense to enumerate failure modes here? (If the scheduler 
> > fails, if the master fails, ...)

It's a implementation specific concern. Not sure if/how we should capture it.


> On Oct. 5, 2015, 12:15 p.m., Niklas Nielsen wrote:
> > docs/networking.md, line 113
> > 
> >
> > Let's ask the community; but I'd assume that we would avoid references 
> > to repos which are not hosted by github.com/apache/mesos or 
> > github.com/mesos - maybe it is fine, but let's make sure

Will send an email shortly.


> On Oct. 5, 2015, 12:15 p.m., Niklas Nielsen wrote:
> > docs/networking.md, line 165
> > 
> >
> > Are those hard tabs?

Nope, just spaces.


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38963/#review101375
---


On Oct. 5, 2015, 3:52 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38963/
> ---
> 
> (Updated Oct. 5, 2015, 3:52 p.m.)
> 
> 
> Review request for mesos, Connor Doyle and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3561
> https://issues.apache.org/jira/browse/MESOS-3561
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added initial draft of networking user-doc.
> 
> 
> Diffs
> -
> 
>   docs/home.md f8c2b62 
>   docs/images/networking-architecture.png PRE-CREATION 
>   docs/networking-for-mesos-managed-containers.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38963/diff/
> 
> 
> Testing
> ---
> 
> Markdown rendering at 
> https://github.com/karya0/mesos/blob/net-user-doc/docs/networking.md
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>



Re: Review Request 38919: Validation of Docker Image Manifests

2015-10-05 Thread Gilbert Song

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38919/
---

(Updated Oct. 5, 2015, 1:51 p.m.)


Review request for mesos, Jojy Varghese and Timothy Chen.


Bugs: MESOS-3099
https://issues.apache.org/jira/browse/MESOS-3099


Repository: mesos


Description
---

Validation of Docker Image Manifests


Diffs (updated)
-

  src/slave/containerizer/provisioner/docker/spec.hpp PRE-CREATION 
  src/slave/containerizer/provisioner/docker/spec.cpp PRE-CREATION 
  src/tests/containerizer/provisioner_docker_tests.cpp 
d895eb9d0723e52cff8b21ef2deeaef1911d019c 

Diff: https://reviews.apache.org/r/38919/diff/


Testing
---

make check (Ubuntu14.04 + clang++-3.6)


Thanks,

Gilbert Song



Review Request 39017: RegistryClient refactor: encapsulated Manifest

2015-10-05 Thread Jojy Varghese

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39017/
---

Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

Wrapped Manifest with ManifestResponse. getManifest returns the encapsulated 
ManifestResponse.


Diffs (updated)
-

  src/slave/containerizer/provisioner/docker/registry_client.hpp 
9d5d15455192e2d75fe5cd7fa8755fb8cc67e185 
  src/slave/containerizer/provisioner/docker/registry_client.cpp 
c2040b48ea43fdb29766994c244273d3fa9ee3cd 
  src/tests/containerizer/provisioner_docker_tests.cpp 
d895eb9d0723e52cff8b21ef2deeaef1911d019c 

Diff: https://reviews.apache.org/r/39017/diff/


Testing
---

make check.


Thanks,

Jojy Varghese



Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

2015-10-05 Thread Isabel Jimenez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38877/#review101565
---

Ship it!


Ship It!

- Isabel Jimenez


On Sept. 30, 2015, 6:06 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38877/
> ---
> 
> (Updated Sept. 30, 2015, 6:06 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-3515
> https://issues.apache.org/jira/browse/MESOS-3515
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds the functionality for executors to `Subscribe` via the 
> `api/v1/executor` endpoint. It also stores a marker file as part of the 
> `Subscribe` call if framework `checkpointing` is enabled. This can then be 
> used by the agent when recovering to wait for reconnecting back with the 
> executor.
> 
> Since `Call::Update` is in progress as part of MESOS-3476. I have added a 
> `CHECK` if a executor tries to send a list of unacknowledged tasks as part of 
> the `Subscribe` call.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b 
>   src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476 
>   src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c 
> 
> Diff: https://reviews.apache.org/r/38877/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Review Request 39025: Fixed a flaky oversubscription test.

2015-10-05 Thread Ben Mahler

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39025/
---

Review request for mesos, Anand Mazumdar and Jie Yu.


Bugs: MESOS-3577
https://issues.apache.org/jira/browse/MESOS-3577


Repository: mesos


Description
---

The expectation needs to be added before it becomes possible
for the estimation to make its way to the master.


Diffs
-

  src/tests/oversubscription_tests.cpp 561e9220f7b67da26a7b8f14311926d5079820e1 

Diff: https://reviews.apache.org/r/39025/diff/


Testing
---

Ran in repetition.


Thanks,

Ben Mahler



Re: Review Request 39025: Fixed a flaky oversubscription test.

2015-10-05 Thread Anand Mazumdar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39025/#review101545
---

Ship it!


LGTM !

- Anand Mazumdar


On Oct. 5, 2015, 10:25 p.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39025/
> ---
> 
> (Updated Oct. 5, 2015, 10:25 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Jie Yu.
> 
> 
> Bugs: MESOS-3577
> https://issues.apache.org/jira/browse/MESOS-3577
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The expectation needs to be added before it becomes possible
> for the estimation to make its way to the master.
> 
> 
> Diffs
> -
> 
>   src/tests/oversubscription_tests.cpp 
> 561e9220f7b67da26a7b8f14311926d5079820e1 
> 
> Diff: https://reviews.apache.org/r/39025/diff/
> 
> 
> Testing
> ---
> 
> Ran in repetition.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>



Re: Review Request 38606: Added ability to check if the streaming decoder is writing to a body pipe.

2015-10-05 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38606/#review101549
---

Ship it!


Ship It!

- Jie Yu


On Sept. 22, 2015, 6:18 a.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38606/
> ---
> 
> (Updated Sept. 22, 2015, 6:18 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is necessary to know when the decoder has finished writing the latest 
> response, and is needed for the subsequent patch that adds an 
> http::Connection.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/decoder.hpp 
> 67a5135f302153e376e8dfe8db82aa0b15449389 
>   3rdparty/libprocess/src/tests/decoder_tests.cpp 
> 6994fa96d33209f9a367b8c3bb09b0d050023fad 
> 
> Diff: https://reviews.apache.org/r/38606/diff/
> 
> 
> Testing
> ---
> 
> Updated the streaming tests.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>



Re: Review Request 38873: Added helper functions for evolving old style executor messages to V1 Executor Events

2015-10-05 Thread Isabel Jimenez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38873/#review101550
---


LGTM just small nit from standing review issue

- Isabel Jimenez


On Sept. 30, 2015, 3:38 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38873/
> ---
> 
> (Updated Sept. 30, 2015, 3:38 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-3480
> https://issues.apache.org/jira/browse/MESOS-3480
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change implements helper functions for evolving old style Executor 
> messages in `src/messages/messages.proto` to V1 Executor Events defined in 
> `include/mesos/v1/executor/executor.proto`. This is needed for MESOS-3480
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp 9babac3ccbfb2bf9a3989a3ae20cf96e5f3a2903 
>   src/internal/evolve.cpp 625706e089984b32d8298a2eacf2f8af2bca931e 
> 
> Diff: https://reviews.apache.org/r/38873/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Re: Review Request 38873: Added helper functions for evolving old style executor messages to V1 Executor Events

2015-10-05 Thread Anand Mazumdar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38873/
---

(Updated Oct. 5, 2015, 11:09 p.m.)


Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.


Changes
---

Removed the erroneous declaration as per review comments


Bugs: MESOS-3480
https://issues.apache.org/jira/browse/MESOS-3480


Repository: mesos


Description
---

This change implements helper functions for evolving old style Executor 
messages in `src/messages/messages.proto` to V1 Executor Events defined in 
`include/mesos/v1/executor/executor.proto`. This is needed for MESOS-3480


Diffs (updated)
-

  src/internal/evolve.hpp 9babac3ccbfb2bf9a3989a3ae20cf96e5f3a2903 
  src/internal/evolve.cpp 625706e089984b32d8298a2eacf2f8af2bca931e 

Diff: https://reviews.apache.org/r/38873/diff/


Testing
---

make check


Thanks,

Anand Mazumdar



Re: Review Request 37996: Added property manager

2015-10-05 Thread Ben Mahler

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37996/#review101552
---



3rdparty/libprocess/3rdparty/stout/include/stout/inheritancetree.hpp (lines 30 
- 52)


Hm.. what will this abstraction be used for? I have a hard time 
understanding what this is abstracting, is this general enough to belong in 
stout?


- Ben Mahler


On Oct. 5, 2015, 4:02 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37996/
> ---
> 
> (Updated Oct. 5, 2015, 4:02 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3231
> https://issues.apache.org/jira/browse/MESOS-3231
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduces the `InheritanceTree` class which allows to create a tree where 
> nodes can be tag with some property. This property is then inherited by 
> children nodes.
> 
> Two behaviors are implemented, overriding, i.e. Adding a property to the 
> child node of another node with a property already will result in the 
> ancestor property being lost. The second behavior, accumulating, takes a 
> function and accumulates
> properties of all ancestors.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 
> 76e1674e08bbe65a4fdf86731823a61f231d6d12 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 9e9c3119ad18f4cbc70c70095c71dc4fd19553df 
>   3rdparty/libprocess/3rdparty/stout/include/stout/inheritancetree.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
> 94292f8a46ec31bbaf6e52f48109322bbe123f70 
>   3rdparty/libprocess/3rdparty/stout/tests/inheritancetree_tests.cpp 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37996/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>



Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

2015-10-05 Thread Timothy Chen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38901/#review101553
---



src/tests/containerizer/provisioner_docker_tests.cpp (line 357)


Add a comment in the code to say why this is invalid.


- Timothy Chen


On Oct. 5, 2015, 7:21 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38901/
> ---
> 
> (Updated Oct. 5, 2015, 7:21 p.m.)
> 
> 
> Review request for mesos, Jojy Varghese and Timothy Chen.
> 
> 
> Bugs: MESOS-2972
> https://issues.apache.org/jira/browse/MESOS-2972
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Serialize Docker Image Spec as Protobuf
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 891f951f3107ece29b7923b7a3cc414e2ea56983 
>   src/Makefile.am f060998bb08cdb071db5a2e85dfbad805dab45e9 
>   src/slave/containerizer/provisioner/docker/message.proto 
> bbac2e6c1f40a7ca3f9227baca56a44cd43f58c6 
>   src/slave/containerizer/provisioner/docker/spec.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/spec.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> d895eb9d0723e52cff8b21ef2deeaef1911d019c 
> 
> Diff: https://reviews.apache.org/r/38901/diff/
> 
> 
> Testing
> ---
> 
> make check (ubuntu 14.04 + clang++-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>



Re: Review Request 36180: Avoid multi writers write to same file in PortMappingIsolatorTests.

2015-10-05 Thread Benjamin Mahler
Jie or Ian, can you shepherd this?

On Sat, Oct 3, 2015 at 5:25 PM, Mesos ReviewBot 
wrote:

>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36180/#review101422
> ---
>
>
> Patch looks great!
>
> Reviews applied: [36180]
>
> All tests passed.
>
> - Mesos ReviewBot
>
>
> On Oct. 3, 2015, 4:52 p.m., haosdent huang wrote:
> >
> > ---
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/36180/
> > ---
> >
> > (Updated Oct. 3, 2015, 4:52 p.m.)
> >
> >
> > Review request for mesos, Adam B, Ian Downes, Jie Yu, and Michael Park.
> >
> >
> > Bugs: MESOS-2765
> > https://issues.apache.org/jira/browse/MESOS-2765
> >
> >
> > Repository: mesos
> >
> >
> > Description
> > ---
> >
> > Avoid multi writers write to same file in PortMappingIsolatorTests.
> >
> >
> > Diffs
> > -
> >
> >   src/tests/containerizer/port_mapping_tests.cpp
> feca2043503436ac9abac6017ae9059b3fcbed21
> >
> > Diff: https://reviews.apache.org/r/36180/diff/
> >
> >
> > Testing
> > ---
> >
> >
> > Thanks,
> >
> > haosdent huang
> >
> >
>
>


Re: Review Request 38646: Added WIP note for Executor endpoint in changelog

2015-10-05 Thread Isabel Jimenez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38646/#review101544
---

Ship it!


Ship It!

- Isabel Jimenez


On Sept. 25, 2015, 12:09 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38646/
> ---
> 
> (Updated Sept. 25, 2015, 12:09 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> WIP Note for the 0.25 release that `api/v1/executor` endpoint is incomplete.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 7a0c813847590e8e384054551381e4f13f5c67d2 
> 
> Diff: https://reviews.apache.org/r/38646/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Re: Review Request 38608: Added an http::Connection for connection re-use and pipelining.

2015-10-05 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38608/#review101548
---

Ship it!


Ship It!

- Jie Yu


On Oct. 3, 2015, 12:04 a.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38608/
> ---
> 
> (Updated Oct. 3, 2015, 12:04 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-3332
> https://issues.apache.org/jira/browse/MESOS-3332
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In order to support connection re-use and pipelining of requests on a shared 
> connection, this introduces the notion of an http::Connection.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/http.hpp 
> ba3f0bc7df33795e332c374fbad04106b9d56416 
>   3rdparty/libprocess/src/http.cpp d9925333f25491f92495bf11315237f54a0a2015 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> c380f356548cf9f5491044bccabcd9c66ad5f55a 
> 
> Diff: https://reviews.apache.org/r/38608/diff/
> 
> 
> Testing
> ---
> 
> Added tests.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>



Re: Review Request 38608: Added an http::Connection for connection re-use and pipelining.

2015-10-05 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38608/#review101540
---


LGTM! Nice tests!


3rdparty/libprocess/src/http.cpp (line 783)


s/`socket_`/`_socket`/?

underscore suffix makes it more look like a member (Google style).



3rdparty/libprocess/src/http.cpp (line 979)


Owned, instead of a raw pointer? Save a 'delete' in `~Data()`.



3rdparty/libprocess/src/tests/http_tests.cpp (line 721)


Remove one extra blank line here.


- Jie Yu


On Oct. 3, 2015, 12:04 a.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38608/
> ---
> 
> (Updated Oct. 3, 2015, 12:04 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-3332
> https://issues.apache.org/jira/browse/MESOS-3332
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In order to support connection re-use and pipelining of requests on a shared 
> connection, this introduces the notion of an http::Connection.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/http.hpp 
> ba3f0bc7df33795e332c374fbad04106b9d56416 
>   3rdparty/libprocess/src/http.cpp d9925333f25491f92495bf11315237f54a0a2015 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> c380f356548cf9f5491044bccabcd9c66ad5f55a 
> 
> Diff: https://reviews.apache.org/r/38608/diff/
> 
> 
> Testing
> ---
> 
> Added tests.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>



Re: Review Request 38873: Added helper functions for evolving old style executor messages to V1 Executor Events

2015-10-05 Thread Isabel Jimenez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38873/#review101551
---

Ship it!


Ship It!

- Isabel Jimenez


On Oct. 5, 2015, 11:09 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38873/
> ---
> 
> (Updated Oct. 5, 2015, 11:09 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-3480
> https://issues.apache.org/jira/browse/MESOS-3480
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change implements helper functions for evolving old style Executor 
> messages in `src/messages/messages.proto` to V1 Executor Events defined in 
> `include/mesos/v1/executor/executor.proto`. This is needed for MESOS-3480
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp 9babac3ccbfb2bf9a3989a3ae20cf96e5f3a2903 
>   src/internal/evolve.cpp 625706e089984b32d8298a2eacf2f8af2bca931e 
> 
> Diff: https://reviews.apache.org/r/38873/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Re: Review Request 38608: Added an http::Connection for connection re-use and pipelining.

2015-10-05 Thread Ben Mahler


> On Oct. 5, 2015, 11 p.m., Jie Yu wrote:
> > 3rdparty/libprocess/src/http.cpp, line 783
> > 
> >
> > s/`socket_`/`_socket`/?
> > 
> > underscore suffix makes it more look like a member (Google style).

Agreed, I think we need to do a sweep though because the majority of our code 
still uses underscore as ' (prime): socket'


- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38608/#review101540
---


On Oct. 3, 2015, 12:04 a.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38608/
> ---
> 
> (Updated Oct. 3, 2015, 12:04 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-3332
> https://issues.apache.org/jira/browse/MESOS-3332
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In order to support connection re-use and pipelining of requests on a shared 
> connection, this introduces the notion of an http::Connection.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/http.hpp 
> ba3f0bc7df33795e332c374fbad04106b9d56416 
>   3rdparty/libprocess/src/http.cpp d9925333f25491f92495bf11315237f54a0a2015 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> c380f356548cf9f5491044bccabcd9c66ad5f55a 
> 
> Diff: https://reviews.apache.org/r/38608/diff/
> 
> 
> Testing
> ---
> 
> Added tests.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>



Re: Review Request 38874: Refactored executor struct in Agent for the Executor HTTP API

2015-10-05 Thread Anand Mazumdar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38874/
---

(Updated Oct. 6, 2015, 2:22 a.m.)


Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.


Changes
---

Review comments


Bugs: MESOS-3480
https://issues.apache.org/jira/browse/MESOS-3480


Repository: mesos


Description
---

This change refactors the Executor struct on Agent and adds support for 
Executors to connect via the `api/v1/executor` endpoint on Agent. This is 
similar to the change done in Master for the Scheduler HTTP API.


Diffs (updated)
-

  src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476 
  src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c 

Diff: https://reviews.apache.org/r/38874/diff/


Testing
---

make check


Thanks,

Anand Mazumdar



Re: Review Request 37023: Add an endpoint that exposes component flags.

2015-10-05 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/
---

(Updated Oct. 6, 2015, 2:29 a.m.)


Review request for mesos and Ben Mahler.


Changes
---

Update according @bmahler's reviews


Bugs: MESOS-3104
https://issues.apache.org/jira/browse/MESOS-3104


Repository: mesos


Description
---

Add an endpoint that exposes component flags.


Diffs (updated)
-

  src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660 
  src/master/master.hpp 4bb65f0b6b77ea7324b0dee943602cfdb0f6a11c 
  src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b 
  src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b 
  src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476 
  src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c 

Diff: https://reviews.apache.org/r/37023/diff/


Testing
---

manual test wich mesos-local.
```
$ curl http://localhost:5050/master/flags 2>/dev/null|jq .
{
  "flags": {
"allocation_interval": "1secs",
"allocator": "HierarchicalDRF",
"authenticate": "false",
"authenticate_slaves": "false",
"authenticators": "crammd5",
"framework_sorter": "drf",
"help": "true",
"initialize_driver_logging": "true",
"log_auto_initialize": "true",
"logbufsecs": "0",
"logging_level": "INFO",
"max_slave_ping_timeouts": "5",
"quiet": "false",
"recovery_slave_removal_limit": "100%",
"registry": "replicated_log",
"registry_fetch_timeout": "1mins",
"registry_store_timeout": "5secs",
"registry_strict": "false",
"root_submissions": "true",
"slave_ping_timeout": "15secs",
"slave_reregister_timeout": "10mins",
"user_sorter": "drf",
"version": "false",
"webui_dir": "/home/haosdent/mesos/build/../src/webui",
"work_dir": "/tmp/mesos",
"zk_session_timeout": "10secs"
  }
}
```

```
$ curl http://localhost:5050/slave(1)/flags 2>/dev/null|jq .
{
  "flags": {
"authenticatee": "crammd5",
"cgroups_cpu_enable_pids_and_tids_count": "false",
"cgroups_enable_cfs": "false",
"cgroups_hierarchy": "/sys/fs/cgroup",
"cgroups_limit_swap": "false",
"cgroups_root": "mesos",
"container_disk_watch_interval": "15secs",
"containerizers": "mesos",
"default_role": "*",
"disk_watch_interval": "1mins",
"docker": "docker",
"docker_kill_orphans": "true",
"docker_remove_delay": "6hrs",
"docker_socket": "/var/run/docker.sock",
"docker_stop_timeout": "0ns",
"enforce_container_disk_quota": "false",
"executor_registration_timeout": "1mins",
"executor_shutdown_grace_period": "5secs",
"fetcher_cache_dir": "/tmp/mesos/fetch",
"fetcher_cache_size": "2GB",
"frameworks_home": "",
"gc_delay": "1weeks",
"gc_disk_headroom": "0.1",
"hadoop_home": "",
"help": "false",
"initialize_driver_logging": "true",
"isolation": "posix/cpu,posix/mem",
"launcher_dir": "/home/haosdent/mesos/build/src",
"logbufsecs": "0",
"logging_level": "INFO",
"oversubscribed_resources_interval": "15secs",
"perf_duration": "10secs",
"perf_interval": "1mins",
"qos_correction_interval_min": "0ns",
"quiet": "false",
"recover": "reconnect",
"recovery_timeout": "15mins",
"registration_backoff_factor": "1secs",
"resource_monitoring_interval": "1secs",
"revocable_cpu_low_priority": "true",
"sandbox_directory": "/mnt/mesos/sandbox",
"strict": "true",
"switch_user": "true",
"version": "false",
"work_dir": "/tmp/mesos/0"
  }
}
```


Thanks,

haosdent huang



Re: Review Request 39013: RegistryClient refactor: Fixed comments style.

2015-10-05 Thread Jojy Varghese

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39013/
---

(Updated Oct. 6, 2015, 2:30 a.m.)


Review request for mesos and Ben Mahler.


Changes
---

Removed dependency on 38443.


Repository: mesos


Description
---

RegistryClient refactor: Fixed comments style.


Diffs (updated)
-

  src/slave/containerizer/provisioner/docker/registry_client.hpp 
9d5d15455192e2d75fe5cd7fa8755fb8cc67e185 
  src/slave/containerizer/provisioner/docker/registry_client.cpp 
c2040b48ea43fdb29766994c244273d3fa9ee3cd 

Diff: https://reviews.apache.org/r/39013/diff/


Testing
---

make check.


Thanks,

Jojy Varghese



Re: Review Request 37023: Add an endpoint that exposes component flags.

2015-10-05 Thread haosdent huang


> On Oct. 6, 2015, 1:19 a.m., Ben Mahler wrote:
> > src/master/http.cpp, line 523
> > 
> >
> > Can you avoid the static non-POD? We should follow up on removing the 
> > rest as well (I believe there is a ticket for this).
> > 
> > How about following the approach from monitor.cpp?
> > 
> > https://github.com/apache/mesos/blob/master/src/slave/monitor.cpp#L45

I change it, but current patch looks inconsistent with old style. Should we 
change to old style here?


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/#review101570
---


On Oct. 6, 2015, 2:29 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37023/
> ---
> 
> (Updated Oct. 6, 2015, 2:29 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3104
> https://issues.apache.org/jira/browse/MESOS-3104
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add an endpoint that exposes component flags.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660 
>   src/master/master.hpp 4bb65f0b6b77ea7324b0dee943602cfdb0f6a11c 
>   src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b 
>   src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b 
>   src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476 
>   src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c 
> 
> Diff: https://reviews.apache.org/r/37023/diff/
> 
> 
> Testing
> ---
> 
> manual test wich mesos-local.
> ```
> $ curl http://localhost:5050/master/flags 2>/dev/null|jq .
> {
>   "flags": {
> "allocation_interval": "1secs",
> "allocator": "HierarchicalDRF",
> "authenticate": "false",
> "authenticate_slaves": "false",
> "authenticators": "crammd5",
> "framework_sorter": "drf",
> "help": "true",
> "initialize_driver_logging": "true",
> "log_auto_initialize": "true",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "max_slave_ping_timeouts": "5",
> "quiet": "false",
> "recovery_slave_removal_limit": "100%",
> "registry": "replicated_log",
> "registry_fetch_timeout": "1mins",
> "registry_store_timeout": "5secs",
> "registry_strict": "false",
> "root_submissions": "true",
> "slave_ping_timeout": "15secs",
> "slave_reregister_timeout": "10mins",
> "user_sorter": "drf",
> "version": "false",
> "webui_dir": "/home/haosdent/mesos/build/../src/webui",
> "work_dir": "/tmp/mesos",
> "zk_session_timeout": "10secs"
>   }
> }
> ```
> 
> ```
> $ curl http://localhost:5050/slave(1)/flags 2>/dev/null|jq .
> {
>   "flags": {
> "authenticatee": "crammd5",
> "cgroups_cpu_enable_pids_and_tids_count": "false",
> "cgroups_enable_cfs": "false",
> "cgroups_hierarchy": "/sys/fs/cgroup",
> "cgroups_limit_swap": "false",
> "cgroups_root": "mesos",
> "container_disk_watch_interval": "15secs",
> "containerizers": "mesos",
> "default_role": "*",
> "disk_watch_interval": "1mins",
> "docker": "docker",
> "docker_kill_orphans": "true",
> "docker_remove_delay": "6hrs",
> "docker_socket": "/var/run/docker.sock",
> "docker_stop_timeout": "0ns",
> "enforce_container_disk_quota": "false",
> "executor_registration_timeout": "1mins",
> "executor_shutdown_grace_period": "5secs",
> "fetcher_cache_dir": "/tmp/mesos/fetch",
> "fetcher_cache_size": "2GB",
> "frameworks_home": "",
> "gc_delay": "1weeks",
> "gc_disk_headroom": "0.1",
> "hadoop_home": "",
> "help": "false",
> "initialize_driver_logging": "true",
> "isolation": "posix/cpu,posix/mem",
> "launcher_dir": "/home/haosdent/mesos/build/src",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "oversubscribed_resources_interval": "15secs",
> "perf_duration": "10secs",
> "perf_interval": "1mins",
> "qos_correction_interval_min": "0ns",
> "quiet": "false",
> "recover": "reconnect",
> "recovery_timeout": "15mins",
> "registration_backoff_factor": "1secs",
> "resource_monitoring_interval": "1secs",
> "revocable_cpu_low_priority": "true",
> "sandbox_directory": "/mnt/mesos/sandbox",
> "strict": "true",
> "switch_user": "true",
> "version": "false",
> "work_dir": "/tmp/mesos/0"
>   }
> }
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 38443: Added layerid information to ManifestResponse

2015-10-05 Thread Jojy Varghese

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38443/
---

(Updated Oct. 6, 2015, 2:31 a.m.)


Review request for mesos and Timothy Chen.


Changes
---

reordered patches


Repository: mesos


Description
---

Added layerid information to ManifestResponse


Diffs (updated)
-

  src/slave/containerizer/provisioner/docker/registry_client.hpp 
9d5d15455192e2d75fe5cd7fa8755fb8cc67e185 
  src/slave/containerizer/provisioner/docker/registry_client.cpp 
c2040b48ea43fdb29766994c244273d3fa9ee3cd 
  src/tests/containerizer/provisioner_docker_tests.cpp 
d895eb9d0723e52cff8b21ef2deeaef1911d019c 

Diff: https://reviews.apache.org/r/38443/diff/


Testing
---

make check.


Thanks,

Jojy Varghese



Re: Review Request 38579: Refactored registry client

2015-10-05 Thread Jojy Varghese

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38579/
---

(Updated Oct. 6, 2015, 2:32 a.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Changes
---

reordered patches.


Repository: mesos


Description
---

- Moved ManifestResponse struct from RegistryClient to namespace.
- Cleanup


Diffs (updated)
-

  src/slave/containerizer/provisioner/docker/registry_client.hpp 
9d5d15455192e2d75fe5cd7fa8755fb8cc67e185 
  src/slave/containerizer/provisioner/docker/registry_client.cpp 
c2040b48ea43fdb29766994c244273d3fa9ee3cd 
  src/tests/containerizer/provisioner_docker_tests.cpp 
d895eb9d0723e52cff8b21ef2deeaef1911d019c 

Diff: https://reviews.apache.org/r/38579/diff/


Testing
---

make check.


Thanks,

Jojy Varghese



Re: Review Request 38579: Refactored registry client

2015-10-05 Thread Jojy Varghese

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38579/
---

(Updated Oct. 6, 2015, 2:33 a.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Changes
---

updated description.


Repository: mesos


Description (updated)
---

- Cleanup and broke big methods into smaller chunks.


Diffs
-

  src/slave/containerizer/provisioner/docker/registry_client.hpp 
9d5d15455192e2d75fe5cd7fa8755fb8cc67e185 
  src/slave/containerizer/provisioner/docker/registry_client.cpp 
c2040b48ea43fdb29766994c244273d3fa9ee3cd 
  src/tests/containerizer/provisioner_docker_tests.cpp 
d895eb9d0723e52cff8b21ef2deeaef1911d019c 

Diff: https://reviews.apache.org/r/38579/diff/


Testing
---

make check.


Thanks,

Jojy Varghese



Re: Review Request 36180: Avoid multi writers write to same file in PortMappingIsolatorTests.

2015-10-05 Thread haosdent huang


> On Oct. 6, 2015, 12:01 a.m., Cong Wang wrote:
> > Or simply use 'tee -a' instead? Since it should not append anything to that 
> > file when nc receives nothing.

tee -a aslo OK, but seems use different files would more clear?


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36180/#review101563
---


On Oct. 3, 2015, 4:52 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36180/
> ---
> 
> (Updated Oct. 3, 2015, 4:52 p.m.)
> 
> 
> Review request for mesos, Adam B, Ian Downes, Jie Yu, and Michael Park.
> 
> 
> Bugs: MESOS-2765
> https://issues.apache.org/jira/browse/MESOS-2765
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Avoid multi writers write to same file in PortMappingIsolatorTests.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/port_mapping_tests.cpp 
> feca2043503436ac9abac6017ae9059b3fcbed21 
> 
> Diff: https://reviews.apache.org/r/36180/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 38875: Moved the framework/executor exists check before Subscribe call in Agent

2015-10-05 Thread Guangya Liu


> On 十月 5, 2015, 11:57 p.m., Isabel Jimenez wrote:
> > src/slave/http.cpp, line 310
> > 
> >
> > Could you please change the syntax for every case to be consistent with 
> > `: {` through this switch?

Does the "{" needed here?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38875/#review101562
---


On 九月 30, 2015, 3:39 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38875/
> ---
> 
> (Updated 九月 30, 2015, 3:39 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-3515
> https://issues.apache.org/jira/browse/MESOS-3515
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactored the `api/v1/executor` endpoint to do executor/framework 
> exists(`NULL`) checks before `Subscribe` since the slave explicitly knows the 
> `frameworkID/executorID` when it launches it. Also modified tests to first 
> spawn a dummy `cat` process and then make a `Subscribe` call to ensure that 
> the Agent knows about the Framework/Executor and not reject it via 
> `BadRequest` due to the `NULL` checks.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b 
>   src/tests/executor_http_api_tests.cpp 
> 31938c295367686d444f8a8aa2c43d2696b481ec 
> 
> Diff: https://reviews.apache.org/r/38875/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Re: Review Request 36180: Avoid multi writers write to same file in PortMappingIsolatorTests.

2015-10-05 Thread Cong Wang


> On Oct. 6, 2015, 12:01 a.m., Cong Wang wrote:
> > Or simply use 'tee -a' instead? Since it should not append anything to that 
> > file when nc receives nothing.
> 
> haosdent huang wrote:
> tee -a aslo OK, but seems use different files would more clear?

I have no preference on either. BTW, names like 'trafficInViaPublic' are too 
confusing, actually you mean to say "invalid" by "In", spell the full word.


- Cong


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36180/#review101563
---


On Oct. 3, 2015, 4:52 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36180/
> ---
> 
> (Updated Oct. 3, 2015, 4:52 p.m.)
> 
> 
> Review request for mesos, Adam B, Ian Downes, Jie Yu, and Michael Park.
> 
> 
> Bugs: MESOS-2765
> https://issues.apache.org/jira/browse/MESOS-2765
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Avoid multi writers write to same file in PortMappingIsolatorTests.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/port_mapping_tests.cpp 
> feca2043503436ac9abac6017ae9059b3fcbed21 
> 
> Diff: https://reviews.apache.org/r/36180/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 39013: RegistryClient refactor: Fixed comments style.

2015-10-05 Thread Cong Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39013/#review101585
---


BTW, can you update https://issues.apache.org/jira/browse/MESOS-3523 to catch 
this coding style issue in future?

- Cong Wang


On Oct. 6, 2015, 2:30 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39013/
> ---
> 
> (Updated Oct. 6, 2015, 2:30 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> RegistryClient refactor: Fixed comments style.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioner/docker/registry_client.hpp 
> 9d5d15455192e2d75fe5cd7fa8755fb8cc67e185 
>   src/slave/containerizer/provisioner/docker/registry_client.cpp 
> c2040b48ea43fdb29766994c244273d3fa9ee3cd 
> 
> Diff: https://reviews.apache.org/r/39013/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>



Re: Review Request 38875: Moved the framework/executor exists check before Subscribe call in Agent

2015-10-05 Thread Anand Mazumdar


> On Sept. 30, 2015, 5 a.m., Guangya Liu wrote:
> > src/slave/http.cpp, line 304
> > 
> >
> > Can you please add some comments for when this if condition will be 
> > hit? I see that the scheduler API is not handling such logic.

It should be : 
https://github.com/apache/mesos/blob/master/src/master/http.cpp#L465

The only difference here being that we also need to explicitly check for the 
state to be `REGISTERING` as the agent creates an executor object when it 
receives a `RunTaskMessage` from the master


- Anand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38875/#review101074
---


On Sept. 30, 2015, 3:39 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38875/
> ---
> 
> (Updated Sept. 30, 2015, 3:39 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-3515
> https://issues.apache.org/jira/browse/MESOS-3515
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactored the `api/v1/executor` endpoint to do executor/framework 
> exists(`NULL`) checks before `Subscribe` since the slave explicitly knows the 
> `frameworkID/executorID` when it launches it. Also modified tests to first 
> spawn a dummy `cat` process and then make a `Subscribe` call to ensure that 
> the Agent knows about the Framework/Executor and not reject it via 
> `BadRequest` due to the `NULL` checks.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b 
>   src/tests/executor_http_api_tests.cpp 
> 31938c295367686d444f8a8aa2c43d2696b481ec 
> 
> Diff: https://reviews.apache.org/r/38875/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Re: Review Request 38875: Moved the framework/executor exists check before Subscribe call in Agent

2015-10-05 Thread Anand Mazumdar


> On Oct. 5, 2015, 11:57 p.m., Isabel Jimenez wrote:
> > src/slave/http.cpp, line 310
> > 
> >
> > Could you please change the syntax for every case to be consistent with 
> > `: {` through this switch?
> 
> Guangya Liu wrote:
> Does the "{" needed here?

I can make the change. Bit of an overkill though, as these switches would not 
be stubs quite soon and have a `{`:

There is already a patch out for Call::MESSAGE: 
https://reviews.apache.org/r/38899
MESOS-3476 is already being worked on.


- Anand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38875/#review101562
---


On Sept. 30, 2015, 3:39 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38875/
> ---
> 
> (Updated Sept. 30, 2015, 3:39 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-3515
> https://issues.apache.org/jira/browse/MESOS-3515
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactored the `api/v1/executor` endpoint to do executor/framework 
> exists(`NULL`) checks before `Subscribe` since the slave explicitly knows the 
> `frameworkID/executorID` when it launches it. Also modified tests to first 
> spawn a dummy `cat` process and then make a `Subscribe` call to ensure that 
> the Agent knows about the Framework/Executor and not reject it via 
> `BadRequest` due to the `NULL` checks.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b 
>   src/tests/executor_http_api_tests.cpp 
> 31938c295367686d444f8a8aa2c43d2696b481ec 
> 
> Diff: https://reviews.apache.org/r/38875/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Re: Review Request 38899: Added handler for Executor->Framework message for the Executor HTTP API

2015-10-05 Thread Anand Mazumdar


> On Oct. 4, 2015, 7:30 a.m., Guangya Liu wrote:
> > src/slave/http.cpp, line 316
> > 
> >
> > I think that the blank line is not needed.

It's always considered good practice to have a newline after a multiline 
continuation statement.


- Anand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38899/#review101439
---


On Sept. 30, 2015, 5:02 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38899/
> ---
> 
> (Updated Sept. 30, 2015, 5:02 p.m.)
> 
> 
> Review request for mesos, Isabel Jimenez and Vinod Kone.
> 
> 
> Bugs: MESOS-2296
> https://issues.apache.org/jira/browse/MESOS-2296
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Trivial change to call the `executorMessage(...)` function that already 
> existed in `src/slave/slave.cpp` to handle ExecutorToFrameworkMessage.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b 
> 
> Diff: https://reviews.apache.org/r/38899/diff/
> 
> 
> Testing
> ---
> 
> make check. Would add tests later after the MESOS-3480 review chain gets 
> committed.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Re: Review Request 39018: Added JSON parsing for Resources.

2015-10-05 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39018/#review101590
---


Patch looks great!

Reviews applied: [39018]

All tests passed.

- Mesos ReviewBot


On Oct. 5, 2015, 9:51 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39018/
> ---
> 
> (Updated Oct. 5, 2015, 9:51 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Jie Yu, and Michael 
> Park.
> 
> 
> Bugs: MESOS-2467
> https://issues.apache.org/jira/browse/MESOS-2467
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This includes code changes necessary for JSON parsing of Resources. 
> Documentation changes will be posted soon in another review.
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp 6c3a065945eb56dc88df9c977e5ca11d4cbcbf61 
>   include/mesos/v1/resources.hpp fe8925ac851b74d1b37919f00afc7ed816f47ea5 
>   src/common/resources.cpp 601388c35a1bff37c58e753d1870d53b8d0af2d1 
>   src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697 
>   src/v1/resources.cpp dc868903472f8f3a1ddc56092e3f8f81d953ce39 
> 
> Diff: https://reviews.apache.org/r/39018/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 36180: Avoid multi writers write to same file in PortMappingIsolatorTests.

2015-10-05 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36180/
---

(Updated Oct. 6, 2015, 3:13 a.m.)


Review request for mesos, Adam B, Ian Downes, Jie Yu, and Michael Park.


Changes
---

Update according @wangcong's review


Bugs: MESOS-2765
https://issues.apache.org/jira/browse/MESOS-2765


Repository: mesos


Description
---

Avoid multi writers write to same file in PortMappingIsolatorTests.


Diffs (updated)
-

  src/tests/containerizer/port_mapping_tests.cpp 
feca2043503436ac9abac6017ae9059b3fcbed21 

Diff: https://reviews.apache.org/r/36180/diff/


Testing
---


Thanks,

haosdent huang



Re: Review Request 36180: Avoid multi writers write to same file in PortMappingIsolatorTests.

2015-10-05 Thread Cong Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36180/#review101591
---



src/tests/containerizer/port_mapping_tests.cpp (line 270)


traffic_invalid_via_loopback is not good either, because there is no 
traffic from an invalid port


- Cong Wang


On Oct. 6, 2015, 3:13 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36180/
> ---
> 
> (Updated Oct. 6, 2015, 3:13 a.m.)
> 
> 
> Review request for mesos, Adam B, Ian Downes, Jie Yu, and Michael Park.
> 
> 
> Bugs: MESOS-2765
> https://issues.apache.org/jira/browse/MESOS-2765
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Avoid multi writers write to same file in PortMappingIsolatorTests.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/port_mapping_tests.cpp 
> feca2043503436ac9abac6017ae9059b3fcbed21 
> 
> Diff: https://reviews.apache.org/r/36180/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 37023: Add an endpoint that exposes component flags.

2015-10-05 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/#review101592
---



src/master/master.cpp (line 131)


Does DESCRIPTION still needed since it is empty now.


- Guangya Liu


On 十月 6, 2015, 2:29 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37023/
> ---
> 
> (Updated 十月 6, 2015, 2:29 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3104
> https://issues.apache.org/jira/browse/MESOS-3104
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add an endpoint that exposes component flags.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660 
>   src/master/master.hpp 4bb65f0b6b77ea7324b0dee943602cfdb0f6a11c 
>   src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b 
>   src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b 
>   src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476 
>   src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c 
> 
> Diff: https://reviews.apache.org/r/37023/diff/
> 
> 
> Testing
> ---
> 
> manual test wich mesos-local.
> ```
> $ curl http://localhost:5050/master/flags 2>/dev/null|jq .
> {
>   "flags": {
> "allocation_interval": "1secs",
> "allocator": "HierarchicalDRF",
> "authenticate": "false",
> "authenticate_slaves": "false",
> "authenticators": "crammd5",
> "framework_sorter": "drf",
> "help": "true",
> "initialize_driver_logging": "true",
> "log_auto_initialize": "true",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "max_slave_ping_timeouts": "5",
> "quiet": "false",
> "recovery_slave_removal_limit": "100%",
> "registry": "replicated_log",
> "registry_fetch_timeout": "1mins",
> "registry_store_timeout": "5secs",
> "registry_strict": "false",
> "root_submissions": "true",
> "slave_ping_timeout": "15secs",
> "slave_reregister_timeout": "10mins",
> "user_sorter": "drf",
> "version": "false",
> "webui_dir": "/home/haosdent/mesos/build/../src/webui",
> "work_dir": "/tmp/mesos",
> "zk_session_timeout": "10secs"
>   }
> }
> ```
> 
> ```
> $ curl http://localhost:5050/slave(1)/flags 2>/dev/null|jq .
> {
>   "flags": {
> "authenticatee": "crammd5",
> "cgroups_cpu_enable_pids_and_tids_count": "false",
> "cgroups_enable_cfs": "false",
> "cgroups_hierarchy": "/sys/fs/cgroup",
> "cgroups_limit_swap": "false",
> "cgroups_root": "mesos",
> "container_disk_watch_interval": "15secs",
> "containerizers": "mesos",
> "default_role": "*",
> "disk_watch_interval": "1mins",
> "docker": "docker",
> "docker_kill_orphans": "true",
> "docker_remove_delay": "6hrs",
> "docker_socket": "/var/run/docker.sock",
> "docker_stop_timeout": "0ns",
> "enforce_container_disk_quota": "false",
> "executor_registration_timeout": "1mins",
> "executor_shutdown_grace_period": "5secs",
> "fetcher_cache_dir": "/tmp/mesos/fetch",
> "fetcher_cache_size": "2GB",
> "frameworks_home": "",
> "gc_delay": "1weeks",
> "gc_disk_headroom": "0.1",
> "hadoop_home": "",
> "help": "false",
> "initialize_driver_logging": "true",
> "isolation": "posix/cpu,posix/mem",
> "launcher_dir": "/home/haosdent/mesos/build/src",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "oversubscribed_resources_interval": "15secs",
> "perf_duration": "10secs",
> "perf_interval": "1mins",
> "qos_correction_interval_min": "0ns",
> "quiet": "false",
> "recover": "reconnect",
> "recovery_timeout": "15mins",
> "registration_backoff_factor": "1secs",
> "resource_monitoring_interval": "1secs",
> "revocable_cpu_low_priority": "true",
> "sandbox_directory": "/mnt/mesos/sandbox",
> "strict": "true",
> "switch_user": "true",
> "version": "false",
> "work_dir": "/tmp/mesos/0"
>   }
> }
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 37023: Add an endpoint that exposes component flags.

2015-10-05 Thread haosdent huang


> On Oct. 6, 2015, 3:43 a.m., Guangya Liu wrote:
> > src/master/master.cpp, line 131
> > 
> >
> > Does DESCRIPTION still needed since it is empty now.

So far we still need it except we add 
```
string HELP(
string tldr,
const Option& references)
```
to libprocess/help.cpp


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/#review101592
---


On Oct. 6, 2015, 2:29 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37023/
> ---
> 
> (Updated Oct. 6, 2015, 2:29 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3104
> https://issues.apache.org/jira/browse/MESOS-3104
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add an endpoint that exposes component flags.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660 
>   src/master/master.hpp 4bb65f0b6b77ea7324b0dee943602cfdb0f6a11c 
>   src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b 
>   src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b 
>   src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476 
>   src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c 
> 
> Diff: https://reviews.apache.org/r/37023/diff/
> 
> 
> Testing
> ---
> 
> manual test wich mesos-local.
> ```
> $ curl http://localhost:5050/master/flags 2>/dev/null|jq .
> {
>   "flags": {
> "allocation_interval": "1secs",
> "allocator": "HierarchicalDRF",
> "authenticate": "false",
> "authenticate_slaves": "false",
> "authenticators": "crammd5",
> "framework_sorter": "drf",
> "help": "true",
> "initialize_driver_logging": "true",
> "log_auto_initialize": "true",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "max_slave_ping_timeouts": "5",
> "quiet": "false",
> "recovery_slave_removal_limit": "100%",
> "registry": "replicated_log",
> "registry_fetch_timeout": "1mins",
> "registry_store_timeout": "5secs",
> "registry_strict": "false",
> "root_submissions": "true",
> "slave_ping_timeout": "15secs",
> "slave_reregister_timeout": "10mins",
> "user_sorter": "drf",
> "version": "false",
> "webui_dir": "/home/haosdent/mesos/build/../src/webui",
> "work_dir": "/tmp/mesos",
> "zk_session_timeout": "10secs"
>   }
> }
> ```
> 
> ```
> $ curl http://localhost:5050/slave(1)/flags 2>/dev/null|jq .
> {
>   "flags": {
> "authenticatee": "crammd5",
> "cgroups_cpu_enable_pids_and_tids_count": "false",
> "cgroups_enable_cfs": "false",
> "cgroups_hierarchy": "/sys/fs/cgroup",
> "cgroups_limit_swap": "false",
> "cgroups_root": "mesos",
> "container_disk_watch_interval": "15secs",
> "containerizers": "mesos",
> "default_role": "*",
> "disk_watch_interval": "1mins",
> "docker": "docker",
> "docker_kill_orphans": "true",
> "docker_remove_delay": "6hrs",
> "docker_socket": "/var/run/docker.sock",
> "docker_stop_timeout": "0ns",
> "enforce_container_disk_quota": "false",
> "executor_registration_timeout": "1mins",
> "executor_shutdown_grace_period": "5secs",
> "fetcher_cache_dir": "/tmp/mesos/fetch",
> "fetcher_cache_size": "2GB",
> "frameworks_home": "",
> "gc_delay": "1weeks",
> "gc_disk_headroom": "0.1",
> "hadoop_home": "",
> "help": "false",
> "initialize_driver_logging": "true",
> "isolation": "posix/cpu,posix/mem",
> "launcher_dir": "/home/haosdent/mesos/build/src",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "oversubscribed_resources_interval": "15secs",
> "perf_duration": "10secs",
> "perf_interval": "1mins",
> "qos_correction_interval_min": "0ns",
> "quiet": "false",
> "recover": "reconnect",
> "recovery_timeout": "15mins",
> "registration_backoff_factor": "1secs",
> "resource_monitoring_interval": "1secs",
> "revocable_cpu_low_priority": "true",
> "sandbox_directory": "/mnt/mesos/sandbox",
> "strict": "true",
> "switch_user": "true",
> "version": "false",
> "work_dir": "/tmp/mesos/0"
>   }
> }
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 37023: Add an endpoint that exposes component flags.

2015-10-05 Thread haosdent huang


> On Oct. 6, 2015, 3:43 a.m., Guangya Liu wrote:
> > src/master/master.cpp, line 131
> > 
> >
> > Does DESCRIPTION still needed since it is empty now.
> 
> haosdent huang wrote:
> So far we still need it except we add 
> ```
> string HELP(
> string tldr,
> const Option& references)
> ```
> to libprocess/help.cpp

Hmm, let me add it to libprocess/help.cpp.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/#review101592
---


On Oct. 6, 2015, 2:29 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37023/
> ---
> 
> (Updated Oct. 6, 2015, 2:29 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3104
> https://issues.apache.org/jira/browse/MESOS-3104
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add an endpoint that exposes component flags.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660 
>   src/master/master.hpp 4bb65f0b6b77ea7324b0dee943602cfdb0f6a11c 
>   src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b 
>   src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b 
>   src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476 
>   src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c 
> 
> Diff: https://reviews.apache.org/r/37023/diff/
> 
> 
> Testing
> ---
> 
> manual test wich mesos-local.
> ```
> $ curl http://localhost:5050/master/flags 2>/dev/null|jq .
> {
>   "flags": {
> "allocation_interval": "1secs",
> "allocator": "HierarchicalDRF",
> "authenticate": "false",
> "authenticate_slaves": "false",
> "authenticators": "crammd5",
> "framework_sorter": "drf",
> "help": "true",
> "initialize_driver_logging": "true",
> "log_auto_initialize": "true",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "max_slave_ping_timeouts": "5",
> "quiet": "false",
> "recovery_slave_removal_limit": "100%",
> "registry": "replicated_log",
> "registry_fetch_timeout": "1mins",
> "registry_store_timeout": "5secs",
> "registry_strict": "false",
> "root_submissions": "true",
> "slave_ping_timeout": "15secs",
> "slave_reregister_timeout": "10mins",
> "user_sorter": "drf",
> "version": "false",
> "webui_dir": "/home/haosdent/mesos/build/../src/webui",
> "work_dir": "/tmp/mesos",
> "zk_session_timeout": "10secs"
>   }
> }
> ```
> 
> ```
> $ curl http://localhost:5050/slave(1)/flags 2>/dev/null|jq .
> {
>   "flags": {
> "authenticatee": "crammd5",
> "cgroups_cpu_enable_pids_and_tids_count": "false",
> "cgroups_enable_cfs": "false",
> "cgroups_hierarchy": "/sys/fs/cgroup",
> "cgroups_limit_swap": "false",
> "cgroups_root": "mesos",
> "container_disk_watch_interval": "15secs",
> "containerizers": "mesos",
> "default_role": "*",
> "disk_watch_interval": "1mins",
> "docker": "docker",
> "docker_kill_orphans": "true",
> "docker_remove_delay": "6hrs",
> "docker_socket": "/var/run/docker.sock",
> "docker_stop_timeout": "0ns",
> "enforce_container_disk_quota": "false",
> "executor_registration_timeout": "1mins",
> "executor_shutdown_grace_period": "5secs",
> "fetcher_cache_dir": "/tmp/mesos/fetch",
> "fetcher_cache_size": "2GB",
> "frameworks_home": "",
> "gc_delay": "1weeks",
> "gc_disk_headroom": "0.1",
> "hadoop_home": "",
> "help": "false",
> "initialize_driver_logging": "true",
> "isolation": "posix/cpu,posix/mem",
> "launcher_dir": "/home/haosdent/mesos/build/src",
> "logbufsecs": "0",
> "logging_level": "INFO",
> "oversubscribed_resources_interval": "15secs",
> "perf_duration": "10secs",
> "perf_interval": "1mins",
> "qos_correction_interval_min": "0ns",
> "quiet": "false",
> "recover": "reconnect",
> "recovery_timeout": "15mins",
> "registration_backoff_factor": "1secs",
> "resource_monitoring_interval": "1secs",
> "revocable_cpu_low_priority": "true",
> "sandbox_directory": "/mnt/mesos/sandbox",
> "strict": "true",
> "switch_user": "true",
> "version": "false",
> "work_dir": "/tmp/mesos/0"
>   }
> }
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Review Request 39037: Allow description empty in help information.

2015-10-05 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39037/
---

Review request for mesos and Ben Mahler.


Bugs: MESOS-3104
https://issues.apache.org/jira/browse/MESOS-3104


Repository: mesos


Description
---

Allow description empty in help information.


Diffs
-

  3rdparty/libprocess/include/process/help.hpp 
e7dc670648e8abd2fef7be79835f0b71e3e91258 
  3rdparty/libprocess/src/help.cpp 822c0844c61c7cabfca2b0534a5fb40001bd7cc7 

Diff: https://reviews.apache.org/r/39037/diff/


Testing
---


Thanks,

haosdent huang



Re: Review Request 37023: Add an endpoint that exposes component flags.

2015-10-05 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/
---

(Updated Oct. 6, 2015, 4:15 a.m.)


Review request for mesos and Ben Mahler.


Changes
---

Update according @gyliu's review


Bugs: MESOS-3104
https://issues.apache.org/jira/browse/MESOS-3104


Repository: mesos


Description
---

Add an endpoint that exposes component flags.


Diffs (updated)
-

  src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660 
  src/master/master.hpp 4bb65f0b6b77ea7324b0dee943602cfdb0f6a11c 
  src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b 
  src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b 
  src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476 
  src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c 

Diff: https://reviews.apache.org/r/37023/diff/


Testing
---

manual test wich mesos-local.
```
$ curl http://localhost:5050/master/flags 2>/dev/null|jq .
{
  "flags": {
"allocation_interval": "1secs",
"allocator": "HierarchicalDRF",
"authenticate": "false",
"authenticate_slaves": "false",
"authenticators": "crammd5",
"framework_sorter": "drf",
"help": "true",
"initialize_driver_logging": "true",
"log_auto_initialize": "true",
"logbufsecs": "0",
"logging_level": "INFO",
"max_slave_ping_timeouts": "5",
"quiet": "false",
"recovery_slave_removal_limit": "100%",
"registry": "replicated_log",
"registry_fetch_timeout": "1mins",
"registry_store_timeout": "5secs",
"registry_strict": "false",
"root_submissions": "true",
"slave_ping_timeout": "15secs",
"slave_reregister_timeout": "10mins",
"user_sorter": "drf",
"version": "false",
"webui_dir": "/home/haosdent/mesos/build/../src/webui",
"work_dir": "/tmp/mesos",
"zk_session_timeout": "10secs"
  }
}
```

```
$ curl http://localhost:5050/slave(1)/flags 2>/dev/null|jq .
{
  "flags": {
"authenticatee": "crammd5",
"cgroups_cpu_enable_pids_and_tids_count": "false",
"cgroups_enable_cfs": "false",
"cgroups_hierarchy": "/sys/fs/cgroup",
"cgroups_limit_swap": "false",
"cgroups_root": "mesos",
"container_disk_watch_interval": "15secs",
"containerizers": "mesos",
"default_role": "*",
"disk_watch_interval": "1mins",
"docker": "docker",
"docker_kill_orphans": "true",
"docker_remove_delay": "6hrs",
"docker_socket": "/var/run/docker.sock",
"docker_stop_timeout": "0ns",
"enforce_container_disk_quota": "false",
"executor_registration_timeout": "1mins",
"executor_shutdown_grace_period": "5secs",
"fetcher_cache_dir": "/tmp/mesos/fetch",
"fetcher_cache_size": "2GB",
"frameworks_home": "",
"gc_delay": "1weeks",
"gc_disk_headroom": "0.1",
"hadoop_home": "",
"help": "false",
"initialize_driver_logging": "true",
"isolation": "posix/cpu,posix/mem",
"launcher_dir": "/home/haosdent/mesos/build/src",
"logbufsecs": "0",
"logging_level": "INFO",
"oversubscribed_resources_interval": "15secs",
"perf_duration": "10secs",
"perf_interval": "1mins",
"qos_correction_interval_min": "0ns",
"quiet": "false",
"recover": "reconnect",
"recovery_timeout": "15mins",
"registration_backoff_factor": "1secs",
"resource_monitoring_interval": "1secs",
"revocable_cpu_low_priority": "true",
"sandbox_directory": "/mnt/mesos/sandbox",
"strict": "true",
"switch_user": "true",
"version": "false",
"work_dir": "/tmp/mesos/0"
  }
}
```


Thanks,

haosdent huang



Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

2015-10-05 Thread Alexander Rukletsov


> On Sept. 29, 2015, 4:17 p.m., Alexander Rukletsov wrote:
> > One high level suggestion.
> > 
> > After looking at our http code, I realized that we use the same pattern 
> > again and again, for example:
> > ```
> > JSON::Array array;
> > array.values.reserve(status.network_infos().size()); // MESOS-2353.
> > foreach (const NetworkInfo& info, status.network_infos()) {
> >   array.values.push_back(model(info));
> > }
> > object.values["network_infos"] = std::move(array);
> > ```
> > We cannot use newly added `JSON::protobuf()` here, because a different way 
> > for rendering JSON from protobuf is used. Without digging deep inside, I 
> > know three ways how we create a `JSON` out of a proto in our codebase:
> > - wrap in `JSON::Protobuf()` for individual messages;
> > - wrap in one of the `model()` family functions;
> > - pass as it is for built-in types.
> > 
> > The proposed conversion function covers one of the possible ways. How about 
> > add one more convertion? Something like:
> > ```
> > template 
> > Array protobuf(const google::protobuf::RepeatedPtrField& repeated,
> > const lambda::function(const T&)>& converter)
> > {
> >   static_assert(std::is_convertible::value,
> > "T must be a google::protobuf::Message");
> >   JSON::Array array;
> >   array.values.reserve(repeated.size());
> >   foreach (const T& elem, repeated) {
> > array.values.push_back(converter(elem));
> >   }
> >   
> >   return array;
> > }
> > ```
> > 
> > Then the snippet above could be rewritten as:
> > ```
> > object.values["network_infos"] = 
> > std::move(JSON::protobuf(status.network_infos(), [](const NetworkInfo& 
> > info) { return model(info); });
> > ```
> > 
> > A further improvement would be to accept any iterable collection, not only 
> > `RepeatedPtrField<>`, for example `hashset`.
> > 
> > What do you think?
> 
> Klaus Ma wrote:
> Awesome! I've also try similar proposal, but failed when `function` 
> converting with `template`; your suggestion using lambda is great!
> For the `hashset`, I'd suggest to address it when we have such case in 
> our code :).
> 
> I'll also address your comments above.
> 
> Alexander Rukletsov wrote:
> We do have such cases in our codebase ; ). Here are a few as an example:
> - https://github.com/apache/mesos/blob/master/src/master/http.cpp#L217
> - https://github.com/apache/mesos/blob/master/src/master/http.cpp#L229
> 
> Michael Park wrote:
> I like the idea of taking a projection function as an argument, but let's 
> do it as a separate ticket to keep the scope of this review narrow.
> 
> Klaus Ma wrote:
> I'll log a new ticket to trace projection fuction part.
> 
> Klaus Ma wrote:
> MESOS-3580 is logged to trace this requirement, @alex-mesos, would you 
> shepherd it?

Great, thanks! I'm not a Mesos committer, hence I cannot shepherd, but I would 
love to review and help out with that! Maybe @MPark will agree to shepherd?


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38342/#review100964
---


On Oct. 4, 2015, 11:29 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38342/
> ---
> 
> (Updated Oct. 4, 2015, 11:29 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Michael Park, and Jan Schlicht.
> 
> 
> Bugs: MESOS-3405
> https://issues.apache.org/jira/browse/MESOS-3405
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently, `stout/protobuf.hpp` provides a `JSON::Protobuf` utility which 
> converts a `google::protobuf::Message` into a `JSON::Object`.
> We should add the support for `google::protobuf::RepeatedPtrField` by 
> introducing overloaded functions.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 2285ce9 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 68328a2 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h 8ebb798 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc 34eb6d0 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto 920f5c9 
> 
> Diff: https://reviews.apache.org/r/38342/diff/
> 
> 
> Testing
> ---
> 
> cd 3rdparty/libprocess/3rdparty/stout
> ./boostrap
> ./configure
> make
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>



Re: Review Request 38932: Kill health check external command process and continue check after timeout.

2015-10-05 Thread haosdent huang


> On Oct. 5, 2015, 10:03 a.m., Jan Schlicht wrote:
> > src/health-check/main.cpp, line 208
> > 
> >
> > Following the JIRA discussion, this change seems to be in line with 
> > Gabriels sentence "It's fine that the health check fails potentially 
> > forever if the command is malformed.", right?
> > Otherwise I would suggest to keep `promise.fail` here.
> 
> haosdent huang wrote:
> So you suggest keep `promise.fail` here?

For current implementation, it would only exit if command value is empty. Other 
cases would be considered as failure.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38932/#review101459
---


On Oct. 5, 2015, 10:18 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38932/
> ---
> 
> (Updated Oct. 5, 2015, 10:18 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3479
> https://issues.apache.org/jira/browse/MESOS-3479
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Kill health check external command process and continue check after timeout.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp 1e4901335854c49e46cd7b132e79ccb11cd72ade 
>   src/health-check/main.cpp 97b25716335ec5719c1100bd73d06b7fc98036c9 
>   src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390 
>   src/tests/health_check_tests.cpp ff6275b19206b49eacb6761f3aeb58dd87651ade 
> 
> Diff: https://reviews.apache.org/r/38932/diff/
> 
> 
> Testing
> ---
> 
> GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="HealthCheckTest.CheckCommandTimeout" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



  1   2   >