Re: Review Request 39506: Remove unnecessary exec in post-rewrite hook.

2015-10-21 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39506/#review103406 --- Ship it! Ship It! - Joris Van Remoortere On Oct. 21, 2015,

Re: Review Request 39516: Slave should accept PingSlaveMessage but not "PING" message.

2015-10-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39516/#review103401 --- Patch looks great! Reviews applied: [39516] All tests passed. -

Re: Review Request 39516: Slave should accept PingSlaveMessage but not "PING" message.

2015-10-21 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39516/#review103411 --- src/slave/slave.hpp (line 186)

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

2015-10-21 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review103402 --- src/master/master.cpp (line 510)

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

2015-10-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review103407 --- Patch looks great! Reviews applied: [39276, 37998, 39472, 37999,

Re: Review Request 39541: Windows: Moved `os::chdir` to its own file, `stout/os/chdir.hpp`.

2015-10-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39541/#review103522 --- Patch looks great! Reviews applied: [39537, 39538, 39539, 39540,

Re: Review Request 39285: Added Quota Request Validation.

2015-10-21 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/ --- (Updated Oct. 22, 2015, 4:38 a.m.) Review request for mesos, Alexander

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-10-21 Thread Joerg Schad
> On Oct. 22, 2015, 3:08 a.m., Guangya Liu wrote: > > src/master/http.cpp, line 843 > > > > > > What about return quotaHandler.delete(request); > > > > It is better that the operation API can map to CRUD

Re: Review Request 38874: Refactored executor struct in Agent for the Executor HTTP API

2015-10-21 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38874/ --- (Updated Oct. 22, 2015, 5:51 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

2015-10-21 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/ --- (Updated Oct. 22, 2015, 5:53 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 39507: Check message.empty() in Slave::shutdown before log it

2015-10-21 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39507/#review103430 --- src/slave/slave.cpp (line 652)

Re: Review Request 39276: Fixed a bug in which under certains circumstances HTTP 1.1 Pipelining is not respected.

2015-10-21 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39276/#review103410 --- 3rdparty/libprocess/include/process/event.hpp (line 123)

Re: Review Request 39331: Support docker local store pull image simultaneously

2015-10-21 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39331/ --- (Updated Oct. 21, 2015, 9:48 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 39331: Support docker local store pull image simultaneously

2015-10-21 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39331/ --- (Updated Oct. 21, 2015, 9:55 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 39060: Create master detector per url & not per framework

2015-10-21 Thread Mandeep Chadha
> On Oct. 21, 2015, 12:41 a.m., Joris Van Remoortere wrote: > > Hey Mandeep, Thanks for taking on this important work! > > Some high level questions: > > - Do we need to do reference counting manually or can we use a construct > > like `Shared` in Libprocess that wraps the `std::shared_ptr`. >

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

2015-10-21 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39494/ --- (Updated Oct. 21, 2015, 4:17 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

2015-10-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39494/#review103429 --- Patch looks great! Reviews applied: [39494] All tests passed. -

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

2015-10-21 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39494/#review103434 --- docs/configuration.md (line 1915)

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

2015-10-21 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39494/ --- (Updated Oct. 21, 2015, 5:28 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 39514: HTTP Scheduler API no longer allows FrameworkInfo.user to be empty

2015-10-21 Thread Marco Massenzio
> On Oct. 21, 2015, 6:05 p.m., Marco Massenzio wrote: > > include/mesos/v1/mesos.proto, lines 211-213 > > > > > > I know it's not your code, but could you please remove `automagically` > > (there's nothing magic in

Re: Review Request 39457: Document messages in messages.proto.

2015-10-21 Thread Joseph Wu
> On Oct. 20, 2015, 2:13 p.m., Joris Van Remoortere wrote: > > This looks great Joseph! > > Can you stay consistent with the scheduler / framework terminology? > > Which one should we use consistently in the code-base? (oops, forgot to click publish earlier.) I'll use "framework" whenever the

Re: Review Request 39497: Fixed quotation of interpolated variables in log messages.

2015-10-21 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39497/#review103437 --- Ship it! Ship It! - Greg Mann On Oct. 21, 2015, 2:37 a.m.,

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

2015-10-21 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39494/#review103436 --- Ship it! Ship It! - Cong Wang On Oct. 21, 2015, 5:28 p.m.,

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

2015-10-21 Thread Greg Mann
> On Oct. 21, 2015, 5:22 p.m., Cong Wang wrote: > > docs/configuration.md, line 1915 > > > > > > Like what you do for libevent, it would be nicer if you can add a URL > > to libnl3 too, but this is not a big

Re: Review Request 39331: Support docker local store pull image simultaneously

2015-10-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39331/#review103439 --- Patch looks great! Reviews applied: [39331] All tests passed. -

Re: Review Request 39514: HTTP Scheduler API no longer allows FrameworkInfo.user to be empty

2015-10-21 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39514/#review103440 --- Thanks for this; please add reviewers to this patch, and find a

Review Request 39518: Changed write api.

2015-10-21 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39518/ --- Review request for mesos and Timothy Chen. Bugs: MESOS-3773

Re: Review Request 39516: Slave should accept PingSlaveMessage but not "PING" message.

2015-10-21 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39516/#review103452 --- Ship it! src/slave/slave.hpp (line 186)

Re: Review Request 39345: Enable build on FreeBSD, start porting components.

2015-10-21 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39345/#review103449 --- Looks good! I haven't tested this myself yet, so these are

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

2015-10-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39494/#review103453 --- Patch looks great! Reviews applied: [39494] All tests passed. -

Re: Review Request 39006: stout: Used thread-safe replacement for strerror.

2015-10-21 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39006/#review103459 --- Ship it! Ship It! - Kapil Arya On Oct. 8, 2015, 10:36 a.m.,

Re: Review Request 39502: Sync v1/mesos.proto with docker, QoS, and AppC changes.

2015-10-21 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39502/#review103456 --- Ship it! Ship It! - Kapil Arya On Oct. 20, 2015, 9:04 p.m.,

Re: Review Request 39006: stout: Used thread-safe replacement for strerror.

2015-10-21 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39006/#review103460 --- Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp

Re: Review Request 39345: Enable build on FreeBSD, start porting components.

2015-10-21 Thread Ian Downes
> On Oct. 20, 2015, 1:52 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [39345] > > > > Failed command: ./support/apply-review.sh -n -r 39345 > > > > Error: > > 2015-10-20 08:52:33 URL:https://reviews.apache.org/r/39345/diff/raw/ > > [26851/26851] -> "39345.patch" [1]

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

2015-10-21 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39005/#review103458 --- Ship it!

Re: Review Request 39453: Added HTTP docs to libprocess README.md.

2015-10-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39453/#review103464 --- Patch looks great! Reviews applied: [39453] All tests passed. -

Re: Review Request 39456: Documentation: added containerizer internals

2015-10-21 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39456/ --- (Updated Oct. 21, 2015, 9:25 p.m.) Review request for mesos, Connor Doyle and

Re: Review Request 39007: libprocess: Used thread-safe replacement for strerror.

2015-10-21 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39007/#review103486 --- 3rdparty/libprocess/src/io.cpp (line 27)

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-10-21 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated Oct. 21, 2015, 10:41 p.m.) Review request for Alexander Rukletsov,

Re: Review Request 39230: Added prevention of SASL deprecation warnings all around its invocations on OS X.

2015-10-21 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39230/#review103488 --- Ship it! Curious if we want to scope these for the whole files?

Re: Review Request 39518: Changed write api.

2015-10-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39518/#review103480 --- Patch looks great! Reviews applied: [39518] All tests passed. -

Re: Review Request 39007: libprocess: Used thread-safe replacement for strerror.

2015-10-21 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39007/#review103463 --- Ship it! 3rdparty/libprocess/src/profiler.cpp (line 88)

Re: Review Request 39502: Sync v1/mesos.proto with docker, QoS, and AppC changes.

2015-10-21 Thread Joseph Wu
> On Oct. 21, 2015, 12:31 p.m., Kapil Arya wrote: > > Ship It! Just to confirm, https://reviews.apache.org/r/38367/diff/4#0 was omitted from V1 unintentionally? - Joseph --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 39008: Used thread-safe replacement for strerror.

2015-10-21 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39008/#review103482 --- Ship it! LGTM modulo some comments about #includes.

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

2015-10-21 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39005/#review103484 --- 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp (line 41)

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

2015-10-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39531/#review103506 --- Bad patch! Reviews applied: [39531] Failed command:

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

2015-10-21 Thread Klaus Ma
> On Oct. 21, 2015, 3:02 p.m., Klaus Ma wrote: > > src/module/manager.hpp, line 94 > > > > > > Should we merge with `moduleParameters[moduleName]` or replace it? IMO, > > prefer to merge them; I'd like to leave it

Re: Review Request 39507: Check message.empty() in Slave::shutdown before log it

2015-10-21 Thread Guangya Liu
> On 十月 21, 2015, 4:58 p.m., Alexander Rukletsov wrote: > > src/slave/slave.cpp, line 652 > > > > > > Capitalize? If the message is empty, we can use capitalize, otherwise we cannot. Will update this patch. -

Re: Review Request 39507: Check message.empty() in Slave::shutdown before log it

2015-10-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39507/ --- (Updated 十月 22, 2015, 2:14 a.m.) Review request for mesos and Till Toenshoff.

Re: Review Request 39495: Fix SSL flag cleanup for tests.

2015-10-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39495/ --- (Updated Oct. 21, 2015, 10:17 a.m.) Review request for mesos, Artem

Re: Review Request 39453: Added HTTP docs to libprocess README.md.

2015-10-21 Thread Greg Mann
> On Oct. 21, 2015, 1:51 a.m., Guangya Liu wrote: > > 3rdparty/libprocess/README.md, line 452 > > > > > > s/noting/nothing Here, I'm saying something to the effect of "It's also worthy of note that if multiple

Re: Review Request 39453: Added HTTP docs to libprocess README.md.

2015-10-21 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39453/ --- (Updated Oct. 21, 2015, 5:53 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

2015-10-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39531/#review103497 --- Can you also sync this with the V1 API? (If so, I'll remove that

Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.

2015-10-21 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39531/#review103496 --- Should we also mention it explicitly that each NetworkInfo message

Re: Review Request 39534: SSLTest refactor: Change MesosTest to inherit from the SSL helper class.

2015-10-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39534/#review103503 --- Patch looks great! Reviews applied: [39495, 39498, 39499, 39501,

Re: Review Request 39220: CMake: Added subset of agent target in Windows builds.

2015-10-21 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39220/#review103408 --- Ship it! - Joris Van Remoortere On Oct. 20, 2015, 10:27 p.m.,

Re: Review Request 39220: CMake: Added subset of agent target in Windows builds.

2015-10-21 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39220/ --- (Updated Oct. 21, 2015, 3:13 p.m.) Review request for mesos, Artem

Re: Review Request 39456: Documentation: added containerizer internals

2015-10-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39456/#review103492 --- Patch looks great! Reviews applied: [39456] All tests passed. -

Re: Review Request 39498: SSLTest refactor: Change SSLTest to inherit from TemporaryDirectoryTest.

2015-10-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39498/ --- (Updated Oct. 21, 2015, 5:04 p.m.) Review request for mesos, Artem Harutyunyan

Review Request 39533: [WIP] SSLTest refactor: Change test #ifdefs so this class exists with or without --enable-ssl.

2015-10-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39533/ --- Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. Bugs:

Re: Review Request 39533: SSLTest refactor: Change test #ifdefs so this class exists with or without --enable-ssl.

2015-10-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39533/ --- (Updated Oct. 21, 2015, 5:04 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 39501: SSLTest refactor: Split SSLTest into helpers which can be integrated into MesosTest.

2015-10-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39501/ --- (Updated Oct. 21, 2015, 5:04 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 39499: SSLTest refactor: Update docker registry tests to reflect changed cleanup logic of SSLTest.

2015-10-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39499/ --- (Updated Oct. 21, 2015, 5:04 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 39453: Added HTTP docs to libprocess README.md.

2015-10-21 Thread Guangya Liu
> On 十月 21, 2015, 1:51 a.m., Guangya Liu wrote: > > 3rdparty/libprocess/README.md, line 452 > > > > > > s/noting/nothing > > Greg Mann wrote: > Here, I'm saying something to the effect of "It's also worthy of

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

2015-10-21 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Oct. 21, 2015, 2:55 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

2015-10-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review103399 --- Bad patch! Reviews applied: [39276, 37998, 39472, 37999, 38000,

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

2015-10-21 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Oct. 21, 2015, 3:12 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

2015-10-21 Thread Alexander Rojas
> On Oct. 12, 2015, 1:59 p.m., Guangya Liu wrote: > > include/mesos/authentication/http/basic_authenticator_factory.hpp, line 33 > > > > > > virtual It is not virtual because the class is not supposed to be

Re: Review Request 39276: Fixed a bug in which under certains circumstances HTTP 1.1 Pipelining is not respected.

2015-10-21 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39276/ --- (Updated Oct. 21, 2015, 3:18 p.m.) Review request for mesos, Anand Mazumdar,

Review Request 39516: Slave should accept PingSlaveMessage but not "PING" message.

2015-10-21 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39516/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-1832

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

2015-10-21 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Oct. 21, 2015, 3:20 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

2015-10-21 Thread haosdent huang
> On Oct. 18, 2015, 4:10 a.m., haosdent huang wrote: > > src/docker/docker.cpp, line 430 > > > > > > Seems we already have this env in > >

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-10-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/#review103518 --- src/master/http.cpp (line 839)

Re: Review Request 39507: Check message.empty() in Slave::shutdown before log it

2015-10-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39507/#review103519 --- Patch looks great! Reviews applied: [39507] All tests passed. -

Review Request 39538: Windows: Moved `os::touch` to its own file, `stout/os/touch.hpp`.

2015-10-21 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39538/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Review Request 39541: Windows: Moved `os::chdir` to its own file, `stout/os/chdir.hpp`.

2015-10-21 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39541/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Review Request 39539: Windows: Moved `os::mktemp` to its own file, `stout/os/mktemp.hpp`.

2015-10-21 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39539/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Review Request 39540: Windows: Moved `os::getcwd` to its own file, `stout/os/getcwd.hpp`.

2015-10-21 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39540/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Re: Review Request 39539: Windows: Moved `os::mktemp` to its own file, `stout/os/mktemp.hpp`.

2015-10-21 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39539/#review103521 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/mktemp.hpp

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

2015-10-21 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38627/#review103365 --- src/module/manager.hpp (line 94)

Re: Review Request 39497: Fixed quotation of interpolated variables in log messages.

2015-10-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39497/#review103366 --- Patch looks great! Reviews applied: [39497] All tests passed. -

Re: Review Request 39211: Check for trailing characters in JSON::parse().

2015-10-21 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39211/#review103368 --- Ship it! Committing..

Re: Review Request 39494: Added libevent and ssl flags to config docs.

2015-10-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39494/#review103376 --- Patch looks great! Reviews applied: [39494] All tests passed. -

Re: Review Request 39276: Fixed a bug in which under certains circumstances HTTP 1.1 Pipelining is not respected.

2015-10-21 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39276/#review103377 --- 3rdparty/libprocess/src/process.cpp (line 2344)

Re: Review Request 39276: Fixed a bug in which under certains circumstances HTTP 1.1 Pipelining is not respected.

2015-10-21 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39276/ --- (Updated Oct. 21, 2015, 11:41 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 37999: Implemented http::AuthenticatorManager

2015-10-21 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37999/ --- (Updated Oct. 21, 2015, 12:01 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 39276: Fixed a bug in which under certains circumstances HTTP 1.1 Pipelining is not respected.

2015-10-21 Thread Alexander Rojas
> On Oct. 21, 2015, 3:47 a.m., Till Toenshoff wrote: > > 3rdparty/libprocess/src/process.cpp, line 2351 > > > > > > The existing is incorrect but not sure which option is correct: > > > > A.

Re: Review Request 39507: Check message.empty() in Slave::shutdown before log it

2015-10-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39507/#review103385 --- Patch looks great! Reviews applied: [39507] All tests passed. -

Re: Review Request 38000: Added an API for libprocess users to interact with http::AuthenticatorManager

2015-10-21 Thread Alexander Rojas
> On Oct. 21, 2015, 6:11 a.m., Till Toenshoff wrote: > > 3rdparty/libprocess/src/tests/http_tests.cpp, line 1416 > > > > > > s/are ignored/is ignored/ > > s/tests/test/ or s/this/these/ I fixed the second, but

Re: Review Request 38000: Added an API for libprocess users to interact with http::AuthenticatorManager

2015-10-21 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/ --- (Updated Oct. 21, 2015, 12:47 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 37999: Implemented http::AuthenticatorManager

2015-10-21 Thread Alexander Rojas
> On Oct. 21, 2015, 5:25 a.m., Till Toenshoff wrote: > > 3rdparty/libprocess/src/process.cpp, lines 841-842 > > > > > > If an `authenticate`-request failed, the error message is never shown > > anywhere. > > >

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

2015-10-21 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Oct. 21, 2015, 2:37 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

2015-10-21 Thread Alexander Rojas
> On Oct. 21, 2015, 9:02 a.m., Klaus Ma wrote: > > src/module/manager.hpp, line 94 > > > > > > Should we merge with `moduleParameters[moduleName]` or replace it? IMO, > > prefer to merge them; I'd like to leave it

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

2015-10-21 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38627/ --- (Updated Oct. 21, 2015, 2:52 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39514: HTTP Scheduler API no longer allows FrameworkInfo.user to be empty

2015-10-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39514/#review103389 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 37999: Implemented http::AuthenticatorManager

2015-10-21 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37999/#review103383 --- 3rdparty/libprocess/include/process/authenticator.hpp (line 52)

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

2015-10-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/#review103388 --- Patch looks great! Reviews applied: [38705, 38883, 39410, 39420]

Re: Review Request 37999: Implemented http::AuthenticatorManager

2015-10-21 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37999/#review103387 --- 3rdparty/libprocess/src/process.cpp (line 833)

Re: Review Request 38000: Added an API for libprocess users to interact with http::AuthenticatorManager

2015-10-21 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/#review103391 --- 3rdparty/libprocess/include/process/process.hpp (line 72)

Re: Review Request 38000: Added an API for libprocess users to interact with http::AuthenticatorManager

2015-10-21 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/#review103395 --- 3rdparty/libprocess/src/tests/http_tests.cpp (line 1351)

  1   2   >