Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

2015-10-23 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39559/#review103815 ---

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

2015-10-23 Thread Artem Harutyunyan
> On Oct. 23, 2015, 11:42 a.m., Neil Conway wrote: > > src/slave/containerizer/linux_launcher.cpp, line 189 > > > > > > You could simplify this to "return freezer.isSome();". Clearly more > > concise; debatable

Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

2015-10-23 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

2015-10-23 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39583/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Re: Review Request 39548: SchedulerTest.Suppress is flaky

2015-10-23 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39548/ --- (Updated 十月 23, 2015, 9:05 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

2015-10-23 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39604/ --- (Updated Oct. 23, 2015, 11:50 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 39548: SchedulerTest.Suppress is flaky

2015-10-23 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39548/#review103745 --- Ship it! LGTM ! - Anand Mazumdar On Oct. 23, 2015, 9:05 a.m.,

Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

2015-10-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39583/#review103746 ---

Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

2015-10-23 Thread Alex Clemmer
> On Oct. 23, 2015, 9:15 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp, line 34 > > > > > > This doesn't use any instance data so could probably be either

Re: Review Request 39592: [libprocess]: Made license-headers doxygen-compatible.

2015-10-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39592/#review103767 --- Patch looks great! Reviews applied: [39590, 39591, 39592] All

Re: Review Request 39597: Add Newbie guide.

2015-10-23 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39597/#review103781 --- I'm pretty sure that Mesos only builds with the bundled GLog and

Re: Review Request 39410: Added support for github to apply-reviews.py.

2015-10-23 Thread Marco Massenzio
> On Oct. 20, 2015, 5:06 a.m., Marco Massenzio wrote: > > support/apply-reviews.py, line 160 > > > > > > you don't really need to escape the quotes, just take advantage of > > Python being able to use single and

Re: Review Request 39518: Changed write api.

2015-10-23 Thread Jojy Varghese
> On Oct. 23, 2015, 8:02 a.m., Timothy Chen wrote: > > src/slave/containerizer/provisioner/docker/registry_client.cpp, line 638 > > > > > > Did we ever find out why before we just use another interface? I realized

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

2015-10-23 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review103778 --- Ship it! Ship It! - Marco Massenzio On Oct. 23, 2015, 6:18

Re: Review Request 39285: Added Quota Request Validation.

2015-10-23 Thread Joerg Schad
> On Oct. 22, 2015, 10:25 a.m., Alexander Rukletsov wrote: > > src/master/quota_handler.cpp, lines 71-72 > > > > > > How about initializing `role` with QuotaInfo.role? Or we agreed not to > > send role as part of

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

2015-10-23 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/#review103779 --- Ship it! Thanks for the "Better Bash" :) - Marco Massenzio On

Review Request 39590: Made license-headers doxygen-compatible.

2015-10-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39590/ --- Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till

Review Request 39591: [stout]: Made license-headers doxygen-compatible.

2015-10-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39591/ --- Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till

Review Request 39592: [libprocess]: Made license-headers doxygen-compatible.

2015-10-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39592/ --- Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till

Re: Review Request 39579: Updated docker registry client to check HTTP code.

2015-10-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39579/#review103748 --- Patch looks great! Reviews applied: [38416, 38779, 39579] All

Re: Review Request 39548: SchedulerTest.Suppress is flaky

2015-10-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39548/#review103752 --- Patch looks great! Reviews applied: [39548] All tests passed. -

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

2015-10-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review103749 --- Bad patch! Reviews applied: [39537, 39538, 39539, 39540, 39541,

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

2015-10-23 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39401/ --- (Updated Oct. 23, 2015, 4:38 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39539: Windows: Moved `os::mktemp` to its own file, `stout/os/mktemp.hpp`.

2015-10-23 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39539/#review103793 --- Confirmed that mktemp logic was unchanged.

Re: Review Request 39383: Windows: Moved `os::mkdir` to its own file, `stout/os/mkdir`.

2015-10-23 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39383/#review103805 --- Confirmed that `mkdir` logic is essentially unchanged.

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

2015-10-23 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/ --- (Updated Oct. 23, 2015, 4:30 p.m.) Review request for mesos, Artem

Re: Review Request 39450: Quota: Added hierarchical allocator-specific tests.

2015-10-23 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39450/ --- (Updated Oct. 23, 2015, 4:38 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39400: Quota: Implemented quota API.

2015-10-23 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39400/ --- (Updated Oct. 23, 2015, 4:38 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

2015-10-23 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38218/ --- (Updated Oct. 23, 2015, 4:38 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39285: Added Quota Request Validation.

2015-10-23 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/ --- (Updated Oct. 23, 2015, 4:52 p.m.) Review request for mesos, Alexander

Re: Review Request 38580: Added docker registry RemotePuller

2015-10-23 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Oct. 23, 2015, 4:57 p.m.) Review request for mesos, Jie Yu, Timothy

Re: Review Request 39548: SchedulerTest.Suppress is flaky

2015-10-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39548/#review103810 --- Ship it! Ship It! - Vinod Kone On Oct. 23, 2015, 9:05 a.m.,

Re: Review Request 39518: Changed write api.

2015-10-23 Thread Jojy Varghese
> On Oct. 23, 2015, 7:59 a.m., Benjamin Bannier wrote: > > src/slave/containerizer/provisioner/docker/registry_client.cpp, line 642 > > > > > > Wouldn't this potentially cause data loss if the called `write` > >

Re: Review Request 39340: RegistryClient: Added streaming response read

2015-10-23 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39340/ --- (Updated Oct. 23, 2015, 5:20 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38654: Added digest verifier for image blobs

2015-10-23 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38654/ --- (Updated Oct. 23, 2015, 5:31 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-10-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39595/#review103813 --- Patch looks great! Reviews applied: [39594, 39595] All tests

Re: Review Request 39399: Quota: Refactored hierarchical allocator in preparation for quota.

2015-10-23 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39399/ --- (Updated Oct. 23, 2015, 4:38 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39579: Updated docker registry client to check HTTP code.

2015-10-23 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39579/#review103795 --- src/slave/containerizer/provisioner/docker/registry_client.cpp

Re: Review Request 39540: Windows: Moved `os::getcwd` to its own file, `stout/os/getcwd.hpp`.

2015-10-23 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39540/#review103800 --- Ship it! Confirmed that `getcwd` logic is unchanged.

Re: Review Request 39541: Windows: Moved `os::chdir` to its own file, `stout/os/chdir.hpp`.

2015-10-23 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39541/#review103802 --- Ship it! Confirmed that `chdir` logic is unchanged. - Joseph Wu

Re: Review Request 39540: Windows: Moved `os::getcwd` to its own file, `stout/os/getcwd.hpp`.

2015-10-23 Thread Alex Clemmer
> On Oct. 23, 2015, 4:56 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/getcwd.hpp, line 17 > > > > > > This isn't used, is it? Ah, yes, I remember thinking that we _should_ make

Re: Review Request 39317: Quota: Moved QuotaInfo protobuf into a separate package.

2015-10-23 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39317/ --- (Updated Oct. 23, 2015, 4:38 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39579: Updated docker registry client to check HTTP code.

2015-10-23 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39579/#review103791 --- Ship it! LGTM! Ship It! - Gilbert Song On Oct. 23, 2015, 12:58

Re: Review Request 39340: RegistryClient: Added streaming response read

2015-10-23 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39340/ --- (Updated Oct. 23, 2015, 4:55 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38747: Adding digest utilities

2015-10-23 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Oct. 23, 2015, 4:56 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 38654: Added digest verifier for image blobs

2015-10-23 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38654/ --- (Updated Oct. 23, 2015, 5:30 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 39493: Added `yum update nss` to CentOS 6.6 install docs.

2015-10-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39493/#review103891 --- Patch looks great! Reviews applied: [39493] All tests passed. -

Re: Review Request 39493: Added `yum update nss` to CentOS 6.6 install docs.

2015-10-23 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39493/#review103894 --- docs/getting-started.md (line 61)

Re: Review Request 39531: Clarify NetworkInfo semantics for IP addresses and group policies.

2015-10-23 Thread Connor Doyle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39531/ --- (Updated Oct. 23, 2015, 7:21 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

2015-10-23 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38627/#review103837 --- LGTM - Kapil, any thoughts? - Niklas Nielsen On Oct. 21, 2015,

Re: Review Request 39597: Add Newbie guide.

2015-10-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39597/#review103835 --- Patch looks great! Reviews applied: [39597] All tests passed. -

Re: Review Request 39531: Clarify NetworkInfo semantics for IP addresses and group policies.

2015-10-23 Thread Connor Doyle
> On Oct. 23, 2015, 12:06 a.m., Niklas Nielsen wrote: > > include/mesos/mesos.proto, line 1389 > > > > > > 'the actual assigned IP adress' reads a bit odd. How about something > > like: "A user can request an

Re: Review Request 39531: Clarify NetworkInfo semantics for IP addresses and group policies.

2015-10-23 Thread Connor Doyle
> On Oct. 23, 2015, 12:06 a.m., Niklas Nielsen wrote: > > include/mesos/v1/mesos.proto, line 1343 > > > > > > As a non-native speaker; what's the consistency around capitalizing > > framework :) I personally find

Re: Review Request 39614: Quota: Added Status Validation Tests.

2015-10-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/#review103890 --- Patch looks great! Reviews applied: [39317, 38218, 36913, 38059,

Review Request 39594: [stout]: Added function to simultaneously query size and mtime of URI.

2015-10-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39594/ --- Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff.

Review Request 39595: Took mtime into account in the fetcher cache.

2015-10-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39595/ --- Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff.

Review Request 39597: Add Newbie guide.

2015-10-23 Thread Diana Arroyo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39597/ --- Review request for mesos and Timothy Chen. Bugs: MESOS-3224

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

2015-10-23 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Oct. 22, 2015, 11:19 p.m.) Review request for mesos, Joris Van

Re: Review Request 38874: Refactored executor struct in Agent for the Executor HTTP API

2015-10-23 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38874/#review103723 --- Ship it! Thanks for the patience and for reworking the patches!

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

2015-10-23 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Oct. 22, 2015, 11:58 p.m.) Review request for mesos, Joris Van

Re: Review Request 39548: SchedulerTest.Suppress is flaky

2015-10-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39548/#review103735 --- Patch looks great! Reviews applied: [39548] All tests passed. -

Re: Review Request 39410: Added support for github to apply-reviews.py.

2015-10-23 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/#review103731 --- Ship it! This looks great - a really few minor nits, but then

Re: Review Request 39410: Added support for github to apply-reviews.py.

2015-10-23 Thread Artem Harutyunyan
> On Oct. 19, 2015, 10:06 p.m., Marco Massenzio wrote: > > support/apply-reviews.py, line 160 > > > > > > you don't really need to escape the quotes, just take advantage of > > Python being able to use single and

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

2015-10-23 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/ --- (Updated Oct. 22, 2015, 11:18 p.m.) Review request for mesos, Benjamin

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

2015-10-23 Thread Artem Harutyunyan
> On Oct. 22, 2015, 11:48 p.m., Marco Massenzio wrote: > > Looks good - I'd still be happier with "Better Bash" :) would you mind > > "fixing" apply-review.sh? > > > > Thanks! Done. - Artem --- This is an automatically generated

Re: Review Request 39410: Added support for github to apply-reviews.py.

2015-10-23 Thread Artem Harutyunyan
> On Oct. 19, 2015, 10:06 p.m., Marco Massenzio wrote: > > support/apply-reviews.py, lines 277-282 > > > > > > this code look familiar and I remember already commenting about > > `applied` :) > > Artem Harutyunyan

Re: Review Request 39410: Added support for github to apply-reviews.py.

2015-10-23 Thread Marco Massenzio
> On Oct. 20, 2015, 5:06 a.m., Marco Massenzio wrote: > > support/apply-reviews.py, line 160 > > > > > > you don't really need to escape the quotes, just take advantage of > > Python being able to use single and

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-10-23 Thread Artem Harutyunyan
> On Oct. 22, 2015, 2:20 p.m., Vinod Kone wrote: > > support/apply-reviews.py, line 25 > > > > > > s/extract_// Marco commented earlier on this one `nit: you are 'masking' the global builtin id() here - that's a

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

2015-10-23 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/#review103729 --- Ship it! Looks good - I'd still be happier with "Better Bash" :)

Re: Review Request 39410: Added support for github to apply-reviews.py.

2015-10-23 Thread Marco Massenzio
> On Oct. 20, 2015, 5:06 a.m., Marco Massenzio wrote: > > support/apply-reviews.py, line 106 > > > > > > it would be really nice if we could make our code work under both 2.7 > > and 3.x Python ;) > > Artem

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

2015-10-23 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39604/ --- (Updated Oct. 23, 2015, 3:21 p.m.) Review request for mesos, Ben Mahler, Jie

Review Request 39614: Quota: Added Status Validation Tests.

2015-10-23 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/ --- Review request for mesos, Alexander Rukletsov and Bernd Mathiske. Bugs:

Re: Review Request 39492: Added status endpoint for quota master endpoint.

2015-10-23 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/ --- (Updated Oct. 23, 2015, 10:34 p.m.) Review request for mesos, Alexander

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

2015-10-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39325/#review103873 --- Looks good to me except the last test. Looks quite ugly to me:(

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

2015-10-23 Thread Neil Conway
> On Oct. 23, 2015, 11:52 p.m., Jie Yu wrote: > > Looks good to me except the last test. Looks quite ugly to me:( Still > > thinking about better solutions. > > > > The code part looks good to me, we can commit that first (with one more > > unit test to test the coordinator election logic

Re: Review Request 39493: Added `yum update nss` to CentOS 6.6 install docs.

2015-10-23 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39493/ --- (Updated Oct. 23, 2015, 11:58 p.m.) Review request for mesos, Adam B and

Re: Review Request 39230: Added prevention of SASL deprecation warnings all around its invocations on OS X.

2015-10-23 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39230/#review103885 --- Ship it! Ship It! - Michael Park On Oct. 22, 2015, 10:02 a.m.,

Re: Review Request 39591: [stout]: Made license-headers doxygen-compatible.

2015-10-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39591/ --- (Updated Oct. 24, 2015, 12:06 a.m.) Review request for mesos, Alexander

Re: Review Request 39590: Made license-headers doxygen-compatible.

2015-10-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39590/ --- (Updated Oct. 24, 2015, 12:06 a.m.) Review request for mesos, Alexander

Re: Review Request 39399: Quota: Refactored hierarchical allocator in preparation for quota.

2015-10-23 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39399/#review103888 --- Ship it! Ship It! - Klaus Ma On Oct. 24, 2015, 12:38 a.m.,

Re: Review Request 37787: Reworked Jenkins build script. Added test images for ubuntu-14.04-gcc-4.8, ubuntu-14.04-clang-3.6, ubuntu-12.04-gcc-4.8, centos-7.1-gcc-4.8.

2015-10-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37787/#review103889 --- Patch looks great! Reviews applied: [39604, 37787] All tests

Re: Review Request 39410: Added support for github to apply-reviews.py.

2015-10-23 Thread Artem Harutyunyan
> On Oct. 23, 2015, 12:18 a.m., Marco Massenzio wrote: > > support/apply-reviews.py, lines 287-290 > > > > > > does this work? (I really am curious, I didn't know about the 'mutually > > exclusive' option!) > >

Re: Review Request 39410: Added support for github to apply-reviews.py.

2015-10-23 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Oct. 23, 2015, 4:13 p.m.) Review request for mesos, Adam B, Joris Van

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

2015-10-23 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39604/#review103875 --- src/slave/containerizer/linux_launcher.cpp (lines 187 - 190)

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

2015-10-23 Thread Till Toenshoff
> On Oct. 23, 2015, 11:18 p.m., Till Toenshoff wrote: > > src/slave/containerizer/linux_launcher.cpp, lines 187-190 > > > > > > It is pretty well readable already, hence this point is VERY minor... > > > >

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

2015-10-23 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39604/#review103880 --- src/slave/containerizer/linux_launcher.cpp (line 181)

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

2015-10-23 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39604/ --- (Updated Oct. 23, 2015, 4:48 p.m.) Review request for mesos, Ben Mahler, Jie

Re: Review Request 39223: WIP Added Quota Request Validation Tests.

2015-10-23 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/ --- (Updated Oct. 23, 2015, 9:10 p.m.) Review request for mesos, Alexander

Re: Review Request 39223: Added Quota Request Validation Tests.

2015-10-23 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/ --- (Updated Oct. 23, 2015, 9:10 p.m.) Review request for mesos, Alexander

Re: Review Request 39492: Added status endpoint for quota master endpoint.

2015-10-23 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/ --- (Updated Oct. 23, 2015, 9:32 p.m.) Review request for mesos, Alexander

Re: Review Request 37787: Reworked Jenkins build script. Added test images for ubuntu-14.04-gcc-4.8, ubuntu-14.04-clang-3.6, ubuntu-12.04-gcc-4.8, centos-7.1-gcc-4.8.

2015-10-23 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37787/ --- (Updated Oct. 23, 2015, 2:43 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

2015-10-23 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39604/ --- (Updated Oct. 23, 2015, 2:58 p.m.) Review request for mesos, Ben Mahler, Jie

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

2015-10-23 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39604/#review103872 --- Ship it! Ship It! - Kapil Arya On Oct. 23, 2015, 5:58 p.m.,

Re: Review Request 39450: Quota: Added hierarchical allocator-specific tests.

2015-10-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39450/#review103874 --- Patch looks great! Reviews applied: [39317, 38218, 39399, 39400,

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

2015-10-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review103858 --- Patch looks great! Reviews applied: [39537, 39538, 39539, 39540,

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

2015-10-23 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39604/ --- (Updated Oct. 23, 2015, 2:35 p.m.) Review request for mesos, Ben Mahler, Joris

Re: Review Request 37787: Reworked Jenkins build script. Added test images for ubuntu-14.04-gcc-4.8, ubuntu-14.04-clang-3.6, ubuntu-12.04-gcc-4.8, centos-7.1-gcc-4.8.

2015-10-23 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37787/ --- (Updated Oct. 23, 2015, 2:41 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

2015-10-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39005/ --- (Updated Oct. 23, 2015, 7:49 a.m.) Review request for mesos, Bernd Mathiske,

Review Request 39579: Updated docker registry client to check HTTP code.

2015-10-23 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39579/ --- Review request for mesos, Gilbert Song and Jojy Varghese. Repository: mesos

Re: Review Request 39518: Changed write api.

2015-10-23 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39518/#review103739 --- src/slave/containerizer/provisioner/docker/registry_client.cpp

  1   2   >