Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

2015-11-09 Thread Alexander Rukletsov
> On Nov. 5, 2015, 8:24 p.m., Joseph Wu wrote: > > src/master/quota_handler.cpp, line 52 > > > > > > I feel this shouldn't be left for later. I think I have to apologize for the confusion I create with this ticket.

Re: Review Request 38110: Quota: Checked sanity of quota set requests.

2015-11-09 Thread Alexander Rukletsov
> On Nov. 4, 2015, 2:44 p.m., Qian Zhang wrote: > > src/master/quota_handler.cpp, line 164 > > > > > > Do we want to filter out the slave which is not active (slave->active > > == false)? I think it makes sense

Re: Review Request 39594: [stout]: Added function to simultaneously query size and mtime of URI.

2015-11-09 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39594/#review105488 --- As discussed, let's re-iterate on the actual function / signature.

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-09 Thread Alexander Rukletsov
> On Nov. 6, 2015, 12:39 a.m., Joseph Wu wrote: > > src/tests/master_quota_tests.cpp, lines 110-112 > > > > > > The resource string you have is equivalent to the resource string from > > `CreateSlaveFlags`. Is

Re: Review Request 39410: Added support for github to apply-reviews.py.

2015-11-09 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Nov. 9, 2015, 6:19 a.m.) Review request for mesos, Adam B, Joris Van

Re: Review Request 39285: Added Quota Request Validation.

2015-11-09 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/#review105668 --- Ship it! Ship It! - Klaus Ma On Nov. 9, 2015, 8:51 p.m., Joerg

Re: Review Request 38110: Quota: Checked sanity of quota set requests.

2015-11-09 Thread Alexander Rukletsov
> On Nov. 5, 2015, 10:48 p.m., Joseph Wu wrote: > > src/master/quota_handler.cpp, lines 166-168 > > > > > > I checked the codepaths for `Operation::RESERVE` and apparently there's > > nothing preventing you from

Re: Review Request 39285: Added Quota Request Validation.

2015-11-09 Thread Klaus Ma
> On Nov. 7, 2015, 12:19 a.m., Klaus Ma wrote: > > src/master/quota_handler.cpp, line 140 > > > > > > Suggest to move it into the loop; if any role is not known by master, > > we did not need to continue to check

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-09 Thread Alexander Rukletsov
> On Nov. 3, 2015, 7:14 a.m., Guangya Liu wrote: > > src/tests/master_quota_tests.cpp, line 237 > > > > > > move to upper line? That's what `clang-format` suggests. Also, I think it's slightly readable this way.

Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

2015-11-09 Thread Alexander Rukletsov
> On Oct. 6, 2015, 12:40 p.m., Guangya Liu wrote: > > src/master/quota_handler.cpp, line 65 > > > > > > Just as early comments: What about PUT and DELETE? > > Alexander Rukletsov wrote: > See my comment in the

Re: Review Request 39947: Refactored mock allocator into a separate header file.

2015-11-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39947/#review105670 --- Ship it! Ship It! - Joris Van Remoortere On Nov. 5, 2015,

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

2015-11-09 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/ --- (Updated Nov. 9, 2015, 6:18 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

2015-11-09 Thread Bernd Mathiske
> On Oct. 7, 2015, 7:41 a.m., Bernd Mathiske wrote: > > src/master/quota_handler.cpp, line 66 > > > > > > Given that we have the request object, we can output more diagnostic > > info here. > > Guangya Liu wrote: >

Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

2015-11-09 Thread Alexander Rukletsov
> On Oct. 13, 2015, 3:35 p.m., Joris Van Remoortere wrote: > > src/master/quota_handler.cpp, line 60 > > > > > > Should we follow the pattern of other validation routines where we use > > the validation namespace

Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

2015-11-09 Thread Bernd Mathiske
> On Oct. 7, 2015, 7:41 a.m., Bernd Mathiske wrote: > > src/master/quota_handler.cpp, line 74 > > > > > > Again, we could output more info here. > > Alexander Rukletsov wrote: > What exactly? I checked the

Re: Review Request 39285: Added Quota Request Validation.

2015-11-09 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/ --- (Updated Nov. 9, 2015, 12:51 p.m.) Review request for mesos, Alexander

Re: Review Request 38110: Quota: Checked sanity of quota set requests.

2015-11-09 Thread Alexander Rukletsov
> On Nov. 3, 2015, 5:52 a.m., Guangya Liu wrote: > > src/master/quota_handler.cpp, lines 159-186 > > > > > > How to handle the following cases? Say two roles request quota: r1 and > > r2. > > > > When r1

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-09 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39595/#review105587 --- src/hdfs/hdfs.hpp (lines 204 - 208)

Re: Review Request 39590: Made license-headers doxygen-compatible.

2015-11-09 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39590/ --- (Updated Nov. 9, 2015, 1:37 p.m.) Review request for mesos, Alexander

Re: Review Request 39591: [stout]: Made license-headers doxygen-compatible.

2015-11-09 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39591/ --- (Updated Nov. 9, 2015, 1:37 p.m.) Review request for mesos, Alexander

Re: Review Request 39592: [libprocess]: Made license-headers doxygen-compatible.

2015-11-09 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39592/ --- (Updated Nov. 9, 2015, 1:37 p.m.) Review request for mesos, Alexander

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-09 Thread Alexander Rukletsov
> On Oct. 8, 2015, 10:21 a.m., Bernd Mathiske wrote: > > src/tests/master_quota_tests.cpp, line 132 > > > > > > How about adding each test function and have it do nothing, with a TODO > > inside, but with a comment

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

2015-11-09 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/#review105755 --- Can you split this into 2 reviews? one adding --parent option and

Re: Review Request 39949: Document and simplify libprocess initialization synchronization logic.

2015-11-09 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39949/ --- (Updated Nov. 9, 2015, 2:23 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 39948: Remove some undocumented, commented-out code within libprocess.

2015-11-09 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39948/ --- (Updated Nov. 9, 2015, 2:23 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 40107: Removed unused checks in command executor.

2015-11-09 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40107/ --- (Updated Nov. 9, 2015, 9:37 p.m.) Review request for mesos, Anand Mazumdar and

Review Request 40107: Removed unused checks in command executor.

2015-11-09 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40107/ --- Review request for mesos, Anand Mazumdar and Till Toenshoff. Repository: mesos

Re: Review Request 39410: Added support for github to apply-reviews.py.

2015-11-09 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/#review105728 --- Ship it! support/apply-reviews.py (line 42)

Re: Review Request 40102: Windows: Unified POSIX and Windows implementation of process.hpp.

2015-11-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40102/#review105759 --- Bad patch! Reviews applied: [39537, 39538, 39539, 39540, 39541,

Re: Review Request 39276: Fixed a bug in which under certains circumstances HTTP 1.1 Pipelining is not respected.

2015-11-09 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39276/ --- (Updated Nov. 10, 2015, 4:58 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

2015-11-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review105788 --- Patch looks great! Reviews applied: [39276, 37998, 37999, 38000,

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

2015-11-09 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Nov. 10, 2015, 5 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 37998: Made ProcessManager::handle() a void returning method.

2015-11-09 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37998/ --- (Updated Nov. 10, 2015, 4:58 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 37999: Implemented http::AuthenticatorManager

2015-11-09 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37999/ --- (Updated Nov. 10, 2015, 4:59 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38000: Added an API for libprocess users to interact with http::AuthenticatorManager

2015-11-09 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/ --- (Updated Nov. 10, 2015, 4:59 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 40125: Fixed quoted strings in executor log messages on agent

2015-11-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40125/#review105794 --- Bad patch! Reviews applied: [40125] Failed command:

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

2015-11-09 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38627/ --- (Updated Nov. 10, 2015, 5:01 a.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

2015-11-09 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Nov. 10, 2015, 5:03 a.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

2015-11-09 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Nov. 10, 2015, 5:02 a.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 40062: MESOS-2315 Deprecate/Remove CommandInfo::ContainerInfo

2015-11-09 Thread Vaibhav Khanduja
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40062/ --- (Updated Nov. 10, 2015, 5:16 a.m.) Review request for mesos and Adam B.

Re: Review Request 39250: Puller refactor: moved untar to a common place

2015-11-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39250/#review105780 --- Bad patch! Reviews applied: [39832, 39882, 39839, 38579, 39015,

Re: Review Request 39410: Added support for github to apply-reviews.py.

2015-11-09 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/#review105786 --- support/apply-reviews.py (lines 187 - 188)

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

2015-11-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review105787 --- Bad patch! Reviews applied: [39276] Failed command:

Re: Review Request 40062: MESOS-2315 Deprecate/Remove CommandInfo::ContainerInfo

2015-11-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40062/#review105790 --- Bad patch! Reviews applied: [40062] Failed command:

Review Request 40125: Fixed quoted strings in executor log messages on agent

2015-11-09 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40125/ --- Review request for mesos, Joris Van Remoortere and Neil Conway. Repository:

Re: Review Request 40062: MESOS-2315 Deprecate/Remove CommandInfo::ContainerInfo

2015-11-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40062/#review105795 --- Patch looks great! Reviews applied: [40062] All tests passed. -

Re: Review Request 40062: MESOS-2315 Deprecate/Remove CommandInfo::ContainerInfo

2015-11-09 Thread Vaibhav Khanduja
> On Nov. 9, 2015, 7:27 p.m., Joseph Wu wrote: > > include/mesos/mesos.proto, line 372 > > > > > > Should we also remove this from v1/mesos.proto? Fixed - Vaibhav

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

2015-11-09 Thread Alex Clemmer
> On Nov. 2, 2015, 8:38 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp, > > lines 34-71 > > > > > > Can you please explain why we can't just use

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/#review105714 --- Patch looks great! Reviews applied: [39985, 39986, 39987, 39988,

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

2015-11-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/#review105685 --- Bad patch! Reviews applied: [38705, 38883, 39410] Failed

Re: Review Request 40087: Added a list of protocols supported by the Mesos fetcher as requested in MESOS-2783

2015-11-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40087/#review105692 --- Bad patch! Reviews applied: [40087] Failed command:

Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

2015-11-09 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38059/ --- (Updated Nov. 9, 2015, 4:39 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

2015-11-09 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/ --- (Updated Nov. 9, 2015, 5:26 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

2015-11-09 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39559/ --- (Updated Nov. 9, 2015, 5:58 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-09 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38956/ --- (Updated Nov. 9, 2015, 5:49 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39966: Fix a typo in ssl.md: After -> Before

2015-11-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39966/#review105712 --- Ship it! Ship It! - Joris Van Remoortere On Nov. 5, 2015, 4:02

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-09 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38956/ --- (Updated Nov. 9, 2015, 5:39 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

2015-11-09 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/ --- (Updated Nov. 9, 2015, 5:26 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-11-09 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39986/ --- (Updated Nov. 9, 2015, 5:26 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39985: [1/5] Introduced ACL protobuf definitions for dynamic reservation.

2015-11-09 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39985/ --- (Updated Nov. 9, 2015, 5:25 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39987: [3/5] Added 'Master::authorize' for Reserve/Unreserve.

2015-11-09 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39987/ --- (Updated Nov. 9, 2015, 5:26 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 38110: Quota: Checked sanity of quota set requests.

2015-11-09 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38110/ --- (Updated Nov. 9, 2015, 5:37 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39018: Added JSON parsing for Resources.

2015-11-09 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/ --- (Updated Nov. 9, 2015, 4:48 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 39410: Added support for github to apply-reviews.py.

2015-11-09 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Nov. 9, 2015, 7:32 a.m.) Review request for mesos, Adam B, Joris Van

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-11-09 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated Nov. 9, 2015, 4:06 p.m.) Review request for mesos, Alexander

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

2015-11-09 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38218/ --- (Updated Nov. 9, 2015, 3:25 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40087: Added a list of protocols supported by the Mesos fetcher as requested in MESOS-2783

2015-11-09 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40087/#review105693 --- docs/fetcher.md (line 19)

Re: Review Request 39317: Quota: Moved `QuotaInfo` protobuf into a separate package.

2015-11-09 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39317/ --- (Updated Nov. 9, 2015, 3:23 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

2015-11-09 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38059/ --- (Updated Nov. 9, 2015, 3:59 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39018: Added JSON parsing for Resources.

2015-11-09 Thread Greg Mann
> On Nov. 9, 2015, 6:43 a.m., Adam B wrote: > > src/common/resources.cpp, lines 356-357 > > > > > > Doesn't Resources::validate() return an Error? Why not use that Error > > and its message with your return?

Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

2015-11-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38059/#review105192 --- src/master/quota_handler.cpp (lines 44 - 47)

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

2015-11-09 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Nov. 9, 2015, 7:31 a.m.) Review request for mesos, Joris Van

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

2015-11-09 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Nov. 9, 2015, 7:31 a.m.) Review request for mesos, Joris Van

Review Request 40087: Added a list of protocols supported by the Mesos fetcher as requested in MESOS-2783

2015-11-09 Thread Andrey Dyatlov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40087/ --- Review request for mesos, Alexander Rojas and Bernd Mathiske. Bugs: MESOS-2783

Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

2015-11-09 Thread Joseph Wu
> On Nov. 5, 2015, 12:24 p.m., Joseph Wu wrote: > > src/master/quota_handler.cpp, lines 83-88 > > > > > > Why don't you just parse a QuotaInfo object instead of a > > form-serialized body (with JSON components)? >

Re: Review Request 38747: Adding digest utilities

2015-11-09 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Nov. 9, 2015, 8:17 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 39285: Added Quota Request Validation.

2015-11-09 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/ --- (Updated Nov. 9, 2015, 7:31 p.m.) Review request for mesos, Alexander

Re: Review Request 39331: Support docker local store pull image simultaneously

2015-11-09 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39331/ --- (Updated Nov. 9, 2015, 11:26 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 39331: Support docker local store pull image simultaneously

2015-11-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39331/#review105733 --- Bad patch! Reviews applied: [39331] Failed command:

Re: Review Request 40062: MESOS-2315 Deprecate/Remove CommandInfo::ContainerInfo

2015-11-09 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40062/#review105723 --- include/mesos/mesos.proto

Re: Review Request 39949: Document and simplify libprocess initialization synchronization logic.

2015-11-09 Thread Joseph Wu
> On Nov. 7, 2015, 7:35 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/process.cpp, lines 742-770 > > > > > > Could we document why we're not just using process::Once to clean this > > up? > > > > The

Re: Review Request 39285: Added Quota Request Validation.

2015-11-09 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/ --- (Updated Nov. 9, 2015, 8:25 p.m.) Review request for mesos, Alexander

Re: Review Request 39636: FreeBSD: Add basic support to stout

2015-11-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39636/#review105800 --- Bad patch! Reviews applied: [39634, 39635] Failed command:

Re: Review Request 39410: Added support for github to apply-reviews.py.

2015-11-09 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Nov. 9, 2015, 11:48 p.m.) Review request for mesos, Adam B, Joris Van

Re: Review Request 39410: Added support for github to apply-reviews.py.

2015-11-09 Thread Artem Harutyunyan
> On Nov. 9, 2015, 8:11 p.m., Kapil Arya wrote: > > support/apply-reviews.py, lines 196-197 > > > > > > Can we enhance it as following: > > ``` > > amend=options['no_amend'] ? '' : '-e' > > cmd = 'git

Re: Review Request 39636: FreeBSD: Add basic support to stout

2015-11-09 Thread David Forsythe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39636/ --- (Updated Nov. 10, 2015, 6:35 a.m.) Review request for mesos and Ian Downes.

Re: Review Request 39634: FreeBSD: Enable mesos build and start fixing some tests

2015-11-09 Thread David Forsythe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39634/ --- (Updated Nov. 10, 2015, 6:35 a.m.) Review request for mesos and Ian Downes.

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-11-09 Thread Joris Van Remoortere
> On Nov. 6, 2015, 2:58 p.m., Klaus Ma wrote: > > src/master/quota_handler.cpp, line 1 > > > > > > It seems other feature named file without "_handler"; any consideration > > for it? > > Joerg Schad wrote: > In

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

2015-11-09 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Nov. 9, 2015, 11:57 p.m.) Review request for mesos, Joris Van

Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

2015-11-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38059/#review105801 --- Let's just try and make this chain a little easier to follow.

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

2015-11-09 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Nov. 9, 2015, 11:56 p.m.) Review request for mesos, Joris Van

Re: Review Request 40125: Fixed quoted strings in executor log messages on agent

2015-11-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40125/#review105797 --- Ship it! Ship It! - Joris Van Remoortere On Nov. 10, 2015,

Re: Review Request 39635: FreeBSD: Enable libprocess build and disable failing test

2015-11-09 Thread David Forsythe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39635/ --- (Updated Nov. 10, 2015, 6:35 a.m.) Review request for mesos and Ian Downes.

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-11-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/#review105798 --- Ship it! src/master/master.hpp (line 859)

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-11-09 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/ --- (Updated Nov. 9, 2015, 2:52 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

2015-11-09 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/ --- (Updated Nov. 9, 2015, 2:57 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 39410: Added support for github to apply-reviews.py.

2015-11-09 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Nov. 9, 2015, 2:57 a.m.) Review request for mesos, Adam B, Joris Van

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

2015-11-09 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Nov. 9, 2015, 2:58 a.m.) Review request for mesos, Joris Van

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

2015-11-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/#review105664 --- Bad patch! Reviews applied: [38705, 38883, 39410, 39420] Failed

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

2015-11-09 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Nov. 9, 2015, 11:33 p.m.) Review request for mesos, Adam B, Benjamin

  1   2   >