Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-10 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39595/#review105881 --- Ship it! src/hdfs/hdfs.hpp (lines 205 - 210)

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-10 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39595/ --- (Updated Nov. 10, 2015, 4:14 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39450: Quota: Added hierarchical allocator-specific tests.

2015-11-10 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39450/#review105885 --- src/tests/hierarchical_allocator_tests.cpp (line 1150)

Re: Review Request 40107: Removed unused checks in command executor.

2015-11-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40107/#review105877 --- Ship it! Ship It! - haosdent huang On Nov. 10, 2015, 1:21

Re: Review Request 40107: Removed unused checks in command executor.

2015-11-10 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40107/#review105879 --- Ship it! Ship It! - Bernd Mathiske On Nov. 10, 2015, 5:21

Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

2015-11-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38059/ --- (Updated Nov. 10, 2015, 4:19 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-10 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39595/ --- (Updated Nov. 10, 2015, 4:19 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39285: Added Quota Request Validation.

2015-11-10 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/ --- (Updated Nov. 10, 2015, 3:43 p.m.) Review request for mesos, Alexander

Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

2015-11-10 Thread Alexander Rukletsov
> On Nov. 10, 2015, 7:26 a.m., Joris Van Remoortere wrote: > > src/master/quota_handler.cpp, line 48 > > > > > > Let's sync this to a `Try` to avoid confusion. I think I'd better remove the whole function

Re: Review Request 38399: Add ACLs for the maintenance HTTP endpoints

2015-11-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38399/#review105884 --- docs/authorization.md (line 12)

Re: Review Request 39450: Quota: Added hierarchical allocator-specific tests.

2015-11-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39450/ --- (Updated Nov. 10, 2015, 5:51 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39285: Added Quota Request Validation.

2015-11-10 Thread Vinod Kone
joerg, can you please make sure these reviews have linear dependencies? i'm seeing some reviews that block multiple reviews!? are you not using the post-reviews script? On Tue, Nov 10, 2015 at 10:20 AM, Joerg Schad wrote: > >

Re: Review Request 38110: Quota: Checked sanity of quota set requests.

2015-11-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38110/ --- (Updated Nov. 10, 2015, 7:02 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40142: Corrected include order for gtest and gmock according to Styleguide.

2015-11-10 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40142/ --- (Updated Nov. 10, 2015, 5:22 p.m.) Review request for mesos and Jan Schlicht.

Re: Review Request 39250: Puller refactor: moved untar to a common place

2015-11-10 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39250/#review105905 --- Ship it! Ship It! - Timothy Chen On Nov. 10, 2015, 1:25 a.m.,

Re: Review Request 39851: Windows: fixed ambiguousity error in `process/owned.hpp`.

2015-11-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39851/#review105926 --- Ship it! Double-checked non-Windows build. - Joseph Wu On Nov.

Re: Review Request 40142: Corrected include order for gtest and gmock according to Styleguide.

2015-11-10 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40142/#review105898 --- Ship it! Ship It! - Jan Schlicht On Nov. 10, 2015, 6:14 p.m.,

Re: Review Request 40142: Corrected include order for gtest and gmock according to Styleguide.

2015-11-10 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40142/ --- (Updated Nov. 10, 2015, 5:14 p.m.) Review request for mesos and Jan Schlicht.

Re: Review Request 40142: Corrected include order for gtest and gmock according to Styleguide.

2015-11-10 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40142/ --- (Updated Nov. 10, 2015, 5:13 p.m.) Review request for mesos and Jan Schlicht.

Re: Review Request 39285: Added Quota Request Validation.

2015-11-10 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/#review105913 --- src/master/quota.cpp (line 36)

Re: Review Request 39285: Added Quota Request Validation.

2015-11-10 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/ --- (Updated Nov. 10, 2015, 6:10 p.m.) Review request for mesos, Alexander

Re: Review Request 40142: Corrected include order for gtest and gmock according to Styleguide.

2015-11-10 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40142/ --- (Updated Nov. 10, 2015, 6:30 p.m.) Review request for mesos and Jan Schlicht.

Re: Review Request 39285: Added Quota Request Validation.

2015-11-10 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/ --- (Updated Nov. 10, 2015, 6:20 p.m.) Review request for mesos, Alexander

Re: Review Request 39484: Add resource usage section to MesosContainerizer and DockerContainerizer documentation

2015-11-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39484/#review105930 --- Bad patch! Reviews applied: [39484] Failed command:

Re: Review Request 40142: Corrected include order for gtest and gmock according to Styleguide.

2015-11-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40142/#review105904 --- Bad patch! Reviews applied: [40142] Failed command:

Re: Review Request 40142: Corrected include order for gtest and gmock according to Styleguide.

2015-11-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40142/#review105910 --- Patch looks great! Reviews applied: [40142] All tests passed. -

Re: Review Request 39285: Added Quota Request Validation.

2015-11-10 Thread Joseph Wu
The tree structure of the reviews is intentional (at the moment). It's currently roughly split into components like: / Registrar / POST Protobufs - /quota endpoint - Authentication \ Allocator \ \ GET \- DELETE ~Joseph On Tue, Nov 10,

Re: Review Request 39484: Add resource usage section to MesosContainerizer and DockerContainerizer documentation

2015-11-10 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39484/ --- (Updated Nov. 10, 2015, 11:17 a.m.) Review request for mesos, Kapil Arya,

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-10 Thread Alexander Rukletsov
> On Nov. 6, 2015, 12:39 a.m., Joseph Wu wrote: > > src/tests/master_quota_tests.cpp, lines 147-148 > > > > > > Rather than re-defining this, can you populate it via the result of > >

Re: Review Request 39331: Support docker local store pull image simultaneously

2015-11-10 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39331/#review105962 --- src/slave/containerizer/mesos/provisioner/docker/store.cpp (line

Re: Review Request 40146: Windows: Unifies POSIX and Windows PSTree implementations

2015-11-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40146/#review105938 --- Bad patch! Reviews applied: [39537, 39538, 39539, 39540, 39541,

Re: Review Request 40146: Windows: Unifies POSIX and Windows PSTree implementations

2015-11-10 Thread Steve Butler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40146/ --- (Updated Nov. 10, 2015, 8:14 p.m.) Review request for mesos and Alex Clemmer.

Re: Review Request 39289: Quota: Added authorization of quota requests.

2015-11-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39289/#review105954 --- Looks good overall. docs/authorization.md (line 35)

Re: Review Request 37336: Simplified the caller interface to process::Subprocess

2015-11-10 Thread Marco Massenzio
> On Nov. 7, 2015, 1:06 a.m., Michael Park wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, line 91 > > > > > > How come `Invocation` is within `Subprocess::Result`? Wouldn't it make > > more sense

Re: Review Request 40129: Updated apply-review.sh to use apply-reviews.py.

2015-11-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40129/#review105943 --- Ship it! support/apply-review.sh

Re: Review Request 37336: Added `execute()` method to process::Subprocess

2015-11-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37336/#review105960 --- Patch looks great! Reviews applied: [37336] All tests passed. -

Re: Review Request 39420: Added '--chain' option to apply-reviews.py.

2015-11-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/#review105941 --- Ship it! support/apply-reviews.py (line 320)

Re: Review Request 37336: Added `execute()` method to process::Subprocess

2015-11-10 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37336/ --- (Updated Nov. 10, 2015, 8:51 p.m.) Review request for mesos, Joris Van

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-10 Thread Joseph Wu
> On Nov. 5, 2015, 4:39 p.m., Joseph Wu wrote: > > src/tests/master_quota_tests.cpp, lines 110-112 > > > > > > The resource string you have is equivalent to the resource string from > > `CreateSlaveFlags`. Is

Re: Review Request 40142: Corrected include order for gtest and gmock according to Styleguide.

2015-11-10 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40142/#review105981 --- src/tests/containerizer.hpp (line 19)

Re: Review Request 39400: Quota: Implemented quota API.

2015-11-10 Thread Alexander Rukletsov
> On Nov. 10, 2015, 9:21 a.m., Joerg Schad wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 925 > > > > > > Do you want to -symetrically to your todu when setting quota- print the > > actual quota

Re: Review Request 39400: Quota: Implemented quota API.

2015-11-10 Thread Alexander Rukletsov
> On Nov. 10, 2015, 10:09 a.m., Joris Van Remoortere wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 140 > > > > > > Maybe s/Introduce/Consider introducing/ > > Are we sure we want to do this? A

Re: Review Request 39400: Quota: Implemented quota API.

2015-11-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39400/ --- (Updated Nov. 10, 2015, 11:06 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40142: Corrected include order for gtest and gmock according to Styleguide.

2015-11-10 Thread Joerg Schad
> On Nov. 10, 2015, 10:41 p.m., Guangya Liu wrote: > > src/tests/containerizer.hpp, line 19 > > > > > > I see that we have some discussion in mail list, can you please add > > more detail for what we discussed in

Re: Review Request 40162: Updated docker build script to install libev package.

2015-11-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40162/#review106001 --- Patch looks great! Reviews applied: [39953, 39954, 39914, 40162]

Re: Review Request 39331: Support docker local store pull image simultaneously

2015-11-10 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39331/#review105965 --- src/slave/containerizer/mesos/provisioner/docker/store.cpp (line

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38956/ --- (Updated Nov. 10, 2015, 10 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39399: Quota: Refactored hierarchical allocator in preparation for quota.

2015-11-10 Thread Alexander Rukletsov
> On Nov. 10, 2015, 8:56 a.m., Joris Van Remoortere wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 337 > > > > > > let's pull fixes like this out separately. I'll gladly commit it as a > > distinct

Re: Review Request 39400: Quota: Implemented quota API.

2015-11-10 Thread Alexander Rukletsov
> On Nov. 10, 2015, 9:21 a.m., Joerg Schad wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 359 > > > > > > s/the/this Re-phrasing it a bit deeper. > On Nov. 10, 2015, 9:21 a.m., Joerg Schad wrote: >

Re: Review Request 40162: Updated docker build script to install libev package.

2015-11-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40162/#review105996 --- Bad patch! Reviews applied: [39953, 39954, 39914] Failed

Re: Review Request 39914: Changed verify_review to use docker_build.sh.

2015-11-10 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39914/ --- (Updated Nov. 11, 2015, 12:14 a.m.) Review request for mesos, Cody Maloney and

Re: Review Request 39223: Added Quota Request Validation Tests.

2015-11-10 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/ --- (Updated Nov. 10, 2015, 10:27 p.m.) Review request for mesos, Alexander

Re: Review Request 39628: Clear the suppressed flag when deactive a framework

2015-11-10 Thread Vinod Kone
> On Oct. 25, 2015, 2:51 p.m., Ben Mahler wrote: > > Can you please add a test that would have caught this issue? > > Guangya Liu wrote: > I think this is a bug, I tested without my code change, the test also > failed sometimes. Shall we file a bug for this? > > Vinod Kone wrote: >

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

2015-11-10 Thread Qian Zhang
> On Nov. 1, 2015, 8:14 p.m., Qian Zhang wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1005 > > > > > > For this TODO, what do we plan to do in future? Include the dynamic > > reserved resources for

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

2015-11-10 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38627/#review105805 --- Ship it! Ship It! - Till Toenshoff On Nov. 10, 2015, 4:01

Review Request 40129: Updated apply-review.sh to use apply-reviews.py.

2015-11-10 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40129/ --- Review request for mesos, Joris Van Remoortere and Vinod Kone. Bugs:

Re: Review Request 39285: Added Quota Request Validation.

2015-11-10 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/ --- (Updated Nov. 10, 2015, 8:37 a.m.) Review request for mesos, Alexander

Re: Review Request 39420: Added '--chain' option to apply-reviews.py.

2015-11-10 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Nov. 10, 2015, 12:03 a.m.) Review request for mesos, Joris Van

Re: Review Request 39634: FreeBSD: Enable mesos build and start fixing some tests

2015-11-10 Thread David Forsythe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39634/ --- (Updated Nov. 10, 2015, 8:33 a.m.) Review request for mesos and Ian Downes.

Re: Review Request 39636: FreeBSD: Add basic support to stout

2015-11-10 Thread David Forsythe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39636/ --- (Updated Nov. 10, 2015, 8:33 a.m.) Review request for mesos and Ian Downes.

Re: Review Request 39635: FreeBSD: Enable libprocess build and disable failing test

2015-11-10 Thread David Forsythe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39635/ --- (Updated Nov. 10, 2015, 8:33 a.m.) Review request for mesos and Ian Downes.

Re: Review Request 38876: Added functionality to store a marker file to denote HTTP based executors

2015-11-10 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38876/#review105807 --- Ship it! Thanks, just some small cleanups and we should be all

Re: Review Request 39285: Added Quota Request Validation.

2015-11-10 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/#review105772 --- src/master/quota_handler.cpp (line 75)

Re: Review Request 40129: Updated apply-review.sh to use apply-reviews.py.

2015-11-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40129/#review105811 --- Patch looks great! Reviews applied: [38705, 38883, 39410, 39420,

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-11-10 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated Nov. 10, 2015, 8:49 a.m.) Review request for mesos, Alexander

Re: Review Request 39399: Quota: Refactored hierarchical allocator in preparation for quota.

2015-11-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39399/#review105806 --- src/master/allocator/mesos/hierarchical.hpp (line 337)

Re: Review Request 39285: Added Quota Request Validation.

2015-11-10 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/ --- (Updated Nov. 10, 2015, 9:07 a.m.) Review request for mesos, Alexander

Re: Review Request 39400: Quota: Implemented quota API.

2015-11-10 Thread Joris Van Remoortere
> On Oct. 25, 2015, 9:06 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 903 > > > > > > I see that in the code, some are using > > > > '" << xxx << "'"; > > > >

Re: Review Request 39400: Quota: Implemented quota API.

2015-11-10 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39400/#review105817 --- src/master/allocator/mesos/hierarchical.hpp (line 358)

Re: Review Request 40087: Added a list of protocols supported by the Mesos fetcher as requested in MESOS-2783

2015-11-10 Thread Andrey Dyatlov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40087/ --- (Updated Nov. 10, 2015, 11 a.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 40087: Added a list of protocols supported by the Mesos fetcher as requested in MESOS-2783

2015-11-10 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40087/#review105818 --- Ship it! Ship It! - Bernd Mathiske On Nov. 10, 2015, 2 a.m.,

Re: Review Request 40087: Added a list of protocols supported by the Mesos fetcher as requested in MESOS-2783

2015-11-10 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40087/#review105819 --- Ship it! Ship It! - Jan Schlicht On Nov. 10, 2015, 11 a.m.,

Re: Review Request 39594: [stout]: Added function to simultaneously query size and mtime of URI.

2015-11-10 Thread Jan Schlicht
> On Nov. 9, 2015, 2:54 p.m., Till Toenshoff wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 141 > > > > > > Why not use `nullptr` instead? Is `nullptr` okay to use? Judging from

Re: Review Request 39497: Fixed quotation of interpolated variables in log messages.

2015-11-10 Thread Joris Van Remoortere
> On Oct. 20, 2015, 10:35 p.m., Greg Mann wrote: > > The executor id now has a stream operator that takes care of this formatting. - Joris --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 39594: [stout]: Added function to simultaneously query size and mtime of URI.

2015-11-10 Thread Till Toenshoff
> On Nov. 9, 2015, 1:54 p.m., Till Toenshoff wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 141 > > > > > > Why not use `nullptr` instead? > > Jan Schlicht wrote: > Is `nullptr` okay

Re: Review Request 39285: Added Quota Request Validation.

2015-11-10 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/ --- (Updated Nov. 10, 2015, 10 a.m.) Review request for mesos, Alexander

Re: Review Request 39400: Quota: Implemented quota API.

2015-11-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39400/#review105816 --- src/master/allocator/mesos/hierarchical.hpp (line 358)

Re: Review Request 39594: [stout]: Added function to simultaneously query size and mtime of URI.

2015-11-10 Thread Benjamin Bannier
> On Nov. 9, 2015, 1:54 p.m., Till Toenshoff wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 141 > > > > > > Why not use `nullptr` instead? > > Jan Schlicht wrote: > Is `nullptr` okay

Re: Review Request 40129: Updated apply-review.sh to use apply-reviews.py.

2015-11-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40129/#review105808 --- Bad patch! Reviews applied: [38705, 38883, 39410] Failed

Re: Review Request 39636: FreeBSD: Add basic support to stout

2015-11-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39636/#review105810 --- Bad patch! Reviews applied: [39634] Failed command:

Re: Review Request 39288: Quota: Added authentication of quota requests.

2015-11-10 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39288/ --- (Updated Nov. 10, 2015, 1:55 p.m.) Review request for mesos, Alexander

Re: Review Request 39289: Quota: Added authorization of quota requests.

2015-11-10 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39289/ --- (Updated Nov. 10, 2015, 1:56 p.m.) Review request for mesos, Alexander

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

2015-11-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38956/ --- (Updated Nov. 10, 2015, 12:52 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40107: Removed unused checks in command executor.

2015-11-10 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40107/#review105842 --- This is supposed to be the fix (or workaround) for MESOS-3851,

Re: Review Request 40142: Corrected include order for gtest and gmock according to Styleguide.

2015-11-10 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40142/#review106002 --- Ship it! Given that gmock ist not (and never should be, according

Re: Review Request 40151: Windows: Implemented pids() to get all pids.

2015-11-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40151/#review106007 --- Patch looks great! Reviews applied: [40151] All tests passed. -

Re: Review Request 38110: Quota: Checked sanity of quota set requests.

2015-11-10 Thread Guangya Liu
> On Nov. 3, 2015, 5:52 a.m., Guangya Liu wrote: > > src/master/quota_handler.cpp, lines 159-186 > > > > > > How to handle the following cases? Say two roles request quota: r1 and > > r2. > > > > When r1

Re: Review Request 38110: Quota: Checked sanity of quota set requests.

2015-11-10 Thread Alexander Rukletsov
> On Nov. 4, 2015, 2:44 p.m., Qian Zhang wrote: > > src/master/quota_handler.cpp, line 151 > > > > > > So for this TODO, in future, we want to count dynamically reserved > > resources in ```roleTotal```, right?

Re: Review Request 39420: Added '--chain' option to apply-reviews.py.

2015-11-10 Thread Artem Harutyunyan
> On Nov. 9, 2015, 2:09 p.m., Vinod Kone wrote: > > Can you split this into 2 reviews? one adding --parent option and the other > > updating apply-review.sh to use apply-reviews.py? Done. - Artem --- This is an automatically generated

Re: Review Request 40131: Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.

2015-11-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40131/#review105832 --- Bad patch! Reviews applied: [39537, 39538, 39539, 39540, 39541,

Re: Review Request 38110: Quota: Checked sanity of quota set requests.

2015-11-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38110/ --- (Updated Nov. 10, 2015, 10:52 a.m.) Review request for mesos, Bernd Mathiske,

Review Request 40131: Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.

2015-11-10 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40131/ --- Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van

Re: Review Request 40151: Windows: Implemented pids() to get all pids.

2015-11-10 Thread Matt Dotson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40151/ --- (Updated Nov. 11, 2015, 2:01 a.m.) Review request for mesos and Alex Clemmer.

Review Request 40177: Re-checkpoint frameworks after agent recovery.

2015-11-10 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40177/ --- Review request for mesos, Kapil Arya and Vinod Kone. Bugs: MESOS-3834

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

2015-11-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40177/#review106018 --- Patch looks great! Reviews applied: [40177] All tests passed. -

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

2015-11-10 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/ --- (Updated Nov. 10, 2015, 2:27 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39595/#review105870 --- Patch looks great! Reviews applied: [39594, 39595] All tests

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

2015-11-10 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39401/#review105865 --- src/master/allocator/mesos/hierarchical.cpp (line 984)

Re: Review Request 40107: Removed unused checks in command executor.

2015-11-10 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40107/#review105872 --- Ship it! Ship It! - Till Toenshoff On Nov. 10, 2015, 1:21

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

2015-11-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40177/#review106020 --- Patch looks great! Reviews applied: [40177] All tests passed. -

  1   2   >