Re: Review Request 40665: Clean up redundant os exists check before mkdir.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40665/#review107859
---

Ship it!


Ship It!

- Timothy Chen


On Nov. 24, 2015, 7:22 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40665/
> ---
> 
> (Updated Nov. 24, 2015, 7:22 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Clean up redundant os exist check before mkdir.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp fe74d1fe23e91f81b278c1282bea7801414b92a3 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 8f4b372986a28e293a121a80fee98b23becf225a 
> 
> Diff: https://reviews.apache.org/r/40665/diff/
> 
> 
> Testing
> ---
> 
> make check(ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 40641: Increase launch and wait timeout in LinuxFilesystemIsolatorTest.ROOT_ImageInVolumeWithRootFilesystem.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40641/#review107857
---

Ship it!


Ship It!

- Timothy Chen


On Nov. 24, 2015, 1:45 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40641/
> ---
> 
> (Updated Nov. 24, 2015, 1:45 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Jan Schlicht, Till Toenshoff, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-3966
> https://issues.apache.org/jira/browse/MESOS-3966
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Increase launch and wait timeout in 
> LinuxFilesystemIsolatorTest.ROOT_ImageInVolumeWithRootFilesystem.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> dab3abd0d87ae8ec6e4dea6a48870ace7a3cdad3 
> 
> Diff: https://reviews.apache.org/r/40641/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 40114: Windows: Began adding Windows support to `process/future.hpp`

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40114/
---

(Updated Nov. 24, 2015, 11:04 p.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Joseph Wu.


Repository: mesos


Description
---

Added Windows & Posix defines for several parameter list used in future.hpp. 
Provided a new parameter list for VC2015.
Move the existing parameter list into posix.hpp. 

The change has been due to: 

   1. VS 2015 won't support C++14 result_of SFINAE until Update 2,  so
  result_of must be replaced with decltype(invoke).
   2. VS 2015 won't support C++14 std::function SFINAE until Update 2, so
  converting _Deferred to std::function must be done by explicitly
  calling _Deferred's conversion function.
   3. The Standard (C++11 through 17) does not require bind's function call
  operator to SFINAE, and VS 2015's doesn't.  is_bind_expression can be
  used to manually reroute bind expressions to the 1-arg overload, where
  (conveniently) the argument will be ignored if necessary.


Diffs
-

  3rdparty/libprocess/include/process/future.hpp 
3916150691e9a0880b8b826734fa74bd33d18cfd 
  3rdparty/libprocess/include/process/posix/future.hpp PRE-CREATION 
  3rdparty/libprocess/include/process/windows/future.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40114/diff/


Testing
---

OSX make check, Windows 10 make, Ubuntu 15.1 make check


Thanks,

Daniel Pravat

Re: Review Request 39712: Refactor registry client/puller to avoid JSON and struct.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39712/#review107861
---

Ship it!


Ship It!

- Timothy Chen


On Nov. 24, 2015, 6:52 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39712/
> ---
> 
> (Updated Nov. 24, 2015, 6:52 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3994
> https://issues.apache.org/jira/browse/MESOS-3994
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactor registry client/puller to avoid JSON and struct.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
> 22873276a04941c52e4df41750174c86515f1951 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> 99a421b21cce8311b729689c4c4099206e85dc1f 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 94b7539b1e1d3b83f0c608d2ac3af9aebbd8b2e6 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 88b914d3d4a56a51750a75c0988547e2a3e94f56 
> 
> Diff: https://reviews.apache.org/r/39712/diff/
> 
> 
> Testing
> ---
> 
> make check(ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 40114: Windows: Began adding Windows support to `process/future.hpp`

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40114/#review107866
---

Ship it!


Ship It!

- Alex Clemmer


On Nov. 24, 2015, 11:04 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40114/
> ---
> 
> (Updated Nov. 24, 2015, 11:04 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Windows & Posix defines for several parameter list used in future.hpp. 
> Provided a new parameter list for VC2015.
> Move the existing parameter list into posix.hpp. 
> 
> The change has been due to: 
> 
>1. VS 2015 won't support C++14 result_of SFINAE until Update 2,  so
>   result_of must be replaced with decltype(invoke).
>2. VS 2015 won't support C++14 std::function SFINAE until Update 2, so
>   converting _Deferred to std::function must be done by explicitly
>   calling _Deferred's conversion function.
>3. The Standard (C++11 through 17) does not require bind's function call
>   operator to SFINAE, and VS 2015's doesn't.  is_bind_expression can be
>   used to manually reroute bind expressions to the 1-arg overload, where
>   (conveniently) the argument will be ignored if necessary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/future.hpp 
> 3916150691e9a0880b8b826734fa74bd33d18cfd 
>   3rdparty/libprocess/include/process/posix/future.hpp PRE-CREATION 
>   3rdparty/libprocess/include/process/windows/future.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40114/diff/
> 
> 
> Testing
> ---
> 
> OSX make check, Windows 10 make, Ubuntu 15.1 make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Review Request 40681: Changed mesos-local to use posix launcher as default.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40681/
---

Review request for mesos, Jie Yu and Timothy Chen.


Repository: mesos


Description
---

See MESOS-3793 for more details.


Diffs
-

  src/local/local.cpp d714eb148fa8db2cbbe23175ab859e50eec9036f 

Diff: https://reviews.apache.org/r/40681/diff/


Testing
---

Tested the changes in docker (ubuntu:14.04).


Thanks,

Jojy Varghese

Review Request 40679: Added filtering of CFS cgroup tests.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40679/
---

Review request for mesos, Bernd Mathiske, Marco Massenzio, and Till Toenshoff.


Bugs: MESOS-3964 and MESOS-3978
https://issues.apache.org/jira/browse/MESOS-3964
https://issues.apache.org/jira/browse/MESOS-3978


Repository: mesos


Description
---

Added filtering of CFS cgroup tests.


Diffs
-

  src/tests/environment.cpp ea70a5f5e752f4855b7b0e19ee3c1a60015a76ea 

Diff: https://reviews.apache.org/r/40679/diff/


Testing
---

CFS support is disabled by default and must be enabled via a command-line flag. 
Thus, the test suite should not assume that this feature is present.

To test, run `sudo make check` on Debian 8 or another linux distribution 
without CFS cgroup support.

Mesos should crash during LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs or 
LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs_Big_Quota without this patch, and those 
tests should be filtered out after this patch. I ran `sudo make check` on 
Ubuntu 14.04 and the CFS tests ran like normal, and passed.


Thanks,

Greg Mann

Re: Review Request 40679: Added filtering of CFS cgroup tests.

[Greg Mann]

> On Nov. 25, 2015, 1:35 a.m., haosdent huang wrote:
> > src/tests/environment.cpp, line 129
> > 
> >
> > use `/sys/fs/cgroup` maybe have some problems. centos 6 mount cgroup 
> > under `/cgroup` directly. Could refer to how `void 
> > ContainerizerTest::SetUp()` got cgroup 
> > `baseHierarchy`

OK thanks haosdent! I'll look into this.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40679/#review107892
---


On Nov. 25, 2015, 1:05 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40679/
> ---
> 
> (Updated Nov. 25, 2015, 1:05 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Marco Massenzio, Till Toenshoff, 
> and Timothy Chen.
> 
> 
> Bugs: MESOS-3964 and MESOS-3978
> https://issues.apache.org/jira/browse/MESOS-3964
> https://issues.apache.org/jira/browse/MESOS-3978
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added filtering of CFS cgroup tests.
> 
> 
> Diffs
> -
> 
>   src/tests/environment.cpp ea70a5f5e752f4855b7b0e19ee3c1a60015a76ea 
> 
> Diff: https://reviews.apache.org/r/40679/diff/
> 
> 
> Testing
> ---
> 
> CFS support is disabled by default and must be enabled via a command-line 
> flag. Thus, the test suite should not assume that this feature is present.
> 
> To test, run `sudo make check` on Debian 8 or another linux distribution 
> without CFS cgroup support.
> 
> Mesos should crash during LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs or 
> LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs_Big_Quota without this patch, and 
> those tests should be filtered out after this patch. I ran `sudo make check` 
> on Ubuntu 14.04 and the CFS tests ran like normal, and passed.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 38989: Update docker-containerizer.md.

[haosdent huang]

> On Nov. 24, 2015, 1:26 a.m., Timothy Chen wrote:
> > Can you rebase your patch?

Hi, @tnachen. Thanks for you reviews. After rebase, I find all my changes have 
been fixed in current document. So let me discard this patch.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38989/#review107697
---


On Oct. 5, 2015, 7:50 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38989/
> ---
> 
> (Updated Oct. 5, 2015, 7:50 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update docker-containerizer.md.
> 
> 
> Diffs
> -
> 
>   docs/docker-containerizer.md 091a3ace48aca3b34ba5159f5146237d0bc7611c 
> 
> Diff: https://reviews.apache.org/r/38989/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

[Yong Qiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40431/
---

(Updated Nov. 25, 2015, 1:57 a.m.)


Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.


Bugs: MESOS-3944
https://issues.apache.org/jira/browse/MESOS-3944


Repository: mesos


Description
---

Move RoleInfo message out of allocator.proto


Diffs (updated)
-

  include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0 
  include/mesos/master/allocator.proto 702f56f56c3b1331613cecf26522986f6b572f8c 
  include/mesos/role/role.hpp PRE-CREATION 
  include/mesos/role/role.proto PRE-CREATION 
  src/CMakeLists.txt cfe9d26c45ba42852fd1af958549954e7b04d448 
  src/Makefile.am a57e46d06c8c26a32a9444be4f0e1269d775f8b0 
  src/master/allocator/mesos/allocator.hpp 
97ee80726ad155917811265a983258b0165d3451 
  src/master/allocator/mesos/hierarchical.hpp 
2a21364fdcaa4ec5e5567b9f367c14a1579b9a49 
  src/master/allocator/mesos/hierarchical.cpp 
aee8ced1fbfec8cf30cb939ff67fadfc6b08f37a 
  src/master/master.hpp e5e0ed01a56d869cc535687c8dbb6b99f6295b66 
  src/master/master.cpp 370980edfc80d1e52134fdaf3ce49177b6528b02 
  src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42 
  src/tests/hierarchical_allocator_tests.cpp 
a45b3dd0a8237fdd080536cb9ab600e71ad939d3 

Diff: https://reviews.apache.org/r/40431/diff/


Testing
---

1. Make Check successfully;

2. $ curl http://9.110.48.168:5050/roles
{"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}


Thanks,

Yong Qiao Wang

Re: Review Request 38201: [WIP] precision errors with allocation calculations

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38201/
---

(Updated Nov. 25, 2015, 10:04 a.m.)


Review request for mesos, Jie Yu and Vinod Kone.


Changes
---

The final solution is under discussion; mark it as [WIP].


Summary (updated)
-

[WIP] precision errors with allocation calculations


Bugs: MESOS-1187
https://issues.apache.org/jira/browse/MESOS-1187


Repository: mesos


Description
---

As allocations are stored/transmitted as doubles many a times precision errors 
creep in.


Diffs
-

  src/common/values.cpp 750264e603b4cde2011f07f4434a4b34fe3e512f 
  src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56 

Diff: https://reviews.apache.org/r/38201/diff/


Testing
---

make
make check


Thanks,

Klaus Ma

Re: Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.

[Guangya Liu]

> On 十一月 24, 2015, 9:38 p.m., Michael Park wrote:
> > Ship It!

@mcypark and @Neil, shall we clarify that the dynamic reservation works for 
both enabling and not enabling authorization in the document?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40242/#review107853
---


On 十一月 23, 2015, 11:44 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40242/
> ---
> 
> (Updated 十一月 23, 2015, 11:44 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved docs for dynamic reservation HTTP endpoints.
> 
> 
> Diffs
> -
> 
>   docs/home.md 7aa785e9ae07f2cc14eb0f1108ae4ab4c8748599 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
> 
> Diff: https://reviews.apache.org/r/40242/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40679: Added filtering of CFS cgroup tests.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40679/#review107892
---



src/tests/environment.cpp (line 129)


use `/sys/fs/cgroup` maybe have some problems. centos 6 mount cgroup under 
`/cgroup` directly. Could refer to how `void 
ContainerizerTest::SetUp()` got cgroup 
`baseHierarchy`


- haosdent huang


On Nov. 25, 2015, 1:05 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40679/
> ---
> 
> (Updated Nov. 25, 2015, 1:05 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Marco Massenzio, Till Toenshoff, 
> and Timothy Chen.
> 
> 
> Bugs: MESOS-3964 and MESOS-3978
> https://issues.apache.org/jira/browse/MESOS-3964
> https://issues.apache.org/jira/browse/MESOS-3978
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added filtering of CFS cgroup tests.
> 
> 
> Diffs
> -
> 
>   src/tests/environment.cpp ea70a5f5e752f4855b7b0e19ee3c1a60015a76ea 
> 
> Diff: https://reviews.apache.org/r/40679/diff/
> 
> 
> Testing
> ---
> 
> CFS support is disabled by default and must be enabled via a command-line 
> flag. Thus, the test suite should not assume that this feature is present.
> 
> To test, run `sudo make check` on Debian 8 or another linux distribution 
> without CFS cgroup support.
> 
> Mesos should crash during LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs or 
> LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs_Big_Quota without this patch, and 
> those tests should be filtered out after this patch. I ran `sudo make check` 
> on Ubuntu 14.04 and the CFS tests ran like normal, and passed.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 40654: Cleaned up usage of `CreateSlaveFlags()` in a test file.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40654/#review107899
---



src/tests/authentication_tests.cpp (line 311)


Not yours but do you mind to update s/Try/Try and 
the following?


- Guangya Liu


On 十一月 24, 2015, 4:54 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40654/
> ---
> 
> (Updated 十一月 24, 2015, 4:54 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Cleaned up usage of `CreateSlaveFlags()` in a test file.
> 
> 
> Diffs
> -
> 
>   src/tests/authentication_tests.cpp 98a872e8b5c69737e334fd5d4838d988d8aced95 
> 
> Diff: https://reviews.apache.org/r/40654/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40654: Cleaned up usage of `CreateSlaveFlags()` in a test file.

[Neil Conway]

> On Nov. 25, 2015, 2:25 a.m., Guangya Liu wrote:
> > src/tests/authentication_tests.cpp, line 311
> > 
> >
> > Not yours but do you mind to update s/Try/Try 
> > and the following?

Sure -- although I believe that committers would like to see these kinds of 
cleanups as a separate commit.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40654/#review107899
---


On Nov. 24, 2015, 4:54 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40654/
> ---
> 
> (Updated Nov. 24, 2015, 4:54 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Cleaned up usage of `CreateSlaveFlags()` in a test file.
> 
> 
> Diffs
> -
> 
>   src/tests/authentication_tests.cpp 98a872e8b5c69737e334fd5d4838d988d8aced95 
> 
> Diff: https://reviews.apache.org/r/40654/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40654: Cleaned up usage of `CreateSlaveFlags()` in a test file.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40654/
---

(Updated Nov. 25, 2015, 2:32 a.m.)


Review request for mesos and Ben Mahler.


Changes
---

Rebase.


Repository: mesos


Description
---

Cleaned up usage of `CreateSlaveFlags()` in a test file.


Diffs (updated)
-

  src/tests/authentication_tests.cpp 98a872e8b5c69737e334fd5d4838d988d8aced95 

Diff: https://reviews.apache.org/r/40654/diff/


Testing
---

make check


Thanks,

Neil Conway

Review Request 40690: Cleaned up ">>" style in test file.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40690/
---

Review request for mesos.


Repository: mesos


Description
---

Cleaned up ">>" style in test file.


Diffs
-

  src/tests/authentication_tests.cpp 98a872e8b5c69737e334fd5d4838d988d8aced95 

Diff: https://reviews.apache.org/r/40690/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 40681: Changed mesos-local to use posix launcher as default.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40681/#review107890
---

Ship it!


Ship It!

- haosdent huang


On Nov. 25, 2015, 12:38 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40681/
> ---
> 
> (Updated Nov. 25, 2015, 12:38 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See MESOS-3793 for more details.
> 
> 
> Diffs
> -
> 
>   src/local/local.cpp d714eb148fa8db2cbbe23175ab859e50eec9036f 
> 
> Diff: https://reviews.apache.org/r/40681/diff/
> 
> 
> Testing
> ---
> 
> Tested the changes in docker (ubuntu:14.04).
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 40424: Enhance the existing HTTP endpoint /roles

[Yong Qiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40424/
---

(Updated Nov. 25, 2015, 1:35 a.m.)


Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.


Summary (updated)
-

Enhance the existing HTTP endpoint /roles


Bugs: MESOS-3791
https://issues.apache.org/jira/browse/MESOS-3791


Repository: mesos


Description
---

In this ticket, we will enhance the existing
HTTP endpoint to query roles as outlined in
the dynamic role design Doc.


Diffs
-

  include/mesos/role/role.proto PRE-CREATION 
  src/CMakeLists.txt cfe9d26c45ba42852fd1af958549954e7b04d448 
  src/Makefile.am a57e46d06c8c26a32a9444be4f0e1269d775f8b0 
  src/master/http.cpp 6c647808a48879cbc176ffe7586c7e9b41bcf4c8 
  src/master/master.hpp e5e0ed01a56d869cc535687c8dbb6b99f6295b66 
  src/master/role_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40424/diff/


Testing
---

Test results:
$ curl http://127.0.0.1:5050/roles
{"status":[{"infos":{"name":"*","weight":1.0}},{"infos":{"name":"aa","weight":1.0}},{"framework_id":[{"value":"f1e1af59-9468-4f
f0-8fb4-96825d86b6d7-0142"}],"infos":{"name":"bb","weight":1.0},"resources":[{"name":"cpus","role":"bb","scalar":{"value":5.0},
"type":"SCALAR"},{"name":"mem","role":"bb","scalar":{"value":640.0},"type":"SCALAR"}]},{"infos":{"name":"cc","weight":1.0}}]}


$ curl http://127.0.0.1:5050/roles/aa
{"status":[{"framework_id":[{"value":"f1e1af59-9468-4ff0-8fb4-96825d86b6d7-0305"}],"infos":{"name":"bb","weight":1.0},"resource
s":[{"name":"cpus","role":"bb","scalar":{"value":5.0},"type":"SCALAR"},{"name":"mem","role":"bb","scalar":{"value":640.0},"type
":"SCALAR"}]}]}


$ curl http://127.0.0.1:5050/roles/dd
The specified role [dd] does not exist!


Thanks,

Yong Qiao Wang

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39320/#review107901
---

Ship it!


Ship It!

- Guangya Liu


On 十一月 24, 2015, 3:57 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39320/
> ---
> 
> (Updated 十一月 24, 2015, 3:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Bernd Mathiske, Neil Conway, and 
> Till Toenshoff.
> 
> 
> Bugs: MESOS-3732
> https://issues.apache.org/jira/browse/MESOS-3732
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> 3bbd6cbf6b101415c90991c48f00f33a5aff5590 
> 
> Diff: https://reviews.apache.org/r/39320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> The run time for the `FaultToleranceTest.FrameworkReregister` test has 
> reduced from more than `1s` to less than `100ms`.
> Before:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (1018 ms)
> ```
> After:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (49 ms)
> ```
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 40690: Cleaned up ">>" style in test file.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40690/#review107904
---

Ship it!


Ship It!

- Guangya Liu


On 十一月 25, 2015, 2:32 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40690/
> ---
> 
> (Updated 十一月 25, 2015, 2:32 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Cleaned up ">>" style in test file.
> 
> 
> Diffs
> -
> 
>   src/tests/authentication_tests.cpp 98a872e8b5c69737e334fd5d4838d988d8aced95 
> 
> Diff: https://reviews.apache.org/r/40690/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40690: Cleaned up ">>" style in test file.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40690/#review107905
---



src/tests/authentication_tests.cpp (line 55)


Should we also handle the same issue in other files?

```
$grep -rn "> >" src/* | wc -l
893
```


- Klaus Ma


On Nov. 25, 2015, 10:32 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40690/
> ---
> 
> (Updated Nov. 25, 2015, 10:32 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Cleaned up ">>" style in test file.
> 
> 
> Diffs
> -
> 
>   src/tests/authentication_tests.cpp 98a872e8b5c69737e334fd5d4838d988d8aced95 
> 
> Diff: https://reviews.apache.org/r/40690/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40690: Cleaned up ">>" style in test file.

[Neil Conway]

> On Nov. 25, 2015, 2:52 a.m., Klaus Ma wrote:
> > src/tests/authentication_tests.cpp, line 55
> > 
> >
> > Should we also handle the same issue in other files?
> > 
> > ```
> > $grep -rn "> >" src/* | wc -l
> > 893
> > ```

I believe the policy is to replace "> >" with ">>" incrementally, typically 
whenever we're making changes to a file that uses the old syntax.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40690/#review107905
---


On Nov. 25, 2015, 2:32 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40690/
> ---
> 
> (Updated Nov. 25, 2015, 2:32 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Cleaned up ">>" style in test file.
> 
> 
> Diffs
> -
> 
>   src/tests/authentication_tests.cpp 98a872e8b5c69737e334fd5d4838d988d8aced95 
> 
> Diff: https://reviews.apache.org/r/40690/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/#review107913
---

Ship it!


Looks good overall! Some nit-picks, some thoughts on naming, etc.


docs/persistent-volume.md (line 248)


It looks pretty clear that we allow the creation and destruction of 
multiple volumes via these endpoints. Should we call them `create-volumes` and 
`destroy-volumes` respectively?



docs/persistent-volume.md (lines 258 - 259)


Sorry to be nit-picking, but this still looks like the `-u` and below is 1 
space further indented than the `-i`?



src/master/http.cpp (line 541)


I feel like this could be taken as "remove/filter the disk resources" 
rather than "remove the DiskInfo portion of each resource" :(

I thought maybe `removeVolumes` but I think that has the same issue as 
before. I also think we should keep in mind that we may introduce an alias for, 
and deprecate `flatten`.

Another one would be `removeDiskInfos` to be more indicative that the 
`DiskInfo` portion of the `Resource`s are being removed, but then the alias for 
`flatten` would end up as something like, `removeRolesAndReservationInfos`...

This brings me to maybe declaring the state in which this resource is being 
transformed into. Something like... `makeRegularDisk` and `makeUnreserved`?

What do you think?



src/master/http.cpp (lines 541 - 551)


As far as its implementation, let's do:

```cpp
static Resources removeDisks(Resources resources)
{
  foreach (Resource& resource, resources) {
resource.clear_disk();
  }
  return resources;
}
```



src/master/http.cpp (lines 614 - 617)


```cpp
Option validate = validation::operation::validate(
operation.create(), slave->checkpointedResources);
```

or

```cpp
Option validate = validation::operation::validate(
operation.create(),
slave->checkpointedResources);
```



src/master/http.cpp (lines 704 - 707)


Similar to above.



src/master/http.cpp (line 1046)


`flatten()` removes `role` and `ReservationInfo` from the resources.



src/tests/mesos.hpp (line 520)


`s/reservationPrinciple/reservationPrincipal/`



src/tests/persistent_volume_endpoints_tests.cpp (lines 159 - 162)


I would suggest that we reorder these since we expect `registered` to occur 
before `resourceOffers`. Although functionally, it should have no difference.

Occurences below as well.



src/tests/persistent_volume_endpoints_tests.cpp (line 277)


We should perhaps use `frameworkInfo.role()` here to make sure that it 
matches the dynamically reserved role?



src/tests/persistent_volume_endpoints_tests.cpp (line 382)


Would the following serve as good documentation of the test?

```
ASSERT_NE(frameworkInfo.role(), "role2");
```



src/tests/persistent_volume_endpoints_tests.cpp (line 443)


This also needs to match the dynamically reserved role, right? 
`frameworkInfo.role()`?


- Michael Park


On Nov. 23, 2015, 5:06 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40247/
> ---
> 
> (Updated Nov. 23, 2015, 5:06 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP endpoints for creating and destroying persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
>   src/Makefile.am 8d14ff803249b5b81b696d40d37e013960dee41b 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
>   src/master/master.hpp d4b1edde98925fd51e056f253758afea779be9ed 
>   src/master/master.cpp d2bc83cd77ae7fe723ccb35a7c1e0b70a04a0d6e 
>   src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
>   src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40247/diff/

Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/#review107919
---



src/v1/resources.cpp (line 95)


bool operator==(
const Resource::RevocableInfo& left,
const Resource::RevocableInfo& right)



src/v1/resources.cpp (lines 116 - 117)


bool operator!=(
const Resource::RevocableInfo& left,
const Resource::RevocableInfo& right)


- Guangya Liu


On 十一月 24, 2015, 2:48 p.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40375/
> ---
> 
> (Updated 十一月 24, 2015, 2:48 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3888
> https://issues.apache.org/jira/browse/MESOS-3888
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3888: We need to distinguish revocable resource for usage slack and 
> allocation slack.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 0b8289f 
>   include/mesos/v1/mesos.proto c98f2a4 
>   src/common/resources.cpp b4abf54 
>   src/tests/resources_tests.cpp dbd39cd 
>   src/v1/resources.cpp 8488c31 
> 
> Diff: https://reviews.apache.org/r/40375/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/#review107923
---



src/tests/resources_tests.cpp (line 1982)


move this to 1987 as we discussed


- Guangya Liu


On 十一月 24, 2015, 2:48 p.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40375/
> ---
> 
> (Updated 十一月 24, 2015, 2:48 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3888
> https://issues.apache.org/jira/browse/MESOS-3888
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3888: We need to distinguish revocable resource for usage slack and 
> allocation slack.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 0b8289f 
>   include/mesos/v1/mesos.proto c98f2a4 
>   src/common/resources.cpp b4abf54 
>   src/tests/resources_tests.cpp dbd39cd 
>   src/v1/resources.cpp 8488c31 
> 
> Diff: https://reviews.apache.org/r/40375/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40379/#review107924
---


As we discussed, since we already resolved the compatibility issue, so we can 
evaluate if we need to udpate this file or not. ;-)

- Guangya Liu


On 十一月 24, 2015, 11:02 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40379/
> ---
> 
> (Updated 十一月 24, 2015, 11:02 a.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-3930
> https://issues.apache.org/jira/browse/MESOS-3930
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In Optimistic Offer Phase 1, it introduce `RevocableInfo::type`: USAGE_SLACK 
> for Oversubscription and ALLOCATION_SLACK for Optimistic Offer. Slave helps 
> to update `RevocableInfo::type` for Oversubscription.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 9055f2a 
> 
> Diff: https://reviews.apache.org/r/40379/diff/
> 
> 
> Testing
> ---
> 
> make (make check is on-going)
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 40690: Cleaned up ">>" style in test file.

[Guangya Liu]

> On 十一月 25, 2015, 2:52 a.m., Klaus Ma wrote:
> > src/tests/authentication_tests.cpp, line 55
> > 
> >
> > Should we also handle the same issue in other files?
> > 
> > ```
> > $grep -rn "> >" src/* | wc -l
> > 893
> > ```
> 
> Neil Conway wrote:
> I believe the policy is to replace "> >" with ">>" incrementally, 
> typically whenever we're making changes to a file that uses the old syntax.

+1 to Neil, there are already some patches handling this issues step by step.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40690/#review107905
---


On 十一月 25, 2015, 2:32 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40690/
> ---
> 
> (Updated 十一月 25, 2015, 2:32 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Cleaned up ">>" style in test file.
> 
> 
> Diffs
> -
> 
>   src/tests/authentication_tests.cpp 98a872e8b5c69737e334fd5d4838d988d8aced95 
> 
> Diff: https://reviews.apache.org/r/40690/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40660: Linked against executor PID's to ensure ordered message delivery

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40660/#review107926
---


Patch looks great!

Reviews applied: [40660]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 24, 2015, 6:25 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40660/
> ---
> 
> (Updated Nov. 24, 2015, 6:25 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3851
> https://issues.apache.org/jira/browse/MESOS-3851
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, we did not `link` against the executor `PID` while 
> (re)-registering. This might lead to libprocess creating ephemeral sockets 
> everytime a `send(...)` was invoked. This was leading to races where messages 
> might appear on the Executor out of order. This change does a `link(...)` on 
> the executor PID to ensure ordered message delivery.
> 
> ---Not to be included in commit message---
> I am still not comfortable bringing back the reverted commit 
> https://reviews.apache.org/r/40107/ . I can see one more race condition even 
> with a `link(...)`. We can still have messages coming out of order when the 
> first socket fails after sending the first message when still in flight. A 
> new socket gets created when we send the second message now, which might 
> arrive earlier then the first message leading to a race. But, this is a 
> behavior that is heavily relied upon elsewhere in our code-base. Happy to be 
> proven wrong though and be convinced that we can bring back the reverted 
> commit now after this change.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 9055f2a789cb19f3579c15a379ea505dfef0578c 
> 
> Diff: https://reviews.apache.org/r/40660/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/
---

(Updated Nov. 25, 2015, 2:16 p.m.)


Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van 
Remoortere.


Changes
---

Address comments


Bugs: MESOS-3888
https://issues.apache.org/jira/browse/MESOS-3888


Repository: mesos


Description
---

MESOS-3888: We need to distinguish revocable resource for usage slack and 
allocation slack.


Diffs (updated)
-

  include/mesos/mesos.proto 27971fe 
  include/mesos/v1/mesos.proto 9acefd5 
  src/common/resources.cpp b4abf54 
  src/tests/resources_tests.cpp dbd39cd 
  src/v1/resources.cpp 8488c31 

Diff: https://reviews.apache.org/r/40375/diff/


Testing
---

make && make check


Thanks,

Klaus Ma

Re: Review Request 40690: Cleaned up ">>" style in test file.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40690/#review107929
---

Ship it!


Ship It!

- Klaus Ma


On Nov. 25, 2015, 10:32 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40690/
> ---
> 
> (Updated Nov. 25, 2015, 10:32 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Cleaned up ">>" style in test file.
> 
> 
> Diffs
> -
> 
>   src/tests/authentication_tests.cpp 98a872e8b5c69737e334fd5d4838d988d8aced95 
> 
> Diff: https://reviews.apache.org/r/40690/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40690: Cleaned up ">>" style in test file.

[Klaus Ma]

> On Nov. 25, 2015, 10:52 a.m., Klaus Ma wrote:
> > src/tests/authentication_tests.cpp, line 55
> > 
> >
> > Should we also handle the same issue in other files?
> > 
> > ```
> > $grep -rn "> >" src/* | wc -l
> > 893
> > ```
> 
> Neil Conway wrote:
> I believe the policy is to replace "> >" with ">>" incrementally, 
> typically whenever we're making changes to a file that uses the old syntax.
> 
> Guangya Liu wrote:
> +1 to Neil, there are already some patches handling this issues step by 
> step.

That's OK to me :).


- Klaus


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40690/#review107905
---


On Nov. 25, 2015, 10:32 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40690/
> ---
> 
> (Updated Nov. 25, 2015, 10:32 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Cleaned up ">>" style in test file.
> 
> 
> Diffs
> -
> 
>   src/tests/authentication_tests.cpp 98a872e8b5c69737e334fd5d4838d988d8aced95 
> 
> Diff: https://reviews.apache.org/r/40690/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40379: MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40379/
---

(Updated Nov. 25, 2015, 2:35 p.m.)


Review request for mesos and Guangya Liu.


Changes
---

Mark as ready for review, one open discussion is here: whether this path is 
necessary?
1. Unnecessary because Resources keep the compatibility of unset 
RevocableInfo::type & USAGE_SLACK
2. Necessary because we'd like to introduce USAGE_SLACK & ALLOCATION_SLACK, and 
deprecate unset RevocableInfo::type


Summary (updated)
-

MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription


Bugs: MESOS-3930
https://issues.apache.org/jira/browse/MESOS-3930


Repository: mesos


Description
---

In Optimistic Offer Phase 1, it introduce `RevocableInfo::type`: USAGE_SLACK 
for Oversubscription and ALLOCATION_SLACK for Optimistic Offer. Slave helps to 
update `RevocableInfo::type` for Oversubscription.


Diffs
-

  src/slave/slave.cpp 9055f2a 

Diff: https://reviews.apache.org/r/40379/diff/


Testing
---

make (make check is on-going)


Thanks,

Klaus Ma

Re: Review Request 40524: Used string directly in resources.cpp.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40524/
---

(Updated 十一月 25, 2015, 6:41 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, 
and Klaus Ma.


Summary (updated)
-

Used string directly in resources.cpp.


Bugs: MESOS-3955
https://issues.apache.org/jira/browse/MESOS-3955


Repository: mesos


Description (updated)
---

Used string directly in resources.cpp.


Diffs (updated)
-

  src/common/resources.cpp b4abf5405039d7d0a5028ccf034ad2e9623d064c 
  src/v1/resources.cpp 8488c318a987a150fc5fde26b54246e8effb0428 

Diff: https://reviews.apache.org/r/40524/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 40529: Added helper function to get stateless resources.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40529/
---

(Updated 十一月 25, 2015, 6:41 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, 
and Klaus Ma.


Bugs: MESOS-3955
https://issues.apache.org/jira/browse/MESOS-3955


Repository: mesos


Description
---

Added helper function to get stateless resources.


Diffs (updated)
-

  include/mesos/resources.hpp 51c63f8305f6c0313e0b34f912f5e53396a1591d 
  include/mesos/v1/resources.hpp b481a9e0177b5253acc2585d5dfc6228ab63876c 
  src/common/resources.cpp b4abf5405039d7d0a5028ccf034ad2e9623d064c 
  src/tests/resources_tests.cpp dbd39cd5a6786682a7b528b6fea37ab78904cf12 
  src/v1/resources.cpp 8488c318a987a150fc5fde26b54246e8effb0428 

Diff: https://reviews.apache.org/r/40529/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 40631: Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40631/#review107865
---


Patch looks great!

Reviews applied: [40631]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 24, 2015, 1:47 p.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40631/
> ---
> 
> (Updated Nov. 24, 2015, 1:47 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Michael Park.
> 
> 
> Bugs: MESOS-3963
> https://issues.apache.org/jira/browse/MESOS-3963
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> According to the google code style, the using should be used in internal 
> namespace in header files. Grep the header files, only fetcher.hpp deserved a 
> path.
> 
> 
> > You may use a using-declaration anywhere in a .cc file (including in the 
> > global namespace), and in functions, methods, classes, or within internal 
> > namespaces in .h files.
> 
> >Do not use using-declarations in .h files except in explicitly marked 
> >internal-only namespaces, because anything imported into a namespace in a .h 
> >file becomes part of the public API exported by that file.
> 
> ```
> // OK in .cc files.
> // Must be in a function, method, internal namespace, or
> // class in .h files.
> using ::foo::bar;
> ```
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/fetcher.hpp 
> 78e7d145328c9f7aa9646fa7d6d92f834010053f 
>   src/tests/mesos.hpp a2a76f55f9a4091cccfccd9672c2d2897b34ddcd 
> 
> Diff: https://reviews.apache.org/r/40631/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 40424: [WIP] ]Enhance the existing HTTP endpoint /roles

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40424/#review107833
---


Patch looks great!

Reviews applied: [40431, 40424]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 24, 2015, 10:11 a.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40424/
> ---
> 
> (Updated Nov. 24, 2015, 10:11 a.m.)
> 
> 
> Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
> 
> 
> Bugs: MESOS-3791
> https://issues.apache.org/jira/browse/MESOS-3791
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this ticket, we will enhance the existing
> HTTP endpoint to query roles as outlined in
> the dynamic role design Doc.
> 
> 
> Diffs
> -
> 
>   include/mesos/role/role.proto PRE-CREATION 
>   src/CMakeLists.txt cfe9d26c45ba42852fd1af958549954e7b04d448 
>   src/Makefile.am a57e46d06c8c26a32a9444be4f0e1269d775f8b0 
>   src/master/http.cpp 6c647808a48879cbc176ffe7586c7e9b41bcf4c8 
>   src/master/master.hpp e5e0ed01a56d869cc535687c8dbb6b99f6295b66 
>   src/master/role_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40424/diff/
> 
> 
> Testing
> ---
> 
> Test results:
> $ curl http://127.0.0.1:5050/roles
> {"status":[{"infos":{"name":"*","weight":1.0}},{"infos":{"name":"aa","weight":1.0}},{"framework_id":[{"value":"f1e1af59-9468-4f
> f0-8fb4-96825d86b6d7-0142"}],"infos":{"name":"bb","weight":1.0},"resources":[{"name":"cpus","role":"bb","scalar":{"value":5.0},
> "type":"SCALAR"},{"name":"mem","role":"bb","scalar":{"value":640.0},"type":"SCALAR"}]},{"infos":{"name":"cc","weight":1.0}}]}
> 
> 
> $ curl http://127.0.0.1:5050/roles/aa
> {"status":[{"framework_id":[{"value":"f1e1af59-9468-4ff0-8fb4-96825d86b6d7-0305"}],"infos":{"name":"bb","weight":1.0},"resource
> s":[{"name":"cpus","role":"bb","scalar":{"value":5.0},"type":"SCALAR"},{"name":"mem","role":"bb","scalar":{"value":640.0},"type
> ":"SCALAR"}]}]}
> 
> 
> $ curl http://127.0.0.1:5050/roles/dd
> The specified role [dd] does not exist!
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 40672: Fixed flakey test: MasterMaintenanceTest.InverseOffersFilters.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40672/
---

(Updated Nov. 24, 2015, 9:04 p.m.)


Review request for mesos, Joris Van Remoortere, Joseph Wu, Jan Schlicht, and 
Till Toenshoff.


Bugs: MESOS-3916
https://issues.apache.org/jira/browse/MESOS-3916


Repository: mesos


Description
---

MESOS-3916.


Diffs
-

  src/tests/master_maintenance_tests.cpp 
ade05f932020013ced19c1573be756a029396fac 

Diff: https://reviews.apache.org/r/40672/diff/


Testing (updated)
---

(1) mesos-tests --gtest_repeat=2000 on OSX
(2) My Ubuntu VM seems to be in a weird state: this fixes the observed 
flakiness, but there seem to be other weird networking issues that cause 
messaging timeouts that seem to be unrelated. Till, Jan: would you guys mind 
repro'ing that this fixes the flakiness for you?


Thanks,

Neil Conway

Re: Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40242/#review107853
---

Ship it!


Ship It!

- Michael Park


On Nov. 23, 2015, 11:44 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40242/
> ---
> 
> (Updated Nov. 23, 2015, 11:44 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved docs for dynamic reservation HTTP endpoints.
> 
> 
> Diffs
> -
> 
>   docs/home.md 7aa785e9ae07f2cc14eb0f1108ae4ab4c8748599 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
> 
> Diff: https://reviews.apache.org/r/40242/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40672: Fixed flakey test: MasterMaintenanceTest.InverseOffersFilters.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40672/
---

(Updated Nov. 24, 2015, 9:07 p.m.)


Review request for mesos, Joris Van Remoortere, Joseph Wu, Jan Schlicht, and 
Till Toenshoff.


Changes
---

Whitespace fix.


Bugs: MESOS-3916
https://issues.apache.org/jira/browse/MESOS-3916


Repository: mesos


Description
---

MESOS-3916.


Diffs (updated)
-

  src/tests/master_maintenance_tests.cpp 
ade05f932020013ced19c1573be756a029396fac 

Diff: https://reviews.apache.org/r/40672/diff/


Testing
---

(1) mesos-tests --gtest_repeat=2000 on OSX
(2) My Ubuntu VM seems to be in a weird state: this fixes the observed 
flakiness, but there seem to be other weird networking issues that cause 
messaging timeouts that seem to be unrelated. Till, Jan: would you guys mind 
repro'ing that this fixes the flakiness for you?


Thanks,

Neil Conway

Re: Review Request 40672: Fixed flakey test: MasterMaintenanceTest.InverseOffersFilters.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40672/#review107844
---



src/tests/master_maintenance_tests.cpp 


This was removed because, as far as I can tell, it is unnecessary.



src/tests/master_maintenance_tests.cpp 


This was removed because, as far as I can tell, it is unnecessary.


- Neil Conway


On Nov. 24, 2015, 9:04 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40672/
> ---
> 
> (Updated Nov. 24, 2015, 9:04 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Jan Schlicht, and 
> Till Toenshoff.
> 
> 
> Bugs: MESOS-3916
> https://issues.apache.org/jira/browse/MESOS-3916
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3916.
> 
> 
> Diffs
> -
> 
>   src/tests/master_maintenance_tests.cpp 
> ade05f932020013ced19c1573be756a029396fac 
> 
> Diff: https://reviews.apache.org/r/40672/diff/
> 
> 
> Testing
> ---
> 
> (1) mesos-tests --gtest_repeat=2000 on OSX
> (2) My Ubuntu VM seems to be in a weird state: this fixes the observed 
> flakiness, but there seem to be other weird networking issues that cause 
> messaging timeouts that seem to be unrelated. Till, Jan: would you guys mind 
> repro'ing that this fixes the flakiness for you?
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Review Request 40672: Fixed flakey test: MasterMaintenanceTest.InverseOffersFilters.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40672/
---

Review request for mesos, Joris Van Remoortere and Joseph Wu.


Bugs: MESOS-3916
https://issues.apache.org/jira/browse/MESOS-3916


Repository: mesos


Description
---

MESOS-3916.


Diffs
-

  src/tests/master_maintenance_tests.cpp 
ade05f932020013ced19c1573be756a029396fac 

Diff: https://reviews.apache.org/r/40672/diff/


Testing
---

(1) mesos-tests --gtest_repeat=2000 on OSX
(2) My Ubuntu VM seems to be in a weird state: this fixes the observed 
flakiness, but there seem to be other weird networking issues that cause 
messaging timeouts that seem to be unrelated.


Thanks,

Neil Conway

Re: Review Request 40641: Increase launch and wait timeout in LinuxFilesystemIsolatorTest.ROOT_ImageInVolumeWithRootFilesystem.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40641/#review107849
---


Patch looks great!

Reviews applied: [40641]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 24, 2015, 1:45 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40641/
> ---
> 
> (Updated Nov. 24, 2015, 1:45 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Jan Schlicht, Till Toenshoff, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-3966
> https://issues.apache.org/jira/browse/MESOS-3966
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Increase launch and wait timeout in 
> LinuxFilesystemIsolatorTest.ROOT_ImageInVolumeWithRootFilesystem.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> dab3abd0d87ae8ec6e4dea6a48870ace7a3cdad3 
> 
> Diff: https://reviews.apache.org/r/40641/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Review Request 40667: Fixed flakiness in reservation endpoint tests

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40667/
---

Review request for mesos, Michael Park and Vinod Kone.


Bugs: MESOS-4002
https://issues.apache.org/jira/browse/MESOS-4002


Repository: mesos


Description
---

1. Fixed some flakiness in the reservation tests around `resourceOffers` 
expectation being set after `driver.start()` leading to a race condition 
sometimes.

```GMOCK WARNING:
Uninteresting mock function call - returning directly.
Function call: resourceOffers(0x7fffe27c3830, @0x2ae03c9ce9d0 { 144-byte 
object  })
S```

2. Added `AWAIT_READY` for the returned future from 1.
3. Removed the initial call to `reviveOffers` after `driver.start()` since that 
was redundant.

-- Not to be committed--
Still does not fixes MESOS-4002 completely though. The test kept looping for 
300 minutes meaning there is some future that was never ready and we invoked a 
`.get()` blocking forever or a deadlock somewhere else. Would keep digging for 
the root cause and for future failures on the ASF CI leading to more clues.


Diffs
-

  src/tests/reservation_endpoints_tests.cpp 
f4e332327049944000baccd3e607201240a8c5f4 

Diff: https://reviews.apache.org/r/40667/diff/


Testing
---

make check + ran the tests in a loop. They did not fail for me before the fix 
too :-(


Thanks,

Anand Mazumdar

Re: Review Request 40115: Windows: Added support for `slave/gc.cpp'.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40115/
---

(Updated Nov. 24, 2015, 9:57 p.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Joseph Wu.


Repository: mesos


Description
---

Windows: Added support for `slave/gc.cpp'.


Diffs
-

  src/CMakeLists.txt a14518831553c5eb55fe648d349b91bb55e641d9 
  src/slave/gc.cpp 6042277f893a54ada612b2080d35061236f4176a 

Diff: https://reviews.apache.org/r/40115/diff/


Testing
---

Windows 10: make.bat
OSX: make check
Ubuntu: 15.1 make check


Thanks,

Daniel Pravat

Re: Review Request 40679: Added filtering of CFS cgroup tests.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40679/#review107933
---



src/tests/environment.cpp (line 147)


Cfs should be CFS_ right?


- Timothy Chen


On Nov. 25, 2015, 1:05 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40679/
> ---
> 
> (Updated Nov. 25, 2015, 1:05 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Marco Massenzio, Till Toenshoff, 
> and Timothy Chen.
> 
> 
> Bugs: MESOS-3964 and MESOS-3978
> https://issues.apache.org/jira/browse/MESOS-3964
> https://issues.apache.org/jira/browse/MESOS-3978
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added filtering of CFS cgroup tests.
> 
> 
> Diffs
> -
> 
>   src/tests/environment.cpp ea70a5f5e752f4855b7b0e19ee3c1a60015a76ea 
> 
> Diff: https://reviews.apache.org/r/40679/diff/
> 
> 
> Testing
> ---
> 
> CFS support is disabled by default and must be enabled via a command-line 
> flag. Thus, the test suite should not assume that this feature is present.
> 
> To test, run `sudo make check` on Debian 8 or another linux distribution 
> without CFS cgroup support.
> 
> Mesos should crash during LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs or 
> LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs_Big_Quota without this patch, and 
> those tests should be filtered out after this patch. I ran `sudo make check` 
> on Ubuntu 14.04 and the CFS tests ran like normal, and passed.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 40529: Added helper function to get stateless resources.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40529/
---

(Updated 十一月 25, 2015, 7:31 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, 
and Klaus Ma.


Bugs: MESOS-3955
https://issues.apache.org/jira/browse/MESOS-3955


Repository: mesos


Description
---

Added helper function to get stateless resources.


Diffs (updated)
-

  include/mesos/resources.hpp 51c63f8305f6c0313e0b34f912f5e53396a1591d 
  include/mesos/v1/resources.hpp b481a9e0177b5253acc2585d5dfc6228ab63876c 
  src/common/resources.cpp b4abf5405039d7d0a5028ccf034ad2e9623d064c 
  src/tests/resources_tests.cpp dbd39cd5a6786682a7b528b6fea37ab78904cf12 
  src/v1/resources.cpp 8488c318a987a150fc5fde26b54246e8effb0428 

Diff: https://reviews.apache.org/r/40529/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 40632: WIP: Enabled oversubscribed resources for reservations in allocator.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40632/
---

(Updated 十一月 25, 2015, 7:31 a.m.)


Review request for mesos and Klaus Ma.


Repository: mesos


Description
---

WIP: Enabled oversubscribed resources for reservations in allocator.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.cpp 
aee8ced1fbfec8cf30cb939ff67fadfc6b08f37a 

Diff: https://reviews.apache.org/r/40632/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 40647: Updated centos6.6 installation instructions.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40647/#review107934
---


Patch looks great!

Reviews applied: [40647]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 24, 2015, 2:50 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40647/
> ---
> 
> (Updated Nov. 24, 2015, 2:50 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-3974
> https://issues.apache.org/jira/browse/MESOS-3974
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For full support for the Docker- and MesosContainerizers we require a
> relatively recent kernel. Document this dependency.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 8e1df88 
> 
> Diff: https://reviews.apache.org/r/40647/diff/
> 
> 
> Testing
> ---
> 
> Confirmed that the test succeeds with the suggested change.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 40532: Added notion of evictable task to RunTaskMessage.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40532/
---

(Updated 十一月 25, 2015, 7:31 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, 
and Klaus Ma.


Bugs: MESOS-3890
https://issues.apache.org/jira/browse/MESOS-3890


Repository: mesos


Description
---

Added notion of evictable task to RunTaskMessage.


Diffs (updated)
-

  src/messages/messages.proto 178d757a76f14829da6daab97ec678843717cf5a 

Diff: https://reviews.apache.org/r/40532/diff/


Testing
---


Thanks,

Guangya Liu

Review Request 40660: Linked against executor PID's to ensure ordered message delivery

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40660/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-3851
https://issues.apache.org/jira/browse/MESOS-3851


Repository: mesos


Description
---

Previously, we did not `link` against the executor `PID` while 
(re)-registering. This might lead to libprocess creating ephemeral sockets 
everytime a `send(...)` was invoked. This was leading to races where messages 
might appear on the Executor out of order. This change does a `link(...)` on 
the executor PID to ensure ordered message delivery.

---Not to be included in commit message---
I am still not comfortable bringing back the reverted commit 
https://reviews.apache.org/r/40107/ . I can see one more race condition even 
with a `link(...)`. We can still have messages coming out of order when the 
first socket fails after sending the first message when still in flight. A new 
socket gets created when we send the second message now, which might arrive 
earlier then the first message leading to a race. But, this is a behavior that 
is heavily relied upon elsewhere in our code-base. Happy to be proven wrong 
though and be convinced that we can bring back the reverted commit now after 
this change.


Diffs
-

  src/slave/slave.cpp 9055f2a789cb19f3579c15a379ea505dfef0578c 

Diff: https://reviews.apache.org/r/40660/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39320/#review107800
---

Ship it!


Ship It!

- Neil Conway


On Nov. 24, 2015, 3:57 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39320/
> ---
> 
> (Updated Nov. 24, 2015, 3:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Bernd Mathiske, Neil Conway, and 
> Till Toenshoff.
> 
> 
> Bugs: MESOS-3732
> https://issues.apache.org/jira/browse/MESOS-3732
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> 3bbd6cbf6b101415c90991c48f00f33a5aff5590 
> 
> Diff: https://reviews.apache.org/r/39320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> The run time for the `FaultToleranceTest.FrameworkReregister` test has 
> reduced from more than `1s` to less than `100ms`.
> Before:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (1018 ms)
> ```
> After:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (49 ms)
> ```
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

[Neil Conway]

> On Nov. 24, 2015, 3:58 p.m., Neil Conway wrote:
> > src/tests/fault_tolerance_tests.cpp, line 720
> > 
> >
> > I'd remove this comment -- various other places use the same pattern. 
> > I'd also remove the newline after CreateMasterFlags(), to match the other 
> > places we use this pattern.
> 
> Alexander Rukletsov wrote:
> I think we are not consistent, e.g. see 
> https://github.com/apache/mesos/blob/master/src/tests/master_maintenance_tests.cpp#L1293

Sure.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39320/#review107793
---


On Nov. 24, 2015, 3:57 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39320/
> ---
> 
> (Updated Nov. 24, 2015, 3:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Bernd Mathiske, Neil Conway, and 
> Till Toenshoff.
> 
> 
> Bugs: MESOS-3732
> https://issues.apache.org/jira/browse/MESOS-3732
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> 3bbd6cbf6b101415c90991c48f00f33a5aff5590 
> 
> Diff: https://reviews.apache.org/r/39320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> The run time for the `FaultToleranceTest.FrameworkReregister` test has 
> reduced from more than `1s` to less than `100ms`.
> Before:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (1018 ms)
> ```
> After:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (49 ms)
> ```
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

[Alexander Rukletsov]

> On Nov. 18, 2015, 7:51 a.m., Qian Zhang wrote:
> > src/master/quota_handler.cpp, line 180
> > 
> >
> > Why do we want to rescind the offeres that do not contribute to 
> > satisfying quota request?
> 
> Alexander Rukletsov wrote:
> Because we may rescind more than necessary to satisfy quota request 
> (remember minimal agent count). If we have a check in place, this will 
> effectively prevent us from doing so. Does it make sense to you?
> 
> Qian Zhang wrote:
> Suppose the quota request is to request 20GB disk for a role, and there 
> is an offer which only include 2 CPU & 2GB memory and has no disk resources 
> at all, so we will rescind this offer too? This seems a little unfair to me.
> And can you please clarify a little more about why we want to rescind 
> offers from at least `numF` agents? The reason is that we want to ensure each 
> framework in that role will have a chance to get an offer in next allocation 
> cycle?
> 
> Alexander Rukletsov wrote:
> That's correct, we will rescind that offer and yes, it's a bit unfair. 
> Let me explain why I decided to remove this check. Suppose we a quota request 
> is for 6 CPUs for role with 3 frameworks. The first offer we rescind is 10 
> CPUs, 10GB MEM. Technically, we have enough resources to satisfy quota, but 
> we would like to rescind offers from at least 2 more agents. Having a check 
> in place will prevent us from doing so. Do you think greedy rescinding can be 
> a problem?
> 
> Yes, we would like to facilitate allocation for each framework in the 
> role, for which quota is set.
> 
> Qian Zhang wrote:
> The most unclear in my mind is why we need to rescind offers from at 
> least numF agents, i.e., in your example above, why do we want to rescind 
> offers from at least 2 more agents after quota has been satisfied? Can you 
> please let me know the motivation behind it? I think quota is kind of global 
> concept which should not have direct relation with agent and framework, it 
> should stay in role level. So I am not sure why we want to facilitate 
> allocation for each framework in the role, is that something that we 
> mentioned in design doc? Maybe I forget ... :-)

Nope, it wasn't in the design doc, that's something we decided recently. The 
main motivation is to improve user experience and simplify debugging. Because 
the built-in allocator is used in 99% of clusters, it makes sense to exploit 
some knowledge about how it works. Because of coarse-grained allocations, to 
facilitate fairness we may want to rescind from more agents than necessary to 
satisfy quota numbers.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40351/#review106977
---


On Nov. 24, 2015, 4:29 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40351/
> ---
> 
> (Updated Nov. 24, 2015, 4:29 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Qian Zhang.
> 
> 
> Bugs: MESOS-3912
> https://issues.apache.org/jira/browse/MESOS-3912
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp e5e0ed01a56d869cc535687c8dbb6b99f6295b66 
>   src/master/quota_handler.cpp b8e501be43de6bc02aebfa5bd415b4212a96da31 
> 
> Diff: https://reviews.apache.org/r/40351/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/
---

(Updated Nov. 24, 2015, 4:30 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
Joseph Wu, and Michael Park.


Bugs: MESOS-3720
https://issues.apache.org/jira/browse/MESOS-3720


Repository: mesos


Description
---

See summary.


Diffs
-

  src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
  src/tests/master_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38956/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 40524: Enabled resources.cpp and resources.hpp use std::string

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40524/#review107808
---



include/mesos/resources.hpp (lines 53 - 54)


This isn't allowed in a header.  (We don't want the namespace(s) to be 
polluted with unnecessary aliases.)



include/mesos/v1/resources.hpp (lines 53 - 54)


Not allowed for the same reason above.


- Joseph Wu


On Nov. 23, 2015, 9:42 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40524/
> ---
> 
> (Updated Nov. 23, 2015, 9:42 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, 
> and Klaus Ma.
> 
> 
> Bugs: MESOS-3955
> https://issues.apache.org/jira/browse/MESOS-3955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled resources.cpp and resources.hpp use std::string
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp 51c63f8305f6c0313e0b34f912f5e53396a1591d 
>   include/mesos/v1/resources.hpp b481a9e0177b5253acc2585d5dfc6228ab63876c 
>   src/common/resources.cpp b4abf5405039d7d0a5028ccf034ad2e9623d064c 
>   src/v1/resources.cpp 8488c318a987a150fc5fde26b54246e8effb0428 
> 
> Diff: https://reviews.apache.org/r/40524/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 40396: Quota: Added a test for offer rescinding.

[Alexander Rukletsov]

> On Nov. 23, 2015, 4:09 a.m., Guangya Liu wrote:
> > src/tests/master_quota_tests.cpp, line 542
> > 
> >
> > Add ASSERT here to make sure no offers?

Could you please elaborate what exactly do you propose?


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40396/#review107546
---


On Nov. 23, 2015, 10:45 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40396/
> ---
> 
> (Updated Nov. 23, 2015, 10:45 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Qian Zhang.
> 
> 
> Bugs: MESOS-3985
> https://issues.apache.org/jira/browse/MESOS-3985
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40396/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

[Alexander Rukletsov]

> On Nov. 24, 2015, 3:58 p.m., Neil Conway wrote:
> > src/tests/fault_tolerance_tests.cpp, line 720
> > 
> >
> > I'd remove this comment -- various other places use the same pattern. 
> > I'd also remove the newline after CreateMasterFlags(), to match the other 
> > places we use this pattern.

I think we are not consistent, e.g. see 
https://github.com/apache/mesos/blob/master/src/tests/master_maintenance_tests.cpp#L1293


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39320/#review107793
---


On Nov. 24, 2015, 3:57 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39320/
> ---
> 
> (Updated Nov. 24, 2015, 3:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Bernd Mathiske, Neil Conway, and 
> Till Toenshoff.
> 
> 
> Bugs: MESOS-3732
> https://issues.apache.org/jira/browse/MESOS-3732
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> 3bbd6cbf6b101415c90991c48f00f33a5aff5590 
> 
> Diff: https://reviews.apache.org/r/39320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> The run time for the `FaultToleranceTest.FrameworkReregister` test has 
> reduced from more than `1s` to less than `100ms`.
> Before:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (1018 ms)
> ```
> After:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (49 ms)
> ```
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 40396: Quota: Added a test for offer rescinding.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40396/
---

(Updated Nov. 24, 2015, 4:29 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
Joseph Wu, and Qian Zhang.


Changes
---

Rebased.


Bugs: MESOS-3985
https://issues.apache.org/jira/browse/MESOS-3985


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/tests/master_quota_tests.cpp 330e591f81c7ece7f401042ad159bd6b55881a84 

Diff: https://reviews.apache.org/r/40396/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40351/
---

(Updated Nov. 24, 2015, 4:29 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
Joseph Wu, and Qian Zhang.


Changes
---

Rescind after set quota.


Bugs: MESOS-3912
https://issues.apache.org/jira/browse/MESOS-3912


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/master.hpp e5e0ed01a56d869cc535687c8dbb6b99f6295b66 
  src/master/quota_handler.cpp b8e501be43de6bc02aebfa5bd415b4212a96da31 

Diff: https://reviews.apache.org/r/40351/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Review Request 40654: Cleaned up usage of `CreateSlaveFlags()` in a test file.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40654/
---

Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

Cleaned up usage of `CreateSlaveFlags()` in a test file.


Diffs
-

  src/tests/authentication_tests.cpp 98a872e8b5c69737e334fd5d4838d988d8aced95 

Diff: https://reviews.apache.org/r/40654/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 40647: Updated centos6.6 installation instructions.

[Cong Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40647/#review107817
---

Ship it!


Ship It!

- Cong Wang


On Nov. 24, 2015, 2:50 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40647/
> ---
> 
> (Updated Nov. 24, 2015, 2:50 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-3974
> https://issues.apache.org/jira/browse/MESOS-3974
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For full support for the Docker- and MesosContainerizers we require a
> relatively recent kernel. Document this dependency.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 8e1df88 
> 
> Diff: https://reviews.apache.org/r/40647/diff/
> 
> 
> Testing
> ---
> 
> Confirmed that the test succeeds with the suggested change.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 40445: Added linter for license headers in some file types.

[Vinod Kone]

> On Nov. 18, 2015, 6:21 p.m., Vinod Kone wrote:
> > support/hooks/post-rewrite, line 33
> > 
> >
> > instead of calling this script directly, i would recommend calling it 
> > from mesos-style.py. this way users and tools (review bot) can run just one 
> > script to test compliance.
> 
> Benjamin Bannier wrote:
> We do already call two scripts from the hooks ATM (one to wrap 
> `cpplint.py`, and one to check for properly split commits across libraries). 
> Looking at `mesos-style.py`, its logic is pretty much tied to just running 
> `cpplint` and parsing its output -- do you really mean we should rewrite all 
> of that?
> 
> Note that users can always manually run the hooks.

I just meant to call mesos-license.py from mesos-style.py because it is 
essentially a style checker. This just adds ~1 line to mesos-style.py. The 
reason I suggested this because if there are multiple scripts to run to check 
conformance, it will be hard to track. For example, review bot manually runs 
`./support/mesos-style.py` before doing `make check`. I would like to avoid 
updating review bot, everytime someone adds a new script to improve style 
checking. It would be also easy for  us to tell users to run this single script 
to check sytle (they might want to check before doing commit). 

The reason split commits checker has its own line in the commit hook is because 
it only comes into play when committing. For example, you wouldn't (couldn't) 
run that script on a freshly cloned repo. This is the same reason review bot 
doesn't run that checker.

Does that make sense?


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/#review107061
---


On Nov. 18, 2015, 4:05 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40445/
> ---
> 
> (Updated Nov. 18, 2015, 4:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Marco Massenzio.
> 
> 
> Bugs: MESOS-3581
> https://issues.apache.org/jira/browse/MESOS-3581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added linter for license headers in some file types.
> 
> 
> Diffs
> -
> 
>   support/hooks/post-rewrite 7df1e0f29c6ce940a364c0b1d312251c6160e5e3 
>   support/hooks/pre-commit ca9e9810aca921734be5224e3ef71fe7ff4aa03d 
>   support/mesos-license.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40445/diff/
> 
> 
> Testing
> ---
> 
> Ran the a whole clean checkout through the linter with only one expected 
> failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a 
> license).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 40010: Put authorize logic for teardown into a common function.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40010/#review107804
---


Patch looks great!

Reviews applied: [40010]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 24, 2015, 9:50 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40010/
> ---
> 
> (Updated Nov. 24, 2015, 9:50 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3838
> https://issues.apache.org/jira/browse/MESOS-3838
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The mesos now have authorizeTask, authorizeFramework etc, it is
> better to put authorize logic for teardown into a common function
> authorizeTeardown.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 6c647808a48879cbc176ffe7586c7e9b41bcf4c8 
>   src/master/master.hpp e5e0ed01a56d869cc535687c8dbb6b99f6295b66 
>   src/master/master.cpp 370980edfc80d1e52134fdaf3ce49177b6528b02 
> 
> Diff: https://reviews.apache.org/r/40010/diff/
> 
> 
> Testing
> ---
> 
> Ubuntu 14.04
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Review Request 40665: Clean up redundant os exists check before mkdir.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40665/
---

Review request for mesos and Timothy Chen.


Repository: mesos


Description
---

Clean up redundant os exist check before mkdir.


Diffs
-

  src/slave/containerizer/docker.cpp fe74d1fe23e91f81b278c1282bea7801414b92a3 
  src/slave/containerizer/mesos/provisioner/docker/store.cpp 
8f4b372986a28e293a121a80fee98b23becf225a 

Diff: https://reviews.apache.org/r/40665/diff/


Testing
---

make check(ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song

Re: Review Request 40532: Added notion of evictable task to RunTaskMessage.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40532/
---

(Updated 十一月 24, 2015, 8:09 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, 
and Klaus Ma.


Changes
---

Rebase


Bugs: MESOS-3890
https://issues.apache.org/jira/browse/MESOS-3890


Repository: mesos


Description
---

Added notion of evictable task to RunTaskMessage.


Diffs (updated)
-

  src/messages/messages.proto 178d757a76f14829da6daab97ec678843717cf5a 

Diff: https://reviews.apache.org/r/40532/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 40545: MESOS-3970: fix cpu usage in mesos ui

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40545/#review107734
---



src/webui/master/static/js/services.js (line 130)


Do we know why timestamp is NaN?


- Klaus Ma


On Nov. 21, 2015, 1:01 a.m., Ian Babrou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40545/
> ---
> 
> (Updated Nov. 21, 2015, 1:01 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3970: fix cpu usage in mesos ui
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/js/services.js 
> d41bc7142ae0182e25b2ae9dce960ee38ab22361 
> 
> Diff: https://reviews.apache.org/r/40545/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ian Babrou
> 
>

Re: Review Request 40424: [WIP] ]Enhance the existing HTTP endpoint /roles

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40424/#review107735
---


Patch looks great!

Reviews applied: [40424]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 24, 2015, 6:41 a.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40424/
> ---
> 
> (Updated Nov. 24, 2015, 6:41 a.m.)
> 
> 
> Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
> 
> 
> Bugs: MESOS-3791
> https://issues.apache.org/jira/browse/MESOS-3791
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this ticket, we will enhance the existing
> HTTP endpoint to query roles as outlined in
> the dynamic role design Doc.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
> 
> Diff: https://reviews.apache.org/r/40424/diff/
> 
> 
> Testing
> ---
> 
> Test results:
> $ curl http://127.0.0.1:5050/roles
> {"roles":[{"frameworks":[],"name":"cc","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"bb","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
> 
> $ curl http://127.0.0.1:5050/roles?roleName=aa
> {"roles":[{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
> 
> 
> $ curl http://127.0.0.1:5050/roles?roleName=dd
> The specified role [dd] does not exist!
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 40375: [WIP] Support distinguishing revocable resources in the Resource protobuf.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/#review107732
---



include/mesos/mesos.proto (line 649)


Did you get out how to leverage this default value in the code? ;-)



src/common/resources.cpp (lines 92 - 93)


// To keep backward compatibility, resources without revocable type are 
considered same as resources with USAGE_SLACK type.



src/common/resources.cpp (lines 94 - 95)


bool operator==(
const Resource::RevocableInfo& left,
const Resource::RevocableInfo& right)



src/common/resources.cpp (lines 115 - 116)


bool operator!=(
const Resource::RevocableInfo& left,
const Resource::RevocableInfo& right)



src/tests/resources_tests.cpp (line 800)


Do we need to update this? The standard revocable resource should be usage 
slack



src/tests/resources_tests.cpp (lines 1908 - 1909)


new line



src/tests/resources_tests.cpp (lines 1912 - 1913)


new line



src/tests/resources_tests.cpp (lines 1941 - 1948)


new line to split.

It is suggested to add new line if one sentense is split to two lines.



src/tests/resources_tests.cpp (line 1982)


EXPECT_TRUE((r3 - r3).empty());



src/tests/resources_tests.cpp (line 1986)


Add EXPECT_TRUE((r5 - r5).empty());



src/v1/resources.cpp (lines 93 - 105)


update this to handle backward compatibility issue



src/v1/resources.cpp (lines 1365 - 1368)


Losing no type case


- Guangya Liu


On 十一月 24, 2015, 7:24 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40375/
> ---
> 
> (Updated 十一月 24, 2015, 7:24 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3888
> https://issues.apache.org/jira/browse/MESOS-3888
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3888: We need to distinguish revocable resource for usage slack and 
> allocation slack.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 0b8289f 
>   include/mesos/v1/mesos.proto c98f2a4 
>   src/common/resources.cpp b4abf54 
>   src/tests/resources_tests.cpp dbd39cd 
>   src/v1/resources.cpp 8488c31 
> 
> Diff: https://reviews.apache.org/r/40375/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Review Request 40630: Upgrade pip to 7.1.2

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40630/
---

Review request for mesos, Bernd Mathiske, Joseph Wu, and Till Toenshoff.


Bugs: MESOS-3969
https://issues.apache.org/jira/browse/MESOS-3969


Repository: mesos


Description
---

Upgrade pip to 7.1.2


Diffs
-

  3rdparty/pip-1.5.6.tar.gz b2111358d013fb40390a60b5d55bac08639f3efc 
  3rdparty/pip-7.1.2.tar.gz PRE-CREATION 
  3rdparty/versions.am a3e17dfc935f640a7377ae118334fd303b52fc33 

Diff: https://reviews.apache.org/r/40630/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 38527: Fix UserCgroupIsolatorTest failed on CentOS 6.6.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38527/#review107736
---

Ship it!


Ship It!

- Alexander Rojas


On Oct. 6, 2015, 6:47 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38527/
> ---
> 
> (Updated Oct. 6, 2015, 6:47 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, and Cong Wang.
> 
> 
> Bugs: MESOS-3470
> https://issues.apache.org/jira/browse/MESOS-3470
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix UserCgroupIsolatorTest failed on CentOS 6.6.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/isolator_tests.cpp 
> 237f3f27722b01ff92d0dcbaba7910613542a1a7 
>   src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a 
>   src/tests/mesos.cpp ab2d85b091d121113931e4190a5b496901dcd7a5 
> 
> Diff: https://reviews.apache.org/r/38527/diff/
> 
> 
> Testing
> ---
> 
> # In CentOS 6.6
> sudo ./bin/mesos-tests.sh --gtest_filter="UserCgroupIsolatorTest*" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 40545: MESOS-3970: fix cpu usage in mesos ui

[Ian Babrou]

> On Nov. 24, 2015, 8:14 a.m., Klaus Ma wrote:
> > src/webui/master/static/js/services.js, line 130
> > 
> >
> > Do we know why timestamp is NaN?

Because mesos slaves do not supply it in metrics. It's not NaN, it's undefined, 
and undefined - undefined = NaN:

> undefined - undefined
NaN


- Ian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40545/#review107734
---


On Nov. 20, 2015, 5:01 p.m., Ian Babrou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40545/
> ---
> 
> (Updated Nov. 20, 2015, 5:01 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3970: fix cpu usage in mesos ui
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/js/services.js 
> d41bc7142ae0182e25b2ae9dce960ee38ab22361 
> 
> Diff: https://reviews.apache.org/r/40545/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ian Babrou
> 
>

Re: Review Request 39056: Fix for Mesos master crash due to check failure.

[Bernd Mathiske]

> On Oct. 6, 2015, 5:42 p.m., Klaus Ma wrote:
> > src/common/resources.cpp, line 879
> > 
> >
> > This fix is ok for this ticket; but how to handle other part about 
> > cpu()? Here's some question from me:
> > 1. if `epsilon` is 0.01 here, does it mean the min cpu is 0.01?
> > 2. is this the only code that need `epsilon`? It seems not
> > 
> > @jieyu/@mcypark, show we start a EPIC to include all precision related 
> > ticket? so, we can 
> > 1. unify the min cpu/men/disk to user
> > 2. unify the operator/code within allocator
> > 3. unify the precision between backend and UI
> > 4. clarify the requirement to cpu/mem, e.g. whether accept empty cpu/mem
> > 
> > Any comments?

I suggest (based on input from @benjaminhindman) we don't use a specific 
constant here, but try using CHECK_DOUBLE_EQ, first. Only if this does not 
work, we should switch to CHECK_NEAR, which takes epsilon as an argument. (In 
that case, we'd have to elevate the constant to a more prominent place and 
describe it in the docs as well.) With either of this, we'll have a viable 
short-term fix. The long-term solution will be pursued by MESOS-3997.


- Bernd


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39056/#review101727
---


On Oct. 6, 2015, 3:07 p.m., Mandeep Chadha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39056/
> ---
> 
> (Updated Oct. 6, 2015, 3:07 p.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Bugs: MESOS-3552
> https://issues.apache.org/jira/browse/MESOS-3552
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Check failed due to double comparison : MESOS-3552.
> 
> 
> Diffs
> -
> 
>   src/common/resources.cpp 601388c35a1bff37c58e753d1870d53b8d0af2d1 
>   src/tests/reservation_tests.cpp 6b7c43c8b5c64618249dbee926383242320c111e 
>   src/v1/resources.cpp dc868903472f8f3a1ddc56092e3f8f81d953ce39 
> 
> Diff: https://reviews.apache.org/r/39056/diff/
> 
> 
> Testing
> ---
> 
> Added unit test.
> make check successful.
> 
> 
> Thanks,
> 
> Mandeep Chadha
> 
>

Re: Review Request 40631: Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40631/#review107742
---



src/tests/mesos.hpp (line 87)


mistake? ;-)


- Guangya Liu


On 十一月 24, 2015, 9:19 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40631/
> ---
> 
> (Updated 十一月 24, 2015, 9:19 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3963
> https://issues.apache.org/jira/browse/MESOS-3963
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> According to the google code style, the using should be used in internal 
> namespace in header files. Grep the header files, only fetcher.hpp deserved a 
> path.
> 
> 
> > You may use a using-declaration anywhere in a .cc file (including in the 
> > global namespace), and in functions, methods, classes, or within internal 
> > namespaces in .h files.
> 
> >Do not use using-declarations in .h files except in explicitly marked 
> >internal-only namespaces, because anything imported into a namespace in a .h 
> >file becomes part of the public API exported by that file.
> 
> ```
> // OK in .cc files.
> // Must be in a function, method, internal namespace, or
> // class in .h files.
> using ::foo::bar;
> ```
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/fetcher.hpp 
> 78e7d145328c9f7aa9646fa7d6d92f834010053f 
>   src/tests/mesos.hpp a2a76f55f9a4091cccfccd9672c2d2897b34ddcd 
> 
> Diff: https://reviews.apache.org/r/40631/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 40010: Put authorize logic for teardown into a common function.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40010/
---

(Updated 十一月 24, 2015, 9:50 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Rebase


Bugs: MESOS-3838
https://issues.apache.org/jira/browse/MESOS-3838


Repository: mesos


Description
---

The mesos now have authorizeTask, authorizeFramework etc, it is
better to put authorize logic for teardown into a common function
authorizeTeardown.


Diffs (updated)
-

  src/master/http.cpp 6c647808a48879cbc176ffe7586c7e9b41bcf4c8 
  src/master/master.hpp e5e0ed01a56d869cc535687c8dbb6b99f6295b66 
  src/master/master.cpp 370980edfc80d1e52134fdaf3ce49177b6528b02 

Diff: https://reviews.apache.org/r/40010/diff/


Testing
---

Ubuntu 14.04
make
make check


Thanks,

Guangya Liu

Re: Review Request 40424: [WIP] ]Enhance the existing HTTP endpoint /roles

[Yong Qiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40424/
---

(Updated Nov. 24, 2015, 10:11 a.m.)


Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.


Bugs: MESOS-3791
https://issues.apache.org/jira/browse/MESOS-3791


Repository: mesos


Description
---

In this ticket, we will enhance the existing
HTTP endpoint to query roles as outlined in
the dynamic role design Doc.


Diffs (updated)
-

  include/mesos/role/role.proto PRE-CREATION 
  src/CMakeLists.txt cfe9d26c45ba42852fd1af958549954e7b04d448 
  src/Makefile.am a57e46d06c8c26a32a9444be4f0e1269d775f8b0 
  src/master/http.cpp 6c647808a48879cbc176ffe7586c7e9b41bcf4c8 
  src/master/master.hpp e5e0ed01a56d869cc535687c8dbb6b99f6295b66 
  src/master/role_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40424/diff/


Testing (updated)
---

Test results:
$ curl http://127.0.0.1:5050/roles
{"status":[{"infos":{"name":"*","weight":1.0}},{"infos":{"name":"aa","weight":1.0}},{"framework_id":[{"value":"f1e1af59-9468-4f
f0-8fb4-96825d86b6d7-0142"}],"infos":{"name":"bb","weight":1.0},"resources":[{"name":"cpus","role":"bb","scalar":{"value":5.0},
"type":"SCALAR"},{"name":"mem","role":"bb","scalar":{"value":640.0},"type":"SCALAR"}]},{"infos":{"name":"cc","weight":1.0}}]}


$ curl http://127.0.0.1:5050/roles/aa
{"status":[{"framework_id":[{"value":"f1e1af59-9468-4ff0-8fb4-96825d86b6d7-0305"}],"infos":{"name":"bb","weight":1.0},"resource
s":[{"name":"cpus","role":"bb","scalar":{"value":5.0},"type":"SCALAR"},{"name":"mem","role":"bb","scalar":{"value":640.0},"type
":"SCALAR"}]}]}


$ curl http://127.0.0.1:5050/roles/dd
The specified role [dd] does not exist!


Thanks,

Yong Qiao Wang

Review Request 40632: WIP: Enabled oversubscribed resources for reservations in allocator.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40632/
---

Review request for mesos and Klaus Ma.


Repository: mesos


Description
---

WIP: Enabled oversubscribed resources for reservations in allocator.


Diffs
-

  src/master/allocator/mesos/hierarchical.cpp 
aee8ced1fbfec8cf30cb939ff67fadfc6b08f37a 
  src/tests/resources_tests.cpp dbd39cd5a6786682a7b528b6fea37ab78904cf12 

Diff: https://reviews.apache.org/r/40632/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

[Bernd Mathiske]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39320/#review107748
---

Ship it!


Ship It!

- Bernd Mathiske


On Nov. 23, 2015, 9:52 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39320/
> ---
> 
> (Updated Nov. 23, 2015, 9:52 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3732
> https://issues.apache.org/jira/browse/MESOS-3732
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> 3bbd6cbf6b101415c90991c48f00f33a5aff5590 
> 
> Diff: https://reviews.apache.org/r/39320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> The run time for the `FaultToleranceTest.FrameworkReregister` test has 
> reduced from more than `1s` to less than `100ms`.
> Before:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (1018 ms)
> ```
> After:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (49 ms)
> ```
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 40602: Add missing DiscoveryInfo.Visibility field to v1/mesos.proto.

[Bernd Mathiske]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40602/#review107751
---

Ship it!


Ship It!

- Bernd Mathiske


On Nov. 23, 2015, 5:20 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40602/
> ---
> 
> (Updated Nov. 23, 2015, 5:20 p.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Neil Conway, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3989
> https://issues.apache.org/jira/browse/MESOS-3989
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added missing DiscoveryInfo.Visibility field to v1/mesos.proto.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/mesos.proto c98f2a49c3ec9b867053969839645126966587d4 
> 
> Diff: https://reviews.apache.org/r/40602/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 40631: Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"

[Klaus Ma]

> On Nov. 24, 2015, 5:42 p.m., Benjamin Bannier wrote:
> > src/tests/mesos.hpp, line 87
> > 
> >
> > This seems like a weird addition for this patch: while the existing 
> > `using` decls above could be justified (it's hard to imagine testing test 
> > infrastructure w/o having to perform some environment cleanup), 
> > unconditionally pulling in `mesos::fetcher::FetcherInfo` here seems way too 
> > general; also, it probably would make any attempt of e.g., mocking 
> > `FetcherInfo` anywhere much harder.
> > 
> > Either pull this into the internal namespace, or just do the extra 
> > typing here and pull it in in the corresponding `mesos.cpp`.

@Guangya/Ben, I'm thinking mesos.hpp as internal header :). Anyweay, maybe we 
move `using mesos::internal::slave::FetherInfo` into `mesos::internal::test` in 
`mesos.hpp`.


- Klaus


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40631/#review107741
---


On Nov. 24, 2015, 5:19 p.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40631/
> ---
> 
> (Updated Nov. 24, 2015, 5:19 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3963
> https://issues.apache.org/jira/browse/MESOS-3963
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> According to the google code style, the using should be used in internal 
> namespace in header files. Grep the header files, only fetcher.hpp deserved a 
> path.
> 
> 
> > You may use a using-declaration anywhere in a .cc file (including in the 
> > global namespace), and in functions, methods, classes, or within internal 
> > namespaces in .h files.
> 
> >Do not use using-declarations in .h files except in explicitly marked 
> >internal-only namespaces, because anything imported into a namespace in a .h 
> >file becomes part of the public API exported by that file.
> 
> ```
> // OK in .cc files.
> // Must be in a function, method, internal namespace, or
> // class in .h files.
> using ::foo::bar;
> ```
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/fetcher.hpp 
> 78e7d145328c9f7aa9646fa7d6d92f834010053f 
>   src/tests/mesos.hpp a2a76f55f9a4091cccfccd9672c2d2897b34ddcd 
> 
> Diff: https://reviews.apache.org/r/40631/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Review Request 40631: Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40631/
---

Review request for mesos.


Bugs: MESOS-3963
https://issues.apache.org/jira/browse/MESOS-3963


Repository: mesos


Description
---

According to the google code style, the using should be used in internal 
namespace in header files. Grep the header files, only fetcher.hpp deserved a 
path.


> You may use a using-declaration anywhere in a .cc file (including in the 
> global namespace), and in functions, methods, classes, or within internal 
> namespaces in .h files.

>Do not use using-declarations in .h files except in explicitly marked 
>internal-only namespaces, because anything imported into a namespace in a .h 
>file becomes part of the public API exported by that file.

```
// OK in .cc files.
// Must be in a function, method, internal namespace, or
// class in .h files.
using ::foo::bar;
```


Diffs
-

  src/slave/containerizer/fetcher.hpp 78e7d145328c9f7aa9646fa7d6d92f834010053f 
  src/tests/mesos.hpp a2a76f55f9a4091cccfccd9672c2d2897b34ddcd 

Diff: https://reviews.apache.org/r/40631/diff/


Testing
---

make && make check


Thanks,

Klaus Ma

Re: Review Request 40545: MESOS-3970: fix cpu usage in mesos ui

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40545/#review107739
---

Ship it!


Ship It!

- Klaus Ma


On Nov. 21, 2015, 1:01 a.m., Ian Babrou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40545/
> ---
> 
> (Updated Nov. 21, 2015, 1:01 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3970: fix cpu usage in mesos ui
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/js/services.js 
> d41bc7142ae0182e25b2ae9dce960ee38ab22361 
> 
> Diff: https://reviews.apache.org/r/40545/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ian Babrou
> 
>

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

[Klaus Ma]

> On Nov. 23, 2015, 8:58 a.m., Guangya Liu wrote:
> > src/slave/slave.cpp, line 4419
> > 
> >
> > I think that the oversubscribable resources should always 
> > has_revocable()? For which case does the oversubscribable resource do not 
> > has_revocable()? Caused by a bad resource estimitator? For such case, can 
> > we let slave throw exception?

Should we keep the compatitility?


- Klaus


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40379/#review107527
---


On Nov. 24, 2015, 7:02 p.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40379/
> ---
> 
> (Updated Nov. 24, 2015, 7:02 p.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-3930
> https://issues.apache.org/jira/browse/MESOS-3930
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In Optimistic Offer Phase 1, it introduce `RevocableInfo::type`: USAGE_SLACK 
> for Oversubscription and ALLOCATION_SLACK for Optimistic Offer. Slave helps 
> to update `RevocableInfo::type` for Oversubscription.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 9055f2a 
> 
> Diff: https://reviews.apache.org/r/40379/diff/
> 
> 
> Testing
> ---
> 
> make (make check is on-going)
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40379/
---

(Updated Nov. 24, 2015, 7:02 p.m.)


Review request for mesos and Guangya Liu.


Changes
---

Address comments


Bugs: MESOS-3930
https://issues.apache.org/jira/browse/MESOS-3930


Repository: mesos


Description
---

In Optimistic Offer Phase 1, it introduce `RevocableInfo::type`: USAGE_SLACK 
for Oversubscription and ALLOCATION_SLACK for Optimistic Offer. Slave helps to 
update `RevocableInfo::type` for Oversubscription.


Diffs (updated)
-

  src/slave/slave.cpp 9055f2a 

Diff: https://reviews.apache.org/r/40379/diff/


Testing
---

make (make check is on-going)


Thanks,

Klaus Ma

Re: Review Request 40631: Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40631/#review107741
---



src/tests/mesos.hpp (line 87)


This seems like a weird addition for this patch: while the existing `using` 
decls above could be justified (it's hard to imagine testing test 
infrastructure w/o having to perform some environment cleanup), unconditionally 
pulling in `mesos::fetcher::FetcherInfo` here seems way too general; also, it 
probably would make any attempt of e.g., mocking `FetcherInfo` anywhere much 
harder.

Either pull this into the internal namespace, or just do the extra typing 
here and pull it in in the corresponding `mesos.cpp`.


- Benjamin Bannier


On Nov. 24, 2015, 9:19 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40631/
> ---
> 
> (Updated Nov. 24, 2015, 9:19 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3963
> https://issues.apache.org/jira/browse/MESOS-3963
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> According to the google code style, the using should be used in internal 
> namespace in header files. Grep the header files, only fetcher.hpp deserved a 
> path.
> 
> 
> > You may use a using-declaration anywhere in a .cc file (including in the 
> > global namespace), and in functions, methods, classes, or within internal 
> > namespaces in .h files.
> 
> >Do not use using-declarations in .h files except in explicitly marked 
> >internal-only namespaces, because anything imported into a namespace in a .h 
> >file becomes part of the public API exported by that file.
> 
> ```
> // OK in .cc files.
> // Must be in a function, method, internal namespace, or
> // class in .h files.
> using ::foo::bar;
> ```
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/fetcher.hpp 
> 78e7d145328c9f7aa9646fa7d6d92f834010053f 
>   src/tests/mesos.hpp a2a76f55f9a4091cccfccd9672c2d2897b34ddcd 
> 
> Diff: https://reviews.apache.org/r/40631/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 39712: Refactor registry client/puller to avoid JSON and struct.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39712/#review107746
---


Patch looks great!

Reviews applied: [39712]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 24, 2015, 6:52 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39712/
> ---
> 
> (Updated Nov. 24, 2015, 6:52 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3994
> https://issues.apache.org/jira/browse/MESOS-3994
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactor registry client/puller to avoid JSON and struct.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
> 22873276a04941c52e4df41750174c86515f1951 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> 99a421b21cce8311b729689c4c4099206e85dc1f 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 94b7539b1e1d3b83f0c608d2ac3af9aebbd8b2e6 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 88b914d3d4a56a51750a75c0988547e2a3e94f56 
> 
> Diff: https://reviews.apache.org/r/39712/diff/
> 
> 
> Testing
> ---
> 
> make check(ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

[Klaus Ma]

> On Nov. 24, 2015, 10:25 p.m., Guangya Liu wrote:
> > Seems the rebase caused some problem for your patch, some files are lost.

There's only file for this patch; if still issue, please ping me online.


> On Nov. 24, 2015, 10:25 p.m., Guangya Liu wrote:
> > src/slave/slave.cpp, line 4460
> > 
> >
> > s/allocations/usage slack?

Used comments in `mesos.proto`


- Klaus


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40379/#review107786
---


On Nov. 24, 2015, 7:02 p.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40379/
> ---
> 
> (Updated Nov. 24, 2015, 7:02 p.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-3930
> https://issues.apache.org/jira/browse/MESOS-3930
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In Optimistic Offer Phase 1, it introduce `RevocableInfo::type`: USAGE_SLACK 
> for Oversubscription and ALLOCATION_SLACK for Optimistic Offer. Slave helps 
> to update `RevocableInfo::type` for Oversubscription.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 9055f2a 
> 
> Diff: https://reviews.apache.org/r/40379/diff/
> 
> 
> Testing
> ---
> 
> make (make check is on-going)
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 40647: Updated centos6.6 installation instructions.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40647/
---

(Updated Nov. 24, 2015, 2:50 p.m.)


Review request for mesos, Bernd Mathiske, Till Toenshoff, and Timothy Chen.


Bugs: MESOS-3974
https://issues.apache.org/jira/browse/MESOS-3974


Repository: mesos


Description
---

For full support for the Docker- and MesosContainerizers we require a
relatively recent kernel. Document this dependency.


Diffs (updated)
-

  docs/getting-started.md 8e1df88 

Diff: https://reviews.apache.org/r/40647/diff/


Testing
---

Confirmed that the test succeeds with the suggested change.


Thanks,

Benjamin Bannier

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

[Guangya Liu]

> On 十一月 23, 2015, 12:58 a.m., Guangya Liu wrote:
> > src/slave/slave.cpp, line 4419
> > 
> >
> > I think that the oversubscribable resources should always 
> > has_revocable()? For which case does the oversubscribable resource do not 
> > has_revocable()? Caused by a bad resource estimitator? For such case, can 
> > we let slave throw exception?
> 
> Klaus Ma wrote:
> Should we keep the compatitility?

Yes, we should keep compatibility. But the problem is that all of the revocable 
resources no matter usage_slack or allocation_slack should has_revocable()? 
Comments?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40379/#review107527
---


On 十一月 24, 2015, 11:02 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40379/
> ---
> 
> (Updated 十一月 24, 2015, 11:02 a.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-3930
> https://issues.apache.org/jira/browse/MESOS-3930
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In Optimistic Offer Phase 1, it introduce `RevocableInfo::type`: USAGE_SLACK 
> for Oversubscription and ALLOCATION_SLACK for Optimistic Offer. Slave helps 
> to update `RevocableInfo::type` for Oversubscription.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 9055f2a 
> 
> Diff: https://reviews.apache.org/r/40379/diff/
> 
> 
> Testing
> ---
> 
> make (make check is on-going)
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40379/#review107786
---


Seems the rebase caused some problem for your patch, some files are lost.


src/slave/slave.cpp (line 4460)


s/allocations/usage slack?


- Guangya Liu


On 十一月 24, 2015, 11:02 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40379/
> ---
> 
> (Updated 十一月 24, 2015, 11:02 a.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-3930
> https://issues.apache.org/jira/browse/MESOS-3930
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In Optimistic Offer Phase 1, it introduce `RevocableInfo::type`: USAGE_SLACK 
> for Oversubscription and ALLOCATION_SLACK for Optimistic Offer. Slave helps 
> to update `RevocableInfo::type` for Oversubscription.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 9055f2a 
> 
> Diff: https://reviews.apache.org/r/40379/diff/
> 
> 
> Testing
> ---
> 
> make (make check is on-going)
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

[Alexander Rukletsov]

> On Nov. 24, 2015, 1:52 p.m., Benjamin Bannier wrote:
> > src/tests/fault_tolerance_tests.cpp, line 778
> > 
> >
> > You should just use `master::Flags().allocation_interval` to simplify 
> > this.

Do you think it will be cleaner? I have following thoughts:
- it extracts the default value from the `master::Flags` structs instead of 
being in sync with the test environment created by `CreateMasterFlags()`;
- we create a complete `master::Flags` object in order to use one flag.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39320/#review107780
---


On Nov. 24, 2015, 1:13 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39320/
> ---
> 
> (Updated Nov. 24, 2015, 1:13 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Bernd Mathiske, Neil Conway, and 
> Till Toenshoff.
> 
> 
> Bugs: MESOS-3732
> https://issues.apache.org/jira/browse/MESOS-3732
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> 3bbd6cbf6b101415c90991c48f00f33a5aff5590 
>   src/tests/mesos.hpp a2a76f55f9a4091cccfccd9672c2d2897b34ddcd 
>   src/tests/mesos.cpp b2211d59ed571ec8ddc132f69ed1cf5da9eeef10 
> 
> Diff: https://reviews.apache.org/r/39320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> The run time for the `FaultToleranceTest.FrameworkReregister` test has 
> reduced from more than `1s` to less than `100ms`.
> Before:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (1018 ms)
> ```
> After:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (49 ms)
> ```
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Review Request 40647: Updated centos6.6 installation instructions.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40647/
---

Review request for mesos, Bernd Mathiske, Till Toenshoff, and Timothy Chen.


Bugs: MESOS-3974
https://issues.apache.org/jira/browse/MESOS-3974


Repository: mesos


Description
---

For full support for the Docker- and MesosContainerizers we require a
relatively recent kernel. Document this dependency.


Diffs
-

  docs/getting-started.md 8e1df88fcf9e932dfc01b7455e63553ac028a904 

Diff: https://reviews.apache.org/r/40647/diff/


Testing
---

Confirmed that the test succeeds with the suggested change.


Thanks,

Benjamin Bannier

Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/
---

(Updated Nov. 24, 2015, 10:48 p.m.)


Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van 
Remoortere.


Summary (updated)
-

Support distinguishing revocable resources in the Resource protobuf.


Bugs: MESOS-3888
https://issues.apache.org/jira/browse/MESOS-3888


Repository: mesos


Description
---

MESOS-3888: We need to distinguish revocable resource for usage slack and 
allocation slack.


Diffs
-

  include/mesos/mesos.proto 0b8289f 
  include/mesos/v1/mesos.proto c98f2a4 
  src/common/resources.cpp b4abf54 
  src/tests/resources_tests.cpp dbd39cd 
  src/v1/resources.cpp 8488c31 

Diff: https://reviews.apache.org/r/40375/diff/


Testing
---

make && make check


Thanks,

Klaus Ma

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40332/
---

(Updated Nov. 24, 2015, 3:07 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
Joseph Wu, and Qian Zhang.


Changes
---

Rephrased logs.


Bugs: MESOS-3981
https://issues.apache.org/jira/browse/MESOS-3981


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
2a21364fdcaa4ec5e5567b9f367c14a1579b9a49 
  src/master/allocator/mesos/hierarchical.cpp 
aee8ced1fbfec8cf30cb939ff67fadfc6b08f37a 

Diff: https://reviews.apache.org/r/40332/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 40375: [WIP] Support distinguishing revocable resources in the Resource protobuf.

[Klaus Ma]

> On Nov. 24, 2015, 4:26 p.m., Guangya Liu wrote:
> > src/tests/resources_tests.cpp, line 1982
> > 
> >
> > EXPECT_TRUE((r3 - r3).empty());

This is added the previous code, so i'd like to drop this issue.


> On Nov. 24, 2015, 4:26 p.m., Guangya Liu wrote:
> > src/tests/resources_tests.cpp, line 1986
> > 
> >
> > Add EXPECT_TRUE((r5 - r5).empty());

ditto


> On Nov. 24, 2015, 4:26 p.m., Guangya Liu wrote:
> > src/tests/resources_tests.cpp, lines 1941-1948
> > 
> >
> > new line to split.
> > 
> > It is suggested to add new line if one sentense is split to two lines.

I keep the same style with other code in `resources_test.cpp`, so i'd like to 
keep it as is.


> On Nov. 24, 2015, 4:26 p.m., Guangya Liu wrote:
> > include/mesos/mesos.proto, line 649
> > 
> >
> > Did you get out how to leverage this default value in the code? ;-)

Did not try it, but I think calling `mutable_type()` (or similar) will set the 
type. `mutable_revocable()` will only create revocable object instead of 
RevocableInfo::type.


> On Nov. 24, 2015, 4:26 p.m., Guangya Liu wrote:
> > src/tests/resources_tests.cpp, line 800
> > 
> >
> > Do we need to update this? The standard revocable resource should be 
> > usage slack

I mean unset RevocableInfo::type; maybe `Unset RevocableInfo::type revocable 
resource` is better.


- Klaus


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/#review107732
---


On Nov. 24, 2015, 3:24 p.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40375/
> ---
> 
> (Updated Nov. 24, 2015, 3:24 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3888
> https://issues.apache.org/jira/browse/MESOS-3888
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3888: We need to distinguish revocable resource for usage slack and 
> allocation slack.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 0b8289f 
>   include/mesos/v1/mesos.proto c98f2a4 
>   src/common/resources.cpp b4abf54 
>   src/tests/resources_tests.cpp dbd39cd 
>   src/v1/resources.cpp 8488c31 
> 
> Diff: https://reviews.apache.org/r/40375/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 40375: [WIP] Support distinguishing revocable resources in the Resource protobuf.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/
---

(Updated Nov. 24, 2015, 7:35 p.m.)


Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van 
Remoortere.


Changes
---

Address comments.


Bugs: MESOS-3888
https://issues.apache.org/jira/browse/MESOS-3888


Repository: mesos


Description
---

MESOS-3888: We need to distinguish revocable resource for usage slack and 
allocation slack.


Diffs (updated)
-

  include/mesos/mesos.proto 0b8289f 
  include/mesos/v1/mesos.proto c98f2a4 
  src/common/resources.cpp b4abf54 
  src/tests/resources_tests.cpp dbd39cd 
  src/v1/resources.cpp 8488c31 

Diff: https://reviews.apache.org/r/40375/diff/


Testing
---

make && make check


Thanks,

Klaus Ma

Re: Review Request 40545: MESOS-3970: fix cpu usage in mesos ui

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40545/#review107763
---


Bad review!

Reviews applied: []

Error:
 No reviewers specified. Please find a reviewer by asking on JIRA or the 
mailing list.

- Mesos ReviewBot


On Nov. 20, 2015, 5:01 p.m., Ian Babrou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40545/
> ---
> 
> (Updated Nov. 20, 2015, 5:01 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3970: fix cpu usage in mesos ui
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/js/services.js 
> d41bc7142ae0182e25b2ae9dce960ee38ab22361 
> 
> Diff: https://reviews.apache.org/r/40545/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ian Babrou
> 
>

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

[Alexander Rukletsov]

> On Nov. 23, 2015, 6:45 p.m., Neil Conway wrote:
> > An alternative would be to pause and advance the clock by the 
> > allocation_interval. Do you think that would be worth doing instead?

That's correct. I was not sure what approach is easier to understand. After you 
input I have checked the "testing-patterns.md" doc and it looks like clock 
magic is well documented and may therefore be a preferred solution. Will update 
the patch shortly.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39320/#review107625
---


On Nov. 23, 2015, 5:52 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39320/
> ---
> 
> (Updated Nov. 23, 2015, 5:52 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3732
> https://issues.apache.org/jira/browse/MESOS-3732
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> 3bbd6cbf6b101415c90991c48f00f33a5aff5590 
> 
> Diff: https://reviews.apache.org/r/39320/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> The run time for the `FaultToleranceTest.FrameworkReregister` test has 
> reduced from more than `1s` to less than `100ms`.
> Before:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (1018 ms)
> ```
> After:
> ```
> [ RUN  ] FaultToleranceTest.FrameworkReregister
> [   OK ] FaultToleranceTest.FrameworkReregister (49 ms)
> ```
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 40641: Increase launch and wait timeout in LinuxFilesystemIsolatorTest.ROOT_ImageInVolumeWithRootFilesystem.

[Bernd Mathiske]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40641/#review107772
---


Have you tested this?

- Bernd Mathiske


On Nov. 24, 2015, 5:20 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40641/
> ---
> 
> (Updated Nov. 24, 2015, 5:20 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Jan Schlicht, Till Toenshoff, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-3966
> https://issues.apache.org/jira/browse/MESOS-3966
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Increase launch and wait timeout in 
> LinuxFilesystemIsolatorTest.ROOT_ImageInVolumeWithRootFilesystem.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> dab3abd0d87ae8ec6e4dea6a48870ace7a3cdad3 
> 
> Diff: https://reviews.apache.org/r/40641/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 40641: Increase launch and wait timeout in LinuxFilesystemIsolatorTest.ROOT_ImageInVolumeWithRootFilesystem.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40641/
---

(Updated Nov. 24, 2015, 1:45 p.m.)


Review request for mesos, Bernd Mathiske, Jan Schlicht, Till Toenshoff, and 
Timothy Chen.


Changes
---

Add comments.


Bugs: MESOS-3966
https://issues.apache.org/jira/browse/MESOS-3966


Repository: mesos


Description
---

Increase launch and wait timeout in 
LinuxFilesystemIsolatorTest.ROOT_ImageInVolumeWithRootFilesystem.


Diffs (updated)
-

  src/tests/containerizer/filesystem_isolator_tests.cpp 
dab3abd0d87ae8ec6e4dea6a48870ace7a3cdad3 

Diff: https://reviews.apache.org/r/40641/diff/


Testing
---


Thanks,

haosdent huang