Re: Review Request 41444: Cleaned up Authorizer interface.

2015-12-22 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41444/#review111614
---


Patch looks great!

Reviews applied: [41444]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 22, 2015, 1:53 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41444/
> ---
> 
> (Updated Dec. 22, 2015, 1:53 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Greg Mann, Jan Schlicht, 
> and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Extract a repetitive part of the function comments into a class comment. 
> Added backticks, quotes when necessary, formatted comments to avoid 
> jaggedness.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.hpp 
> 19f6e1a2d025bf6ff07f515b10d41e8a48d7d0b4 
>   src/master/main.cpp e00f878770f3e0bddae5a137b50a00822d154e2c 
> 
> Diff: https://reviews.apache.org/r/41444/diff/
> 
> 
> Testing
> ---
> 
> None: not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Review Request 41648: Used initializer list c-tor for brevity.

2015-12-22 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41648/
---

Review request for mesos.


Repository: mesos


Description
---

Used initializer list c-tor for brevity.


Diffs
-

  src/master/allocator/mesos/hierarchical.cpp 
775182515dcb52bd873ecdf98c827320251a59c8 

Diff: https://reviews.apache.org/r/41648/diff/


Testing
---

`make check` on Mac OS 10.10.4


Thanks,

Alexander Rukletsov



Review Request 41656: Renamed containerizer.md to mesos-containerizer.md.

2015-12-22 Thread Jojy Varghese

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41656/
---

Review request for mesos, Jie Yu and Joerg Schad.


Repository: mesos


Description
---

The change reflects the content of the documentation. A separate document that
  describes containerizer from a user perspective will be created.


Diffs
-

  docs/containerizer.md  
  docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 

Diff: https://reviews.apache.org/r/41656/diff/


Testing
---

mesos website docker.


Thanks,

Jojy Varghese



Re: Review Request 41515: Refactored error messages to reduce jaggedness.

2015-12-22 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41515/#review111640
---

Ship it!


Ship It!

- Joris Van Remoortere


On Dec. 22, 2015, 6:08 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41515/
> ---
> 
> (Updated Dec. 22, 2015, 6:08 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> and Neil Conway.
> 
> 
> Bugs: MESOS-3960
> https://issues.apache.org/jira/browse/MESOS-3960
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Includes minor updates to wording and punctuation.
> 
> 
> Diffs
> -
> 
>   src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 
> 
> Diff: https://reviews.apache.org/r/41515/diff/
> 
> 
> Testing
> ---
> 
> make check on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 41593: stout: Added `jsonify` function.

2015-12-22 Thread Michael Park

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41593/
---

(Updated Dec. 22, 2015, 8:39 p.m.)


Review request for mesos and Benjamin Hindman.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/README.md 
a2a3dc6120b10c8fe82088b9f0ebecfa5642f945 
  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
  3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41593/diff/


Testing
---


Thanks,

Michael Park



Re: Review Request 41575: Removed outdated "Logging and Debugging" doc page.

2015-12-22 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41575/#review111658
---

Ship it!


Ship It!

- Joris Van Remoortere


On Dec. 19, 2015, 12:14 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41575/
> ---
> 
> (Updated Dec. 19, 2015, 12:14 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-934
> https://issues.apache.org/jira/browse/MESOS-934
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed outdated "Logging and Debugging" doc page.
> 
> 
> Diffs
> -
> 
>   docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 
>   docs/logging-and-debugging.md 6797d156b244e0f08dbd754c5adc80a22e247693 
> 
> Diff: https://reviews.apache.org/r/41575/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>



Re: Review Request 41656: Renamed containerizer.md to mesos-containerizer.md.

2015-12-22 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41656/#review111660
---

Ship it!



docs/home.md (line 34)


This document has a link to the exiting containerizer doc (on Github).


- Joseph Wu


On Dec. 22, 2015, 11:33 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41656/
> ---
> 
> (Updated Dec. 22, 2015, 11:33 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The change reflects the content of the documentation. A separate document that
>   describes containerizer from a user perspective will be created.
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md  
>   docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 
> 
> Diff: https://reviews.apache.org/r/41656/diff/
> 
> 
> Testing
> ---
> 
> mesos website docker.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>



Review Request 41658: Track the allocation candidates to bound the allocation queue.

2015-12-22 Thread James Peach

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41658/
---

Review request for mesos, Ben Mahler and Klaus Ma.


Bugs: MESOS-3157
https://issues.apache.org/jira/browse/MESOS-3157


Repository: mesos


Description
---

When there is churn in the cluster, frequent resource allocation
is required.  Maintain a set of allocation candidates so that we
don't end up running the same allocation multiple times.

This review is just for feedback. Not proposing it to be berged at this time.


Diffs
-

  src/master/allocator/mesos/hierarchical.hpp 
86ea5a402ed67f8f22f11d5730147cd907d66a08 
  src/master/allocator/mesos/hierarchical.cpp 
775182515dcb52bd873ecdf98c827320251a59c8 

Diff: https://reviews.apache.org/r/41658/diff/


Testing
---

make check.


Thanks,

James Peach



Re: Review Request 41593: stout: Added `jsonify` function.

2015-12-22 Thread Michael Park


> On Dec. 22, 2015, 4:52 a.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, line 192
> > 
> >
> > Why not s/type/type_/ here?

I think I was following the guideline of "add the trailing underscore if there 
are conflicts, otherwise use the *nicer* name".

I'm totally on board with using a single naming scheme for member variables 
though :)


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41593/#review111575
---


On Dec. 22, 2015, 8:23 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41593/
> ---
> 
> (Updated Dec. 22, 2015, 8:23 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/README.md 
> a2a3dc6120b10c8fe82088b9f0ebecfa5642f945 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
>   3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41593/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>



Re: Review Request 41593: stout: Added `jsonify` function.

2015-12-22 Thread Michael Park

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41593/
---

(Updated Dec. 22, 2015, 8:42 p.m.)


Review request for mesos and Benjamin Hindman.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/README.md 
a2a3dc6120b10c8fe82088b9f0ebecfa5642f945 
  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
  3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41593/diff/


Testing
---


Thanks,

Michael Park



Re: Review Request 41603: Cleaned up quota HTTP handling code and tests.

2015-12-22 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41603/#review111644
---


Patch looks great!

Reviews applied: [41514, 41515, 41603]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 22, 2015, 6:08 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41603/
> ---
> 
> (Updated Dec. 22, 2015, 6:08 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3960
> https://issues.apache.org/jira/browse/MESOS-3960
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Define a variable earlier in the handler for clarity; add consts; add
> and re-order using directive where appropriate.
> 
> 
> Diffs
> -
> 
>   src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 
>   src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1 
> 
> Diff: https://reviews.apache.org/r/41603/diff/
> 
> 
> Testing
> ---
> 
> make check on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 41026: libevent ssl: Added check for buffer length before swapping request.

2015-12-22 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41026/#review111657
---

Ship it!


Ship It!

- Joris Van Remoortere


On Dec. 18, 2015, 11:53 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41026/
> ---
> 
> (Updated Dec. 18, 2015, 11:53 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4069
> https://issues.apache.org/jira/browse/MESOS-4069
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> recv_callback could be called from libevents receive callback and Socket::recv
> for the same buffer event and different requests. There is a check for buffer
> length at Socket::recv but not at libevent's receive callback. This could lead
> to the incoming request for Socket::recv being swapped out even though the
> buffer length is zero. This change adds a check for buffer length before
> swapping out the receive request object.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/libevent_ssl_socket.cpp 
> 55b91dd47bb5bd5e97147d0af91c7899fd42702c 
> 
> Diff: https://reviews.apache.org/r/41026/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>



Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2015-12-22 Thread Alex Clemmer


> On Oct. 6, 2015, 5:12 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp,
> >  line 87
> > 
> >
> > Seems like this will give a negative array access if you set `path = 
> > "";`.
> 
> Joris Van Remoortere wrote:
> I don't see where this issue was "fixed".

Per our conversation, this is fixed because we check that the path is not empty 
at the beginning of the function.

In the future, when I fix something non-obvious, I'll make sure to write down 
as a response to the comment where it was fixed.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/#review101663
---


On Nov. 17, 2015, 7:06 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39019/
> ---
> 
> (Updated Nov. 17, 2015, 7:06 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added dirent compat code for non-Unix systems.
> 
> 
> Diffs
> -
> 
>   
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> 1a7037d64afeedc340258c92067e95d1d3caa027 
> 
> Diff: https://reviews.apache.org/r/39019/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 41425: Fix the Mesos pkg-config.

2015-12-22 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41425/#review111664
---

Ship it!


LGTM.

- Joseph Wu


On Dec. 22, 2015, 12:45 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41425/
> ---
> 
> (Updated Dec. 22, 2015, 12:45 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Alex Clemmer, Joris 
> Van Remoortere, Joseph Wu, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3909
> https://issues.apache.org/jira/browse/MESOS-3909
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The pkg-config file needs to explicitly set the -I path, and also
> set and preprocessor definitions that Mesos assumes will be set for
> picojson.h.
> 
> 
> Diffs
> -
> 
>   mesos.pc.in bc4f7e778dd8e5e2bd5e8f4181d62934ac423135 
> 
> Diff: https://reviews.apache.org/r/41425/diff/
> 
> 
> Testing
> ---
> 
> Check various pkg-config invocations and make sure they are sane:
> 
> $ PKG_CONFIG_PATH=/opt/mesos/lib/pkgconfig pkg-config --libs mesos
> -L/opt/mesos/lib -lmesos
> $ PKG_CONFIG_PATH=/opt/mesos/lib/pkgconfig pkg-config --cflags mesos
> -DPICOJSON_USE_INT64 -D__STDC_FORMAT_MACROS -I/opt/mesos/include
> $ PKG_CONFIG_PATH=/opt/mesos/lib/pkgconfig pkg-config --cflags-only-I 
> mesos
> -I/opt/mesos/include
> 
> 
> Thanks,
> 
> James Peach
> 
>



Re: Review Request 41513: Cleaned up STL I/O includes.

2015-12-22 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41513/#review111635
---


Patch looks great!

Reviews applied: [41509, 41510, 41511, 41512, 41513]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 22, 2015, 5:59 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41513/
> ---
> 
> (Updated Dec. 22, 2015, 5:59 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Joris Van Remoortere, and Michael 
> Park.
> 
> 
> Bugs: MESOS-4183
> https://issues.apache.org/jira/browse/MESOS-4183
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Move `operator<<` definitions to ".cpp" files and include ``
> in ".hpp"s.
> 
> 
> Diffs
> -
> 
>   src/linux/perf.cpp 8ee9f381c3587bb2fa0f309a477035340bc44e15 
>   src/linux/routing/filter/ip.hpp 1a63dcca2badc041e73fe454a9994b82695117de 
>   src/linux/routing/filter/ip.cpp 158bab6cb95fe10b8dc41b22934a946b21ff88ed 
>   src/linux/routing/handle.hpp 5b03be5e70ad3910487a1867fa4fa0d8de25d11e 
>   src/linux/routing/handle.cpp e88c6eb7336ac31683a6ff394a139f6777576a3e 
>   src/messages/messages.hpp 350118399927a8d7185d87a6a8e3370b7158fe14 
>   src/messages/messages.cpp 30f55bb8ee5a57ff9517144ffc43d45df6b3de5b 
> 
> Diff: https://reviews.apache.org/r/41513/diff/
> 
> 
> Testing
> ---
> 
> make check on Mac OS 10.10.4.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 41603: Cleaned up quota HTTP handling code and tests.

2015-12-22 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41603/#review111641
---

Ship it!


Ship It!

- Joris Van Remoortere


On Dec. 22, 2015, 6:08 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41603/
> ---
> 
> (Updated Dec. 22, 2015, 6:08 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3960
> https://issues.apache.org/jira/browse/MESOS-3960
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Define a variable earlier in the handler for clarity; add consts; add
> and re-order using directive where appropriate.
> 
> 
> Diffs
> -
> 
>   src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 
>   src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1 
> 
> Diff: https://reviews.apache.org/r/41603/diff/
> 
> 
> Testing
> ---
> 
> make check on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 41593: stout: Added `jsonify` function.

2015-12-22 Thread Michael Park

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41593/
---

(Updated Dec. 22, 2015, 8:49 p.m.)


Review request for mesos and Benjamin Hindman.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/README.md 
a2a3dc6120b10c8fe82088b9f0ebecfa5642f945 
  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
  3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41593/diff/


Testing
---


Thanks,

Michael Park



Re: Review Request 41657: Added user facing documentation for containerizers.

2015-12-22 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41657/#review111662
---


Patch looks great!

Reviews applied: [41656, 41657]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 22, 2015, 7:35 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41657/
> ---
> 
> (Updated Dec. 22, 2015, 7:35 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This documentation is intended for users trying to get an overview of
> containerizer technology. It also provides the criteria for selecting a
> particular type of containerizer.
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md PRE-CREATION 
>   docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 
> 
> Diff: https://reviews.apache.org/r/41657/diff/
> 
> 
> Testing
> ---
> 
> mesos website docker.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>



Re: Review Request 41657: Added user facing documentation for containerizers.

2015-12-22 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41657/#review111665
---


Looks good.  Just a few suggestions:


docs/containerizer.md (lines 13 - 15)


I feel like these three points say the same thing.  Maybe you can condense 
them down to two points.

Wording suggestion: 

* Isolate a task from other running tasks by restricting the resources the 
task can access.
* Programmatically control a task's resource usage.



docs/containerizer.md (lines 19 - 20)


Suggestion: The user can specify what types of containerizer to use via the 
`--containerizers` agent flag.



docs/containerizer.md (line 25)


You can also say that Docker is a "first-class citizen" of Mesos.



docs/containerizer.md (line 53)


Maybe: s/OSX/POSIX/



docs/containerizer.md (line 61)


Mis-matched closing parentheses.


- Joseph Wu


On Dec. 22, 2015, 11:35 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41657/
> ---
> 
> (Updated Dec. 22, 2015, 11:35 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This documentation is intended for users trying to get an overview of
> containerizer technology. It also provides the criteria for selecting a
> particular type of containerizer.
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md PRE-CREATION 
>   docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 
> 
> Diff: https://reviews.apache.org/r/41657/diff/
> 
> 
> Testing
> ---
> 
> mesos website docker.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>



Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-22 Thread Avinash sridharan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41380/
---

(Updated Dec. 22, 2015, 10:03 p.m.)


Review request for mesos, Adam B and Anand Mazumdar.


Bugs: MESOS-4114
https://issues.apache.org/jira/browse/MESOS-4114


Repository: mesos


Description
---

Added repeated vip field to DiscoveryInfo and an instance_port field to Port


Diffs (updated)
-

  include/mesos/mesos.proto 2431fdd6b84625c6140a2b3913736bffada4e7f6 
  include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8 

Diff: https://reviews.apache.org/r/41380/diff/


Testing
---

make check, and make


Thanks,

Avinash sridharan



Re: Review Request 41657: Added user facing documentation for containerizers.

2015-12-22 Thread Jojy Varghese


> On Dec. 22, 2015, 9:42 p.m., Joseph Wu wrote:
> > docs/containerizer.md, lines 13-15
> > 
> >
> > I feel like these three points say the same thing.  Maybe you can 
> > condense them down to two points.
> > 
> > Wording suggestion: 
> > 
> > * Isolate a task from other running tasks by restricting the resources 
> > the task can access.
> > * Programmatically control a task's resource usage.

Thanks for the suggestions Joseph. I feel that restricting resources and 
isolation are separate concerns. For example in Linux, isolation is achieved 
via namespaces and resource restriction is achieved through cgroups. Today 
network namespace does not have ability to restrict bandwidth usage.


- Jojy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41657/#review111665
---


On Dec. 22, 2015, 7:35 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41657/
> ---
> 
> (Updated Dec. 22, 2015, 7:35 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This documentation is intended for users trying to get an overview of
> containerizer technology. It also provides the criteria for selecting a
> particular type of containerizer.
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md PRE-CREATION 
>   docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 
> 
> Diff: https://reviews.apache.org/r/41657/diff/
> 
> 
> Testing
> ---
> 
> mesos website docker.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>



Re: Review Request 41656: Renamed containerizer.md to mesos-containerizer.md.

2015-12-22 Thread Joerg Schad


> On Dec. 22, 2015, 10:24 p.m., Guangya Liu wrote:
> > I found that all of the links in home.md does not work, take "Getting 
> > Started" as example, it will redirect to 
> > https://github.com/apache/mesos/blob/master/documentation/latest/getting-started
> >  and report 404 error.

I guess that is the difference in creating links between github and the 
published website. http://mesos.apache.org/documentation/latest/ works fine for 
me.


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41656/#review111674
---


On Dec. 22, 2015, 10:11 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41656/
> ---
> 
> (Updated Dec. 22, 2015, 10:11 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The change reflects the content of the documentation. A separate document that
>   describes containerizer from a user perspective will be created.
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md  
>   docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 
>   docs/mesos-provisioner.md fdb298c2a954e903317ef56abbcfe2470a2dfd23 
> 
> Diff: https://reviews.apache.org/r/41656/diff/
> 
> 
> Testing
> ---
> 
> mesos website docker.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>



Re: Review Request 41658: Track the allocation candidates to bound the allocation queue.

2015-12-22 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41658/#review111675
---


Patch looks great!

Reviews applied: [41658]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 22, 2015, 7:56 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41658/
> ---
> 
> (Updated Dec. 22, 2015, 7:56 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Klaus Ma.
> 
> 
> Bugs: MESOS-3157
> https://issues.apache.org/jira/browse/MESOS-3157
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When there is churn in the cluster, frequent resource allocation
> is required.  Maintain a set of allocation candidates so that we
> don't end up running the same allocation multiple times.
> 
> This review is just for feedback. Not proposing it to be berged at this time.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 86ea5a402ed67f8f22f11d5730147cd907d66a08 
>   src/master/allocator/mesos/hierarchical.cpp 
> 775182515dcb52bd873ecdf98c827320251a59c8 
> 
> Diff: https://reviews.apache.org/r/41658/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> James Peach
> 
>



Re: Review Request 41661: Added documentation for API versioning.

2015-12-22 Thread Anand Mazumdar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41661/
---

(Updated Dec. 22, 2015, 10:57 p.m.)


Review request for mesos, Neil Conway and Vinod Kone.


Changes
---

Review comments


Bugs: MESOS-4192
https://issues.apache.org/jira/browse/MESOS-4192


Repository: mesos


Description
---

This change adds documentation on how Mesos does API versioning. It also has a 
section:
- On how API versioning and Release versioning are different.
- API compatibility/upgrade guarantees.
- Implementation Details.

Most of the information is taken from the design doc on Mesos HTTP API 
Versioning:
https://docs.google.com/document/d/1-iQjo6778H_fU_1Zi_Yk6szg8qj-wqYgVgnx7u3h6OU/edit#


Diffs (updated)
-

  docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 
  docs/versioning.md PRE-CREATION 

Diff: https://reviews.apache.org/r/41661/diff/


Testing
---

https://gist.github.com/hatred/1cc6db05d0ca51397886


Thanks,

Anand Mazumdar



Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

2015-12-22 Thread Avinash sridharan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/
---

(Updated Dec. 23, 2015, 2:10 a.m.)


Review request for mesos, Adam B and Anand Mazumdar.


Repository: mesos


Description
---

Added unit test cases to test the new vip and instance_port fields


Diffs (updated)
-

  src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464 
  src/tests/slave_tests.cpp 90d56b987c60b99d9ca3e4ffef9cb71815bfc9b7 

Diff: https://reviews.apache.org/r/41381/diff/


Testing
---

make check


Thanks,

Avinash sridharan



Re: Review Request 41661: Added documentation for API versioning.

2015-12-22 Thread Anand Mazumdar


> On Dec. 22, 2015, 11:55 p.m., Guangya Liu wrote:
> > docs/versioning.md, line 36
> > 
> >
> > Not clear for what does " It would be really hard to debug an error 
> > that happens with Scheduler v2 API, Executor v4 API interacting with Mesos 
> > cluster running Internal v6 API and Operator v7 API." mean? I think that 
> > even with API versioning, this problem is still difficult to debug, how can 
> > the API version help this issue?
> 
> Anand Mazumdar wrote:
> We have a single API version across all components in Mesos. So you won't 
> ever run into the version explosion problem i.e. you have different 
> components running on different versions.
> 
> If any of the components have a backward compatible change it would 
> result in a version upgrade for all the components. Does this help clear 
> things ?
> 
> Guangya Liu wrote:
> Yes, I know what you mean, but the sentense here to me is more like to 
> be: With API versioning, I can make the Scheduler v2 API, Executor v4 API 
> interacting with Mesos cluster running Internal v6 API and Operator v7 API be 
> easy to debug. what do you say?  ;-)
> 
> What about refine the sentense as this: 
> * **Avoiding version explosion**: It would be really hard to debug an 
> error that happens with Scheduler v2 API, Executor v4 API interacting with 
> Mesos cluster running Internal v6 API and Operator v7 API. By putting all the 
> APIs under one version, we avoid the version explosion problem.

Fixed.


- Anand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41661/#review111689
---


On Dec. 22, 2015, 10:57 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41661/
> ---
> 
> (Updated Dec. 22, 2015, 10:57 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4192
> https://issues.apache.org/jira/browse/MESOS-4192
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds documentation on how Mesos does API versioning. It also has 
> a section:
> - On how API versioning and Release versioning are different.
> - API compatibility/upgrade guarantees.
> - Implementation Details.
> 
> Most of the information is taken from the design doc on Mesos HTTP API 
> Versioning:
> https://docs.google.com/document/d/1-iQjo6778H_fU_1Zi_Yk6szg8qj-wqYgVgnx7u3h6OU/edit#
> 
> 
> Diffs
> -
> 
>   docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 
>   docs/versioning.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41661/diff/
> 
> 
> Testing
> ---
> 
> https://gist.github.com/hatred/1cc6db05d0ca51397886
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-22 Thread Avinash sridharan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41380/
---

(Updated Dec. 23, 2015, 2:09 a.m.)


Review request for mesos, Adam B and Anand Mazumdar.


Bugs: MESOS-4114
https://issues.apache.org/jira/browse/MESOS-4114


Repository: mesos


Description
---

Added repeated vip field to DiscoveryInfo and an instance_port field to Port


Diffs (updated)
-

  include/mesos/mesos.proto 2431fdd6b84625c6140a2b3913736bffada4e7f6 
  include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8 

Diff: https://reviews.apache.org/r/41380/diff/


Testing
---

make check, and make


Thanks,

Avinash sridharan



Re: Review Request 41661: Added documentation for API versioning.

2015-12-22 Thread Anand Mazumdar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41661/
---

(Updated Dec. 23, 2015, 2:09 a.m.)


Review request for mesos, Neil Conway and Vinod Kone.


Changes
---

Review comments


Bugs: MESOS-4192
https://issues.apache.org/jira/browse/MESOS-4192


Repository: mesos


Description
---

This change adds documentation on how Mesos does API versioning. It also has a 
section:
- On how API versioning and Release versioning are different.
- API compatibility/upgrade guarantees.
- Implementation Details.

Most of the information is taken from the design doc on Mesos HTTP API 
Versioning:
https://docs.google.com/document/d/1-iQjo6778H_fU_1Zi_Yk6szg8qj-wqYgVgnx7u3h6OU/edit#


Diffs (updated)
-

  docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 
  docs/versioning.md PRE-CREATION 

Diff: https://reviews.apache.org/r/41661/diff/


Testing
---

https://gist.github.com/hatred/1cc6db05d0ca51397886


Thanks,

Anand Mazumdar



Re: Review Request 41661: Added documentation for API versioning.

2015-12-22 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41661/#review111715
---


Patch looks great!

Reviews applied: [41661]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 23, 2015, 2:09 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41661/
> ---
> 
> (Updated Dec. 23, 2015, 2:09 a.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4192
> https://issues.apache.org/jira/browse/MESOS-4192
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds documentation on how Mesos does API versioning. It also has 
> a section:
> - On how API versioning and Release versioning are different.
> - API compatibility/upgrade guarantees.
> - Implementation Details.
> 
> Most of the information is taken from the design doc on Mesos HTTP API 
> Versioning:
> https://docs.google.com/document/d/1-iQjo6778H_fU_1Zi_Yk6szg8qj-wqYgVgnx7u3h6OU/edit#
> 
> 
> Diffs
> -
> 
>   docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 
>   docs/versioning.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41661/diff/
> 
> 
> Testing
> ---
> 
> https://gist.github.com/hatred/1cc6db05d0ca51397886
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

2015-12-22 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/#review111718
---


Bad review!

Reviews applied: []

Error:
 No reviewers specified. Please find a reviewer by asking on JIRA or the 
mailing list.

- Mesos ReviewBot


On Dec. 23, 2015, 2:10 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41381/
> ---
> 
> (Updated Dec. 23, 2015, 2:10 a.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added unit test cases to test the new vip and instance_port fields
> 
> 
> Diffs
> -
> 
>   src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464 
>   src/tests/slave_tests.cpp 90d56b987c60b99d9ca3e4ffef9cb71815bfc9b7 
> 
> Diff: https://reviews.apache.org/r/41381/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>



Re: Review Request 41661: Added documentation for API versioning.

2015-12-22 Thread Anand Mazumdar


> On Dec. 22, 2015, 11:55 p.m., Guangya Liu wrote:
> > docs/versioning.md, line 22
> > 
> >
> > Not yours, but can you please add the following to "Terminology" 
> > section?
> > 
> > Scheduler API
> > Executor API
> > Internal API
> > Operator API
> > 
> > I did not get any explanation for those APIs except from a slides 
> > shared by @vinod in Seattle conference 
> > http://www.slideshare.net/mesosphere/mesos-http-api

I don't think the versioning document should cater to such trivial details. The 
Mesos Scheduler API is already linked from the Mesos homepage. The Executor API 
should be up there soon along with others ?

Also, this is what the description for them would look like:

Scheduler API: API for schedulers to interact with Mesos.
Executor API: API for executors to interact with Mesos.
Operator API: API for operators to interact with Mesos.
Internal API: API for internal communication between Mesos Master and Agent.

^^ Isn't this self-explantory ?


> On Dec. 22, 2015, 11:55 p.m., Guangya Liu wrote:
> > docs/versioning.md, line 36
> > 
> >
> > Not clear for what does " It would be really hard to debug an error 
> > that happens with Scheduler v2 API, Executor v4 API interacting with Mesos 
> > cluster running Internal v6 API and Operator v7 API." mean? I think that 
> > even with API versioning, this problem is still difficult to debug, how can 
> > the API version help this issue?

We have a single API version across all components in Mesos. So you won't ever 
run into the version explosion problem i.e. you have different components 
running on different versions.

If any of the components have a backward compatible change it would result in a 
version upgrade for all the components. Does this help clear things ?


- Anand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41661/#review111689
---


On Dec. 22, 2015, 10:57 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41661/
> ---
> 
> (Updated Dec. 22, 2015, 10:57 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4192
> https://issues.apache.org/jira/browse/MESOS-4192
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds documentation on how Mesos does API versioning. It also has 
> a section:
> - On how API versioning and Release versioning are different.
> - API compatibility/upgrade guarantees.
> - Implementation Details.
> 
> Most of the information is taken from the design doc on Mesos HTTP API 
> Versioning:
> https://docs.google.com/document/d/1-iQjo6778H_fU_1Zi_Yk6szg8qj-wqYgVgnx7u3h6OU/edit#
> 
> 
> Diffs
> -
> 
>   docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 
>   docs/versioning.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41661/diff/
> 
> 
> Testing
> ---
> 
> https://gist.github.com/hatred/1cc6db05d0ca51397886
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Re: Review Request 41661: Added documentation for API versioning.

2015-12-22 Thread Guangya Liu


> On 十二月 22, 2015, 11:55 p.m., Guangya Liu wrote:
> > docs/versioning.md, line 22
> > 
> >
> > Not yours, but can you please add the following to "Terminology" 
> > section?
> > 
> > Scheduler API
> > Executor API
> > Internal API
> > Operator API
> > 
> > I did not get any explanation for those APIs except from a slides 
> > shared by @vinod in Seattle conference 
> > http://www.slideshare.net/mesosphere/mesos-http-api
> 
> Anand Mazumdar wrote:
> I don't think the versioning document should cater to such trivial 
> details. The Mesos Scheduler API is already linked from the Mesos homepage. 
> The Executor API should be up there soon along with others ?
> 
> Also, this is what the description for them would look like:
> 
> Scheduler API: API for schedulers to interact with Mesos.
> Executor API: API for executors to interact with Mesos.
> Operator API: API for operators to interact with Mesos.
> Internal API: API for internal communication between Mesos Master and 
> Agent.
> 
> ^^ Isn't this self-explantory ?

Fair enough, thanks.


> On 十二月 22, 2015, 11:55 p.m., Guangya Liu wrote:
> > docs/versioning.md, line 36
> > 
> >
> > Not clear for what does " It would be really hard to debug an error 
> > that happens with Scheduler v2 API, Executor v4 API interacting with Mesos 
> > cluster running Internal v6 API and Operator v7 API." mean? I think that 
> > even with API versioning, this problem is still difficult to debug, how can 
> > the API version help this issue?
> 
> Anand Mazumdar wrote:
> We have a single API version across all components in Mesos. So you won't 
> ever run into the version explosion problem i.e. you have different 
> components running on different versions.
> 
> If any of the components have a backward compatible change it would 
> result in a version upgrade for all the components. Does this help clear 
> things ?

Yes, I know what you mean, but the sentense here to me is more like to be: With 
API versioning, I can make the Scheduler v2 API, Executor v4 API interacting 
with Mesos cluster running Internal v6 API and Operator v7 API be easy to 
debug. what do you say?  ;-)

What about refine the sentense as this: 
* **Avoiding version explosion**: It would be really hard to debug an error 
that happens with Scheduler v2 API, Executor v4 API interacting with Mesos 
cluster running Internal v6 API and Operator v7 API. By putting all the APIs 
under one version, we avoid the version explosion problem.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41661/#review111689
---


On 十二月 22, 2015, 10:57 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41661/
> ---
> 
> (Updated 十二月 22, 2015, 10:57 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4192
> https://issues.apache.org/jira/browse/MESOS-4192
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds documentation on how Mesos does API versioning. It also has 
> a section:
> - On how API versioning and Release versioning are different.
> - API compatibility/upgrade guarantees.
> - Implementation Details.
> 
> Most of the information is taken from the design doc on Mesos HTTP API 
> Versioning:
> https://docs.google.com/document/d/1-iQjo6778H_fU_1Zi_Yk6szg8qj-wqYgVgnx7u3h6OU/edit#
> 
> 
> Diffs
> -
> 
>   docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 
>   docs/versioning.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41661/diff/
> 
> 
> Testing
> ---
> 
> https://gist.github.com/hatred/1cc6db05d0ca51397886
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2015-12-22 Thread Alex Clemmer


> On Dec. 12, 2015, 8:09 p.m., Joris Van Remoortere wrote:
> > Let's get some Windows team reviews on this.
> > let's try and use snake_case in stout.

Wasn't sure where you wanted me to use snake_case, so those changes aren't 
reflected in iteration 8.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/#review110101
---


On Dec. 23, 2015, 2:12 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39019/
> ---
> 
> (Updated Dec. 23, 2015, 2:12 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added dirent compat code for non-Unix systems.
> 
> 
> Diffs
> -
> 
>   
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> d46e262e0fd1c2de36f3bf19d8bd693c23bf58cd 
> 
> Diff: https://reviews.apache.org/r/39019/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2015-12-22 Thread Alex Clemmer


> On Dec. 12, 2015, 8:09 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp,
> >  lines 198-200
> > 
> >
> > Where does the internal data for DIR get freed?

Oh god. How embarrassing. In my defense, I have no idea what I'm doing. I have 
written maybe 30 lines of "real C", ever. I feel bad about this. :(


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/#review110101
---


On Dec. 23, 2015, 2:12 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39019/
> ---
> 
> (Updated Dec. 23, 2015, 2:12 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added dirent compat code for non-Unix systems.
> 
> 
> Diffs
> -
> 
>   
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> d46e262e0fd1c2de36f3bf19d8bd693c23bf58cd 
> 
> Diff: https://reviews.apache.org/r/39019/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2015-12-22 Thread Alex Clemmer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/
---

(Updated Dec. 23, 2015, 2:12 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Bugs: MESOS-3441
https://issues.apache.org/jira/browse/MESOS-3441


Repository: mesos


Description
---

Windows: Added dirent compat code for non-Unix systems.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
d46e262e0fd1c2de36f3bf19d8bd693c23bf58cd 

Diff: https://reviews.apache.org/r/39019/diff/


Testing
---

`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.


Thanks,

Alex Clemmer



Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2015-12-22 Thread Alex Clemmer


> On Dec. 15, 2015, 4:24 a.m., Alex Naparu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp,
> >  line 79
> > 
> >
> > Consider using a smart pointer instead. Same below.

I would love to use a smart pointer, but unfortunately, the goal here is to 
make a drop-in replacement for the POSIX `dirent` API, which is in raw C.


> On Dec. 15, 2015, 4:24 a.m., Alex Naparu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp,
> >  line 215
> > 
> >
> > This is copied here, but malloc'd elsewhere. Is that safe?

I'm no C expert by any stretch of the imagination, but I believe this is safe. 
The reason is, we're actually not `malloc`'ing that array at all, we're 
`strcpy`'ing a path into a stack-allocated array of `MAX_PATH` in length. 
According to [1], this includes null terminator, so I think this is ok to do.

[1] 
https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx


> On Dec. 15, 2015, 4:24 a.m., Alex Naparu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp,
> >  line 230
> > 
> >
> > Consider using safe versions of string functions

I'm not an expert in C or Windows, but looking at this, it seems like we can't 
use `strncpy` or `strcpy_s` for the potentially-insecure call to `strcpy` in 
`opendir` (since we don't know the length of `path` ahead of time), and for the 
calls to `strcpy` that we can use these functions, it's not helpful, because 
they are `strcpy`'ing stuff from Windows API calls like `FindNextFile`, which 
should be outputting something sensible anyway.

So, it seems like this is probably not worth changing? What do you think?


> On Dec. 15, 2015, 4:24 a.m., Alex Naparu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp, line 74
> > 
> >
> > Might want to add this as a reference too: 
> > https://msdn.microsoft.com/en-us/library/930f87yf.aspx
> > 
> > MAX_PATH is horribly obsolete, we might want to consider checking 
> > whether we're running on NTFS for all FS-related ops. That will be true in 
> > the vast majority of cases these days.

I actually expect that we will probably mostly never run on FAT at all, but I 
wasn't super well versed in how to get the Windows API to not use the FAT 
limitations, so we went with mostly FAT-limited APIs, because they seemed 
simpler. That said, I'm not an expert at either Windows or C++, so maybe this 
was all just naive.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/#review110392
---


On Nov. 17, 2015, 7:06 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39019/
> ---
> 
> (Updated Nov. 17, 2015, 7:06 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added dirent compat code for non-Unix systems.
> 
> 
> Diffs
> -
> 
>   
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> 1a7037d64afeedc340258c92067e95d1d3caa027 
> 
> Diff: https://reviews.apache.org/r/39019/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 41665: Tests: Use 'in_memory' registry by default for tests.

2015-12-22 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41665/#review111697
---


Patch looks great!

Reviews applied: [41665]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 22, 2015, 10:45 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41665/
> ---
> 
> (Updated Dec. 22, 2015, 10:45 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Artem Harutyunyan, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-1757
> https://issues.apache.org/jira/browse/MESOS-1757
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This speeds up running the tests by ~13%.
> It can have a much larger impact when running specific test suites
> using 'gtest_repeat'.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 865fa4a71f4bae2a218cd2c4e10873222d1ea3c4 
>   src/tests/mesos.cpp 11ca0519ad0dad44328b6ebdf52c5356fda818b7 
> 
> Diff: https://reviews.apache.org/r/41665/diff/
> 
> 
> Testing
> ---
> 
> With patch:
> ```
> Command being timed: "./bin/mesos-tests.sh"
> User time (seconds): 42.76
> System time (seconds): 10.21
> Percent of CPU this job got: 7%
> Elapsed (wall clock) time (h:mm:ss or m:ss): 11:15.21
> ```
> before:
> ```
> Command being timed: "./bin/mesos-tests.sh"
> User time (seconds): 52.58
> System time (seconds): 11.78
> Percent of CPU this job got: 8%
> Elapsed (wall clock) time (h:mm:ss or m:ss): 12:48.42
> ```
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>



Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

2015-12-22 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/#review111703
---


Bad review!

Reviews applied: []

Error:
 No reviewers specified. Please find a reviewer by asking on JIRA or the 
mailing list.

- Mesos ReviewBot


On Dec. 22, 2015, 11:48 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41381/
> ---
> 
> (Updated Dec. 22, 2015, 11:48 p.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added unit test cases to test the new vip and instance_port fields
> 
> 
> Diffs
> -
> 
>   src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464 
>   src/tests/slave_tests.cpp 90d56b987c60b99d9ca3e4ffef9cb71815bfc9b7 
> 
> Diff: https://reviews.apache.org/r/41381/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>



Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-22 Thread Avinash sridharan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41380/
---

(Updated Dec. 23, 2015, 2:05 a.m.)


Review request for mesos, Adam B and Anand Mazumdar.


Bugs: MESOS-4114
https://issues.apache.org/jira/browse/MESOS-4114


Repository: mesos


Description
---

Added repeated vip field to DiscoveryInfo and an instance_port field to Port


Diffs
-

  include/mesos/mesos.proto 2431fdd6b84625c6140a2b3913736bffada4e7f6 
  include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8 

Diff: https://reviews.apache.org/r/41380/diff/


Testing
---

make check, and make


Thanks,

Avinash sridharan



Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-22 Thread Avinash sridharan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41380/
---

(Updated Dec. 23, 2015, 3 a.m.)


Review request for mesos, Adam B and Anand Mazumdar.


Bugs: MESOS-4114
https://issues.apache.org/jira/browse/MESOS-4114


Repository: mesos


Description
---

Added repeated vip field to DiscoveryInfo and an instance_port field to Port


Diffs
-

  include/mesos/mesos.proto 2431fdd6b84625c6140a2b3913736bffada4e7f6 
  include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8 

Diff: https://reviews.apache.org/r/41380/diff/


Testing
---

make check, and make


Thanks,

Avinash sridharan



Re: Review Request 41593: stout: Added `jsonify` function.

2015-12-22 Thread Michael Park


> On Dec. 22, 2015, 4:52 a.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, line 167
> > 
> >
> > Is the `int32_t`, `uint32_t`, and `float` overloads necessary?

With only overloads for `int64_t`, `uint64_t`, `double`, passing `0` for 
example is ambiguous between `int64_t` and `uint64_t`.


> On Dec. 22, 2015, 4:52 a.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, line 624
> > 
> >
> > Since this is in the `internal` namespace, can we 
> > s/jsonify_impl/jsonify/ please?

We sure could. I initially had it named `jsonify` and had it returning `Proxy`, 
but when I changed it to `std::function`, I thought `jsonify_impl` would be a 
better name for it.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41593/#review111575
---


On Dec. 22, 2015, 8:23 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41593/
> ---
> 
> (Updated Dec. 22, 2015, 8:23 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/README.md 
> a2a3dc6120b10c8fe82088b9f0ebecfa5642f945 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
>   3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41593/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>



Re: Review Request 41111: Logger Module: Add test for default executor/task stdout/stderr logging behavior (to sandbox).

2015-12-22 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4/
---

(Updated Dec. 22, 2015, 1:09 p.m.)


Review request for mesos, Benjamin Hindman and Artem Harutyunyan.


Changes
---

Rebase.


Bugs: MESOS-4087
https://issues.apache.org/jira/browse/MESOS-4087


Repository: mesos


Description
---

`ContainerLoggerTest.DefaultToSandbox` is a regression test which checks the 
existing logging behavior, prior to introducing/using the `ContainerLogger` 
module.  As of this patch, the `ContainerLogger` is not actually being tested.


Diffs (updated)
-

  src/Makefile.am cf7f950c0c320a6c8e956409a35a7f47d905f71d 
  src/tests/container_logger_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/4/diff/


Testing
---

make check


Thanks,

Joseph Wu



Re: Review Request 41424: Install picojson.h if we are using the bundled version.

2015-12-22 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41424/#review111661
---

Ship it!


Verified this does not break a clean build.

- Joseph Wu


On Dec. 22, 2015, 12:44 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41424/
> ---
> 
> (Updated Dec. 22, 2015, 12:44 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Alex Clemmer, Joris 
> Van Remoortere, Joseph Wu, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3909
> https://issues.apache.org/jira/browse/MESOS-3909
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Stout JSON API depends on picojson.h, so we need to install it
> to be able to build Mesos modules outside the Mesos source tree.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> 04d0fa324bf6eab98a51fc08298b9da2992d29d1 
> 
> Diff: https://reviews.apache.org/r/41424/diff/
> 
> 
> Testing
> ---
> 
> Build an external module that implicitly depends on picojson.h
> 
> 
> Thanks,
> 
> James Peach
> 
>



Re: Review Request 41661: Added documentation for API versioning.

2015-12-22 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41661/#review111679
---



docs/versioning.md (line 11)


it is better use /roles instead of not /roles.json cause it will be 
deprecated.

https://github.com/apache/mesos/blob/master/src/master/master.cpp#L792-L799



docs/versioning.md (line 64)


s/an/a



docs/versioning.md (line 79)


s/scheduler" ./scheduler".



docs/versioning.md (lines 91 - 94)


Shall we unify the time to month? e.g. 24 weeks -> 6months
4 weeks-> 1 month



docs/versioning.md (line 94)


s/atleast/at least


- Guangya Liu


On 十二月 22, 2015, 9:43 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41661/
> ---
> 
> (Updated 十二月 22, 2015, 9:43 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4192
> https://issues.apache.org/jira/browse/MESOS-4192
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds documentation on how Mesos does API versioning. It also has 
> a section:
> - On how API versioning and Release versioning are different.
> - API compatibility/upgrade guarantees.
> - Implementation Details.
> 
> Most of the information is taken from the design doc on Mesos HTTP API 
> Versioning:
> https://docs.google.com/document/d/1-iQjo6778H_fU_1Zi_Yk6szg8qj-wqYgVgnx7u3h6OU/edit#
> 
> 
> Diffs
> -
> 
>   docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 
>   docs/versioning.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41661/diff/
> 
> 
> Testing
> ---
> 
> https://gist.github.com/hatred/1cc6db05d0ca51397886
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Review Request 41665: Tests: Use 'in_memory' registry by default for tests.

2015-12-22 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41665/
---

Review request for mesos, Alexander Rukletsov, Ben Mahler, Artem Harutyunyan, 
and Joseph Wu.


Bugs: MESOS-1757
https://issues.apache.org/jira/browse/MESOS-1757


Repository: mesos


Description
---

This speeds up running the tests by ~13%.
It can have a much larger impact when running specific test suites
using 'gtest_repeat'.


Diffs
-

  src/tests/master_tests.cpp 865fa4a71f4bae2a218cd2c4e10873222d1ea3c4 
  src/tests/mesos.cpp 11ca0519ad0dad44328b6ebdf52c5356fda818b7 

Diff: https://reviews.apache.org/r/41665/diff/


Testing
---

With patch:
```
Command being timed: "./bin/mesos-tests.sh"
User time (seconds): 42.76
System time (seconds): 10.21
Percent of CPU this job got: 7%
Elapsed (wall clock) time (h:mm:ss or m:ss): 11:15.21
```
before:
```
Command being timed: "./bin/mesos-tests.sh"
User time (seconds): 52.58
System time (seconds): 11.78
Percent of CPU this job got: 8%
Elapsed (wall clock) time (h:mm:ss or m:ss): 12:48.42
```


Thanks,

Joris Van Remoortere



Re: Review Request 41665: Tests: Use 'in_memory' registry by default for tests.

2015-12-22 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41665/#review111684
---


By changing the default registry to "in_memory", you also have to change (and 
you do) the `registry_strict` flag to `false`. I believe this may impact some 
tests. Obviously it does, since you explicitly fall back to strict 
"replicated_log" in some tests. My questions are:
  - When is it fine to use a non-strict registry and when not?
  - How did you figure out the tests that require a strict registry?
I think it will be great if you can leave such comment in the review 
description.

- Alexander Rukletsov


On Dec. 22, 2015, 10:45 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41665/
> ---
> 
> (Updated Dec. 22, 2015, 10:45 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Artem Harutyunyan, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-1757
> https://issues.apache.org/jira/browse/MESOS-1757
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This speeds up running the tests by ~13%.
> It can have a much larger impact when running specific test suites
> using 'gtest_repeat'.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 865fa4a71f4bae2a218cd2c4e10873222d1ea3c4 
>   src/tests/mesos.cpp 11ca0519ad0dad44328b6ebdf52c5356fda818b7 
> 
> Diff: https://reviews.apache.org/r/41665/diff/
> 
> 
> Testing
> ---
> 
> With patch:
> ```
> Command being timed: "./bin/mesos-tests.sh"
> User time (seconds): 42.76
> System time (seconds): 10.21
> Percent of CPU this job got: 7%
> Elapsed (wall clock) time (h:mm:ss or m:ss): 11:15.21
> ```
> before:
> ```
> Command being timed: "./bin/mesos-tests.sh"
> User time (seconds): 52.58
> System time (seconds): 11.78
> Percent of CPU this job got: 8%
> Elapsed (wall clock) time (h:mm:ss or m:ss): 12:48.42
> ```
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>



Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

2015-12-22 Thread Avinash sridharan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/
---

(Updated Dec. 22, 2015, 11:48 p.m.)


Review request for mesos, Adam B and Anand Mazumdar.


Repository: mesos


Description
---

Added unit test cases to test the new vip and instance_port fields


Diffs (updated)
-

  src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464 
  src/tests/slave_tests.cpp 90d56b987c60b99d9ca3e4ffef9cb71815bfc9b7 

Diff: https://reviews.apache.org/r/41381/diff/


Testing
---

make check


Thanks,

Avinash sridharan



Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-22 Thread Avinash sridharan


> On Dec. 19, 2015, 10:01 a.m., Adam B wrote:
> > include/mesos/mesos.proto, lines 1576-1577
> > 
> >
> > Do we expect to add more fields to the Vip message later?
> > If not, why don't we just add a `repeated string vips` to DiscoveryInfo?
> > If so, what do you think we'd add? Maybe a service name, in case the 
> > same task has multiple services exposed on different vips?
> 
> Anand Mazumdar wrote:
> hmm ... Since a VIP is just a virtual IP address. Why not use the 
> existing `Address` message and just add the following to `DiscoveryInfo`:
> 
> `repeated Address vips;`
> 
> Avinash sridharan wrote:
> This is the Address message :message Address {
>   // May contain a hostname, IP address, or both.
>   optional string hostname = 1;
>   optional string ip = 2;
> 
>   required int32 port = 3;
> }
> 
> The problem with using this is that port is a required field in the 
> Address type (a bit odd). In case of virtual IP's they need to be explicitly 
> IP and port is mapping that is provided separately (message Port). So don't 
> think will make sense to use it in this context ?
> 
> Avinash sridharan wrote:
> I am just thinking that given this is a virtual endpoint there might be 
> other metadata (labels is what comes to mind right now) that might be 
> associated with this in the future.  Similar to the message Port. As you 
> pointed out named Vips is another option.

Have added a new message type IPAddress which is in the top-level namespace. 
Also, after talking to Anand have kept the enums in the IPAddress field as 
protocol, since renaming the field will cause another set of churn that is 
better to avoid at this stage.


- Avinash


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41380/#review111369
---


On Dec. 22, 2015, 10:03 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41380/
> ---
> 
> (Updated Dec. 22, 2015, 10:03 p.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Bugs: MESOS-4114
> https://issues.apache.org/jira/browse/MESOS-4114
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added repeated vip field to DiscoveryInfo and an instance_port field to Port
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 2431fdd6b84625c6140a2b3913736bffada4e7f6 
>   include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8 
> 
> Diff: https://reviews.apache.org/r/41380/diff/
> 
> 
> Testing
> ---
> 
> make check, and make
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>



Re: Review Request 41656: Renamed containerizer.md to mesos-containerizer.md.

2015-12-22 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41656/#review111674
---


I found that all of the links in home.md does not work, take "Getting Started" 
as example, it will redirect to 
https://github.com/apache/mesos/blob/master/documentation/latest/getting-started
 and report 404 error.

- Guangya Liu


On 十二月 22, 2015, 10:11 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41656/
> ---
> 
> (Updated 十二月 22, 2015, 10:11 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The change reflects the content of the documentation. A separate document that
>   describes containerizer from a user perspective will be created.
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md  
>   docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 
>   docs/mesos-provisioner.md fdb298c2a954e903317ef56abbcfe2470a2dfd23 
> 
> Diff: https://reviews.apache.org/r/41656/diff/
> 
> 
> Testing
> ---
> 
> mesos website docker.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>



Re: Review Request 41657: Added user facing documentation for containerizers.

2015-12-22 Thread Jojy Varghese


> On Dec. 22, 2015, 9:42 p.m., Joseph Wu wrote:
> > docs/containerizer.md, line 53
> > 
> >
> > Maybe: s/OSX/POSIX/

If we have to say linux, then I would think we should use an operating system 
like osx/bsd. posix is an API standard.


- Jojy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41657/#review111665
---


On Dec. 22, 2015, 7:35 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41657/
> ---
> 
> (Updated Dec. 22, 2015, 7:35 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This documentation is intended for users trying to get an overview of
> containerizer technology. It also provides the criteria for selecting a
> particular type of containerizer.
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md PRE-CREATION 
>   docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 
> 
> Diff: https://reviews.apache.org/r/41657/diff/
> 
> 
> Testing
> ---
> 
> mesos website docker.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>



Re: Review Request 41656: Renamed containerizer.md to mesos-containerizer.md.

2015-12-22 Thread Guangya Liu


> On 十二月 22, 2015, 10:24 p.m., Guangya Liu wrote:
> > I found that all of the links in home.md does not work, take "Getting 
> > Started" as example, it will redirect to 
> > https://github.com/apache/mesos/blob/master/documentation/latest/getting-started
> >  and report 404 error.
> 
> Joerg Schad wrote:
> I guess that is the difference in creating links between github and the 
> published website. http://mesos.apache.org/documentation/latest/ works fine 
> for me.

I see, but it might be a problem if someone wants to start the document from 
github cause the github will redirect end user to 
https://github.com/apache/mesos/blob/master/documentation/latest/ which will be 
failed by 404. Shall we clarify that the end user need to go to 
http://mesos.apache.org/documentation/latest/ im home.md?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41656/#review111674
---


On 十二月 22, 2015, 10:11 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41656/
> ---
> 
> (Updated 十二月 22, 2015, 10:11 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The change reflects the content of the documentation. A separate document that
>   describes containerizer from a user perspective will be created.
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md  
>   docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 
>   docs/mesos-provisioner.md fdb298c2a954e903317ef56abbcfe2470a2dfd23 
> 
> Diff: https://reviews.apache.org/r/41656/diff/
> 
> 
> Testing
> ---
> 
> mesos website docker.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>



Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-22 Thread Avinash sridharan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41380/
---

(Updated Dec. 22, 2015, 11:47 p.m.)


Review request for mesos, Adam B and Anand Mazumdar.


Bugs: MESOS-4114
https://issues.apache.org/jira/browse/MESOS-4114


Repository: mesos


Description
---

Added repeated vip field to DiscoveryInfo and an instance_port field to Port


Diffs (updated)
-

  include/mesos/mesos.proto 2431fdd6b84625c6140a2b3913736bffada4e7f6 
  include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8 

Diff: https://reviews.apache.org/r/41380/diff/


Testing
---

make check, and make


Thanks,

Avinash sridharan



Re: Review Request 41656: Renamed containerizer.md to mesos-containerizer.md.

2015-12-22 Thread Jojy Varghese

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41656/
---

(Updated Dec. 22, 2015, 10:11 p.m.)


Review request for mesos, Jie Yu and Joerg Schad.


Changes
---

review addressed.


Repository: mesos


Description
---

The change reflects the content of the documentation. A separate document that
  describes containerizer from a user perspective will be created.


Diffs (updated)
-

  docs/containerizer.md  
  docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 
  docs/mesos-provisioner.md fdb298c2a954e903317ef56abbcfe2470a2dfd23 

Diff: https://reviews.apache.org/r/41656/diff/


Testing
---

mesos website docker.


Thanks,

Jojy Varghese



Re: Review Request 41656: Renamed containerizer.md to mesos-containerizer.md.

2015-12-22 Thread Joerg Schad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41656/#review111680
---

Ship it!



docs/mesos-provisioner.md (line 112)


Not yours, but didn't we want to remove such fully specified links to 
github?


- Joerg Schad


On Dec. 22, 2015, 10:11 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41656/
> ---
> 
> (Updated Dec. 22, 2015, 10:11 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The change reflects the content of the documentation. A separate document that
>   describes containerizer from a user perspective will be created.
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md  
>   docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 
>   docs/mesos-provisioner.md fdb298c2a954e903317ef56abbcfe2470a2dfd23 
> 
> Diff: https://reviews.apache.org/r/41656/diff/
> 
> 
> Testing
> ---
> 
> mesos website docker.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>



Re: Review Request 41657: Added user facing documentation for containerizers.

2015-12-22 Thread Jojy Varghese

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41657/
---

(Updated Dec. 22, 2015, 10:27 p.m.)


Review request for mesos, Jie Yu and Joerg Schad.


Changes
---

review addressed.


Repository: mesos


Description
---

This documentation is intended for users trying to get an overview of
containerizer technology. It also provides the criteria for selecting a
particular type of containerizer.


Diffs (updated)
-

  docs/containerizer.md PRE-CREATION 
  docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 

Diff: https://reviews.apache.org/r/41657/diff/


Testing
---

mesos website docker.


Thanks,

Jojy Varghese



Re: Review Request 41514: Accepted a single JSON object for quota set request.

2015-12-22 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41514/#review111638
---

Ship it!



src/master/quota_handler.cpp (lines 332 - 334)


Have you considered making this static?
What about building it up from the true and false components so that you 
can use the true component below. Something along these lines:
```
const static hashset trueValues({"true", "yes", "t", "y"});
const static hashset falseValues({"false", "no", "f", "n"});
const static hashset allowedForceValues = trueValues + falseValues;
```
and
```
const bool forced = (force.isSome() && trueValues.contains(forceValue));
```

Please note the indentation is off the L334 in the current diff.


- Joris Van Remoortere


On Dec. 22, 2015, 6:09 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41514/
> ---
> 
> (Updated Dec. 22, 2015, 6:09 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Bernd Mathiske, Joerg Schad, and 
> Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3960
> https://issues.apache.org/jira/browse/MESOS-3960
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> POST request to "/quota" requires a single JSON object as opposed to
> key-value pairs encoded in a string.
> 
> 
> Diffs
> -
> 
>   src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 
>   src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1 
>   src/tests/role_tests.cpp 2c5f68ccaac7e9a37345e2f331d1bc35cae77736 
> 
> Diff: https://reviews.apache.org/r/41514/diff/
> 
> 
> Testing
> ---
> 
> make check on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 41514: Accepted a single JSON object for quota set request.

2015-12-22 Thread Joris Van Remoortere


> On Dec. 22, 2015, 7:48 p.m., Joris Van Remoortere wrote:
> > src/master/quota_handler.cpp, lines 357-359
> > 
> >
> > Have you considered making this static?
> > What about building it up from the true and false components so that 
> > you can use the true component below. Something along these lines:
> > ```
> > const static hashset trueValues({"true", "yes", "t", "y"});
> > const static hashset falseValues({"false", "no", "f", "n"});
> > const static hashset allowedForceValues = trueValues + 
> > falseValues;
> > ```
> > and
> > ```
> > const bool forced = (force.isSome() && trueValues.contains(forceValue));
> > ```
> > 
> > Please note the indentation is off the L334 in the current diff.

Review has already been updated to use JSON::Boolean.


- Joris


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41514/#review111638
---


On Dec. 22, 2015, 6:09 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41514/
> ---
> 
> (Updated Dec. 22, 2015, 6:09 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Bernd Mathiske, Joerg Schad, and 
> Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3960
> https://issues.apache.org/jira/browse/MESOS-3960
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> POST request to "/quota" requires a single JSON object as opposed to
> key-value pairs encoded in a string.
> 
> 
> Diffs
> -
> 
>   src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 
>   src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1 
>   src/tests/role_tests.cpp 2c5f68ccaac7e9a37345e2f331d1bc35cae77736 
> 
> Diff: https://reviews.apache.org/r/41514/diff/
> 
> 
> Testing
> ---
> 
> make check on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 41593: stout: Added `jsonify` function.

2015-12-22 Thread Michael Park

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41593/
---

(Updated Dec. 22, 2015, 8:43 p.m.)


Review request for mesos and Benjamin Hindman.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/README.md 
a2a3dc6120b10c8fe82088b9f0ebecfa5642f945 
  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
  3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41593/diff/


Testing
---


Thanks,

Michael Park



Re: Review Request 41661: Added documentation for API versioning.

2015-12-22 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41661/#review111689
---



docs/versioning.md (line 20)


1) work or works?
2) s/work ?/work?



docs/versioning.md (line 22)


Not yours, but can you please add the following to "Terminology" section?

Scheduler API
Executor API
Internal API
Operator API

I did not get any explanation for those APIs except from a slides shared by 
@vinod in Seattle conference http://www.slideshare.net/mesosphere/mesos-http-api



docs/versioning.md (line 36)


Not clear for what does " It would be really hard to debug an error that 
happens with Scheduler v2 API, Executor v4 API interacting with Mesos cluster 
running Internal v6 API and Operator v7 API." mean? I think that even with API 
versioning, this problem is still difficult to debug, how can the API version 
help this issue?


- Guangya Liu


On 十二月 22, 2015, 10:57 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41661/
> ---
> 
> (Updated 十二月 22, 2015, 10:57 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4192
> https://issues.apache.org/jira/browse/MESOS-4192
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds documentation on how Mesos does API versioning. It also has 
> a section:
> - On how API versioning and Release versioning are different.
> - API compatibility/upgrade guarantees.
> - Implementation Details.
> 
> Most of the information is taken from the design doc on Mesos HTTP API 
> Versioning:
> https://docs.google.com/document/d/1-iQjo6778H_fU_1Zi_Yk6szg8qj-wqYgVgnx7u3h6OU/edit#
> 
> 
> Diffs
> -
> 
>   docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 
>   docs/versioning.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41661/diff/
> 
> 
> Testing
> ---
> 
> https://gist.github.com/hatred/1cc6db05d0ca51397886
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Re: Review Request 41509: [libprocess] Cleaned up STL I/O includes.

2015-12-22 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41509/
---

(Updated Dec. 22, 2015, 5:53 p.m.)


Review request for mesos, Benjamin Bannier, Joris Van Remoortere, and Michael 
Park.


Changes
---

Wrapped description.


Bugs: MESOS-4183
https://issues.apache.org/jira/browse/MESOS-4183


Repository: mesos


Description (updated)
---

Where possible move operator<< definitions and functions using streams
to ".cpp" files and include  in ".hpp"s. Also remove unused
I/O includes and clean up std:: prefixes.


Diffs
-

  3rdparty/libprocess/include/process/address.hpp 
79429e904546ebeb993663efb9bd9e212c1dbd63 
  3rdparty/libprocess/include/process/future.hpp 
817fca2ba5352a2c1cea1cb6cf6ecc49821215e4 
  3rdparty/libprocess/include/process/http.hpp 
f0666f0fa48c4f3a98332d12066561a02a715236 
  3rdparty/libprocess/include/process/pid.hpp 
b22c160ad0051ea1dac733a39a9f833719dbcb58 
  3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969 
  3rdparty/libprocess/src/pid.cpp 1a9cbd1eec6aefbd9a40113ae0f4475a90011b85 

Diff: https://reviews.apache.org/r/41509/diff/


Testing
---

make check on Mac OS 10.10.4.


Thanks,

Alexander Rukletsov



Re: Review Request 41511: Cleaned up STL I/O includes in public header (including v1).

2015-12-22 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41511/
---

(Updated Dec. 22, 2015, 5:55 p.m.)


Review request for mesos, Benjamin Bannier, Joris Van Remoortere, and Michael 
Park.


Changes
---

Wrapped description.


Bugs: MESOS-4183
https://issues.apache.org/jira/browse/MESOS-4183


Repository: mesos


Description (updated)
---

Where possible move operator<< definitions and functions using streams
to ".cpp" files and include  in ".hpp"s. Also remove unused I/O
includes, add necessary includes, clean up `std::` prefixes and blank
lines.


Diffs
-

  include/mesos/resources.hpp 9c8bfb0e7e1e40ca99b4cc75079e5b950630243d 
  include/mesos/type_utils.hpp b370b5180e71ed246fa09bf0fe119dfa946d0b08 
  include/mesos/v1/mesos.hpp 80e76040de77e65b20f10b0465124ab86c1feab6 
  include/mesos/v1/resources.hpp db87c992e2ec466cb1d4d17775bf6423a2fb15aa 
  include/mesos/v1/values.hpp a160bd4d49d53fd2f794f36fea69ea99a455af09 
  include/mesos/values.hpp 58af972186d7156660eac742b41501ce420cefe9 
  src/common/resources.cpp b9d31aef8babee212374e352c57fadbff02167f3 
  src/common/type_utils.cpp c6c9ba7d1bfc6e6202b9e3ff94a74711e3602d6f 
  src/v1/mesos.cpp 13a58baf086ef3aaf46abcf7f58b71b7e2639728 
  src/v1/resources.cpp 0c0eee6b3b7ae3254d7dc7b06187855c9b873764 

Diff: https://reviews.apache.org/r/41511/diff/


Testing
---

make check on Mac OS 10.10.4.


Thanks,

Alexander Rukletsov



Re: Review Request 41512: Cleaned up STL I/O includes in public headers which are not part of v1.

2015-12-22 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41512/
---

(Updated Dec. 22, 2015, 5:56 p.m.)


Review request for mesos, Benjamin Bannier, Joris Van Remoortere, and Michael 
Park.


Changes
---

Rebased & wrapped description.


Bugs: MESOS-4183
https://issues.apache.org/jira/browse/MESOS-4183


Repository: mesos


Description (updated)
---

Where possible move `operator<<` definitions and functions using streams
to ".cpp" files and include  in ".hpp"s. Also remove unused I/O
includes, add necessary includes, clean up `std::` prefixes.


Diffs (updated)
-

  include/mesos/authorizer/authorizer.hpp 
19f6e1a2d025bf6ff07f515b10d41e8a48d7d0b4 
  include/mesos/http.hpp 8529ed0bf5b0954a223af5f7025fcd0d54c7348d 
  include/mesos/uri/uri.hpp aa3ab5d24bb8c501dd19e93d7563cb0afd889f23 
  src/authorizer/authorizer.cpp 31712e511cdaac3f6d137f425d5cd430434544aa 
  src/common/http.cpp 2ecb78c582325c3e5141a9946516d6c9e8d7106f 

Diff: https://reviews.apache.org/r/41512/diff/


Testing
---

make check on Mac OS 10.10.4.


Thanks,

Alexander Rukletsov



Re: Review Request 41513: Cleaned up STL I/O includes.

2015-12-22 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41513/
---

(Updated Dec. 22, 2015, 5:59 p.m.)


Review request for mesos, Benjamin Bannier, Joris Van Remoortere, and Michael 
Park.


Changes
---

Rebased & wrapped description.


Bugs: MESOS-4183
https://issues.apache.org/jira/browse/MESOS-4183


Repository: mesos


Description (updated)
---

Move `operator<<` definitions to ".cpp" files and include ``
in ".hpp"s.


Diffs (updated)
-

  src/linux/perf.cpp 8ee9f381c3587bb2fa0f309a477035340bc44e15 
  src/linux/routing/filter/ip.hpp 1a63dcca2badc041e73fe454a9994b82695117de 
  src/linux/routing/filter/ip.cpp 158bab6cb95fe10b8dc41b22934a946b21ff88ed 
  src/linux/routing/handle.hpp 5b03be5e70ad3910487a1867fa4fa0d8de25d11e 
  src/linux/routing/handle.cpp e88c6eb7336ac31683a6ff394a139f6777576a3e 
  src/messages/messages.hpp 350118399927a8d7185d87a6a8e3370b7158fe14 
  src/messages/messages.cpp 30f55bb8ee5a57ff9517144ffc43d45df6b3de5b 

Diff: https://reviews.apache.org/r/41513/diff/


Testing
---

make check on Mac OS 10.10.4.


Thanks,

Alexander Rukletsov



Re: Review Request 41514: Accepted a single JSON object for quota set request.

2015-12-22 Thread Alexander Rukletsov


> On Dec. 22, 2015, 5:47 p.m., Anand Mazumdar wrote:
> > src/master/quota_handler.cpp, line 30
> > 
> >
> > Remove this. This must have crept in due to handling multiple `force` 
> > field values ?

You're right and that's embarrassing. Thanks a lot for catching this!


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41514/#review111624
---


On Dec. 22, 2015, 11:02 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41514/
> ---
> 
> (Updated Dec. 22, 2015, 11:02 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Bernd Mathiske, Joerg Schad, and 
> Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3960
> https://issues.apache.org/jira/browse/MESOS-3960
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> POST request to "/quota" requires a single JSON object as opposed to 
> key-value pairs encoded in a string.
> 
> 
> Diffs
> -
> 
>   src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 
>   src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1 
>   src/tests/role_tests.cpp 2c5f68ccaac7e9a37345e2f331d1bc35cae77736 
> 
> Diff: https://reviews.apache.org/r/41514/diff/
> 
> 
> Testing
> ---
> 
> make check on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 41515: Refactored error messages to reduce jaggedness.

2015-12-22 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41515/
---

(Updated Dec. 22, 2015, 6:08 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
and Neil Conway.


Changes
---

Rebased.


Bugs: MESOS-3960
https://issues.apache.org/jira/browse/MESOS-3960


Repository: mesos


Description
---

Includes minor updates to wording and punctuation.


Diffs (updated)
-

  src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 

Diff: https://reviews.apache.org/r/41515/diff/


Testing
---

make check on Mac OS 10.10.4


Thanks,

Alexander Rukletsov



Re: Review Request 41603: Cleaned up quota HTTP handling code and tests.

2015-12-22 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41603/
---

(Updated Dec. 22, 2015, 6:08 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.


Changes
---

Added ab include.


Bugs: MESOS-3960
https://issues.apache.org/jira/browse/MESOS-3960


Repository: mesos


Description
---

Define a variable earlier in the handler for clarity; add consts; add
and re-order using directive where appropriate.


Diffs (updated)
-

  src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 
  src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1 

Diff: https://reviews.apache.org/r/41603/diff/


Testing
---

make check on Mac OS 10.10.4


Thanks,

Alexander Rukletsov



Re: Review Request 41514: Accepted a single JSON object for quota set request.

2015-12-22 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41514/
---

(Updated Dec. 22, 2015, 6:09 p.m.)


Review request for mesos, Anand Mazumdar, Bernd Mathiske, Joerg Schad, and 
Joris Van Remoortere.


Changes
---

Removed an unnecessary include; moved adding a necessaru include to a follow-up 
cleanup patch.


Bugs: MESOS-3960
https://issues.apache.org/jira/browse/MESOS-3960


Repository: mesos


Description (updated)
---

POST request to "/quota" requires a single JSON object as opposed to
key-value pairs encoded in a string.


Diffs (updated)
-

  src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 
  src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1 
  src/tests/role_tests.cpp 2c5f68ccaac7e9a37345e2f331d1bc35cae77736 

Diff: https://reviews.apache.org/r/41514/diff/


Testing
---

make check on Mac OS 10.10.4


Thanks,

Alexander Rukletsov



Review Request 41661: Added documentation for API versioning.

2015-12-22 Thread Anand Mazumdar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41661/
---

Review request for mesos, Neil Conway and Vinod Kone.


Bugs: MESOS-4192
https://issues.apache.org/jira/browse/MESOS-4192


Repository: mesos


Description
---

This change adds documentation on how Mesos does API versioning. It also has a 
section:
- On how API versioning and Release versioning are different.
- API compatibility/upgrade guarantees.
- Implementation Details.

Most of the information is taken from the design doc on Mesos HTTP API 
Versioning:
https://docs.google.com/document/d/1-iQjo6778H_fU_1Zi_Yk6szg8qj-wqYgVgnx7u3h6OU/edit#


Diffs
-

  docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 
  docs/versioning.md PRE-CREATION 

Diff: https://reviews.apache.org/r/41661/diff/


Testing
---

https://gist.github.com/hatred/1cc6db05d0ca51397886


Thanks,

Anand Mazumdar



Re: Review Request 41657: Added user facing documentation for containerizers.

2015-12-22 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41657/#review111688
---


Patch looks great!

Reviews applied: [41656, 41657]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 22, 2015, 10:27 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41657/
> ---
> 
> (Updated Dec. 22, 2015, 10:27 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This documentation is intended for users trying to get an overview of
> containerizer technology. It also provides the criteria for selecting a
> particular type of containerizer.
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md PRE-CREATION 
>   docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 
> 
> Diff: https://reviews.apache.org/r/41657/diff/
> 
> 
> Testing
> ---
> 
> mesos website docker.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>



Re: Review Request 41661: Added documentation for API versioning.

2015-12-22 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41661/#review111719
---



docs/versioning.md (line 30)


s/URL ?/URL?

Sorry, I should post this in previous patch.


- Guangya Liu


On 十二月 23, 2015, 2:09 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41661/
> ---
> 
> (Updated 十二月 23, 2015, 2:09 a.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4192
> https://issues.apache.org/jira/browse/MESOS-4192
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds documentation on how Mesos does API versioning. It also has 
> a section:
> - On how API versioning and Release versioning are different.
> - API compatibility/upgrade guarantees.
> - Implementation Details.
> 
> Most of the information is taken from the design doc on Mesos HTTP API 
> Versioning:
> https://docs.google.com/document/d/1-iQjo6778H_fU_1Zi_Yk6szg8qj-wqYgVgnx7u3h6OU/edit#
> 
> 
> Diffs
> -
> 
>   docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 
>   docs/versioning.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41661/diff/
> 
> 
> Testing
> ---
> 
> https://gist.github.com/hatred/1cc6db05d0ca51397886
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2015-12-22 Thread Daniel Pravat

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/#review111717
---



3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp 
(line 1)


Does it have to be in makefile.am? Or this is used only on Windows, which 
is CMake at this time.



3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp 
(line 104)


Can you check the semnatic of opendir() function? I'm under the imression 
that the first file is found after a susequential readdir() call. Is the intent 
to change the behaviour on Windows?


- Daniel Pravat


On Dec. 23, 2015, 2:15 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39019/
> ---
> 
> (Updated Dec. 23, 2015, 2:15 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added dirent compat code for non-Unix systems.
> 
> 
> Diffs
> -
> 
>   
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> d46e262e0fd1c2de36f3bf19d8bd693c23bf58cd 
> 
> Diff: https://reviews.apache.org/r/39019/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2015-12-22 Thread Alex Clemmer


> On Dec. 23, 2015, 5:28 a.m., Daniel Pravat wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp,
> >  line 104
> > 
> >
> > Can you check the semnatic of opendir() function? I'm under the 
> > imression that the first file is found after a susequential readdir() call. 
> > Is the intent to change the behaviour on Windows?
> 
> Alex Clemmer wrote:
> I believe this implementation is correct. The POSIX specification[1] 
> says: "The directory stream is positioned at the first entry." Do you read 
> this differently?
> 
> [1] http://pubs.opengroup.org/onlinepubs/009695399/functions/opendir.html

I'm going to close this issue, but feel free to open it again if you think I'm 
missing something.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/#review111717
---


On Dec. 23, 2015, 6:44 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39019/
> ---
> 
> (Updated Dec. 23, 2015, 6:44 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added dirent compat code for non-Unix systems.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
>   
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> d46e262e0fd1c2de36f3bf19d8bd693c23bf58cd 
> 
> Diff: https://reviews.apache.org/r/39019/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Review Request 41672: Test case(s) for weights + allocation behavior

2015-12-22 Thread Yongqiao Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41672/
---

Review request for mesos, Adam B and Neil Conway.


Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200


Repository: mesos


Description
---

Test case(s) for weights + allocation behavior


Diffs
-

  src/tests/hierarchical_allocator_tests.cpp 
88bb7e987c471587d46e15082fe1149fd94db5d6 

Diff: https://reviews.apache.org/r/41672/diff/


Testing
---


Thanks,

Yongqiao Wang



Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-22 Thread Yongqiao Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41597/
---

(Updated Dec. 23, 2015, 5:46 a.m.)


Review request for mesos, Adam B, Neil Conway, and Qian Zhang.


Bugs: MESOS-3943
https://issues.apache.org/jira/browse/MESOS-3943


Repository: mesos


Description
---

Add the interface in allocator to support updating weight
at runtime, and the allocator is invoked to allocate the
resources based on the updated weights later.


Diffs (updated)
-

  include/mesos/master/allocator.hpp f7ada68d7111486d264284990996413bb3d6 
  src/master/allocator/mesos/allocator.hpp 
50ef3b20f34bc6d87cbeccabcebec9a5031a6554 
  src/master/allocator/mesos/hierarchical.hpp 
86ea5a402ed67f8f22f11d5730147cd907d66a08 
  src/master/allocator/mesos/hierarchical.cpp 
775182515dcb52bd873ecdf98c827320251a59c8 
  src/master/allocator/sorter/drf/sorter.hpp 
050896e8b12cd4097ccd137d5284d6b39b0f06ab 
  src/master/allocator/sorter/drf/sorter.cpp 
3a442f121f3a1505513877a5c78458a4b8d0a824 
  src/master/allocator/sorter/sorter.hpp 
7be6b44a762fd62c2cd7f28b4dc4865a4587ed26 
  src/tests/allocator.hpp 9bdfaecf1a148f113ad52956b50ed7cabe0902ef 

Diff: https://reviews.apache.org/r/41597/diff/


Testing (updated)
---

Make & Make check successfully!

Test case: https://reviews.apache.org/r/41672/


Thanks,

Yongqiao Wang



Review Request 41673: Windows: Forked signal handling in `signalhandler.hpp`.

2015-12-22 Thread Daniel Pravat

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41673/
---

Review request for mesos.


Repository: mesos


Description
---

Windows: Forked signal handling in `signalhandler.hpp`.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
a25e2c1e5584e744c666bbc654eafbfc5f7b10e6 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signalhandler.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/signalhandler.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/signalhandler.hpp 
PRE-CREATION 

Diff: https://reviews.apache.org/r/41673/diff/


Testing
---

OSX: make check
Windows: build


Thanks,

Daniel Pravat



Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride

2015-12-22 Thread Jian Qiu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41600/
---

Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-4161
https://issues.apache.org/jira/browse/MESOS-4161


Repository: mesos


Description
---

To speed up SlaveTest.CommandExecutorWithOverride, we need to explicitly kill 
the executor process and advance reap interval.


Diffs
-

  src/tests/slave_tests.cpp 90d56b987c60b99d9ca3e4ffef9cb71815bfc9b7 

Diff: https://reviews.apache.org/r/41600/diff/


Testing
---

make check -j4 GTEST_FILTER=SlaveTest.CommandExecutorWithOverride takes 415ms

[==] Running 1 test from 1 test case.
[--] Global test environment set-up.
[--] 1 test from SlaveTest
[ RUN  ] SlaveTest.CommandExecutorWithOverride
[   OK ] SlaveTest.CommandExecutorWithOverride (405 ms)
[--] 1 test from SlaveTest (405 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (415 ms total)
[  PASSED  ] 1 test.


Thanks,

Jian Qiu



Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2015-12-22 Thread Alex Clemmer


> On Dec. 23, 2015, 5:28 a.m., Daniel Pravat wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp,
> >  line 1
> > 
> >
> > Does it have to be in makefile.am? Or this is used only on Windows, 
> > which is CMake at this time.

Good catch! You're right, we should put it there (because we include things 
like `Windows.hpp`), but you're also right that it doesn't _need_ to be there, 
because someone on a Unix would never need to update their build if this file 
was altered.


> On Dec. 23, 2015, 5:28 a.m., Daniel Pravat wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp,
> >  line 104
> > 
> >
> > Can you check the semnatic of opendir() function? I'm under the 
> > imression that the first file is found after a susequential readdir() call. 
> > Is the intent to change the behaviour on Windows?

I believe this implementation is correct. The POSIX specification[1] says: "The 
directory stream is positioned at the first entry." Do you read this 
differently?

[1] http://pubs.opengroup.org/onlinepubs/009695399/functions/opendir.html


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/#review111717
---


On Dec. 23, 2015, 2:15 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39019/
> ---
> 
> (Updated Dec. 23, 2015, 2:15 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added dirent compat code for non-Unix systems.
> 
> 
> Diffs
> -
> 
>   
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> d46e262e0fd1c2de36f3bf19d8bd693c23bf58cd 
> 
> Diff: https://reviews.apache.org/r/39019/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride

2015-12-22 Thread Jian Qiu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41600/
---

(Updated 十二月 23, 2015, 6:43 a.m.)


Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-4161
https://issues.apache.org/jira/browse/MESOS-4161


Repository: mesos


Description
---

To speed up SlaveTest.CommandExecutorWithOverride, we need to explicitly kill 
the executor process and advance reap interval.


Diffs
-

  src/tests/slave_tests.cpp 90d56b987c60b99d9ca3e4ffef9cb71815bfc9b7 

Diff: https://reviews.apache.org/r/41600/diff/


Testing
---

make check -j4 GTEST_FILTER=SlaveTest.CommandExecutorWithOverride takes 415ms

[==] Running 1 test from 1 test case.
[--] Global test environment set-up.
[--] 1 test from SlaveTest
[ RUN  ] SlaveTest.CommandExecutorWithOverride
[   OK ] SlaveTest.CommandExecutorWithOverride (405 ms)
[--] 1 test from SlaveTest (405 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (415 ms total)
[  PASSED  ] 1 test.


Thanks,

Jian Qiu



Re: Review Request 41593: stout: Added `jsonify` function.

2015-12-22 Thread Michael Park

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41593/
---

(Updated Dec. 23, 2015, 3:56 a.m.)


Review request for mesos and Benjamin Hindman.


Changes
---

Removed the use of macros in the `json` definition for 
`google::protobuf::Message`.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/README.md 
a2a3dc6120b10c8fe82088b9f0ebecfa5642f945 
  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
  3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41593/diff/


Testing
---


Thanks,

Michael Park



Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2015-12-22 Thread Alex Naparu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/#review111725
---

Ship it!


Ship It!

- Alex Naparu


On Dec. 23, 2015, 2:15 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39019/
> ---
> 
> (Updated Dec. 23, 2015, 2:15 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added dirent compat code for non-Unix systems.
> 
> 
> Diffs
> -
> 
>   
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> d46e262e0fd1c2de36f3bf19d8bd693c23bf58cd 
> 
> Diff: https://reviews.apache.org/r/39019/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 41672: Test case(s) for weights + allocation behavior

2015-12-22 Thread Yongqiao Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41672/
---

(Updated Dec. 23, 2015, 5:49 a.m.)


Review request for mesos, Adam B and Neil Conway.


Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200


Repository: mesos


Description
---

Test case(s) for weights + allocation behavior


Diffs
-

  src/tests/hierarchical_allocator_tests.cpp 
88bb7e987c471587d46e15082fe1149fd94db5d6 

Diff: https://reviews.apache.org/r/41672/diff/


Testing (updated)
---

Make check done:
Yongs-MacBook-Pro:build yqwyq$ ./src/mesos-tests 
--gtest_filter=HierarchicalAllocatorTest.UpdateWeight
Source directory: /Users/yqwyq/Desktop/mesos
Build directory: /Users/yqwyq/Desktop/mesos/build
[==] Running 1 test from 1 test case.
[--] Global test environment set-up.
[--] 1 test from HierarchicalAllocatorTest
[ RUN  ] HierarchicalAllocatorTest.UpdateWeight
[   OK ] HierarchicalAllocatorTest.UpdateWeight (257 ms)
[--] 1 test from HierarchicalAllocatorTest (257 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (340 ms total)
[  PASSED  ] 1 test.


Thanks,

Yongqiao Wang



Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2015-12-22 Thread Alex Clemmer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/
---

(Updated Dec. 23, 2015, 6:44 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, and Joseph Wu.


Bugs: MESOS-3441
https://issues.apache.org/jira/browse/MESOS-3441


Repository: mesos


Description
---

Windows: Added dirent compat code for non-Unix systems.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
  3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
d46e262e0fd1c2de36f3bf19d8bd693c23bf58cd 

Diff: https://reviews.apache.org/r/39019/diff/


Testing
---

`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.


Thanks,

Alex Clemmer



Re: Review Request 39492: Added status endpoint for quota master endpoint.

2015-12-22 Thread Joerg Schad


> On Dec. 21, 2015, 10:22 p.m., Guangya Liu wrote:
> > I assume that you will have another RR to cover the unit test, right?

Yes, just updated the description (as we removed the dependency and there is no 
next review anymore). Thanks!


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review111547
---


On Dec. 22, 2015, 8:38 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> ---
> 
> (Updated Dec. 22, 2015, 8:38 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-4013
> https://issues.apache.org/jira/browse/MESOS-4013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added status handling for quota master endpoint.
> 
> 
> Diffs
> -
> 
>   include/mesos/quota/quota.proto 03e816dcd4dead8326731ac221df7354c0610fed 
>   src/master/master.hpp 8af82a0bbc2038e18180136c82cbaeeacc7b3526 
>   src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 
> 
> Diff: https://reviews.apache.org/r/39492/diff/
> 
> 
> Testing
> ---
> 
> Tests are in Review 39614.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>



Re: Review Request 41613: Added `defaultRole` constant to persistent volume tests.

2015-12-22 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41613/#review111589
---

Ship it!



src/tests/persistent_volume_tests.cpp (line 68)


Usually, we capitalize constants, so how about `DEFAULT_ROLE`?



src/tests/persistent_volume_tests.cpp (lines 682 - 684)


I always find increasing line numbers unfortunate : ). What do you think 
about the following formatting:
```
  Resources taskResources = Resources::parse(
  "cpus:1;mem:128;disk(" + defaultRole + "):32").get() + volume;
```


- Alexander Rukletsov


On Dec. 21, 2015, 7:12 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41613/
> ---
> 
> (Updated Dec. 21, 2015, 7:12 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `defaultRole` constant to persistent volume tests.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> 2fb57814b2805bc76981d1877603a1a033f29289 
> 
> Diff: https://reviews.apache.org/r/41613/diff/
> 
> 
> Testing
> ---
> 
> `GTEST_FILTER="PersistentVolumeTest*" bin/mesos-tests.sh`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 39492: Added status endpoint for quota master endpoint.

2015-12-22 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review111596
---

Ship it!


Ship It!

- Guangya Liu


On 十二月 22, 2015, 9:40 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> ---
> 
> (Updated 十二月 22, 2015, 9:40 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-4013
> https://issues.apache.org/jira/browse/MESOS-4013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added status handling for quota master endpoint.
> 
> 
> Diffs
> -
> 
>   include/mesos/quota/quota.proto 03e816dcd4dead8326731ac221df7354c0610fed 
>   src/master/master.hpp 8af82a0bbc2038e18180136c82cbaeeacc7b3526 
>   src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 
> 
> Diff: https://reviews.apache.org/r/39492/diff/
> 
> 
> Testing
> ---
> 
> Tests are in Review 39614.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>



Re: Review Request 41514: Accepted a single JSON object for quota set request.

2015-12-22 Thread Alexander Rukletsov


> On Dec. 18, 2015, 12:04 a.m., Anand Mazumdar wrote:
> > src/master/quota_handler.cpp, line 353
> > 
> >
> > hmmm .. Should we return a `BadRequest` for all other non-allowed 
> > values of `force` other then `true` or `false` ?
> 
> Alexander Rukletsov wrote:
> I was thinking about the [Postel's 
> law](https://en.wikipedia.org/wiki/Robustness_principle), but maybe you are 
> right and we should not interpret "force:t", "force:1", "force:god-damn-yes" 
> as `false`, I'll fix that.
> 
> Anand Mazumdar wrote:
> I was wondering if we should accept only `true/false` as valid values. 
> Currently the `/scheduler` endpoint also specifies a semantically similar 
> field `force` in `Call::Subscribe` message that just takes these 2 possible 
> values. Should we strive for consistency across all the endpoints and reject 
> all other values ?
> 
> Alexander Rukletsov wrote:
> I agree consistency is important, thanks for spotting this. I'll update 
> the review shortly.

The best solution here is to use `JSON::Boolean` I think.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41514/#review111086
---


On Dec. 21, 2015, 1:27 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41514/
> ---
> 
> (Updated Dec. 21, 2015, 1:27 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Bernd Mathiske, Joerg Schad, and 
> Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3960
> https://issues.apache.org/jira/browse/MESOS-3960
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> POST request to "/quota" requires a single JSON object as opposed to 
> key-value pairs encoded in a string.
> 
> 
> Diffs
> -
> 
>   src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 
>   src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1 
>   src/tests/role_tests.cpp 2c5f68ccaac7e9a37345e2f331d1bc35cae77736 
> 
> Diff: https://reviews.apache.org/r/41514/diff/
> 
> 
> Testing
> ---
> 
> make check on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 41515: Refactored error messages to reduce jaggedness.

2015-12-22 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41515/
---

(Updated Dec. 22, 2015, 11:02 a.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
and Neil Conway.


Changes
---

Rebased.


Bugs: MESOS-3960
https://issues.apache.org/jira/browse/MESOS-3960


Repository: mesos


Description
---

Includes minor updates to wording and punctuation.


Diffs (updated)
-

  src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 

Diff: https://reviews.apache.org/r/41515/diff/


Testing
---

make check on Mac OS 10.10.4


Thanks,

Alexander Rukletsov



Re: Review Request 41603: Cleaned up quota HTTP handling code and tests.

2015-12-22 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41603/
---

(Updated Dec. 22, 2015, 11:01 a.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.


Changes
---

Rebased.


Bugs: MESOS-3960
https://issues.apache.org/jira/browse/MESOS-3960


Repository: mesos


Description
---

Define a variable earlier in the handler for clarity; add consts and
using directive where appropriate.


Diffs (updated)
-

  src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 
  src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1 

Diff: https://reviews.apache.org/r/41603/diff/


Testing
---

make check on Mac OS 10.10.4


Thanks,

Alexander Rukletsov



Re: Review Request 41603: Cleaned up quota HTTP handling code and tests.

2015-12-22 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41603/
---

(Updated Dec. 22, 2015, 11:16 a.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.


Changes
---

Re-order includes.


Bugs: MESOS-3960
https://issues.apache.org/jira/browse/MESOS-3960


Repository: mesos


Description (updated)
---

Define a variable earlier in the handler for clarity; add consts; add
and re-order using directive where appropriate.


Diffs (updated)
-

  src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 
  src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1 

Diff: https://reviews.apache.org/r/41603/diff/


Testing
---

make check on Mac OS 10.10.4


Thanks,

Alexander Rukletsov



Re: Review Request 41514: Accepted a single JSON object for quota set request.

2015-12-22 Thread Alexander Rukletsov


> On Dec. 18, 2015, 12:04 a.m., Anand Mazumdar wrote:
> > src/master/quota_handler.cpp, line 353
> > 
> >
> > hmmm .. Should we return a `BadRequest` for all other non-allowed 
> > values of `force` other then `true` or `false` ?
> 
> Alexander Rukletsov wrote:
> I was thinking about the [Postel's 
> law](https://en.wikipedia.org/wiki/Robustness_principle), but maybe you are 
> right and we should not interpret "force:t", "force:1", "force:god-damn-yes" 
> as `false`, I'll fix that.
> 
> Anand Mazumdar wrote:
> I was wondering if we should accept only `true/false` as valid values. 
> Currently the `/scheduler` endpoint also specifies a semantically similar 
> field `force` in `Call::Subscribe` message that just takes these 2 possible 
> values. Should we strive for consistency across all the endpoints and reject 
> all other values ?

I agree consistency is important, thanks for spotting this. I'll update the 
review shortly.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41514/#review111086
---


On Dec. 21, 2015, 1:27 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41514/
> ---
> 
> (Updated Dec. 21, 2015, 1:27 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Bernd Mathiske, Joerg Schad, and 
> Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3960
> https://issues.apache.org/jira/browse/MESOS-3960
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> POST request to "/quota" requires a single JSON object as opposed to 
> key-value pairs encoded in a string.
> 
> 
> Diffs
> -
> 
>   src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 
>   src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1 
>   src/tests/role_tests.cpp 2c5f68ccaac7e9a37345e2f331d1bc35cae77736 
> 
> Diff: https://reviews.apache.org/r/41514/diff/
> 
> 
> Testing
> ---
> 
> make check on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 39614: Quota: Added Status Validation Tests.

2015-12-22 Thread Joerg Schad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39614/
---

(Updated Dec. 22, 2015, 10:19 a.m.)


Review request for mesos, Alexander Rukletsov and Bernd Mathiske.


Changes
---

Adressed comments


Bugs: MESOS-4218
https://issues.apache.org/jira/browse/MESOS-4218


Repository: mesos


Description
---

Quota: Added Status Validation Tests.


Diffs (updated)
-

  src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1 

Diff: https://reviews.apache.org/r/39614/diff/


Testing
---

make check


Thanks,

Joerg Schad



Re: Review Request 41618: Edited defer documentation in libprocess.

2015-12-22 Thread Alexander Rojas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41618/#review111592
---


Hey Gregg, Thanks for working on this, I really think this needs documentation. 
However, I think we are going great lengths to explain relatively simple 
concepts. I also feel that tying so much the concept of a `defer` to a future 
limits the capabilities of defer.

I feel the best way to explain these concepts goes like this:

# Dispatch

`dispatch` schedules a method for asynchronous execution. It creates an event 
which is added at the back of the process event queue and will be executed once 
it reaches the front.

# Defer

Creates a [callable object](http://en.cppreference.com/w/cpp/concept/Callable) 
of type `Deferred` which will execute a `dispatch` 
operation once it gets invoked.  Example:

```c++
using namespace process;

class CountProcess : public Process
{
public:
  CountProcess() : counter_(0) {}
  
  void increase() { ++counter_; }
  
private:
  unsinged int counter_;
};

int main(int argc, cha** argv)
{
  CountProcess counter;
  spawn(counter);
  
  Deferred deferred = defer(counter, ::increase);
  
  for (int i = 0; i < 10; ++i) {
deferred();
  }
  
  // This code is equivalent to the one above:
  for (int i = 0; i < 10; ++i) {
dispatch(counter, ::increase);
  }
  
  terminate(counter);
  wait(counter);

  return 0;
}
```

I allows a lot of flexibility over a dispatch, since a `Deferred` object may 
never be invoked, it could be invoked multiple times or it could be invoked in 
a completely different execution context. Example:

```c++
// In log.cpp
using namespace process;

class LogProcess : public Process
{
public:
  LogProcess(const std::string& filePath) : logfile_(filePath) {}
  ~LogProcess() { logfile_.flush(); logfile.close(); }
  
  void log(const std::string& message) { logfile_ << message << '\n'; }
  
private:
  std:::ofstream logfile_;
};

LogProcess *logProcess;

void initLog(const std::string& filePath) 
{
  logProcess = new LogProcess(filePath);
  spawn(logProcess);
}

void terminateLog()
{
  terminate(logProcess);
  delete logProcess;
}

Deferred getLogger()
{
  return defer(logProcess, ::log);
}


// in log.hpp
void initLog(const std::string& filePath);
void terminateLogger();
Deferred getLogger();

// in main.cpp

#include 

// SomeOtherClass::SomeOtherClass(std::function 
logger);

int main(int argc, cha** argv)
{
  initLog("/var/log/test.log");
  
  Deferred logger = getLogger();
  logger("Starting app");
  
  // SomeOtherClass has no idea of what logger
  // is or even an idea of processes.
  SomeOtherClass(logger);

  terminateLog();
  return 0;
}
```

Its power really comes by when mixed with promises and futures, since it allows 
to attach a `dispatch` only when a future transitions, example:

```c++
using namespace process;

void foo()
{
  ProcessBase process;
  spawn(process);

  std::thread::id mainThreadId = std::this_thread::get_id();

  Deferred deferred = defer(
  process,
  [mainThreadId](int i) {
// Invoked _asynchronously_ using `process` as the
// execution context.
assert(mainThreadId != std::this_thread::get_id());
  });

  Promise promise;

  promise.future().then(deferred);

  promise.future().then([mainThreadId](int i) {
// Invoked synchronously from the execution context of
// the thread that completes the future!
assert(mainThreadId == std::this_thread::get_id());
  });

  // Executes both callbacks synchronously, which _dispatches_
  // the deferred lambda to run asynchronously in the execution
  // context of `process` but invokes the other lambda immediately.
  promise.set(42);

  terminate(process);
}
```


3rdparty/libprocess/README.md (lines 113 - 114)





- Alexander Rojas


On Dec. 22, 2015, 1 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41618/
> ---
> 
> (Updated Dec. 22, 2015, 1 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Edited defer documentation in libprocess.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/README.md 6a47f6772bb7a74af368ed970af0f1c154a070e3 
> 
> Diff: https://reviews.apache.org/r/41618/diff/
> 
> 
> Testing
> ---
> 
> Viewed on github: 
> https://github.com/mesosphere/mesos/tree/defer_doc_update/3rdparty/libprocess
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 40293: Applied consistent number style in c++ styleguide.

2015-12-22 Thread Joerg Schad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40293/
---

(Updated Dec. 22, 2015, 10:36 a.m.)


Review request for mesos and Bernd Mathiske.


Changes
---

Rebased


Repository: mesos


Description (updated)
---

Applied consistent number style in c++ styleguide. This is trying to make the 
file consistent without introducing an addition rule to the documentation 
styleguide.


Diffs (updated)
-

  docs/c++-style-guide.md 7f5e51948616036378b8993134ba6df09dad5d88 

Diff: https://reviews.apache.org/r/40293/diff/


Testing
---

viewed rendered version.


Thanks,

Joerg Schad



Re: Review Request 41514: Accepted a single JSON object for quota set request.

2015-12-22 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41514/
---

(Updated Dec. 22, 2015, 11:02 a.m.)


Review request for mesos, Anand Mazumdar, Bernd Mathiske, Joerg Schad, and 
Joris Van Remoortere.


Changes
---

Used `JSON::Boolean` for the `force` field.


Bugs: MESOS-3960
https://issues.apache.org/jira/browse/MESOS-3960


Repository: mesos


Description
---

POST request to "/quota" requires a single JSON object as opposed to key-value 
pairs encoded in a string.


Diffs (updated)
-

  src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 
  src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1 
  src/tests/role_tests.cpp 2c5f68ccaac7e9a37345e2f331d1bc35cae77736 

Diff: https://reviews.apache.org/r/41514/diff/


Testing
---

make check on Mac OS 10.10.4


Thanks,

Alexander Rukletsov



Re: Review Request 39614: Quota: Added Status Validation Tests.

2015-12-22 Thread Joerg Schad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39614/
---

(Updated Dec. 22, 2015, 9:40 a.m.)


Review request for mesos, Alexander Rukletsov and Bernd Mathiske.


Bugs: MESOS-4218
https://issues.apache.org/jira/browse/MESOS-4218


Repository: mesos


Description
---

Quota: Added Status Validation Tests.


Diffs
-

  src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1 

Diff: https://reviews.apache.org/r/39614/diff/


Testing
---

make check


Thanks,

Joerg Schad



Re: Review Request 39492: Added status endpoint for quota master endpoint.

2015-12-22 Thread Joerg Schad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/
---

(Updated Dec. 22, 2015, 9:40 a.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
Remoortere.


Bugs: MESOS-4013
https://issues.apache.org/jira/browse/MESOS-4013


Repository: mesos


Description
---

Added status handling for quota master endpoint.


Diffs
-

  include/mesos/quota/quota.proto 03e816dcd4dead8326731ac221df7354c0610fed 
  src/master/master.hpp 8af82a0bbc2038e18180136c82cbaeeacc7b3526 
  src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 

Diff: https://reviews.apache.org/r/39492/diff/


Testing
---

Tests are in Review 39614.


Thanks,

Joerg Schad



Re: Review Request 41612: Fixed handling of failed authorization for (un)reserve operations.

2015-12-22 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41612/#review111590
---

Ship it!


- Alexander Rukletsov


On Dec. 21, 2015, 7:12 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41612/
> ---
> 
> (Updated Dec. 21, 2015, 7:12 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed handling of failed authorization for (un)reserve operations.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
> 
> Diff: https://reviews.apache.org/r/41612/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 39614: Quota: Added Status Validation Tests.

2015-12-22 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39614/#review111597
---



src/tests/master_quota_tests.cpp (line 578)


The ReviewBot is failing because `quotaResources` must be flattened.

Also, why do you use `ASSERT_*` instead of `EXPECT_*` which are used 
throughout the test?


- Alexander Rukletsov


On Dec. 22, 2015, 10:19 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39614/
> ---
> 
> (Updated Dec. 22, 2015, 10:19 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4218
> https://issues.apache.org/jira/browse/MESOS-4218
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Quota: Added Status Validation Tests.
> 
> 
> Diffs
> -
> 
>   src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1 
> 
> Diff: https://reviews.apache.org/r/39614/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>



Re: Review Request 41603: Cleaned up quota HTTP handling code and tests.

2015-12-22 Thread Alexander Rukletsov


> On Dec. 21, 2015, 11:38 p.m., Guangya Liu wrote:
> > src/master/quota_handler.cpp, lines 57-60
> > 
> >
> > Not yours but it would be greate to update it as following:
> > 
> > using mesos::quota::QuotaInfo;
> > 
> > using process::Future;
> > using process::Owned;

I grepped the codebase and found out that we indeed order `using` groups 
alphabetically. The only exception (and we are unfortunately inconsistent about 
it) is STL `using`s: sometimes we put them first (like with STL includes), 
sometimes alphabetically (after `process::*`). I'll reorder the whole using 
section.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41603/#review111555
---


On Dec. 22, 2015, 11:01 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41603/
> ---
> 
> (Updated Dec. 22, 2015, 11:01 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3960
> https://issues.apache.org/jira/browse/MESOS-3960
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Define a variable earlier in the handler for clarity; add consts and
> using directive where appropriate.
> 
> 
> Diffs
> -
> 
>   src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 
>   src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1 
> 
> Diff: https://reviews.apache.org/r/41603/diff/
> 
> 
> Testing
> ---
> 
> make check on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 39492: Added status endpoint for quota master endpoint.

2015-12-22 Thread Joerg Schad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/
---

(Updated Dec. 22, 2015, 8:38 a.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
Remoortere.


Bugs: MESOS-4013
https://issues.apache.org/jira/browse/MESOS-4013


Repository: mesos


Description
---

Added status handling for quota master endpoint.


Diffs
-

  include/mesos/quota/quota.proto 03e816dcd4dead8326731ac221df7354c0610fed 
  src/master/master.hpp 8af82a0bbc2038e18180136c82cbaeeacc7b3526 
  src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 

Diff: https://reviews.apache.org/r/39492/diff/


Testing (updated)
---

Tests are in Review 39614.


Thanks,

Joerg Schad



  1   2   >