Re: Review Request 41713: Added HDFS URI fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41713/ --- (Updated Dec. 31, 2015, 5:35 a.m.) Review request for mesos, Adam B, Ben

Re: Review Request 41714: Added tests for HDFS URI fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41714/ --- (Updated Dec. 31, 2015, 5:36 a.m.) Review request for mesos, Adam B, Ben

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/#review112368 --- src/master/master.cpp (line 1445)

Re: Review Request 41727: Fixed registry client to use libprocess parse url.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41727/#review112329 --- Ship it! Great cleanup! THanks!

Re: Review Request 41715: Support parsing url in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41715/#review112328 --- Ship it! 3rdparty/libprocess/src/http.cpp (line 169)

Re: Review Request 41728: Removed docker provisioner port slave flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41728/#review112331 --- Ship it! Again, great cleanup! Thanks Tim! - Jie Yu On Dec.

Re: Review Request 41697: Fixed a documentation bug in containerizer internals doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41697/#review112333 --- Ship it! Ship It! - Jie Yu On Dec. 23, 2015, 10:22 p.m., Anand

Re: Review Request 41705: Added support for enforcing quota on (persistent) volumes (MESOS-4198).

> On Dec. 25, 2015, 9:37 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/posix/disk.cpp, line 171 > > > > > > Should we simply use `!Resources::isPersistentVolume()` here? A disk volume resource

Re: Review Request 41704: Added support for checking whether a given path is absolute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41704/#review112342 --- Ship it! Ship It! - Jie Yu On Dec. 28, 2015, 7:35 p.m., Artem

Re: Review Request 41586: Partially enforced commit message guidelines with a hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41586/#review112346 --- Patch looks great! Reviews applied: [41584, 41586] Passed

Re: Review Request 40998: Added CHECK's for various executor states in Command Executor to verify if messages are delivered in order.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40998/ --- (Updated Dec. 30, 2015, 8:47 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 41754: Added reference to docker registry bearer token spec.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41754/#review112347 --- Ship it!

Re: Review Request 41586: Partially enforced commit message guidelines with a hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41586/ --- (Updated Dec. 30, 2015, 11:28 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 41731: Removed docker puller flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41731/#review112336 --- src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp

Re: Review Request 41705: Added support for enforcing quota on (persistent) volumes (MESOS-4198).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41705/#review112343 --- Ship it! src/slave/containerizer/mesos/isolators/posix/disk.cpp

Re: Review Request 40998: Added CHECK's for various executor states in Command Executor to verify if messages are delivered in order.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40998/#review112337 --- Ship it! src/launcher/executor.cpp (line 106)

Re: Review Request 41584: Added commit message guidelines to docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41584/#review112338 --- Ship it! Ship It! - Neil Conway On Dec. 19, 2015, 8:18 a.m.,

Re: Review Request 41586: Partially enforced commit message guidelines with a hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41586/#review112339 --- Ship it! Ship It! support/hooks/commit-msg (line 22)

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/#review112340 --- src/executor/executor.cpp (line 229)

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

> On Dec. 30, 2015, 7:25 p.m., Jojy Varghese wrote: > > src/executor/executor.cpp, line 229 > > > > > > We should probably limit the max value here. Does not make much sense to me. We do not have any semantics in

Re: Review Request 40998: Added CHECK's for various executor states in Command Executor to verify if messages are delivered in order.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40998/ --- (Updated Dec. 30, 2015, 8:06 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 41705: Added support for enforcing quota on (persistent) volumes (MESOS-4198).

> On Dec. 30, 2015, 11:55 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/posix/disk.cpp, line 301 > > > > > > We may want to report volume usage through ResourceStatistics. This can > > be a

Re: Review Request 41705: Added support for enforcing quota on (persistent) volumes (MESOS-4198).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41705/ --- (Updated Dec. 30, 2015, 4:01 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 41806: Cleaned up assertions in test cases around JSON HTTP responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41806/#review112350 --- Patch looks great! Reviews applied: [41806] Passed command:

Re: Review Request 41731: Removed docker puller flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41731/ --- (Updated Dec. 30, 2015, 11:08 p.m.) Review request for mesos, Gilbert Song,

Review Request 41810: Added credential to Docker image protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41810/ --- Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese. Repository:

Re: Review Request 41704: Added support for checking whether a given path is absolute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41704/ --- (Updated Dec. 30, 2015, 3:46 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 40998: Added CHECK's for various executor states in Command Executor to verify if messages are delivered in order.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40998/#review112348 --- Patch looks great! Reviews applied: [40998] Passed command:

Review Request 41806: Cleaned up assertions in test cases around JSON HTTP responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41806/ --- Review request for mesos and Adam B. Repository: mesos Description ---

Re: Review Request 41757: Unified Container: Added passing Env in docker runtime config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41757/#review112370 --- src/slave/containerizer/mesos/provisioner/store.hpp (line 43)

Re: Review Request 41758: Unified Container: Added passing Cmd in docker runtime config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41758/#review112371 --- src/slave/containerizer/mesos/provisioner/store.hpp (line 47)

Re: Review Request 41704: Added support for checking whether a given path is absolute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41704/ --- (Updated Dec. 30, 2015, 9:46 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 41597: Extending allocator interface to support dynamic weights

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Dec. 30, 2015, 8:07 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Dec. 30, 2015, 8:07 a.m.) Review request for mesos, Adam B, Neil

Review Request 41789: Add put method for http PUT request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- Review request for mesos, Adam B, Neil Conway, and Qian Zhang. Bugs:

Re: Review Request 41789: Add put method for http PUT request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/#review112293 --- May need to refer to

Review Request 41790: Add tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- Review request for mesos, Adam B, Neil Conway, and Qian Zhang. Bugs:

Re: Review Request 41790: Add tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated Dec. 30, 2015, 11:56 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41790: Add tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated Dec. 30, 2015, 10:59 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41790: Add tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated Dec. 30, 2015, 11:24 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41791: WIP: Updated allocation slack when dynamic reservation was updated.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41791/#review112306 --- Patch looks great! Reviews applied: [40375, 41334, 40529, 41772,

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Dec. 30, 2015, 11:54 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41789: Add put method for http PUT request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Dec. 30, 2015, 11:55 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Dec. 30, 2015, 11:54 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Dec. 30, 2015, 8:32 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Dec. 30, 2015, 8:32 a.m.) Review request for mesos, Adam B, Neil

Review Request 41791: WIP: Updated allocation slack when dynamic reservation was updated.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41791/ --- Review request for mesos, Klaus Ma and Jian Qiu. Repository: mesos

Re: Review Request 41789: Add put method for http PUT request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/#review112294 --- Patch looks great! Reviews applied: [41597, 41681, 41789] Passed

Re: Review Request 41789: Add put method for http PUT request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Dec. 30, 2015, 8:34 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41790: Add tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/#review112297 --- Patch looks great! Reviews applied: [41597, 41681, 41789, 41790]

Re: Review Request 41789: Add put method for http PUT request.

> On Dec. 30, 2015, 8:17 a.m., Jian Qiu wrote: > > May need to refer to https://issues.apache.org/jira/browse/MESOS-3763 Yes, I have noticed that ticket, but I found that patch does not work now, so I post a new patch to contiue my test coding. I have email to the owner of that ticket, and

Re: Review Request 41790: Add tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/#review112308 --- Patch looks great! Reviews applied: [41597, 41681, 41789, 41790]

Re: Review Request 41772: WIP: Added helper function to flatten resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41772/#review112310 --- src/common/resources.cpp (line 854)

Re: Review Request 40632: WIP: Enabled oversubscribed resources for reservations in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/#review112309 --- src/master/allocator/mesos/hierarchical.cpp (line 1302)