date:20160106


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41855/
---

(Updated Jan. 6, 2016, 7:24 p.m.)


Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van 
Remoortere, Joseph Wu, and Jian Qiu.


Changes
---

Correct defect # and add reviewers.


Bugs: MESOS-3892
https://issues.apache.org/jira/browse/MESOS-3892


Repository: mesos


Description
---

Trace the executor that are not launched; after launching, it's removed from 
pendingExecutor list.


Diffs
-

  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c 

Diff: https://reviews.apache.org/r/41855/diff/


Testing
---


Thanks,

Klaus Ma

Re: Review Request 41550: [5/5] Quota Authorization: Added tests for quota removal authorization.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41550/
---

(Updated Jan. 6, 2016, 11:26 a.m.)


Review request for mesos, Alexander Rukletsov and Till Toenshoff.


Changes
---

Addressed issues and merged tests.


Bugs: MESOS-4083
https://issues.apache.org/jira/browse/MESOS-4083


Repository: mesos


Description
---

Quota Authorization: Added tests for quota removal authorization.


Diffs (updated)
-

  src/tests/authorization_tests.cpp 1d11a02032c142455debd9c78d4ee4cc6297a350 
  src/tests/master_quota_tests.cpp 81f0386d072d0176cb28eb229b274e424004f54c 

Diff: https://reviews.apache.org/r/41550/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 41550: [5/5] Quota Authorization: Added tests for quota removal authorization.



> On Jan. 5, 2016, 7:51 p.m., Alexander Rukletsov wrote:
> > src/tests/master_quota_tests.cpp, lines 1308-1318
> > 
> >
> > You don't really need an agent here, you can set the force flag and 
> > remove this boilerplate code. Check the cleanup here: 
> > https://reviews.apache.org/r/41939
> 
> Jan Schlicht wrote:
> This is great! But I have some concerns that are more review related. I 
> would need to add the same comments as you do in the cleanup. As your code is 
> currently being reviewed, these comments may change and I would need to 
> change them as well, or vice versa. Therefore I think it would be better to 
> only fix this in your cleanup and leave it like that for now. Do you agree? 
> I'm mostly concerned about the comments explaining why the force flag is set 
> for the HTTP requests.

Talked with my Shepherd about this. Let's remove the boilerplate code and add 
the comments. If these change in your review, you'd need to change them here as 
well, okay?


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41550/#review112889
---


On Jan. 6, 2016, 11:26 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41550/
> ---
> 
> (Updated Jan. 6, 2016, 11:26 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Till Toenshoff.
> 
> 
> Bugs: MESOS-4083
> https://issues.apache.org/jira/browse/MESOS-4083
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Quota Authorization: Added tests for quota removal authorization.
> 
> 
> Diffs
> -
> 
>   src/tests/authorization_tests.cpp 1d11a02032c142455debd9c78d4ee4cc6297a350 
>   src/tests/master_quota_tests.cpp 81f0386d072d0176cb28eb229b274e424004f54c 
> 
> Diff: https://reviews.apache.org/r/41550/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 41855: Trace pending executors


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41855/
---

(Updated Jan. 6, 2016, 7:21 p.m.)


Review request for mesos and Guangya Liu.


Changes
---

Correct comments


Summary (updated)
-

Trace pending executors


Bugs: MESOS-3982
https://issues.apache.org/jira/browse/MESOS-3982


Repository: mesos


Description
---

Trace the executor that are not launched; after launching, it's removed from 
pendingExecutor list.


Diffs (updated)
-

  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c 

Diff: https://reviews.apache.org/r/41855/diff/


Testing
---


Thanks,

Klaus Ma

Re: Review Request 41550: [5/5] Quota Authorization: Added tests for quota removal authorization.



> On Jan. 5, 2016, 6:51 p.m., Alexander Rukletsov wrote:
> > src/tests/master_quota_tests.cpp, lines 1308-1318
> > 
> >
> > You don't really need an agent here, you can set the force flag and 
> > remove this boilerplate code. Check the cleanup here: 
> > https://reviews.apache.org/r/41939
> 
> Jan Schlicht wrote:
> This is great! But I have some concerns that are more review related. I 
> would need to add the same comments as you do in the cleanup. As your code is 
> currently being reviewed, these comments may change and I would need to 
> change them as well, or vice versa. Therefore I think it would be better to 
> only fix this in your cleanup and leave it like that for now. Do you agree? 
> I'm mostly concerned about the comments explaining why the force flag is set 
> for the HTTP requests.
> 
> Jan Schlicht wrote:
> Talked with my Shepherd about this. Let's remove the boilerplate code and 
> add the comments. If these change in your review, you'd need to change them 
> here as well, okay?

Sure!


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41550/#review112889
---


On Jan. 6, 2016, 10:53 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41550/
> ---
> 
> (Updated Jan. 6, 2016, 10:53 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Till Toenshoff.
> 
> 
> Bugs: MESOS-4083
> https://issues.apache.org/jira/browse/MESOS-4083
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Quota Authorization: Added tests for quota removal authorization.
> 
> 
> Diffs
> -
> 
>   src/tests/authorization_tests.cpp 1d11a02032c142455debd9c78d4ee4cc6297a350 
>   src/tests/master_quota_tests.cpp 81f0386d072d0176cb28eb229b274e424004f54c 
> 
> Diff: https://reviews.apache.org/r/41550/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 40529: Added helper function to get stateless resources.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40529/#review113054
---



include/mesos/v1/resources.hpp (line 155)


s/Resource/`Resource`, or s/Resource/resource



include/mesos/v1/resources.hpp (line 156)


I'd like to say: Currently, the resources without persistent volumes are 
considered to be `stateless`.



include/mesos/v1/resources.hpp (line 243)


ditto


- Klaus Ma


On Jan. 2, 2016, 9:15 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40529/
> ---
> 
> (Updated Jan. 2, 2016, 9:15 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, and Klaus Ma.
> 
> 
> Bugs: MESOS-3955
> https://issues.apache.org/jira/browse/MESOS-3955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added helper function to get stateless resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp 9c8bfb0e7e1e40ca99b4cc75079e5b950630243d 
>   include/mesos/v1/resources.hpp db87c992e2ec466cb1d4d17775bf6423a2fb15aa 
>   src/common/resources.cpp b9d31aef8babee212374e352c57fadbff02167f3 
>   src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 
>   src/v1/resources.cpp 0c0eee6b3b7ae3254d7dc7b06187855c9b873764 
> 
> Diff: https://reviews.apache.org/r/40529/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 41333: Added helper functions to filter usage slack resources.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41333/#review113056
---



src/common/resources.cpp (line 733)


This's not necessary; the default value of `RevocableInfo::type` is 
`USAGE_SLACK`, so return `type() == USAGE_SLACK` is OK.


- Klaus Ma


On Jan. 2, 2016, 9:15 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41333/
> ---
> 
> (Updated Jan. 2, 2016, 9:15 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, and Klaus Ma.
> 
> 
> Bugs: MESOS-4146
> https://issues.apache.org/jira/browse/MESOS-4146
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added helper functions to filter usage slack resources. This helper function 
> will be used to validate if the task is using usage slack resource or not so 
> as to make sure that one task or executor can only use same kind of resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp 9c8bfb0e7e1e40ca99b4cc75079e5b950630243d 
>   include/mesos/v1/resources.hpp db87c992e2ec466cb1d4d17775bf6423a2fb15aa 
>   src/common/resources.cpp b9d31aef8babee212374e352c57fadbff02167f3 
>   src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 
>   src/v1/resources.cpp 0c0eee6b3b7ae3254d7dc7b06187855c9b873764 
> 
> Diff: https://reviews.apache.org/r/41333/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-06 Thread Yongqiao Wang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41597/
---

(Updated Jan. 6, 2016, 11:01 a.m.)


Review request for mesos, Adam B, Neil Conway, and Qian Zhang.


Changes
---

Addressed the comments of Adam.


Bugs: MESOS-3943
https://issues.apache.org/jira/browse/MESOS-3943


Repository: mesos


Description
---

Add the interface in allocator to support updating weight
at runtime, and the allocator is invoked to allocate the
resources based on the updated weights later.


Diffs (updated)
-

  include/mesos/master/allocator.hpp f7ada68d7111486d264284990996413bb3d6 
  include/mesos/mesos.proto 158e08774c4a4fa5ec667388c61e55dbdafc7f67 
  include/mesos/v1/mesos.proto c6c5a81eb9282d188d90fe395e1c16633a2a64cf 
  src/master/allocator/mesos/allocator.hpp 
50ef3b20f34bc6d87cbeccabcebec9a5031a6554 
  src/master/allocator/mesos/hierarchical.hpp 
86ea5a402ed67f8f22f11d5730147cd907d66a08 
  src/master/allocator/mesos/hierarchical.cpp 
df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f 
  src/master/allocator/sorter/drf/sorter.hpp 
050896e8b12cd4097ccd137d5284d6b39b0f06ab 
  src/master/allocator/sorter/drf/sorter.cpp 
3a442f121f3a1505513877a5c78458a4b8d0a824 
  src/master/allocator/sorter/sorter.hpp 
7be6b44a762fd62c2cd7f28b4dc4865a4587ed26 
  src/tests/allocator.hpp 9bdfaecf1a148f113ad52956b50ed7cabe0902ef 

Diff: https://reviews.apache.org/r/41597/diff/


Testing
---

Make & Make check successfully!

Test case: https://reviews.apache.org/r/41672/


Thanks,

Yongqiao Wang

Re: Review Request 41333: Added helper functions to filter usage slack resources.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41333/#review113053
---


Overall comments is that: is this code called by any others? If not, why should 
we add that? I'd suggest to add this on demand.

- Klaus Ma


On Jan. 2, 2016, 9:15 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41333/
> ---
> 
> (Updated Jan. 2, 2016, 9:15 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, and Klaus Ma.
> 
> 
> Bugs: MESOS-4146
> https://issues.apache.org/jira/browse/MESOS-4146
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added helper functions to filter usage slack resources. This helper function 
> will be used to validate if the task is using usage slack resource or not so 
> as to make sure that one task or executor can only use same kind of resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp 9c8bfb0e7e1e40ca99b4cc75079e5b950630243d 
>   include/mesos/v1/resources.hpp db87c992e2ec466cb1d4d17775bf6423a2fb15aa 
>   src/common/resources.cpp b9d31aef8babee212374e352c57fadbff02167f3 
>   src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 
>   src/v1/resources.cpp 0c0eee6b3b7ae3254d7dc7b06187855c9b873764 
> 
> Diff: https://reviews.apache.org/r/41333/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 41550: [5/5] Quota Authorization: Added tests for quota removal authorization.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41550/
---

(Updated Jan. 6, 2016, 11:53 a.m.)


Review request for mesos, Alexander Rukletsov and Till Toenshoff.


Changes
---

Use force flag to remove the need for an agent.


Bugs: MESOS-4083
https://issues.apache.org/jira/browse/MESOS-4083


Repository: mesos


Description
---

Quota Authorization: Added tests for quota removal authorization.


Diffs (updated)
-

  src/tests/authorization_tests.cpp 1d11a02032c142455debd9c78d4ee4cc6297a350 
  src/tests/master_quota_tests.cpp 81f0386d072d0176cb28eb229b274e424004f54c 

Diff: https://reviews.apache.org/r/41550/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 41959: Statically initializing fetcher plugins.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41959/#review113036
---


Patch looks great!

Reviews applied: [41958, 41959]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 6, 2016, 2:14 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41959/
> ---
> 
> (Updated Jan. 6, 2016, 2:14 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since fetcher plugins are not dynamically pluggable today, simplified the
> factory method to use the statically intitalized plugins. This would be
> useful when Fetchers are created multiple times.
> 
> 
> Diffs
> -
> 
>   src/uri/fetcher.cpp ac13fbdc7399045d183cbdcc48dc5cf9969e8ad5 
> 
> Diff: https://reviews.apache.org/r/41959/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 41593: Added `jsonify` function to stout.

2016-01-06 Thread Benjamin Bannier



> On Jan. 5, 2016, 10:28 a.m., Benjamin Bannier wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, line 107
> > 
> >
> > Here and in all dtrs below: Given that we don't know whether exceptions 
> > are enabled for `stream` (this is stout), could we wrap this in a `try` 
> > block?, e.g., imagine an underlying `fstream` becoming `bad` because there 
> > is no space left on the device.
> 
> Michael Park wrote:
> Hm... that's a good point. I'm not particularly worried about it for our 
> use case since we don't use exception-enabled streams but it is an issue in 
> the general case. One approach would be to make it a requirement that the 
> stream not be exception-enabled (We can `CHECK` this on construction). If we 
> were to wrap it in a `try` block, the best we can do is swallow the exception 
> with no way to propagate the information which is generally a bad idea...

AFAICT there is no race-free way to `CHECK` that exceptions on `stream` are 
disabled, so it seems like one would need to fix this by violently documenting 
a pre-condition.

Not sure how easy it would be to adjust the existing design, but one could 
imagine closing the semantic brackets (currently in dtrs) from some `finalize` 
method (phooey!). If something threw from there users could either catch or 
just `terminate`, but at least we wouldn't summon UB.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41593/#review112802
---


On Jan. 5, 2016, 11:38 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41593/
> ---
> 
> (Updated Jan. 5, 2016, 11:38 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 
> 5ab7bc4966fe32eaddd573a4dbfd997f98b5d481 
>   3rdparty/libprocess/3rdparty/stout/README.md 
> a2a3dc6120b10c8fe82088b9f0ebecfa5642f945 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
>   3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
> 98ea47794b3a7c99b3cbd2418ba6e36eb5951259 
>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
> 62ad461eb228b688f1ceac16cfb003561ed5a806 
>   3rdparty/libprocess/3rdparty/stout/tests/jsonify_tests.cpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 
> bf2a2b8a9f67c6a4cf66b156b9c14fae015a8af0 
> 
> Diff: https://reviews.apache.org/r/41593/diff/
> 
> 
> Testing
> ---
> 
> Added tests to ``
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-06 Thread Adam B


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41597/#review113035
---


Nearly flawless, but I want to wait until I've gotten through a couple others 
before I commit them all as a group.


include/mesos/master/allocator.hpp (lines 402 - 406)


Remove the first "Updates weights." line, since that's no more helpful than 
the function name. The next sentence makes a better doxygen brief description 
anyway, maybe reworded something like: 
"Updates the weight of each provided role.
Subsequent allocation calculations will use these updated weights."



include/mesos/mesos.proto (line 1665)


Useless comment. Please remove.



src/master/allocator/mesos/hierarchical.cpp (lines 1048 - 1051)


Does anything rely on this behavior of erasing 1.0s from the hashmap? I 
know it'll (slightly) reduce the number of bits in memory and persisted in the 
registry, but is there any other reason to do this? Might be a premature 
optimization. Besides, the sorters still get updated for 1.0s.
Thoughts?


- Adam B


On Jan. 5, 2016, 6:14 p.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41597/
> ---
> 
> (Updated Jan. 5, 2016, 6:14 p.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-3943
> https://issues.apache.org/jira/browse/MESOS-3943
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add the interface in allocator to support updating weight
> at runtime, and the allocator is invoked to allocate the
> resources based on the updated weights later.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp f7ada68d7111486d264284990996413bb3d6 
>   include/mesos/mesos.proto 158e08774c4a4fa5ec667388c61e55dbdafc7f67 
>   include/mesos/v1/mesos.proto c6c5a81eb9282d188d90fe395e1c16633a2a64cf 
>   src/master/allocator/mesos/allocator.hpp 
> 50ef3b20f34bc6d87cbeccabcebec9a5031a6554 
>   src/master/allocator/mesos/hierarchical.hpp 
> 86ea5a402ed67f8f22f11d5730147cd907d66a08 
>   src/master/allocator/mesos/hierarchical.cpp 
> df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f 
>   src/master/allocator/sorter/drf/sorter.hpp 
> 050896e8b12cd4097ccd137d5284d6b39b0f06ab 
>   src/master/allocator/sorter/drf/sorter.cpp 
> 3a442f121f3a1505513877a5c78458a4b8d0a824 
>   src/master/allocator/sorter/sorter.hpp 
> 7be6b44a762fd62c2cd7f28b4dc4865a4587ed26 
>   src/tests/allocator.hpp 9bdfaecf1a148f113ad52956b50ed7cabe0902ef 
> 
> Diff: https://reviews.apache.org/r/41597/diff/
> 
> 
> Testing
> ---
> 
> Make & Make check successfully!
> 
> Test case: https://reviews.apache.org/r/41672/
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 41549: [4/5] Quota Authorization: Documented quota removal authorization.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41549/
---

(Updated Jan. 6, 2016, 12:16 p.m.)


Review request for mesos, Alexander Rukletsov and Till Toenshoff.


Changes
---

Addressed issues.


Bugs: MESOS-4081
https://issues.apache.org/jira/browse/MESOS-4081


Repository: mesos


Description
---

Quota Authorization: Documented quota removal authorization.


Diffs (updated)
-

  docs/authorization.md 900922855723581f4f7b77ecbc2fd3dbbd33e572 
  src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d 

Diff: https://reviews.apache.org/r/41549/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 41548: [3/5] Quota Authorization: Implemented quota remove authorization.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41548/
---

(Updated Jan. 6, 2016, 12:16 p.m.)


Review request for mesos, Alexander Rukletsov and Till Toenshoff.


Changes
---

Addressed issues.


Bugs: MESOS-4081
https://issues.apache.org/jira/browse/MESOS-4081


Repository: mesos


Description
---

Quota Authorization: Implemented quota remove authorization.


Diffs (updated)
-

  include/mesos/quota/quota.proto ab505b1a8b99e2ec0b541cd258daabc8d8045191 
  src/master/master.hpp 2936d32c5e7b5b944bf16a1f261c7c54179900ec 
  src/master/quota_handler.cpp ac4da74686f524a66745b4a4e038c3d703ea1ee9 

Diff: https://reviews.apache.org/r/41548/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 41946: Added a `Representation` abstraction to stout.

2016-01-06 Thread Benjamin Bannier


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41946/#review113033
---



3rdparty/libprocess/3rdparty/stout/include/stout/representation.hpp (line 66)


Seems like an `explicit` ctr is good enough here, right? Otherwise `/* 
implicit */` would show that this is intentional.



3rdparty/libprocess/3rdparty/stout/include/stout/representation.hpp (line 67)


Any reason you did not delete the ctr from `T&&`?



3rdparty/libprocess/3rdparty/stout/include/stout/representation.hpp (line 76)


Would it make sense to add an r-value ref qualifier here to effectively 
make non-temporary `References` unusable? At least it would alleviate some 
cases of lifetime mismatches between `value` and it's `Representation`.


- Benjamin Bannier


On Jan. 6, 2016, 3:48 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41946/
> ---
> 
> (Updated Jan. 6, 2016, 3:48 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
>   3rdparty/libprocess/3rdparty/stout/include/stout/representation.hpp 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41946/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 41550: [5/5] Quota Authorization: Added tests for quota removal authorization.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41550/#review113050
---



src/tests/master_quota_tests.cpp (line 1216)


s/acl/acl1



src/tests/master_quota_tests.cpp (lines 1239 - 1241)


This comment is related to the whole block and not to `Resources` struct 
only. Let's split it into two parts: one for the block and one for resources.



src/tests/master_quota_tests.cpp (lines 1257 - 1259)


Same here.



src/tests/master_quota_tests.cpp (lines 1291 - 1294)


Also here, and below. Since each block is actually a test case, we should 
prepend it with a comment explaining the intention behind, same as we do for 
each test.



src/tests/master_quota_tests.cpp (lines 1206 - 1207)


Now you also check that unauthorized princiapls can't do that. Please 
update the comment (and maybe the test name) accordingly (e.g. 
`AuthorizeQuotaRequests`).



src/tests/master_quota_tests.cpp (line 1329)


To be consistent with the previous test, let's 
s/AuthorizedQuotaRequestsWithoutPrincipal/AuthorizeQuotaRequestsWithoutPrincipal



src/tests/master_quota_tests.cpp (lines 1336 - 1342)


Blank lines, please.



src/tests/master_quota_tests.cpp (lines 1352 - 1364)


We agreed to wrap those in blocks, no? Same for remove quota below.


- Alexander Rukletsov


On Jan. 6, 2016, 10:53 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41550/
> ---
> 
> (Updated Jan. 6, 2016, 10:53 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Till Toenshoff.
> 
> 
> Bugs: MESOS-4083
> https://issues.apache.org/jira/browse/MESOS-4083
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Quota Authorization: Added tests for quota removal authorization.
> 
> 
> Diffs
> -
> 
>   src/tests/authorization_tests.cpp 1d11a02032c142455debd9c78d4ee4cc6297a350 
>   src/tests/master_quota_tests.cpp 81f0386d072d0176cb28eb229b274e424004f54c 
> 
> Diff: https://reviews.apache.org/r/41550/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 41550: [5/5] Quota Authorization: Added tests for quota removal authorization.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41550/#review113051
---



src/tests/master_quota_tests.cpp (line 1337)


s/acl/acl1


- Alexander Rukletsov


On Jan. 6, 2016, 10:53 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41550/
> ---
> 
> (Updated Jan. 6, 2016, 10:53 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Till Toenshoff.
> 
> 
> Bugs: MESOS-4083
> https://issues.apache.org/jira/browse/MESOS-4083
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Quota Authorization: Added tests for quota removal authorization.
> 
> 
> Diffs
> -
> 
>   src/tests/authorization_tests.cpp 1d11a02032c142455debd9c78d4ee4cc6297a350 
>   src/tests/master_quota_tests.cpp 81f0386d072d0176cb28eb229b274e424004f54c 
> 
> Diff: https://reviews.apache.org/r/41550/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 41947: Changed signature of `QuotaInfo` validation.

2016-01-06 Thread Joerg Schad


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41947/#review113044
---

Ship it!


Ship It!

- Joerg Schad


On Jan. 5, 2016, 11:38 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41947/
> ---
> 
> (Updated Jan. 5, 2016, 11:38 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-4058
> https://issues.apache.org/jira/browse/MESOS-4058
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/quota.hpp 7a728e3d2e66c4d0fd3b5dbf0fdc854363bae53e 
>   src/master/quota.cpp df2cc5877160df101222756739f042895ceacc95 
>   src/master/quota_handler.cpp 1d84ef5767b3cb7cf870dd184aa2d9f030919498 
> 
> Diff: https://reviews.apache.org/r/41947/diff/
> 
> 
> Testing
> ---
> 
> `make check` on Mac OS 10.10.5
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 41790: Add tests for /weights endpoint.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review113028
---


Patch looks great!

Reviews applied: [41597, 41681, 41789, 41790]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 6, 2016, 2:07 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> ---
> 
> (Updated Jan. 6, 2016, 2:07 a.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add tests for /weights endpoint.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817 
>   src/tests/dynamic_weights_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41790/diff/
> 
> 
> Testing
> ---
> 
> Make and Make check successfully!
> 
> ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==] Running 10 tests from 1 test case.
> [--] Global test environment set-up.
> [--] 10 tests from DynamicWeightsTest
> [ RUN  ] DynamicWeightsTest.PutInvalidRequest
> [   OK ] DynamicWeightsTest.PutInvalidRequest (102 ms)
> [ RUN  ] DynamicWeightsTest.NegativeWeight
> [   OK ] DynamicWeightsTest.NegativeWeight (42 ms)
> [ RUN  ] DynamicWeightsTest.MissingRole
> [   OK ] DynamicWeightsTest.MissingRole (43 ms)
> [ RUN  ] DynamicWeightsTest.NonExistentRole
> [   OK ] DynamicWeightsTest.NonExistentRole (30 ms)
> [ RUN  ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [   OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (38 ms)
> [ RUN  ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
> [   OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (42 ms)
> [ RUN  ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
> [   OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (35 ms)
> [ RUN  ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
> [   OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (37 ms)
> [ RUN  ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
> [   OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal 
> (44 ms)
> [ RUN  ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
> [   OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (30 ms)
> [--] 10 tests from DynamicWeightsTest (443 ms total)
> 
> [--] Global test environment tear-down
> [==] 10 tests from 1 test case ran. (452 ms total)
> [  PASSED  ] 10 tests.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 41938: Cleaned up quota tests.

2016-01-06 Thread Joerg Schad


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41938/#review113034
---



src/tests/master_quota_tests.cpp (line 160)


Shouldn't this be SetNonExistentRole?



src/tests/master_quota_tests.cpp (line 297)


SetResourcesSpecifyRole?


- Joerg Schad


On Jan. 5, 2016, 11:39 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41938/
> ---
> 
> (Updated Jan. 5, 2016, 11:39 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van 
> Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changes made:
>   - removed extra ';' in resources string;
>   - renamed variables for clarity;
>   - updated comments;
>   - removed explicit conversion to `Resources`;
>   - wrapped test cases in {} blocks.
> 
> 
> Diffs
> -
> 
>   src/tests/master_quota_tests.cpp 2f1bc3ae6a370e466f7cea9b597f51d7eccb1b33 
>   src/tests/registrar_tests.cpp 6064621a001d66423f9b2dc7b749b67d9fc4bc13 
> 
> Diff: https://reviews.apache.org/r/41938/diff/
> 
> 
> Testing
> ---
> 
> `make check` on Mac OS 10.10.5
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 41550: [5/5] Quota Authorization: Added tests for quota removal authorization.



> On Jan. 5, 2016, 7:51 p.m., Alexander Rukletsov wrote:
> > src/tests/master_quota_tests.cpp, lines 1308-1318
> > 
> >
> > You don't really need an agent here, you can set the force flag and 
> > remove this boilerplate code. Check the cleanup here: 
> > https://reviews.apache.org/r/41939

This is great! But I have some concerns that are more review related. I would 
need to add the same comments as you do in the cleanup. As your code is 
currently being reviewed, these comments may change and I would need to change 
them as well, or vice versa. Therefore I think it would be better to only fix 
this in your cleanup and leave it like that for now. Do you agree? I'm mostly 
concerned about the comments explaining why the force flag is set for the HTTP 
requests.


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41550/#review112889
---


On Jan. 5, 2016, 4:13 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41550/
> ---
> 
> (Updated Jan. 5, 2016, 4:13 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Till Toenshoff.
> 
> 
> Bugs: MESOS-4083
> https://issues.apache.org/jira/browse/MESOS-4083
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Quota Authorization: Added tests for quota removal authorization.
> 
> 
> Diffs
> -
> 
>   src/tests/authorization_tests.cpp 1d11a02032c142455debd9c78d4ee4cc6297a350 
>   src/tests/master_quota_tests.cpp 2f1bc3ae6a370e466f7cea9b597f51d7eccb1b33 
> 
> Diff: https://reviews.apache.org/r/41550/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-06 Thread Yongqiao Wang



> On Jan. 6, 2016, 10:09 a.m., Adam B wrote:
> > src/master/allocator/mesos/hierarchical.cpp, lines 1048-1051
> > 
> >
> > Does anything rely on this behavior of erasing 1.0s from the hashmap? I 
> > know it'll (slightly) reduce the number of bits in memory and persisted in 
> > the registry, but is there any other reason to do this? Might be a 
> > premature optimization. Besides, the sorters still get updated for 1.0s.
> > Thoughts?

There is no any other reasons for erasing the default weight frm the hasmap. In 
HierarchicalAllocatorProcess::roleWeight method of allocator, if the role's 
weight does not exist in weights hashmap, then it will return 1.0. so it is 
make sence to the erase it.

In addition, we should keep the same behaviour to only save the non-default 
weights in allocator, master and registry.


- Yongqiao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41597/#review113035
---


On Jan. 6, 2016, 2:14 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41597/
> ---
> 
> (Updated Jan. 6, 2016, 2:14 a.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-3943
> https://issues.apache.org/jira/browse/MESOS-3943
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add the interface in allocator to support updating weight
> at runtime, and the allocator is invoked to allocate the
> resources based on the updated weights later.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp f7ada68d7111486d264284990996413bb3d6 
>   include/mesos/mesos.proto 158e08774c4a4fa5ec667388c61e55dbdafc7f67 
>   include/mesos/v1/mesos.proto c6c5a81eb9282d188d90fe395e1c16633a2a64cf 
>   src/master/allocator/mesos/allocator.hpp 
> 50ef3b20f34bc6d87cbeccabcebec9a5031a6554 
>   src/master/allocator/mesos/hierarchical.hpp 
> 86ea5a402ed67f8f22f11d5730147cd907d66a08 
>   src/master/allocator/mesos/hierarchical.cpp 
> df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f 
>   src/master/allocator/sorter/drf/sorter.hpp 
> 050896e8b12cd4097ccd137d5284d6b39b0f06ab 
>   src/master/allocator/sorter/drf/sorter.cpp 
> 3a442f121f3a1505513877a5c78458a4b8d0a824 
>   src/master/allocator/sorter/sorter.hpp 
> 7be6b44a762fd62c2cd7f28b4dc4865a4587ed26 
>   src/tests/allocator.hpp 9bdfaecf1a148f113ad52956b50ed7cabe0902ef 
> 
> Diff: https://reviews.apache.org/r/41597/diff/
> 
> 
> Testing
> ---
> 
> Make & Make check successfully!
> 
> Test case: https://reviews.apache.org/r/41672/
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38950/
---

(Updated Jan. 6, 2016, 2:43 p.m.)


Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.


Changes
---

Till's requested changes.


Bugs: MESOS-3756
https://issues.apache.org/jira/browse/MESOS-3756


Repository: mesos


Description
---

Adds support for modularization of HTTP Authenticators. 

It includes an example of how to do it with the Basic HTTP Authenticator.


Diffs (updated)
-

  include/mesos/authentication/http/basic_authenticator_factory.hpp 
PRE-CREATION 
  include/mesos/module/http_authenticator.hpp PRE-CREATION 
  src/CMakeLists.txt 8169fe4f1a0eda5c2e2b30e22a7346478420a9a0 
  src/Makefile.am 865926c5b46e42c5e29d3645a700c4ad20c1f11d 
  src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION 
  src/examples/test_http_authenticator_module.cpp PRE-CREATION 
  src/master/constants.hpp f1624e1ed5091f08f57d4382b344cab8b05ba840 
  src/master/constants.cpp 589f2ee55a24d7e8b9352a4c8f94a3785fd1bef4 
  src/module/manager.cpp 127942e20800d4a6bfff70597e37cb9d76e2270e 
  src/tests/http_authentication_tests.cpp PRE-CREATION 
  src/tests/module.hpp 8e92774ddd51bc8a1368fb1cf6546300696b2d22 
  src/tests/module.cpp 7968519996ca9f9d8895e73d5f173d26a7e794e0 

Diff: https://reviews.apache.org/r/38950/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Review Request 41930: Added "TeardownFramework" to ACL protobuf.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41930/
---

Review request for mesos and Adam B.


Bugs: MESOS-4154
https://issues.apache.org/jira/browse/MESOS-4154


Repository: mesos


Description
---

This patch included the following:
1) Renamed "ShutdownFramework" to "TeardownFramework".
2) Added teardown_frameworks ACL to protobuf.


Diffs
-

  include/mesos/authorizer/authorizer.hpp 
f61613948b7b5c5c2118f1782a0c5f8ff7e8e057 
  include/mesos/authorizer/authorizer.proto 
7b729e19484d92be48bbde4dff2c833a4109936e 
  src/authorizer/local/authorizer.hpp 1563c11709c2612350354690b50ceb33d2720f98 
  src/authorizer/local/authorizer.cpp 1d135fb6906c7050a788cbac9ca2d8164ff064ef 
  src/master/http.cpp d7afa2af989eebfc9039b3681f087ce570f601d5 
  src/tests/master_tests.cpp 865fa4a71f4bae2a218cd2c4e10873222d1ea3c4 
  src/tests/mesos.hpp 49a4c48e6887e6f0921d96c359746e39be10e222 
  src/tests/mesos.cpp 082e57bc73fad02de77e16e4b34451e6c0903038 
  src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8 
  src/tests/teardown_tests.cpp 97cc89ba168aefff8512f6d1a25c4f7ddf180bae 

Diff: https://reviews.apache.org/r/41930/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Review Request 41932: Updated "teardown_framework" requests in the authorizer.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41932/
---

Review request for mesos and Adam B.


Bugs: MESOS-4154
https://issues.apache.org/jira/browse/MESOS-4154


Repository: mesos


Description
---

See Summary.


Diffs
-

  src/authorizer/local/authorizer.cpp 1d135fb6906c7050a788cbac9ca2d8164ff064ef 
  src/tests/teardown_tests.cpp 97cc89ba168aefff8512f6d1a25c4f7ddf180bae 

Diff: https://reviews.apache.org/r/41932/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 41948: Ensured `QuotaInfo` is valid in registrar tests.

2016-01-06 Thread Joerg Schad


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41948/#review113060
---

Ship it!


Ship It!

- Joerg Schad


On Jan. 5, 2016, 11:38 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41948/
> ---
> 
> (Updated Jan. 5, 2016, 11:38 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-4058
> https://issues.apache.org/jira/browse/MESOS-4058
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Resources in `QuotaInfo` protobuf must not specify role, hence
> remove all occurrences of `flatten()` and add explicit validation.
> 
> 
> Diffs
> -
> 
>   src/tests/registrar_tests.cpp 6064621a001d66423f9b2dc7b749b67d9fc4bc13 
> 
> Diff: https://reviews.apache.org/r/41948/diff/
> 
> 
> Testing
> ---
> 
> `make check` on Mac OS 10.10.5
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39043/
---

(Updated Jan. 6, 2016, 2:47 p.m.)


Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, Jan Schlicht, 
and Till Toenshoff.


Changes
---

Rebase.


Bugs: MESOS-3756
https://issues.apache.org/jira/browse/MESOS-3756


Repository: mesos


Description
---

1. Adds a flag to load an HTTP Authenticator module from the flags.
2. If provided, uses the credentials file to initialize the default HTTP 
Authenticator.
3. Updates the existing endpoints which implement their own basic HTTP 
authenticator with the libprocess one.
4. Updates one test which expected the wrong results since now credentials are 
checked before the body of the request.


Diffs (updated)
-

  include/mesos/authentication/http/basic_authenticator_factory.hpp 
PRE-CREATION 
  src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION 
  src/master/constants.hpp f1624e1ed5091f08f57d4382b344cab8b05ba840 
  src/master/constants.cpp 589f2ee55a24d7e8b9352a4c8f94a3785fd1bef4 
  src/master/flags.hpp 9af6c68eef6bcf39d5776809fab6c66dc95da6b2 
  src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d 
  src/master/http.cpp d7afa2af989eebfc9039b3681f087ce570f601d5 
  src/master/master.hpp 2936d32c5e7b5b944bf16a1f261c7c54179900ec 
  src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
  src/master/quota_handler.cpp ac4da74686f524a66745b4a4e038c3d703ea1ee9 
  src/tests/master_quota_tests.cpp 81f0386d072d0176cb28eb229b274e424004f54c 
  src/tests/mesos.cpp 082e57bc73fad02de77e16e4b34451e6c0903038 
  src/tests/persistent_volume_endpoints_tests.cpp 
f0cce190abc90f0fae84d6c3db20e8215c2d8132 

Diff: https://reviews.apache.org/r/39043/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 41549: Quota: Documented quota removal authorization.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41549/
---

(Updated Jan. 6, 2016, 2:36 p.m.)


Review request for mesos, Alexander Rukletsov and Till Toenshoff.


Summary (updated)
-

Quota: Documented quota removal authorization.


Bugs: MESOS-4081
https://issues.apache.org/jira/browse/MESOS-4081


Repository: mesos


Description
---

Quota Authorization: Documented quota removal authorization.


Diffs
-

  docs/authorization.md 900922855723581f4f7b77ecbc2fd3dbbd33e572 
  src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d 

Diff: https://reviews.apache.org/r/41549/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 41550: Quota: Added tests for quota removal authorization.



> On Jan. 6, 2016, 2:54 p.m., Alexander Rukletsov wrote:
> > src/tests/master_quota_tests.cpp, line 1243
> > 
> >
> > There is no agent any more, right : )? How about
> > "A request can contain any amount of resources because we set the force 
> > flag."

After some discussion we decided to also include an explanation what the 
rationale for using the force flags has to do with these resources.


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41550/#review113064
---


On Jan. 6, 2016, 3:34 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41550/
> ---
> 
> (Updated Jan. 6, 2016, 3:34 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Till Toenshoff.
> 
> 
> Bugs: MESOS-4083
> https://issues.apache.org/jira/browse/MESOS-4083
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> see summary.
> 
> 
> Diffs
> -
> 
>   src/tests/authorization_tests.cpp 1d11a02032c142455debd9c78d4ee4cc6297a350 
>   src/tests/master_quota_tests.cpp 81f0386d072d0176cb28eb229b274e424004f54c 
> 
> Diff: https://reviews.apache.org/r/41550/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 41855: [WIP] Trace pending executors


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41855/
---

(Updated Jan. 6, 2016, 10:03 p.m.)


Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van 
Remoortere, Joseph Wu, and Jian Qiu.


Changes
---

rebase


Bugs: MESOS-3892
https://issues.apache.org/jira/browse/MESOS-3892


Repository: mesos


Description
---

Trace the executor that are not launched; after launching, it's removed from 
pendingExecutor list.


Diffs (updated)
-

  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f 

Diff: https://reviews.apache.org/r/41855/diff/


Testing
---


Thanks,

Klaus Ma

Re: Review Request 41548: Quota: Implemented quota remove authorization.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41548/
---

(Updated Jan. 6, 2016, 2:37 p.m.)


Review request for mesos, Alexander Rukletsov and Till Toenshoff.


Summary (updated)
-

Quota: Implemented quota remove authorization.


Bugs: MESOS-4081
https://issues.apache.org/jira/browse/MESOS-4081


Repository: mesos


Description
---

Quota Authorization: Implemented quota remove authorization.


Diffs
-

  include/mesos/quota/quota.proto ab505b1a8b99e2ec0b541cd258daabc8d8045191 
  src/master/master.hpp 2936d32c5e7b5b944bf16a1f261c7c54179900ec 
  src/master/quota_handler.cpp ac4da74686f524a66745b4a4e038c3d703ea1ee9 

Diff: https://reviews.apache.org/r/41548/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 41850: [MESOS-3892] Add map to trace evictable executors


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41850/
---

(Updated Jan. 6, 2016, 8:14 p.m.)


Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van 
Remoortere, Joseph Wu, and Jian Qiu.


Changes
---

Update comments


Summary (updated)
-

[MESOS-3892] Add map to trace evictable executors


Bugs: MESOS-3892
https://issues.apache.org/jira/browse/MESOS-3892


Repository: mesos


Description
---

Before getting evictable executors for evicting, it need to trace which 
execuotor can be evicted.


Diffs (updated)
-

  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c 

Diff: https://reviews.apache.org/r/41850/diff/


Testing
---


Thanks,

Klaus Ma

Re: Review Request 41462: Used SFINAE-friendly `result_of` in libprocess.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41462/#review113059
---


Patch looks great!

Reviews applied: [41459, 41460, 41461, 41462]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 6, 2016, 2:28 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41462/
> ---
> 
> (Updated Jan. 6, 2016, 2:28 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Alex Clemmer, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-4220
> https://issues.apache.org/jira/browse/MESOS-4220
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used the SFINAE `result_of` implemented in 
> [r41461](https://reviews.apache.org/r/41461/).
> 
> Follow-up from [r40114](https://reviews.apache.org/r/40114/).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/async.hpp 
> b80b60a7ceb5e87eed8cdab17144ae9617485a04 
>   3rdparty/libprocess/include/process/future.hpp 
> bcb5668565298825056f1b48d48efe12d2e56e7c 
> 
> Diff: https://reviews.apache.org/r/41462/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OS X, compiled on Windows.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 41855: [WIP] Trace pending executors


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41855/
---

(Updated Jan. 6, 2016, 8:48 p.m.)


Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van 
Remoortere, Joseph Wu, and Jian Qiu.


Changes
---

Working rebase


Summary (updated)
-

[WIP] Trace pending executors


Bugs: MESOS-3892
https://issues.apache.org/jira/browse/MESOS-3892


Repository: mesos


Description
---

Trace the executor that are not launched; after launching, it's removed from 
pendingExecutor list.


Diffs (updated)
-

  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c 

Diff: https://reviews.apache.org/r/41855/diff/


Testing
---


Thanks,

Klaus Ma

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

2016-01-06 Thread Till Toenshoff


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38950/#review113061
---

Ship it!


This looks great Alexander - almost perfect :) !


src/master/constants.hpp (line 134)


s/Basic/basic/



src/tests/module.cpp (line 239)


s/http/HTTP/



src/tests/module.cpp (line 284)


s/http/HTTP/

s/teshttpauthenticator/testhttpauthenticator/


- Till Toenshoff


On Jan. 5, 2016, 4:17 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38950/
> ---
> 
> (Updated Jan. 5, 2016, 4:17 p.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3756
> https://issues.apache.org/jira/browse/MESOS-3756
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds support for modularization of HTTP Authenticators. 
> 
> It includes an example of how to do it with the Basic HTTP Authenticator.
> 
> 
> Diffs
> -
> 
>   include/mesos/authentication/http/basic_authenticator_factory.hpp 
> PRE-CREATION 
>   include/mesos/module/http_authenticator.hpp PRE-CREATION 
>   src/CMakeLists.txt 8169fe4f1a0eda5c2e2b30e22a7346478420a9a0 
>   src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817 
>   src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION 
>   src/examples/test_http_authenticator_module.cpp PRE-CREATION 
>   src/master/constants.hpp f1624e1ed5091f08f57d4382b344cab8b05ba840 
>   src/master/constants.cpp 589f2ee55a24d7e8b9352a4c8f94a3785fd1bef4 
>   src/module/manager.cpp 127942e20800d4a6bfff70597e37cb9d76e2270e 
>   src/tests/http_authentication_tests.cpp PRE-CREATION 
>   src/tests/module.hpp 8e92774ddd51bc8a1368fb1cf6546300696b2d22 
>   src/tests/module.cpp 7968519996ca9f9d8895e73d5f173d26a7e794e0 
> 
> Diff: https://reviews.apache.org/r/38950/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41649/#review113070
---


Patch looks great!

Reviews applied: [41649]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 6, 2016, 10:28 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41649/
> ---
> 
> (Updated Jan. 6, 2016, 10:28 a.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, and Till Toenshoff.
> 
> 
> Bugs: MESOS-2317
> https://issues.apache.org/jira/browse/MESOS-2317
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed slave checkpointing logic after deprecation cycle.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 158e08774c4a4fa5ec667388c61e55dbdafc7f67 
>   src/cli/execute.cpp a2b610f32da3deb9d3df99c225d22a425e03cdba 
>   src/examples/docker_no_executor_framework.cpp 
> 7b3f0581f75105addb388dc15c4a0390ae4e0e0e 
>   src/examples/java/TestFramework.java 
> cbcdeedb0da22f82e274d088eb15a4128fd920fe 
>   src/examples/python/test_framework.py 
> 6af6d22f54c0ad702917d09cf658e70f7032d793 
>   src/internal/devolve.cpp 6c38403d908954112e07030c80e8701b84178678 
>   src/master/allocator/mesos/hierarchical.hpp 
> 86ea5a402ed67f8f22f11d5730147cd907d66a08 
>   src/master/allocator/mesos/hierarchical.cpp 
> df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f 
>   src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
>   src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305 
>   src/slave/containerizer/containerizer.hpp 
> 6964d136818ea9904fa35cd778eb9ef19e2c64fc 
>   src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c 
> 
> Diff: https://reviews.apache.org/r/41649/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 41550: [5/5] Quota Authorization: Added tests for quota removal authorization.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41550/#review113064
---

Ship it!


Thanks for holding on till the end, almost there!


src/tests/master_quota_tests.cpp (line 1206)


s/and that/while



src/tests/master_quota_tests.cpp (line 1243)


There is no agent any more, right : )? How about
"A request can contain any amount of resources because we set the force 
flag."



src/tests/master_quota_tests.cpp (line 1261)


Same here.



src/tests/master_quota_tests.cpp (lines 1355 - 1357)


Please prepend the block with a comment as discussed in the previous review.



src/tests/master_quota_tests.cpp (lines 1373 - 1375)


Move the comment before the block, please


- Alexander Rukletsov


On Jan. 6, 2016, 1:15 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41550/
> ---
> 
> (Updated Jan. 6, 2016, 1:15 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Till Toenshoff.
> 
> 
> Bugs: MESOS-4083
> https://issues.apache.org/jira/browse/MESOS-4083
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Quota Authorization: Added tests for quota removal authorization.
> 
> 
> Diffs
> -
> 
>   src/tests/authorization_tests.cpp 1d11a02032c142455debd9c78d4ee4cc6297a350 
>   src/tests/master_quota_tests.cpp 81f0386d072d0176cb28eb229b274e424004f54c 
> 
> Diff: https://reviews.apache.org/r/41550/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 41550: [5/5] Quota Authorization: Added tests for quota removal authorization.

2016-01-06 Thread Till Toenshoff


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41550/#review113067
---

Ship it!


Ship It!

- Till Toenshoff


On Jan. 6, 2016, 1:15 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41550/
> ---
> 
> (Updated Jan. 6, 2016, 1:15 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Till Toenshoff.
> 
> 
> Bugs: MESOS-4083
> https://issues.apache.org/jira/browse/MESOS-4083
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Quota Authorization: Added tests for quota removal authorization.
> 
> 
> Diffs
> -
> 
>   src/tests/authorization_tests.cpp 1d11a02032c142455debd9c78d4ee4cc6297a350 
>   src/tests/master_quota_tests.cpp 81f0386d072d0176cb28eb229b274e424004f54c 
> 
> Diff: https://reviews.apache.org/r/41550/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 41857: [MESOS-3892] get evictable executors


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41857/
---

(Updated Jan. 6, 2016, 8:41 p.m.)


Review request for mesos and Guangya Liu.


Changes
---

Add `idle` for the allocation slack which's not used by others.


Summary (updated)
-

[MESOS-3892] get evictable executors


Bugs: MESOS-3892
https://issues.apache.org/jira/browse/MESOS-3892


Repository: mesos


Description
---

get evictable executors


Diffs (updated)
-

  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c 

Diff: https://reviews.apache.org/r/41857/diff/


Testing
---


Thanks,

Klaus Ma

Re: Review Request 41857: [MESOS-3892] get evictable executors


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41857/
---

(Updated Jan. 6, 2016, 8:41 p.m.)


Review request for mesos and Guangya Liu.


Changes
---

Add `idle` for the allocation slack which's not used by others.


Summary (updated)
-

[MESOS-3892] get evictable executors


Bugs: MESOS-3892
https://issues.apache.org/jira/browse/MESOS-3892


Repository: mesos


Description
---

get evictable executors


Diffs (updated)
-

  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c 

Diff: https://reviews.apache.org/r/41857/diff/


Testing
---


Thanks,

Klaus Ma

Re: Review Request 41550: Quota: Added tests for quota removal authorization.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41550/
---

(Updated Jan. 6, 2016, 2:11 p.m.)


Review request for mesos, Alexander Rukletsov and Till Toenshoff.


Summary (updated)
-

Quota: Added tests for quota removal authorization.


Bugs: MESOS-4083
https://issues.apache.org/jira/browse/MESOS-4083


Repository: mesos


Description (updated)
---

see summary.


Diffs
-

  src/tests/authorization_tests.cpp 1d11a02032c142455debd9c78d4ee4cc6297a350 
  src/tests/master_quota_tests.cpp 81f0386d072d0176cb28eb229b274e424004f54c 

Diff: https://reviews.apache.org/r/41550/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 41857: [WIP][MESOS-3892] get evictable executors


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41857/
---

(Updated Jan. 6, 2016, 8:42 p.m.)


Review request for mesos and Guangya Liu.


Summary (updated)
-

[WIP][MESOS-3892] get evictable executors


Bugs: MESOS-3892
https://issues.apache.org/jira/browse/MESOS-3892


Repository: mesos


Description
---

get evictable executors


Diffs
-

  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c 

Diff: https://reviews.apache.org/r/41857/diff/


Testing
---


Thanks,

Klaus Ma

Re: Review Request 41550: [5/5] Quota Authorization: Added tests for quota removal authorization.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41550/
---

(Updated Jan. 6, 2016, 2:15 p.m.)


Review request for mesos, Alexander Rukletsov and Till Toenshoff.


Changes
---

Addressed issues.


Bugs: MESOS-4083
https://issues.apache.org/jira/browse/MESOS-4083


Repository: mesos


Description
---

Quota Authorization: Added tests for quota removal authorization.


Diffs (updated)
-

  src/tests/authorization_tests.cpp 1d11a02032c142455debd9c78d4ee4cc6297a350 
  src/tests/master_quota_tests.cpp 81f0386d072d0176cb28eb229b274e424004f54c 

Diff: https://reviews.apache.org/r/41550/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 39923: Cleaned up configuration.md.



> On 一月 6, 2016, 12:26 a.m., Neil Conway wrote:
> > This introduces some inconsistencies between the text in `configuration.md` 
> > and the content of the various `flags.cpp` files (first thing I checked: 
> > "api" still appears in `src/logging/flags.cpp` but we now use "API" in 
> > `configuration.md`; likely other instances as well).
> 
> Guangya Liu wrote:
> @Neil, please refer to https://reviews.apache.org/r/41933/ , all of the 
> issues you mentioned are being fixed there.

@Neil, just filed a new JIRA ticket to trace those issues 
https://issues.apache.org/jira/browse/MESOS-4298 , the 
https://reviews.apache.org/r/41933/ is only handling authorizer part.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39923/#review112974
---


On 一月 5, 2016, 7:53 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39923/
> ---
> 
> (Updated 一月 5, 2016, 7:53 p.m.)
> 
> 
> Review request for mesos, Jojy Varghese, Joris Van Remoortere, Kapil Arya, 
> and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Edited configuration.md for style and consistency. Made consistent use of 
>  for commands, flags, and flag values. Edited the libprocess 
> flags for consistency and proper use of `=DIR` or `[=DIR]` depending on 
> whether or not the directory is an optional parameter. Note that the 
> libprocess `--with-*` flags have two different descriptions depending upon 
> whether or not the library is bundled with Mesos.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md a33e802a3ff1246d25f52b15da7905c5b22e339d 
> 
> Diff: https://reviews.apache.org/r/39923/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the mesos website container 
> (https://github.com/mesosphere/mesos-website-container).
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 41550: Quota: Added tests for quota removal authorization.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41550/
---

(Updated Jan. 6, 2016, 3:34 p.m.)


Review request for mesos, Alexander Rukletsov and Till Toenshoff.


Changes
---

Addressed issues.


Bugs: MESOS-4083
https://issues.apache.org/jira/browse/MESOS-4083


Repository: mesos


Description
---

see summary.


Diffs (updated)
-

  src/tests/authorization_tests.cpp 1d11a02032c142455debd9c78d4ee4cc6297a350 
  src/tests/master_quota_tests.cpp 81f0386d072d0176cb28eb229b274e424004f54c 

Diff: https://reviews.apache.org/r/41550/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 41547: Quota: Implemented authorization of "remove quota" requests in the authorizer.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41547/
---

(Updated Jan. 6, 2016, 2:37 p.m.)


Review request for mesos, Alexander Rukletsov and Till Toenshoff.


Summary (updated)
-

Quota: Implemented authorization of "remove quota" requests in the authorizer.


Bugs: MESOS-4081
https://issues.apache.org/jira/browse/MESOS-4081


Repository: mesos


Description
---

Quota Authorization: Implemented authorization of "remove quota" requests in 
the authorizer.


Diffs
-

  include/mesos/authorizer/authorizer.hpp 
f61613948b7b5c5c2118f1782a0c5f8ff7e8e057 
  src/authorizer/local/authorizer.hpp 1563c11709c2612350354690b50ceb33d2720f98 
  src/authorizer/local/authorizer.cpp 1d135fb6906c7050a788cbac9ca2d8164ff064ef 
  src/tests/mesos.hpp a4811b0d8dee33ff2ca4968f532ce64b7ea95249 
  src/tests/mesos.cpp f4b0f82449c4b6a2b4b7b7f14518714485d5a13a 

Diff: https://reviews.apache.org/r/41547/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 41859: [WIP][MESOS-4265] launch tasks after evicting executors


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41859/
---

(Updated Jan. 6, 2016, 11:26 p.m.)


Review request for mesos and Guangya Liu.


Changes
---

rebase


Bugs: MESOS-4265
https://issues.apache.org/jira/browse/MESOS-4265


Repository: mesos


Description
---

launch tasks after evicting executors


Diffs (updated)
-

  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f 

Diff: https://reviews.apache.org/r/41859/diff/


Testing
---


Thanks,

Klaus Ma

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39043/
---

(Updated Jan. 6, 2016, 4:27 p.m.)


Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, Jan Schlicht, 
and Till Toenshoff.


Changes
---

Jan's review.


Bugs: MESOS-3756
https://issues.apache.org/jira/browse/MESOS-3756


Repository: mesos


Description
---

1. Adds a flag to load an HTTP Authenticator module from the flags.
2. If provided, uses the credentials file to initialize the default HTTP 
Authenticator.
3. Updates the existing endpoints which implement their own basic HTTP 
authenticator with the libprocess one.
4. Updates one test which expected the wrong results since now credentials are 
checked before the body of the request.


Diffs (updated)
-

  include/mesos/authentication/http/basic_authenticator_factory.hpp 
PRE-CREATION 
  src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION 
  src/master/constants.hpp f1624e1ed5091f08f57d4382b344cab8b05ba840 
  src/master/constants.cpp 589f2ee55a24d7e8b9352a4c8f94a3785fd1bef4 
  src/master/flags.hpp 9af6c68eef6bcf39d5776809fab6c66dc95da6b2 
  src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d 
  src/master/http.cpp d7afa2af989eebfc9039b3681f087ce570f601d5 
  src/master/master.hpp 2936d32c5e7b5b944bf16a1f261c7c54179900ec 
  src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
  src/master/quota_handler.cpp ac4da74686f524a66745b4a4e038c3d703ea1ee9 
  src/tests/master_quota_tests.cpp 81f0386d072d0176cb28eb229b274e424004f54c 
  src/tests/mesos.cpp 082e57bc73fad02de77e16e4b34451e6c0903038 
  src/tests/persistent_volume_endpoints_tests.cpp 
f0cce190abc90f0fae84d6c3db20e8215c2d8132 

Diff: https://reviews.apache.org/r/39043/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.



> On Jan. 6, 2016, 3:45 p.m., Jan Schlicht wrote:
> > src/master/constants.hpp, line 137
> > 
> >
> > s/mesos/Mesos

The string there is the actual value of the string, which is "mesos". That is 
the pattern in this file. I'll drop it now, but if you feel like it should be 
otherwise, please reopen.


> On Jan. 6, 2016, 3:45 p.m., Jan Schlicht wrote:
> > src/master/http.cpp, line 606
> > 
> >
> > You're changing this to `Forbidden()` here and in 
> > `Master::Http::destroyVolumes`, which has to do with RFC-2616. If this is 
> > the right way to respond to a failed authorization, you should also 
> > implement it that way for the other code paths that deal with 
> > authorization. It might be better to leave it be for now and create a 
> > separate JIRA for that?

I updated them all right now. Let's see what the author thinks.


> On Jan. 6, 2016, 3:45 p.m., Jan Schlicht wrote:
> > src/master/quota_handler.cpp, line 50
> > 
> >
> > `Forbidden` isn't used in this file.

It is now.


> On Jan. 6, 2016, 3:45 p.m., Jan Schlicht wrote:
> > src/master/quota_handler.cpp, line 349
> > 
> >
> > See my comment re `Unauthorized` & `Forbidden` above. This would have 
> > to be changed to `Forbidden` to be consistent with the change in 
> > `Master::Http::createVolumes`.

I changed to `Forbidden`. Though if the authors insist, I will change it back. 
It is my opinion that only the authorizer should return `Unauthorized`.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39043/#review113065
---


On Jan. 6, 2016, 3:44 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39043/
> ---
> 
> (Updated Jan. 6, 2016, 3:44 p.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, Jan 
> Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3756
> https://issues.apache.org/jira/browse/MESOS-3756
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> 1. Adds a flag to load an HTTP Authenticator module from the flags.
> 2. If provided, uses the credentials file to initialize the default HTTP 
> Authenticator.
> 3. Updates the existing endpoints which implement their own basic HTTP 
> authenticator with the libprocess one.
> 4. Updates one test which expected the wrong results since now credentials 
> are checked before the body of the request.
> 
> 
> Diffs
> -
> 
>   include/mesos/authentication/http/basic_authenticator_factory.hpp 
> PRE-CREATION 
>   src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION 
>   src/master/constants.hpp f1624e1ed5091f08f57d4382b344cab8b05ba840 
>   src/master/constants.cpp 589f2ee55a24d7e8b9352a4c8f94a3785fd1bef4 
>   src/master/flags.hpp 9af6c68eef6bcf39d5776809fab6c66dc95da6b2 
>   src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d 
>   src/master/http.cpp d7afa2af989eebfc9039b3681f087ce570f601d5 
>   src/master/master.hpp 2936d32c5e7b5b944bf16a1f261c7c54179900ec 
>   src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
>   src/master/quota_handler.cpp ac4da74686f524a66745b4a4e038c3d703ea1ee9 
>   src/tests/master_quota_tests.cpp 81f0386d072d0176cb28eb229b274e424004f54c 
>   src/tests/mesos.cpp 082e57bc73fad02de77e16e4b34451e6c0903038 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> f0cce190abc90f0fae84d6c3db20e8215c2d8132 
> 
> Diff: https://reviews.apache.org/r/39043/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 41932: Updated "teardown_framework" requests in the authorizer.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41932/#review113076
---


Patch looks great!

Reviews applied: [41933, 41930, 41932]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 6, 2016, 2:36 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41932/
> ---
> 
> (Updated Jan. 6, 2016, 2:36 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-4154
> https://issues.apache.org/jira/browse/MESOS-4154
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See Summary.
> 
> 
> Diffs
> -
> 
>   src/authorizer/local/authorizer.cpp 
> 1d135fb6906c7050a788cbac9ca2d8164ff064ef 
>   src/tests/teardown_tests.cpp 97cc89ba168aefff8512f6d1a25c4f7ddf180bae 
> 
> Diff: https://reviews.apache.org/r/41932/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Review Request 41979: Updated document for teardown_frameworks.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41979/
---

Review request for mesos and Adam B.


Bugs: MESOS-4154
https://issues.apache.org/jira/browse/MESOS-4154


Repository: mesos


Description
---

Updated document for teardown_frameworks.


Diffs
-

  docs/authorization.md 900922855723581f4f7b77ecbc2fd3dbbd33e572 
  docs/configuration.md fb6f6784e5d11850ba0bafaeafa3213a1038e6b4 
  src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d 

Diff: https://reviews.apache.org/r/41979/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.



> On Jan. 6, 2016, 3:45 p.m., Jan Schlicht wrote:
> > src/master/http.cpp, line 606
> > 
> >
> > You're changing this to `Forbidden()` here and in 
> > `Master::Http::destroyVolumes`, which has to do with RFC-2616. If this is 
> > the right way to respond to a failed authorization, you should also 
> > implement it that way for the other code paths that deal with 
> > authorization. It might be better to leave it be for now and create a 
> > separate JIRA for that?
> 
> Alexander Rojas wrote:
> I updated them all right now. Let's see what the author thinks.

`Master::Http::reserve`, `Master::Http::teardown` and `Master::Http::unreserve` 
use authorization and would also be affected. Also 
`Master::QuotaHandler::remove` will get an authorization soon-ish and might be 
affected after a rebase.


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39043/#review113065
---


On Jan. 6, 2016, 4:27 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39043/
> ---
> 
> (Updated Jan. 6, 2016, 4:27 p.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, Jan 
> Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3756
> https://issues.apache.org/jira/browse/MESOS-3756
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> 1. Adds a flag to load an HTTP Authenticator module from the flags.
> 2. If provided, uses the credentials file to initialize the default HTTP 
> Authenticator.
> 3. Updates the existing endpoints which implement their own basic HTTP 
> authenticator with the libprocess one.
> 4. Updates one test which expected the wrong results since now credentials 
> are checked before the body of the request.
> 
> 
> Diffs
> -
> 
>   include/mesos/authentication/http/basic_authenticator_factory.hpp 
> PRE-CREATION 
>   src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION 
>   src/master/constants.hpp f1624e1ed5091f08f57d4382b344cab8b05ba840 
>   src/master/constants.cpp 589f2ee55a24d7e8b9352a4c8f94a3785fd1bef4 
>   src/master/flags.hpp 9af6c68eef6bcf39d5776809fab6c66dc95da6b2 
>   src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d 
>   src/master/http.cpp d7afa2af989eebfc9039b3681f087ce570f601d5 
>   src/master/master.hpp 2936d32c5e7b5b944bf16a1f261c7c54179900ec 
>   src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
>   src/master/quota_handler.cpp ac4da74686f524a66745b4a4e038c3d703ea1ee9 
>   src/tests/master_quota_tests.cpp 81f0386d072d0176cb28eb229b274e424004f54c 
>   src/tests/mesos.cpp 082e57bc73fad02de77e16e4b34451e6c0903038 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> f0cce190abc90f0fae84d6c3db20e8215c2d8132 
> 
> Diff: https://reviews.apache.org/r/39043/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 41546: Quota: Added "RemoveQuota" message to ACL protobuf.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41546/
---

(Updated Jan. 6, 2016, 2:38 p.m.)


Review request for mesos, Alexander Rukletsov and Till Toenshoff.


Summary (updated)
-

Quota: Added "RemoveQuota" message to ACL protobuf.


Bugs: MESOS-4081
https://issues.apache.org/jira/browse/MESOS-4081


Repository: mesos


Description
---

Quota Authorization: Added "RemoveQuota" message to ACL protobuf.


Diffs
-

  include/mesos/authorizer/authorizer.proto 
7b729e19484d92be48bbde4dff2c833a4109936e 

Diff: https://reviews.apache.org/r/41546/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 41547: Quota: Implemented authorization of "remove quota" requests.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41547/
---

(Updated Jan. 6, 2016, 2:39 p.m.)


Review request for mesos, Alexander Rukletsov and Till Toenshoff.


Summary (updated)
-

Quota: Implemented authorization of "remove quota" requests.


Bugs: MESOS-4081
https://issues.apache.org/jira/browse/MESOS-4081


Repository: mesos


Description
---

Quota Authorization: Implemented authorization of "remove quota" requests in 
the authorizer.


Diffs
-

  include/mesos/authorizer/authorizer.hpp 
f61613948b7b5c5c2118f1782a0c5f8ff7e8e057 
  src/authorizer/local/authorizer.hpp 1563c11709c2612350354690b50ceb33d2720f98 
  src/authorizer/local/authorizer.cpp 1d135fb6906c7050a788cbac9ca2d8164ff064ef 
  src/tests/mesos.hpp a4811b0d8dee33ff2ca4968f532ce64b7ea95249 
  src/tests/mesos.cpp f4b0f82449c4b6a2b4b7b7f14518714485d5a13a 

Diff: https://reviews.apache.org/r/41547/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 40379: MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40379/
---

(Updated Jan. 6, 2016, 11:30 p.m.)


Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van 
Remoortere, Joseph Wu, and Jian Qiu.


Changes
---

Update dependency


Bugs: MESOS-3930
https://issues.apache.org/jira/browse/MESOS-3930


Repository: mesos


Description
---

In Optimistic Offer Phase 1, it introduce `RevocableInfo::type`: USAGE_SLACK 
for Oversubscription and ALLOCATION_SLACK for Optimistic Offer. Slave helps to 
update `RevocableInfo::type` for Oversubscription.


Diffs
-

  include/mesos/slave/resource_estimator.hpp 27612ca 
  src/slave/slave.cpp 9d80c96 

Diff: https://reviews.apache.org/r/40379/diff/


Testing
---

make (make check is on-going)


Thanks,

Klaus Ma

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39043/
---

(Updated Jan. 6, 2016, 3:44 p.m.)


Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, Jan Schlicht, 
and Till Toenshoff.


Changes
---

Remove use of deprecated `Unauthorized` constructor. Unauthorized request 
should return `Forbidden`.


Bugs: MESOS-3756
https://issues.apache.org/jira/browse/MESOS-3756


Repository: mesos


Description
---

1. Adds a flag to load an HTTP Authenticator module from the flags.
2. If provided, uses the credentials file to initialize the default HTTP 
Authenticator.
3. Updates the existing endpoints which implement their own basic HTTP 
authenticator with the libprocess one.
4. Updates one test which expected the wrong results since now credentials are 
checked before the body of the request.


Diffs (updated)
-

  include/mesos/authentication/http/basic_authenticator_factory.hpp 
PRE-CREATION 
  src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION 
  src/master/constants.hpp f1624e1ed5091f08f57d4382b344cab8b05ba840 
  src/master/constants.cpp 589f2ee55a24d7e8b9352a4c8f94a3785fd1bef4 
  src/master/flags.hpp 9af6c68eef6bcf39d5776809fab6c66dc95da6b2 
  src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d 
  src/master/http.cpp d7afa2af989eebfc9039b3681f087ce570f601d5 
  src/master/master.hpp 2936d32c5e7b5b944bf16a1f261c7c54179900ec 
  src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
  src/master/quota_handler.cpp ac4da74686f524a66745b4a4e038c3d703ea1ee9 
  src/tests/master_quota_tests.cpp 81f0386d072d0176cb28eb229b274e424004f54c 
  src/tests/mesos.cpp 082e57bc73fad02de77e16e4b34451e6c0903038 
  src/tests/persistent_volume_endpoints_tests.cpp 
f0cce190abc90f0fae84d6c3db20e8215c2d8132 

Diff: https://reviews.apache.org/r/39043/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39043/#review113065
---



include/mesos/authentication/http/basic_authenticator_factory.hpp (line 41)


4 spaces instead of 2.



src/master/constants.hpp (line 137)


s/mesos/Mesos



src/master/http.cpp (line 598)


You're changing this to `Forbidden()` here and in 
`Master::Http::destroyVolumes`, which has to do with RFC-2616. If this is the 
right way to respond to a failed authorization, you should also implement it 
that way for the other code paths that deal with authorization. It might be 
better to leave it be for now and create a separate JIRA for that?



src/master/quota_handler.cpp (line 50)


`Forbidden` isn't used in this file.



src/master/quota_handler.cpp (line 339)


See my comment re `Unauthorized` & `Forbidden` above. This would have to be 
changed to `Forbidden` to be consistent with the change in 
`Master::Http::createVolumes`.


- Jan Schlicht


On Jan. 6, 2016, 3:44 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39043/
> ---
> 
> (Updated Jan. 6, 2016, 3:44 p.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, Jan 
> Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3756
> https://issues.apache.org/jira/browse/MESOS-3756
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> 1. Adds a flag to load an HTTP Authenticator module from the flags.
> 2. If provided, uses the credentials file to initialize the default HTTP 
> Authenticator.
> 3. Updates the existing endpoints which implement their own basic HTTP 
> authenticator with the libprocess one.
> 4. Updates one test which expected the wrong results since now credentials 
> are checked before the body of the request.
> 
> 
> Diffs
> -
> 
>   include/mesos/authentication/http/basic_authenticator_factory.hpp 
> PRE-CREATION 
>   src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION 
>   src/master/constants.hpp f1624e1ed5091f08f57d4382b344cab8b05ba840 
>   src/master/constants.cpp 589f2ee55a24d7e8b9352a4c8f94a3785fd1bef4 
>   src/master/flags.hpp 9af6c68eef6bcf39d5776809fab6c66dc95da6b2 
>   src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d 
>   src/master/http.cpp d7afa2af989eebfc9039b3681f087ce570f601d5 
>   src/master/master.hpp 2936d32c5e7b5b944bf16a1f261c7c54179900ec 
>   src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
>   src/master/quota_handler.cpp ac4da74686f524a66745b4a4e038c3d703ea1ee9 
>   src/tests/master_quota_tests.cpp 81f0386d072d0176cb28eb229b274e424004f54c 
>   src/tests/mesos.cpp 082e57bc73fad02de77e16e4b34451e6c0903038 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> f0cce190abc90f0fae84d6c3db20e8215c2d8132 
> 
> Diff: https://reviews.apache.org/r/39043/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 41856: [WIP][MESOS-3892] helper functions to get allocation slack


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41856/
---

(Updated Jan. 6, 2016, 11:10 p.m.)


Review request for mesos and Guangya Liu.


Changes
---

rebase


Bugs: MESOS-3892
https://issues.apache.org/jira/browse/MESOS-3892


Repository: mesos


Description
---

helper functions to get allocation slack


Diffs (updated)
-

  include/mesos/resources.hpp cc8fef9470d779078aa408ed03e747e5a492deaa 
  include/mesos/v1/resources.hpp f4892977f8d7b0439db6e9cf7921334f606a496c 
  src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4 
  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f 
  src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc 

Diff: https://reviews.apache.org/r/41856/diff/


Testing
---


Thanks,

Klaus Ma

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

2016-01-06 Thread Bernd Mathiske



> On Jan. 6, 2016, 6:45 a.m., Jan Schlicht wrote:
> > src/master/constants.hpp, line 137
> > 
> >
> > s/mesos/Mesos
> 
> Alexander Rojas wrote:
> The string there is the actual value of the string, which is "mesos". 
> That is the pattern in this file. I'll drop it now, but if you feel like it 
> should be otherwise, please reopen.

Aha. Then I'd suggest writing either of these:
- "mesos"
- Mesos


- Bernd


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39043/#review113065
---


On Jan. 6, 2016, 7:27 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39043/
> ---
> 
> (Updated Jan. 6, 2016, 7:27 a.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, Jan 
> Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3756
> https://issues.apache.org/jira/browse/MESOS-3756
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> 1. Adds a flag to load an HTTP Authenticator module from the flags.
> 2. If provided, uses the credentials file to initialize the default HTTP 
> Authenticator.
> 3. Updates the existing endpoints which implement their own basic HTTP 
> authenticator with the libprocess one.
> 4. Updates one test which expected the wrong results since now credentials 
> are checked before the body of the request.
> 
> 
> Diffs
> -
> 
>   include/mesos/authentication/http/basic_authenticator_factory.hpp 
> PRE-CREATION 
>   src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION 
>   src/master/constants.hpp f1624e1ed5091f08f57d4382b344cab8b05ba840 
>   src/master/constants.cpp 589f2ee55a24d7e8b9352a4c8f94a3785fd1bef4 
>   src/master/flags.hpp 9af6c68eef6bcf39d5776809fab6c66dc95da6b2 
>   src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d 
>   src/master/http.cpp d7afa2af989eebfc9039b3681f087ce570f601d5 
>   src/master/master.hpp 2936d32c5e7b5b944bf16a1f261c7c54179900ec 
>   src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
>   src/master/quota_handler.cpp ac4da74686f524a66745b4a4e038c3d703ea1ee9 
>   src/tests/master_quota_tests.cpp 81f0386d072d0176cb28eb229b274e424004f54c 
>   src/tests/mesos.cpp 082e57bc73fad02de77e16e4b34451e6c0903038 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> f0cce190abc90f0fae84d6c3db20e8215c2d8132 
> 
> Diff: https://reviews.apache.org/r/39043/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39043/#review113108
---


Bad patch!

Reviews applied: [40539, 37999, 38000, 38094, 38950, 39043]

Failed command: ./support/apply-review.sh -n -r 39043

Error:
 2016-01-06 18:42:26 URL:https://reviews.apache.org/r/39043/diff/raw/ 
[29169/29169] -> "39043.patch" [1]
error: patch failed: src/master/quota_handler.cpp:337
error: src/master/quota_handler.cpp: patch does not apply
error: patch failed: src/tests/master_quota_tests.cpp:1341
error: src/tests/master_quota_tests.cpp: patch does not apply

- Mesos ReviewBot


On Jan. 6, 2016, 3:27 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39043/
> ---
> 
> (Updated Jan. 6, 2016, 3:27 p.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, Jan 
> Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3756
> https://issues.apache.org/jira/browse/MESOS-3756
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> 1. Adds a flag to load an HTTP Authenticator module from the flags.
> 2. If provided, uses the credentials file to initialize the default HTTP 
> Authenticator.
> 3. Updates the existing endpoints which implement their own basic HTTP 
> authenticator with the libprocess one.
> 4. Updates one test which expected the wrong results since now credentials 
> are checked before the body of the request.
> 
> 
> Diffs
> -
> 
>   include/mesos/authentication/http/basic_authenticator_factory.hpp 
> PRE-CREATION 
>   src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION 
>   src/master/constants.hpp f1624e1ed5091f08f57d4382b344cab8b05ba840 
>   src/master/constants.cpp 589f2ee55a24d7e8b9352a4c8f94a3785fd1bef4 
>   src/master/flags.hpp 9af6c68eef6bcf39d5776809fab6c66dc95da6b2 
>   src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d 
>   src/master/http.cpp d7afa2af989eebfc9039b3681f087ce570f601d5 
>   src/master/master.hpp 2936d32c5e7b5b944bf16a1f261c7c54179900ec 
>   src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
>   src/master/quota_handler.cpp ac4da74686f524a66745b4a4e038c3d703ea1ee9 
>   src/tests/master_quota_tests.cpp 81f0386d072d0176cb28eb229b274e424004f54c 
>   src/tests/mesos.cpp 082e57bc73fad02de77e16e4b34451e6c0903038 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> f0cce190abc90f0fae84d6c3db20e8215c2d8132 
> 
> Diff: https://reviews.apache.org/r/39043/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 41963: Logger Module: Implement ContainerLogger recovery.

2016-01-06 Thread Jojy Varghese


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41963/#review113117
---



src/slave/containerizer/docker.cpp (line 701)


Do you need all the variables on the stack to be passed to the capture? 
Maybe just executorInfo ?


- Jojy Varghese


On Jan. 6, 2016, 2:19 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41963/
> ---
> 
> (Updated Jan. 6, 2016, 2:19 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-4150
> https://issues.apache.org/jira/browse/MESOS-4150
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds a call to `ContainerLogger::recover` inside each containerizer's 
> `Containerizer::recover`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp aacf90f2cb6c08f94340936d29b2df513ac9825a 
>   src/slave/containerizer/mesos/containerizer.cpp 
> f3c370aeb331beb6202fd30cd0278877da0b42e0 
> 
> Diff: https://reviews.apache.org/r/41963/diff/
> 
> 
> Testing
> ---
> 
> make check (OSX & Centos7)
> 
> sudo bin/mesos-tests.sh --gtest_filter="*ROOT*" (Centos7)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Review Request 41989: Added docs for persistent volume endpoint authorization.

2016-01-06 Thread Greg Mann


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41989/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-3903
https://issues.apache.org/jira/browse/MESOS-3903


Repository: mesos


Description
---

Added docs for persistent volume endpoint authorization.


Diffs
-

  docs/authorization.md 900922855723581f4f7b77ecbc2fd3dbbd33e572 
  docs/persistent-volume.md 766e62a497558692f3df89a0e666c9d96c6c0fcb 

Diff: https://reviews.apache.org/r/41989/diff/


Testing
---


Thanks,

Greg Mann

Re: Review Request 41979: Updated document for teardown_frameworks.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41979/#review113091
---


Patch looks great!

Reviews applied: [41933, 41930, 41932, 41979]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 6, 2016, 3:23 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41979/
> ---
> 
> (Updated Jan. 6, 2016, 3:23 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-4154
> https://issues.apache.org/jira/browse/MESOS-4154
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated document for teardown_frameworks.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md 900922855723581f4f7b77ecbc2fd3dbbd33e572 
>   docs/configuration.md fb6f6784e5d11850ba0bafaeafa3213a1038e6b4 
>   src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d 
> 
> Diff: https://reviews.apache.org/r/41979/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 41859: [WIP][MESOS-4265] launch tasks after evicting executors


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41859/#review113101
---


Bad patch!

Reviews applied: [40375, 41334, 41333, 40529, 41772, 40339]

Failed command: ./support/apply-review.sh -n -r 40339

Error:
 2016-01-06 18:15:08 URL:https://reviews.apache.org/r/40339/diff/raw/ 
[27381/27381] -> "40339.patch" [1]
error: patch failed: src/tests/master_quota_tests.cpp:
error: src/tests/master_quota_tests.cpp: patch does not apply

- Mesos ReviewBot


On Jan. 6, 2016, 3:26 p.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41859/
> ---
> 
> (Updated Jan. 6, 2016, 3:26 p.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-4265
> https://issues.apache.org/jira/browse/MESOS-4265
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> launch tasks after evicting executors
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
>   src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f 
> 
> Diff: https://reviews.apache.org/r/41859/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Review Request 41986: Fixed race in persistent volume tests.

2016-01-06 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41986/
---

Review request for mesos, Alexander Rukletsov, Jie Yu, and Michael Park.

Bugs: MESOS-4208
https://issues.apache.org/jira/browse/MESOS-4208

Repository: mesos

Description
---

Fixed race in persistent volume tests. This race occurred because
`scheduelerDriver.reviveOffers` will trigger an offer immediately, while the
tests originally assumed that settling and advancing the clock after reviving
was necessary to produce an offer.

Diffs
-

src/tests/persistent_volume_tests.cpp
2fb57814b2805bc76981d1877603a1a033f29289

Diff: https://reviews.apache.org/r/41986/diff/

Testing
---

In order to reproduce this bug, insert a short sleep onto line 1204 or line
1402 of `src/tests/persistent_volume_tests.cpp` - note that these line numbers
refer to the file *before* applying this patch.

The race is due to the fact that calling `reviveOffers` triggers a new offer,
while the code is assuming that the clock must be settled and advanced before
an offer will be sent. Thus, the offer may arrive before the `EXPECT_CALL` is
executed, causing a previous `EXPECT_CALL` to be triggered more times than
expected.

By calling `EXPECT_CALL` before `reviveOffers`, this race is avoided. The
unnecessary `Clock:settle` and `Clock::advance` calls have been removed as well.

To test,
`GTEST_FILTER="PersistentVolumeTest.BadACLDropCreateAndDestroy:PersistentVolumeTest.BadACLNoPrincipal"
bin/mesos-tests.sh` was run both with and without `sleep(1);` inserted before
the relevant `EXPECT_CALL`s.

Thanks,

Greg Mann

Re: Review Request 41550: Quota: Added tests for quota removal authorization.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41550/#review113085
---


Patch looks great!

Reviews applied: [41546, 41547, 41548, 41549, 41550]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 6, 2016, 2:34 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41550/
> ---
> 
> (Updated Jan. 6, 2016, 2:34 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Till Toenshoff.
> 
> 
> Bugs: MESOS-4083
> https://issues.apache.org/jira/browse/MESOS-4083
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> see summary.
> 
> 
> Diffs
> -
> 
>   src/tests/authorization_tests.cpp 1d11a02032c142455debd9c78d4ee4cc6297a350 
>   src/tests/master_quota_tests.cpp 81f0386d072d0176cb28eb229b274e424004f54c 
> 
> Diff: https://reviews.apache.org/r/41550/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 40546: Fixed framework CPU counters on slave page.

2016-01-06 Thread Till Toenshoff


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40546/#review113084
---


I will go ahead and discard this review as it is no longer needed - 
https://reviews.apache.org/r/41927/ fixed the problem in a preferred way.

Thanks for your submission, Ian!

- Till Toenshoff


On Jan. 4, 2016, 3:43 a.m., Ian Babrou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40546/
> ---
> 
> (Updated Jan. 4, 2016, 3:43 a.m.)
> 
> 
> Review request for mesos, Jan Schlicht and Till Toenshoff.
> 
> 
> Bugs: MESOS-3972
> https://issues.apache.org/jira/browse/MESOS-3972
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> see summary
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/slave.html a1446bce827944609faf10f72e788f33d275d6f9 
> 
> Diff: https://reviews.apache.org/r/40546/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ian Babrou
> 
>

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39043/
---

(Updated Jan. 6, 2016, 9:03 a.m.)


Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, Jan Schlicht, 
and Till Toenshoff.


Changes
---

Ortographic corrections.


Bugs: MESOS-3756
https://issues.apache.org/jira/browse/MESOS-3756


Repository: mesos


Description
---

1. Adds a flag to load an HTTP Authenticator module from the flags.
2. If provided, uses the credentials file to initialize the default HTTP 
Authenticator.
3. Updates the existing endpoints which implement their own basic HTTP 
authenticator with the libprocess one.
4. Updates one test which expected the wrong results since now credentials are 
checked before the body of the request.


Diffs (updated)
-

  include/mesos/authentication/http/basic_authenticator_factory.hpp 
PRE-CREATION 
  src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION 
  src/master/constants.hpp f1624e1ed5091f08f57d4382b344cab8b05ba840 
  src/master/constants.cpp 589f2ee55a24d7e8b9352a4c8f94a3785fd1bef4 
  src/master/flags.hpp 9af6c68eef6bcf39d5776809fab6c66dc95da6b2 
  src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d 
  src/master/http.cpp deb0c8f9852dc0eec1e8c0ff35c684f982e8b110 
  src/master/master.hpp 1cc5531de70bdc0bdce9835c4930dc774406fac9 
  src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
  src/master/quota_handler.cpp 1d84ef5767b3cb7cf870dd184aa2d9f030919498 
  src/tests/mesos.cpp f4b0f82449c4b6a2b4b7b7f14518714485d5a13a 

Diff: https://reviews.apache.org/r/39043/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/#review113094
---

Ship it!


A few comment suggestions, but otherwise LGTM.


include/mesos/mesos.proto (line 661)


s/that controlled/controlled/



include/mesos/mesos.proto (lines 661 - 662)


s/by oversubscription for allocations (QoSController & 
ResourceEstimator)/by the `QoSController` and `ResourceEstimator`/

s/`ResourceEstimator`/The `ResourceEstimator`/



include/mesos/mesos.proto (line 663)


s/marks allocated by not used resources/marks resources that are allocated 
but not utilized/



include/mesos/mesos.proto (line 667)


s/that controlled/controlled/



include/mesos/mesos.proto (lines 667 - 668)


s/by oversubscription for reservations (Allocator)/by the allocator, when 
oversubscription for reservations is enabled/



include/mesos/mesos.proto (lines 668 - 669)


s/reserved by not allocated resources/resources that are reserved but not 
allocated/


- Joseph Wu


On Dec. 12, 2015, 7:19 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40375/
> ---
> 
> (Updated Dec. 12, 2015, 7:19 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3888
> https://issues.apache.org/jira/browse/MESOS-3888
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3888: We need to distinguish revocable resource for usage slack and 
> allocation slack.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 8ca2130 
>   include/mesos/v1/mesos.proto 8f357b0 
>   src/common/resources.cpp 5a79817 
>   src/tests/resources_tests.cpp ce47bac 
>   src/v1/resources.cpp d300842 
> 
> Diff: https://reviews.apache.org/r/40375/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 41657: Added user facing documentation for containerizers.

2016-01-06 Thread Jojy Varghese



> On Jan. 6, 2016, 11:10 p.m., Jie Yu wrote:
> > docs/containerizer.md, lines 53-54
> > 
> >
> > What does that mean? An agent is either running on Linux or running on 
> > OSX, how is that possible?

What i meant was that this feature will allow a `task` (say command) to be run 
on OSX(by using mesos containerizer + posix isolators) or Linux (using mesos 
containerizer or docker containerizer).


- Jojy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41657/#review113148
---


On Dec. 29, 2015, 4:36 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41657/
> ---
> 
> (Updated Dec. 29, 2015, 4:36 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This documentation is intended for users trying to get an overview of
> containerizer technology. It also provides the criteria for selecting a
> particular type of containerizer.
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md PRE-CREATION 
>   docs/home.md d929838206817a6c49cc2343b4de82fa085da682 
> 
> Diff: https://reviews.apache.org/r/41657/diff/
> 
> 
> Testing
> ---
> 
> mesos website docker.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 41334: Added helper functions to filter allocation slack resources.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41334/#review113102
---


Looks good.  Just address the lack-of-comment as Klaus pointed out.


src/common/resources.cpp (lines 712 - 723)


Suggestion:
```
if (role.isSome() && role.get() != resource.role()) {
  return false;
}

return resource.revocable().type() == 
Resource::RevocableInfo::ALLOCATION_SLACK
```

Note: `type()` has a default, so you don't need to check `has_type()`.


- Joseph Wu


On Jan. 1, 2016, 5:14 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41334/
> ---
> 
> (Updated Jan. 1, 2016, 5:14 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, and Klaus Ma.
> 
> 
> Bugs: MESOS-4146
> https://issues.apache.org/jira/browse/MESOS-4146
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This helper function is used to filter out allocation slack resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp 9c8bfb0e7e1e40ca99b4cc75079e5b950630243d 
>   include/mesos/v1/resources.hpp db87c992e2ec466cb1d4d17775bf6423a2fb15aa 
>   src/common/resources.cpp b9d31aef8babee212374e352c57fadbff02167f3 
>   src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 
>   src/v1/resources.cpp 0c0eee6b3b7ae3254d7dc7b06187855c9b873764 
> 
> Diff: https://reviews.apache.org/r/41334/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 41772: Added helper function to flatten resources.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41772/#review113153
---



include/mesos/resources.hpp (lines 267 - 275)


I'd recommend killing these.  See issues below.



src/common/resources.cpp (lines 880 - 891)


Does this give you more value than something like this?
```
resources.filter(isReserved).flatten()
```



src/common/resources.cpp (lines 894 - 904)


This seems more appropriate as an optional parameter for 
`Resources::flatten`, just like `Option`.


- Joseph Wu


On Jan. 3, 2016, 1:42 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41772/
> ---
> 
> (Updated Jan. 3, 2016, 1:42 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, and Klaus Ma.
> 
> 
> Bugs: MESOS-4267
> https://issues.apache.org/jira/browse/MESOS-4267
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added two new helper functions to flatten resources.
> 1) Flatten reserved resources.
> 2) Flatten allocation slack revocable resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp 9c8bfb0e7e1e40ca99b4cc75079e5b950630243d 
>   include/mesos/v1/resources.hpp db87c992e2ec466cb1d4d17775bf6423a2fb15aa 
>   src/common/resources.cpp b9d31aef8babee212374e352c57fadbff02167f3 
>   src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 
>   src/v1/resources.cpp 0c0eee6b3b7ae3254d7dc7b06187855c9b873764 
> 
> Diff: https://reviews.apache.org/r/41772/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 41656: Renamed containerizer.md to mesos-containerizer.md.

2016-01-06 Thread Jie Yu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41656/#review113147
---

Ship it!


Ship It!

- Jie Yu


On Dec. 28, 2015, 8:23 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41656/
> ---
> 
> (Updated Dec. 28, 2015, 8:23 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The change reflects the content of the documentation. A separate document that
>   describes containerizer from a user perspective will be created.
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md  
>   docs/home.md d929838206817a6c49cc2343b4de82fa085da682 
>   docs/mesos-provisioner.md fdb298c2a954e903317ef56abbcfe2470a2dfd23 
> 
> Diff: https://reviews.apache.org/r/41656/diff/
> 
> 
> Testing
> ---
> 
> mesos website docker.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 41946: Added a `Representation` abstraction to stout.

2016-01-06 Thread Michael Park



> On Jan. 6, 2016, 9:51 a.m., Benjamin Bannier wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/representation.hpp, line 66
> > 
> >
> > Seems like an `explicit` ctr is good enough here, right? Otherwise `/* 
> > implicit */` would show that this is intentional.

I used `reference_wrapper` to implement this, which has an implicit 
constructor. I think its default behavior is fine for us?


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41946/#review113033
---


On Jan. 6, 2016, 10 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41946/
> ---
> 
> (Updated Jan. 6, 2016, 10 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
>   3rdparty/libprocess/3rdparty/stout/include/stout/representation.hpp 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41946/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 41333: Added helper functions to filter usage slack resources.



> On Jan. 6, 2016, 4:01 a.m., Klaus Ma wrote:
> > Overall comments is that: is this code called by any others? If not, why 
> > should we add that? I'd suggest to add this on demand.

I agree.  If this is not used, we should not add it.


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41333/#review113053
---


On Jan. 1, 2016, 5:15 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41333/
> ---
> 
> (Updated Jan. 1, 2016, 5:15 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, and Klaus Ma.
> 
> 
> Bugs: MESOS-4146
> https://issues.apache.org/jira/browse/MESOS-4146
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added helper functions to filter usage slack resources. This helper function 
> will be used to validate if the task is using usage slack resource or not so 
> as to make sure that one task or executor can only use same kind of resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp 9c8bfb0e7e1e40ca99b4cc75079e5b950630243d 
>   include/mesos/v1/resources.hpp db87c992e2ec466cb1d4d17775bf6423a2fb15aa 
>   src/common/resources.cpp b9d31aef8babee212374e352c57fadbff02167f3 
>   src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 
>   src/v1/resources.cpp 0c0eee6b3b7ae3254d7dc7b06187855c9b873764 
> 
> Diff: https://reviews.apache.org/r/41333/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 41820: Pulled out provisioner from linux filesystem isolator.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41820/
---

(Updated Jan. 6, 2016, 3:41 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-4240
https://issues.apache.org/jira/browse/MESOS-4240


Repository: mesos


Description
---

Pulled out provisioner from linux filesystem isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.hpp 
89d18624b08f2c953b9fa21663aeda694d4aac12 
  src/slave/containerizer/mesos/containerizer.cpp 
f3c370aeb331beb6202fd30cd0278877da0b42e0 
  src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 
a29f9d184a0d1088577b3168a12bc8c06493a477 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
8af2cecdca947e55d8d39e26d2fc3d42212f36c3 
  src/tests/containerizer/filesystem_isolator_tests.cpp 
5bb85034c22caef64054c1629f6fd55d227e48b1 

Diff: https://reviews.apache.org/r/41820/diff/


Testing
---

make check (ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40339/#review113154
---

Ship it!


LGTM.

- Joseph Wu


On Jan. 1, 2016, 5:17 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40339/
> ---
> 
> (Updated Jan. 1, 2016, 5:17 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-3887
> https://issues.apache.org/jira/browse/MESOS-3887
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a flag to master to enable oversubscription for reservations.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp f7ada68d7111486d264284990996413bb3d6 
>   src/master/allocator/mesos/allocator.hpp 
> 50ef3b20f34bc6d87cbeccabcebec9a5031a6554 
>   src/master/allocator/mesos/hierarchical.hpp 
> 86ea5a402ed67f8f22f11d5730147cd907d66a08 
>   src/master/allocator/mesos/hierarchical.cpp 
> 7f900c4e024485704d79e57ae22407557598fe6c 
>   src/master/flags.hpp 9af6c68eef6bcf39d5776809fab6c66dc95da6b2 
>   src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d 
>   src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
>   src/tests/allocator.hpp 9bdfaecf1a148f113ad52956b50ed7cabe0902ef 
>   src/tests/hierarchical_allocator_tests.cpp 
> e044f832c2c16e53e663c6ced5452649bb0dcb59 
>   src/tests/master_allocator_tests.cpp 
> cba7c36471f93b678d94e1da0251a28a893696b1 
>   src/tests/master_quota_tests.cpp 2f1bc3ae6a370e466f7cea9b597f51d7eccb1b33 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> c0feedee393b8475fd27b0af9344d306a392893e 
>   src/tests/reservation_endpoints_tests.cpp 
> b8edd6fafedd4c2221a8d19c1ebc71254071a8c7 
>   src/tests/reservation_tests.cpp 69ddf906f2041bba84d7e1a20f90ee18817b4e64 
>   src/tests/resource_offers_tests.cpp 
> 0bad45dd1dabecc88fef1ab46e8ea26718070b33 
>   src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8 
> 
> Diff: https://reviews.apache.org/r/40339/diff/
> 
> 
> Testing
> ---
> 
> Ubuntu 14.04
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 41946: Added a `Representation` abstraction to stout.

2016-01-06 Thread Michael Park



> On Jan. 6, 2016, 9:51 a.m., Benjamin Bannier wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/representation.hpp, line 67
> > 
> >
> > Any reason you did not delete the ctr from `T&&`?

Used `reference_wrapper` which deletes it.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41946/#review113033
---


On Jan. 6, 2016, 10 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41946/
> ---
> 
> (Updated Jan. 6, 2016, 10 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
>   3rdparty/libprocess/3rdparty/stout/include/stout/representation.hpp 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41946/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 41896: Added guide to writing highly available Mesos frameworks.

2016-01-06 Thread Neil Conway


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41896/
---

(Updated Jan. 6, 2016, 11:05 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, and Joris Van 
Remoortere.


Changes
---

Incorporate feedback from BenM.


Bugs: MESOS-3936
https://issues.apache.org/jira/browse/MESOS-3936


Repository: mesos


Description
---

Added guide to writing highly available Mesos frameworks.


Diffs (updated)
-

  docs/app-framework-development-guide.md 
4a43a93d080bdac37b8aee91748fea7552a1cc67 
  docs/high-availability-framework-guide.md PRE-CREATION 
  docs/high-availability.md 31aa66220617a3f8606b185ef247c11f00735227 
  docs/home.md bc22d3126f49e0213e6bb3a0e23e156cd2b247f1 

Diff: https://reviews.apache.org/r/41896/diff/


Testing
---

Previewed via site-docker.

Note that there's a lot more that could be said here; also, at some point we 
should probably unify the "reconciliation" page with this page, and perhaps 
move some of the content in the "high-availability" page here (leaving the 
"high-availability" page for the operator-centric parts of configuring Mesos to 
run in HA mode).


Thanks,

Neil Conway

Re: Review Request 41819: Added ContainerConfig to all isolators.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41819/
---

(Updated Jan. 6, 2016, 3:41 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-4240
https://issues.apache.org/jira/browse/MESOS-4240


Repository: mesos


Description
---

Added ContainerConfig to all isolators.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
f3c370aeb331beb6202fd30cd0278877da0b42e0 
  src/slave/containerizer/mesos/isolator.cpp 
493b5dd26cf0e8f986381a502cfa6d1dde6573d4 
  src/slave/containerizer/mesos/isolators/cgroups/cpushare.hpp 
123b9ed3ccaebcd5da24fc62ff7a92d4a81ed760 
  src/slave/containerizer/mesos/isolators/cgroups/cpushare.cpp 
3b95e195ad704f163c245175390d9a26bde7e17c 
  src/slave/containerizer/mesos/isolators/cgroups/mem.hpp 
09952369c72d3c6322ae7a1c73cd68226d452ad2 
  src/slave/containerizer/mesos/isolators/cgroups/mem.cpp 
2ddb9f4adbb879682cd39966ab974cf3fa32209c 
  src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 
5eaf49f1f35c93ad4465adb6c9c9cf57b3a2c6ee 
  src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp 
4d82c2b2f231c59cbb600869a0f2b716c1e55f5e 
  src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 
a29f9d184a0d1088577b3168a12bc8c06493a477 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
8af2cecdca947e55d8d39e26d2fc3d42212f36c3 
  src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 
c3544aa313cbb185efb03bba59961cdf2b616a37 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
00ff84b6cd0aa29fa5a7918d7f88d480af8752ca 
  src/slave/containerizer/mesos/isolators/filesystem/shared.hpp 
2e457015a0348a457581edf493877b71fab17090 
  src/slave/containerizer/mesos/isolators/filesystem/shared.cpp 
361ed6561bd5e2f75d026922def01f42b43d61c2 
  src/slave/containerizer/mesos/isolators/namespaces/pid.hpp 
c2d1455249618f9cd2e17dc2244b184d52b32eaf 
  src/slave/containerizer/mesos/isolators/namespaces/pid.cpp 
d65c1593b44f4b21237581147e57e441ebf3160d 
  src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 
e3766c313a1bd2a838a73730c62c74c5ee8e1a4c 
  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
22a8428427b758bae4a0518356d7933c4110cd9f 
  src/slave/containerizer/mesos/isolators/posix.hpp 
7e1ebc2fada5a5e291e84c7044bdba9a71f4b42c 
  src/slave/containerizer/mesos/isolators/posix/disk.hpp 
31808c1e8199fbf2cea36c273860fdbf0a2388f8 
  src/slave/containerizer/mesos/isolators/posix/disk.cpp 
248c34adb63907911d89bed5b1519682a852bb2d 

Diff: https://reviews.apache.org/r/41819/diff/


Testing
---

make check (ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song

Re: Review Request 41815: Unified Container: Added provisioner to mesos containerizer.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41815/
---

(Updated Jan. 6, 2016, 3:40 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-4240
https://issues.apache.org/jira/browse/MESOS-4240


Repository: mesos


Description
---

Unified Container: Added provisioner to mesos containerizer.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.hpp 
89d18624b08f2c953b9fa21663aeda694d4aac12 
  src/slave/containerizer/mesos/containerizer.cpp 
f3c370aeb331beb6202fd30cd0278877da0b42e0 
  src/tests/containerizer/filesystem_isolator_tests.cpp 
5bb85034c22caef64054c1629f6fd55d227e48b1 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
95b493c6f479eef52ee0c9a44ac40254ed76ebae 

Diff: https://reviews.apache.org/r/41815/diff/


Testing
---

make check (ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song

Re: Review Request 41816: Generated ContainerConfig in mesos containerizer.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41816/
---

(Updated Jan. 6, 2016, 3:40 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-4240
https://issues.apache.org/jira/browse/MESOS-4240


Repository: mesos


Description
---

Generated ContainerConfig in mesos containerizer.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.hpp 
89d18624b08f2c953b9fa21663aeda694d4aac12 
  src/slave/containerizer/mesos/containerizer.cpp 
f3c370aeb331beb6202fd30cd0278877da0b42e0 

Diff: https://reviews.apache.org/r/41816/diff/


Testing
---

make check (ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song

Re: Review Request 41817: Changed slave isolator interface, updated mesos isolator, isolator tests and mock isolator.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41817/
---

(Updated Jan. 6, 2016, 3:41 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-4240
https://issues.apache.org/jira/browse/MESOS-4240


Repository: mesos


Description
---

Changed slave isolator interface, updated mesos isolator, isolator tests and 
mock isolator.


Diffs (updated)
-

  include/mesos/slave/isolator.hpp 95a2933988ea7c9b9404df5e12031f134712b2b5 
  src/slave/containerizer/mesos/isolator.hpp 
937f253656d36ed10b47ceeb0b6101f212e65586 
  src/slave/containerizer/mesos/isolator.cpp 
493b5dd26cf0e8f986381a502cfa6d1dde6573d4 
  src/tests/containerizer/isolator.hpp e4101b188560bd857ea104f61f52f27c880e7731 
  src/tests/containerizer/isolator_tests.cpp 
91178b69ccbf5b6cbf64421e5602e6d554fc34ca 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
95b493c6f479eef52ee0c9a44ac40254ed76ebae 

Diff: https://reviews.apache.org/r/41817/diff/


Testing
---

make check (ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song

Review Request 41999: Cleaned up unnecessary parameter in provisioner constructor.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41999/
---

Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Repository: mesos


Description
---

Cleaned up unnecessary parameter in provisioner constructor.


Diffs
-

  src/slave/containerizer/mesos/containerizer.cpp 
f3c370aeb331beb6202fd30cd0278877da0b42e0 
  src/slave/containerizer/mesos/provisioner/provisioner.hpp 
b2e23d82ea255e1c91d7537a58f86632763d9a56 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 
89d06e94bd2255bb4f2dad3fae75c1b3d789611d 
  src/tests/containerizer/provisioner_appc_tests.cpp 
98d5a46149ef63cedcbf4915b5b6e9842ac67dbb 

Diff: https://reviews.apache.org/r/41999/diff/


Testing
---

make check(ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song

Review Request 42002: Updated missing allocator comments and removed redundancies.

2016-01-06 Thread Adam B


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42002/
---

Review request for mesos, Alexander Rukletsov, Guangya Liu, and Neil Conway.


Repository: mesos


Description
---

Updated missing allocator comments and removed redundancies.


Diffs
-

  include/mesos/master/allocator.hpp f7ada68d7111486d264284990996413bb3d6 

Diff: https://reviews.apache.org/r/42002/diff/


Testing
---

JAVADOC_AUTOBRIEF=YES means that the brief description stops at the first '.', 
so we don't really need a newline or blank line in between brief and detailed 
descriptions.
Also, REPEAT_BRIEF=YES means that the brief description is prepended to the 
detailed description, so there's no need to repeat it ourselves.

I mostly wanted to get rid of gyliu513's TODOs, but got frustrated with the 
useless comment : function definition ratio.


Thanks,

Adam B

Re: Review Request 41943: Fixed stout protobuf::parse to support parsing JSON object containing JSON::Null.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41943/
---

(Updated Jan. 6, 2016, 6:07 p.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Jie Yu, Joris Van 
Remoortere, Joseph Wu, and Timothy Chen.


Summary (updated)
-

Fixed stout protobuf::parse to support parsing JSON object containing 
JSON::Null.


Bugs: MESOS-4294
https://issues.apache.org/jira/browse/MESOS-4294


Repository: mesos


Description (updated)
---

Fixed stout protobuf::parse to support parsing JSON object containing 
JSON::Null.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
98ea47794b3a7c99b3cbd2418ba6e36eb5951259 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 
bf2a2b8a9f67c6a4cf66b156b9c14fae015a8af0 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h 
08793c9d21d4b9b7dd3081cfa35afa47a7e0d28a 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc 
797b3b000f3c3fea42cabc3b40baf7235eab6b1e 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto 
4c11e23f875b75bcb9d5c65ee66d55b6f72e546d 

Diff: https://reviews.apache.org/r/41943/diff/


Testing
---

make check (tested on both ubuntu14.04 and OSX10.10)


Thanks,

Gilbert Song

Re: Review Request 41943: Fixed stout protobuf::parse to support parsing JSON object containing JSON::Null.



> On Jan. 5, 2016, 1:08 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp, line 359
> > 
> >
> > Can you also check that the parsed JSON (protobuf object) is equivalent 
> > to parsing the same JSON with the `null` field removed?
> > 
> > i.e.
> > ```
> > protobuf::parse(
> >   "{"
> >   "  \"burger\": \"big\"
> >   "}");
> > ```
> > 
> > Same for below.

I'll go ahead and drop this, since you no longer have that test.


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41943/#review112927
---


On Jan. 6, 2016, 6:07 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41943/
> ---
> 
> (Updated Jan. 6, 2016, 6:07 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Jie Yu, Joris Van 
> Remoortere, Joseph Wu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4294
> https://issues.apache.org/jira/browse/MESOS-4294
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed stout protobuf::parse to support parsing JSON object containing 
> JSON::Null.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
> 98ea47794b3a7c99b3cbd2418ba6e36eb5951259 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 
> bf2a2b8a9f67c6a4cf66b156b9c14fae015a8af0 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h 
> 08793c9d21d4b9b7dd3081cfa35afa47a7e0d28a 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc 
> 797b3b000f3c3fea42cabc3b40baf7235eab6b1e 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto 
> 4c11e23f875b75bcb9d5c65ee66d55b6f72e546d 
> 
> Diff: https://reviews.apache.org/r/41943/diff/
> 
> 
> Testing
> ---
> 
> make check (tested on both ubuntu14.04 and OSX10.10)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 42011: Added gtest flags to generate xml report

2016-01-06 Thread haosdent huang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42011/#review113173
---

Ship it!


Ship It!

- haosdent huang


On Jan. 7, 2016, 2:39 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42011/
> ---
> 
> (Updated Jan. 7, 2016, 2:39 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4258
> https://issues.apache.org/jira/browse/MESOS-4258
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added gtest flags to generate xml report
> 
> 
> Diffs
> -
> 
>   Makefile.am d9604f48f194dc8272423410e9938e646f334a9c 
>   support/docker_build.sh 7882bd20e4b6ee28dc117086386de8faac995a3e 
> 
> Diff: https://reviews.apache.org/r/42011/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 41870: [stout] Added ref-qualifiers to Option::get().

2016-01-06 Thread Anand Mazumdar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41870/
---

(Updated Jan. 7, 2016, 4:47 a.m.)


Review request for mesos, Joris Van Remoortere and Michael Park.


Changes
---

Updated review deps.


Repository: mesos


Description
---

This trivial change adds ref-qualifiers introduced in C++11 to Option::get(). 
This is in sync with what boost/folly `optional` already have.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
b58350b312c1969aa86ec679e95af0f97846c141 

Diff: https://reviews.apache.org/r/41870/diff/


Testing
---

make check

Verified this enables operations like the following to incur a move instead of 
a copy:

```
Option create();
T t = create().get();
```


Thanks,

Anand Mazumdar

Review Request 42015: Added minimum supported compiler versions in getting started doc.

2016-01-06 Thread Anand Mazumdar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42015/
---

Review request for mesos, Joris Van Remoortere and Michael Park.


Repository: mesos


Description
---

See summary. Follow up on an email to dev@ to update the minimum supported 
version for GCC to 4.8.1+


Diffs
-

  docs/getting-started.md a679093da97cb40499f0c9fd5c255d647fed062a 

Diff: https://reviews.apache.org/r/42015/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40339/#review113188
---

Ship it!


Ship It!

- Klaus Ma


On Jan. 2, 2016, 9:17 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40339/
> ---
> 
> (Updated Jan. 2, 2016, 9:17 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-3887
> https://issues.apache.org/jira/browse/MESOS-3887
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a flag to master to enable oversubscription for reservations.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp f7ada68d7111486d264284990996413bb3d6 
>   src/master/allocator/mesos/allocator.hpp 
> 50ef3b20f34bc6d87cbeccabcebec9a5031a6554 
>   src/master/allocator/mesos/hierarchical.hpp 
> 86ea5a402ed67f8f22f11d5730147cd907d66a08 
>   src/master/allocator/mesos/hierarchical.cpp 
> 7f900c4e024485704d79e57ae22407557598fe6c 
>   src/master/flags.hpp 9af6c68eef6bcf39d5776809fab6c66dc95da6b2 
>   src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d 
>   src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
>   src/tests/allocator.hpp 9bdfaecf1a148f113ad52956b50ed7cabe0902ef 
>   src/tests/hierarchical_allocator_tests.cpp 
> e044f832c2c16e53e663c6ced5452649bb0dcb59 
>   src/tests/master_allocator_tests.cpp 
> cba7c36471f93b678d94e1da0251a28a893696b1 
>   src/tests/master_quota_tests.cpp 2f1bc3ae6a370e466f7cea9b597f51d7eccb1b33 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> c0feedee393b8475fd27b0af9344d306a392893e 
>   src/tests/reservation_endpoints_tests.cpp 
> b8edd6fafedd4c2221a8d19c1ebc71254071a8c7 
>   src/tests/reservation_tests.cpp 69ddf906f2041bba84d7e1a20f90ee18817b4e64 
>   src/tests/resource_offers_tests.cpp 
> 0bad45dd1dabecc88fef1ab46e8ea26718070b33 
>   src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8 
> 
> Diff: https://reviews.apache.org/r/40339/diff/
> 
> 
> Testing
> ---
> 
> Ubuntu 14.04
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Review Request 42011: Added gtest flags to generate xml report


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42011/
---

Review request for mesos and Ben Mahler.


Bugs: MESOS-4258
https://issues.apache.org/jira/browse/MESOS-4258


Repository: mesos


Description
---

Added gtest flags to generate xml report


Diffs
-

  Makefile.am d9604f48f194dc8272423410e9938e646f334a9c 
  support/docker_build.sh 7882bd20e4b6ee28dc117086386de8faac995a3e 

Diff: https://reviews.apache.org/r/42011/diff/


Testing
---

make check


Thanks,

Shuai Lin

Re: Review Request 42011: Added gtest flags to generate xml report



> On Jan. 7, 2016, 2:17 a.m., haosdent huang wrote:
> > support/docker_build.sh, line 69
> > 
> >
> > do here overwrite the env `GTEST_FILTER` before?
> 
> haosdent huang wrote:
> Seems would overwrite according my test.

Sorry, it's a typo. Already updated.


- Shuai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42011/#review113167
---


On Jan. 7, 2016, 2:39 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42011/
> ---
> 
> (Updated Jan. 7, 2016, 2:39 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4258
> https://issues.apache.org/jira/browse/MESOS-4258
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added gtest flags to generate xml report
> 
> 
> Diffs
> -
> 
>   Makefile.am d9604f48f194dc8272423410e9938e646f334a9c 
>   support/docker_build.sh 7882bd20e4b6ee28dc117086386de8faac995a3e 
> 
> Diff: https://reviews.apache.org/r/42011/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 42011: Added gtest flags to generate xml report



> On Jan. 7, 2016, 2:17 a.m., haosdent huang wrote:
> > support/docker_build.sh, line 69
> > 
> >
> > do here overwrite the env `GTEST_FILTER` before?
> 
> haosdent huang wrote:
> Seems would overwrite according my test.
> 
> Shuai Lin wrote:
> Sorry, it's a typo. Already updated.


root@hostname ~/dev/mesos/mesos-master-branch/build # find . -name report.xml   

 
./3rdparty/libprocess/report.xml
./3rdparty/libprocess/3rdparty/report.xml
./src/report.xml



- Shuai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42011/#review113167
---


On Jan. 7, 2016, 2:39 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42011/
> ---
> 
> (Updated Jan. 7, 2016, 2:39 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4258
> https://issues.apache.org/jira/browse/MESOS-4258
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added gtest flags to generate xml report
> 
> 
> Diffs
> -
> 
>   Makefile.am d9604f48f194dc8272423410e9938e646f334a9c 
>   support/docker_build.sh 7882bd20e4b6ee28dc117086386de8faac995a3e 
> 
> Diff: https://reviews.apache.org/r/42011/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 42011: Added gtest flags to generate xml report


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42011/
---

(Updated Jan. 7, 2016, 2:39 a.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-4258
https://issues.apache.org/jira/browse/MESOS-4258


Repository: mesos


Description
---

Added gtest flags to generate xml report


Diffs (updated)
-

  Makefile.am d9604f48f194dc8272423410e9938e646f334a9c 
  support/docker_build.sh 7882bd20e4b6ee28dc117086386de8faac995a3e 

Diff: https://reviews.apache.org/r/42011/diff/


Testing
---

make check


Thanks,

Shuai Lin

Re: Review Request 41334: Added helper functions to filter allocation slack resources.



> On 一月 6, 2016, 11:32 p.m., Joseph Wu wrote:
> > src/common/resources.cpp, lines 712-723
> > 
> >
> > Suggestion:
> > ```
> > if (role.isSome() && role.get() != resource.role()) {
> >   return false;
> > }
> > 
> > return resource.revocable().type() == 
> > Resource::RevocableInfo::ALLOCATION_SLACK
> > ```
> > 
> > Note: `type()` has a default, so you don't need to check `has_type()`.

Thanks Joseph, seems the logic should be

if (role.isSome() && role.get() == resource.role()) {  // Exclude current 
role's allocation slack from itself, enable this role only use other role's 
allocation slack.
  return false;
}

return resource.revocable().type() == Resource::RevocableInfo::ALLOCATION_SLACK


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41334/#review113102
---


On 一月 2, 2016, 1:14 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41334/
> ---
> 
> (Updated 一月 2, 2016, 1:14 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, and Klaus Ma.
> 
> 
> Bugs: MESOS-4146
> https://issues.apache.org/jira/browse/MESOS-4146
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This helper function is used to filter out allocation slack resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp 9c8bfb0e7e1e40ca99b4cc75079e5b950630243d 
>   include/mesos/v1/resources.hpp db87c992e2ec466cb1d4d17775bf6423a2fb15aa 
>   src/common/resources.cpp b9d31aef8babee212374e352c57fadbff02167f3 
>   src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 
>   src/v1/resources.cpp 0c0eee6b3b7ae3254d7dc7b06187855c9b873764 
> 
> Diff: https://reviews.apache.org/r/41334/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 41491: Unified Container: Exposed docker/appc image manifest to mesos containerizer.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41491/
---

(Updated Jan. 6, 2016, 5:15 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-4225
https://issues.apache.org/jira/browse/MESOS-4225


Repository: mesos


Description
---

Unified Container: Exposed docker/appc image manifest to mesos containerizer.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/store.cpp 
03425daaf015cf231920b7eda1d5424895a41286 
  src/slave/containerizer/mesos/provisioner/provisioner.hpp 
b2e23d82ea255e1c91d7537a58f86632763d9a56 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 
89d06e94bd2255bb4f2dad3fae75c1b3d789611d 
  src/slave/containerizer/mesos/provisioner/store.hpp 
aec725f789f7aeb92abfcc6718c2e6e2f1f37981 
  src/tests/containerizer/provisioner_docker_tests.cpp 
8635eee1832cd4ab0e73e218106388d25d0278b7 

Diff: https://reviews.apache.org/r/41491/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 40429: Report executor exit to framework schedulers.

2016-01-06 Thread Adam B


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40429/#review112969
---

Ship it!


Great job! I'll make the one minor change and commit this.


src/sched/sched.cpp (line 1029)


Why is this VLOG(2) instead of VLOG(1)? Seems at least as valuable as the 
"Scheduler::executorLost took" message below.

I'll bring this back up to VLOG(1) so they're the same.


- Adam B


On Jan. 5, 2016, 11:01 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40429/
> ---
> 
> (Updated Jan. 5, 2016, 11:01 a.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-313
> https://issues.apache.org/jira/browse/MESOS-313
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Report executor exit to framework schedulers. This is a MVP to start the work 
> of notifying scheduler on scheduler refresh.
> 
> Next step would be sending this message reliabily, and/or splitting 
> Event::FAILURE for slave failure and executor termination.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 2aa083c85ae2a2f1392121b1d30d71376c01ffd7 
>   docs/app-framework-development-guide.md 
> 4a43a93d080bdac37b8aee91748fea7552a1cc67 
>   docs/upgrades.md aebdc1e1b7a73c93b5a14867214eb852de89ad24 
>   include/mesos/scheduler.hpp 049c041286f3167e79cc5ea8a9e0bf8d42569832 
>   src/java/src/org/apache/mesos/Scheduler.java 
> 4f048830a2c47f747033c60730cc770cb2578815 
>   src/python/interface/src/mesos/interface/__init__.py 
> 4be502fd83029ad5fc798696caf9e27fd95f7482 
>   src/sched/sched.cpp 44eb4f50e8ed84297268d94a3a0320c843ff6d8c 
>   src/tests/fault_tolerance_tests.cpp 
> ba657d0e1d8515cffd1b37925bf91a84b2feaef1 
>   src/tests/gc_tests.cpp f939d27c58177fba052fbcd9d6c9a572d052df52 
>   src/tests/master_slave_reconciliation_tests.cpp 
> 9afa826006fa7129da1a9c1ac8c389c0e051f717 
>   src/tests/master_tests.cpp 865fa4a71f4bae2a218cd2c4e10873222d1ea3c4 
>   src/tests/scheduler_event_call_tests.cpp 
> 03f0332ef75bbe7c4947bd6daf55d40384570f18 
>   src/tests/slave_tests.cpp 77750eda99184c0bf4404df8468461e3c7f8cde0 
> 
> Diff: https://reviews.apache.org/r/40429/diff/
> 
> 
> Testing
> ---
> 
> Modified test for SchedulerDriverEventTest.Failure, which verifies that 
> MockScheduler::executorLost is invoked.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 41333: Added helper functions to filter usage slack resources.