Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On Dec. 30, 2015, 8:42 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1321 > > > > > > As framework can not use ALLOCATION_SLACK mixed with other resources, > > allocator need to

Re: Review Request 41856: Added helper functions to get allocation slack.

> On Jan. 4, 2016, 3:40 p.m., Guangya Liu wrote: > > src/slave/slave.hpp, lines 392-400 > > > > > > Can you please explain why not adding some global counters for > > totalAllocationSlack, pendingAllocationSlac,

Re: Review Request 41567: Clarified a comment that occurs in several test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41567/#review113438 --- Neil, do you want to rebase this or discard it, since you've

Re: Review Request 42058: Fixed stout protobuf::parse by passing error message in nested JSON.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42058/#review113433 --- Patch looks great! Reviews applied: [41943, 42058] Passed

Re: Review Request 41791: Updated allocation slack when dynamic reservation reserve some new resources.

> On Jan. 3, 2016, 6:43 p.m., Klaus Ma wrote: > > I think it's too early to update total allocation slack here; my suggestion > > to handle dynamic reservation: > > > > 1. Did not reduce total allocation slack in > > updateAllocation/updateAvailable; but if no allocated ALLOCATIONS_SLACK, >

Re: Review Request 41855: Trace pending executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41855/#review113435 --- src/slave/slave.cpp (line 1379)

Re: Review Request 41857: Got evictable executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41857/#review113430 --- src/slave/slave.cpp (line 3963)

Re: Review Request 41859: Launch tasks after evicting executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41859/#review113440 --- src/slave/slave.cpp (line 1449)

Re: Review Request 41858: Added helper functions to kill executor.

> On 一月 8, 2016, 7:49 a.m., Jian Qiu wrote: > > src/slave/slave.cpp, line 4886 > > > > > > Should this be used also by qos_correction? Want to leverage but because of `log` issues, the `qosCorrections` has many

Re: Review Request 41567: Clarified a comment that occurs in several test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41567/ --- (Updated Jan. 8, 2016, 6:22 p.m.) Review request for mesos and Adam B.

Re: Review Request 41817: Changed slave isolator interface and updated correspondings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41817/ --- (Updated Jan. 8, 2016, 10:18 a.m.) Review request for mesos, Artem

Re: Review Request 42027: WIP: Changes HTTP responses from Unauthorized (401) to Forbidden (403).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42027/#review113494 --- Patch looks great! Reviews applied: [40539, 37999, 38000, 38094,

Re: Review Request 42053: Add flags to set size of completed task/framework history.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42053/ --- (Updated Jan. 8, 2016, 5:47 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 42059: Updated ContainerLogger to use Subprocess::IO type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42059/ --- (Updated Jan. 8, 2016, 10:28 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 42040: Added Quota Operator Documentation.

> On Jan. 7, 2016, 11:55 p.m., Neil Conway wrote: > > docs/quota.md, line 226 > > > > > > Fix this link -- probably just link to roles.md. Although we don't > > really call the feature "implicit roles" in the

Re: Review Request 42040: Added Quota Operator Documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/#review113496 --- docs/home.md (line 42)

Re: Review Request 41567: Clarified a comment that occurs in several test cases.

> On Jan. 8, 2016, 9:08 a.m., Adam B wrote: > > Neil, do you want to rebase this or discard it, since you've discarded the > > parent patch? Will rebase! Sorry, didn't realize it was a child patch. - Neil --- This is an automatically

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On Dec. 30, 2015, 4:42 a.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1334 > > > > > > In this check, it seems allocator send offer when both !allocation & > > allocation are enough.

Re: Review Request 41819: Added ContainerConfig to all isolators.

> On Jan. 7, 2016, 4:16 p.m., Jie Yu wrote: > > Fixed at `41816`. - Gilbert --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41819/#review113372

Re: Review Request 41429: Cleaned up the CfsFilter and clarified its logging message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41429/#review113510 --- Patch looks great! Reviews applied: [41429] Passed command:

Review Request 42082: Fixed header order in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42082/ --- Review request for mesos, Benjamin Hindman and Artem Harutyunyan. Repository:

Re: Review Request 41782: Logger Module: Wire up the rotating container logger module and test.

> On Jan. 7, 2016, 4:43 p.m., Benjamin Hindman wrote: > > src/tests/module.cpp, line 111 > > > > > > s/sandboxPath/sandboxDirectory/ > > > > ? This one points to the sandbox module (the default one). I'll

Re: Review Request 42030: Added example of a `defer` bug to libprocess README.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42030/#review113534 --- 3rdparty/libprocess/README.md (line 257)

Re: Review Request 41810: Added credential to Docker image protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41810/#review113544 --- Ship it! include/mesos/mesos.proto (line 1318)

Re: Review Request 41781: Logger Module: Add test for the rotating container logger module.

> On Jan. 7, 2016, 4:12 p.m., Benjamin Hindman wrote: > > src/tests/container_logger_tests.cpp, lines 28-30 > > > > > > How come these aren't pulled out since they are three levels? Looks like we're a bit

Re: Review Request 41781: Logger Module: Add test for the rotating container logger module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41781/ --- (Updated Jan. 8, 2016, 12:06 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41783: Logger Module: Implement the rotating container logger module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41783/ --- (Updated Jan. 8, 2016, 12:06 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41782: Logger Module: Wire up the rotating container logger module and test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41782/ --- (Updated Jan. 8, 2016, 12:06 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41956: Removed an unnecessary os::exists check in curl URI fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41956/#review113543 --- Ship it! Ship It! - Timothy Chen On Jan. 6, 2016, 1:31 a.m.,

Re: Review Request 41960: Added the Docker URI fetcher plugin interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41960/#review113541 --- Ship it! Ship It! - Timothy Chen On Jan. 6, 2016, 1:43 a.m.,

Re: Review Request 41957: Style fix for curl URI fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41957/#review113542 --- Ship it! Ship It! - Timothy Chen On Jan. 6, 2016, 1:32 a.m.,

Re: Review Request 42030: Added example of a `defer` bug to libprocess README.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42030/#review113529 --- Patch looks great! Reviews applied: [42030] Passed command:

Re: Review Request 40975: Document that libprocess ignores SIGPIPE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40975/ --- (Updated Jan. 8, 2016, 8:58 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 40975: Document that libprocess ignores SIGPIPE

> On Jan. 7, 2016, 10:32 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [40975] > > > > Failed command: ./support/apply-review.sh -n -r 40975 > > > > Error: > > 2016-01-07 18:32:55 URL:https://reviews.apache.org/r/40975/diff/raw/ > > [1164/1164] -> "40975.patch" [1] >

Re: Review Request 40975: Document that libprocess ignores SIGPIPE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40975/ --- (Updated Jan. 8, 2016, 9:19 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 41429: Cleaned up the CfsFilter and clarified its logging message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41429/#review113535 --- Ship it! Ship It! - Timothy Chen On Jan. 8, 2016, 4:24 p.m.,

Re: Review Request 41961: Added an HTTP decode response method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41961/#review113539 --- 3rdparty/libprocess/include/process/http.hpp (line 718)

Re: Review Request 41961: Added an HTTP decode response method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41961/#review113540 --- 3rdparty/libprocess/src/http.cpp (line 707)

Review Request 42083: Fixed header order in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42083/ --- Review request for mesos, Benjamin Hindman and Artem Harutyunyan. Repository:

Review Request 42084: Fixed header order.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42084/ --- Review request for mesos, Benjamin Hindman and Artem Harutyunyan. Repository:

Re: Review Request 42011: Added gtest flags to generate xml report.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42011/#review113536 --- Ship it! Thank you! This is very helpful to the project. We'll

Re: Review Request 41962: Logger Module: Add tests for module recovery after agent failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41962/#review113538 --- src/tests/container_logger_tests.cpp (line 222)

Re: Review Request 34140: AppC image store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34140/#review113545 --- Can we close this now? I don't think this is relevant anymore. -

Re: Review Request 37075: Protobuf definitions instructing the fetcher cache about checksums and their validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37075/#review113546 --- Is this still relevant? - Timothy Chen On Aug. 5, 2015, 11:37

Re: Review Request 40975: Document that libprocess ignores SIGPIPE

> On Jan. 7, 2016, 6:32 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [40975] > > > > Failed command: ./support/apply-review.sh -n -r 40975 > > > > Error: > > 2016-01-07 18:32:55 URL:https://reviews.apache.org/r/40975/diff/raw/ > > [1164/1164] -> "40975.patch" [1] > >

Re: Review Request 42053: Add flags to set size of completed task/framework history.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42053/#review113547 --- Patch looks great! Reviews applied: [42053] Passed command:

Re: Review Request 41461: Added SFINAE-friendly `result_of` to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41461/ --- (Updated Jan. 8, 2016, 10:07 p.m.) Review request for mesos, Benjamin Hindman,

Review Request 42092: Add test for accept/decline offers and inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42092/ --- Review request for mesos, Ben Mahler, Artem Harutyunyan, and Joris Van

Review Request 42093: Added proper handling of 'None()' in the 'CfsFilter'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42093/ --- Review request for mesos, Ben Mahler and Timothy Chen. Repository: mesos

Re: Review Request 42093: Added proper handling of `None()` in the `CfsFilter`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42093/ --- (Updated Jan. 8, 2016, 11:41 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 41962: Logger Module: Add tests for module recovery after agent failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41962/ --- (Updated Jan. 8, 2016, 4:24 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 42084: Fixed header order.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42084/#review113578 --- Patch looks great! Reviews applied: [42082, 42083, 42084] Passed

Re: Review Request 42093: Added proper handling of `None()` in the `CfsFilter`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42093/#review113579 --- Ship it! Ship It! - Timothy Chen On Jan. 8, 2016, 11:42 p.m.,

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/#review113581 --- Ship it! Ship It!

Re: Review Request 37703: Add docker exec command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37703/#review113582 --- I just ran the CheckExec test and it failed for me, can you try it

Review Request 42096: Fixed race in persistent volume tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42096/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4318

Re: Review Request 42086: Updated master's Offer validation to handle InverseOffers.

> On Jan. 8, 2016, 4:09 p.m., Klaus Ma wrote: > > src/master/validation.cpp, line 597 > > > > > > There're several similar code: > > if (condition) { > > return Error(); > > } > >

Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41649/#review113556 --- Ship it! Besides these two minor suggestions, I think this is

Re: Review Request 41963: Logger Module: Implement ContainerLogger recovery.

> On Jan. 6, 2016, 7:21 p.m., Jojy Varghese wrote: > > src/slave/containerizer/docker.cpp, line 701 > > > > > > Do you need all the variables on the stack to be passed to the capture? > > Maybe just executorInfo ?

Re: Review Request 42086: Updated master's Offer validation to handle InverseOffers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42086/#review113571 --- src/master/validation.cpp (line 597)

Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.

> On Jan. 6, 2016, 2:22 a.m., Joerg Schad wrote: > > include/mesos/mesos.proto, line 482 > > > > > > Let us doublecheck we actually need a deprecation cycle here: The > > critical scenario would be in my opinion if

Re: Review Request 41962: Logger Module: Add tests for module recovery after agent failover.

> On Jan. 6, 2016, 7:32 p.m., Jojy Varghese wrote: > > src/tests/container_logger_tests.cpp, line 158 > > > > > > Can we have this as : > > > > ``` > > Shared docker(new MockDocker(...)); > > > >

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/#review113576 --- Ship it! Regarding the snake_case, my comment was regarding the

Re: Review Request 42084: Fixed header order.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42084/#review113584 --- Ship it! Ship It! - Klaus Ma On Jan. 9, 2016, 4:08 a.m.,

Re: Review Request 41962: Logger Module: Add tests for module recovery after agent failover.

> On Jan. 8, 2016, 1:29 p.m., Timothy Chen wrote: > > src/tests/container_logger_tests.cpp, line 222 > > > > > > Do we need to check that the correct container id is passed? It wouldn't hurt. I'll add it to both

Review Request 42086: Updated master's Offer validation to handle InverseOffers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42086/ --- Review request for mesos, Ben Mahler, Artem Harutyunyan, and Joris Van

Re: Review Request 41783: Logger Module: Implement the rotating container logger module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41783/#review113565 --- Patch looks great! Reviews applied: [41002, 41003, 41004, 41061,

Re: Review Request 41814: Unified Container: Created ContainerConfig protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41814/ --- (Updated Jan. 8, 2016, 10:17 a.m.) Review request for mesos, Artem

Re: Review Request 41816: Generated ContainerConfig in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41816/ --- (Updated Jan. 8, 2016, 10:17 a.m.) Review request for mesos, Artem

Re: Review Request 41875: Provided List constructor from std::initializer_list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41875/#review113445 --- Can you please add unit tests in the same way of

Re: Review Request 41876: Used List constructor from std::initializer_list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41876/#review113447 --- Ship it! Ship It! - Alexander Rojas On Jan. 4, 2016, 12:28

Re: Review Request 41871: Replaced libtool with dolt to speed up compiler invocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41871/#review113450 --- Patch looks great! Reviews applied: [41871] Passed command:

Review Request 42068: Porting Mesos on ppc64le.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42068/ --- Review request for mesos. Bugs: MESOS-4312

Review Request 42069: Porting libprocess on ppc64le.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42069/ --- Review request for mesos. Bugs: MESOS-4312

Re: Review Request 41875: Provided List constructor from std::initializer_list.

> On Jan. 8, 2016, 11:48 a.m., Alexander Rojas wrote: > > Can you please add unit tests in the same way of `hashset_tests.cpp` and > > `hashmap_tests.cpp` I added new unit tests for List which will be added to the Makefile in the follow-up patch (Makefile for stout-tests lives in libprocess).

Re: Review Request 41876: Used List constructor from std::initializer_list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41876/ --- (Updated Jan. 8, 2016, 12:29 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 41875: Provided List constructor from std::initializer_list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41875/ --- (Updated Jan. 8, 2016, 12:29 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42086/ --- (Updated Jan. 8, 2016, 5:58 p.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41820: Pulled out provisioner from linux filesystem isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41820/ --- (Updated Jan. 8, 2016, 6:14 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On 十二月 30, 2015, 12:42 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1334 > > > > > > In this check, it seems allocator send offer when both !allocation & > > allocation are enough.

Re: Review Request 42040: Added Quota Operator Documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/#review113601 --- docs/quota.md (line 20)

Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42100/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-4258

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42086/#review113597 --- src/master/master.cpp (lines 3054 - 3059)

Re: Review Request 42059: Update ContainerLogger to use Subprocess::IO type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42059/#review113442 --- Bad patch! Reviews applied: [42052, 42059] Failed command:

Re: Review Request 41429: Cleaned up the CfsFilter and clarified its logging message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41429/#review113444 --- Ship it! Ship It! src/tests/environment.cpp (line 156)

Re: Review Request 42040: Added Quota Operator Documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/ --- (Updated Jan. 8, 2016, 10:26 a.m.) Review request for mesos, Alexander

Re: Review Request 41871: Replaced libtool with dolt to speed up compiler invocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41871/ --- (Updated Jan. 8, 2016, 11:04 a.m.) Review request for mesos, Joerg Schad,

Re: Review Request 42040: Added Quota Operator Documentation.

> On Jan. 7, 2016, 11:55 p.m., Neil Conway wrote: > > Can we link this page from `home.md`? > > > > Overall: looks great! Only major feedback is to move the implementation > > details down to the bottom (or remove them), and refactor things slightly > > so that any user-visible behavior

Re: Review Request 41875: Provided List constructor from std::initializer_list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41875/ --- (Updated Jan. 8, 2016, 11:29 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/#review113439 --- Here's my first full pass over this patch. Couldn't find anything

Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41649/#review113457 --- Ship it! lgtm! src/master/master.cpp (line 1076)

Re: Review Request 39781: Update ModuleTest to not assume dynamic dlopen search.

> On Nov. 30, 2015, 9:51 a.m., Benjamin Bannier wrote: > > src/tests/module_tests.cpp, line 123 > > > > > > None of these functions need to be (mutating!) member functions if you > > simply inject

Re: Review Request 42027: WIP: Changes HTTP responses from Unauthorized (401) to Forbidden (403).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42027/ --- (Updated Jan. 8, 2016, 2:48 p.m.) Review request for mesos, Alexander

Re: Review Request 41936: Required role in set quota request explicitly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41936/#review113477 --- Ship it! Ship It! - Joerg Schad On Jan. 5, 2016, 6:08 p.m.,

Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41649/ --- (Updated Jan. 8, 2016, 12:46 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 41857: Got evictable executors.

> On Jan. 8, 2016, 4:36 p.m., Jian Qiu wrote: > > src/slave/slave.cpp, line 3967 > > > > > > this check may not be necessary because resources cannot be negative? Yes; it won't be negative, but it'll return first

Re: Review Request 41875: Provided List constructor from std::initializer_list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41875/ --- (Updated Jan. 8, 2016, 12:38 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 42040: Added Quota Operator Documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/#review113455 --- Patch looks great! Reviews applied: [42040] Passed command:

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

> On Dec. 17, 2015, 3:42 a.m., Till Toenshoff wrote: > > Ship It! Sorry for the delay -- this patch now needs a rebase. - Till --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 41791: Updated allocation slack for dynamic reserve.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41791/ --- (Updated 一月 8, 2016, 12:50 p.m.) Review request for mesos, Ben Mahler, Artem

  1   2   >