Re: Review Request 42194: Handle unreserve logic for dynamic reservation (3/3).

2016-01-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42194/ --- (Updated 一月 19, 2016, 8:22 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 42476: Introduced protobuf for set quota requests.

2016-01-19 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42476/#review115127 --- Ship it! include/mesos/quota/quota.proto (line 53)

Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

2016-01-19 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42289/ --- (Updated Jan. 19, 2016, 4:40 p.m.) Review request for mesos, Alexander

Re: Review Request 42490: Updated Presentaions.md and fixed two typos in support/hooks.

2016-01-19 Thread Disha Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42490/ --- (Updated Jan. 19, 2016, 8:51 a.m.) Review request for mesos, Alexander

Re: Review Request 42458: Made links to .md files consistent across documentation.

2016-01-19 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42458/#review115133 --- Ship it! Thanks Joerg! docs/markdown-style-guide.md (line 120)

Re: Review Request 42458: Made links to .md files consistent across documentation.

2016-01-19 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42458/ --- (Updated Jan. 19, 2016, 9:09 a.m.) Review request for mesos, Neil Conway and

Review Request 42490: Updated Presentaions.md and fixed two typos in support/hooks.

2016-01-19 Thread Disha Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42490/ --- Review request for mesos, Alexander Rukletsov, Guangya Liu, and Vinod Kone.

Re: Review Request 42490: Updated Presentaions.md and fixed two typos in support/hooks.

2016-01-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42490/#review115131 --- support/hooks/post-rewrite cannot be accessed. - Guangya Liu On

Re: Review Request 42415: Added a roles field to FrameworkInfo.

2016-01-19 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42415/#review115134 --- include/mesos/mesos.proto (lines 238 - 240)

Re: Review Request 42289: Quota doesn't allocate resources on slave joining.

2016-01-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42289/#review115132 --- Let's tweak some wording and testing and we are good to go! I

Re: Review Request 42458: Made links to .md files consistent across documentation.

2016-01-19 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42458/ --- (Updated Jan. 19, 2016, 10:50 a.m.) Review request for mesos, Neil Conway and

Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

2016-01-19 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42289/ --- (Updated Jan. 19, 2016, 6:55 p.m.) Review request for mesos, Alexander

Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

2016-01-19 Thread Klaus Ma
> On Jan. 19, 2016, 5:23 p.m., Alexander Rukletsov wrote: > > Let's tweak some wording and testing and we are good to go! > > > > I liked the initial summary more. IMO a patch should describe the solution, > > and not the problem. It's quite opposite for JIRA tickets, hence I'm > > convinced

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

2016-01-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/ --- (Updated 一月 19, 2016, 8:03 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 42477: Corrected example in quota user doc.

2016-01-19 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42477/#review115126 --- Ship it! Ship It! - Joerg Schad On Jan. 18, 2016, 11:37 p.m.,

Review Request 42491: WIP: Updated allocatable() to distinguish different resources.

2016-01-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42491/ --- Review request for mesos and Klaus Ma. Bugs: MESOS-4426

Re: Review Request 42289: Quota doesn't allocate resources on slave joining.

2016-01-19 Thread Alexander Rukletsov
> On Jan. 19, 2016, 9:23 a.m., Alexander Rukletsov wrote: > > Let's tweak some wording and testing and we are good to go! > > > > I liked the initial summary more. IMO a patch should describe the solution, > > and not the problem. It's quite opposite for JIRA tickets, hence I'm > > convinced

Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

2016-01-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41769/ --- (Updated 一月 19, 2016, 10 a.m.) Review request for mesos, Alexander Rukletsov,

Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

2016-01-19 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42289/ --- (Updated Jan. 19, 2016, 7:10 p.m.) Review request for mesos, Alexander

Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

2016-01-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41769/#review115135 --- How about a more succinct summary: "Traversed all roles for quota

Re: Review Request 42476: Introduced protobuf for set quota requests.

2016-01-19 Thread Alexander Rukletsov
> On Jan. 19, 2016, 8:37 a.m., Joerg Schad wrote: > > src/master/quota_handler.cpp, line 280 > > > > > > Not an issue, but question/remark: the protoRequest.error() is most > > likely to be less concise compared to

Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

2016-01-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42289/#review115142 --- It would be great if you add a comment describing the cluster

Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

2016-01-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42289/#review115143 --- src/tests/hierarchical_allocator_tests.cpp (lines 1812 - 1824)

Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

2016-01-19 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42289/ --- (Updated Jan. 19, 2016, 8:03 p.m.) Review request for mesos, Alexander

Re: Review Request 42476: Introduced protobuf for set quota requests.

2016-01-19 Thread Joerg Schad
> On Jan. 19, 2016, 8:37 a.m., Joerg Schad wrote: > > include/mesos/quota/quota.proto, line 54 > > > > > > Given the naming scheme QuotaStatus wouldn't a more consistent name be > > QuotaSet? > > Alexander

Re: Review Request 41459: Invoked `_Deferred`'s `operator F()` explicitly.

2016-01-19 Thread Michael Park
> On Dec. 28, 2015, 11:31 p.m., Daniel Pravat wrote: > > 3rdparty/libprocess/include/process/future.hpp, line 347 > > > > > > Other similar constructs will be converted when the code using them > > will compile on

Re: Review Request 41462: Used SFINAE-friendly `result_of` in libprocess.

2016-01-19 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41462/ --- (Updated Jan. 19, 2016, 10:43 p.m.) Review request for mesos, Benjamin

Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

2016-01-19 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41769/#review115232 --- The central part lgtm, will check the tests tomorrow morning in

Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

2016-01-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41769/#review115265 --- Ship it! Ship It! - Alexander Rukletsov On Jan. 19, 2016,

Re: Review Request 42182: Removed recovery checks in slave/http.cpp.

2016-01-19 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42182/ --- (Updated Jan. 19, 2016, 10:49 p.m.) Review request for mesos and Vinod Kone.

Review Request 42519: Fixed race between SchedDriver.{stop(), abort()} and SchedDriver.join().

2016-01-19 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42519/ --- Review request for mesos, Ben Mahler and Greg Mann. Bugs: MESOS-4409

Review Request 42524: Simplified SchedulerDriver.run().

2016-01-19 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42524/ --- Review request for mesos, Ben Mahler and Greg Mann. Bugs: MESOS-4409

Re: Review Request 42182: Allowed `Subscribe` Calls to pass through when agent is recovering.

2016-01-19 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42182/ --- (Updated Jan. 19, 2016, 10:51 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 42182: Allowed `Subscribe` Calls to pass through when agent is recovering.

2016-01-19 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42182/ --- (Updated Jan. 19, 2016, 10:56 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 41460: Used `std::is_bind_expression` to SFINAE correctly.

2016-01-19 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41460/ --- (Updated Jan. 19, 2016, 10:42 p.m.) Review request for mesos, Benjamin

Re: Review Request 41459: Invoked `_Deferred`'s `operator F()` explicitly.

2016-01-19 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41459/ --- (Updated Jan. 19, 2016, 10:42 p.m.) Review request for mesos, Benjamin

Re: Review Request 41461: Added SFINAE-friendly `result_of` in stout.

2016-01-19 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41461/ --- (Updated Jan. 19, 2016, 10:42 p.m.) Review request for mesos, Benjamin

Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.

2016-01-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42471/#review115260 --- Do we want to expose == and != for DiskInfo::Source yet? We don't

Re: Review Request 42472: Multiple Disk: Checkpoint persistent volume based on 'DiskInfo.Source'.

2016-01-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42472/#review115267 --- src/slave/paths.hpp (lines 269 - 273)

Re: Review Request 42470: Multiple Disk: Added 'Source' to 'Resource.DiskInfo'.

2016-01-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42470/#review115257 --- include/mesos/mesos.proto (line 646)

Re: Review Request 42182: Fixed check thereby allowing HTTP executors to reconnect.

2016-01-19 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42182/ --- (Updated Jan. 19, 2016, 10:29 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 42183: Introduced HttpEvent based filters in libprocess.

2016-01-19 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42183/ --- (Updated Jan. 19, 2016, 10:29 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 42374: Logger Module: Add test filter for tests requiring `logrotate`.

2016-01-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42374/ --- (Updated Jan. 19, 2016, 12:22 p.m.) Review request for mesos, Benjamin

Re: Review Request 41285: Initialized `pid` to None() instead of `UPID()` in Slave.

2016-01-19 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41285/ --- (Updated Jan. 19, 2016, 10:28 p.m.) Review request for mesos, Ben Mahler, Jie

Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

2016-01-19 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41288/ --- (Updated Jan. 19, 2016, 10:28 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

2016-01-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42386/#review115258 --- Ship it! Test cleanup, LGTM! - Joseph Wu On Jan. 16, 2016,

Re: Review Request 42182: Removed recovery checks in slave/http.cpp

2016-01-19 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42182/ --- (Updated Jan. 19, 2016, 10:48 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

2016-01-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42289/#review115264 --- Ship it! Ship It! - Alexander Rukletsov On Jan. 19, 2016, 2:25

Re: Review Request 41334: Added helper functions to filter allocation slack resources.

2016-01-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41334/#review115245 --- Ship it! Much easier to read now :) include/mesos/resources.hpp

Re: Review Request 41460: Used `std::is_bind_expression` to SFINAE correctly.

2016-01-19 Thread Michael Park
> On Jan. 3, 2016, 11:55 p.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/include/process/future.hpp, lines 228-230 > > > > > > Why do we need to capture/alias the type `F` as `G` again and then use > > it in

Re: Review Request 41460: Used `std::is_bind_expression` to SFINAE correctly.

2016-01-19 Thread Michael Park
> On Jan. 14, 2016, 3:58 a.m., Benjamin Hindman wrote: > > This LGTM; IIUC we're going to rely on the lexical substitution of the > > template parameters and that we're going to just do `typename =` instead of > > `typename G =`? Refer to https://reviews.apache.org/r/41460/#comment172930 -

Re: Review Request 42491: WIP: Updated allocatable() to distinguish different resources.

2016-01-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42491/#review115266 --- Patch looks great! Reviews applied: [40375, 41334, 41333, 40529,

Re: Review Request 42384: Correctted a typo in test case DeactivateAndReactivateFramework.

2016-01-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42384/#review115224 --- Ship it! Ship It! - Vinod Kone On Jan. 16, 2016, 2:57 a.m.,

Re: Review Request 42172: Add documentation for the ContainerLogger.

2016-01-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42172/ --- (Updated Jan. 19, 2016, 10:31 a.m.) Review request for mesos, Benjamin

Review Request 42516: Add support for user-defined networks.

2016-01-19 Thread Ezra Silvera
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- Review request for mesos and TimothyIL TimothyIL. Bugs: MESOS-4369

Re: Review Request 42172: Add documentation for logging and ContainerLogger.

2016-01-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42172/ --- (Updated Jan. 19, 2016, 10:35 a.m.) Review request for mesos, Benjamin

Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

2016-01-19 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41288/ --- (Updated Jan. 19, 2016, 8:05 p.m.) Review request for mesos, Ben Mahler and

Review Request 42517: Added discussion about allowing multiple frameworks in a role.

2016-01-19 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42517/ --- Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.

Re: Review Request 42068: Porting Mesos on ppc64le.

2016-01-19 Thread Joseph Wu
> On Jan. 17, 2016, 10:37 a.m., Artem Harutyunyan wrote: > > We avoid making changes in 3rdparty and the Mesos code within the same > > patch. Could you please break this patch into 2? > > Qian Zhang wrote: > Did you mean splitting the commit between mesos and libprocess? I saw we > have

Re: Review Request 42172: Add documentation for logging and ContainerLogger.

2016-01-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42172/ --- (Updated Jan. 19, 2016, 11:58 a.m.) Review request for mesos, Benjamin

Re: Review Request 42124: Updated /state to show usage slack and allocation slack resources.

2016-01-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42124/#review115288 --- You may want to revisit this patch in light of the recent /state

Re: Review Request 41285: PID none bug in slave

2016-01-19 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41285/ --- (Updated Jan. 20, 2016, 1:28 a.m.) Review request for mesos, Ben Mahler, Jie

Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.

2016-01-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42471/#review115324 --- Ship it! Ship It! - Jie Yu On Jan. 20, 2016, 2:29 a.m., Joris

Re: Review Request 41491: Exposed docker/appc image manifest to mesos containerizer.

2016-01-19 Thread Gilbert Song
> On Jan. 17, 2016, 10:57 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/provisioner/provisioner.hpp, line 60 > > > > > > We only expose Docker image manifest? But the summary of this RR says > > we will

Re: Review Request 41491: Exposed docker image manifest to mesos containerizer.

2016-01-19 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41491/ --- (Updated Jan. 19, 2016, 6:56 p.m.) Review request for mesos, Artem

Re: Review Request 42355: Removed the timeout from the filter.

2016-01-19 Thread Qian Zhang
> On Jan. 20, 2016, 9:49 a.m., Qian Zhang wrote: > > One question: Say allocation interval is 10s, at the time 5s, framework > > sets a filter with 3s, so with this patch, we will expire the filter 10s > > (max(10, 3)) later, i.e., at the time 15s. Then at the time of 10s (the > > next

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

2016-01-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/#review115263 --- src/tests/hierarchical_allocator_tests.cpp (lines 1918 - 1919)

Re: Review Request 42361: Added dynamic reservation test with no principal.

2016-01-19 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42361/#review115269 --- src/tests/reservation_tests.cpp (lines 1762 - 1765)

Re: Review Request 42265: Fixed more tests that didn't set a shutdown expect for MockExecutor.

2016-01-19 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42265/#review115286 --- Ship it! Ship It! - Timothy Chen On Jan. 18, 2016, 9:58 p.m.,

Re: Review Request 42368: Added reservation endpoint test without auth and principal.

2016-01-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42368/ --- (Updated Jan. 20, 2016, 12:11 a.m.) Review request for mesos, Jie Yu, Michael

Re: Review Request 42368: Added reservation endpoint test without auth and principal.

2016-01-19 Thread Greg Mann
> On Jan. 20, 2016, 12:44 a.m., Michael Park wrote: > > src/tests/reservation_endpoints_tests.cpp, lines 1173-1184 > > > > > > Why are we testing for this? When we met previously, Vinod mentioned that we sometimes

Re: Review Request 41858: Added helper functions to kill executor.

2016-01-19 Thread Joseph Wu
> On Jan. 7, 2016, 11:49 p.m., Jian Qiu wrote: > > src/slave/slave.cpp, line 4886 > > > > > > Should this be used also by qos_correction? > > Guangya Liu wrote: > Want to leverage but because of `log` issues,

Re: Review Request 42517: Added discussion about allowing multiple frameworks in a role.

2016-01-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42517/#review115330 --- docs/persistent-volume.md (line 404)

Re: Review Request 42361: Added dynamic reservation test with no principal.

2016-01-19 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42361/#review115273 --- src/tests/reservation_tests.cpp (line 1823)

Re: Review Request 42511: Updated comments around hierarchical tests.

2016-01-19 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42511/#review115284 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 19, 2016,

Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

2016-01-19 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41769/#review115285 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 19, 2016,

Re: Review Request 42252: Enabled master totalResources include allocation slack.

2016-01-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42252/#review115292 --- Considering that https://reviews.apache.org/r/41847/ has the same

Re: Review Request 42355: Removed the timeout from the filter.

2016-01-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42355/#review115327 --- What about inverseOfferFilter? - Guangya Liu On 一月 19, 2016,

Re: Review Request 41334: Added helper functions to filter allocation slack resources.

2016-01-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41334/ --- (Updated 一月 20, 2016, 2:51 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41789: Expose the http::internal::request function.

2016-01-19 Thread Adam B
> On Jan. 11, 2016, 12:12 a.m., Adam B wrote: > > 3rdparty/libprocess/src/http.cpp, lines 1218-1221 > > > > > > Will you add `query` as a parameter only once you've moved `get()` over > > to this? > > > >

Re: Review Request 42361: Added dynamic reservation test with no principal.

2016-01-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42361/ --- (Updated Jan. 19, 2016, 11:59 p.m.) Review request for mesos, Jie Yu, Michael

Re: Review Request 42505: Multiple Disk: Adjusted DiskInfo validation.

2016-01-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42505/#review115304 --- src/master/validation.cpp (lines 206 - 210)

Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.

2016-01-19 Thread Joris Van Remoortere
> On Jan. 19, 2016, 10:50 p.m., Jie Yu wrote: > > include/mesos/type_utils.hpp, line 29 > > > > > > Do you need this? Not after we get rid of `total_size`. I needed it for the scalar comparison. - Joris

Re: Review Request 42368: Added reservation endpoint test without auth and principal.

2016-01-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42368/ --- (Updated Jan. 20, 2016, 1:30 a.m.) Review request for mesos, Jie Yu, Michael

Re: Review Request 42530: Changed `createReservationInfo` to take `Option`.

2016-01-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42530/ --- (Updated Jan. 20, 2016, 1:30 a.m.) Review request for mesos and Michael Park.

Re: Review Request 42355: Removed the timeout from the filter.

2016-01-19 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42355/#review115315 --- One question: Say allocation interval is 10s, at the time 5s,

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

2016-01-19 Thread Joseph Wu
> On Jan. 15, 2016, 6:11 p.m., Joseph Wu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1291-1319 > > > > > > None of this should be necessary: > > > > 1) You should have all the allocation

Re: Review Request 42510: Updated comments around hierarchical tests.

2016-01-19 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42510/#review115271 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 19, 2016,

Re: Review Request 41847: Updated allocation slack when slave was updated.

2016-01-19 Thread Joseph Wu
> On Jan. 15, 2016, 6:21 p.m., Joseph Wu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 529-535 > > > > > > What if you did this? > > ``` > > slaves[slaveId]total =

Re: Review Request 42355: Removed the timeout from the filter.

2016-01-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42355/ --- (Updated Jan. 19, 2016, 11:32 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 42361: Added dynamic reservation test with no principal.

2016-01-19 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42361/#review115283 --- Ship it! src/tests/reservation_tests.cpp (lines 1761 - 1762)

Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.

2016-01-19 Thread Joris Van Remoortere
> On Jan. 19, 2016, 10:50 p.m., Jie Yu wrote: > > include/mesos/v1/values.hpp, line 22 > > > > > > Why this change? It was due to a cyclical include between `values.hpp` and `mesos.hpp`; however, since I moved the

Re: Review Request 42361: Added dynamic reservation test with no principal.

2016-01-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42361/ --- (Updated Jan. 20, 2016, 1:27 a.m.) Review request for mesos, Jie Yu, Michael

Review Request 42530: Changed 'createReservationInfo' to take 'Option'.

2016-01-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42530/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 41285: Made Executor struct assign `pid/http` to be None() explicitly.

2016-01-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41285/#review115311 --- Patch looks great! Reviews applied: [41285] Passed command:

Re: Review Request 41285: Made Executor struct assign `pid/http` to be None() explicitly.

2016-01-19 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41285/ --- (Updated Jan. 20, 2016, 1:41 a.m.) Review request for mesos, Ben Mahler, Jie

Re: Review Request 42491: Updated allocatable() to distinguish different resources.

2016-01-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42491/ --- (Updated 一月 20, 2016, 1:41 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41783: Implement the rotating container logger module.

2016-01-19 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41783/#review115318 --- src/slave/container_loggers/rotate.cpp (lines 128 - 131)

Re: Review Request 41789: Expose the http::internal::request function.

2016-01-19 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/#review115326 --- Looks good. Besides the previously mentioned `http::request()`

Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

2016-01-19 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42289/#review115270 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 19, 2016,

  1   2   3   >