Review Request 44421: Added support for "overlay" keyword.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44421/ --- Review request for mesos, haosdent huang, Jie Yu, and Shuai Lin. Bugs:

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44408/#review122192 --- Patch looks great! Reviews applied: [44408] Passed command:

Re: Review Request 44414: Added documentation about container image support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44414/#review122188 --- Patch looks great! Reviews applied: [44414] Passed command:

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review122186 --- Patch looks great! Reviews applied: [43613, 43614, 43629, 43630,

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44260/#review122176 --- Fix it, then Ship it! I like the idea of making this more

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

> On March 5, 2016, 2:31 a.m., Joseph Wu wrote: > > src/tests/persistent_volume_tests.cpp, lines 283-284 > > > > > > One more small refinement: > > > > Now that the master does not use this variable, you

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44408/ --- (Updated March 5, 2016, 4:17 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 44087: Moved logic to assign process to freezer hierarchy into parentHook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44087/#review122182 --- Patch looks great! Reviews applied: [44247, 44087] Passed

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

> On 三月 5, 2016, 1:25 a.m., Joseph Wu wrote: > > src/tests/persistent_volume_tests.cpp, line 89 > > > > > > This entire helper is not needed anymore (due to implicit roles). > > Guangya Liu wrote: > @Jopseph,

Re: Review Request 44414: Added documentation about container image support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44414/#review122175 --- docs/container-image.md (line 11)

Re: Review Request 44407: Fixed a typo in a log message in an example framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44407/#review122178 --- Patch looks great! Reviews applied: [44407] Passed command:

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/#review122174 --- Most of my comments are based on an email @alex-mesos sent today,

Re: Review Request 44366: Added GPUs as an explicit resource.

> On March 4, 2016, 12:27 p.m., Klaus Ma wrote: > > src/slave/containerizer/containerizer.cpp, line 105 > > > > > > `` for --nvidia_gpus; not only this line, please also update them in > > the following comments.

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44408/#review122173 --- BTW, thanks for doing this :)

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

> On March 4, 2016, 5:25 p.m., Joseph Wu wrote: > > src/tests/persistent_volume_tests.cpp, line 89 > > > > > > This entire helper is not needed anymore (due to implicit roles). > > Guangya Liu wrote: > @Jopseph,

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44408/ --- (Updated March 5, 2016, 2:24 a.m.) Review request for mesos and Joseph Wu.

Review Request 44414: Added documentation about container image support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44414/ --- Review request for mesos, Gilbert Song, Jojy Varghese, Neil Conway, Timothy

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/#review122170 --- Ship it! Ship It! - Alexander Rojas On March 3, 2016, 5:17

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44260/#review121904 --- Ship it! src/master/allocator/mesos/metrics.hpp (line 26)

Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44380/#review122168 --- Patch looks great! Reviews applied: [44380] Passed command:

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

> On 三月 5, 2016, 1:25 a.m., Joseph Wu wrote: > > src/tests/persistent_volume_tests.cpp, line 89 > > > > > > This entire helper is not needed anymore (due to implicit roles). @Jopseph, why also remove acls here? The

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44408/#review122163 --- src/tests/persistent_volume_tests.cpp (line 89)

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44258/ --- (Updated March 5, 2016, 1:23 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44258/#review122161 --- src/master/http.cpp (lines 2029 - 2030)

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44258/ --- (Updated March 5, 2016, 12:34 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

> On March 4, 2016, 8:28 p.m., Joris Van Remoortere wrote: > > src/master/http.cpp, lines 2026-2027 > > > > > > Can you explain how machines going from `UP` to `DOWN` are handled in > > the next loop? > > I

Re: Review Request 44269: Added the framework of 'network/cni' isolator.

> On March 4, 2016, 3:30 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 129 > > > > > > Can we also check if the plugin is executable? Since later we are going > >

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

> On March 4, 2016, 6:45 a.m., Bernd Mathiske wrote: > > I also noticed a couple of these: ``` MesosSchedulerDriver driver( , DEFAULT_FRAMEWORK_INFO, master.get()->pid, DEFAULT_CREDENTIAL); ``` Now fixed (there were two spaces rather than four). --- Also went through and changed a

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- (Updated March 4, 2016, 4:14 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43630: Especially updated scheduler tests to use the updated MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43630/ --- (Updated March 4, 2016, 3:58 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43629/ --- (Updated March 4, 2016, 3:55 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 41049: New python lib with only the executor driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41049/#review122158 --- Bad patch! Reviews applied: [41049] Failed command:

Re: Review Request 43614: Refactor MesosTest and remove cleanup logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43614/ --- (Updated March 4, 2016, 3:43 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 44269: Added the framework of 'network/cni' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44269/#review122155 --- Patch looks great! Reviews applied: [44004, 44200, 44269]

Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44408/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-4868

Re: Review Request 44087: Moved logic to assign process to freezer hierarchy into parentHook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44087/#review122154 --- Ship it! Ship It! - Avinash sridharan On March 3, 2016,

Review Request 44407: Fixed a typo in a log message in an example framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44407/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

Re: Review Request 44396: Updated unavailable in batch to avoid several allocate(slaveId) call in "/maintenance/schedule".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44396/#review122153 --- Bad patch! Reviews applied: [44396] Failed command:

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/#review122151 --- Patch looks great! Reviews applied: [44070, 44071, 44073, 44260,

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44258/#review122146 --- src/master/http.cpp (line 2016)

Re: Review Request 43293: Ignored invalid env vars.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43293/#review122147 --- Patch looks great! Reviews applied: [43293] Passed command:

Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

> On March 4, 2016, 7:42 a.m., Benjamin Bannier wrote: > > I think using a `TemporaryDirectoryTest` fixture is the right approach, but > > what I find unfortunate about your approach is that with this patch we'd > > create a temporary directory and incur the overhead for all tests in this > >

Re: Review Request 41049: New python lib with only the executor driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41049/ --- (Updated March 4, 2016, 7:51 p.m.) Review request for mesos, Till Toenshoff

Re: Review Request 43701: Added a command executor based on the new V1 API.

> On Feb. 29, 2016, 2:24 a.m., Vinod Kone wrote: > > Thanks for working on this Qian! > > > > It's really hard to tell what changes were made to the http command > > executor that are different from the command executor. I would suggest you > > to split this into multiple reviews to make

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

> On March 3, 2016, 10:15 p.m., Joseph Wu wrote: > > src/master/contender.hpp, lines 17-18 > > > > > > This whole file seems like a pretty substantial change. I'd recommend > > pulling it out into a separate review

Re: Review Request 44269: Added the framework of 'network/cni' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44269/#review122123 --- src/slave/containerizer/mesos/isolators/network/cni.cpp (line

Re: Review Request 44269: Added the framework of 'network/cni' isolator.

> On March 4, 2016, 3:30 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 80 > > > > > > Shouldn't we do a size check here as well ? Bail out if we don't have > > any

Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44380/ --- (Updated March 4, 2016, 6:56 p.m.) Review request for mesos and Benjamin

Re: Review Request 44391: Added document for overlayfs backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44391/#review122127 --- Patch looks great! Reviews applied: [44390, 44391] Passed

Re: Review Request 44200: Add agent flags for specifying CNI plugin and config directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44200/#review122122 --- Ship it! Ship It! - Avinash sridharan On March 4, 2016,

Re: Review Request 44269: Added the framework of 'network/cni' isolator.

> On March 4, 2016, 3:30 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, lines 108-115 > > > > > > isn't this the same as !nameValue.isSome() ? > > > > Also

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

> On March 3, 2016, 5:55 a.m., Bernd Mathiske wrote: > > src/tests/slave_recovery_tests.cpp, line 3461 > > > > > > Why was this moved up here? Couldn't this be in line 3389/3402? > > Joseph Wu wrote: > In this

Re: Review Request 44336: Removed numeric suffixes where appropriate in allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44336/#review122110 --- Patch looks great! Reviews applied: [43105, 44331, 44332, 44333,

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

> On March 3, 2016, 10:15 p.m., Joseph Wu wrote: > > src/master/main.cpp, line 61 > > > > > > What about this header? Do you mean why is this header not ""? It's different from - it includes the

Re: Review Request 44269: Added the framework of 'network/cni' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44269/ --- (Updated March 5, 2016, 1:07 a.m.) Review request for mesos, Avinash

Re: Review Request 44269: Added the framework of 'network/cni' isolator.

> On March 4, 2016, 11:30 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni.hpp, line 28 > > > > > > Maybe: > > The isolator implements support for Container Network

Review Request 44396: Updated unavailable in batch to avoid several allocate(slaveId) call in "/maintenance/schedule".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44396/ --- Review request for mesos, Joris Van Remoortere and Joseph Wu. Bugs: MESOS-4838

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

> On March 3, 2016, 10:15 p.m., Joseph Wu wrote: > > src/master/contender.hpp, lines 17-18 > > > > > > This whole file seems like a pretty substantial change. I'd recommend > > pulling it out into a separate review

Re: Review Request 44200: Add agent flags for specifying CNI plugin and config directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44200/ --- (Updated March 5, 2016, 12:14 a.m.) Review request for mesos, Avinash

Re: Review Request 44269: Added the framework of 'network/cni' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44269/#review122092 --- Patch looks great! Reviews applied: [44200, 44269] Passed

Re: Review Request 43883: Added allocator metrics for the number of offer filters per framework.

> On March 4, 2016, 2:05 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 288-297 > > > > > > I suggest we create a helper in `Metrics` for this. Also, minor nit: in > >

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

> On March 4, 2016, 2:05 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 275-280 > > > > > > I would pull this into a helper in `Metrics` similar to > >

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

> On March 4, 2016, 2:05 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/metrics.hpp, line 27 > > > > > > Kill this line. As if it never was there now. > On March 4, 2016, 2:05 p.m., Alexander

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/ --- (Updated March 4, 2016, 5:01 p.m.) Review request for mesos, Alexander

Re: Review Request 43884: Added allocator metrics for used quotas.

> On March 4, 2016, 2:46 p.m., Alexander Rukletsov wrote: > > docs/monitoring.md, line 905 > > > > > > In the same vein as `allocator/allocated/KIND`, this should be > > something like

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/ --- (Updated March 4, 2016, 5:01 p.m.) Review request for mesos, Alexander

Re: Review Request 43293: Ignored invalid env vars.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43293/ --- (Updated March 4, 2016, 3:34 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 44269: Added the framework of 'network/cni' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44269/#review122077 --- src/slave/containerizer/mesos/isolators/network/cni.hpp (line

Review Request 44391: Added document for overlayfs backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44391/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4866

Re: Review Request 44227: Added AWAIT_READY() call to reservation_endpoint_tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44227/#review122081 --- Ship it! Ship It! - Till Toenshoff On March 4, 2016, 3:07

Re: Review Request 44227: Added AWAIT_READY() call to reservation_endpoint_tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44227/ --- (Updated March 4, 2016, 3:07 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 44382: Update leveldb-1.4.patch to support PowerPC LE platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44382/#review122078 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

> On March 3, 2016, 5:55 a.m., Bernd Mathiske wrote: > > src/tests/slave_recovery_tests.cpp, line 3461 > > > > > > Why was this moved up here? Couldn't this be in line 3389/3402? > > Joseph Wu wrote: > In this

Re: Review Request 44332: Fixed a typo in the HierarchicalAllocatorTest.CoarseGrained test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44332/ --- (Updated March 4, 2016, 2:52 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 44336: Removed numeric suffixes where appropriate in allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44336/ --- (Updated March 4, 2016, 2:52 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43630: Especially updated scheduler tests to use the updated MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43630/#review122079 --- Ship it! - Bernd Mathiske On March 2, 2016, 1:45 p.m.,

Re: Review Request 44200: Add agent flags for specifying CNI plugin and config directories.

> On March 2, 2016, 4:07 p.m., Avinash sridharan wrote: > > src/slave/flags.cpp, line 694 > > > > > > s/directory/location > > > > remove this line: > > This flag is used for\n" > > "the

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review122072 --- src/tests/container_logger_tests.cpp (line 301)

Re: Review Request 44269: Added the framework of 'network/cni' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44269/ --- (Updated March 4, 2016, 10:34 p.m.) Review request for mesos, Avinash

Review Request 44390: No need to enable SSL when using registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44390/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support Power LE platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/#review122075 --- Bad patch! Reviews applied: [44372] Failed command:

Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44380/#review122073 --- Patch looks great! Reviews applied: [44380] Passed command:

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/#review122057 --- docs/monitoring.md (line 905)

Re: Review Request 43614: Refactor MesosTest and remove cleanup logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43614/#review122067 --- Fix it, then Ship it! src/tests/mesos.hpp (line 190)

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/#review122066 --- Ship it! Note to reviewers: the resulting code can still be

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

> On March 3, 2016, 5:22 a.m., Bernd Mathiske wrote: > > src/tests/cluster.hpp, line 213 > > > > > > I don't think we need this constructor. We are using an instance of > > this merely as an aggregate temporary

Re: Review Request 44332: Fixed a typo in the HierarchicalAllocatorTest.CoarseGrained test.

> On March 3, 2016, 7:04 p.m., Joris Van Remoortere wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 806 > > > > > > Can you fix the extra `.` here as well? Sure - Alexander

Re: Review Request 43883: Added allocator metrics for the number of offer filters per framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/#review122056 --- Fix it, then Ship it!

Re: Review Request 43882: Added allocation metrics for allocation time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/#review122055 --- Fix it, then Ship it!

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/#review122053 --- Fix it, then Ship it!

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/#review122047 --- Fix it, then Ship it! src/master/allocator/mesos/metrics.hpp

Re: Review Request 44366: Added GPUs as an explicit resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44366/#review122059 --- src/slave/containerizer/containerizer.cpp (line 105)

Re: Review Request 44336: Removed numeric suffixes where appropriate in allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44336/#review122063 --- Ship it! Ship It! - Bernd Mathiske On March 3, 2016, 5:01

Re: Review Request 44379: Correctly parse perf stat format for 3.10 kernel.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44379/#review122062 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 44335: Moved variable declarations closer to where they are used.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44335/#review122061 --- Ship it! Ship It! - Bernd Mathiske On March 3, 2016, 5:01

Re: Review Request 44334: Cleaned up empty hashmaps from allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44334/#review122058 --- "{}" is short, but cryptic. It is unclear what kind of entity is

Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44378/#review122054 --- Bad patch! Reviews applied: [44378] Failed command:

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

> On March 1, 2016, 11:48 a.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 268-272 > > > > > > Does it make sense to wrap framework-related metrics in a separate > > struct in

Re: Review Request 44343: Used single space in license check error message.

> On March 3, 2016, 8:12 p.m., Till Toenshoff wrote: > > support/mesos-style.py, line 90 > > > > > > Are the two leading spaces intentional? > > Benjamin Bannier wrote: > Yes, this is intentional to be

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

> On March 3, 2016, 3:04 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1711-1712 > > > > > > My intuition is that using `allocationScalarQuantities` will be more > >

  1   2   >