Re: Review Request 44360: Added a script to install the Nvidia GDK on a host.

2016-03-05 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44360/#review122216 --- support/install-nvidia-gdk.sh (lines 3 - 13)

Re: Review Request 44366: Added GPUs as an explicit resource.

2016-03-05 Thread Kevin Klues
> On March 4, 2016, 12:27 p.m., Klaus Ma wrote: > > OK, got it. I'll wait for more comments and then do a full pass all at once. Thanks! - Kevin --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 44427: Added --http_command_executor flag.

2016-03-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44427/#review122207 --- Patch looks great! Reviews applied: [44423, 44424, 44427]

Re: Review Request 44425: Changed mount as writable for bind backend.

2016-03-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44425/#review122206 --- Patch looks great! Reviews applied: [44425] Passed command:

Re: Review Request 43701: Added a command executor based on the new V1 API.

2016-03-05 Thread Qian Zhang
> On Feb. 29, 2016, 10:24 a.m., Vinod Kone wrote: > > Thanks for working on this Qian! > > > > It's really hard to tell what changes were made to the http command > > executor that are different from the command executor. I would suggest you > > to split this into multiple reviews to make

Review Request 44427: Added --http_command_executor flag.

2016-03-05 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44427/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-3558

Review Request 44425: Changed mount as writable for bind backend.

2016-03-05 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44425/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-4876

Review Request 44423: Added HTTP command executor to make files.

2016-03-05 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44423/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-3558

Re: Review Request 44366: Added GPUs as an explicit resource.

2016-03-05 Thread Klaus Ma
> On March 4, 2016, 8:27 p.m., Klaus Ma wrote: > > src/slave/containerizer/containerizer.cpp, line 115 > > > > > > I'd like to say "`--navidia_gpus` must be set when specifying `gpu` > > resources." > > Kevin

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

2016-03-05 Thread Benjamin Bannier
> On March 2, 2016, 2:58 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/metrics.hpp, line 37 > > > > > > You don't really need to call `.self()` here, there exists an `defer` > > override taking

Re: Review Request 44421: Added support for "overlay" keyword.

2016-03-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44421/#review122195 --- I agree this could works completely. But I not sure whether we

Re: Review Request 44421: Added support for "overlay" keyword.

2016-03-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44421/#review122193 --- Patch looks great! Reviews applied: [44421] Passed command:

Re: Review Request 44421: Added support for "overlay" keyword.

2016-03-05 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44421/ --- (Updated 三月 5, 2016, 8:04 a.m.) Review request for mesos, haosdent huang, Jie