Re: Review Request 42705: Update docs for --weights flag and authorization.

2016-03-08 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42705/#review122694 --- Ship it! Ship It! - Adam B On March 8, 2016, 8:09 p.m.,

Re: Review Request 43824: Addressed comments of 41672.

2016-03-08 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/#review122693 --- src/tests/hierarchical_allocator_tests.cpp (lines 236 - 239)

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

2016-03-08 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44408/#review122691 --- Fix it, then Ship it! Looks great! One more little bit of

Re: Review Request 44512: Support to get weights info by /weights.

2016-03-08 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44512/ --- (Updated March 9, 2016, 6:36 a.m.) Review request for mesos and Adam B.

Re: Review Request 44511: Add registry tests for /weights endpoint.

2016-03-08 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44511/ --- (Updated March 9, 2016, 6:34 a.m.) Review request for mesos and Adam B.

Re: Review Request 44531: Fixed parsing network ip address with docker.

2016-03-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44531/#review122687 --- Patch looks great! Reviews applied: [44531] Passed command:

Re: Review Request 44269: Added the framework of 'network/cni' isolator.

2016-03-08 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44269/#review122686 --- I will discard this patch since I have broken it into two:

Re: Review Request 44269: Added the framework of 'network/cni' isolator.

2016-03-08 Thread Qian Zhang
> On March 9, 2016, 2:09 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, lines 95-288 > > > > > > I would strongly recommend move all `parse` and `validation` operations > > to

Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

2016-03-08 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44555/ --- Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. Bugs:

Re: Review Request 41790: Add tests for /weights endpoint.

2016-03-08 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated March 9, 2016, 5:52 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 44470: Implemented runtime isoaltor default entrypoint test.

2016-03-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44470/#review122682 --- src/tests/containerizer/runtime_isolator_tests.cpp (line 302)

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

2016-03-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44258/ --- (Updated 三月 9, 2016, 5:38 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

2016-03-08 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44320/ --- (Updated March 9, 2016, 6:35 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

2016-03-08 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44450/ --- (Updated March 9, 2016, 5:19 a.m.) Review request for mesos and Adam B.

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

2016-03-08 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/ --- (Updated March 9, 2016, 6:07 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

2016-03-08 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44320/ --- (Updated March 9, 2016, 5:58 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 44319: Removed initialize method from the authorizer interface.

2016-03-08 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44319/ --- (Updated March 9, 2016, 5:54 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 44319: Removed initialize method from the authorizer interface.

2016-03-08 Thread Alexander Rojas
> On March 8, 2016, 7:16 p.m., Vinod Kone wrote: > > src/examples/test_authorizer_module.cpp, lines 41-61 > > > > > > why can't you use Authorizer::create() here instead of repeating this > > flags

Re: Review Request 44289: Added support for contender and detector modules.

2016-03-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/#review122672 --- Bad review! Reviews applied: [44289] Error: No reviewers

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

2016-03-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44523/#review122669 --- Patch looks great! Reviews applied: [44515, 44523] Passed

Re: Review Request 42705: Update docs for --weights flag and authorization.

2016-03-08 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42705/ --- (Updated March 9, 2016, 4:09 a.m.) Review request for mesos and Adam B.

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-08 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/#review122668 --- Fix it, then Ship it! src/slave/constants.cpp (line 58)

Re: Review Request 44467: Implemented local puller shell command test.

2016-03-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44467/#review122667 --- src/tests/containerizer/provisioner_docker_tests.cpp (lines 340

Re: Review Request 43824: Addressed comments of 41672.

2016-03-08 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/ --- (Updated March 9, 2016, 3:17 a.m.) Review request for mesos, Adam B and

Re: Review Request 43824: Addressed comments of 41672.

2016-03-08 Thread Yongqiao Wang
> On March 8, 2016, 11:20 p.m., Adam B wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 233 > > > > > > `getAllocations` is too general a name for what this function actually > > does. More like

Re: Review Request 44467: Implemented local puller shell command test.

2016-03-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44467/#review122664 --- src/tests/containerizer/provisioner_docker_tests.cpp (line 335)

Review Request 44549: Introduced a protobuf message "NetworkConfig".

2016-03-08 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44549/ --- Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. Bugs:

Re: Review Request 44531: Fixed parsing network ip address with docker.

2016-03-08 Thread Guangya Liu
> On 三月 9, 2016, 2:21 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 306-307 > > > > > > I found that the NetworkMode is `default` when using `bridge` mode, so > > the value of `networkModeValue` would

Re: Review Request 44456: Added Appc provisioner integration test.

2016-03-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44456/#review122660 --- Patch looks great! Reviews applied: [44533, 44534, 44299, 44455,

Re: Review Request 44531: Fixed parsing network ip address with docker.

2016-03-08 Thread Travis Hegner
> On March 9, 2016, 2:21 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 306-307 > > > > > > I found that the NetworkMode is `default` when using `bridge` mode, so > > the value of `networkModeValue`

Re: Review Request 44531: Fixed parsing network ip address with docker.

2016-03-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44531/#review122657 --- src/docker/docker.cpp (lines 306 - 307)

Re: Review Request 44439: Added device support in cgroups abstraction.

2016-03-08 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44439/#review122646 --- src/linux/cgroups.hpp (lines 628 - 633)

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

2016-03-08 Thread Anurag Singh
> On March 3, 2016, 10:15 p.m., Joseph Wu wrote: > > src/master/contender.hpp, lines 17-18 > > > > > > This whole file seems like a pretty substantial change. I'd recommend > > pulling it out into a separate review

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

2016-03-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44258/ --- (Updated 三月 9, 2016, 1:47 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

2016-03-08 Thread fan du
> On March 7, 2016, 10:43 p.m., Jie Yu wrote: > > src/master/master.cpp, line 2846 > > > > > > I looked weird to me that we increase the metrics for reserve resources > > in 'authorizeXXX' function. Can you do

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

2016-03-08 Thread Anurag Singh
> On March 3, 2016, 10:15 p.m., Joseph Wu wrote: > > include/mesos/scheduler.hpp, lines 44-49 > > > > > > A forward declaration isn't required anymore. You can just include the > > header(s) from the previous

Re: Review Request 44289: Added support for contender and detector modules.

2016-03-08 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/ --- (Updated March 9, 2016, 1:39 a.m.) Review request for mesos and Benjamin

Review Request 44546: Moved functions in promises to a common header file.

2016-03-08 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44546/ --- Review request for mesos. Repository: mesos Description --- Moved

Review Request 44547: Added functions in promises to the collect header.

2016-03-08 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44547/ --- Review request for mesos. Repository: mesos Description --- Added

Review Request 44545: Separated standalone and zookeeper classes.

2016-03-08 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44545/ --- Review request for mesos. Repository: mesos Description --- Instead of

Review Request 44544: Moved contender and detector definitions into separate directories.

2016-03-08 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44544/ --- Review request for mesos. Repository: mesos Description --- Moved

Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.

2016-03-08 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44543/ --- Review request for mesos. Repository: mesos Description ---

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

2016-03-08 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated March 9, 2016, 1:34 a.m.) Review request for mesos and Benjamin

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

2016-03-08 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/ --- (Updated March 9, 2016, 1:35 a.m.) Review request for mesos and Benjamin

Re: Review Request 44366: Added GPUs as an explicit resource.

2016-03-08 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44366/#review122638 --- Could you update the description to reflect the new state of the

Re: Review Request 44365: Added flag to specify available Nvidia GPUs on an agent's command line.

2016-03-08 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44365/#review122628 --- src/slave/flags.hpp (line 92)

Re: Review Request 44531: Fixed parsing network ip address with docker.

2016-03-08 Thread Dan Osborne
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44531/#review122637 --- Ship it! Ship It! - Dan Osborne On March 8, 2016, 10:54

Re: Review Request 44363: Added stubs for the Nvidia GPU device isolator.

2016-03-08 Thread Vikrama Ditya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44363/#review122633 --- Ship it! Ship It! - Vikrama Ditya On March 8, 2016, 10:46

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

2016-03-08 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44523/#review122630 --- src/master/constants.cpp (lines 52 - 53)

Re: Review Request 44513: Added missing flag to authentication docs.

2016-03-08 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44513/#review122626 --- Ship it! Ship It! - Adam B On March 8, 2016, 7:15 a.m.,

Re: Review Request 42705: Update docs for --weights flag and authorization.

2016-03-08 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42705/#review122625 --- Need to update the --weights flags help message in flags.cpp too.

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

2016-03-08 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44258/#review122623 --- src/tests/master_maintenance_tests.cpp (line 481)

Re: Review Request 44299: Added unit test for file URI fetcher.

2016-03-08 Thread Jojy Varghese
> On March 8, 2016, 1:57 a.m., Jie Yu wrote: > > src/tests/containerizer/provisioner_appc_tests.cpp, lines 590-591 > > > > > > Looking at the original code, why do we need this id? Should that > > always be the

Re: Review Request 44364: Added infrastructure for Nvidia GPU specific tests.

2016-03-08 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44364/#review122624 --- src/tests/containerizer/nvidia_gpu_isolator_tests.cpp (lines 30

Re: Review Request 43824: Addressed comments of 41672.

2016-03-08 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/#review122622 --- src/tests/hierarchical_allocator_tests.cpp (line 233)

Re: Review Request 44514: Implemented NetworkCniIsolatorProcess::prepare().

2016-03-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/#review122619 --- Patch looks great! Reviews applied: [44004, 44200, 44269, 44514]

Re: Review Request 43920: Added a helper function to stout : os/which.hpp.

2016-03-08 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43920/#review122613 --- Looks good. Before I give a "Ship It!", your next steps should

Re: Review Request 44456: Added Appc provisioner integration test.

2016-03-08 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44456/ --- (Updated March 8, 2016, 10:50 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 44299: Added unit test for file URI fetcher.

2016-03-08 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44299/ --- (Updated March 8, 2016, 10:49 p.m.) Review request for mesos and Jie Yu.

Review Request 44534: Refactored AppcImageFetcherTest.

2016-03-08 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44534/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 44366: Added GPUs as an explicit resource.

2016-03-08 Thread Vikrama Ditya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44366/#review122612 --- src/slave/containerizer/containerizer.cpp (line 107)

Review Request 44533: Fixed AppcStoreTest fixture to remove imageId from test image.

2016-03-08 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44533/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 44455: Fixed AppcImageFetcherTest for manifest formatting.

2016-03-08 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44455/ --- (Updated March 8, 2016, 10:45 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

2016-03-08 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44258/#review122610 --- Ship it! Ship It! - Joseph Wu On March 4, 2016, 5:23 p.m.,

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

2016-03-08 Thread Joseph Wu
> On March 3, 2016, 2:15 p.m., Joseph Wu wrote: > > src/master/contender.hpp, lines 17-18 > > > > > > This whole file seems like a pretty substantial change. I'd recommend > > pulling it out into a separate review

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

2016-03-08 Thread Joseph Wu
> On March 8, 2016, 3:50 a.m., Bernd Mathiske wrote: > > src/tests/scheduler_event_call_tests.cpp, line 367 > > > > > > In most other places you have the blank line before the detector. True. Fixed four places

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

2016-03-08 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- (Updated March 8, 2016, 2:33 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43630: Especially updated scheduler tests to use the updated MesosTest helpers.

2016-03-08 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43630/ --- (Updated March 8, 2016, 2:32 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 44531: Fixed parsing network ip address with docker.

2016-03-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44531/ --- (Updated March 8, 2016, 9:58 p.m.) Review request for mesos, Jie Yu and Travis

Re: Review Request 44363: Added stubs for the Nvidia GPU device isolator.

2016-03-08 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44363/#review122600 --- Fix it, then Ship it! Looks good thanks, can you ask Jie about

Review Request 44531: Fixed parsing network ip address with docker.

2016-03-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44531/ --- Review request for mesos, Jie Yu and Travis Hegner. Repository: mesos

Re: Review Request 44531: Fixed parsing network ip address with docker.

2016-03-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44531/ --- (Updated March 8, 2016, 9:58 p.m.) Review request for mesos, Jie Yu and Travis

Re: Review Request 44513: Added missing flag to authentication docs.

2016-03-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44513/#review122594 --- Patch looks great! Reviews applied: [44513] Passed command:

Re: Review Request 44361: Added configure flags to build with Nvidia GPU support.

2016-03-08 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44361/#review122582 --- Fix it, then Ship it! Looks good, thanks! configure.ac

Re: Review Request 44512: Support to get weights info by /weights.

2016-03-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44512/#review122584 --- Patch looks great! Reviews applied: [41681, 43863, 44512]

Re: Review Request 44360: Added a script to install the Nvidia GDK on a host.

2016-03-08 Thread Ben Mahler
> On March 8, 2016, 7:15 p.m., Ben Mahler wrote: > > Looks good, main thing is just to add some context to the installer script > > so that others understand why it exists. Could you update the testing done so that others can tell how you tested this? - Ben

Re: Review Request 44360: Added a script to install the Nvidia GDK on a host.

2016-03-08 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44360/#review122572 --- Looks good, main thing is just to add some context to the

Review Request 44523: Changed the master's default HTTP authentication realm.

2016-03-08 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44523/ --- Review request for mesos, Adam B, Alexander Rojas, and Till Toenshoff. Bugs:

Review Request 44515: Added agent flags for HTTP authentication.

2016-03-08 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/ --- Review request for mesos, Adam B, Alexander Rojas, and Till Toenshoff. Bugs:

Re: Review Request 41049: New python lib with only the executor driver.

2016-03-08 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41049/#review122564 --- Sorry for the spam, I added -static-libstdc++ to allow better

Re: Review Request 41049: New python lib with only the executor driver.

2016-03-08 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41049/ --- (Updated March 8, 2016, 6:25 p.m.) Review request for mesos, Till Toenshoff

Re: Review Request 44319: Removed initialize method from the authorizer interface.

2016-03-08 Thread Vinod Kone
> On March 8, 2016, 1:08 a.m., Vinod Kone wrote: > > include/mesos/authorizer/authorizer.hpp, line 58 > > > > > > seems weird that this interface takes ACLs as a param. can we make it > > take Parameters instead? I

Re: Review Request 41049: New python lib with only the executor driver.

2016-03-08 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41049/ --- (Updated March 8, 2016, 6:15 p.m.) Review request for mesos, Till Toenshoff

Re: Review Request 41632: Windows: Added Console Ctrl handling in `slave.cpp`.

2016-03-08 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41632/ --- (Updated March 8, 2016, 6:15 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 41632: Windows: Added Console Ctrl handling in `slave.cpp`.

2016-03-08 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41632/ --- (Updated March 8, 2016, 6:10 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44269: Added the framework of 'network/cni' isolator.

2016-03-08 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44269/#review122546 --- src/slave/containerizer/mesos/isolators/network/cni.cpp (line

Re: Review Request 43920: Added a helper function to stout : os/which.hpp.

2016-03-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43920/#review122552 --- Patch looks great! Reviews applied: [43920] Passed command:

Re: Review Request 44474: Improve master tasks metrics.

2016-03-08 Thread Cong Wang
> On March 7, 2016, 11:17 p.m., Neil Conway wrote: > > src/master/master.cpp, line 6461 > > > > > > Seems like we use post-increment elsewhere in this RR? I am not sure I understand your question, but

Re: Review Request 44474: Improve master tasks metrics.

2016-03-08 Thread Cong Wang
> On March 8, 2016, 12:37 a.m., Ian Downes wrote: > > src/master/metrics.cpp, line 215 > > > > > > foreach? I don't think we can use foreach over enum, can we? - Cong

Re: Review Request 44474: Improve master tasks metrics.

2016-03-08 Thread Cong Wang
> On March 8, 2016, 12:37 a.m., Ian Downes wrote: > > src/master/master.cpp, line 6461 > > > > > > I'm not familiar with this code but it appears to be changing the > > behavior substantially. > > > >

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

2016-03-08 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/ --- (Updated March 8, 2016, 5:50 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

2016-03-08 Thread Anurag Singh
> On March 3, 2016, 10:15 p.m., Joseph Wu wrote: > > src/master/contender.hpp, lines 17-18 > > > > > > This whole file seems like a pretty substantial change. I'd recommend > > pulling it out into a separate review

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

2016-03-08 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44320/ --- (Updated March 8, 2016, 5:44 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 44319: Removed initialize method from the authorizer interface.

2016-03-08 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44319/ --- (Updated March 8, 2016, 5:43 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

2016-03-08 Thread Travis Hegner
> On March 7, 2016, 5:36 p.m., Timothy Chen wrote: > > Are you still be able to work on this? We like to get this merged, so if > > you can't or don't reply we will create a new patch based on this. > > Travis Hegner wrote: > Hi Timothy, > > I've been stalling this for

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

2016-03-08 Thread Timothy Chen
> On March 7, 2016, 5:36 p.m., Timothy Chen wrote: > > Are you still be able to work on this? We like to get this merged, so if > > you can't or don't reply we will create a new patch based on this. > > Travis Hegner wrote: > Hi Timothy, > > I've been stalling this for

Re: Review Request 43798: Added overview section to upgrades.md.

2016-03-08 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43798/ --- (Updated March 8, 2016, 4:18 p.m.) Review request for mesos, Michael Park,

Re: Review Request 43798: Added overview section to upgrades.md.

2016-03-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43798/#review122533 --- Bad patch! Reviews applied: [43798, 43792] Failed command:

Review Request 44514: Implemented NetworkCniIsolatorProcess::prepare().

2016-03-08 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/ --- Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. Bugs:

Re: Review Request 44511: Add registry tests for /weights endpoint.

2016-03-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44511/#review122528 --- Patch looks great! Reviews applied: [41681, 43863, 41790, 44511]

  1   2   >