Re: Review Request 44694: Enabled multiple calls to ModuleManager::load().

2016-03-10 Thread Kapil Arya
> On March 10, 2016, 10:03 p.m., Joris Van Remoortere wrote: > > src/module/manager.cpp, lines 50-53 > > > > > > Why the re-ordering here? The idea is to keep all mappings close together. > On March

Re: Review Request 44694: Enabled multiple calls to ModuleManager::load().

2016-03-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44694/ --- (Updated March 11, 2016, 2:50 a.m.) Review request for mesos, Joris Van

Re: Review Request 44470: Implemented runtime isoaltor default entrypoint test.

2016-03-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44470/#review123108 --- Patch looks great! Reviews applied: [43956, 44467, 44469, 44470]

Re: Review Request 42127: Did not rescind offer if only ALLOCATION_SLACK resources incuded.

2016-03-10 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42127/ --- (Updated March 11, 2016, 3:13 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 41859: Launch tasks after evicting executors.

2016-03-10 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41859/ --- (Updated March 11, 2016, 3:10 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 41858: Added helper functions to kill executor.

2016-03-10 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41858/ --- (Updated March 11, 2016, 2:56 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 41857: Got evictable executors.

2016-03-10 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41857/ --- (Updated March 11, 2016, 2:52 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 41856: Added helper functions to get allocation slack.

2016-03-10 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41856/ --- (Updated March 11, 2016, 2:50 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 41855: Trace pending executors.

2016-03-10 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41855/ --- (Updated March 11, 2016, 2:17 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 41850: Add map to trace evictable executors.

2016-03-10 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41850/ --- (Updated March 11, 2016, 2:15 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 40379: MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription.

2016-03-10 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40379/ --- (Updated March 11, 2016, 2:07 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 42516: Add support for user-defined networks.

2016-03-10 Thread Guangya Liu
> On 二月 18, 2016, 10:44 p.m., Jie Yu wrote: > > include/mesos/v1/mesos.proto, lines 1543-1544 > > > > > > We're going to introduce a ContainerInfo.NetworkInfo.name to allow > > frameworks to specify the network

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-10 Thread Alexander Rojas
> On March 10, 2016, 9:45 a.m., Adam B wrote: > > src/slave/flags.cpp, line 684 > > > > > > I wonder if/when we'll ever deprecate one of these formats. > > https://issues.apache.org/jira/browse/MESOS-2281 > >

Re: Review Request 44342: XFS disk resource isolator.

2016-03-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44342/#review123103 --- Patch looks great! Reviews applied: [44342] Passed command:

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

2016-03-10 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44678/#review123102 --- src/authentication/http/basic_authenticator_factory.cpp (lines

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-10 Thread Alexander Rojas
> On March 10, 2016, 9:45 a.m., Adam B wrote: > > src/tests/mesos.cpp, lines 182-184 > > > > > > Any reason you can't reuse the previous `path` and `fd` variables? > > Greg Mann wrote: > We could do that;

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

2016-03-10 Thread Alexander Rojas
> On March 10, 2016, 10:06 p.m., Vinod Kone wrote: > > src/Makefile.am, line 158 > > > > > > any reason why this should be exposed in the include directory? Main reason is because of this `static Try

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

2016-03-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/#review122991 --- include/mesos/authorizer/authorizer.hpp (line 43)

Re: Review Request 43709: Windows:[3/3] Enabled zlib compression tests.

2016-03-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43709/#review123087 --- 3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt (lines

Re: Review Request 43708: Windows:[2/3] Added zlib compilation steps for Windows.

2016-03-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43708/#review123086 --- 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake (lines

Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

2016-03-10 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40375/ --- (Updated March 11, 2016, 11:21 a.m.) Review request for mesos, Guangya Liu,

Re: Review Request 44694: Enabled multiple calls to ModuleManager::load().

2016-03-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44694/#review123083 --- Fix it, then Ship it! src/module/manager.cpp (line 22)

Re: Review Request 44692: Added exception for master/slave to exclude name in endpoint help.

2016-03-10 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44692/ --- (Updated March 11, 2016, 3:12 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 44690: Added 'delegate' info to the Help process.

2016-03-10 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44690/#review123085 --- Ship it! Ship It! - Ben Mahler On March 11, 2016, 3:11

Re: Review Request 44690: Added 'delegate' info to the Help process.

2016-03-10 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44690/ --- (Updated March 11, 2016, 3:11 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 44693: Updated endpoint docs based on adding the delegate to the Help process.

2016-03-10 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44693/#review123084 --- Ship it! Ship It! - Ben Mahler On March 11, 2016, 1:40

Re: Review Request 44690: Added 'delegate' info to the Help process.

2016-03-10 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44690/ --- (Updated March 11, 2016, 3:05 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 44694: Enabled multiple calls to ModuleManager::load().

2016-03-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44694/#review123077 --- src/common/type_utils.cpp (lines 155 - 182)

Re: Review Request 44690: Added 'delegate' info to the Help process.

2016-03-10 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44690/#review123076 --- 3rdparty/libprocess/src/help.cpp (lines 97 - 100)

Re: Review Request 44691: Fixed comment in support/generate-endpoint-help.py.

2016-03-10 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44691/#review123080 --- Ship it! Ship It! - Ben Mahler On March 11, 2016, 1:39

Re: Review Request 44670: Added master_detector and master_contender flags.

2016-03-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44670/#review123078 --- Patch looks great! Reviews applied: [44287, 44288, 44543, 44544,

Re: Review Request 44470: Implemented runtime isoaltor default entrypoint test.

2016-03-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44470/#review123074 --- Fix it, then Ship it!

Re: Review Request 44689: Changed ProcessManager.delegate to an Option type.

2016-03-10 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44689/#review123075 --- Ship it! Ship It! - Ben Mahler On March 11, 2016, 1:38

Re: Review Request 44469: Implemented runtime isolator default cmd test.

2016-03-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44469/#review123073 --- Fix it, then Ship it!

Re: Review Request 44473: Added decrement operator to Counter.

2016-03-10 Thread Ben Mahler
> On March 10, 2016, 10:30 p.m., Ben Mahler wrote: > > It looks like we need to update the documentation at the top of Counter to > > reflect that we intentionally left out decrementing, because we found that > > some metrics libraries and systems have a counter type that only supports > >

Re: Review Request 43956: Created base docker image for test suite.

2016-03-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43956/#review123068 --- Fix it, then Ship it!

Re: Review Request 44696: Updated doc for the newly introduced 'NetworkInfo.name' field.

2016-03-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44696/#review123066 --- Ship it! Ship It! - Jie Yu On March 11, 2016, 1:40 a.m.,

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

2016-03-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44258/#review123064 --- Ship it! Ship It! - Joris Van Remoortere On March 9, 2016,

Re: Review Request 44537: Update PendingUnavailabilityTest to use the new scheduler mock.

2016-03-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44537/#review123065 --- Ship it! Ship It! - Joris Van Remoortere On March 10, 2016,

Re: Review Request 44473: Added decrement operator to Counter.

2016-03-10 Thread Cong Wang
> On March 10, 2016, 10:30 p.m., Ben Mahler wrote: > > It looks like we need to update the documentation at the top of Counter to > > reflect that we intentionally left out decrementing, because we found that > > some metrics libraries and systems have a counter type that only supports > >

Review Request 44696: Updated doc for the newly introduced 'NetworkInfo.name' field.

2016-03-10 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44696/ --- Review request for mesos, Avinash sridharan, Gilbert Song, Jie Yu, and Neil

Review Request 44693: Updated endpoint docs based on adding the delegate to the Help process.

2016-03-10 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44693/ --- Review request for mesos, Ben Mahler and Neil Conway. Bugs: MESOS-4787

Review Request 44692: Added exception for master/slave to exclude name in endpoint help.

2016-03-10 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44692/ --- Review request for mesos, Ben Mahler and Neil Conway. Bugs: MESOS-4787

Review Request 44691: Fixed comment in support/generate-endpoint-help.py.

2016-03-10 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44691/ --- Review request for mesos, Ben Mahler and Neil Conway. Bugs: MESOS-4787

Review Request 44690: Added 'delegate' info to the Help process.

2016-03-10 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44690/ --- Review request for mesos, Ben Mahler and Neil Conway. Bugs: MESOS-4787

Review Request 44689: Changed ProcessManager.delegate to an Option type.

2016-03-10 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44689/ --- Review request for mesos, Ben Mahler and Neil Conway. Bugs: MESOS-4914

Review Request 44694: Enabled multiple calls to ModuleManager::load().

2016-03-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44694/ --- Review request for mesos, Joris Van Remoortere, Michael Park, and Till

Re: Review Request 44299: Added unit test for file URI fetcher.

2016-03-10 Thread Jie Yu
> On March 11, 2016, 12:43 a.m., Jie Yu wrote: > > src/tests/containerizer/provisioner_appc_tests.cpp, lines 572-578 > > > > > > No need for this? I'll fix it for you. - Jie

Re: Review Request 44456: Added Appc provisioner integration test.

2016-03-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44456/#review123055 --- src/tests/containerizer/provisioner_appc_tests.cpp (lines 805 -

Re: Review Request 44675: Updated `/metrics/snapshot` endpoint to use `jsonify`.

2016-03-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44675/#review123054 --- Patch looks great! Reviews applied: [44675] Passed command:

Re: Review Request 44342: XFS disk resource isolator.

2016-03-10 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44342/ --- (Updated March 11, 2016, 12:55 a.m.) Review request for mesos, Jie Yu and

Re: Review Request 44455: Fixed AppcImageFetcherTest for manifest formatting.

2016-03-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44455/#review123050 --- Ship it! Ship It! - Jie Yu On March 8, 2016, 10:45 p.m.,

Re: Review Request 44299: Added unit test for file URI fetcher.

2016-03-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44299/#review123048 --- Fix it, then Ship it! Ship It!

Re: Review Request 44534: Refactored AppcImageFetcherTest.

2016-03-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44534/#review123046 --- Ship it! Ship It! - Jie Yu On March 8, 2016, 10:47 p.m.,

Re: Review Request 44191: Avoided external linkage for master constants.

2016-03-10 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44191/#review123043 --- Thanks! Are you planning to also address the slave's constants

Re: Review Request 44469: Implemented runtime isolator default cmd test.

2016-03-10 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44469/ --- (Updated March 10, 2016, 4:24 p.m.) Review request for mesos, Artem

Re: Review Request 44470: Implemented runtime isoaltor default entrypoint test.

2016-03-10 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44470/ --- (Updated March 10, 2016, 4:24 p.m.) Review request for mesos, Artem

Re: Review Request 44467: Implemented local puller shell command test.

2016-03-10 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44467/ --- (Updated March 10, 2016, 4:23 p.m.) Review request for mesos, Artem

Re: Review Request 44190: Made `Bytes` usable in `constexpr` expressions [stout].

2016-03-10 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44190/#review123038 --- 3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp

Re: Review Request 44190: Made `Bytes` usable in `constexpr` expressions [stout].

2016-03-10 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44190/#review123037 --- Ship it! Ship It! - Ben Mahler On March 1, 2016, 2:26 a.m.,

Re: Review Request 44672: Added normalize method to registry puller.

2016-03-10 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44672/ --- (Updated March 10, 2016, 3:49 p.m.) Review request for mesos, Artem

Re: Review Request 44289: Added support for contender and detector modules.

2016-03-10 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/ --- (Updated March 10, 2016, 11:46 p.m.) Review request for mesos and Benjamin

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

2016-03-10 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/ --- (Updated March 10, 2016, 11:45 p.m.) Review request for mesos and Benjamin

Re: Review Request 44670: Added master_detector and master_contender flags.

2016-03-10 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44670/ --- (Updated March 10, 2016, 11:46 p.m.) Review request for mesos and Benjamin

Re: Review Request 44546: Moved functions in promises to a common header file.

2016-03-10 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44546/ --- (Updated March 10, 2016, 11:46 p.m.) Review request for mesos and Benjamin

Re: Review Request 44669: Added createFromModule methods to MasterContender and MasterDetector.

2016-03-10 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44669/ --- (Updated March 10, 2016, 11:46 p.m.) Review request for mesos and Benjamin

Re: Review Request 44544: Moved contender and detector definitions into separate directories.

2016-03-10 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44544/ --- (Updated March 10, 2016, 11:46 p.m.) Review request for mesos and Benjamin

Re: Review Request 44547: Added functions in promises to the collect header.

2016-03-10 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44547/ --- (Updated March 10, 2016, 11:46 p.m.) Review request for mesos and Benjamin

Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.

2016-03-10 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44543/ --- (Updated March 10, 2016, 11:45 p.m.) Review request for mesos and Benjamin

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

2016-03-10 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated March 10, 2016, 11:45 p.m.) Review request for mesos and Benjamin

Re: Review Request 44545: Separated standalone and zookeeper classes.

2016-03-10 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44545/ --- (Updated March 10, 2016, 11:46 p.m.) Review request for mesos and Benjamin

Re: Review Request 44391: Added document for overlayfs backend.

2016-03-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44391/#review123035 --- Ship it! docs/container-image.md (lines 298 - 299)

Re: Review Request 44469: Implemented runtime isolator default cmd test.

2016-03-10 Thread Gilbert Song
> On March 9, 2016, 3:22 p.m., Jie Yu wrote: > > src/tests/containerizer/runtime_isolator_tests.cpp, line 102 > > > > > > Can you put this under slave's work dir? Because if all tests using the same dir for docker

Re: Review Request 43956: Created base docker image for test suite.

2016-03-10 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43956/ --- (Updated March 10, 2016, 3:37 p.m.) Review request for mesos, Artem

Re: Review Request 43956: Created base docker image for test suite.

2016-03-10 Thread Gilbert Song
> On March 8, 2016, 6:57 p.m., Guangya Liu wrote: > > src/tests/containerizer/docker_archive.hpp, lines 70-75 > > > > > > Two layer will not work with bind backend, does it make sense to enable > > `create` can

Re: Review Request 44469: Implemented runtime isolator default cmd test.

2016-03-10 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44469/ --- (Updated March 10, 2016, 3:37 p.m.) Review request for mesos, Artem

Re: Review Request 44470: Implemented runtime isoaltor default entrypoint test.

2016-03-10 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44470/ --- (Updated March 10, 2016, 3:37 p.m.) Review request for mesos, Artem

Re: Review Request 43956: Created base docker image for test suite.

2016-03-10 Thread Gilbert Song
> On March 9, 2016, 2:59 p.m., Jie Yu wrote: > > Can you also update cmakelist? cmakelist not supports test build yet. - Gilbert --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 44467: Implemented local puller shell command test.

2016-03-10 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44467/ --- (Updated March 10, 2016, 3:37 p.m.) Review request for mesos, Artem

Re: Review Request 44421: Added support for "overlay" keyword.

2016-03-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44421/#review123032 --- src/linux/fs.hpp (lines 155 - 156)

Re: Review Request 44342: XFS disk resource isolator.

2016-03-10 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44342/ --- (Updated March 10, 2016, 11:29 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 44342: XFS disk resource isolator.

2016-03-10 Thread James Peach
> On March 9, 2016, 6:03 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/disk/xfs.hpp, line 84 > > > > > > About the type: should it be `prid_t` which more accurately describes > > what it is?

Re: Review Request 44531: Fixed parsing network ip address with docker.

2016-03-10 Thread Timothy Chen
> On March 10, 2016, 11:09 p.m., Jie Yu wrote: > > src/docker/docker.cpp, lines 336-341 > > > > > > To be consistent, maybe just do `if (!ipAddressValue.isSome())` here as > > well? For now I think I'll leave it

Re: Review Request 44533: Fixed AppcStoreTest fixture to remove imageId from test image.

2016-03-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44533/#review123028 --- Ship it! Ship It! - Jie Yu On March 8, 2016, 10:46 p.m.,

Re: Review Request 44531: Fixed parsing network ip address with docker.

2016-03-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44531/#review123025 --- Fix it, then Ship it! src/docker/docker.cpp (lines 306 - 307)

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

2016-03-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44678/ --- (Updated March 10, 2016, 10:58 p.m.) Review request for mesos, Adam B,

Re: Review Request 44672: Added normalize method to registry puller.

2016-03-10 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44672/#review123019 ---

Re: Review Request 44473: Added decrement operator to Counter.

2016-03-10 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44473/#review123017 --- It looks like we need to update the documentation at the top of

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/ --- (Updated March 10, 2016, 10:16 p.m.) Review request for mesos, Adam B,

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

2016-03-10 Thread Greg Mann
> On March 10, 2016, 4:02 a.m., Alexander Rojas wrote: > > I just did a grep and I found this: > > > > ```sh > > $ ag --cpp --ignore="build/.*" '\"mesos\"' . > > # ... > > src/authentication/http/basic_authenticator_factory.cpp > > 66: Authenticator* authenticator = new

Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

2016-03-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44678/ --- Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till

Re: Review Request 44675: Updated `/metrics/snapshot` endpoint to use `jsonify`.

2016-03-10 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44675/ --- (Updated March 10, 2016, 9:59 p.m.) Review request for mesos, Michael Park,

Re: Review Request 44045: Style fixes to `stout/include/Makefile.am`.

2016-03-10 Thread Yi Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44045/#review123008 --- Ship it! Ship It! - Yi Sun On Feb. 25, 2016, 10:28 p.m.,

Re: Review Request 44042: Windows: Fixed `UUID::random` and added utime/touch to stout/os.hpp.

2016-03-10 Thread Yi Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44042/#review123007 --- Ship it! Ship It! - Yi Sun On Feb. 25, 2016, 9:16 p.m.,

Re: Review Request 44078: Windows: Added Socket compatibility `#define`s to windows.hpp.

2016-03-10 Thread Yi Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44078/#review123006 --- Ship it! Ship It! - Yi Sun On Feb. 26, 2016, 4:11 p.m.,

Re: Review Request 44077: Windows:[3/3] Transitioned Windows `system` to use `os::execlp`.

2016-03-10 Thread Yi Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44077/#review123005 --- Ship it! Ship It! - Yi Sun On Feb. 26, 2016, 4:11 p.m.,

Re: Review Request 44076: Windows: [2/3] Used `os::execlp` in launch.cpp.

2016-03-10 Thread Yi Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44076/#review123004 --- Ship it! Ship It! - Yi Sun On Feb. 26, 2016, 4:11 p.m.,

Re: Review Request 44075: Windows: [1/3] Add platform-dependent `os::execlp`.

2016-03-10 Thread Yi Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44075/#review123003 --- Ship it! Ship It! - Yi Sun On Feb. 26, 2016, 4:11 p.m.,

Re: Review Request 44046: Windows: Used `evutil_socket_t` typedef for sockets.

2016-03-10 Thread Yi Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44046/#review123001 --- Ship it! Ship It! - Yi Sun On Feb. 26, 2016, 4:09 p.m.,

Re: Review Request 44675: Updated `/metrics/snapshot` endpoint to use `jsonify`.

2016-03-10 Thread Cong Wang
> On March 10, 2016, 9:32 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/metrics/metrics.cpp, line 234 > > > > > > (1) Why not just `snapshot`? > > (2) We don't use default capture by reference. Could you

  1   2   3   >