Re: Review Request 44753: Fixed runtime isolator tests out of disk issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44753/#review123274 --- Patch looks great! Reviews applied: [44753] Passed command:

Re: Review Request 42590: Renamed reserved() to reservations().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42590/#review123270 --- Bad patch! Reviews applied: [42590] Failed command:

Review Request 44753: Fixed runtime isolator tests out of disk issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44753/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 44749: Separate XFS utilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44749/#review123269 --- Patch looks great! Reviews applied: [44342, 44749] Passed

Re: Review Request 44748: Stout: Added implementation of `read` that works on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44748/#review123268 --- Ship it! Ship It! - Daniel Pravat On March 12, 2016, 1:28

Re: Review Request 42590: Renamed reserved() to reservations().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42590/#review123267 --- include/mesos/resources.hpp (line 228)

Re: Review Request 42590: Renamed reserved() to reservations().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42590/#review123266 --- I left a comment but I'll take care of that for you before

Re: Review Request 42590: Renamed reserved() to reservations().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42590/#review123265 --- Ship it! Ship It! - Ben Mahler On March 12, 2016, 2:47

Re: Review Request 44090: Windows: Added a cast for `get/setsockopt` parameters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44090/ --- (Updated March 12, 2016, 2:54 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 42590: Renamed reserved() to reservations().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42590/ --- (Updated 三月 12, 2016, 2:47 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41772: Added helper function to flatten resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41772/ --- (Updated 三月 12, 2016, 2:46 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 44743: Improved grammar in `--help` output for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44743/#review123263 --- Patch looks great! Reviews applied: [44742, 44743] Passed

Re: Review Request 44721: Avoided external linkage for sched constants.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44721/#review123262 --- Ship it! Ship It! - Ben Mahler On March 11, 2016, 6:32

Re: Review Request 44720: Replaced `const string` slave constants with `constexpr char[]`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44720/#review123261 --- Ship it! Ship It! - Ben Mahler On March 11, 2016, 6:32

Re: Review Request 44719: Avoided external linkage for slave constants.

> On March 12, 2016, 2:28 a.m., Ben Mahler wrote: > > I'll make sure the commit description provides the similar motivation as was provided in https://reviews.apache.org/r/44191/ (although referring to the latest project style guidelines rather than performance). - Ben

Re: Review Request 44719: Avoided external linkage for slave constants.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44719/#review123258 --- Ship it! src/slave/constants.hpp (lines 110 - 112)

Re: Review Request 44718: Replaced `const string` master constants with `constexpr char[]`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44718/#review123257 --- Ship it! Ship It! - Ben Mahler On March 11, 2016, 6:32

Re: Review Request 44191: Avoided external linkage for master constants.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44191/#review123255 --- Fix it, then Ship it! We may want to update the description to

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

On March 12, 2016, 2:11 a.m., fan du wrote: > > In a separate patch, could you add documentation for these metrics to > > docs/monitoring.md? Whoops, sorry! I see that you already have the documentation :-) - Greg --- This is an

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/#review123247 --- Thanks for the edits! A few comments below.

Re: Review Request 44190: Made `Bytes` usable in `constexpr` expressions [stout].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44190/#review123253 --- Ship it! Ship It! - Ben Mahler On March 11, 2016, 6:30

Re: Review Request 44717: Marked a few Duration constants `constexpr`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44717/#review123254 --- Ship it! Ship It! - Ben Mahler On March 11, 2016, 6:32

Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/ --- (Updated March 12, 2016, 2:02 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44747: Stout: Added implementation of `write` that works on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44747/#review123252 --- Ship it! Ship It! - Yi Sun On March 12, 2016, 1:28 a.m.,

Re: Review Request 44748: Stout: Added implementation of `read` that works on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44748/#review123251 --- Ship it! Ship It! - Yi Sun On March 12, 2016, 1:28 a.m.,

Re: Review Request 44342: XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44342/ --- (Updated March 12, 2016, 1:30 a.m.) Review request for mesos, Jie Yu and Jiang

Review Request 44749: Separate XFS utilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44749/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Bugs: MESOS-4828

Review Request 44747: Stout: Added implementation of `write` that works on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44747/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Review Request 44748: Stout: Added implementation of `read` that works on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44748/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Re: Review Request 44470: Implemented runtime isoaltor default entrypoint test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44470/#review123249 --- Patch looks great! Reviews applied: [43956, 44467, 44469, 44470]

Re: Review Request 44742: Improved documentation for multiple disks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44742/ --- (Updated March 12, 2016, 1:24 a.m.) Review request for mesos and Joris Van

Re: Review Request 44456: Added Appc provisioner integration test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44456/#review123246 --- Fix it, then Ship it!

Review Request 44743: Improved grammar in `--help` output for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44743/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

Review Request 44742: Improved documentation for multiple disks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44742/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

Re: Review Request 44734: Marked a few internal functions `static`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44734/#review123242 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 44469: Implemented runtime isolator default cmd test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44469/ --- (Updated March 11, 2016, 4:16 p.m.) Review request for mesos, Artem

Re: Review Request 44470: Implemented runtime isoaltor default entrypoint test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44470/ --- (Updated March 11, 2016, 4:16 p.m.) Review request for mesos, Artem

Re: Review Request 43956: Created base docker image for test suite.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43956/ --- (Updated March 11, 2016, 4:15 p.m.) Review request for mesos, Artem

Re: Review Request 44467: Implemented local puller shell command test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44467/ --- (Updated March 11, 2016, 4:15 p.m.) Review request for mesos, Artem

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

> On March 11, 2016, 8:02 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni.hpp, line 85 > > > > > > I would suggest we have a `Info` for each container. > > > > ``` > > struct

Re: Review Request 44580: Made changes to the executor library around managing connections.

> On March 11, 2016, 10:44 p.m., Vinod Kone wrote: > > src/executor/executor.cpp, line 462 > > > > > > This if statement sounds like all combinations of "checkpoint", > > "connecting" and "recoveryTimeout" are

Re: Review Request 44580: Made changes to the executor library around managing connections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44580/ --- (Updated March 11, 2016, 11:39 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 44733: Added fault tolerance tests for the V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44733/#review123234 --- Patch looks great! Reviews applied: [44578, 44579, 44580, 44727,

Re: Review Request 44580: Made changes to the executor library around managing connections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44580/#review123223 --- Fix it, then Ship it! src/executor/executor.cpp (line 424)

Review Request 44734: Marked a few internal functions `static`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44734/ --- Review request for mesos. Repository: mesos Description --- Marked a

Re: Review Request 43911: Updated `/state` agent endpoint to use jsonify.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43911/ --- (Updated March 11, 2016, 10:33 p.m.) Review request for mesos and Michael

Re: Review Request 43910: Enhanced a test case for the `/state` agent endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43910/ --- (Updated March 11, 2016, 10:11 p.m.) Review request for mesos and Michael

Review Request 44728: Replaced `.get()` `Option` calls with `->` operator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44728/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 44731: Modified `FaultToleranceTest.SchedulerExit` to wait for shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44731/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4629

Review Request 44733: Added fault tolerance tests for the V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44733/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4629

Review Request 44727: Made `ExamplesTest.TestHTTPFramework` use the example http executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44727/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 44729: Close the connection upon framework teardown for HTTP frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44729/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4629

Review Request 44730: Refactored `model` for TaskInfo to common/.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44730/ --- Review request for mesos. Repository: mesos Description --- Also added

Re: Review Request 43823: Updated `/tasks` master endpoint to use jsonify.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43823/ --- (Updated March 11, 2016, 10:10 p.m.) Review request for mesos and Michael

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

> On March 11, 2016, 8:02 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni.hpp, line 85 > > > > > > I would suggest we have a `Info` for each container. > > > > ``` > > struct

Re: Review Request 44579: Minor fix to output state during a `CHECK` failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44579/#review123220 --- Ship it! Ship It! - Vinod Kone On March 9, 2016, 6:03 p.m.,

Re: Review Request 44578: Pass `received` argument by const ref in the executor library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44578/#review123219 --- Ship it! Ship It! - Vinod Kone On March 9, 2016, 6:03 p.m.,

Re: Review Request 42036: Windows: Added `slave/flags.cpp` to Windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42036/ --- (Updated March 11, 2016, 9:51 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

> On March 11, 2016, 9:40 p.m., Joseph Wu wrote: > > I think you should send an email to the user and dev mailing lists to ask > > for high-level feedback on this interface. We want to make sure the > > interface is broad enough to support different implementations. (And I'm > > no expert

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/#review123214 --- Ship it! Ship It! - Vinod Kone On March 11, 2016, 3:57

Re: Review Request 44722: Libprocess: Add `SOL_TCP` flag for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44722/#review123213 --- Patch looks great! Reviews applied: [44078, 44722] Passed

Re: Review Request 44670: Added master_detector and master_contender flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44670/#review123207 --- src/master/main.cpp (line 238)

Re: Review Request 44669: Added createFromModule methods to MasterContender and MasterDetector.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44669/#review123206 --- src/master/contenders/contender.cpp (line 100)

Re: Review Request 44289: Added support for contender and detector modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/#review123205 --- src/master/contenders/zookeeper.cpp (lines 27 - 33)

Re: Review Request 44545: Separated standalone and zookeeper classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44545/#review123201 --- src/master/contender.hpp (lines 17 - 18)

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/#review123196 --- Mostly nits here. include/mesos/v1/scheduler.hpp (line 39)

Re: Review Request 44544: Moved contender and detector definitions into separate directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44544/#review123199 --- Looking through the review chain, I don't see where you've

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44320/#review123211 --- Ship it! Ship It! - Vinod Kone On March 11, 2016, 1:47

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/#review122832 --- I think you should send an email to the user and dev mailing

Re: Review Request 44319: Removed initialize method from the authorizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44319/#review123210 --- Ship it! Ship It! - Vinod Kone On March 11, 2016, 1:45

Re: Review Request 44721: Avoided external linkage for sched constants.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44721/#review123204 --- Patch looks great! Reviews applied: [44190, 44717, 44191, 44718,

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/#review123200 --- src/slave/containerizer/mesos/isolators/network/cni.hpp (line

Re: Review Request 44621: Added tests for http endpoints with bad authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44621/ --- (Updated March 11, 2016, 7:49 p.m.) Review request for mesos, Adam B and

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44555/#review123192 --- src/slave/containerizer/mesos/isolators/network/cni.hpp (lines

Re: Review Request 44711: Updated authentication.md after most endpoints enable authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44711/#review123194 --- Patch looks great! Reviews applied: [44286, 44186, 44621, 44711]

Re: Review Request 44621: Added tests for http endpoints with bad authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44621/#review123185 --- Fix it, then Ship it! src/tests/master_maintenance_tests.cpp

Re: Review Request 44186: Added authentication to master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44186/ --- (Updated March 11, 2016, 7:12 p.m.) Review request for mesos, Adam B,

Re: Review Request 44620: Documented how to make executors work with SSL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44620/ --- (Updated March 11, 2016, 8:11 p.m.) Review request for mesos, Adam B and

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

> On March 11, 2016, 6:19 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/spec.proto, line 23 > > > > > > OK, this is my bad. I didn't realize that network configuration JSON > > will inline

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44549/#review123190 --- src/slave/containerizer/mesos/isolators/network/spec.proto

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/ --- (Updated March 11, 2016, 6:56 p.m.) Review request for mesos, Adam B,

Re: Review Request 44186: Added authentication to master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44186/#review123182 --- Fix it, then Ship it! src/master/http.cpp (line 1279)

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/ --- (Updated March 11, 2016, 6:54 p.m.) Review request for mesos, Adam B,

Re: Review Request 44622: Introduced a protobuf message "NetworkResult".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44622/#review123179 --- Can we introduce the protobuf before the `prepare` method patch?

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44706/#review123181 --- src/slave/containerizer/mesos/isolators/network/cni.hpp (line

Re: Review Request 44078: Windows: Added Socket compatibility `#define`s to windows.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44078/ --- (Updated March 11, 2016, 6:39 p.m.) Review request for mesos, Alex Naparu,

Review Request 44722: Libprocess: Add `SOL_TCP` flag for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44722/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Re: Review Request 44620: Documented how to make executors work with SSL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44620/#review123184 --- Fix it, then Ship it! Verified the paragraph shows up

Review Request 44721: Avoided external linkage for sched constants.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44721/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Review Request 44718: Replaced `const string` master constants with `constexpr char[]`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44718/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Review Request 44719: Avoided external linkage for slave constants.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44719/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Review Request 44720: Replaced `const string` slave constants with `constexpr char[]`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44720/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 44191: Avoided external linkage for master constants.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44191/ --- (Updated March 11, 2016, 6:31 p.m.) Review request for mesos and Ben Mahler.

Review Request 44717: Marked a few Duration constants `constexpr`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44717/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 44191: Avoided external linkage for master constants.

> On March 11, 2016, 12:38 a.m., Ben Mahler wrote: > > src/master/constants.hpp, line 108 > > > > > > Could you also go ahead and do the change to `constexpr char[]` if > > possible for strings here? Done, as a

Re: Review Request 44190: Made `Bytes` usable in `constexpr` expressions [stout].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44190/ --- (Updated March 11, 2016, 6:30 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 43630: Especially updated scheduler tests to use the updated MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43630/ --- (Updated March 11, 2016, 10:24 a.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

> On March 3, 2016, 10:15 p.m., Joseph Wu wrote: > > src/master/contender.hpp, lines 17-18 > > > > > > This whole file seems like a pretty substantial change. I'd recommend > > pulling it out into a separate review

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44549/#review123170 --- src/CMakeLists.txt (line 52)

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/#review123176 --- src/slave/containerizer/mesos/isolators/network/cni.hpp (line

  1   2   3   >