Re: Review Request 44186: Added authentication to master endpoints.

2016-03-12 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44186/#review123301 --- Ship it! Ship It! - Adam B On March 11, 2016, 11:12 a.m.,

Review Request 44760: Windows: Fixed non-blocking connect.

2016-03-12 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44760/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Re: Review Request 44089: Windows: Used os::read/write from Stout for proper OS isolation.

2016-03-12 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44089/ --- (Updated March 13, 2016, 7:28 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44090: Windows: Changed the calling parameters for Windows API.

2016-03-12 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44090/ --- (Updated March 13, 2016, 7:27 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

2016-03-12 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44570/#review123300 --- Sorry for the misunderstanding. As far as (sandbox)

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

2016-03-12 Thread Adam B
> On March 9, 2016, 10:31 p.m., Adam B wrote: > > src/master/validation.cpp, line 381 > > > > > > It may be sufficient to only check `if (task.has_owner() && > > task.has_executor())` since a custom executor should

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/#review123296 --- Patch looks great! Reviews applied: [44758] Passed command:

Re: Review Request 44672: Added normalize method to registry puller.

2016-03-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44672/#review123295 --- Ship it! Ship It! - haosdent huang On March 10, 2016, 11:49

Re: Review Request 44439: Added device support in cgroups abstraction.

2016-03-12 Thread Kevin Klues
> On March 9, 2016, 1:58 a.m., Ben Mahler wrote: > > src/linux/cgroups.hpp, lines 635-654 > > > > > > The naming convention in this file is to mirror the cgroups controls, > > so these would be: > > > >

Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-12 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/ --- Review request for mesos and Michael Park. Bugs: MESOS-4906

Re: Review Request 44719: Avoided external linkage for slave constants.

2016-03-12 Thread Neil Conway
> On March 12, 2016, 2:28 a.m., Ben Mahler wrote: > > src/slave/constants.hpp, lines 116-118 > > > > > > Can this be in-line or is there a circular dependency issue that > > warrants the .cpp file? This can be in

Re: Review Request 44456: Added Appc provisioner integration test.

2016-03-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44456/#review123282 --- Patch looks great! Reviews applied: [44755, 44456] Passed

Re: Review Request 44748: Stout: Added implementation of `read` that works on Windows.

2016-03-12 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44748/ --- (Updated March 12, 2016, 6:14 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44747: Stout: Added implementation of `write` that works on Windows.

2016-03-12 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44747/ --- (Updated March 12, 2016, 6:14 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44456: Added Appc provisioner integration test.

2016-03-12 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44456/ --- (Updated March 12, 2016, 5:14 p.m.) Review request for mesos and Jie Yu.

Review Request 44755: Added getAppcImage for Appc provisioning tests.

2016-03-12 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44755/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

2016-03-12 Thread Qian Zhang
> On March 12, 2016, 3:28 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 48 > > > > > > Let's remove this 'empty' check here since you hae the os::exists check > > below. They