Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/#review123836 --- Patch looks great! Reviews applied: [44758] Passed command:

Re: Review Request 42036: Windows: Added `slave/flags.cpp` to Windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42036/#review123834 --- Ship it! Ship It! - Michael Park On March 11, 2016, 9:51

Re: Review Request 44883: Fix the mis-leading URI fetcher error message (MESOS-4954).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44883/#review123829 --- Ship it! Ship It! - haosdent huang On March 16, 2016, 3:31

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review123828 --- Patch looks great! Reviews applied: [43613, 43614, 43629, 43630,

Re: Review Request 41334: Added helper functions to filter allocation slack resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41334/#review123824 --- include/mesos/resources.hpp (line 170)

Re: Review Request 41333: Added helper functions to filter usage slack resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41333/#review123823 --- include/mesos/resources.hpp (line 174)

Re: Review Request 42547: Added helper function to get non usage slack resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42547/#review123822 --- include/mesos/resources.hpp (line 263)

Re: Review Request 44836: Update TaskId in long_lived_framework to use fixed length taskid.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44836/ --- (Updated March 16, 2016, 2:27 a.m.) Review request for mesos and haosdent

Re: Review Request 44836: Update TaskId in long_lived_framework to use fixed length taskid.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44836/ --- (Updated March 16, 2016, 2:21 a.m.) Review request for mesos and haosdent

Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40375/ --- (Updated March 16, 2016, 10:12 a.m.) Review request for mesos, Guangya Liu,

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44549/ --- (Updated March 16, 2016, 10:09 a.m.) Review request for mesos, Avinash

Re: Review Request 44881: Generize perf event parsing to match PerfStatistics filed name for "perf stat"

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44881/ --- (Updated 三月 16, 2016, 2:07 a.m.) Review request for mesos. Changes ---

Review Request 44881: Provide generic perf event parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44881/ --- Review request for mesos. Bugs: MESOS-4955

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

> On March 15, 2016, 11:19 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/spec.proto, line 40 > > > > > > Why are the position identifiers not sequential ? Sorry, my bad, will

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

> On March 15, 2016, 11:28 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/spec.proto, lines 45-46 > > > > > > The isolator doesn't actually need the IPAM or the DNS

Re: Review Request 44832: Validate string when convert `Flags` to `hashmap<string, string>`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44832/ --- (Updated March 16, 2016, 1:50 a.m.) Review request for mesos, Adam B, Ben

Re: Review Request 40532: Added notion of evict resources to RunTaskMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40532/ --- (Updated 三月 16, 2016, 1:46 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

> On March 15, 2016, 9:24 p.m., Michael Park wrote: > > support/clang-format, lines 101-107 > > > > > > We can help out a little more here: > > > > The following code orders the headers: > > (1) C

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/ --- (Updated March 16, 2016, 1:37 a.m.) Review request for mesos and Michael Park.

Re: Review Request 40532: Added notion of evict resources to RunTaskMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40532/ --- (Updated 三月 16, 2016, 1:24 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44378/#review123812 --- Can you explain what testing you have done in the "Testing done"

Re: Review Request 44874: Added support for FTS_SLNONE in rmdir.

> On March 16, 2016, 12:29 a.m., Neil Conway wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp, line 222 > > > > > > Why is this a `string&` and `newDirectory` is a `string`? I'd think > > both

Re: Review Request 44743: Improved grammar in `--help` output for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44743/#review123809 --- Ship it! Ship It! - Joris Van Remoortere On March 12, 2016,

Re: Review Request 44229: Added upgrade testing script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44229/#review123800 --- support/test-upgrade.py (line 24)

Re: Review Request 44874: Added support for FTS_SLNONE in rmdir.

> On March 16, 2016, 12:25 a.m., Neil Conway wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp, line 71 > > > > > > "don't". Also, we should use backticks for `FTS_COMFOLLOW` for > >

Re: Review Request 44742: Improved documentation for multiple disks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44742/#review123808 --- Ship it! Ship It! - Joris Van Remoortere On March 12, 2016,

Re: Review Request 44874: Added support for FTS_SLNONE in rmdir.

> On March 16, 2016, 12:25 a.m., Neil Conway wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp, line 71 > > > > > > "don't". Also, we should use backticks for `FTS_COMFOLLOW` for > >

Re: Review Request 44874: Added support for FTS_SLNONE in rmdir.

> On March 16, 2016, 12:29 a.m., Neil Conway wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp, line 222 > > > > > > Why is this a `string&` and `newDirectory` is a `string`? I'd think > > both

Re: Review Request 44867: Fixed linux fs isolator multi containers test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44867/#review123807 --- Patch looks great! Reviews applied: [44867] Passed command:

Re: Review Request 44313: Described "/maintanence/schedule" GET/POST in the two paragraph.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44313/#review123804 --- Ship it! Ship It! - Joris Van Remoortere On March 3, 2016,

Re: Review Request 44874: Added support for FTS_SLNONE in rmdir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44874/#review123802 ---

Re: Review Request 44867: Fixed linux fs isolator multi containers test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44867/#review123801 --- Ship it! Ship It! - Jie Yu On March 15, 2016, 9:21 p.m.,

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- (Updated March 15, 2016, 5:21 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 44229: Added upgrade testing script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44229/ --- (Updated March 16, 2016, 12:18 a.m.) Review request for mesos, Niklas Nielsen

Re: Review Request 44874: Added support for FTS_SLNONE in rmdir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44874/#review123798 --- Ship it! Ship It! - Jie Yu On March 15, 2016, 11:47 p.m.,

Re: Review Request 44722: Libprocess: Add `SOL_TCP` flag for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44722/#review123797 --- Ship it! Ship It! - Joris Van Remoortere On March 11, 2016,

Re: Review Request 44078: Windows: Added Socket compatibility `#define`s to windows.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44078/#review123796 --- Ship it! Ship It! - Joris Van Remoortere On March 11, 2016,

Re: Review Request 44873: Added test for rmdir with device file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44873/#review123794 --- Ship it! Ship It! - Jie Yu On March 15, 2016, 11:46 p.m.,

Re: Review Request 44832: Validate string when convert `Flags` to `hashmap<string, string>`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44832/#review123792 --- src/common/parse.hpp (lines 107 - 113)

Re: Review Request 44733: Added fault tolerance tests for the V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44733/#review123793 --- Ship it! Ship It! - Vinod Kone On March 14, 2016, 10:14

Review Request 44874: Added support for FTS_SLNONE in rmdir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44874/ --- Review request for mesos, Jie Yu and Neil Conway. Repository: mesos

Review Request 44873: Added test for rmdir with device file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44873/ --- Review request for mesos, Jie Yu and Neil Conway. Repository: mesos

Re: Review Request 44662: Added kill policies and shutdown grace period to the CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44662/#review123791 --- Looks good, just some suggestions for the descriptions.

Re: Review Request 44661: Deprecated the `docker_stop_timeout` flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44661/#review123787 --- Looking pretty good. Would be great to have a CHANGELOG update

Re: Review Request 44753: Fixed runtime isolator tests out of disk issue.

> On 三月 15, 2016, 1:28 a.m., Guangya Liu wrote: > > src/tests/containerizer/runtime_isolator_tests.cpp, lines 96-98 > > > > > > The comments should also be updated? Also should mention that do not > > want use up

Re: Review Request 44837: Added force_pull_image to Image protobuf.

> On 三月 15, 2016, 4:42 p.m., Jie Yu wrote: > > include/mesos/mesos.proto, line 1501 > > > > > > s/force_pull_image/no_cache/ > > > > IMO, force pull is a mean, not a description. Please adjust the > >

Re: Review Request 44669: Added createFromModule methods to MasterContender and MasterDetector.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44669/ --- (Updated March 15, 2016, 11:02 p.m.) Review request for mesos and Benjamin

Re: Review Request 44546: Moved functions in promises to a common header file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44546/ --- (Updated March 15, 2016, 11:02 p.m.) Review request for mesos and Benjamin

Re: Review Request 44289: Added support for contender and detector modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/ --- (Updated March 15, 2016, 11:02 p.m.) Review request for mesos and Benjamin

Re: Review Request 44547: Added functions in promises to the collect header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44547/ --- (Updated March 15, 2016, 11:02 p.m.) Review request for mesos and Benjamin

Re: Review Request 44545: Separated standalone and zookeeper classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44545/ --- (Updated March 15, 2016, 11:01 p.m.) Review request for mesos and Benjamin

Re: Review Request 44544: Moved contender and detector definitions into separate directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44544/ --- (Updated March 15, 2016, 11:01 p.m.) Review request for mesos and Benjamin

Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44543/ --- (Updated March 15, 2016, 11:01 p.m.) Review request for mesos and Benjamin

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated March 15, 2016, 11:01 p.m.) Review request for mesos and Benjamin

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/ --- (Updated March 15, 2016, 11:01 p.m.) Review request for mesos and Benjamin

Re: Review Request 44834: Documented task, executor, and volume IDs reuse is discouraged.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44834/#review123781 --- Patch looks great! Reviews applied: [44834] Passed command:

Re: Review Request 44708: Fixed signed / unsigned comparison in docker.cpp.

> On March 15, 2016, 10:37 p.m., Ben Mahler wrote: > > src/slave/constants.hpp, line 102 > > > > > > We tend to use size_t for things that are a count or a size. Otherwise, > > we'll tend to use `unsigned int`

Re: Review Request 44230: Added FS_DEFAULT case in rmdir.

Yes thats correct. I am planning to submit a patch that will add the test. Will also address the symlink case. -jojy > On Mar 15, 2016, at 3:33 PM, Cong Wang wrote: > > This is an automatically generated e-mail. To reply, > visit:https://reviews.apache.org/r/44230/

Re: Review Request 44708: Fixed signed / unsigned comparison in docker.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44708/#review123774 --- Fix it, then Ship it! src/slave/constants.hpp (line 102)

Re: Review Request 44659: Updated the comment about docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44659/#review123773 --- Ship it! src/docker/executor.cpp (lines 60 - 64)

Re: Review Request 44230: Added FS_DEFAULT case in rmdir.

> On March 15, 2016, 8:02 p.m., Neil Conway wrote: > > Is it feasible/portable to have a test case for this change? > > Cong Wang wrote: > Yes, like in our case, you can create some socket or device file and try > to remove the directory contains it, it would fail without this patch. > >

Re: Review Request 44230: Added FS_DEFAULT case in rmdir.

Would be happy to add test. Patch forthcoming. Will also address FTS_SLNONE. -Jojy > On Mar 15, 2016, at 2:26 PM, David Robinson > wrote: > > > >> On March 15, 2016, 8:02 p.m., Neil Conway wrote: >>> Is it feasible/portable to have a test case for this change?

Re: Review Request 44658: Removed unused signal escalation constant.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44658/#review123771 --- Ship it! Ship It! - Ben Mahler On March 15, 2016, 2:28

Re: Review Request 44657: Used `KillPolicy` and shutdown grace period in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44657/#review123765 --- src/launcher/executor.cpp (lines 121 - 125)

Re: Review Request 44837: Added force_pull_image to Image protobuf.

> On March 15, 2016, 9:42 a.m., Jie Yu wrote: > > include/mesos/mesos.proto, line 1501 > > > > > > s/force_pull_image/no_cache/ > > > > IMO, force pull is a mean, not a description. Please adjust the > >

Re: Review Request 44753: Fixed runtime isolator tests out of disk issue.

> On March 15, 2016, 1:28 a.m., Guangya Liu wrote: > > src/tests/containerizer/runtime_isolator_tests.cpp, lines 96-98 > > > > > > The comments should also be updated? Also should mention that do not > > want use up

Re: Review Request 44554: Added agent HTTP authentication to the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44554/ --- (Updated March 15, 2016, 9:32 p.m.) Review request for mesos, Adam B,

Re: Review Request 44515: Added agent flags for HTTP authentication.

> On March 15, 2016, 10:33 a.m., Joerg Schad wrote: > > src/slave/flags.cpp, line 682 > > > > > > As we are actively deprecated the old text based format with Mesos-228, > > does it make sense to only document the

Re: Review Request 44846: Deprecated the plain text credential format.

> On March 15, 2016, 6:53 p.m., Greg Mann wrote: > > FYI, this review: https://reviews.apache.org/r/44515/ adds command-line > > credentials to the agent with the `--http_credentials` flag. Depending on > > which one of these lands first, the other one should be updated to remain > >

Re: Review Request 44515: Added agent flags for HTTP authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/ --- (Updated March 15, 2016, 9:30 p.m.) Review request for mesos, Adam B,

Re: Review Request 44230: Added FS_DEFAULT case in rmdir.

> On March 15, 2016, 8:02 p.m., Neil Conway wrote: > > Is it feasible/portable to have a test case for this change? > > Cong Wang wrote: > Yes, like in our case, you can create some socket or device file and try > to remove the directory contains it, it would fail without this patch.

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/#review123734 --- Fix it, then Ship it! support/clang-format (lines 24 - 35)

Review Request 44867: Fixed linux fs isolator multi containers test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44867/ --- Review request for mesos, Jie Yu and Timothy Chen. Bugs: MESOS-4912

Re: Review Request 44230: Added FS_DEFAULT case in rmdir.

> On March 15, 2016, 8:02 p.m., Neil Conway wrote: > > Is it feasible/portable to have a test case for this change? Yes, like in our case, you can create some socket or device file and try to remove the directory contains it, it would fail without this patch. - Cong

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43629/ --- (Updated March 15, 2016, 1:48 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 44707: Added validation for task's kill policy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44707/#review123743 --- Could you add a corresponding test? Having it in the header

Re: Review Request 44656: Introduced `KillPolicy` protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44656/#review123741 --- Looks great, just some suggestions for clarifying the

Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44380/#review123738 --- Ship it! Ship It! - Joris Van Remoortere On March 15, 2016,

Re: Review Request 44853: Added benchmark test for the allocator metrics endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44853/#review123736 --- Patch looks great! Reviews applied: [44853] Passed command:

Re: Review Request 44655: Made `shutdown_grace_period` configurable in `ExecutorInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44655/#review123731 --- Looking good! Just some minor logical tweaks and some updates to

Re: Review Request 44230: Added FS_DEFAULT case in rmdir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44230/#review123735 --- Also, seems pretty clear we should handle `FTS_SLNONE`, as the

Re: Review Request 44230: Added FS_DEFAULT case in rmdir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44230/#review123733 --- Is it feasible/portable to have a test case for this change? -

Re: Review Request 43614: Refactor MesosTest and remove cleanup logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43614/#review123728 --- Ship it! Ship It! - Michael Park On March 4, 2016, 11:43

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/#review123727 --- Ship it! I think there are a few parts that are a bit clunky,

Re: Review Request 44657: Used `KillPolicy` and shutdown grace period in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44657/#review123726 --- src/launcher/executor.cpp (line 931)

Re: Review Request 44846: Deprecated the plain text credential format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44846/#review123720 --- FYI, this review: https://reviews.apache.org/r/44515/ adds

Re: Review Request 44654: Fixed hard-coded executor shutdown grace period in executor library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44654/#review123713 --- Looks great! Main thing is documenting why we don't assume the

Re: Review Request 44755: Added getAppcImage for Appc provisioning tests.

> On March 15, 2016, 4:56 p.m., Jie Yu wrote: > > src/tests/containerizer/provisioner_appc_tests.cpp, lines 587-610 > > > > > > Can you move this function to the top of this file and make it 'static'? > > Anand

Re: Review Request 44755: Added getAppcImage for Appc provisioning tests.

> On March 15, 2016, 4:56 p.m., Jie Yu wrote: > > src/tests/containerizer/provisioner_appc_tests.cpp, lines 587-610 > > > > > > Can you move this function to the top of this file and make it 'static'? > > Anand

Re: Review Request 44755: Added getAppcImage for Appc provisioning tests.

> On March 15, 2016, 4:56 p.m., Jie Yu wrote: > > src/tests/containerizer/provisioner_appc_tests.cpp, lines 587-610 > > > > > > Can you move this function to the top of this file and make it 'static'? > > Anand

Re: Review Request 44755: Added getAppcImage for Appc provisioning tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44755/ --- (Updated March 15, 2016, 6:26 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 44515: Added agent flags for HTTP authentication.

> On March 15, 2016, 10:33 a.m., Joerg Schad wrote: > > src/slave/flags.cpp, line 682 > > > > > > As we are actively deprecated the old text based format with Mesos-228, > > does it make sense to only document the

Re: Review Request 37168: Add an example framework using dynamic reservation.

> On March 15, 2016, 5:40 p.m., Greg Mann wrote: > > src/examples/dynamic_reservation_framework.cpp, line 42 > > > > > > Instead of using boost here, perhaps we could use members of the STL > > like `std::stoi` and

Re: Review Request 37168: Add an example framework using dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review122307 --- Thanks Klaus, this is great! It will be awesome to have an

Re: Review Request 43883: Added allocator metrics for the number of offer filters per framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/#review123696 --- Patch looks great! Reviews applied: [44850, 44851, 44852, 43884,

Re: Review Request 44755: Added getAppcImage for Appc provisioning tests.

> On March 15, 2016, 4:56 p.m., Jie Yu wrote: > > src/tests/containerizer/provisioner_appc_tests.cpp, lines 587-610 > > > > > > Can you move this function to the top of this file and make it 'static'? Wondering why

Re: Review Request 44755: Added getAppcImage for Appc provisioning tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44755/#review123688 --- Fix it, then Ship it!

Re: Review Request 44753: Fixed runtime isolator tests out of disk issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44753/#review123687 --- Ship it! Ship It! - Jie Yu On March 15, 2016, 12:22 a.m.,

Re: Review Request 44848: Moved defaults in configuration.md to a new line for readability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44848/#review123667 --- These docs were generated from the flag help strings, as printed

Re: Review Request 44837: Added force_pull_image to Image protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44837/#review123681 --- include/mesos/mesos.proto (line 1501)

  1   2   3   >