Re: Review Request 44888: Fix the typo.

2016-03-16 Thread Adam B
> On March 16, 2016, 3:30 a.m., Adam B wrote: > > Ship It! Went back to look at the patch that originally added the Disk column, and found one more copy/paste error in src/webui/master/static/slave.html I'm fixing that one too with the same commit. - Adam ---

Re: Review Request 44888: Fix the typo.

2016-03-16 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44888/#review123850 --- Ship it! Ship It! - Adam B On March 16, 2016, 3:05 a.m., Yon

Re: Review Request 44832: Validate string when convert `Flags` to `hashmap`.

2016-03-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44832/#review123847 --- Patch looks great! Reviews applied: [44832] Passed command: expo

Re: Review Request 44888: Fix the typo.

2016-03-16 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44888/ --- (Updated March 16, 2016, 10:05 a.m.) Review request for mesos and Adam B. Bug

Review Request 44888: Fix the typo.

2016-03-16 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44888/ --- Review request for mesos and Adam B. Repository: mesos Description --- F

Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform.

2016-03-16 Thread Zhiwei Chen
> On March 16, 2016, 8:46 a.m., Vinod Kone wrote: > > Can you explain what testing you have done in the "Testing done" section? > > > > According to MESOS-4312, we agreed to do the following tests: > > > > -- Verify SSL, perf and docker related test cases work as expected on all > > platforms

Re: Review Request 44078: Windows: Added Socket compatibility `#define`s to windows.hpp.

2016-03-16 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44078/ --- (Updated March 16, 2016, 8:03 a.m.) Review request for mesos, Alex Naparu, Dani

Re: Review Request 44622: Introduced a protobuf message "NetworkResult".

2016-03-16 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44622/ --- (Updated March 16, 2016, 3:58 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

2016-03-16 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/ --- (Updated March 16, 2016, 3:49 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

2016-03-16 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44706/ --- (Updated March 16, 2016, 3:50 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 44622: Introduced a protobuf message "NetworkResult".

2016-03-16 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44622/ --- (Updated March 16, 2016, 3:48 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

2016-03-16 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44555/ --- (Updated March 16, 2016, 3:25 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 40532: Added notion of evict resources to RunTaskMessage.

2016-03-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40532/#review123842 --- Patch looks great! Reviews applied: [40375, 41334, 41333, 42547,