Re: Review Request 45854: Updated the default JSON representation of a Resource to include GPUs.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45854/
---

(Updated April 8, 2016, 5:54 a.m.)


Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.


Changes
---

Updated some of the tests that rely on parsing the default Resource JSON. In 
the first iteratio, some tests were failing without this:
```
[  FAILED  ] DynamicWeightsTest.PutInvalidRequest
[  FAILED  ] DynamicWeightsTest.ZeroWeight
[  FAILED  ] DynamicWeightsTest.NegativeWeight
[  FAILED  ] DynamicWeightsTest.NonNumericWeight
[  FAILED  ] DynamicWeightsTest.MissingRole
[  FAILED  ] DynamicWeightsTest.UnknownRole
[  FAILED  ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
[  FAILED  ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
[  FAILED  ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
[  FAILED  ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
[  FAILED  ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
[  FAILED  ] DynamicWeightsTest.RecoveredWeightsFromRegistry
[  FAILED  ] RoleTest.EndpointEmpty
[  FAILED  ] RoleTest.EndpointNoFrameworks
[  FAILED  ] RoleTest.EndpointImplicitRolesWeights
[  FAILED  ] RoleTest.EndpointImplicitRolesQuotas
[  FAILED  ] HTTPTest.ModelTask
[  FAILED  ] HTTPTest.ModelResources
[  FAILED  ] HTTP.ModelRoleResources
```

I must have missed these the first time around because I ran `make check` with 
a filter set.


Bugs: MESOS-5136
https://issues.apache.org/jira/browse/MESOS-5136


Repository: mesos


Description (updated)
---

This includes updating some tests that parse this JSON and look for
specific values for all of its fields.


Diffs (updated)
-

  src/common/http.cpp 3748c71686c696c47f93a81e3434bbb55448e334 
  src/tests/common/http_tests.cpp ac6322d7fb58adf7a615c517496d08dee3bf0081 
  src/tests/dynamic_weights_tests.cpp e36a45fa18d163430df1c9dc72d2372aee9b44e6 
  src/tests/role_tests.cpp 056359bbe6a02bb129bfa2ce371e82cd3aa4c984 

Diff: https://reviews.apache.org/r/45854/diff/


Testing
---

make check


Thanks,

Kevin Klues

Re: Review Request 37168: Add an example framework using dynamic reservation.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37168/#review127733
---



Patch looks great!

Reviews applied: [37168]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 8, 2016, 2:33 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37168/
> ---
> 
> (Updated April 8, 2016, 2:33 a.m.)
> 
> 
> Review request for mesos, Greg Mann, Joerg Schad, and Michael Park.
> 
> 
> Bugs: MESOS-3063
> https://issues.apache.org/jira/browse/MESOS-3063
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Provide example for dynamic reservation features.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 71c4308cccfa5c56b93f6c3928dd2a1cf3ba9741 
>   src/examples/dynamic_reservation_framework.cpp PRE-CREATION 
>   src/tests/dynamic_reservation_framework_test.sh PRE-CREATION 
>   src/tests/examples_tests.cpp 6ddac17bb2ac0330bcc09eaab975ae70e84a7695 
> 
> Diff: https://reviews.apache.org/r/37168/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 44832: Validate string when convert `Flags` to `hashmap<string, string>`.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44832/#review127727
---


Ship it!




Ship It!

- Ben Mahler


On April 2, 2016, 8:07 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44832/
> ---
> 
> (Updated April 2, 2016, 8:07 a.m.)
> 
> 
> Review request for mesos, Adam B, Ben Mahler, and Kevin Klues.
> 
> 
> Bugs: MESOS-2023
> https://issues.apache.org/jira/browse/MESOS-2023
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Validate string when convert `Flags` to `hashmap`.
> 
> 
> Diffs
> -
> 
>   src/common/parse.hpp 9036dae1b55e0c222ddedd15599ea56933c84cd7 
> 
> Diff: https://reviews.apache.org/r/44832/diff/
> 
> 
> Testing
> ---
> 
> 1. Without pass `--env=`.
> ```
> $ ./src/mesos-execute  --master=127.0.0.1:5050 --name=test --command='echo $a'
> ```
> 
> Output:
> ```
> Starting task test
> Forked command at 4542
> sh -c 'echo $a'
> I0315 11:45:39.153188  4402 slave.cpp:3002] Handling status update 
> TASK_RUNNING (UUID: 06b8f974-b6ec-4d10-b1d8-f84b5d4f728d) for task test of 
> framework cf1af3e0-dd66-41e8-8c56-7ad80d7dce98-0001 from execu
> tor(1)@127.0.0.1:54698
> I0315 11:45:39.153964  4401 status_update_manager.cpp:320] Received status 
> update TASK_RUNNING (UUID: 06b8f974-b6ec-4d10-b1d8-f84b5d4f728d) for task 
> test of framework cf1af3e0-dd66-41e8-8c56-7ad80d7dce98-
> 0001
> ```
> 
> 2. Pass `--env=`.
> ```
> $ ./src/mesos-execute  --master=127.0.0.1:5050 --name=test --command='echo 
> $a' --env="{\"a\": \"stdin\"}"
> ```
> 
> Output:
> ```
> Registered executor on localhost
> Starting task test
> Forked command at 4675
> sh -c 'echo $a'
> stdin
> I0315 11:46:34.797502  4408 slave.cpp:3002] Handling status update 
> TASK_RUNNING (UUID: 16040c40-f5e4-4bf0-8690-447f2901310b) for task test of 
> framework cf1af3e0-dd66-41e8-8c56-7ad80d7dce98-0003 from execu
> tor(1)@127.0.0.1:57831
> ```
> 
> 3. Pass incorrect json format in `--env=`.
> ```
> ./src/mesos-execute  --master=127.0.0.1:5050 --name=test --command='echo $a' 
> --env="{\"a\": {}}"
> Failed to load flag 'env': Failed to load value '{"a": {}}': The value of key 
> 'a' in '{"a":{}}' is not a valid string.
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 45534: Added per-role and quota share metrics to the DRFSorter.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45534/#review127721
---



High level thought is that we should start with just the shares within the role 
sorter, since these are the easiest to understand. After Vinod and I talked, we 
realized the "quota" shares were difficult to reason about, so let's not 
include those for now (one thing at a time).

I also would suggest the following naming scheme:

```
allocator/mesos/roles//shares/dominant
```

Since we may want additional shares to be exposed:

```
allocator/mesos/roles//shares/dominant: 0.5
allocator/mesos/roles//shares/cpus: 0.5
allocator/mesos/roles//shares/mem: 0.2
allocator/mesos/roles//shares/disk: 0.1
```


docs/monitoring.md (lines 967 - 973)


Let's not include this one for now, I chatted with vinod about this one to 
get some more thoughts and we agree this is pretty difficult to explain to the 
users and likely the most valuable thing to expose for now is the dominant 
shares for the normal sorter.



src/master/allocator/sorter/drf/metrics.hpp (line 59)


```
// Dominant share of each client.
hashmap dominantShares;
```



src/master/allocator/sorter/sorter.hpp (lines 46 - 52)


Why a factory rather than just a string prefix? How about:

```
  // Provides the allocator's execution context (via a UPID)
  // and a name prefix in order to support metrics within the
  // sorter implementation.
  explicit Sorter(
  const process::UPID& allocator,
  const std::string& metricsPrefix) {}
```



src/tests/hierarchical_allocator_tests.cpp (lines 2748 - 2752)


How about:

```
// Verifies that per-role dominant share metrics are correctly reported.
```



src/tests/hierarchical_allocator_tests.cpp (lines 2762 - 2764)


Would you mind wrapping to reduce jaggedness in general?

```
  // Register one agent and one framework. The framework will
  // immediately receive receive an offer and make it have the
  // maximum possible dominant share.
```



src/tests/hierarchical_allocator_tests.cpp (lines 2783 - 2787)


We need to settle after these allocator calls, otherwise we may not see the 
changes reflected in the metrics. Did you run this test in repetition?



src/tests/hierarchical_allocator_tests.cpp (lines 2791 - 2792)


How about moving this up to before the decline happens, to be consistent 
with your other comments that describe what's happening in the test, so:

```
  // Decline the offered resources and expect a zero share.
  Future allocation = allocations.get();
  AWAIT_READY(allocation);
  allocator->recoverResources(
  allocation->frameworkId,
  agent1.id(),
  allocation->resources.get(agent1.id()).get(),
  None());
```



src/tests/hierarchical_allocator_tests.cpp (line 2835)


Can you move this down to be adjacent with the expectation on the metrics? 
It's also how we did it in the metrics test above:

```
  expected.values = {
  {"allocator/mesos/dominant_share/roles/roleA", 0.5},
  };

  metrics = Metrics();
  EXPECT_TRUE(metrics.contains(expected));
```


- Ben Mahler


On April 4, 2016, 12:32 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45534/
> ---
> 
> (Updated April 4, 2016, 12:32 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4760
> https://issues.apache.org/jira/browse/MESOS-4760
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added per-role and quota share metrics to the DRFSorter.
> 
> 
> Diffs
> -
> 
>   docs/monitoring.md 76be32842e8b437fda40c8565a34ec4f8d8dfbcc 
>   src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
>   src/master/allocator/mesos/hierarchical.hpp 
> e979fdf60da1409d1c2d08f0e9f03cef067506dd 
>   src/master/allocator/sorter/drf/metrics.hpp PRE-CREATION 
>   src/master/allocator/sorter/drf/metrics.cpp PRE-CREATION 
>   src/master/allocator/sorter/drf/sorter.hpp 
> f316bb5b8bfe93311ecac57198392e104b234b04 
>   src/master/allocator/sorter/drf/sorter.cpp 
> c14f9a45b9e2ea8d79bd8d2f092d313afa4cbac3 
>   

Re: Review Request 44853: Added benchmark test for the allocator metrics endpoint.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44853/#review127698
---


Fix it, then Ship it!





src/tests/hierarchical_allocator_tests.cpp (line 2988)


2 spaces here



src/tests/hierarchical_allocator_tests.cpp (lines 3000 - 3017)


size_t above but unsigned here?

Also, why the vectors here?

```
  for (size_t i = 0; i < frameworkCount; i++) {
string role = stringify(i);
allocator->setQuota(role, createQuota(role, "cpus:1;mem:512;disk:256"));
  }

  for (size_t i = 0; i < frameworkCount; i++) {
FrameworkInfo framework = createFrameworkInfo(stringify(i)));
allocator->addFramework(framework.id(), framework, {});
  }

  for (size_t i = 0; i < slaveCount; i++) {
SlaveInfo slave = createSlaveInfo("cpus:16;mem:2048;disk:1024");
allocator->addSlave(slaveid(), slave, None(), slave.resources(), {});
  }
```



src/tests/hierarchical_allocator_tests.cpp (lines 3022 - 3032)


Why the scope here? Looks like it was added because some of the new 
benchmarks in this file are using a scope for the stopwatch? I don't think it's 
bad, but it's a little tricky to follow the reasoning for where to use a scope 
here. I suppose it calls out the timing code, but I'd opt to just avoid the 
extra scoping for now.



src/tests/hierarchical_allocator_tests.cpp (lines 3023 - 3027)


Perhaps this would be clearer?

```
  Stopwatch watch;

  // TODO(bmahler): Avoid timing the JSON parsing here.
  // Ideally we also avoid timing the HTTP layer.
  watch.start();
  JSON::Object metrics = Metrics();
  watch.stop();
```



src/tests/hierarchical_allocator_tests.cpp (lines 3029 - 3031)


How about:

```
  cout << "/metrics/snapshot took " << watch.elapsed()
   << " for " << slaveCount << " slaves"
   << " and " << frameworkCount << " frameworks" << endl;
```


- Ben Mahler


On March 30, 2016, 1:22 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44853/
> ---
> 
> (Updated March 30, 2016, 1:22 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added benchmark test for the allocator metrics endpoint.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 459e02576f6d05abbbcc83ae5cabac5c66e93f05 
> 
> Diff: https://reviews.apache.org/r/44853/diff/
> 
> 
> Testing
> ---
> 
> The benchmark uses the same parametrized setup as other 
> `HierarchicalAllocator_BENCHMARK_Tests` which already elsewhere take 
> considerable time. The reason for covering the same parameter space here was 
> the assumption that that parameter space does capture the relevant scenarios.
> 
> The benchmark shows that the time needed to obtain the metrics has a linear 
> relationship with the number of registered frameworks, roughly independent of 
> the number of slaves. With my setup, the time per framework was well below 1 
> ms after already a few frameworks.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 45533: Explicitly typed quota role sorter in Mesos allocator.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45533/#review127705
---


Fix it, then Ship it!





src/master/allocator/mesos/hierarchical.hpp (line 479)


whoops?


- Ben Mahler


On April 1, 2016, 8:07 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45533/
> ---
> 
> (Updated April 1, 2016, 8:07 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4760
> https://issues.apache.org/jira/browse/MESOS-4760
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Explicitly typed quota role sorter in Mesos allocator.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> e979fdf60da1409d1c2d08f0e9f03cef067506dd 
>   src/master/allocator/mesos/hierarchical.cpp 
> 5a5df5f8287a1f85b8b2a6aac7e6e13d0650a132 
> 
> Diff: https://reviews.apache.org/r/45533/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X, clang trunk, not optimized)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 45910: Move metrics code into the scheduler body.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45910/#review127722
---



Bad patch!

Reviews applied: [45910, 45800, 45799, 45440, 45067]

Failed command: ./support/apply-review.sh -n -r 45067

Error:
2016-04-08 02:53:42 URL:https://reviews.apache.org/r/45067/diff/raw/ 
[13287/13287] -> "45067.patch" [1]
Total errors found: 0
Checking 1 files
Error: No line in the commit message summary may exceed 72 characters.

Full log: https://builds.apache.org/job/mesos-reviewbot/12398/console

- Mesos ReviewBot


On April 8, 2016, 12:02 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45910/
> ---
> 
> (Updated April 8, 2016, 12:02 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Artem Harutyunyan, and Vinod Kone.
> 
> 
> Bugs: MESOS-4982
> https://issues.apache.org/jira/browse/MESOS-4982
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since the HTTP scheduler is a libprocess process, the sub-class 
> `Metrics` does not need to be a process anymore.  This moves the
> process-specific code into the appropriate place in the scheduler.
> 
> 
> Diffs
> -
> 
>   src/examples/long_lived_framework.cpp 
> ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 
> 
> Diff: https://reviews.apache.org/r/45910/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Deployed on a test cluster (see the first review in the chain.)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 37168: Add an example framework using dynamic reservation.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37168/
---

(Updated April 8, 2016, 10:33 a.m.)


Review request for mesos, Greg Mann, Joerg Schad, and Michael Park.


Changes
---

Address @mcypark's comments and rebase.


Bugs: MESOS-3063
https://issues.apache.org/jira/browse/MESOS-3063


Repository: mesos


Description
---

Provide example for dynamic reservation features.


Diffs (updated)
-

  src/Makefile.am 71c4308cccfa5c56b93f6c3928dd2a1cf3ba9741 
  src/examples/dynamic_reservation_framework.cpp PRE-CREATION 
  src/tests/dynamic_reservation_framework_test.sh PRE-CREATION 
  src/tests/examples_tests.cpp 6ddac17bb2ac0330bcc09eaab975ae70e84a7695 

Diff: https://reviews.apache.org/r/37168/diff/


Testing
---

make
make check


Thanks,

Klaus Ma

Re: Review Request 45852: Added standard metrics for GPU resources.

[haosdent huang]

> On April 8, 2016, 2:24 a.m., haosdent huang wrote:
> > Do you forgot to update
> > ```
> > diff --git a/src/common/http.cpp b/src/common/http.cpp
> > index 3748c71..d2f75b0 100644
> > --- a/src/common/http.cpp
> > +++ b/src/common/http.cpp
> > @@ -105,6 +105,7 @@ JSON::Object model(const Resources& resources)
> >  {
> >JSON::Object object;
> >object.values["cpus"] = 0;
> > +  object.values["gpu"] = 0;
> >object.values["mem"] = 0;
> >object.values["disk"] = 0;
> > ```
> > 
> > I saw some field is empty in webui after apply your patch.
> > 
> > As you know, if `xxx.resources.gpus` is `undefined`, `+=` would get `NaN`.

OK, my bad to forgot apply https://reviews.apache.org/r/45854/


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45852/#review127718
---


On April 7, 2016, 1:54 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45852/
> ---
> 
> (Updated April 7, 2016, 1:54 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.
> 
> 
> Bugs: MESOS-4624
> https://issues.apache.org/jira/browse/MESOS-4624
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit also includes updates to the webui to show these metrics.
> 
> 
> Diffs
> -
> 
>   src/master/metrics.cpp 30c091198a8fdd6d6a957a351dc37d3dae7788e4 
>   src/slave/metrics.cpp 42c66d7d7176232ccc71f1e040bcae99900f49f8 
>   src/tests/master_tests.cpp 8f93fbaf2bfd66bbc144a85c0097f45c55ff3491 
>   src/tests/slave_tests.cpp 03bb6da687a1bf11d81619839e6730835e5c4d82 
>   src/webui/master/static/framework.html 
> ee42d1ab841a4c42d95512ee60d577b1bbb66bc8 
>   src/webui/master/static/frameworks.html 
> 15ff1e9cb6c70df8df47a1b939681abde591e010 
>   src/webui/master/static/home.html a691084f4992cda65734f5fee3b2f38349737b83 
>   src/webui/master/static/js/controllers.js 
> f92affab41f8418cd7e5ea25561a182a1761fd79 
>   src/webui/master/static/offers.html 
> 01213e9582f50072a9c729782271269f72972d28 
>   src/webui/master/static/slave.html 4419f7c166e8768040dab7dbc6fb64e1382ad272 
>   src/webui/master/static/slave_executor.html 
> 5acb676390fe4ed17369143c5a13202c0981 
>   src/webui/master/static/slave_framework.html 
> 4b2b1562f38f002b4659b4a883249f0469307323 
>   src/webui/master/static/slaves.html 
> 0cb125a7d95ccc7770916cbffa052f43e8ea3d2c 
> 
> Diff: https://reviews.apache.org/r/45852/diff/
> 
> 
> Testing
> ---
> 
> Ran:
> ```
> GTEST_FILTER="SlaveTest.MetricsInMetricsEndpoint:SlaveTest.MetricsInMetricsEndpoint"
>  make -j check
> SUCCESS
> ```
> 
> Manually opened the web UI, clicked around to make sure all the GPU metrics 
> now showed up.
> Also looked at "Inspect Element" to verify that there were no javascript 
> errors when loading.
> 
> Specifically:
> ```
> * The Resources section in the left sidebar of the main page
> * The Resources section of the table in the Frameworks tab
> * The Resources section of the table in the Slaves tab
> * The Resources section of the table in the Offers tab
> ```
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 45905: Added metrics to the balloon framework.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45905/#review127719
---



Bad patch!

Reviews applied: [45905, 45604]

Failed command: ./support/apply-review.sh -n -r 45604

Error:
2016-04-08 02:24:27 URL:https://reviews.apache.org/r/45604/diff/raw/ 
[18869/18869] -> "45604.patch" [1]
Total errors found: 0
Checking 2 files
Error: No line in the commit message summary may exceed 72 characters.

Full log: https://builds.apache.org/job/mesos-reviewbot/12397/console

- Mesos ReviewBot


On April 7, 2016, 10:59 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45905/
> ---
> 
> (Updated April 7, 2016, 10:59 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and 
> Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds metrics to gauge the health of the framework.  This includes:
> 
> * uptime_secs = How long the framework has been running.
> * registered = If the framework is registered.
> * tasks_finished = Number of tasks finished (successfully).
> * tasks_oomed = Number of tasks that were OOM killed.
> * abnormal_terminations = Number of terminal status updates which 
>   were not `TASK_FINISHED` or `TASK_FAILED` due to OOM.
> 
> Also adds an endpoint `/framework/counters` which returns the list of 
> metrics which are "counters".
> 
> 
> Diffs
> -
> 
>   src/examples/balloon_framework.cpp 15c45612b777edaf97aea9b953439d4ad56920f3 
> 
> Diff: https://reviews.apache.org/r/45905/diff/
> 
> 
> Testing
> ---
> 
> ```
> make check
> 
> sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_BalloonFramework"
> 
> # Also launched two instances on a cluster.
> # This one OOM's:
> ./balloon-framework --master=zk://localhost:2181/mesos --checkpoint 
> --balloon_limit=256MB --task_memory=128MB 
> --executor_uri="https://s3.amazonaws.com/url/to/balloon-executor; 
> --executor_command="LD_LIBRARY_PATH=/path/to/libmesos && ./balloon-executor"
> 
> # This one does not OOM:
> ./balloon-framework --master=zk://localhost:2181/mesos --checkpoint 
> --balloon_limit=256MB --task_memory=256MB 
> --executor_uri="https://s3.amazonaws.com/url/to/balloon-executor; 
> --executor_command="LD_LIBRARY_PATH=/path/to/libmesos && ./balloon-executor"
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 45852: Added standard metrics for GPU resources.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45852/#review127718
---



Do you forgot to update
```
diff --git a/src/common/http.cpp b/src/common/http.cpp
index 3748c71..d2f75b0 100644
--- a/src/common/http.cpp
+++ b/src/common/http.cpp
@@ -105,6 +105,7 @@ JSON::Object model(const Resources& resources)
 {
   JSON::Object object;
   object.values["cpus"] = 0;
+  object.values["gpu"] = 0;
   object.values["mem"] = 0;
   object.values["disk"] = 0;
```

I saw some field is empty in webui after apply your patch.

As you know, if `xxx.resources.gpus` is `undefined`, `+=` would get `NaN`.

- haosdent huang


On April 7, 2016, 1:54 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45852/
> ---
> 
> (Updated April 7, 2016, 1:54 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.
> 
> 
> Bugs: MESOS-4624
> https://issues.apache.org/jira/browse/MESOS-4624
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit also includes updates to the webui to show these metrics.
> 
> 
> Diffs
> -
> 
>   src/master/metrics.cpp 30c091198a8fdd6d6a957a351dc37d3dae7788e4 
>   src/slave/metrics.cpp 42c66d7d7176232ccc71f1e040bcae99900f49f8 
>   src/tests/master_tests.cpp 8f93fbaf2bfd66bbc144a85c0097f45c55ff3491 
>   src/tests/slave_tests.cpp 03bb6da687a1bf11d81619839e6730835e5c4d82 
>   src/webui/master/static/framework.html 
> ee42d1ab841a4c42d95512ee60d577b1bbb66bc8 
>   src/webui/master/static/frameworks.html 
> 15ff1e9cb6c70df8df47a1b939681abde591e010 
>   src/webui/master/static/home.html a691084f4992cda65734f5fee3b2f38349737b83 
>   src/webui/master/static/js/controllers.js 
> f92affab41f8418cd7e5ea25561a182a1761fd79 
>   src/webui/master/static/offers.html 
> 01213e9582f50072a9c729782271269f72972d28 
>   src/webui/master/static/slave.html 4419f7c166e8768040dab7dbc6fb64e1382ad272 
>   src/webui/master/static/slave_executor.html 
> 5acb676390fe4ed17369143c5a13202c0981 
>   src/webui/master/static/slave_framework.html 
> 4b2b1562f38f002b4659b4a883249f0469307323 
>   src/webui/master/static/slaves.html 
> 0cb125a7d95ccc7770916cbffa052f43e8ea3d2c 
> 
> Diff: https://reviews.apache.org/r/45852/diff/
> 
> 
> Testing
> ---
> 
> Ran:
> ```
> GTEST_FILTER="SlaveTest.MetricsInMetricsEndpoint:SlaveTest.MetricsInMetricsEndpoint"
>  make -j check
> SUCCESS
> ```
> 
> Manually opened the web UI, clicked around to make sure all the GPU metrics 
> now showed up.
> Also looked at "Inspect Element" to verify that there were no javascript 
> errors when loading.
> 
> Specifically:
> ```
> * The Resources section in the left sidebar of the main page
> * The Resources section of the table in the Frameworks tab
> * The Resources section of the table in the Slaves tab
> * The Resources section of the table in the Offers tab
> ```
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 45562: Edited `--work_dir` help strings and docs.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/#review127714
---



How about `fetcher_cache_dir`, `appc_store_dir` and `docker_store_dir`?

- haosdent huang


On March 31, 2016, 9:22 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45562/
> ---
> 
> (Updated March 31, 2016, 9:22 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Neil Conway.
> 
> 
> Bugs: MESOS-5064
> https://issues.apache.org/jira/browse/MESOS-5064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Some users have encountered difficulty when running the Mesos agent with the 
> `work_dir` located in a subdirectory of `/tmp`. This patch adds language to 
> the `work_dir` help strings and configuration docs advising users to avoid 
> the use of this location in production.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md da42eaf7069a016fa7eaf929fc285e1fa1f144e9 
>   src/master/flags.cpp 06852c9de68cce5d40f294f6402f7677ee6183d3 
>   src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 
> 
> Diff: https://reviews.apache.org/r/45562/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the Mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 37168: Add an example framework using dynamic reservation.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37168/#review127711
---


Fix it, then Ship it!





src/examples/dynamic_reservation_framework.cpp (lines 389 - 392)


We need to remove this in order for this to work on OS X.

Refer to https://reviews.apache.org/r/39423.


- Michael Park


On April 7, 2016, 3:23 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37168/
> ---
> 
> (Updated April 7, 2016, 3:23 a.m.)
> 
> 
> Review request for mesos, Greg Mann, Joerg Schad, and Michael Park.
> 
> 
> Bugs: MESOS-3063
> https://issues.apache.org/jira/browse/MESOS-3063
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Provide example for dynamic reservation features.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 71c4308cccfa5c56b93f6c3928dd2a1cf3ba9741 
>   src/examples/dynamic_reservation_framework.cpp PRE-CREATION 
>   src/tests/dynamic_reservation_framework_test.sh PRE-CREATION 
>   src/tests/examples_tests.cpp 6ddac17bb2ac0330bcc09eaab975ae70e84a7695 
> 
> Diff: https://reviews.apache.org/r/37168/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45806/#review127688
---



Thanks for the update!

Doing a quick `git-grep` after applying the patch, I still see a few references 
to `mesos-slave` throughout the code base.  Alot of these are in the 
documentation (which I think should be covered by MESOS-3783).  However, the 
following other files still have references:
```
src/slave/containerizer/mesos/launch.cpp
src/tests/balloon_framework_test.sh
support/generate-endpoint-help.py
support/test-upgrade.py
```
These files should likely be updated to refer to `mesos-agent` as part of this 
patch.

There is also this file:
```
3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake
```
which it's not clear we should change as part of this patch, but I talked to 
@vinod and he thinks we should. The Cmake stuff isn't really supported yet, so 
he thinks it's OK to just sort of blindly change it and let those working on 
the Cmake port sort things out. I'd suggest:
```
# Define target for AGENT.
##
set(
  AGENT_TARGET mesos-agent
  CACHE STRING "Target we use to refer to the agent executable")
```

Also, we should probably make it clear in both the commit message and the 
"Testing" section of the review that a full `bootstrap` is required once this 
patch has landed.  Otherwise, `configure` will break because of the missing 
`mesos-slave-*.sh` scripts.
```
cd mesos
./bootstrap
mkdir build
cd build
../configure --prefix=${HOME}/install/mesos
make
```

I ran through this as well as doing a `make install` and inspecting the 
contents of `${HOME}/install/mesos` I see:
```
[klueska@core-dev build]$ find ${HOME}/install/mesos/ -name "*slave*"
${HOME}/install/mesos/include/mesos/slave
${HOME}/install/mesos/sbin/mesos-start-slaves.sh
${HOME}/install/mesos/sbin/mesos-stop-slaves.sh
${HOME}/install/mesos/sbin/mesos-slave
${HOME}/install/mesos/share/mesos/webui/master/static/slave.html
${HOME}/install/mesos/share/mesos/webui/master/static/slave_executor.html
${HOME}/install/mesos/share/mesos/webui/master/static/slave_framework.html
${HOME}/install/mesos/share/mesos/webui/master/static/slaves.html
${HOME}/install/mesos/etc/mesos/mesos-slave-env.sh.template

[klueska@core-dev build]$ find ${HOME}/install/mesos/ -name "*agent*"
${HOME}/install/mesos/sbin/mesos-start-agents.sh
${HOME}/install/mesos/sbin/mesos-stop-agents.sh
${HOME}/install/mesos/sbin/mesos-agent
${HOME}/install/mesos/etc/mesos/mesos-agent-env.sh.template
```

which seems consistent with what we want for this patch.

However there are still references to the word 'slave' in places such as 
`include/mesos/slave` and the webui stuff.  The webui stuff should be covered 
by MESOS-3779, but there is no ticket covering a rename of the 
`include/mesos/slave` folder.  I talked to @vinod about this, and he suggested 
making a separate ticket to do this rename. Glancing through `src/Makefile.am`, 
it may be enough to just change:
```
slavedir = $(pkgincludedir)/slave

slave_HEADERS =   \
  $(top_srcdir)/include/mesos/slave/container_logger.hpp\
  $(top_srcdir)/include/mesos/slave/isolator.hpp  \
  $(top_srcdir)/include/mesos/slave/isolator.proto  \
  $(top_srcdir)/include/mesos/slave/oversubscription.hpp\
  $(top_srcdir)/include/mesos/slave/oversubscription.proto\
  $(top_srcdir)/include/mesos/slave/qos_controller.hpp  \
  $(top_srcdir)/include/mesos/slave/resource_estimator.hpp

nodist_slave_HEADERS =  \
  ../include/mesos/slave/isolator.pb.h  \
  ../include/mesos/slave/oversubscription.pb.h
```
to
```
agentdir = $(pkgincludedir)/agent

agent_HEADERS =   \
  $(top_srcdir)/include/mesos/slave/container_logger.hpp\
  $(top_srcdir)/include/mesos/slave/isolator.hpp  \
  $(top_srcdir)/include/mesos/slave/isolator.proto  \
  $(top_srcdir)/include/mesos/slave/oversubscription.hpp\
  $(top_srcdir)/include/mesos/slave/oversubscription.proto\
  $(top_srcdir)/include/mesos/slave/qos_controller.hpp  \
  $(top_srcdir)/include/mesos/slave/resource_estimator.hpp

nodist_agent_HEADERS =  \
  ../include/mesos/slave/isolator.pb.h  \
  ../include/mesos/slave/oversubscription.pb.h
```

and then add another command to your install/uninstall-hooks to create a 
symlink from `agent->slave`. Possibly renaming `copy-agent-env-template` to 
something more meaningful to cover both the existing stuff, plus setting up 
this symlink.

Finally, the CHANGELOG should be updated as part of this patch to point out all 
of the changes that have been made.

Thanks!


src/Makefile.am (line 2097)


I would probably put a space here after the colon.


- Kevin Klues


On April 7, 2016, 7:10 a.m., zhou xing wrote:
> 
> 

Review Request 45910: Move metrics code into the scheduler body.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45910/
---

Review request for mesos, Anand Mazumdar, Artem Harutyunyan, and Vinod Kone.


Bugs: MESOS-4982
https://issues.apache.org/jira/browse/MESOS-4982


Repository: mesos


Description
---

Since the HTTP scheduler is a libprocess process, the sub-class 
`Metrics` does not need to be a process anymore.  This moves the
process-specific code into the appropriate place in the scheduler.


Diffs
-

  src/examples/long_lived_framework.cpp 
ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 

Diff: https://reviews.apache.org/r/45910/diff/


Testing
---

make check

Deployed on a test cluster (see the first review in the chain.)


Thanks,

Joseph Wu

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45358/#review127696
---




src/slave/containerizer/mesos/provisioner/paths.hpp (lines 43 - 44)


See my comments below. This is specific to overlay backend. Can you move it 
to overlay.cpp?



src/slave/containerizer/mesos/provisioner/paths.hpp (lines 62 - 66)


This is specific to overlay backend. Can you move that to overlay.cpp 
instead?



src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 296)


since scatch space is specific to overlay backend. I would simply pass 
/containers//backends/ as backendDir here and 
pass it to provision.

We can construct the sratch dir in overlay backend code.


- Jie Yu


On April 6, 2016, 12:12 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45358/
> ---
> 
> (Updated April 6, 2016, 12:12 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.
> 
> 
> Bugs: MESOS-4944
> https://issues.apache.org/jira/browse/MESOS-4944
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved overlay backend to make the rootfs writable.
> 
> 
> Diffs
> -
> 
>   docs/container-image.md db4b291498309d5c0bdbf38552b985c33f28e9a0 
>   src/slave/containerizer/mesos/provisioner/backend.hpp 
> c6cca81e287bb9a62e0390f96e1773841887a206 
>   src/slave/containerizer/mesos/provisioner/backends/bind.hpp 
> 9eda944e14f2b05f28620c2e40594ed4e7bab69e 
>   src/slave/containerizer/mesos/provisioner/backends/bind.cpp 
> 9b9f0b9e99a0fc0e9bad8fb2dad41acdc0ca1da1 
>   src/slave/containerizer/mesos/provisioner/backends/copy.hpp 
> b62507f9fc757349d39f39a6654ddd69053bf0e7 
>   src/slave/containerizer/mesos/provisioner/backends/copy.cpp 
> f353c89806816e85bb27875ef5fa68d5c0eaf9ca 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.hpp 
> 85cc737438c88b355f37611bfde50dc80efab017 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp 
> 93892a75fe3ddd5c7b2a023b63f6d0fa83eeb97d 
>   src/slave/containerizer/mesos/provisioner/paths.hpp 
> 2ea38ac3342e1ebb712a7bea8ebef1bdcf96e809 
>   src/slave/containerizer/mesos/provisioner/paths.cpp 
> 07581f6ac714485e9c743984a553bb6fb26756b7 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 8a4938ebe4e00779e88e7c538445e9ffd51202e2 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> d49204f220c6212f83c2adf5544d04b3386c8eb7 
> 
> Diff: https://reviews.apache.org/r/45358/diff/
> 
> 
> Testing
> ---
> 
> - make check
> - tested manually, with slave using overlay backend. Create a task with mesos 
> containerizer, ubuntu docker image, with the command `mkdir -p /abc && touch 
> /abc/def.txt`.
> - also tested manually with alpine image to verify overlay backend could 
> support 1-layer images.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 45898: CMake: Place master files that moved into the correct directories.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45898/#review127699
---



Patch looks great!

Reviews applied: [45898]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 7, 2016, 9:55 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45898/
> ---
> 
> (Updated April 7, 2016, 9:55 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Place master files that moved into the correct directories.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 9a4cffa952a452d5df70ea42949142e534067cd6 
> 
> Diff: https://reviews.apache.org/r/45898/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 45440: Added some metrics to the long-lived-framework example.

[Joseph Wu]

> On April 6, 2016, 11:55 a.m., Vinod Kone wrote:
> > src/examples/long_lived_framework.cpp, line 272
> > 
> >
> > s/counter/metrics/
> > 
> > I'm assuming you might want to add gauge type metrics to this endpoint 
> > in the future?
> > 
> > More importantly, I didn't understand why you need to add a special 
> > endpoint for these 2 counters. Why can't they just be part of the 
> > "/metrics/snapshot" endpoint like the other metrics?
> 
> Joseph Wu wrote:
> This endpoint's sole purpose is to specify which metrics are `Counters`.  
> We still get the metric values from `/metrics/snapshot`, but it can also call 
> this endpoint to decide which metrics to treat as counters.
> 
> Vinod Kone wrote:
> but why a special endpoint for counters? this is not how we did metrics 
> for master or slave or allocator for example.

For master/agent metrics, we can hard-code a list of counters.  This is how we 
differentiate metrics on our test clusters.

It would be ideal if there were, say, another `/metrics/` 
endpoint which told us which metrics were counters.


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45440/#review127404
---


On April 6, 2016, 4:19 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45440/
> ---
> 
> (Updated April 6, 2016, 4:19 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5062
> https://issues.apache.org/jira/browse/MESOS-5062
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds metrics to gauge the health of the framework.  This includes:
> 
> * uptime_secs = How long the framework has been running.
> * registered = If the framework is registered.
> * offers_received = A counter used to determine if the framework is 
>   starved or not.
> * tasks_launched = Number of tasks launched.
> * abnormal_terminations = Number of terminal status updates which 
>   were not `TASK_FINISHED`.
> 
> Also adds an endpoint `/framework/counters` which returns the list of 
> metrics which are "counters".
> 
> 
> Diffs
> -
> 
>   src/examples/long_lived_framework.cpp 
> ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 
> 
> Diff: https://reviews.apache.org/r/45440/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Also deployed this version on a test cluster.  See the previous review.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Review Request 45604: Updated the balloon framework and executor.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45604/
---

Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and Vinod 
Kone.


Repository: mesos


Description
---

This gives the example `balloon-framework` enough options to run
outside of the build environment.

This also updates:

* The style of the framework code.
* Adds an option for restricting the number of resources per task
  (otherwise, it will eat up an entire node).
* Adds an option for persisting the framework and launching one task
  after another.
* Adds filters for declined offers.
* Adds shutdown logic to the executor.


Diffs
-

  src/examples/balloon_executor.cpp 399218478a596387814d123290eeeb33102fad7a 
  src/examples/balloon_framework.cpp 15c45612b777edaf97aea9b953439d4ad56920f3 
  src/tests/balloon_framework_test.sh ae32753e8942f77f94752543c384d218d6e4d48d 

Diff: https://reviews.apache.org/r/45604/diff/


Testing
---

```
make check 

sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_BalloonFramework"
```


Thanks,

Joseph Wu

Review Request 45905: Added metrics to the balloon framework.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45905/
---

Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and Vinod 
Kone.


Repository: mesos


Description
---

Adds metrics to gauge the health of the framework.  This includes:

* uptime_secs = How long the framework has been running.
* registered = If the framework is registered.
* tasks_finished = Number of tasks finished (successfully).
* tasks_oomed = Number of tasks that were OOM killed.
* abnormal_terminations = Number of terminal status updates which 
  were not `TASK_FINISHED` or `TASK_FAILED` due to OOM.

Also adds an endpoint `/framework/counters` which returns the list of 
metrics which are "counters".


Diffs
-

  src/examples/balloon_framework.cpp 15c45612b777edaf97aea9b953439d4ad56920f3 

Diff: https://reviews.apache.org/r/45905/diff/


Testing
---

```
make check

sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_BalloonFramework"

# Also launched two instances on a cluster.
# This one OOM's:
./balloon-framework --master=zk://localhost:2181/mesos --checkpoint 
--balloon_limit=256MB --task_memory=128MB 
--executor_uri="https://s3.amazonaws.com/url/to/balloon-executor; 
--executor_command="LD_LIBRARY_PATH=/path/to/libmesos && ./balloon-executor"

# This one does not OOM:
./balloon-framework --master=zk://localhost:2181/mesos --checkpoint 
--balloon_limit=256MB --task_memory=256MB 
--executor_uri="https://s3.amazonaws.com/url/to/balloon-executor; 
--executor_command="LD_LIBRARY_PATH=/path/to/libmesos && ./balloon-executor"
```


Thanks,

Joseph Wu

Re: Review Request 44571: Added timeout for destroying Docker containers.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44571/#review127685
---


Fix it, then Ship it!





src/slave/containerizer/docker.cpp (line 1854)


The 1 seconds grace period here is pretty random. Can you make it a 
constant?



src/slave/containerizer/docker.cpp (line 1954)


This is useless since docker->stop does not handle `discard()` properly. We 
still rely on the subprocess to terminate anyway.

To be clear, `discard()` does not necessarily mean that the future will be 
in DISCARDED state. It's up to the owner to decide (calling 
`promise->discard()`).


- Jie Yu


On April 4, 2016, 2:05 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44571/
> ---
> 
> (Updated April 4, 2016, 2:05 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4673
> https://issues.apache.org/jira/browse/MESOS-4673
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Commands issued to the Docker daemon can hang, causing problems within Mesos.
> For example a hanging 'docker stop' can result in an unresponsive executor,
> causing the Mesos agent to issue an to run a 'docker stop' itself which might
> result in an unresponsive agent (see MESOS-4673).
> Adding a timeout can be used as a workaround.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.hpp 89d450e10a84f24ddd46d517e2b4b46ab02c4fda 
>   src/slave/containerizer/docker.cpp 9314d1f9e0b6077fe7c48b860783ab21acc48be6 
> 
> Diff: https://reviews.apache.org/r/44571/diff/
> 
> 
> Testing
> ---
> 
> sudo ./bin/mesos-tests.sh (to test if existing tests break due to the changed 
> behavior)
> 
> Because docker must hang for both the Mesos agent as well as the 
> `mesos-docker-executor`, it can't currently be tested as part of the Mesos 
> integration tests. Here's how to test that the timeout works:
> Run with Fedora 23 (Kernel 4.2.3, Docker 1.9.1)
> # Start a master
> ./bin/mesos-master.sh --work_dir=/tmp/mesos &
> 
> # Start an agent
> sudo ./bin/mesos-slave.sh --master=127.0.0.1:5050 --containerizers=docker &
> 
> # Run a task using the docker containerizer
> ./src/mesos-execute --containerizer=docker --docker_image=alpine 
> --master=127.0.0.1:5050 --name="sleep" --command="sleep 1000" &
> # Note the pid of `mesos-execute` as well as the pid of the sleep task run by 
> docker (eg 3323 and 3474)
> 
> # Have mesos run `docker inspect` to gather the pid of the docker task
> curl -X GET localhost:5051/monitor/statistics
> 
> # Now overload docker by trying to run a lot of tasks in parallel
> for i in `seq 1 100`; do sudo docker run --rm alpine sleep 60 & done
> 
> # Wait until the first of these docker tasks finish, `sudo docker ps` should 
> be unresponsible now
> # Kill the `mesos-execute` task (eg 3323)
> kill 3323
> 
> # Watch the logs of the Mesos agent. At some point it will send a SIGKILL to 
> the docker task (eg 3474)
> # Make sure that the docker task is indeed termintad (using `ps fax` or the 
> like)
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 45800: Moved long running framework to use the v1 API.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45800/#review127684
---



Bad patch!

Reviews applied: [45800, 45799, 45440, 45067]

Failed command: ./support/apply-review.sh -n -r 45067

Error:
2016-04-07 22:44:16 URL:https://reviews.apache.org/r/45067/diff/raw/ 
[13287/13287] -> "45067.patch" [1]
Total errors found: 0
Checking 1 files
Error: No line in the commit message summary may exceed 72 characters.

Full log: https://builds.apache.org/job/mesos-reviewbot/12394/console

- Mesos ReviewBot


On April 7, 2016, 9:50 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45800/
> ---
> 
> (Updated April 7, 2016, 9:50 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-4982
> https://issues.apache.org/jira/browse/MESOS-4982
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary. Also removed the AuthN code. Once, the library
> supports AuthN we can bring it back.
> 
> 
> Diffs
> -
> 
>   src/examples/long_lived_framework.cpp 
> ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 
> 
> Diff: https://reviews.apache.org/r/45800/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Review Request 45900: Removed stale contender/detector files.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45900/
---

Review request for mesos, Anurag Singh and James Peach.


Repository: mesos


Description
---

Also updated Makefile.am to move contender/detector module library
declarations into the existing list.


Diffs
-

  src/Makefile.am 71c4308cccfa5c56b93f6c3928dd2a1cf3ba9741 
  src/master/contender/contender.hpp ba05551340f9ca1763f2f460121dc008f0262686 
  src/master/detector/detector.hpp 840026577d81d1b8cd3b079ff1e5b6809d139250 

Diff: https://reviews.apache.org/r/45900/diff/


Testing
---

make check.


Thanks,

Kapil Arya

Review Request 45901: Removed unsed headers from master contender/detector files.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45901/
---

Review request for mesos and Anurag Singh.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/master/contender/contender.cpp 9ad62528ff5cccfa693c2c6289f05060ece5 
  src/master/contender/standalone.hpp 511165c8b355ac9732c2e8921e12545c7c6217ed 
  src/master/contender/standalone.cpp 18959510338c0f2c5b2df254845c119902ff538f 
  src/master/contender/zookeeper.hpp 0363ecde801e429df162eca634c89cb1dacd82a2 
  src/master/contender/zookeeper.cpp 847c62eaaa0ba609138f20c3f4946130d87f2bba 
  src/master/detector/detector.cpp 38517324b3b030c5c425a401ee57cfa53c8ce176 
  src/master/detector/standalone.hpp a4007a4f342f177afd09939aac81f4caefadbbd5 
  src/master/detector/standalone.cpp 0b5de9e5bd575255dac6b18ad63a3eccea589fee 
  src/master/detector/zookeeper.hpp 042505346636de8e1d258ca3f866e7c35acfca01 
  src/master/detector/zookeeper.cpp 519a1025d804a7191fb89dca03d7acc969c37758 

Diff: https://reviews.apache.org/r/45901/diff/


Testing
---

make check.


Thanks,

Kapil Arya

Re: Review Request 45200: Duplicate flags with keywork 'slave' on master side.

[Vinod Kone]

> On April 1, 2016, 10:49 p.m., Vinod Kone wrote:
> > Can you call this out in the CHANGELOG too please?
> > 
> > Also, all of the old flags should print a deprecation warning (when a user 
> > does --help on the binary or starts the binary with a deprecated flag) and 
> > direct users to the new flags. Can you make that change?
> 
> Jay Guo wrote:
> Sure, will do.

Any update on this?

Also the description should be more meaningful than the bug id. Move the bug id 
to "bugs" field.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45200/#review126661
---


On March 23, 2016, 7:39 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45200/
> ---
> 
> (Updated March 23, 2016, 7:39 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> [https://issues.apache.org/jira/browse/MESOS-3781]
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 6552e48eab2708a28dd69adba3ec759cb5aeca4c 
>   src/master/flags.hpp f8d2cc4c6c8dab00e34ca737dbcb5b9ca3870d6d 
>   src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61 
>   src/tests/flags_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45200/diff/
> 
> 
> Testing
> ---
> 
> ./configure --with-network-isolator
> make check
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review127677
---




support/docker_build.sh (line 10)


s/CONFIGURATOR/BUILDTOOL/



support/docker_build.sh (line 16)


the previous version was working fine on ubuntu and centos. why the change?



support/docker_build.sh 


we leave 2 blank lines between outer elements. why the change?



support/docker_build.sh (line 114)


How about

# NOTE: Enviornment is currently ignored by CMake build because tests are 
not run.



support/docker_build.sh (line 123)


indent the comment with the line below.



support/docker_build.sh (line 124)


s/mesos-cmake/build/



support/docker_build.sh (line 127)


s/Configurator/build tool/


- Vinod Kone


On April 6, 2016, 3:49 p.m., Juan Larriba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> ---
> 
> (Updated April 6, 2016, 3:49 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enable CMake build for Linux as new CONFIGURATOR option.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> ---
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both 
> cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in 
> centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

[Vinod Kone]

> On April 7, 2016, 10:13 p.m., Vinod Kone wrote:
> >

Also can you create an issue on ASF JIRA (if there isn't one already) and 
attach it to "bugs" in this review?


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review127677
---


On April 6, 2016, 3:49 p.m., Juan Larriba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> ---
> 
> (Updated April 6, 2016, 3:49 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enable CMake build for Linux as new CONFIGURATOR option.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> ---
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both 
> cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in 
> centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 44950: Add XFS disk isolator documentation.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44950/#review127679
---



Bad patch!

Reviews applied: [44950, 44949, 44948, 44947, 45689, 44946, 44945]

Failed command: ./support/apply-review.sh -n -r 45689

Error:
2016-04-07 22:15:41 URL:https://reviews.apache.org/r/45689/diff/raw/ 
[1413/1413] -> "45689.patch" [1]
error: patch failed: src/tests/cluster.hpp:185
error: src/tests/cluster.hpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/12393/console

- Mesos ReviewBot


On April 7, 2016, 9:50 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44950/
> ---
> 
> (Updated April 7, 2016, 9:50 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOs-4828
> https://issues.apache.org/jira/browse/MESOs-4828
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add XFS disk isolator documentation.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 4337490c2330e0a09bd8c1e8ac50906b2ebf936b 
>   docs/configuration.md 309a5a05eab386c8943ba6bdee8d5efeb448aa0c 
>   docs/mesos-containerizer.md 2fde74362f35568bb944da80a1db17e6d3ba9d7b 
> 
> Diff: https://reviews.apache.org/r/44950/diff/
> 
> 
> Testing
> ---
> 
> Make check. Source inspection.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/#review127678
---


Fix it, then Ship it!





docs/persistent-volume.md (line 296)


Replace "Returns `202 ACCEPTED` which" with "This endpoint returns the `202 
ACCEPTED` HTTP status code, which " -- here and below.



docs/upgrades.md (line 167)


Replace "return code" with "HTTP status code"

I think you can just remove "which may introduce backwards incompatibility 
issue" (if we're keeping it, the grammar isn't quite right).


- Neil Conway


On April 7, 2016, 8:56 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44606/
> ---
> 
> (Updated April 7, 2016, 8:56 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod 
> Kone.
> 
> 
> Bugs: mesos-4580
> https://issues.apache.org/jira/browse/mesos-4580
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modify the return code of the following endpoints to 202:
> 1. /reserve
> 2. /unreserve
> 3. /create-volumes
> 4. /destroy-volumes
> 
> [#MESOS-4580]
> 
> 
> Diffs
> -
> 
>   CHANGELOG 4553465cc3dc17956f168469d405f7a453d6359e 
>   docs/endpoints/master/create-volumes.md 
> 52ae3a8159bb7d26b63f5889ce3f122371afbdc4 
>   docs/endpoints/master/destroy-volumes.md 
> a0bb1e8d1ce42ab2b96518cd4d325bfc541ad4ff 
>   docs/endpoints/master/reserve.md 1d481b56d380d45218001513330b225ca4a0a55c 
>   docs/endpoints/master/unreserve.md b9282df659ebb6090ef49ef8fc0f01411cd53103 
>   docs/persistent-volume.md ab6ed8227259384261dd5f7c2e353753f20e5c19 
>   docs/reservation.md 75357206085848826b70c2d6f2be93d20e771604 
>   docs/upgrades.md 64c6a02dd54ddf06c557b38e08916dc10e484cdd 
>   src/master/http.cpp f781fd0102c247b2e77a71f7be82b872b0831681 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 9b8ad34469c0c9a986aa60f3a52584a3a9eabb2b 
>   src/tests/reservation_endpoints_tests.cpp 
> 2e0f6c1aba95d918b8c42219ee97f79f1070d56e 
> 
> Diff: https://reviews.apache.org/r/44606/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 45803: Add PowerPC LE CI for support/docker_build.sh.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45803/#review127676
---




support/docker_build.sh (lines 71 - 92)


Instead of copy pasting how about changing the `ubuntu*` case above to 
`*ubuntu*`



support/docker_build.sh (line 84)


gcc is installed by `build-essential`. don't you want to install clang like 
we did above?


- Vinod Kone


On April 6, 2016, 9:25 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45803/
> ---
> 
> (Updated April 6, 2016, 9:25 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4897
> https://issues.apache.org/jira/browse/MESOS-4897
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add PowerPC LE CI for support/docker_build.sh.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45803/diff/
> 
> 
> Testing
> ---
> 
> On a PowerPC machine, run following command:
> 
> ENVIRONMENT='GLOG_v=0' CONFIGURATION='--enable-libevent --enable-ssl' 
> OS='ppc64le/ubuntu:14.04' COMPILER=gcc ./support/docker_build.sh
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Review Request 45898: CMake: Place master files that moved into the correct directories.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45898/
---

Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

CMake: Place master files that moved into the correct directories.


Diffs
-

  src/CMakeLists.txt 9a4cffa952a452d5df70ea42949142e534067cd6 

Diff: https://reviews.apache.org/r/45898/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 45800: Moved long running framework to use the v1 API.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45800/
---

(Updated April 7, 2016, 9:50 p.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Changes
---

Review comments from Vinod


Bugs: MESOS-4982
https://issues.apache.org/jira/browse/MESOS-4982


Repository: mesos


Description
---

See summary. Also removed the AuthN code. Once, the library
supports AuthN we can bring it back.


Diffs (updated)
-

  src/examples/long_lived_framework.cpp 
ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 

Diff: https://reviews.apache.org/r/45800/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44946/
---

(Updated April 7, 2016, 9:50 p.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased.


Bugs: MESOS-4828
https://issues.apache.org/jira/browse/MESOS-4828


Repository: mesos


Description
---

Add utility functions to manipulate XFS project quotas.


Diffs (updated)
-

  src/Makefile.am 71c4308cccfa5c56b93f6c3928dd2a1cf3ba9741 
  src/slave/containerizer/mesos/isolators/xfs/utils.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/xfs/utils.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44946/diff/


Testing
---

Make check. Manual verification. Tests in subsequent patches.


Thanks,

James Peach

Re: Review Request 44949: Add XFS disk isolator tests.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44949/
---

(Updated April 7, 2016, 9:50 p.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased.


Bugs: MESOS-4828
https://issues.apache.org/jira/browse/MESOS-4828


Repository: mesos


Description
---

Add basic XFS disk isolator tests by cloning the POSIX disk isolator
tests and making minor changes for the differences in semantics.


Diffs (updated)
-

  src/tests/containerizer/xfs_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44949/diff/


Testing
---

Make check. Manual testing.


Thanks,

James Peach

Re: Review Request 44948: Add XFS disk resource isolator.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44948/
---

(Updated April 7, 2016, 9:50 p.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased.


Bugs: MESOs-4828
https://issues.apache.org/jira/browse/MESOs-4828


Repository: mesos


Description
---

Track sandbox directory usage by dynamically assigning XFS project
quotas. We track a range of XFS project IDs, assigning a project ID
and a project quota to each sandbox as it is created. When the task
reaches the quota, writes will fail with EDQUOT, and the task will have
an opportunity to handle that.

Quotas are not applied to volume resources since the isolator interface
has no insight into the volume lifecycle. Thus it is not currently
possible to accurately assign and reclaim project IDs.

If LOW is the lower bound of the project ID range and HIGH is the upper
bound, you can show the currently allocated project quotas using the
xfs_quota command:

  $ xfs_quota -x -c "report -a -n -L LOW -U HIGH"

To show the project ID assigned to the file PATH, use the xfs_io command:

  $ xfs_io -r -c stat PATH


Diffs (updated)
-

  src/Makefile.am 71c4308cccfa5c56b93f6c3928dd2a1cf3ba9741 
  src/slave/containerizer/mesos/containerizer.cpp 
a5dd22380066aa85de04d485052084e2629681c0 
  src/slave/containerizer/mesos/isolators/xfs/disk.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/xfs/disk.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/xfs/utils.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/xfs/utils.cpp PRE-CREATION 
  src/slave/flags.hpp 4236b7fe40b9aa26d57b651be06a0e36037f65c6 
  src/slave/flags.cpp 7164afef9c82a9bba0f137d7387c3569912b6599 

Diff: https://reviews.apache.org/r/44948/diff/


Testing
---

Make check. Manual testing. Tests in subsequent patches.


Thanks,

James Peach

Re: Review Request 44947: Add tests for XFS project quota utilities.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44947/
---

(Updated April 7, 2016, 9:49 p.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased.


Bugs: MESOS-4828
https://issues.apache.org/jira/browse/MESOS-4828


Repository: mesos


Description
---

Add tests for XFS project quota utilities.


Diffs (updated)
-

  src/Makefile.am 71c4308cccfa5c56b93f6c3928dd2a1cf3ba9741 
  src/tests/containerizer/xfs_quota_tests.cpp PRE-CREATION 
  src/tests/environment.cpp acadb5bb0a1b1a9b0cee0345035b93147bf7164c 

Diff: https://reviews.apache.org/r/44947/diff/


Testing
---

Make check. Manual testing. These tests.


Thanks,

James Peach

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44945/
---

(Updated April 7, 2016, 9:49 p.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
---

Rebased.


Bugs: MESOS-4828
https://issues.apache.org/jira/browse/MESOS-4828


Repository: mesos


Description
---

Add autoconf tests for XFS project quotas.


Diffs (updated)
-

  configure.ac c693b825294f82ace8a14563cf2229820e159e3c 

Diff: https://reviews.apache.org/r/44945/diff/


Testing
---

Make check. Manual verification.


Thanks,

James Peach

Re: Review Request 45800: Moved long running framework to use the v1 API.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45800/#review127670
---



Bad patch!

Reviews applied: [45800, 45799, 45440, 45067]

Failed command: ./support/apply-review.sh -n -r 45067

Error:
2016-04-07 21:45:04 URL:https://reviews.apache.org/r/45067/diff/raw/ 
[13287/13287] -> "45067.patch" [1]
Total errors found: 0
Checking 1 files
Error: No line in the commit message summary may exceed 72 characters.

Full log: https://builds.apache.org/job/mesos-reviewbot/12392/console

- Mesos ReviewBot


On April 7, 2016, 9:25 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45800/
> ---
> 
> (Updated April 7, 2016, 9:25 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-4982
> https://issues.apache.org/jira/browse/MESOS-4982
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary. Also removed the AuthN code. Once, the library
> supports AuthN we can bring it back.
> 
> 
> Diffs
> -
> 
>   src/examples/long_lived_framework.cpp 
> ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 
> 
> Diff: https://reviews.apache.org/r/45800/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 45440: Added some metrics to the long-lived-framework example.

[Vinod Kone]

> On April 6, 2016, 6:55 p.m., Vinod Kone wrote:
> > src/examples/long_lived_framework.cpp, line 272
> > 
> >
> > s/counter/metrics/
> > 
> > I'm assuming you might want to add gauge type metrics to this endpoint 
> > in the future?
> > 
> > More importantly, I didn't understand why you need to add a special 
> > endpoint for these 2 counters. Why can't they just be part of the 
> > "/metrics/snapshot" endpoint like the other metrics?
> 
> Joseph Wu wrote:
> This endpoint's sole purpose is to specify which metrics are `Counters`.  
> We still get the metric values from `/metrics/snapshot`, but it can also call 
> this endpoint to decide which metrics to treat as counters.

but why a special endpoint for counters? this is not how we did metrics for 
master or slave or allocator for example.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45440/#review127404
---


On April 6, 2016, 11:19 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45440/
> ---
> 
> (Updated April 6, 2016, 11:19 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5062
> https://issues.apache.org/jira/browse/MESOS-5062
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds metrics to gauge the health of the framework.  This includes:
> 
> * uptime_secs = How long the framework has been running.
> * registered = If the framework is registered.
> * offers_received = A counter used to determine if the framework is 
>   starved or not.
> * tasks_launched = Number of tasks launched.
> * abnormal_terminations = Number of terminal status updates which 
>   were not `TASK_FINISHED`.
> 
> Also adds an endpoint `/framework/counters` which returns the list of 
> metrics which are "counters".
> 
> 
> Diffs
> -
> 
>   src/examples/long_lived_framework.cpp 
> ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 
> 
> Diff: https://reviews.apache.org/r/45440/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Also deployed this version on a test cluster.  See the previous review.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 45799: Cleaned up the virtual overloads in long lived framework.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45799/#review127663
---


Ship it!




Ship It!

- Vinod Kone


On April 6, 2016, 3:43 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45799/
> ---
> 
> (Updated April 6, 2016, 3:43 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4982
> https://issues.apache.org/jira/browse/MESOS-4982
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change removes the unused methods that won't be needed
> after moving to the v1 API. This review mainly eases reviewing
> later in the chain and should not be committed on its own.
> 
> 
> Diffs
> -
> 
>   src/examples/long_lived_framework.cpp 
> ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 
> 
> Diff: https://reviews.apache.org/r/45799/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 45800: Moved long running framework to use the v1 API.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45800/#review127665
---


Fix it, then Ship it!





src/examples/long_lived_framework.cpp (line 594)


// Add a TODO here to add support for AuthN.


- Vinod Kone


On April 7, 2016, 9:25 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45800/
> ---
> 
> (Updated April 7, 2016, 9:25 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-4982
> https://issues.apache.org/jira/browse/MESOS-4982
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary. Also removed the AuthN code. Once, the library
> supports AuthN we can bring it back.
> 
> 
> Diffs
> -
> 
>   src/examples/long_lived_framework.cpp 
> ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 
> 
> Diff: https://reviews.apache.org/r/45800/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 45800: Moved long running framework to use the v1 API.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45800/
---

(Updated April 7, 2016, 9:24 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Rebased.


Bugs: MESOS-4982
https://issues.apache.org/jira/browse/MESOS-4982


Repository: mesos


Description
---

See summary. Also removed the AuthN code. Once, the library
supports AuthN we can bring it back.


Diffs (updated)
-

  src/examples/long_lived_framework.cpp 
ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 

Diff: https://reviews.apache.org/r/45800/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 45799: Cleaned up the virtual overloads in long lived framework.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45799/
---

(Updated April 7, 2016, 9:24 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Rebased


Bugs: MESOS-4982
https://issues.apache.org/jira/browse/MESOS-4982


Repository: mesos


Description
---

This change removes the unused methods that won't be needed
after moving to the v1 API. This review mainly eases reviewing
later in the chain and should not be committed on its own.


Diffs (updated)
-

  src/examples/long_lived_framework.cpp 
ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 

Diff: https://reviews.apache.org/r/45799/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 45440: Added some metrics to the long-lived-framework example.

[Vinod Kone]

> On April 6, 2016, 6:55 p.m., Vinod Kone wrote:
> >

As discussed offline, lets add TODOs for metrics to defer the gauges to 
scheduler process.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45440/#review127404
---


On April 6, 2016, 11:19 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45440/
> ---
> 
> (Updated April 6, 2016, 11:19 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5062
> https://issues.apache.org/jira/browse/MESOS-5062
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds metrics to gauge the health of the framework.  This includes:
> 
> * uptime_secs = How long the framework has been running.
> * registered = If the framework is registered.
> * offers_received = A counter used to determine if the framework is 
>   starved or not.
> * tasks_launched = Number of tasks launched.
> * abnormal_terminations = Number of terminal status updates which 
>   were not `TASK_FINISHED`.
> 
> Also adds an endpoint `/framework/counters` which returns the list of 
> metrics which are "counters".
> 
> 
> Diffs
> -
> 
>   src/examples/long_lived_framework.cpp 
> ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 
> 
> Diff: https://reviews.apache.org/r/45440/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Also deployed this version on a test cluster.  See the previous review.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 44081: Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44081/
---

(Updated April 7, 2016, 7:35 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
9ee233b988c08d953e70345c55bcdd5c2f7c101b 

Diff: https://reviews.apache.org/r/44081/diff/


Testing
---


Thanks,

Alex Clemmer

Review Request 45888: Stout: Implemented `os::setenv` on Windows.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45888/
---

Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Stout: Implemented `os::setenv` on Windows.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
6a391ff198ab724f689bcef79d4e2e05a786cbc2 

Diff: https://reviews.apache.org/r/45888/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45022/#review127638
---



Bad patch!

Reviews applied: [45022, 45015, 45009, 44084, 44978, 44082, 44081, 44808]

Failed command: ./support/apply-review.sh -n -r 44082

Error:
2016-04-07 18:43:23 URL:https://reviews.apache.org/r/44082/diff/raw/ 
[3757/3757] -> "44082.patch" [1]
error: patch failed: 
3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp:99
error: 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp: patch 
does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/12389/console

- Mesos ReviewBot


On April 7, 2016, 6:23 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45022/
> ---
> 
> (Updated April 7, 2016, 6:23 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4415
> https://issues.apache.org/jira/browse/MESOS-4415
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We currently depend on arcane "POSIX-like" Windows APIs like `::remove`.
> This API is incompatible with NT paths -- which we will eventually have
> to transition to for the Windows integration -- and has no documented
> behavior interacting with subsystems like the driver subsystem, which is
> required for symlinks.
> 
> This commit will move us to proper core Windows API equivalents for
> `::remove`.
> 
> Review: https://reviews.apache.org/r/45022
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 54dd3f7e1453a756e10652cebf4c2a2b09e3d5a4 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rm.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rm.hpp 
> 52568b303c03fd57b81f6cc67782444ce734dd41 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rm.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
> 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 
> 
> Diff: https://reviews.apache.org/r/45022/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 45494: Removed clone option from subprocess [4/5].

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45494/#review127637
---




3rdparty/libprocess/src/subprocess.cpp (line 561)


May I ask why open update `clone` in linux when `clone_flags.isSome()`? As 
you see in the old version code, it update `clone` without care about the 
platform?

And if we really only want to update `clone` in linxu, may we add a error 
log here if `clone_flags.isSome()` in other platforms?


- haosdent huang


On April 7, 2016, 5:07 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45494/
> ---
> 
> (Updated April 7, 2016, 5:07 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5071
> https://issues.apache.org/jira/browse/MESOS-5071
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> As we now support namespaces in the subprocess there should be no need
> for custom clone functions.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> 8a3fe5526f480187441a8aee2c72636bec3e2b2d 
>   3rdparty/libprocess/src/subprocess.cpp 
> bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 
> 
> Diff: https://reviews.apache.org/r/45494/diff/
> 
> 
> Testing
> ---
> 
> Tested entire chain see https://reviews.apache.org/r/45495/.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 45491: Refactored subprocess options [1/5].

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45491/#review127636
---




3rdparty/libprocess/src/subprocess.cpp (line 67)


I think we could use `os::chdir` here?

```
inline Try chdir(const std::string& directory)
{
  if (::chdir(directory.c_str()) < 0) {
return ErrnoError();
  }

  return Nothing();
}
```



3rdparty/libprocess/src/subprocess.cpp (line 441)


Because abort here, should we use `ERROR` level?


- haosdent huang


On April 7, 2016, 4:55 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45491/
> ---
> 
> (Updated April 7, 2016, 4:55 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5070
> https://issues.apache.org/jira/browse/MESOS-5070
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously the subprocess interface supported a several options for the
> child process such as setsid. In order to make the interface more
> flexible we refactored such options into a vector of ChildHooks.
> In order not to allow arbitrary code inside a ChildHook it has to be
> constructed via pre-defined factory methods.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/ssl/gtest.hpp 
> 5435ddda1fd7dfcff1a0b28f2abe35feb707ceeb 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> 8a3fe5526f480187441a8aee2c72636bec3e2b2d 
>   3rdparty/libprocess/src/subprocess.cpp 
> bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 
> 727e940f12643974de4ff2734fba431b285b5de3 
> 
> Diff: https://reviews.apache.org/r/45491/diff/
> 
> 
> Testing
> ---
> 
> Tested entire chain see https://reviews.apache.org/r/45495/.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45022/
---

(Updated April 7, 2016, 6:23 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-4415
https://issues.apache.org/jira/browse/MESOS-4415


Repository: mesos


Description
---

We currently depend on arcane "POSIX-like" Windows APIs like `::remove`.
This API is incompatible with NT paths -- which we will eventually have
to transition to for the Windows integration -- and has no documented
behavior interacting with subsystems like the driver subsystem, which is
required for symlinks.

This commit will move us to proper core Windows API equivalents for
`::remove`.

Review: https://reviews.apache.org/r/45022


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
54dd3f7e1453a756e10652cebf4c2a2b09e3d5a4 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rm.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/rm.hpp 
52568b303c03fd57b81f6cc67782444ce734dd41 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rm.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 

Diff: https://reviews.apache.org/r/45022/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

[Michael Park]

> On March 22, 2016, 8:35 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rm.hpp, lines 
> > 41-43
> > 
> >
> > `RemoveDirectory` only works on empty directories, right? This seems to 
> > be consistent with `rmdir`. Is this not true? Could you explain what the 
> > inconsistency is?
> 
> Alex Clemmer wrote:
> Hmm, inconsistent? It looks like the comment is saying that `rmdir` and 
> `RemoveDirectory` are consistent? Is the inconsistency elsewhere in another 
> comment?

Weird, I think maybe I read this incorrectly when I commented on it.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45022/#review124879
---


On April 7, 2016, 11:08 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45022/
> ---
> 
> (Updated April 7, 2016, 11:08 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4415
> https://issues.apache.org/jira/browse/MESOS-4415
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We currently depend on arcane "POSIX-like" Windows APIs like `::remove`.
> This API is incompatible with NT paths -- which we will eventually have
> to transition to for the Windows integration -- and has no documented
> behavior interacting with subsystems like the driver subsystem, which is
> required for symlinks.
> 
> This commit will move us to proper core Windows API equivalents for
> `::remove`.
> 
> Review: https://reviews.apache.org/r/45022
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 7bd4bfbc2ec5922879dcefddc12137336b11be52 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rm.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rm.hpp 
> 52568b303c03fd57b81f6cc67782444ce734dd41 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rm.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
> 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 
> 
> Diff: https://reviews.apache.org/r/45022/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

[Michael Park]

> On March 22, 2016, 8:30 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp, line 200
> > 
> >
> > Why do we need this? I would much prefer to remove this.
> 
> Alex Clemmer wrote:
> What would you like to see instead? This is how the tests were initially 
> concieved before they moved here, IIRC. I'm happy to change it, as I didn't 
> set out to do this myself.

Ah I see. Sorry about that.

This is only used in one place:
```cpp
  hashset expectedListing = EMPTY;
```

We can just do the following instead:
```cpp
  hashset expectedListing;
```


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45022/#review124867
---


On April 7, 2016, 11:08 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45022/
> ---
> 
> (Updated April 7, 2016, 11:08 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4415
> https://issues.apache.org/jira/browse/MESOS-4415
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We currently depend on arcane "POSIX-like" Windows APIs like `::remove`.
> This API is incompatible with NT paths -- which we will eventually have
> to transition to for the Windows integration -- and has no documented
> behavior interacting with subsystems like the driver subsystem, which is
> required for symlinks.
> 
> This commit will move us to proper core Windows API equivalents for
> `::remove`.
> 
> Review: https://reviews.apache.org/r/45022
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 7bd4bfbc2ec5922879dcefddc12137336b11be52 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rm.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rm.hpp 
> 52568b303c03fd57b81f6cc67782444ce734dd41 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rm.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
> 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 
> 
> Diff: https://reviews.apache.org/r/45022/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 42516: Add support for user-defined networks.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42516/#review127624
---


Ship it!




Ship It!

- Jie Yu


On March 31, 2016, 11:17 a.m., Ezra Silvera wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42516/
> ---
> 
> (Updated March 31, 2016, 11:17 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Bugs: MESOS-4369
> https://issues.apache.org/jira/browse/MESOS-4369
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Signed-off-by: Ezra Silvera 
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto cb68e2c13409620fa4836c12d877488f4333ace7 
>   include/mesos/v1/mesos.proto af1dc9e11a26b52cfc348324b8dd796c1f72323f 
>   src/docker/docker.cpp 4d35513cdd9c044d37d876a6db7dd9321ceaca53 
> 
> Diff: https://reviews.apache.org/r/42516/diff/
> 
> 
> Testing
> ---
> 
> Using Swarm running on Mesos create a network with "docker  network create 
> --driver=bridge myNetwork"   and then create a container on that network:  
> "docker run --net=myNetwork"
> 
> 
> Thanks,
> 
> Ezra Silvera
> 
>

Re: Review Request 45495: Removed custom clone functions from Mesos [5/5].

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45495/
---

(Updated April 7, 2016, 5:09 p.m.)


Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-5071
https://issues.apache.org/jira/browse/MESOS-5071


Repository: mesos


Description
---

All existing clone calls can be specified by providing namespace flags
to subprocess directly.


Diffs (updated)
-

  src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5 
  src/slave/container_loggers/lib_logrotate.cpp 
1f228806da32832c9ca1ae4defcd1bdc154adc18 
  src/slave/containerizer/docker.cpp 0576eab65a1f3556644472d5c9baba4ea9c34346 
  src/slave/containerizer/external_containerizer.cpp 
cf4384cce44172a028c890f52f71ceb8ae109383 
  src/slave/containerizer/mesos/isolators/posix/disk.cpp 
dde958b252eae75563003ec15087b4231beb285a 
  src/slave/containerizer/mesos/launcher.cpp 
a5c8c31b72773d0bd10b9d02675a01f1d641d41c 
  src/slave/containerizer/mesos/linux_launcher.cpp 
5028854fa003615f158120e030866b7ec4402b66 
  src/tests/containerizer/launch_tests.cpp 
3e36f2f7ab89b98de2c1a971e4ecca58c13ad642 
  src/tests/containerizer/ns_tests.cpp cd668ebb3b9461bee00dc338c288e5df6eb8fe31 

Diff: https://reviews.apache.org/r/45495/diff/


Testing
---

sudo make check

../configure --with-network-isolator
make check


Thanks,

Joerg Schad

Re: Review Request 45494: Removed clone option from subprocess [4/5].

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45494/
---

(Updated April 7, 2016, 5:07 p.m.)


Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-5071
https://issues.apache.org/jira/browse/MESOS-5071


Repository: mesos


Description
---

As we now support namespaces in the subprocess there should be no need
for custom clone functions.


Diffs (updated)
-

  3rdparty/libprocess/include/process/subprocess.hpp 
8a3fe5526f480187441a8aee2c72636bec3e2b2d 
  3rdparty/libprocess/src/subprocess.cpp 
bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 

Diff: https://reviews.apache.org/r/45494/diff/


Testing
---

Tested entire chain see https://reviews.apache.org/r/45495/.


Thanks,

Joerg Schad

Re: Review Request 45493: Added cloneFlags option to subprocess [3/5].

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45493/
---

(Updated April 7, 2016, 5:02 p.m.)


Review request for mesos and Joris Van Remoortere.


Summary (updated)
-

Added cloneFlags option to subprocess [3/5].


Bugs: MESOS-5071
https://issues.apache.org/jira/browse/MESOS-5071


Repository: mesos


Description (updated)
---

Allows  cloneFlags to be passed to subprocess.


Diffs (updated)
-

  3rdparty/libprocess/include/process/subprocess.hpp 
8a3fe5526f480187441a8aee2c72636bec3e2b2d 
  3rdparty/libprocess/src/subprocess.cpp 
bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 

Diff: https://reviews.apache.org/r/45493/diff/


Testing
---

Tested entire chain see https://reviews.apache.org/r/45495/.


Thanks,

Joerg Schad

Re: Review Request 45493: Added namespace option to subprocess [3/5].

[Joerg Schad]

> On April 5, 2016, 6:53 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/include/process/subprocess.hpp, lines 338-355
> > 
> >
> > Can you add a `TODO` here to consider making this `clone_flags` as 
> > opposed to `namespaces`?

Seeing the comments in the following reviews I actually went ahead and renamed 
it.


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45493/#review127182
---


On March 31, 2016, 10:22 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45493/
> ---
> 
> (Updated March 31, 2016, 10:22 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5071
> https://issues.apache.org/jira/browse/MESOS-5071
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allows namespaces flags to be passed to subprocess.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> 8a3fe5526f480187441a8aee2c72636bec3e2b2d 
>   3rdparty/libprocess/src/subprocess.cpp 
> bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 
> 
> Diff: https://reviews.apache.org/r/45493/diff/
> 
> 
> Testing
> ---
> 
> Tested entire chain see https://reviews.apache.org/r/45495/.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 45491: Refactored subprocess options [1/5].

[Joerg Schad]

> On April 5, 2016, 6:40 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/include/process/subprocess.hpp, line 219
> > 
> >
> > Do we use this `operator() ()` style elsewhere?

If you mean `operator()()` (vs `operator() ()`) then it is fixed.
Or were you refering to the pattern using `operator()()` in order to expose 
private functions?


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45491/#review127172
---


On April 7, 2016, 4:55 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45491/
> ---
> 
> (Updated April 7, 2016, 4:55 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5070
> https://issues.apache.org/jira/browse/MESOS-5070
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously the subprocess interface supported a several options for the
> child process such as setsid. In order to make the interface more
> flexible we refactored such options into a vector of ChildHooks.
> In order not to allow arbitrary code inside a ChildHook it has to be
> constructed via pre-defined factory methods.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/ssl/gtest.hpp 
> 5435ddda1fd7dfcff1a0b28f2abe35feb707ceeb 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> 8a3fe5526f480187441a8aee2c72636bec3e2b2d 
>   3rdparty/libprocess/src/subprocess.cpp 
> bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 
> 727e940f12643974de4ff2734fba431b285b5de3 
> 
> Diff: https://reviews.apache.org/r/45491/diff/
> 
> 
> Testing
> ---
> 
> Tested entire chain see https://reviews.apache.org/r/45495/.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 45491: Refactored subprocess options [1/5].

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45491/
---

(Updated April 7, 2016, 4:55 p.m.)


Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-5070
https://issues.apache.org/jira/browse/MESOS-5070


Repository: mesos


Description
---

Previously the subprocess interface supported a several options for the
child process such as setsid. In order to make the interface more
flexible we refactored such options into a vector of ChildHooks.
In order not to allow arbitrary code inside a ChildHook it has to be
constructed via pre-defined factory methods.


Diffs (updated)
-

  3rdparty/libprocess/include/process/ssl/gtest.hpp 
5435ddda1fd7dfcff1a0b28f2abe35feb707ceeb 
  3rdparty/libprocess/include/process/subprocess.hpp 
8a3fe5526f480187441a8aee2c72636bec3e2b2d 
  3rdparty/libprocess/src/subprocess.cpp 
bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 
  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
727e940f12643974de4ff2734fba431b285b5de3 

Diff: https://reviews.apache.org/r/45491/diff/


Testing
---

Tested entire chain see https://reviews.apache.org/r/45495/.


Thanks,

Joerg Schad

Re: Review Request 45876: Fixed library lookup for Master detector/contender modules.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45876/#review127609
---


Ship it!




Ship It!

- James Peach


On April 7, 2016, 4:40 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45876/
> ---
> 
> (Updated April 7, 2016, 4:40 p.m.)
> 
> 
> Review request for mesos, Jie Yu and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/module.cpp 4b2404871386319393fc09e1dce872cf6bd43279 
> 
> Diff: https://reviews.apache.org/r/45876/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Review Request 45876: Fixed library lookup for Master detector/contender modules.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45876/
---

Review request for mesos, Jie Yu and James Peach.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/tests/module.cpp 4b2404871386319393fc09e1dce872cf6bd43279 

Diff: https://reviews.apache.org/r/45876/diff/


Testing
---

make check.


Thanks,

Kapil Arya

Re: Review Request 45874: Fixed typo in subprocess.hpp.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45874/#review127608
---



Patch looks great!

Reviews applied: [45874]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 7, 2016, 3:33 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45874/
> ---
> 
> (Updated April 7, 2016, 3:33 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed typo in subprocess.hpp.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> 8a3fe5526f480187441a8aee2c72636bec3e2b2d 
> 
> Diff: https://reviews.apache.org/r/45874/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

[Tim Anderegg]

> On April 4, 2016, 6:13 p.m., Gilbert Song wrote:
> > src/cli/execute.cpp, line 287
> > 
> >
> > This is incorrect. We handle this merging operation in runtime isolator.

I was testing out a similar implementation of this feature on my own machine, 
but using AppC instead of Docker.  Since AppC has no runtime isolator in Mesos 
(yet), I think it would make sense to support merging the arguments within 
mesos-execute to enable easy testing of container images that have no runtime 
isolator, no?  Would the Docker runtime isolator properly handle the arguments 
if they came pre-merged?


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/#review126880
---


On April 3, 2016, 1:42 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1/
> ---
> 
> (Updated April 3, 2016, 1:42 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, haosdent huang, 
> and Jie Yu.
> 
> 
> Bugs: MESOS-4882
> https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 
> 
> Diff: https://reviews.apache.org/r/1/diff/
> 
> 
> Testing
> ---
> 
> 1) with docker entry point
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell
> I0403 21:35:42.949331 12369 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> 
> 2) With command 1
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd"
> I0403 21:36:55.703246 12483 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0001
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 3) With command 2
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd,/etc/passwd"
> I0403 21:37:22.901828 12548 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0002
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 4) With command 3
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="cat,/etc/passwd,/etc/passwd"
> I0403 21:39:35.986281 12651 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0003
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Review Request 45874: Fixed typo in subprocess.hpp.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45874/
---

Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description
---

Fixed typo in subprocess.hpp.


Diffs
-

  3rdparty/libprocess/include/process/subprocess.hpp 
8a3fe5526f480187441a8aee2c72636bec3e2b2d 

Diff: https://reviews.apache.org/r/45874/diff/


Testing
---


Thanks,

Joerg Schad

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

[Neil Conway]

> On March 18, 2016, 6:51 p.m., Vinod Kone wrote:
> > Looks good to me. Couple of things before this can get committed.
> > 
> > --> Have you sent an email to dev/user list about this backwards 
> > incompatible change? If not, you should.
> >  
> > --> If users are depending on the return code (need to ask on the above 
> > email) we need to do a proper deprecation warning in 0.29.0 CHANGELOG 
> > (Deprecations section) and change the behavior in 0.30.0.
> > 
> > --> If no one is depending on the return code, we might just do the change 
> > in 0.29.0. This should go into the 0.29.0 CHANGELOG though (API Changes 
> > section).
> 
> zhou xing wrote:
> Thanks for the review, we have sent a message to the community to see 
> wether anyone are using the return code. will update you the latest feedbacks 
> we collect, thx
> 
> Kevin Klues wrote:
> I Zhao, I'm curious if you got any feedback on this.  Also, did you get a 
> chance to address Neil's comments about updating the documentation? I think 
> that would need to be included as part of this work, though I'd probably 
> submit it as a separate patch that "Depends On" this one.
> 
> zhou xing wrote:
> Kevin, we haven't got any response for this issue from the community yet. 
> So I'm thinking whether we can just merge this patch in release 0.29? if so, 
> I can update the change log and submit another patch, thanks

I think making this change in 0.29 is probably reasonable, provided we include 
the appropriate notices in the release notes / changelog / update doc.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/#review124249
---


On April 7, 2016, 8:56 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44606/
> ---
> 
> (Updated April 7, 2016, 8:56 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod 
> Kone.
> 
> 
> Bugs: mesos-4580
> https://issues.apache.org/jira/browse/mesos-4580
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modify the return code of the following endpoints to 202:
> 1. /reserve
> 2. /unreserve
> 3. /create-volumes
> 4. /destroy-volumes
> 
> [#MESOS-4580]
> 
> 
> Diffs
> -
> 
>   CHANGELOG 4553465cc3dc17956f168469d405f7a453d6359e 
>   docs/endpoints/master/create-volumes.md 
> 52ae3a8159bb7d26b63f5889ce3f122371afbdc4 
>   docs/endpoints/master/destroy-volumes.md 
> a0bb1e8d1ce42ab2b96518cd4d325bfc541ad4ff 
>   docs/endpoints/master/reserve.md 1d481b56d380d45218001513330b225ca4a0a55c 
>   docs/endpoints/master/unreserve.md b9282df659ebb6090ef49ef8fc0f01411cd53103 
>   docs/persistent-volume.md ab6ed8227259384261dd5f7c2e353753f20e5c19 
>   docs/reservation.md 75357206085848826b70c2d6f2be93d20e771604 
>   docs/upgrades.md 64c6a02dd54ddf06c557b38e08916dc10e484cdd 
>   src/master/http.cpp f781fd0102c247b2e77a71f7be82b872b0831681 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 9b8ad34469c0c9a986aa60f3a52584a3a9eabb2b 
>   src/tests/reservation_endpoints_tests.cpp 
> 2e0f6c1aba95d918b8c42219ee97f79f1070d56e 
> 
> Diff: https://reviews.apache.org/r/44606/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 45670: Added tests for HTTP command executor.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45670/#review127599
---



Bad patch!

Reviews applied: [45670, 44427, 44424, 44423]

Failed command: ./support/apply-review.sh -n -r 44423

Error:
2016-04-07 14:18:54 URL:https://reviews.apache.org/r/44423/diff/raw/ 
[30696/30696] -> "44423.patch" [1]
Total errors found: 0
Checking 1 files
Error: No line in the commit message summary may exceed 72 characters.

Full log: https://builds.apache.org/job/mesos-reviewbot/12381/console

- Mesos ReviewBot


On April 7, 2016, 1:49 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45670/
> ---
> 
> (Updated April 7, 2016, 1:49 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
> https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for HTTP command executor.
> 
> 
> Diffs
> -
> 
>   src/tests/command_executor_tests.cpp 
> 970cdc39f4f2b0377d36acf2465d377d2a6e1d05 
> 
> Diff: https://reviews.apache.org/r/45670/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44424/
---

(Updated April 7, 2016, 10:13 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-3558
https://issues.apache.org/jira/browse/MESOS-3558


Repository: mesos


Description
---

Updated http_command_executor.cpp to use v1 API.


Diffs (updated)
-

  src/launcher/http_command_executor.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44424/diff/


Testing
---

make check


Thanks,

Qian Zhang

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

[Qian Zhang]

> On April 6, 2016, 11:14 p.m., Anand Mazumdar wrote:
> > Thanks for bearing with me. Most of the new comments are from the previous 
> > version itself. My bad, should have been caught by me earlier.

Thanks Anand for all the comments, you are really rigorous and all your review 
comments are very helpful!


> On April 6, 2016, 11:14 p.m., Anand Mazumdar wrote:
> > src/launcher/http_command_executor.cpp, line 1082
> > 
> >
> > Nit: s/mesos::v1::FrameworkID/FrameworkID
> > 
> > You already have a `using` declaration for this.

That `using` is in the scope of `mesos::slave` namespace, but this code is out 
of that scope.


> On April 6, 2016, 11:14 p.m., Anand Mazumdar wrote:
> > src/launcher/http_command_executor.cpp, line 1083
> > 
> >
> > Ditto

Ditto.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44424/#review127329
---


On April 5, 2016, 8:36 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44424/
> ---
> 
> (Updated April 5, 2016, 8:36 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
> https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated http_command_executor.cpp to use v1 API.
> 
> 
> Diffs
> -
> 
>   src/launcher/http_command_executor.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44424/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 45492: Used ChildHooks in Mesos [2/5].

[Joerg Schad]

> On April 5, 2016, 6:48 p.m., Joris Van Remoortere wrote:
> > src/slave/containerizer/external_containerizer.cpp, lines 1091-1092
> > 
> >
> > why not inline this?

I couldn't find a nice/readable way to inline the conditional addition of the 
second hook.


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45492/#review127177
---


On March 31, 2016, 10:21 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45492/
> ---
> 
> (Updated March 31, 2016, 10:21 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5070
> https://issues.apache.org/jira/browse/MESOS-5070
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We now use the new ChildHooks instead of explicit options such
> as setsid.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.cpp 386f2f4afa51b3a78a3f0b4711018b38c4513e7b 
>   src/health-check/main.cpp 98ea5d3675f088e3a341037dcee92695e4857999 
>   src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5 
>   src/slave/container_loggers/lib_logrotate.cpp 
> 1f228806da32832c9ca1ae4defcd1bdc154adc18 
>   src/slave/containerizer/docker.cpp c5007a311ae9c1766dd4522ccbddbdb506d4ae4e 
>   src/slave/containerizer/external_containerizer.cpp 
> cf4384cce44172a028c890f52f71ceb8ae109383 
>   src/slave/containerizer/fetcher.cpp 
> 0992112a3d0f122915a3e7636de17c992610832f 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> 1c8e231813c0579b79681c5d18b1f799a727ead7 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> 323c84a3d960a196d8ba87f753814e9d43a07957 
>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 
> dde958b252eae75563003ec15087b4231beb285a 
>   src/slave/containerizer/mesos/launcher.cpp 
> a5c8c31b72773d0bd10b9d02675a01f1d641d41c 
>   src/slave/containerizer/mesos/linux_launcher.cpp 
> 5028854fa003615f158120e030866b7ec4402b66 
>   src/tests/containerizer/launch_tests.cpp 
> 3e36f2f7ab89b98de2c1a971e4ecca58c13ad642 
>   src/tests/containerizer/ns_tests.cpp 
> cd668ebb3b9461bee00dc338c288e5df6eb8fe31 
>   src/tests/containerizer/port_mapping_tests.cpp 
> e062daa9fcfc776144b48325daa1f1284c5e59a4 
>   src/tests/slave_tests.cpp 57fc50360eae85819ae6ce714b0c3c4c1867b2b8 
> 
> Diff: https://reviews.apache.org/r/45492/diff/
> 
> 
> Testing
> ---
> 
> Tested entire chain see https://reviews.apache.org/r/45495/.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 45670: Added tests for HTTP command executor.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45670/
---

(Updated April 7, 2016, 9:49 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-3558
https://issues.apache.org/jira/browse/MESOS-3558


Repository: mesos


Description
---

Added tests for HTTP command executor.


Diffs (updated)
-

  src/tests/command_executor_tests.cpp 970cdc39f4f2b0377d36acf2465d377d2a6e1d05 

Diff: https://reviews.apache.org/r/45670/diff/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 45670: Added tests for HTTP command executor.

[Qian Zhang]

> On April 5, 2016, 3:07 a.m., Anand Mazumdar wrote:
> > hmm.. Would it be possible to not create a new file just for these two 
> > tests? IIUC, the existing tests in `src/tests/command_executor_tests.cpp` 
> > can be easily parameterized by value. The parameterization argument can be 
> > a boolean flag to the tests to enable/disable the HTTP based executor. You 
> > can look at some possible examples in `SlaveRecoveryTest`/`SchedulerTest` 
> > for possible examples.
> > 
> > In the near future, we would like to make 
> > `flags.http_command_executor=true` as the default i.e. always run our test 
> > suite with this option set to `true`. I did a quick run using your patches 
> > and there would be around ~20 tests mostly slave recovery tests that would 
> > need their expectations modified. We can do that as part of a follow up 
> > JIRA later and not worry about them for now.

Agree! Let me update the existing tests in 
`src/tests/command_executor_tests.cpp` by parameterizing it.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45670/#review126904
---


On April 4, 2016, 5:12 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45670/
> ---
> 
> (Updated April 4, 2016, 5:12 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
> https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for HTTP command executor.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
>   src/tests/http_command_executor_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45670/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45022/#review127583
---



Bad patch!

Reviews applied: [45022, 45015, 45009, 44084, 44978, 44082, 44081, 44808]

Failed command: ./support/apply-review.sh -n -r 44082

Error:
2016-04-07 11:54:30 URL:https://reviews.apache.org/r/44082/diff/raw/ 
[3757/3757] -> "44082.patch" [1]
error: patch failed: 
3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp:99
error: 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp: patch 
does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/12379/console

- Mesos ReviewBot


On April 7, 2016, 11:08 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45022/
> ---
> 
> (Updated April 7, 2016, 11:08 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4415
> https://issues.apache.org/jira/browse/MESOS-4415
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We currently depend on arcane "POSIX-like" Windows APIs like `::remove`.
> This API is incompatible with NT paths -- which we will eventually have
> to transition to for the Windows integration -- and has no documented
> behavior interacting with subsystems like the driver subsystem, which is
> required for symlinks.
> 
> This commit will move us to proper core Windows API equivalents for
> `::remove`.
> 
> Review: https://reviews.apache.org/r/45022
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 7bd4bfbc2ec5922879dcefddc12137336b11be52 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rm.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rm.hpp 
> 52568b303c03fd57b81f6cc67782444ce734dd41 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rm.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
> 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 
> 
> Diff: https://reviews.apache.org/r/45022/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 45863: Updated error messages in weights handler.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45863/#review127581
---



Bad patch!

Reviews applied: [45863]

Failed command: ./support/apply-review.sh -n -r 45863

Error:
2016-04-07 11:28:15 URL:https://reviews.apache.org/r/45863/diff/raw/ 
[2452/2452] -> "45863.patch" [1]
Total errors found: 0
Checking 1 files
Error: No line in the commit message summary may exceed 72 characters.

Full log: https://builds.apache.org/job/mesos-reviewbot/12378/console

- Mesos ReviewBot


On April 7, 2016, 10:50 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45863/
> ---
> 
> (Updated April 7, 2016, 10:50 a.m.)
> 
> 
> Review request for mesos, Yongqiao Wang and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> While writing log or error messages we adhere the following style:
>   * No period at the end (there are exceptions though, e.g., one is
> when constructing request responses.
>   * When splitting a string over multiple lines, put a space at the
> beginning of the following line in contrast to the end of the
> previous line.
> 
> 
> Diffs
> -
> 
>   src/master/weights_handler.cpp e88bf2ab67ccadf35879b92f3280298a43d7cd0e 
> 
> Diff: https://reviews.apache.org/r/45863/diff/
> 
> 
> Testing
> ---
> 
> On Mac OS 10.10.4: 
> `make check`
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45022/
---

(Updated April 7, 2016, 11:08 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-4415
https://issues.apache.org/jira/browse/MESOS-4415


Repository: mesos


Description
---

We currently depend on arcane "POSIX-like" Windows APIs like `::remove`.
This API is incompatible with NT paths -- which we will eventually have
to transition to for the Windows integration -- and has no documented
behavior interacting with subsystems like the driver subsystem, which is
required for symlinks.

This commit will move us to proper core Windows API equivalents for
`::remove`.

Review: https://reviews.apache.org/r/45022


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
7bd4bfbc2ec5922879dcefddc12137336b11be52 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rm.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/rm.hpp 
52568b303c03fd57b81f6cc67782444ce734dd41 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rm.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 

Diff: https://reviews.apache.org/r/45022/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 45863: Updated error messages in weights handler.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45863/#review127580
---


Fix it, then Ship it!





src/master/weights_handler.cpp (line 90)


Not yours: Above the request.body is included in the output. Feels 
inconsistent here...



src/master/weights_handler.cpp (line 94)


Could you add a similar comment as in quota_handler (// Check that the role 
is on the role whitelist, if it exists.). IMO for isWhitelistedRole it is not  
obvious from the name that it will be true if there is no whitelist.



src/master/weights_handler.cpp (line 97)


Not yours, still: This feels a little off as it must only exist in the 
whitelist if there is a whitelist specified.


- Joerg Schad


On April 7, 2016, 10:50 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45863/
> ---
> 
> (Updated April 7, 2016, 10:50 a.m.)
> 
> 
> Review request for mesos, Yongqiao Wang and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> While writing log or error messages we adhere the following style:
>   * No period at the end (there are exceptions though, e.g., one is
> when constructing request responses.
>   * When splitting a string over multiple lines, put a space at the
> beginning of the following line in contrast to the end of the
> previous line.
> 
> 
> Diffs
> -
> 
>   src/master/weights_handler.cpp e88bf2ab67ccadf35879b92f3280298a43d7cd0e 
> 
> Diff: https://reviews.apache.org/r/45863/diff/
> 
> 
> Testing
> ---
> 
> On Mac OS 10.10.4: 
> `make check`
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45022/
---

(Updated April 7, 2016, 11:02 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-4415
https://issues.apache.org/jira/browse/MESOS-4415


Repository: mesos


Description
---

We currently depend on arcane "POSIX-like" Windows APIs like `::remove`.
This API is incompatible with NT paths -- which we will eventually have
to transition to for the Windows integration -- and has no documented
behavior interacting with subsystems like the driver subsystem, which is
required for symlinks.

This commit will move us to proper core Windows API equivalents for
`::remove`.

Review: https://reviews.apache.org/r/45022


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
7bd4bfbc2ec5922879dcefddc12137336b11be52 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rm.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/rm.hpp 
52568b303c03fd57b81f6cc67782444ce734dd41 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rm.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 

Diff: https://reviews.apache.org/r/45022/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

[Alex Clemmer]

> On March 22, 2016, 8:35 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rm.hpp, lines 
> > 41-43
> > 
> >
> > `RemoveDirectory` only works on empty directories, right? This seems to 
> > be consistent with `rmdir`. Is this not true? Could you explain what the 
> > inconsistency is?

Hmm, inconsistent? It looks like the comment is saying that `rmdir` and 
`RemoveDirectory` are consistent? Is the inconsistency elsewhere in another 
comment?


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45022/#review124879
---


On March 18, 2016, 7:39 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45022/
> ---
> 
> (Updated March 18, 2016, 7:39 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4415
> https://issues.apache.org/jira/browse/MESOS-4415
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We currently depend on arcane "POSIX-like" Windows APIs like `::remove`.
> This API is incompatible with NT paths -- which we will eventually have
> to transition to for the Windows integration -- and has no documented
> behavior interacting with subsystems like the driver subsystem, which is
> required for symlinks.
> 
> This commit will move us to proper core Windows API equivalents for
> `::remove`.
> 
> Review: https://reviews.apache.org/r/45022
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 7bd4bfbc2ec5922879dcefddc12137336b11be52 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rm.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rm.hpp 
> 52568b303c03fd57b81f6cc67782444ce734dd41 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rm.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
> 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 
> 
> Diff: https://reviews.apache.org/r/45022/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

[Alex Clemmer]

> On March 22, 2016, 8:30 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp, line 200
> > 
> >
> > Why do we need this? I would much prefer to remove this.

What would you like to see instead? This is how the tests were initially 
concieved before they moved here, IIRC. I'm happy to change it, as I didn't set 
out to do this myself.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45022/#review124867
---


On March 18, 2016, 7:39 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45022/
> ---
> 
> (Updated March 18, 2016, 7:39 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4415
> https://issues.apache.org/jira/browse/MESOS-4415
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We currently depend on arcane "POSIX-like" Windows APIs like `::remove`.
> This API is incompatible with NT paths -- which we will eventually have
> to transition to for the Windows integration -- and has no documented
> behavior interacting with subsystems like the driver subsystem, which is
> required for symlinks.
> 
> This commit will move us to proper core Windows API equivalents for
> `::remove`.
> 
> Review: https://reviews.apache.org/r/45022
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 7bd4bfbc2ec5922879dcefddc12137336b11be52 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rm.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rm.hpp 
> 52568b303c03fd57b81f6cc67782444ce734dd41 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rm.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
> 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 
> 
> Diff: https://reviews.apache.org/r/45022/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Review Request 45863: Updated error messages in weights handler.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45863/
---

Review request for mesos, Yongqiao Wang and Joerg Schad.


Repository: mesos


Description
---

While writing log or error messages we adhere the following style:
  * No period at the end (there are exceptions though, e.g., one is
when constructing request responses.
  * When splitting a string over multiple lines, put a space at the
beginning of the following line in contrast to the end of the
previous line.


Diffs
-

  src/master/weights_handler.cpp e88bf2ab67ccadf35879b92f3280298a43d7cd0e 

Diff: https://reviews.apache.org/r/45863/diff/


Testing
---

On Mac OS 10.10.4: 
`make check`


Thanks,

Alexander Rukletsov

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/#review127578
---



Patch looks great!

Reviews applied: [42705, 44606]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 7, 2016, 8:56 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44606/
> ---
> 
> (Updated April 7, 2016, 8:56 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod 
> Kone.
> 
> 
> Bugs: mesos-4580
> https://issues.apache.org/jira/browse/mesos-4580
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modify the return code of the following endpoints to 202:
> 1. /reserve
> 2. /unreserve
> 3. /create-volumes
> 4. /destroy-volumes
> 
> [#MESOS-4580]
> 
> 
> Diffs
> -
> 
>   CHANGELOG 4553465cc3dc17956f168469d405f7a453d6359e 
>   docs/endpoints/master/create-volumes.md 
> 52ae3a8159bb7d26b63f5889ce3f122371afbdc4 
>   docs/endpoints/master/destroy-volumes.md 
> a0bb1e8d1ce42ab2b96518cd4d325bfc541ad4ff 
>   docs/endpoints/master/reserve.md 1d481b56d380d45218001513330b225ca4a0a55c 
>   docs/endpoints/master/unreserve.md b9282df659ebb6090ef49ef8fc0f01411cd53103 
>   docs/persistent-volume.md ab6ed8227259384261dd5f7c2e353753f20e5c19 
>   docs/reservation.md 75357206085848826b70c2d6f2be93d20e771604 
>   docs/upgrades.md 64c6a02dd54ddf06c557b38e08916dc10e484cdd 
>   src/master/http.cpp f781fd0102c247b2e77a71f7be82b872b0831681 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 9b8ad34469c0c9a986aa60f3a52584a3a9eabb2b 
>   src/tests/reservation_endpoints_tests.cpp 
> 2e0f6c1aba95d918b8c42219ee97f79f1070d56e 
> 
> Diff: https://reviews.apache.org/r/44606/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 45350: Add `--cgroups_subsystems` in agent flags.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45350/
---

(Updated April 7, 2016, 10:40 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, Kevin 
Klues, and Neil Conway.


Changes
---

Address @neilc's comment.


Bugs: MESOS-5040
https://issues.apache.org/jira/browse/MESOS-5040


Repository: mesos


Description
---

Add `--cgroups_subsystems` in agent flags.


Diffs (updated)
-

  docs/configuration.md 309a5a05eab386c8943ba6bdee8d5efeb448aa0c 
  src/slave/flags.hpp 4236b7fe40b9aa26d57b651be06a0e36037f65c6 
  src/slave/flags.cpp 7164afef9c82a9bba0f137d7387c3569912b6599 

Diff: https://reviews.apache.org/r/45350/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45473: Migrate test cases for `net_cls` subsystem to cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45473/
---

(Updated April 7, 2016, 10:37 a.m.)


Review request for mesos, Avinash sridharan, Gilbert Song, Guangya Liu, Ian 
Downes, Jie Yu, and Kevin Klues.


Changes
---

Rebase.


Bugs: MESOS-5046
https://issues.apache.org/jira/browse/MESOS-5046


Repository: mesos


Description
---

Migrate test cases for `net_cls` subsystem to cgroups unified isolator.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
c4e467c8227f9e4129b05d173812592f39a04e06 

Diff: https://reviews.apache.org/r/45473/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45362: Add `cgroups::memory::pressure::Counter::snapshot` method.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45362/
---

(Updated April 7, 2016, 10:37 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Rebase.


Bugs: MESOS-5045
https://issues.apache.org/jira/browse/MESOS-5045


Repository: mesos


Description
---

Add `cgroups::memory::pressure::Counter::snapshot` method.


Diffs (updated)
-

  src/linux/cgroups.hpp 5f4010734ed9e3295dcc3a4390123e4f4ce99c16 
  src/linux/cgroups.cpp b7420c682970c4838e84973198ac4fe7af5f68f9 

Diff: https://reviews.apache.org/r/45362/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45086: Enable cgroups unified isolator in isolation.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45086/
---

(Updated April 7, 2016, 10:38 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Alex Clemmer, Ian Downes, 
Jie Yu, and Kevin Klues.


Changes
---

Rebase.


Bugs: MESOS-5041
https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
---

Enable cgroups unified isolator in isolation.


Diffs (updated)
-

  src/CMakeLists.txt 9a4cffa952a452d5df70ea42949142e534067cd6 
  src/Makefile.am 71c4308cccfa5c56b93f6c3928dd2a1cf3ba9741 
  src/slave/containerizer/mesos/containerizer.cpp 
a5dd22380066aa85de04d485052084e2629681c0 

Diff: https://reviews.apache.org/r/45086/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45364: Migrate test cases for `memory` subsystem to cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45364/
---

(Updated April 7, 2016, 10:37 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Rebase.


Bugs: MESOS-5045
https://issues.apache.org/jira/browse/MESOS-5045


Repository: mesos


Description
---

Migrate test cases for `memory` subsystem to cgroups unified isolator.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
c4e467c8227f9e4129b05d173812592f39a04e06 

Diff: https://reviews.apache.org/r/45364/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45354: Migrate `UserCgroupIsolatorTest` to cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45354/
---

(Updated April 7, 2016, 10:37 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Rebase.


Bugs: MESOS-5043
https://issues.apache.org/jira/browse/MESOS-5043


Repository: mesos


Description
---

Migrate `UserCgroupIsolatorTest` to cgroups unified isolator.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
c4e467c8227f9e4129b05d173812592f39a04e06 

Diff: https://reviews.apache.org/r/45354/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45353: Migrate test cases for `cpuacct` subsystem to cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45353/
---

(Updated April 7, 2016, 10:37 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Rebase.


Bugs: MESOS-5043
https://issues.apache.org/jira/browse/MESOS-5043


Repository: mesos


Description
---

Migrate test cases for `cpuacct` subsystem to cgroups unified isolator.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
c4e467c8227f9e4129b05d173812592f39a04e06 

Diff: https://reviews.apache.org/r/45353/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43283/
---

(Updated April 7, 2016, 10:37 a.m.)


Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.


Changes
---

Rebase.


Bugs: MESOS-4655
https://issues.apache.org/jira/browse/MESOS-4655


Repository: mesos


Description
---

Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.


Diffs (updated)
-

  src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5 

Diff: https://reviews.apache.org/r/43283/diff/


Testing
---

This also fix similar error in 
`CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.

# Note: This patch would discarded eventually.


Thanks,

haosdent huang

Re: Review Request 45085: Add cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45085/
---

(Updated April 7, 2016, 10:37 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Added ANY mode to futures collect mechanism.


Bugs: MESOS-5041
https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
---

Add cgroups unified isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45085/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45472: Add `NetClsSubsystem` for cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45472/
---

(Updated April 7, 2016, 10:37 a.m.)


Review request for mesos, Avinash sridharan, Gilbert Song, Guangya Liu, Ian 
Downes, Jie Yu, and Kevin Klues.


Changes
---

Rebase.


Bugs: MESOS-5046
https://issues.apache.org/jira/browse/MESOS-5046


Repository: mesos


Description
---

Add `NetClsSubsystem` for cgroups unified isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45472/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45363/
---

(Updated April 7, 2016, 10:37 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Rebase.


Bugs: MESOS-5045
https://issues.apache.org/jira/browse/MESOS-5045


Repository: mesos


Description
---

Add `MemorySubsystem` for cgroups unified isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45363/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45087: Add `CpuSubsystem` for cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45087/
---

(Updated April 7, 2016, 10:37 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Rebase.


Bugs: MESOS-5042
https://issues.apache.org/jira/browse/MESOS-5042


Repository: mesos


Description
---

Add `CpuSubsystem` for cgroups unified isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45087/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45351: Migrate test cases for `cpu` subsystem to cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45351/
---

(Updated April 7, 2016, 10:37 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Rebase.


Bugs: MESOS-5042
https://issues.apache.org/jira/browse/MESOS-5042


Repository: mesos


Description
---

Migrate test cases for `cpu` subsystem to cgroups unified isolator.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
c4e467c8227f9e4129b05d173812592f39a04e06 

Diff: https://reviews.apache.org/r/45351/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45352: Add `CpuacctSubsystem` for cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45352/
---

(Updated April 7, 2016, 10:37 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Rebase.


Bugs: MESOS-5043
https://issues.apache.org/jira/browse/MESOS-5043


Repository: mesos


Description
---

Add `CpuacctSubsystem` for cgroups unified isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45352/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45083: Added ANY mode to futures collect mechanism.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45083/
---

(Updated April 7, 2016, 10:36 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and 
Kevin Klues.


Changes
---

Added ANY mode to futures collect mechanism.


Summary (updated)
-

Added ANY mode to futures collect mechanism.


Bugs: MESOS-5038
https://issues.apache.org/jira/browse/MESOS-5038


Repository: mesos


Description (updated)
---

Added ANY mode to futures collect mechanism.


Diffs (updated)
-

  3rdparty/libprocess/include/process/collect.hpp 
5a92b72eb7668494dc832ec446a41b3d673a20cc 
  3rdparty/libprocess/src/tests/collect_tests.cpp 
155e0bb75cf723a0a6c29020f9f767e3ba3d7401 

Diff: https://reviews.apache.org/r/45083/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 44084: Windows: Forked os::rename().

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44084/
---

(Updated April 7, 2016, 10:15 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Windows: Forked os::rename().


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
7bd4bfbc2ec5922879dcefddc12137336b11be52 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rename.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/rename.hpp 
7b2215208bcaa5613426d8ede9cab21d1a084631 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rename.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 

Diff: https://reviews.apache.org/r/44084/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 44978: Windows: Fixed `fs::list` to be more compliant with POSIX version.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44978/
---

(Updated April 7, 2016, 9:36 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Windows: Fixed `fs::list` to be more compliant with POSIX version.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/windows/fs.hpp 
7dace7d579c1b18afcf2278f9689b205cf57877f 
  3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 

Diff: https://reviews.apache.org/r/44978/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 45861: Windows: Fixed non-blocking connect.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45861/#review127575
---



Patch looks great!

Reviews applied: [45861]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 7, 2016, 8:08 a.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45861/
> ---
> 
> (Updated April 7, 2016, 8:08 a.m.)
> 
> 
> Review request for mesos, Alex Clemmer and switched to 'mcypark'.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Fixed non-blocking connect.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/poll_socket.cpp 
> cb2878565a112017b190b4ff83dc65a876ea45f9 
> 
> Diff: https://reviews.apache.org/r/45861/diff/
> 
> 
> Testing
> ---
> 
> OSX: make check -j8
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 44082: Stout: Un-commented out functions and marked them as deleted instead.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44082/
---

(Updated April 7, 2016, 9:12 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Stout: Un-commented out functions and marked them as deleted instead.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
6a391ff198ab724f689bcef79d4e2e05a786cbc2 

Diff: https://reviews.apache.org/r/44082/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 44081: Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44081/
---

(Updated April 7, 2016, 9:11 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
9ee233b988c08d953e70345c55bcdd5c2f7c101b 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
6a391ff198ab724f689bcef79d4e2e05a786cbc2 

Diff: https://reviews.apache.org/r/44081/diff/


Testing
---


Thanks,

Alex Clemmer