Re: Review Request 46249: Hook and module process operation before main process initialize.

[Andy Pang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46249/
---

(Updated 四月 18, 2016, 5:41 a.m.)


Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.


Summary (updated)
-

Hook and module process operation before main process initialize.


Repository: mesos


Description
---

If we in hook/module manager use libprocess library, it will auto use process 
initialize fucntion, as the process::initialize will only call once,then in the 
main fucnton process initialize  process::initialize("master") will not be 
called. So the HTTP request process "delegate" will be wrong, http request will 
not be response.


Diffs
-

  src/master/main.cpp ea7f0fc 

Diff: https://reviews.apache.org/r/46249/diff/


Testing
---

make check


Thanks,

Andy Pang

Re: Review Request 44379: Use tokens size to parse perf stat format.

[fan du]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44379/
---

(Updated 四月 18, 2016, 5:41 a.m.)


Review request for mesos and Ben Mahler.


Changes
---

Elaborate more about the commets


Bugs: MESOS-4705
https://issues.apache.org/jira/browse/MESOS-4705


Repository: mesos


Description (updated)
---

Co-authored with haosdent.


Diffs (updated)
-

  src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5 

Diff: https://reviews.apache.org/r/44379/diff/


Testing
---

1. {Found and Test} with Serenity, ema filter could get perf event statistics 
correctly as expected.
2. ./bin/mesos-tests.sh --gtest_filter=PerfEventIsolatorTest* 
--log_dir=/tmp/mesos/


Thanks,

fan du

Re: Review Request 44379: Use tokens size to parse perf stat format.

[fan du]

> On 四月 11, 2016, 2:09 p.m., Klaus Ma wrote:
> > Ship It!
> 
> Klaus Ma wrote:
> LGTM. Just wonder how to handle the input that did not follow our 
> expectation:
> 
> // value,event,cgroup
> // value,unit,event,cgroup
> // value,unit,event,cgroup,running,ratio

Any format other than above is invalid :)


- fan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44379/#review128117
---


On 四月 11, 2016, 7:01 a.m., fan du wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44379/
> ---
> 
> (Updated 四月 11, 2016, 7:01 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4705
> https://issues.apache.org/jira/browse/MESOS-4705
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Use tokens size to parse perf stat format.
> 
> Co-authored with haosdent.
> 
> 
> Diffs
> -
> 
>   src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5 
> 
> Diff: https://reviews.apache.org/r/44379/diff/
> 
> 
> Testing
> ---
> 
> 1. {Found and Test} with Serenity, ema filter could get perf event statistics 
> correctly as expected.
> 2. ./bin/mesos-tests.sh --gtest_filter=PerfEventIsolatorTest* 
> --log_dir=/tmp/mesos/
> 
> 
> Thanks,
> 
> fan du
> 
>

Re: Review Request 36816: Supported HTTP in Mesos health check program.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36816/#review129287
---




src/docker/executor.cpp (line 385)


What's the intention behind this change? Just refactoring?



src/health-check/main.cpp (line 250)


How about 'Http check requires at least one expected status'

Also remove the period in the end


- Timothy Chen


On April 17, 2016, 9:14 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36816/
> ---
> 
> (Updated April 17, 2016, 9:14 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Michael Park, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-2533
> https://issues.apache.org/jira/browse/MESOS-2533
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Supported HTTP in Mesos health check program.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 87af4a06db8cc3889fe4d3b314206103f5ce5f2d 
>   include/mesos/v1/mesos.proto 34da0a1484dc2f71262d8b97484b8edaae35bb6c 
>   src/docker/executor.cpp 579905f6c2ece7db9c853abf481541fdbc3116b7 
>   src/health-check/main.cpp 98ea5d3675f088e3a341037dcee92695e4857999 
>   src/tests/health_check_tests.cpp 1c4a554ab07731963a4a38e3ae40b0323bf317bb 
> 
> Diff: https://reviews.apache.org/r/36816/diff/
> 
> 
> Testing
> ---
> 
> * Add unit test cases: HealthCheckTest.HealthyTaskThroughHttp and 
> HealthCheckTest.HealthyTaskNotMatchHttpStatuses
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 36816: Supported HTTP in Mesos health check program.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36816/#review129286
---




include/mesos/mesos.proto (line 312)


What other schemes are we looking to support besides http or not? What is 
the intention of making it a string instead of bool as before?


- Timothy Chen


On April 17, 2016, 9:14 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36816/
> ---
> 
> (Updated April 17, 2016, 9:14 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Michael Park, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-2533
> https://issues.apache.org/jira/browse/MESOS-2533
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Supported HTTP in Mesos health check program.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 87af4a06db8cc3889fe4d3b314206103f5ce5f2d 
>   include/mesos/v1/mesos.proto 34da0a1484dc2f71262d8b97484b8edaae35bb6c 
>   src/docker/executor.cpp 579905f6c2ece7db9c853abf481541fdbc3116b7 
>   src/health-check/main.cpp 98ea5d3675f088e3a341037dcee92695e4857999 
>   src/tests/health_check_tests.cpp 1c4a554ab07731963a4a38e3ae40b0323bf317bb 
> 
> Diff: https://reviews.apache.org/r/36816/diff/
> 
> 
> Testing
> ---
> 
> * Add unit test cases: HealthCheckTest.HealthyTaskThroughHttp and 
> HealthCheckTest.HealthyTaskNotMatchHttpStatuses
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 46075: Update docs to reflect /containers endpoint.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46075/#review129284
---



Patch looks great!

Reviews applied: [45014, 46075]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 18, 2016, 3:39 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46075/
> ---
> 
> (Updated April 18, 2016, 3:39 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Docs are updated using support/generate-endpoint-help.py.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/index.md 4fc5583e27dda6df6dfc9f3cee72925a07cdd2b3 
>   docs/endpoints/monitor/statistics.json.md 
> 1830493d9b936279abcfc03fc5023b7e8b54888b 
>   docs/endpoints/monitor/statistics.md 
> 38dede06ac0a7cc9798a50ffd540b124eb5c1c84 
>   docs/endpoints/slave/containers.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46075/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 46075: Update docs to reflect /containers endpoint.

[Jay Guo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46075/
---

(Updated April 18, 2016, 3:39 a.m.)


Review request for mesos and Jie Yu.


Repository: mesos


Description
---

Docs are updated using support/generate-endpoint-help.py.


Diffs (updated)
-

  docs/endpoints/index.md 4fc5583e27dda6df6dfc9f3cee72925a07cdd2b3 
  docs/endpoints/monitor/statistics.json.md 
1830493d9b936279abcfc03fc5023b7e8b54888b 
  docs/endpoints/monitor/statistics.md 38dede06ac0a7cc9798a50ffd540b124eb5c1c84 
  docs/endpoints/slave/containers.md PRE-CREATION 

Diff: https://reviews.apache.org/r/46075/diff/


Testing
---


Thanks,

Jay Guo

Re: Review Request 45014: Add /containers endpoint.

[Jay Guo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45014/
---

(Updated April 18, 2016, 3:38 a.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4891
https://issues.apache.org/jira/browse/MESOS-4891


Repository: mesos


Description
---

It returns both resource statistics and container status.


Diffs (updated)
-

  src/slave/http.cpp 3f96f2c201597706dfc814c0a20bb983cd56905a 
  src/slave/slave.hpp f78c1b4e4d5378ef7223c6eb3ea45491c30fb4c1 
  src/slave/slave.cpp de99e9eb5cc812b2e07deb749b98b4f4db363728 
  src/tests/containerizer.hpp efc1ca87c00b04d70efd1e3f6acf4e763132d6b0 
  src/tests/containerizer.cpp 4c7f5a26d38222daf013bd3ca9a133e12d7bf338 
  src/tests/slave_tests.cpp ee58488b0b927c7c5833add4718941539663e6d2 

Diff: https://reviews.apache.org/r/45014/diff/


Testing
---

make check


Thanks,

Jay Guo

Re: Review Request 46249: hook/module process operation before main process initialize.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46249/#review129281
---



Bad patch!

Reviews applied: [46249]

Failed command: ./support/apply-review.sh -n -r 46249

Error:
2016-04-18 03:06:22 URL:https://reviews.apache.org/r/46249/diff/raw/ 
[1834/1834] -> "46249.patch" [1]
Total errors found: 0
Checking 1 files
Error: No line in the commit message summary may exceed 72 characters.

Full log: https://builds.apache.org/job/mesos-reviewbot/12581/console

- Mesos ReviewBot


On April 18, 2016, 2:44 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46249/
> ---
> 
> (Updated April 18, 2016, 2:44 a.m.)
> 
> 
> Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If we in hook/module manager use libprocess library, it will auto use process 
> initialize fucntion, as the process::initialize will only call once,then in 
> the main fucnton process initialize  process::initialize("master") will not 
> be called. So the HTTP request process "delegate" will be wrong, http request 
> will not be response.
> 
> 
> Diffs
> -
> 
>   src/master/main.cpp ea7f0fc 
> 
> Diff: https://reviews.apache.org/r/46249/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>

Re: Review Request 46249: hook/module process operation before main process initialize.

[Andy Pang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46249/
---

(Updated 四月 18, 2016, 2:44 a.m.)


Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.


Repository: mesos


Description
---

If we in hook/module manager use libprocess library, it will auto use process 
initialize fucntion, as the process::initialize will only call once,then in the 
main fucnton process initialize  process::initialize("master") will not be 
called. So the HTTP request process "delegate" will be wrong, http request will 
not be response.


Diffs (updated)
-

  src/master/main.cpp ea7f0fc 

Diff: https://reviews.apache.org/r/46249/diff/


Testing
---

make check


Thanks,

Andy Pang

Re: Review Request 46190: Slave rename - Update standard output messages in libprocess.

[zhou xing]

> On 四月 18, 2016, 12:59 a.m., Vinod Kone wrote:
> > Ship It!
> 
> Vinod Kone wrote:
> Can you rebase?

Hi Vinod, has rebased the code, please take a look, thanks


- zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46190/#review129276
---


On 四月 18, 2016, 2:31 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46190/
> ---
> 
> (Updated 四月 18, 2016, 2:31 a.m.)
> 
> 
> Review request for mesos, Kevin Klues and Vinod Kone.
> 
> 
> Bugs: MESOS-5057
> https://issues.apache.org/jira/browse/MESOS-5057
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> [#MESOS-5057]
> Rename 'slave' to 'agent' in the standard output messages of
> libprocess
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/test-master.cpp 
> 03f2f83613674b3b9edfe76b76adb9b2513c1f06 
>   3rdparty/libprocess/src/test-slave.cpp 
> 9797792d79448dc8e9ed31ef689fa9655250c1c4 
> 
> Diff: https://reviews.apache.org/r/46190/diff/
> 
> 
> Testing
> ---
> 
> Perform the following regular expression on 'mesos/3rdparty' folder to find 
> out all the message strings(in Eclipse IDE):
> ```
> ^[^#include].*".*slave.*"
> ```
> then filter out the lines that using term 'slave' as the field name or 
> attribute name
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 46190: Slave rename - Update standard output messages in libprocess.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46190/
---

(Updated 四月 18, 2016, 2:31 a.m.)


Review request for mesos, Kevin Klues and Vinod Kone.


Changes
---

rebased the code


Bugs: MESOS-5057
https://issues.apache.org/jira/browse/MESOS-5057


Repository: mesos


Description
---

[#MESOS-5057]
Rename 'slave' to 'agent' in the standard output messages of
libprocess


Diffs (updated)
-

  3rdparty/libprocess/src/test-master.cpp 
03f2f83613674b3b9edfe76b76adb9b2513c1f06 
  3rdparty/libprocess/src/test-slave.cpp 
9797792d79448dc8e9ed31ef689fa9655250c1c4 

Diff: https://reviews.apache.org/r/46190/diff/


Testing
---

Perform the following regular expression on 'mesos/3rdparty' folder to find out 
all the message strings(in Eclipse IDE):
```
^[^#include].*".*slave.*"
```
then filter out the lines that using term 'slave' as the field name or 
attribute name

make
make check


Thanks,

zhou xing

Re: Review Request 46189: Slave rename - Update strings in error messages and other strings.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46189/
---

(Updated 四月 18, 2016, 2:31 a.m.)


Review request for mesos, Kevin Klues and Vinod Kone.


Changes
---

rebased the code


Bugs: MESOS-5057
https://issues.apache.org/jira/browse/MESOS-5057


Repository: mesos


Description
---

[#MESOS-5057]
This patch renames 'slave' to 'agent' in the following strings:
1. Error/Warning messages
2. Flag help/description messages
3. Test case messages
4. Other standard output messages


Diffs (updated)
-

  CHANGELOG 915c592b34e080b8227bf4c829db08cd7e497305 
  src/common/resources_utils.cpp 70e6f025d89383084ab8b2cda23ab1cd55d959b2 
  src/examples/dynamic_reservation_framework.cpp 
8f00bcf50c25cf46c3dc32e3e77370b39fbd46bc 
  src/hook/manager.cpp 692b9ea862442f3bac58da678425f03e4b00a79d 
  src/internal/devolve.cpp 0f58dc151c3de5a25d0ca73030a8222cac0f43c1 
  src/local/flags.hpp b3cd811c78bb7b57d82d755e36a89269d8173c2d 
  src/logging/flags.cpp 446eb921443481f4025132653e0bfa8ab42aa240 
  src/master/flags.cpp 989bc980e3e8ebe1f7ebc471ed44df5ddb65510f 
  src/master/http.cpp d83ccd394c688803369034e22de79b40277a3a7c 
  src/master/master.hpp 2dd0971a484cef0360237ff9e5e80cc10db9e20e 
  src/master/master.cpp 210934b6cda1c62cd478de9f39b1561f231406f0 
  src/master/validation.cpp 2b91446edeb1c0afda4ffcb4d140178cdde44862 
  src/python/executor/src/mesos/executor/mesos_executor_driver_impl.cpp 
843771ae5b4f7e283d85c093e63c235dc753397d 
  src/python/scheduler/src/mesos/scheduler/mesos_scheduler_driver_impl.cpp 
78dc298ec19a61cd491b2b43b463db67528c5526 
  src/scaling/scaling_sched.py d1008c79b1f1302d9ff6ae6dc9e1d9d0b7379773 
  src/sched/sched.cpp 5f6f5518f0858c680dc0dffc933c0bb03bba6991 
  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
4f3f210b8d0ab9a453ab56c5e23024e2ab7c4259 
  src/slave/flags.cpp 316feec26e52a8cb1f0fd0739176b3f502e1ed86 
  src/slave/http.cpp 3f96f2c201597706dfc814c0a20bb983cd56905a 
  src/slave/main.cpp 70df4f384b09a1fb078cd893efe52a5e3b116f48 
  src/slave/slave.cpp de99e9eb5cc812b2e07deb749b98b4f4db363728 
  src/slave/state.cpp e7b44c78500e07f0f1655f41a6a977adae2ca0c0 
  src/tests/cluster.cpp b4d69106388892b88f7de20b248cac8b950b861c 
  src/tests/containerizer/docker_containerizer_tests.cpp 
7accd32fba5eed196a82b1a171cb16d37b9e0539 
  src/tests/containerizer/filesystem_isolator_tests.cpp 
51e60c2e8c6c8b76b51de0e7761ecbb0ca9c3304 
  src/tests/flags.hpp af15360491b5433dcfbda03a72407667eb3977d1 
  src/tests/hierarchical_allocator_tests.cpp 
8ed0df45fc745d338482d1944a346cd40c18bb37 
  src/tests/master_allocator_tests.cpp 17607df7d488c8dd42c57504a5ca326697f57ffa 
  src/tests/master_tests.cpp cdd69b61349185e74d90e6b50e31d16ad8c0eabf 
  src/tests/paths_tests.cpp 81498e368cbb77e2cb8af71d8570dc690d3d0dfc 
  src/tests/slave_recovery_tests.cpp 79132344be3bcd2bda54357cd5e7e0c59a766fd8 
  src/tests/sorter_tests.cpp 0f3266f1222163c4d03eb4c4ca88f96836de601e 

Diff: https://reviews.apache.org/r/46189/diff/


Testing
---

Perform the following regular expression on 'mesos/src' and 'mesos/support' 
folder to find out all the message strings(in Eclipse IDE):
```
^[^#include].*".*slave.*"
```
then filter out the lines that using term 'slave' as the field name or 
attribute name

make
make check


Thanks,

zhou xing

Re: Review Request 46249: hook/module process operation before main process initialize.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46249/#review129278
---




src/master/main.cpp (lines 195 - 196)


Move this back to where it was. This needs to be called after 
`LIBPROCESS_*` environment variables are set.

Instead move the ModuleManager and HookManager initialization after 
`logging::initialize()`.


- Vinod Kone


On April 15, 2016, 8:09 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46249/
> ---
> 
> (Updated April 15, 2016, 8:09 a.m.)
> 
> 
> Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If we in hook/module manager use libprocess library, it will auto use process 
> initialize fucntion, as the process::initialize will only call once,then in 
> the main fucnton process initialize  process::initialize("master") will not 
> be called. So the HTTP request process "delegate" will be wrong, http request 
> will not be response.
> 
> 
> Diffs
> -
> 
>   src/master/main.cpp ea7f0fc 
> 
> Diff: https://reviews.apache.org/r/46249/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46307/#review129272
---



Patch looks great!

Reviews applied: [46307]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 17, 2016, 5:15 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46307/
> ---
> 
> (Updated April 17, 2016, 5:15 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Greg Mann, Neil 
> Conway, and Timothy Chen.
> 
> 
> Bugs: MESOS-1802
> https://issues.apache.org/jira/browse/MESOS-1802
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We need to ignore subsequent status updates in HealthStatusChange
> tests. In our test cases, we set `consecutive_failures` to 3 in
> HealthCheck message definition. But the counter for
> `consecutiveFailures` in `mesos-health-check` would be reset to 0
> after a success check. It is possible to continue to receive status
> updates before we stop the driver.
> 
> 
> Diffs
> -
> 
>   src/tests/health_check_tests.cpp 1c4a554ab07731963a4a38e3ae40b0323bf317bb 
> 
> Diff: https://reviews.apache.org/r/46307/diff/
> 
> 
> Testing
> ---
> 
> # I still could not reproduce the problem in old code after repeatedly tests. 
> So seems no way to verify whether my assumption is correct or not.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 46191: Stout: Implemented `uname` on Windows.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46191/
---

(Updated April 17, 2016, 10:46 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-4470
https://issues.apache.org/jira/browse/MESOS-4470


Repository: mesos


Description
---

Stout: Implemented `uname` on Windows.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
edaa76a5322d0bf60b7172405aa754b5aca95458 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
c48106e5905e3be0faeba7177ef534766089faff 

Diff: https://reviews.apache.org/r/46191/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 46191: Stout: Implemented `uname` on Windows.

[Alex Clemmer]

> On April 15, 2016, 10:56 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, line 66
> > 
> >
> > `std::unique_ptr` semantically means that it's pointing to a single 
> > element. We should use  `std::unique_ptr` to use the array of elements 
> > version. We should also use `new` so that we don't have to manually 
> > calcaluate the number of bytes.
> > 
> > ```
> > std::unique_ptr name(new char[size + 1]);
> > ```

You're right, that is a lot cleaner, thanks!


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46191/#review129199
---


On April 15, 2016, 8:42 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46191/
> ---
> 
> (Updated April 15, 2016, 8:42 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4470
> https://issues.apache.org/jira/browse/MESOS-4470
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout: Implemented `uname` on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> edaa76a5322d0bf60b7172405aa754b5aca95458 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> c48106e5905e3be0faeba7177ef534766089faff 
> 
> Diff: https://reviews.apache.org/r/46191/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46013/
---

(Updated April 17, 2016, 10:18 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-4471
https://issues.apache.org/jira/browse/MESOS-4471


Repository: mesos


Description
---

Stout: Implemented `os::processes` on Windows.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
edaa76a5322d0bf60b7172405aa754b5aca95458 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
c48106e5905e3be0faeba7177ef534766089faff 

Diff: https://reviews.apache.org/r/46013/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

[Alex Clemmer]

> On April 15, 2016, 11:31 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, line 362
> > 
> >
> > What's the difference between `Failed to call X` vs `Call to `X` 
> > failed`?

Ah, I tried to be consistent about making all these messages say `Call to x 
failed` because I thought it was clearer. That is why there are both -- I just 
didn't get all of them.

Also, this message is somewhat inconsistent with our style. We say 
`os::processes: Call to x failed`. So we should fix that here too.


> On April 15, 2016, 11:31 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, lines 
> > 406-407
> > 
> >
> > I think it would easier to read:
> > 
> > ```
> > Try utime = Nanoseconds(lKernelTime.QuadPart * 100);
> > Try stime = Nanoseconds(lUserTime.QuadPart * 100);
> > ```
> > 
> > This is also arguably more correct, since any number < 10,000,000 would 
> > incorrectly result in 0 by the division.
> > 
> > What do you think?

You're right, this was sloppy.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46013/#review129204
---


On April 15, 2016, 7:50 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46013/
> ---
> 
> (Updated April 15, 2016, 7:50 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4471
> https://issues.apache.org/jira/browse/MESOS-4471
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout: Implemented `os::processes` on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> edaa76a5322d0bf60b7172405aa754b5aca95458 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> c48106e5905e3be0faeba7177ef534766089faff 
> 
> Diff: https://reviews.apache.org/r/46013/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 46308: Moved LogProcess declaration to log/log.h.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46308/#review129269
---



Patch looks great!

Reviews applied: [45900, 45901, 46160, 46161, 46162, 46163, 46164, 46288, 
46295, 46308]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 17, 2016, 4:47 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46308/
> ---
> 
> (Updated April 17, 2016, 4:47 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5171
> https://issues.apache.org/jira/browse/MESOS-5171
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved LogProcess declaration to log/log.h.
> 
> 
> Diffs
> -
> 
>   include/mesos/log/log.hpp 0f61777dd04e6d7212ac218c4cde3cd7f95d2896 
>   src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99 
>   src/log/log.hpp PRE-CREATION 
>   src/log/log.cpp a37676068dae14b1adc61ef75e2742c16e7a6e42 
> 
> Diff: https://reviews.apache.org/r/46308/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46307/
---

(Updated April 17, 2016, 5:15 p.m.)


Review request for mesos, Alexander Rukletsov, Ben Mahler, Greg Mann, Neil 
Conway, and Timothy Chen.


Changes
---

Update description.


Bugs: MESOS-1802
https://issues.apache.org/jira/browse/MESOS-1802


Repository: mesos


Description (updated)
---

We need to ignore subsequent status updates in HealthStatusChange
tests. In our test cases, we set `consecutive_failures` to 3 in
HealthCheck message definition. But the counter for
`consecutiveFailures` in `mesos-health-check` would be reset to 0
after a success check. It is possible to continue to receive status
updates before we stop the driver.


Diffs (updated)
-

  src/tests/health_check_tests.cpp 1c4a554ab07731963a4a38e3ae40b0323bf317bb 

Diff: https://reviews.apache.org/r/46307/diff/


Testing
---

# I still could not reproduce the problem in old code after repeatedly tests. 
So seems no way to verify whether my assumption is correct or not.


Thanks,

haosdent huang

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46307/#review129265
---



Bad patch!

Reviews applied: [46307]

Failed command: ./support/apply-review.sh -n -r 46307

Error:
2016-04-17 16:51:54 URL:https://reviews.apache.org/r/46307/diff/raw/ 
[1446/1446] -> "46307.patch" [1]
Total errors found: 0
Checking 1 files
Error: No line in the commit message summary may exceed 72 characters.

Full log: https://builds.apache.org/job/mesos-reviewbot/12574/console

- Mesos ReviewBot


On April 17, 2016, 3:15 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46307/
> ---
> 
> (Updated April 17, 2016, 3:15 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Greg Mann, Neil 
> Conway, and Timothy Chen.
> 
> 
> Bugs: MESOS-1802
> https://issues.apache.org/jira/browse/MESOS-1802
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We need to ignore subsequent status updates in HealthStatusChange
> tests. In our test cases, we set `consecutive_failures` to 3 in
> HealthCheck message definition. But the counter for
> `consecutiveFailures` in `mesos-health-check` would be reset to 0 after
> a success check. It is possible to continue to receive status updates
> before we stop the driver.
> 
> 
> Diffs
> -
> 
>   src/tests/health_check_tests.cpp 1c4a554ab07731963a4a38e3ae40b0323bf317bb 
> 
> Diff: https://reviews.apache.org/r/46307/diff/
> 
> 
> Testing
> ---
> 
> # I still could not reproduce the problem in old code after repeatedly tests. 
> So seems no way to verify whether my assumption is correct or not.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 46295: Replaced 'using namespace' with 'using'.

[Kapil Arya]

> On April 16, 2016, 9:41 p.m., Jie Yu wrote:
> > src/log/log.cpp, lines 742-744
> > 
> >
> > Can you move this to the top of the file?
> 
> Kapil Arya wrote:
> That won't work right away coz LogProcess, etc. are declared in this 
> file. So to move it up, I'll have to either do a forward declaration for 
> these classes or move the definitions to a separate header. Any preference?

Created https://reviews.apache.org/r/46308/ to handle this.


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46295/#review129255
---


On April 17, 2016, 12:47 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46295/
> ---
> 
> (Updated April 17, 2016, 12:47 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5171
> https://issues.apache.org/jira/browse/MESOS-5171
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Mostly for mesos::state and mesos::log.
> 
> 
> Diffs
> -
> 
>   src/java/jni/org_apache_mesos_state_AbstractState.cpp 
> 4fd43ca31c6917e81ea1b331b8507ca42a2249cf 
>   src/java/jni/org_apache_mesos_state_LevelDBState.cpp 
> fb3c5418220f66c6320581033ee7963de47eafd3 
>   src/java/jni/org_apache_mesos_state_LogState.cpp 
> 528fe5367f55c63916cd4990abcc3c137e77cfec 
>   src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
> 23a89c3e5c5309a8a9b45c168fb61b12d89db1ec 
>   src/local/local.cpp df72ac52110b75d63df1076496b48e63d06d42ce 
>   src/log/log.cpp a37676068dae14b1adc61ef75e2742c16e7a6e42 
>   src/log/tool/benchmark.cpp 770c6d85fec76826ca8369b2afc721c07899e32f 
>   src/log/tool/replica.cpp 49415821a32960c78192b89f9a0f2067b9157a63 
>   src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 
>   src/state/log.cpp fd9f5ef90cacb56d934dd8603d70c5a14a36a477 
>   src/tests/log_tests.cpp 85fc9d4dfaee232f5ea7c29b2133310f7c6441a8 
>   src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec 
> 
> Diff: https://reviews.apache.org/r/46295/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 46295: Replaced 'using namespace' with 'using'.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46295/
---

(Updated April 17, 2016, 12:47 p.m.)


Review request for mesos and Jie Yu.


Changes
---

addressed comments


Bugs: MESOS-5171
https://issues.apache.org/jira/browse/MESOS-5171


Repository: mesos


Description (updated)
---

Mostly for mesos::state and mesos::log.


Diffs (updated)
-

  src/java/jni/org_apache_mesos_state_AbstractState.cpp 
4fd43ca31c6917e81ea1b331b8507ca42a2249cf 
  src/java/jni/org_apache_mesos_state_LevelDBState.cpp 
fb3c5418220f66c6320581033ee7963de47eafd3 
  src/java/jni/org_apache_mesos_state_LogState.cpp 
528fe5367f55c63916cd4990abcc3c137e77cfec 
  src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
23a89c3e5c5309a8a9b45c168fb61b12d89db1ec 
  src/local/local.cpp df72ac52110b75d63df1076496b48e63d06d42ce 
  src/log/log.cpp a37676068dae14b1adc61ef75e2742c16e7a6e42 
  src/log/tool/benchmark.cpp 770c6d85fec76826ca8369b2afc721c07899e32f 
  src/log/tool/replica.cpp 49415821a32960c78192b89f9a0f2067b9157a63 
  src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 
  src/state/log.cpp fd9f5ef90cacb56d934dd8603d70c5a14a36a477 
  src/tests/log_tests.cpp 85fc9d4dfaee232f5ea7c29b2133310f7c6441a8 
  src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec 

Diff: https://reviews.apache.org/r/46295/diff/


Testing
---


Thanks,

Kapil Arya

Review Request 45673: PoC: Docker Volume Isolator.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45673/
---

Review request for mesos, Gilbert Song and Jie Yu.


Repository: mesos


Description
---

PoC: Docker Volumt Isolator.

Will split this to several patches after review discussion.


Diffs
-

  src/CMakeLists.txt 06f58c4a88e3c527df727df1efe11ed3ab77efa8 
  src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99 
  src/cli/execute.cpp f70d9e1c4badb7d4342e90ce4d4f8114f27a7dff 
  src/slave/containerizer/mesos/containerizer.cpp 
1e1a36903f4377497bb72b69e4ead63675d453c0 
  src/slave/containerizer/mesos/isolators/docker/volume/driver.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
786f917c0ec04b6839bbd524fa7c8de3729f9bdb 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
0ad473dc3bd45e122fba55a670e1a893e61c977a 
  src/slave/containerizer/mesos/isolators/docker/volume/paths.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/volume/paths.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/volume/state.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/volume/state.proto 
PRE-CREATION 
  src/slave/slave.cpp de99e9eb5cc812b2e07deb749b98b4f4db363728 

Diff: https://reviews.apache.org/r/45673/diff/


Testing
---

Some issues want to discuss:
1) One container can have multiple volumes, and the prepare() will generate all 
of the mount point for all of the volumes in one container. Each volume driver 
and volume name need to map to one mount point, so in driver.cpp::mount(), if 
only adding volume_driver, volume_name, options as paramter, then once the 
mount point was generated, in prepare(), we will not able to  know the 
relationship of volume_driver, volume_name pair and mount point. So it is 
better transfer a structure including volume_driver, volume_name and mount 
point to driver.cpp::mount() so that we can keep the relationship of  
volume_driver, volume_name and mount point
2) Reference counter when cleanup. My thinking is that we can use volume driver 
and volume name generate an volume ID, if one volume driver and volume name 
pair was used by more than one container, then the reference couter of the 
volume ID will be greater than 1 and we should not unmounts for such case, the 
unmount was only called when the volume ID reference count was 1.
3) I was using “multihasmap” for infos in volume isolator, the reason is 
because one container can have multiple volumes. If do not want to use 
“multihashmap”, then I may need to update Info structure as:

Info (const hashmap>& _dockerVolumeMountInfo
  const Option& _containerPath = None(),
  const Option>& _driverOptions = None())
: dockerVolumeMountInfo (_dockerVolumeMountInfo),
  containerPath(_containerPath),
  driverOptions(_driverOptions){}

  // The driver.cpp::mount() will fill in the value of mountPoint for each 
DockerVolumeMount (driver and name)
  hashmap> 
dockerVolumeMountInfo;

  Option containerPath;

  Option> driverOptions;
};


Thanks,

Guangya Liu

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46307/
---

(Updated April 17, 2016, 3:11 p.m.)


Review request for mesos, Ben Mahler, Neil Conway, and Timothy Chen.


Bugs: MESOS-1802
https://issues.apache.org/jira/browse/MESOS-1802


Repository: mesos


Description
---

We need to ignore subsequent status updates in HealthStatusChange
tests. In our test cases, we set `consecutive_failures` to 3 in
HealthCheck message definition. But the counter for
`consecutiveFailures` in `mesos-health-check` would be reset to 0 after
a success check. It is possible to continue to receive status updates
before we stop the driver.


Diffs
-

  src/tests/health_check_tests.cpp 1c4a554ab07731963a4a38e3ae40b0323bf317bb 

Diff: https://reviews.apache.org/r/46307/diff/


Testing (updated)
---

# I still could not reproduce the problem in old code after repeatedly tests. 
So seems no way to verify whether my assumption is correct or not.


Thanks,

haosdent huang

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46307/
---

(Updated April 17, 2016, 3:11 p.m.)


Review request for mesos, Ben Mahler, Neil Conway, and Timothy Chen.


Bugs: MESOS-1802
https://issues.apache.org/jira/browse/MESOS-1802


Repository: mesos


Description
---

We need to ignore subsequent status updates in HealthStatusChange
tests. In our test cases, we set `consecutive_failures` to 3 in
HealthCheck message definition. But the counter for
`consecutiveFailures` in `mesos-health-check` would be reset to 0 after
a success check. It is possible to continue to receive status updates
before we stop the driver.


Diffs
-

  src/tests/health_check_tests.cpp 1c4a554ab07731963a4a38e3ae40b0323bf317bb 

Diff: https://reviews.apache.org/r/46307/diff/


Testing (updated)
---

# I still could not reproduce the problem in old code after repeatedly tests. 
So seems no way to verify whether my assumption is correct or not.


Thanks,

haosdent huang

Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46307/
---

Review request for mesos, Ben Mahler, Neil Conway, and Timothy Chen.


Bugs: MESOS-1802
https://issues.apache.org/jira/browse/MESOS-1802


Repository: mesos


Description
---

We need to ignore subsequent status updates in HealthStatusChange
tests. In our test cases, we set `consecutive_failures` to 3 in
HealthCheck message definition. But the counter for
`consecutiveFailures` in `mesos-health-check` would be reset to 0 after
a success check. It is possible to continue to receive status updates
before we stop the driver.


Diffs
-

  src/tests/health_check_tests.cpp 1c4a554ab07731963a4a38e3ae40b0323bf317bb 

Diff: https://reviews.apache.org/r/46307/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 46295: Replaced 'using namespace' with 'using'.

[Kapil Arya]

> On April 16, 2016, 9:41 p.m., Jie Yu wrote:
> > src/log/log.cpp, lines 742-744
> > 
> >
> > Can you move this to the top of the file?

That won't work right away coz LogProcess, etc. are declared in this file. So 
to move it up, I'll have to either do a forward declaration for these classes 
or move the definitions to a separate header. Any preference?


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46295/#review129255
---


On April 15, 2016, 9:27 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46295/
> ---
> 
> (Updated April 15, 2016, 9:27 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5171
> https://issues.apache.org/jira/browse/MESOS-5171
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replaced 'using namespace' with 'using'.
> 
> 
> Diffs
> -
> 
>   src/java/jni/org_apache_mesos_state_AbstractState.cpp 
> 4fd43ca31c6917e81ea1b331b8507ca42a2249cf 
>   src/java/jni/org_apache_mesos_state_LevelDBState.cpp 
> fb3c5418220f66c6320581033ee7963de47eafd3 
>   src/java/jni/org_apache_mesos_state_LogState.cpp 
> 528fe5367f55c63916cd4990abcc3c137e77cfec 
>   src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
> 23a89c3e5c5309a8a9b45c168fb61b12d89db1ec 
>   src/local/local.cpp df72ac52110b75d63df1076496b48e63d06d42ce 
>   src/log/log.cpp a37676068dae14b1adc61ef75e2742c16e7a6e42 
>   src/log/tool/benchmark.cpp 770c6d85fec76826ca8369b2afc721c07899e32f 
>   src/log/tool/replica.cpp 49415821a32960c78192b89f9a0f2067b9157a63 
>   src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 
>   src/state/log.cpp fd9f5ef90cacb56d934dd8603d70c5a14a36a477 
>   src/tests/log_tests.cpp 85fc9d4dfaee232f5ea7c29b2133310f7c6441a8 
>   src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec 
> 
> Diff: https://reviews.apache.org/r/46295/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 36816: Supported HTTP in Mesos health check program.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36816/#review129261
---



Patch looks great!

Reviews applied: [36816]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 17, 2016, 9:14 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36816/
> ---
> 
> (Updated April 17, 2016, 9:14 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Michael Park, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-2533
> https://issues.apache.org/jira/browse/MESOS-2533
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Supported HTTP in Mesos health check program.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 87af4a06db8cc3889fe4d3b314206103f5ce5f2d 
>   include/mesos/v1/mesos.proto 34da0a1484dc2f71262d8b97484b8edaae35bb6c 
>   src/docker/executor.cpp 579905f6c2ece7db9c853abf481541fdbc3116b7 
>   src/health-check/main.cpp 98ea5d3675f088e3a341037dcee92695e4857999 
>   src/tests/health_check_tests.cpp 1c4a554ab07731963a4a38e3ae40b0323bf317bb 
> 
> Diff: https://reviews.apache.org/r/36816/diff/
> 
> 
> Testing
> ---
> 
> * Add unit test cases: HealthCheckTest.HealthyTaskThroughHttp and 
> HealthCheckTest.HealthyTaskNotMatchHttpStatuses
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 36816: Supported HTTP in Mesos health check program.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36816/
---

(Updated April 17, 2016, 9:14 a.m.)


Review request for mesos, Adam B, Michael Park, and Timothy Chen.


Changes
---

Rebase.


Summary (updated)
-

Supported HTTP in Mesos health check program.


Bugs: MESOS-2533
https://issues.apache.org/jira/browse/MESOS-2533


Repository: mesos


Description (updated)
---

Supported HTTP in Mesos health check program.


Diffs (updated)
-

  include/mesos/mesos.proto 87af4a06db8cc3889fe4d3b314206103f5ce5f2d 
  include/mesos/v1/mesos.proto 34da0a1484dc2f71262d8b97484b8edaae35bb6c 
  src/docker/executor.cpp 579905f6c2ece7db9c853abf481541fdbc3116b7 
  src/health-check/main.cpp 98ea5d3675f088e3a341037dcee92695e4857999 
  src/tests/health_check_tests.cpp 1c4a554ab07731963a4a38e3ae40b0323bf317bb 

Diff: https://reviews.apache.org/r/36816/diff/


Testing
---

* Add unit test cases: HealthCheckTest.HealthyTaskThroughHttp and 
HealthCheckTest.HealthyTaskNotMatchHttpStatuses
make check


Thanks,

haosdent huang