Re: Review Request 47082: LostSlaveMessage should be sent to affected frameworks only.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47082/#review136759 --- Patch looks great! Reviews applied: [48453, 47082] Passed

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48315/#review136755 --- Patch looks great! Reviews applied: [48313, 48314, 48315]

Re: Review Request 48423: Simplified the test for Docker::version.

> On June 8, 2016, 10:17 p.m., Joseph Wu wrote: > > FYI, your description is currently above the 72 character line limit :) Yeah, unfortunately for this one I wrote it in reviewboard rather than in git. :) - Benjamin --- This is an

Re: Review Request 48422: Removed an unused function in src/docker/docker.cpp.

> On June 8, 2016, 10:15 p.m., Joseph Wu wrote: > > Interesting. I wonder if this function was used like [this > > one](https://github.com/apache/mesos/blob/1615fa0eb61cc2d87754ee0b2cbfc331f439a32c/src/linux/ns.hpp#L296-L297) > > at some point. Probably, now we have lambdas to make this

Re: Review Request 48429: Fixed broken docker logging redirection in the docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48429/ --- (Updated June 9, 2016, 4:04 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 48428: Updated Docker::run to return exit status of container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48428/ --- (Updated June 9, 2016, 3:57 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 48448: Changed the severity level of a log line in UPID::operator>>.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48448/#review136750 --- Patch looks great! Reviews applied: [48448] Passed command:

Review Request 48458: Corrected comment for QuotaProvidesGuarantee.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48458/ --- Review request for mesos, Alexander Rukletsov and Benjamin Mahler. Repository:

Re: Review Request 48434: Changed operator API RPC handlers to `http::Response` in master.

> On June 8, 2016, 9:13 p.m., Vinod Kone wrote: > > src/master/http.cpp, line 514 > > > > > > this comment doesn't make sense in this helper function because it > > doesn't have a handle to the original

Re: Review Request 48435: Changed operator API RPC handlers to `http::Response` in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48435/ --- (Updated June 9, 2016, 2:01 a.m.) Review request for mesos, Abhishek Dasgupta,

Re: Review Request 48434: Changed operator API RPC handlers to `http::Response` in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48434/ --- (Updated June 9, 2016, 2 a.m.) Review request for mesos, Abhishek Dasgupta,

Re: Review Request 48450: Add unit test for master /tasks endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48450/#review136746 --- Patch looks great! Reviews applied: [48400, 48401, 48449, 48046,

Review Request 48455: Removed unused import from sorter.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48455/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 48314: Added os::empty(path) to check if contents in a directory is empty.

> On June 8, 2016, 1:11 p.m., Neil Conway wrote: > > 3rdparty/stout/tests/os/rmdir_tests.cpp, line 62 > > > > > > Seems redundant to check both `listfiles` and `os::empty`, here and > > elsewhere. Yes, but added

Review Request 48453: Track UPIDs based on executor id in scheduler driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48453/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-5143

Re: Review Request 47082: LostSlaveMessage should be sent to affected frameworks only.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47082/ --- (Updated June 9, 2016, 1:08 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 47082: LostSlaveMessage should be sent to affected frameworks only.

> On June 6, 2016, 5:43 a.m., Jiang Yan Xu wrote: > > src/tests/master_tests.cpp, line 1760 > > > > > > So the following two tests actually caught something we didn't > > anticipate, so instead of "fixing" the

Re: Review Request 48447: Changed the severity level of a log line in Provisioner::destroy().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48447/#review136741 --- Patch looks great! Reviews applied: [48447] Passed command:

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/ --- (Updated June 9, 2016, 12:49 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 48388: Fixed compilation on OS X of aufs tests.

> On June 8, 2016, 6:49 p.m., Jie Yu wrote: > > In the future, please split the patch into two: 1) fix the compile issue; > > 2) do the re-ordering. As you can tell by looking at the diff, it is very > > difficult for reviewers to review. If you were to have two patches, it > > could be very

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48315/ --- (Updated June 9, 2016, 12:25 a.m.) Review request for mesos, Neil Conway and

Re: Review Request 48314: Added os::empty(path) to check if contents in a directory is empty.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48314/ --- (Updated June 9, 2016, 12:24 a.m.) Review request for mesos, Neil Conway and

Re: Review Request 48313: Creation and deletion of persistent volumes across agent restart.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48313/ --- (Updated June 9, 2016, 12:22 a.m.) Review request for mesos, Neil Conway and

Review Request 48448: Changed the severity level of a log line in UPID::operator>>.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48448/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5575

Re: Review Request 48400: Extract task collection logic to helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48400/ --- (Updated June 9, 2016, midnight) Review request for mesos, Anand Mazumdar and

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/ --- (Updated June 9, 2016, 12:01 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 48401: Change GetTask.limit type to int32 with default value 100.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48401/ --- (Updated June 9, 2016, 12:01 a.m.) Review request for mesos and Vinod Kone.

Review Request 48449: Add Task proto message to v1/mesos.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48449/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5493

Review Request 48450: Add unit test for master /tasks endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48450/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 48447: Changed the severity level of a log line in Provisioner::destroy().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48447/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4952

Re: Review Request 48388: Fixed compilation on OS X of aufs tests.

> On June 8, 2016, 6:49 p.m., Jie Yu wrote: > > In the future, please split the patch into two: 1) fix the compile issue; > > 2) do the re-ordering. As you can tell by looking at the diff, it is very > > difficult for reviewers to review. If you were to have two patches, it > > could be very

Re: Review Request 47719: Removed invalid gpu statistics columns in framework data tables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47719/#review136730 --- Ship it! Thanks! - Benjamin Mahler On May 23, 2016, 6:11

Re: Review Request 48442: Removed redundant expectations for `disconnected` callbacks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48442/#review136729 --- Patch looks great! Reviews applied: [48437, 48442] Passed

Re: Review Request 48425: Fixed confusing logging of WSTRINGIFY in Docker wrapper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48425/#review136723 --- Ship it! FYI: Description > 72 characters :) - Joseph Wu On

Re: Review Request 48427: Avoid killing a stale pid in the docker/command executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48427/#review136722 --- Ship it! Ship It! - Jie Yu On June 8, 2016, 7:18 p.m.,

Re: Review Request 48423: Simplified the test for Docker::version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48423/#review136714 --- Ship it! FYI, your description is currently above the 72

Re: Review Request 48422: Removed an unused function in src/docker/docker.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48422/#review136712 --- Ship it! Interesting. I wonder if this function was used like

Re: Review Request 48426: Made logging of Subprocess errors consistent in Docker wrapper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48426/#review136721 --- Ship it! Ship It! - Jie Yu On June 8, 2016, 7:18 p.m.,

Re: Review Request 48425: Fixed confusing logging of WSTRINGIFY in Docker wrapper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48425/#review136720 --- Ship it! Ship It! - Jie Yu On June 8, 2016, 7:18 p.m.,

Re: Review Request 48424: Avoid use of CHECK within Docker tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48424/#review136719 --- Ship it! Ship It! - Jie Yu On June 8, 2016, 7:18 p.m.,

Re: Review Request 48430: Added Docker::kill.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48430/#review136716 --- Bad patch! Reviews applied: [48430, 48429, 48428, 48427, 48426,

Re: Review Request 48423: Simplified the test for Docker::version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48423/#review136718 --- Ship it! Ship It! - Jie Yu On June 8, 2016, 7:18 p.m.,

Re: Review Request 48422: Removed an unused function in src/docker/docker.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48422/#review136717 --- Ship it! Ship It! - Jie Yu On June 8, 2016, 7:18 p.m.,

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/#review136713 --- Patch looks great! Reviews applied: [48438] Passed command:

Re: Review Request 48437: Fixed `Subscribed` events to include heartbeat interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48437/ --- (Updated June 8, 2016, 9:46 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 48442: Removed redundant expectations for `disconnected` callbacks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48442/ --- (Updated June 8, 2016, 9:37 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 48442: Removed redundant expectations for `disconnected` callbacks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48442/#review136708 --- Ship it! Can you add more details to the description on why

Re: Review Request 48437: Fixed `Subscribed` events to include heartbeat interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48437/#review136707 --- src/internal/evolve.cpp (line 173)

Re: Review Request 48435: Changed operator API RPC handlers to `http::Response` in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48435/#review136705 --- same comments as previous review. - Vinod Kone On June 8,

Re: Review Request 48313: Creation and deletion of persistent volumes across agent restart.

> On June 8, 2016, 1:28 p.m., Neil Conway wrote: > > Overall seems like a reasonable approach. > > > > One thing that isn't clear to me: what is the advantage of updating the > > checkpoint to reflect any partial work that was done before exiting? It > > seems that adds a bunch of complexity

Re: Review Request 48434: Changed operator API RPC handlers to `http::Response` in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48434/#review136703 --- src/master/http.cpp (line 514)

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

> On June 8, 2016, 1:06 p.m., Neil Conway wrote: > > (1) This could benefit from a unit test. > > > > (2) More importantly, what happens if the directory already exists and > > contains data? By "cleanup", you mean delete any existing data in the > > directory, right? ISTM this could very

Re: Review Request 47700: Added a benchmark for reconciling tasks using the library/driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47700/#review136698 --- Ship it! Ship It! - Vinod Kone On June 8, 2016, 5:36 p.m.,

Re: Review Request 48380: Updated CHANGELOG for libprocess HTTP authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48380/#review136696 --- CHANGELOG (line 153)

Re: Review Request 48381: Updated CHANGELOG for 'work_dir' flag changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48381/#review136695 --- Fix it, then Ship it! CHANGELOG

Re: Review Request 48435: Changed operator API RPC handlers to `http::Response` in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48435/#review136693 --- Patch looks great! Reviews applied: [48434, 48435] Passed

Re: Review Request 48343: Moved two tests from PartitionTest to MasterTest.

> On June 7, 2016, 3:18 p.m., Vinod Kone wrote: > > src/tests/partition_tests.cpp, line 574 > > > > > > Hmm. Instead of moving them to master_tests.cpp, keep them in > > partition_tests.cpp and have them inherit

Re: Review Request 48250: Cleaned up task state reconciliation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48250/#review136690 --- Ship it! Ship It! - Vinod Kone On June 8, 2016, 11:25 a.m.,

Review Request 48442: Removed redundant expectations for `disconnected` callbacks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48442/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 48428: Updated Docker::run to return exit status of container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48428/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4279

Review Request 48430: Added Docker::kill.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48430/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Review Request 48429: Fixed broken docker logging redirection in the docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48429/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4279 and MESOS-5195

Review Request 48425: Fixed confusing logging of WSTRINGIFY in Docker wrapper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48425/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Review Request 48427: Avoid killing a stale pid in the docker/command executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48427/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Review Request 48424: Avoid use of CHECK within Docker tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48424/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Review Request 48426: Made logging of Subprocess errors consistent in Docker wrapper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48426/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 47700: Added a benchmark for reconciling tasks using the library/driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47700/#review136680 --- Patch looks great! Reviews applied: [47700] Passed command:

Review Request 48423: Simplified the test for Docker::version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48423/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Review Request 48422: Removed an unused function in src/docker/docker.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48422/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 48388: Fixed compilation on OS X of aufs tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48388/#review136674 --- Ship it! In the future, please split the patch into two: 1)

Re: Review Request 48268: Implemented SET_QUOTA Call in v1 master API.

> On June 7, 2016, 10:12 a.m., haosdent huang wrote: > > src/master/quota_handler.cpp, lines 279-335 > > > > > > Is it possible to reuse some code from `Master::QuotaHandler::set(` > > Abhishek Dasgupta wrote: >

Review Request 48438: Implement GET_AGENTS Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: mesos-5491

Review Request 48437: Fixed `Subscribed` events to include heartbeat interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48437/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5567

Re: Review Request 48434: Changed operator API RPC handlers to `http::Response` in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48434/ --- (Updated June 8, 2016, 6:26 p.m.) Review request for mesos, Abhishek Dasgupta,

Re: Review Request 48435: Changed operator API RPC handlers to `http::Response` in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48435/ --- (Updated June 8, 2016, 6:26 p.m.) Review request for mesos, Abhishek Dasgupta,

Review Request 48435: Changed operator API RPC handlers to `http::Response` in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48435/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5572

Review Request 48434: Changed operator API RPC handlers to `http::Response` in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48434/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5572

Re: Review Request 48420: Added some links to the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48420/#review136671 --- Patch looks great! Reviews applied: [48409, 48420] Passed

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

> On June 8, 2016, 5:34 p.m., Vinod Kone wrote: > > src/master/http.cpp, lines 1390-1411 > > > > > > so this stuff is duplicated in the REST handler and this handler. i > > wonder if we can factor it out as well

Re: Review Request 47700: Added a benchmark for reconciling tasks using the library/driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47700/ --- (Updated June 8, 2016, 5:36 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 48400: Extract task collection logic to helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48400/#review136655 --- src/master/master.hpp (lines 1245 - 1246)

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/#review136664 --- src/master/http.cpp (lines 1390 - 1411)

Re: Review Request 48401: Change GetTask.limit type to int32.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48401/#review136663 --- include/mesos/v1/master.proto (line 106)

Re: Review Request 48401: Change GetTask.limit type to int32.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48401/#review136662 --- Ship it! Ship It! - Vinod Kone On June 8, 2016, 7:18 a.m.,

Review Request 48420: Added some links to the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48420/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Re: Review Request 47973: Updated gc to prevent early exit in case of error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47973/ --- (Updated June 8, 2016, 9:57 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 47973: Updated gc to prevent early exit in case of error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47973/#review136592 --- src/slave/gc.cpp (line 135)

Re: Review Request 48002: Windows: Undefined macros.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48002/ --- (Updated June 8, 2016, 4:24 p.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 47603: Agent:[2/2] Added Windows support for folder `launcher/`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47603/ --- (Updated June 8, 2016, 4:20 p.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 48380: Updated CHANGELOG for libprocess HTTP authorization.

> On June 8, 2016, 1:10 p.m., Joerg Schad wrote: > > Should we add this as well to upgrades.md? > > Greg Mann wrote: > Yes! Thanks for thinking of this, Joerg! I will take care of that in another patch. - Joerg --- This is an

Re: Review Request 48380: Updated CHANGELOG for libprocess HTTP authorization.

> On June 8, 2016, 1:10 p.m., Joerg Schad wrote: > > Should we add this as well to upgrades.md? Yes! Thanks for thinking of this, Joerg! - Greg --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 48381: Updated CHANGELOG for 'work_dir' flag changes.

> On June 8, 2016, 1:10 p.m., Joerg Schad wrote: > > Should we add this as well to upgrades.md? Yep, great idea! - Greg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48381/#review136635

Re: Review Request 48380: Updated CHANGELOG for libprocess HTTP authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48380/#review136651 --- Fix it, then Ship it! CHANGELOG (line 149)

Re: Review Request 48409: Fixed broken links in the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48409/#review136648 --- Patch looks great! Reviews applied: [48409] Passed command:

Re: Review Request 48409: Fixed broken links in the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48409/ --- (Updated June 8, 2016, 1:59 p.m.) Review request for mesos and Till Toenshoff.

Re: Review Request 48272: Added 1.0 changed to upgrades.md.

> On June 6, 2016, 2:52 p.m., Vinod Kone wrote: > > docs/upgrades.md, line 173 > > > > > > This section seems like duplicate of what we have in CHANGELOG. What do > > you think about removing this text from here

Re: Review Request 48409: Fixed broken links in the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48409/#review136639 --- Patch looks great! Reviews applied: [48409] Passed command:

Re: Review Request 48313: Creation and deletion of persistent volumes across agent restart.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48313/#review136638 --- Overall seems like a reasonable approach. One thing that isn't

Re: Review Request 43561: Improve Ranges parsing to handle single values.

> On June 8, 2016, 5:32 a.m., Benjamin Mahler wrote: > > Hi Klaus sorry for the delay. > > > > This piece of code is very old in Mesos and has some significant technical > > debt. We should have used a parsing library here but at the time we didn't > > have because we hadn't moved to C++11

Re: Review Request 48381: Updated CHANGELOG for 'work_dir' flag changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48381/#review136635 --- Should we add this as well to upgrades.md? - Joerg Schad On

  1   2   >