Re: Review Request 48923: Updated test to expect ServiceUnavailable.

2016-06-19 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48923/ --- (Updated June 20, 2016, 5:51 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 48914: Added GPU_RESOURCES capability to FrameworkInfo.

2016-06-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48914/#review138524 --- include/mesos/mesos.proto (line 278)

Re: Review Request 48919: Updated HTTPProxy to return a failure message in the HTTP result.

2016-06-19 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48919/ --- (Updated June 20, 2016, 5:50 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 48920: Updated the HTTP result returned by failures of authn/authz.

2016-06-19 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48920/ --- (Updated June 20, 2016, 5:49 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 48268: Implemented SET_QUOTA Call in v1 master API.

2016-06-19 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48268/ --- (Updated June 20, 2016, 5:46 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 48901: Fixed all source files affected by the `fromBytes()` change.

2016-06-19 Thread Deshna Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48901/ --- (Updated June 20, 2016, 5:41 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 48613: Added validation logic for UUID's.

2016-06-19 Thread Deshna Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48613/ --- (Updated June 20, 2016, 5:41 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 48614: Added validation for UUID's to master/agent validation helpers.

2016-06-19 Thread Deshna Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48614/ --- (Updated June 20, 2016, 5:41 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 48937: Added a TODO about possible security issues due to misspelled ACLs.

2016-06-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48937/#review138522 --- Patch looks great! Reviews applied: [48936, 48937] Passed

Re: Review Request 48268: Implemented SET_QUOTA Call in v1 master API.

2016-06-19 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48268/#review138519 --- include/mesos/v1/master/master.proto (lines 164 - 165)

Re: Review Request 48934: Removed redundant expectations for `connected`/`disconnected` callback.

2016-06-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48934/#review138521 --- Patch looks great! Reviews applied: [48935, 48934] Passed

Re: Review Request 48925: Implement GET_WEIGHTS Call in v1 master API.

2016-06-19 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48925/ --- (Updated 六月 20, 2016, 3:35 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 48924: Extract public logic of collecting weights info into _getWeights.

2016-06-19 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48924/ --- (Updated 六月 20, 2016, 3:33 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-19 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/ --- (Updated 六月 20, 2016, 2:47 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 48928: Added info about external `libelf` dependence to `upgrades.md`.

2016-06-19 Thread Kevin Klues
> On June 20, 2016, 1:59 a.m., haosdent huang wrote: > > docs/upgrades.md, line 257 > > > > > > I saw the `getting-started.md` use `elfutils-libelf-devel.x86_64`, > > seems not match here? The getting started

Re: Review Request 48931: Implemented LIST_FILES Call in v1 master API.

2016-06-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48931/#review138514 --- Patch looks great! Reviews applied: [48704, 48705, 48931]

Re: Review Request 48927: Implemented DESTROY_VOLUMES Call in v1 master API.

2016-06-19 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48927/ --- (Updated June 20, 2016, 1:59 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 48926: Implemented CREATE_VOLUMES Call in v1 master API.

2016-06-19 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48926/ --- (Updated June 20, 2016, 1:59 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 48928: Added info about external `libelf` dependence to `upgrades.md`.

2016-06-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48928/#review138513 --- Fix it, then Ship it! docs/upgrades.md (line 257)

Re: Review Request 48927: Implemented DESTROY_VOLUMES Call in v1 master API.

2016-06-19 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48927/ --- (Updated June 20, 2016, 1:54 a.m.) Review request for mesos and Vinod Kone.

Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

2016-06-19 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48938/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5502

Re: Review Request 48926: Implemented CREATE_VOLUMES Call in v1 master API.

2016-06-19 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48926/ --- (Updated June 20, 2016, 1:53 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 48928: Added info about external `libelf` dependence to `upgrades.md`.

2016-06-19 Thread Kevin Klues
> On June 20, 2016, 12:34 a.m., Vinod Kone wrote: > > docs/upgrades.md, line 255 > > > > > > s/dependence/dependency/ ? > > > > esp the last occurence in this para. I can make the change if you like, but

Re: Review Request 48928: Added info about external `libelf` dependence to `upgrades.md`.

2016-06-19 Thread Kevin Klues
> On June 20, 2016, 12:34 a.m., Vinod Kone wrote: > > docs/upgrades.md, line 262 > > > > > > Is libelf a run-time dep as well? I thought it was a build-time dep > > only? I'm thinking more and more that we should

Re: Review Request 48920: Updated the HTTP result returned by failures of authn/authz.

2016-06-19 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48920/ --- (Updated June 20, 2016, 1:02 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 48919: Updated HTTPProxy to return a failure message in the HTTP result.

2016-06-19 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48919/ --- (Updated June 20, 2016, 1:01 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/#review138345 --- src/master/http.cpp (line 1706)

Re: Review Request 48937: Added a TODO about possible security issues due to misspelled ACLs.

2016-06-19 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48937/#review138509 --- Ship it! Ship It! - Till Toenshoff On June 20, 2016, 12:12

Re: Review Request 48928: Added info about external `libelf` dependence to `upgrades.md`.

2016-06-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48928/#review138506 --- docs/upgrades.md (line 255)

Re: Review Request 48614: Added validation for UUID's to master/agent validation helpers.

2016-06-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48614/#review138505 --- Ship it! Ship It! - Vinod Kone On June 18, 2016, 9:16 p.m.,

Review Request 48937: Added a TODO about possible security issues due to misspelled ACLs.

2016-06-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48937/ --- Review request for mesos, Joerg Schad and Till Toenshoff. Bugs: MESOS-5588

Review Request 48936: Explained why fields in the acts.Entity must be required.

2016-06-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48936/ --- Review request for mesos, Alexander Rojas and Till Toenshoff. Bugs: MESOS-5588

Re: Review Request 48613: Added validation logic for UUID's.

2016-06-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48613/#review138503 --- Ship it! Can you update the description? - Vinod Kone On

Re: Review Request 48934: Removed redundant expectations for `connected`/`disconnected` callback.

2016-06-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48934/#review138502 --- Ship it! Ship It! - Vinod Kone On June 19, 2016, 10:47

Re: Review Request 48935: Fixed flakiness in some of the tests using scheduler library.

2016-06-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48935/#review138501 --- Ship it! Ship It! - Vinod Kone On June 19, 2016, 10:47

Re: Review Request 48387: Delay before initiating a connection with master.

2016-06-19 Thread Anand Mazumdar
> On June 19, 2016, 11:56 p.m., Jose Guilherme Vanz wrote: > > src/scheduler/constants.hpp, line 30 > > > > > > Sorry my my fail, but what's "Nit" means? > > I suppose I should remove the extra line, right? +1:

Re: Review Request 48387: Delay before initiating a connection with master.

2016-06-19 Thread Jose Guilherme Vanz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48387/#review138498 --- src/scheduler/constants.hpp (line 30)

Re: Review Request 48056: Windows: Added build and run instructions.

2016-06-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48056/#review138485 --- Possibly missing some steps related to OpenSSL. Here's what I

Re: Review Request 48918: Removed explicit authorization results in Mesos.

2016-06-19 Thread Till Toenshoff
> On June 19, 2016, 10:40 p.m., Alexander Rukletsov wrote: > > src/slave/http.cpp, lines 1089-1093 > > > > > > How about this one? Nope, that one will not get invoked if the authorizer failed - `containers` will

Re: Review Request 48387: Delay before initiating a connection with master.

2016-06-19 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48387/#review138478 --- Fix it, then Ship it! Thanks for your patience. This looks

Re: Review Request 44498: Forbid the executor to inherit from slave environment.

2016-06-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44498/#review138496 --- Ship it! Ship It! - Jie Yu On June 19, 2016, 8:34 p.m.,

Re: Review Request 48387: Delay before initiating a connection with master.

2016-06-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48387/#review138494 --- Patch looks great! Reviews applied: [48387] Passed command:

Re: Review Request 48932: Updated CHANGELOG to include note about '503' on authorizer failures.

2016-06-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48932/#review138493 --- CHANGELOG (lines 160 - 161)

Re: Review Request 48920: Updated the HTTP result returned by failures of authn/authz.

2016-06-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48920/#review138491 --- 3rdparty/libprocess/src/process.cpp (line 3327)

Review Request 48935: Fixed flakiness in some of the tests using scheduler library.

2016-06-19 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48935/ --- Review request for mesos, Jose Guilherme Vanz and Vinod Kone. Repository:

Review Request 48934: Removed redundant expectations for `connected`/`disconnected` callback.

2016-06-19 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48934/ --- Review request for mesos, Jose Guilherme Vanz and Vinod Kone. Repository:

Re: Review Request 48919: Updated HTTPProxy to return a failure message in the HTTP result.

2016-06-19 Thread Alexander Rukletsov
> On June 19, 2016, 10:26 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/process.cpp, lines 1217-1218 > > > > > > In r/48918 you removed logging of the failed future, so now those > > failures are

Re: Review Request 48918: Removed explicit authorization results in Mesos.

2016-06-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48918/#review138488 --- src/slave/http.cpp

Re: Review Request 48919: Updated HTTPProxy to return a failure message in the HTTP result.

2016-06-19 Thread Till Toenshoff
> On June 19, 2016, 10:26 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/process.cpp, line 1218 > > > > > > In case future is not failed, you create a response with an empty body, > > but with some

Re: Review Request 48919: Updated HTTPProxy to return a failure message in the HTTP result.

2016-06-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48919/#review138486 --- 3rdparty/libprocess/src/process.cpp (lines 1217 - 1218)

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

2016-06-19 Thread Anand Mazumdar
> On June 19, 2016, 9:27 p.m., Kevin Klues wrote: > > src/tests/api_tests.cpp, lines 419-421 > > > > > > It's not here in the review, but the final committed version of this > > patch contains these lines as: > >

Re: Review Request 48933: Fixed build on machines that contain GPU's.

2016-06-19 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48933/#review138484 --- Ship it! Looks good: Ran `GTEST_FILTER="*GetRoles*" make -j

Review Request 48933: Fixed build on machines that contain GPU's.

2016-06-19 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48933/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-5494

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

2016-06-19 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/#review138482 --- src/tests/api_tests.cpp (lines 419 - 421)

Re: Review Request 48915: Added an example framework for consuming GPUs.

2016-06-19 Thread Kevin Klues
> On June 19, 2016, 7:13 a.m., Guangya Liu wrote: > > It is better re-implement your framework with v1 API, you can take a look > > at > > https://github.com/apache/mesos/blob/master/src/examples/long_lived_framework.cpp > > as an referene. The `MesosSchedulerDriver` is implemented in terms

Re: Review Request 48915: Added an example framework for consuming GPUs.

2016-06-19 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48915/ --- (Updated June 19, 2016, 9:01 p.m.) Review request for mesos and Benjamin

Review Request 48932: Updated CHANGELOG to include note about '503' on authorizer failures.

2016-06-19 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48932/ --- Review request for mesos, Adam B, Alexander Rukletsov, Anand Mazumdar,

Re: Review Request 48268: Implemented SET_QUOTA Call in v1 master API.

2016-06-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48268/#review138481 --- Patch looks great! Reviews applied: [48268] Passed command:

Re: Review Request 48705: Implemented LIST_FILES Call in v1 agent API.

2016-06-19 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48705/ --- (Updated June 19, 2016, 8:38 p.m.) Review request for mesos, Anand Mazumdar,

Review Request 48931: Implemented LIST_FILES Call in v1 master API.

2016-06-19 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48931/ --- Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.

Re: Review Request 44498: Forbid the executor to inherit from slave environment.

2016-06-19 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44498/ --- (Updated June 19, 2016, 1:34 p.m.) Review request for mesos, Guangya Liu,

Re: Review Request 48914: Added GPU_RESOURCES capability to FrameworkInfo.

2016-06-19 Thread Kevin Klues
> On June 19, 2016, 2:18 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1277-1279 > > > > > > This logic seems also allow agents without gpu resources offered to the > > framework

Review Request 48928: Added info about external `libelf` dependence to `upgrades.md`.

2016-06-19 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48928/ --- Review request for mesos, Benjamin Mahler, haosdent huang, Vinod Kone, and

Re: Review Request 45086: Enable cgroups unified isolator in isolation.

2016-06-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45086/#review138477 --- Bad patch! Reviews applied: [45086, 46300, 43284, 45574, 45573,

Re: Review Request 48705: Implemented LIST_FILES Call in v1 agent API.

2016-06-19 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48705/ --- (Updated June 19, 2016, 7:11 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 48387: Delay before initiating a connection with master.

2016-06-19 Thread Jose Guilherme Vanz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48387/ --- (Updated June 19, 2016, 4:08 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 48921: Added a check of namespaces in Posix launcher.

2016-06-19 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48921/#review138475 --- src/slave/containerizer/mesos/launcher.cpp (line 94)

Re: Review Request 48921: Added a check of namespaces in Posix launcher.

2016-06-19 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48921/#review138474 --- src/slave/containerizer/mesos/launcher.cpp (line 94)

Re: Review Request 48927: Implemented DESTROY_VOLUMES Call in v1 master API.

2016-06-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48927/#review138473 --- Patch looks great! Reviews applied: [48926, 48927] Passed

Re: Review Request 48268: Implemented SET_QUOTA Call in v1 master API.

2016-06-19 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48268/ --- (Updated June 19, 2016, 5:46 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 48925: Implement GET_WEIGHTS Call in v1 master API.

2016-06-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48925/#review138472 --- LGTM except the style issue @tillt mentioned.

Re: Review Request 48924: Extract public logic of collecting weights info into _getWeights.

2016-06-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48924/#review138471 --- Fix it, then Ship it! src/master/master.hpp (line 1078)

Re: Review Request 48773: Added docs on aufs provisioning backend.

2016-06-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48773/#review138470 --- Patch looks great! Reviews applied: [48773] Passed command:

Re: Review Request 48387: Delay before initiating a connection with master.

2016-06-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48387/#review138469 --- Fix it, then Ship it! LGTM! Thank you for your patch!

Re: Review Request 45086: Enable cgroups unified isolator in isolation.

2016-06-19 Thread haosdent huang
> On June 1, 2016, 3:09 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 265 > > > > > > I think you need to handle `cgroups/devices/gpus/nvidia` which also > > starts with

Re: Review Request 45086: Enable cgroups unified isolator in isolation.

2016-06-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45086/ --- (Updated June 19, 2016, 4:50 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.

2016-06-19 Thread haosdent huang
> On June 11, 2016, 2:27 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp, lines 37-38 > > > > > > So even after we introduce the unified cgroups isolator, we still need > >

Re: Review Request 48927: Implemented DESTROY_VOLUMES Call in v1 master API.

2016-06-19 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48927/ --- (Updated June 19, 2016, 4:43 p.m.) Review request for mesos and Vinod Kone.

Review Request 48927: Implemented DESTROY_VOLUMES Call in v1 master API.

2016-06-19 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48927/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 48926: Implemented CREATE_VOLUMES Call in v1 master API.

2016-06-19 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48926/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5501

Re: Review Request 45472: Add `NetClsSubsystem` for cgroups unified isolator.

2016-06-19 Thread haosdent huang
> On June 12, 2016, 1:48 a.m., Qian Zhang wrote: > > I think in `NetClsSubsystem`, you still need a stub for the `update()` > > method, please check the following code: > > https://github.com/apache/mesos/blob/0.28.2/src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp#L461:L465 > > > >

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

2016-06-19 Thread haosdent huang
> On June 12, 2016, 1:09 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, lines 674-677 > > > > > > I see here we call `lambda::bind()`, but in the original `cgroups/mem` >

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

2016-06-19 Thread haosdent huang
> On June 15, 2016, 8:18 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, line 505 > > > > > > I can see two issues here: > > 1. `updated` is a field in subsystem level

Re: Review Request 48387: Delay before initiating a connection with master.

2016-06-19 Thread Jose Guilherme Vanz
> On June 18, 2016, 4:38 a.m., Mesos ReviewBot wrote: > > Patch looks great! > > > > Reviews applied: [48387] > > > > Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' > > COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 > > MESOS_VERBOSE=1';

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

2016-06-19 Thread haosdent huang
> On June 11, 2016, 2:12 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, lines 650-656 > > > > > > I see this method is different from the original one: > >

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

2016-06-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46158/ --- (Updated June 19, 2016, 3:55 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45085: Added stubs for the cgroups unified isolator.

2016-06-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45085/ --- (Updated June 19, 2016, 3:55 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

2016-06-19 Thread haosdent huang
> On June 15, 2016, 1:12 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, line 74 > > > > > > Can you please clarfiy why we want to have `user` as a field of `Info` > > class?

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

2016-06-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46158/ --- (Updated June 19, 2016, 3:34 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

2016-06-19 Thread haosdent huang
> On June 12, 2016, 2:51 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 351-363 > > > > > > Why do we prepare hierarchy here? I think preparing hierarchy for a > >

Re: Review Request 45085: Added stubs for the cgroups unified isolator.

2016-06-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45085/ --- (Updated June 19, 2016, 3:34 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45085: Added stubs for the cgroups unified isolator.

2016-06-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45085/ --- (Updated June 19, 2016, 3:28 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 48925: Implement GET_WEIGHTS Call in v1 master API.

2016-06-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48925/#review138458 --- Patch looks great! Reviews applied: [48924, 48925] Passed

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

2016-06-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46158/ --- (Updated June 19, 2016, 2:55 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 48773: Added docs on aufs provisioning backend.

2016-06-19 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48773/ --- (Updated June 19, 2016, 2:10 p.m.) Review request for mesos, Guangya Liu and

Re: Review Request 48773: Added docs on aufs provisioning backend.

2016-06-19 Thread Shuai Lin
> On June 16, 2016, 6:22 a.m., Guangya Liu wrote: > > docs/container-image.md, line 305 > > > > > > Community link here? Emm, I don't think it's necessary. The paragraph is copied from the docker aufs driver

Re: Review Request 48923: Updated test to expect ServiceUnavailable.

2016-06-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48923/#review138455 --- Patch looks great! Reviews applied: [48918, 48919, 48920, 48923]

Re: Review Request 48925: Implement GET_WEIGHTS Call in v1 master API.

2016-06-19 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48925/#review138453 --- Quick drive-by style review... src/master/weights_handler.cpp

Re: Review Request 45086: Enable cgroups unified isolator in isolation.

2016-06-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45086/#review138452 --- Patch looks great! Reviews applied: [45083, 45084, 46043, 45085,

Review Request 48925: Implement GET_WEIGHTS Call in v1 master API.

2016-06-19 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48925/ --- Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.

  1   2   >