Re: Review Request 49540: Used the argv version for command that launches the command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49540/#review140608 --- src/slave/slave.cpp (line 3956)

Re: Review Request 49518: Initial snapshot for v1 master event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49518/#review140606 --- Patch looks great! Reviews applied: [49464, 49465, 49487, 49488,

Re: Review Request 49518: Initial snapshot for v1 master event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49518/ --- (Updated July 4, 2016, 4:06 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49517: Implement GetState V1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49517/ --- (Updated July 4, 2016, 4:05 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49518: Initial snapshot for v1 master event stream.

> On July 3, 2016, 2:38 a.m., haosdent huang wrote: > > I think we should split the test cases for `SUBSCRIBE` instead of put all > > of them in `MasterAPITest.Subscribe` > > Zhitao Li wrote: > What do you mean here? `MasterAPITest.Subscribe` is testing `SUBSCRIBE` > to event stream, ans

Re: Review Request 49518: Initial snapshot for v1 master event stream.

> On July 3, 2016, 11:35 p.m., Vinod Kone wrote: > > src/master/http.cpp, line 596 > > > > > > why `mutable` here? Because `Connection::send` function is not `const`. > On July 3, 2016, 11:35 p.m., Vinod Kone

Re: Review Request 49582: Used the `char` version of `strings::startsWith` in mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49582/#review140603 --- Patch looks great! Reviews applied: [49581, 49582] Passed

Re: Review Request 49582: Used the `char` version of `strings::startsWith` in mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49582/#review140600 --- Ship it! Ship It! - Klaus Ma On July 4, 2016, 8:39 a.m.,

Re: Review Request 49575: Fixed `delete` usage in authorization_test.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49575/#review140598 --- Bad patch! Reviews applied: [49575, 49574, 49370, 49369] Failed

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46825/#review140597 --- Patch looks great! Reviews applied: [46821, 46822, 46823, 46824,

Review Request 49582: Used the `char` version of `strings::startsWith` in mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49582/ --- Review request for mesos and Klaus Ma. Bugs: MESOS-5692

Review Request 49581: Used the `char` version of `strings::startsWith` in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49581/ --- Review request for mesos and Klaus Ma. Bugs: MESOS-5692

Re: Review Request 49580: Updated Docker::inspect to parse devices.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49580/#review140596 --- Ship it! Ship It! - Kevin Klues On July 3, 2016, 11:44

Review Request 49580: Updated Docker::inspect to parse devices.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49580/ --- Review request for mesos and Kevin Klues. Repository: mesos Description

Re: Review Request 49579: Added container path to Docker::Device.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49579/#review140595 --- Ship it! Ship It! - Kevin Klues On July 3, 2016, 11:35

Review Request 49579: Added container path to Docker::Device.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49579/ --- Review request for mesos and Kevin Klues. Repository: mesos Description

Re: Review Request 49518: Initial snapshot for v1 master event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49518/#review140593 --- src/master/http.cpp (line 596)

Re: Review Request 49518: Initial snapshot for v1 master event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49518/#review140592 --- Patch looks great! Reviews applied: [49464, 49465, 49487, 49488,

Re: Review Request 49517: Implement GetState V1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49517/#review140591 --- Fix it, then Ship it! src/tests/api_tests.cpp (lines 560 -

Re: Review Request 49516: Refactor Master::Http::getExecutors into helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49516/#review140589 --- Ship it! Ship It! - Vinod Kone On July 1, 2016, 11:45 p.m.,

Re: Review Request 49489: Refactor master::Http::getFrameworks to helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49489/#review140587 --- Ship it! Ship It! - Vinod Kone On July 1, 2016, 11:42 p.m.,

Re: Review Request 49509: Revised protobuf definition of GetState response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49509/#review140588 --- Ship it! Ship It! - Vinod Kone On July 1, 2016, 11:43 p.m.,

Re: Review Request 49488: Refactor Master::Http::getAgents into helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49488/#review140586 --- Ship it! Looks like you fixed the issues. Not sure why you

Re: Review Request 49487: Refactor Master::Http::getTasks into helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49487/#review140584 --- Ship it! Ship It! - Vinod Kone On July 1, 2016, 11:32 p.m.,

Re: Review Request 49377: Fixed allocator to update total resources in quota sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49377/#review140577 --- src/master/allocator/mesos/hierarchical.cpp (lines 631 - 642)

Re: Review Request 49376: Added assertions to DRFSorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49376/#review140579 --- Ship it! Ship It! - Michael Park On July 3, 2016, 8:36

Re: Review Request 49518: Initial snapshot for v1 master event stream.

> On July 3, 2016, 2:38 a.m., haosdent huang wrote: > > I think we should split the test cases for `SUBSCRIBE` instead of put all > > of them in `MasterAPITest.Subscribe` > > Zhitao Li wrote: > What do you mean here? `MasterAPITest.Subscribe` is testing `SUBSCRIBE` > to event stream, ans

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/#review140574 --- Patch looks great! Reviews applied: [45958, 45959, 48616, 45960,

Re: Review Request 49575: Fixed `delete` usage in authorization_test.cpp.

> On July 3, 2016, 6:15 p.m., Vinod Kone wrote: > > Ship It! can you rebase? - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49575/#review140567

Re: Review Request 49569: Added an option to the launch helper binary to unshare mount namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49569/#review140572 --- Bad patch! Reviews applied: [49569, 49568, 49549, 49548, 49542,

Re: Review Request 49576: Fixed whitespace error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49576/#review140570 --- Ship it! Ship It! - Benjamin Mahler On July 3, 2016, 6:54

Re: Review Request 49523: Moved MESOS_CONTAINERIZER to a separate constants file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49523/#review140569 --- Ship it! Ship It! - Gilbert Song On July 1, 2016, 11:02

Re: Review Request 49479: Removed --sandbox flag from mesos-containerizer launch command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49479/#review140568 --- Ship it! Thanks for addressing the tech debt I left in Feb :)

Review Request 49576: Fixed whitespace error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49576/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 49574: Refactored /role and getRoles endpoint code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49574/#review140566 --- Ship it! Ship It! - Vinod Kone On July 3, 2016, 5:50 p.m.,

Re: Review Request 49575: Fixed `delete` usage in authorization_test.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49575/#review140567 --- Ship it! Ship It! - Vinod Kone On July 3, 2016, 5:51 p.m.,

Re: Review Request 49575: Fixed `delete` usage in authorization_test.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49575/ --- (Updated July 3, 2016, 5:51 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 49574: Refactored /role and getRoles endpoint code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49574/ --- (Updated July 3, 2016, 5:50 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 49575: Fixed `delete` usage in authorization_test.cpp.

> On July 3, 2016, 5:34 p.m., Vinod Kone wrote: > > src/tests/authorization_tests.cpp, line 2342 > > > > > > hmm. why this change. these tests expect authorization creation to > > fail, so `create` will not tbe

Re: Review Request 49575: Fixed `delete` usage in authorization_test.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49575/#review140564 --- src/tests/authorization_tests.cpp (line 2342)

Re: Review Request 49520: Fixed the flaky BusyMountPoint test.

> On July 3, 2016, 5:32 p.m., Jie Yu wrote: > > Could you please run the test to make sure there's no mount leak? - Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49520/#review140560

Re: Review Request 49520: Fixed the flaky BusyMountPoint test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49520/#review140560 --- src/tests/gc_tests.cpp (line 919)

Re: Review Request 49574: Refactored /role and getRoles endpoint code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49574/#review140562 --- src/master/http.cpp (line 2919)

Re: Review Request 49369: Introduced authorization based filtering for /roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49369/#review140561 --- Ship it! Ship It! - Vinod Kone On July 1, 2016, 2:39 p.m.,

Re: Review Request 49323: Added tests that combine the two ways of creating volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49323/#review140559 --- src/tests/persistent_volume_endpoints_tests.cpp (lines 1639 -

Review Request 49574: Refactored /role and getRoles endpoint code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49574/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5709

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46825/ --- (Updated July 3, 2016, 5:22 p.m.) Review request for mesos, Alexander

Re: Review Request 46822: Avoided slicing of flags in subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46822/ --- (Updated July 3, 2016, 5:22 p.m.) Review request for mesos, Alexander

Re: Review Request 46823: Fully qualified addresses of Flag members in add calls in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46823/ --- (Updated July 3, 2016, 5:22 p.m.) Review request for mesos, Alexander

Re: Review Request 46821: Avoided slicing of flags in subprocess in libprocess and stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46821/ --- (Updated July 3, 2016, 5:22 p.m.) Review request for mesos, Alexander

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46824/ --- (Updated July 3, 2016, 5:22 p.m.) Review request for mesos, Alexander

Re: Review Request 49442: Documented behavior when framework and master both failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49442/#review140557 --- Ship it! Ship It! - Michael Park On June 30, 2016, 1 p.m.,

Re: Review Request 49503: Fixed usage of some GMock expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49503/#review140556 --- Ship it! Ship It! - Michael Park On July 1, 2016, 10:12

Re: Review Request 49140: Added startsWith/endsWith to support char.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49140/#review140555 --- Ship it! Ship It! - Michael Park On June 26, 2016, 9:46

Re: Review Request 49246: Enhanced startsWith/endsWith's performance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49246/#review140554 --- 3rdparty/stout/include/stout/strings.hpp (lines 370 - 374)

Re: Review Request 49376: Added assertions to DRFSorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49376/ --- (Updated July 3, 2016, 8:36 a.m.) Review request for mesos, Alexander

Re: Review Request 49377: Fixed allocator to update total resources in quota sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49377/#review140552 --- Ship it! Ship It! - Alexander Rukletsov On July 1, 2016,

Re: Review Request 49376: Added assertions to DRFSorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49376/#review140551 --- Fix it, then Ship it!

Re: Review Request 49375: Simplified DRFSorter to not track per-slave total resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49375/#review140550 --- Ship it! Ship It! - Alexander Rukletsov On July 1, 2016,

Re: Review Request 49323: Added tests that combine the two ways of creating volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49323/#review140549 --- Ship it! In retrospect it seems unfortunate that we split

Re: Review Request 49517: Implement GetState V1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49517/#review140547 --- Ship it! Ship It! - haosdent huang On July 3, 2016, 7:34

Re: Review Request 49518: Initial snapshot for v1 master event stream.

> On July 3, 2016, 2:38 a.m., haosdent huang wrote: > > I think we should split the test cases for `SUBSCRIBE` instead of put all > > of them in `MasterAPITest.Subscribe` What do you mean here? `MasterAPITest.Subscribe` is testing `SUBSCRIBE` to event stream, ans `Snapshot` is not yet

Re: Review Request 49518: Initial snapshot for v1 master event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49518/ --- (Updated July 3, 2016, 7:35 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49517: Implement GetState V1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49517/ --- (Updated July 3, 2016, 7:34 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/ --- (Updated July 3, 2016, 7:29 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 49553: Fixed indentions of HealthCheck files in src/Makefile.am.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49553/#review140544 --- Ship it! Ship It! - Gilbert Song On July 2, 2016, 8:12

Re: Review Request 49554: Fixed HealthCheck typo in `launcher/executor.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49554/#review140543 --- Ship it! Ship It! - Gilbert Song On July 2, 2016, 8:12

Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/ --- Review request for mesos. Repository: mesos Description --- This

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

> On June 14, 2016, 10:50 p.m., Jiang Yan Xu wrote: > > src/master/allocator/sorter/drf/sorter.cpp, lines 457-467 > > > > > > For this we need to > > > > 1. Run existing benchmarks to see how much