Review Request 50284: Updated upgrades.md with fetcher user changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50284/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5845

Review Request 50283: Updated CHANGELOG with fetcher user changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50283/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5845

Re: Review Request 50268: Target shutdownFramework to associated agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50268/#review143053 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 50223: Separate AuthN for readonly and readwrite endpoints in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50223/ --- (Updated July 21, 2016, 4:33 a.m.) Review request for mesos, Adam B, Benjamin

Review Request 50280: Simplificed removing whitspace by strings::replace().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50280/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 49239: Added logging when Offer::Operation::Launch has no tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49239/ --- (Updated July 21, 2016, 1:04 a.m.) Review request for mesos and Anand

Review Request 50281: Added logging when Offer::Operation::Launch has no tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50281/ --- Review request for mesos. Repository: mesos Description --- The

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

> On July 18, 2016, 2:24 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, line 307 > > > > > > I think here you need to call `onAny()` rather than `then()`. You can > > take

Re: Review Request 50259: Updated docker recovery to use abstraction provided by docker inspect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50259/#review143045 --- Bad patch! Reviews applied: [50259, 50258, 50128, 50127, 50126,

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

> On July 18, 2016, 2:24 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, line 307 > > > > > > I think here you need to call `onAny()` rather than `then()`. You can > > take

Re: Review Request 50062: Refactored `makePortRanges` for allocator benchmark test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50062/ --- (Updated 七月 21, 2016, 2:07 a.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/ --- (Updated July 21, 2016, 1:38 a.m.) Review request for mesos, Greg Mann and

Re: Review Request 50223: Separate AuthN for readonly and readwrite endpoints in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50223/ --- (Updated July 21, 2016, 1:25 a.m.) Review request for mesos, Adam B, Benjamin

Review Request 50277: Separate readonly and readwrite realms in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50277/ --- Review request for mesos, Adam B, Benjamin Bannier, Greg Mann, and Till

Re: Review Request 50260: Documented the executor envirment variable 'MESOS_SANDBOX'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50260/ --- (Updated July 20, 2016, 5:58 p.m.) Review request for mesos, Artem

Re: Review Request 50254: Added an example test for the V0/V1 Mesos java implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50254/#review143039 --- Patch looks great! Reviews applied: [50247, 50248, 50250, 50251,

Re: Review Request 48616: Add v1 changes for shared resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48616/ --- (Updated July 21, 2016, 12:13 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

> On July 20, 2016, 2:36 a.m., Klaus Ma wrote: > > include/mesos/resources.hpp, line 124 > > > > > > Seems `Option` is not necessary. sharedCount is None when it is is regular non-shared resource, and is an

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45959/ --- (Updated July 21, 2016, 12:12 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/#review143034 --- @Shuai, did you pull the master upstream before rebasing? -

Re: Review Request 43561: Improve Ranges parsing to handle single values.

> On March 21, 2016, 2:02 p.m., Joris Van Remoortere wrote: > > src/common/values.cpp, line 613 > > > > > > @benm I wish we had support for iterating over these splicers eg: > > `foreachtoken(temp, ",\n",

Re: Review Request 43561: Improve Ranges parsing to handle single values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/#review143031 --- Can you rebase this on top of

Re: Review Request 49223: Fixed Value parsing code to only accept the canonical formats.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49223/#review143028 --- Sorry for the delay, mostly some bugs around use of tokenize

Re: Review Request 50261: Updated allocator test helper function `makeLabels` more readable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50261/#review143026 --- Ship it! Nice cleanup, thanks for following up on my email

Re: Review Request 50200: Made the agent fetch files as the task user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50200/ --- (Updated July 20, 2016, 11:02 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 50199: Refactored fetcher cache directory creation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50199/ --- (Updated July 20, 2016, 11:01 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 50199: Refactored fetcher cache directory creation.

> On July 20, 2016, 10:26 p.m., Jie Yu wrote: > > src/launcher/fetcher.cpp, lines 512-514 > > > > > > Can we instead use: > > ``` > > CHECK_SOME(createCacheDirectory(fetcherInfo.get())) > > << "..."; >

Re: Review Request 50200: Made the agent fetch files as the task user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50200/#review143022 --- Fix it, then Ship it! src/launcher/fetcher.cpp (lines 513 -

Re: Review Request 50199: Refactored fetcher cache directory creation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50199/#review142997 --- Fix it, then Ship it! src/launcher/fetcher.cpp (lines 506 -

Review Request 50269: Added basic tests for capabilities API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50269/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5228

Review Request 50266: Introduced linux capabilities API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50266/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5051

Re: Review Request 50268: Target shutdownFramework to associated agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50268/ --- (Updated July 20, 2016, 10:09 p.m.) Review request for mesos. Bugs:

Re: Review Request 50268: Target shutdownFramework to associated agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50268/ --- (Updated July 20, 2016, 10:08 p.m.) Review request for mesos. Repository:

Re: Review Request 50199: Refactored fetcher cache directory creation.

> On July 20, 2016, 10:06 p.m., Joerg Schad wrote: > > src/launcher/fetcher.cpp, line 441 > > > > > > Can it happen that dir already exists? Indeed it can! While we were safe with the existing code, I tweaked this

Re: Review Request 50199: Refactored fetcher cache directory creation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50199/ --- (Updated July 20, 2016, 10:07 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 50199: Refactored fetcher cache directory creation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50199/#review143011 --- src/launcher/fetcher.cpp (line 435)

Review Request 50268: Target shutdownFramework to associated agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50268/ --- Review request for mesos. Repository: mesos Description --- Target

Re: Review Request 50267: Updated upgrades.md about deprecated SSL env variables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50267/#review143018 --- Fix it, then Ship it! docs/upgrades.md (line 182)

Re: Review Request 49239: Added logging when Offer::Operation::Launch has no tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49239/#review143016 --- Sorry for the late turn around on this one.

Re: Review Request 50257: Used LIBPROCESS_SSL_ instead of SSL_ as the prefix for ssl support.

> On July 20, 2016, 9:39 p.m., Adam B wrote: > > Won't this break upgrades for any user already using these environment > > variables?!? > > Adam B wrote: > Nevermind.. premature panic. Now I see > ``` > // To be backward compatible, for each environment variable prefixed >

Review Request 50265: Updated 1.0 CHANGELOG about an SSL fix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50265/ --- Review request for mesos, Joris Van Remoortere and Vinod Kone. Repository:

Re: Review Request 50257: Used LIBPROCESS_SSL_ instead of SSL_ as the prefix for ssl support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50257/#review143010 --- Won't this break upgrades for any user already using these

Re: Review Request 50257: Used LIBPROCESS_SSL_ instead of SSL_ as the prefix for ssl support.

> On July 20, 2016, 9:39 p.m., Adam B wrote: > > Won't this break upgrades for any user already using these environment > > variables?!? > > Adam B wrote: > Nevermind.. premature panic. Now I see > ``` > // To be backward compatible, for each environment variable prefixed >

Re: Review Request 50257: Used LIBPROCESS_SSL_ instead of SSL_ as the prefix for ssl support.

> On July 20, 2016, 2:39 p.m., Adam B wrote: > > Won't this break upgrades for any user already using these environment > > variables?!? Nevermind.. premature panic. Now I see ``` // To be backward compatible, for each environment variable prefixed // by SSL_, we generate the corresponding

Re: Review Request 50223: Separate AuthN for readonly and readwrite endpoints in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50223/#review143008 --- Patch looks great! Reviews applied: [50223] Passed command:

Review Request 50261: Updated allocator test helper function `makeLabels` more readable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50261/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 50262: Updated the document about SSL env variables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50262/#review143003 --- Fix it, then Ship it! docs/ssl.md (line 24)

Review Request 50262: Updated the document about SSL env variables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50262/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-5863

Re: Review Request 50257: Used LIBPROCESS_SSL_ instead of SSL_ as the prefix for ssl support.

> On July 20, 2016, 9 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/src/openssl.cpp, line 312 > > > > > > Don't forget the change the documentation too! It's reportedly on it's way. Has to be a separate patch

Re: Review Request 50257: Used LIBPROCESS_SSL_ instead of SSL_ as the prefix for ssl support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50257/#review143000 --- 3rdparty/libprocess/src/openssl.cpp (line 312)

Re: Review Request 50257: Used LIBPROCESS_SSL_ instead of SSL_ as the prefix for ssl support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50257/#review142996 --- Fix it, then Ship it! 3rdparty/libprocess/src/openssl.cpp

Re: Review Request 50200: Made the agent fetch files as the task user.

> On July 20, 2016, 5:45 p.m., Gilbert Song wrote: > > src/tests/fetcher_tests.cpp, line 107 > > > > > > `nobody` seems safe enough since it should exist in all Unix system. > > Joseph Wu wrote: > Side note:

Re: Review Request 50257: Used LIBPROCESS_SSL_ instead of SSL_ as the prefix for ssl support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50257/ --- (Updated July 20, 2016, 8:34 p.m.) Review request for mesos and Joris Van

Re: Review Request 48693: Added tests for `UUID::fromString`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48693/#review142994 --- Ship it! Ship It! - Anand Mazumdar On June 21, 2016, 12:14

Re: Review Request 48692: Cleaned up header includes in stout/uuid.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48692/#review142993 --- Ship it! LGTM though I can understand why it was done

Re: Review Request 50199: Refactored fetcher cache directory creation.

> On July 20, 2016, 8:14 a.m., Joerg Schad wrote: > > src/launcher/fetcher.cpp, line 514 > > > > > > I personally would still use this cacheDirectory as parameter to > > createCacheDirectory for the following

Re: Review Request 50200: Made the agent fetch files as the task user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50200/ --- (Updated July 20, 2016, 8:01 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50249: Modified 'agent' to accecpt request with charset in Content-Type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50249/#review142991 --- Patch looks great! Reviews applied: [50246, 50249] Passed

Re: Review Request 50199: Refactored fetcher cache directory creation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50199/ --- (Updated July 20, 2016, 7:50 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50199: Refactored fetcher cache directory creation.

> On July 20, 2016, 8:14 a.m., Joerg Schad wrote: > > src/launcher/fetcher.cpp, line 436 > > > > > > Do we really want to check and fail on this condition? In the previous > > iteration you would have skipped

Review Request 50259: Updated docker recovery to use abstraction provided by docker inspect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50259/ --- Review request for mesos, Benjamin Mahler, Kevin Klues, Yubo Li, and Vikrama

Review Request 50260: Documented the executor envirment variable 'MESOS_SANDBOX'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50260/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.

Review Request 50258: Updated docker recovery to account for GPU resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50258/ --- Review request for mesos, Benjamin Mahler, Kevin Klues, Yubo Li, and Vikrama

Review Request 50254: Added an example test for the V0/V1 Mesos java implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50254/ --- Review request for mesos, Joris Van Remoortere and Vinod Kone. Bugs:

Review Request 50253: Added native implementation for the V0 Mesos Adapter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50253/ --- Review request for mesos, Joris Van Remoortere and Vinod Kone. Bugs:

Review Request 50251: Added java implementations for the V0/V1 implementation for Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50251/ --- Review request for mesos, Joris Van Remoortere and Vinod Kone. Bugs:

Review Request 50252: Added native implementation for v1 Mesos interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50252/ --- Review request for mesos, Joris Van Remoortere and Vinod Kone. Bugs:

Review Request 50250: Added v1 Scheduler/Mesos interface in Java.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50250/ --- Review request for mesos, Joris Van Remoortere and Vinod Kone. Bugs:

Review Request 50247: Added a abstract base class for scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50247/ --- Review request for mesos, Joris Van Remoortere and Vinod Kone. Repository:

Review Request 50248: Added helper functions for v1 JNI `construct()`/`convert()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50248/ --- Review request for mesos, Joris Van Remoortere and Vinod Kone. Bugs:

Review Request 50257: Used LIBPROCESS_SSL_ instead of SSL_ as the prefix for ssl support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50257/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-5863

Re: Review Request 49814: Implemented `CgroupsIsolatorProcess::create`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49814/ --- (Updated July 20, 2016, 6:36 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49825: Implemented `CgroupsIsolatorProcess::status`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49825/ --- (Updated July 20, 2016, 6:39 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49824: Implemented `CgroupsIsolatorProcess::usage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49824/ --- (Updated July 20, 2016, 6:38 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49823: Implemented `CgroupsIsolatorProcess::update`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49823/ --- (Updated July 20, 2016, 6:38 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49821: Implemented `CgroupsIsolatorProcess::watch`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49821/ --- (Updated July 20, 2016, 6:38 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49820: Implemented `CgroupsIsolatorProcess::isolate`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49820/ --- (Updated July 20, 2016, 6:37 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/ --- (Updated July 20, 2016, 6:37 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49817/ --- (Updated July 20, 2016, 6:36 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50223: Separate AuthN for readonly and readwrite endpoints in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50223/#review142977 --- src/master/flags.cpp (lines 225 - 226)

Review Request 50249: Modified 'agent' to accecpt request with charset in Content-Type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50249/ --- Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.

Re: Review Request 50246: Modified 'master' to accecpt request with charset in Content-Type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50246/ --- (Updated July 20, 2016, 6:11 p.m.) Review request for mesos, Anand Mazumdar,

Review Request 50246: Modified 'master' to accecpt request with charset in Content-Type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50246/ --- Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.

Re: Review Request 49348: Added implementation to Appc Runtime Isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49348/#review142978 --- Ship it! This is great. Thanks, Srini! - Gilbert Song On

Re: Review Request 50200: Made the agent fetch files as the task user.

> On July 20, 2016, 10:45 a.m., Gilbert Song wrote: > > src/tests/fetcher_tests.cpp, line 107 > > > > > > `nobody` seems safe enough since it should exist in all Unix system. Side note: one of our tests creates a

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/#review142975 --- Fix it, then Ship it!

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review142973 --- src/local/flags.hpp (line 50)

Re: Review Request 50200: Made the agent fetch files as the task user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50200/#review142972 --- Fix it, then Ship it! src/tests/fetcher_tests.cpp (line 107)

Re: Review Request 50177: Add systemd watchdog support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50177/#review142968 --- Overall it LGTM. configure.ac (line 615)

Re: Review Request 46626: Added example framework for testing disk quota enforcement.

> On July 19, 2016, 1:40 p.m., Joseph Wu wrote: > > LGTM, modulo the examples tests patch, which is presumably coming up next :) https://reviews.apache.org/r/50217/ - Artem --- This is an automatically generated e-mail. To reply,

Re: Review Request 50223: Separate AuthN for readonly and readwrite endpoints in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50223/ --- (Updated July 20, 2016, 3:21 p.m.) Review request for mesos, Adam B, Benjamin

Review Request 50235: Added more expectations to TASK_LOST test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50235/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 50235: Added more expectations to TASK_LOST test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50235/ --- (Updated July 20, 2016, 3:07 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review142928 --- Patch looks great! Reviews applied: [50002, 50003] Passed

Re: Review Request 49955: Disabled the `--registry_strict` master flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49955/ --- (Updated July 20, 2016, 1:01 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 49955: Disabled the `--registry_strict` master flag.

> On July 19, 2016, 10:56 p.m., Vinod Kone wrote: > > src/master/flags.cpp, line 86 > > > > > > // TODO(neilc): This flag is deprecated in 1.0 and will be removed 6 > > months later. I used the text "This flag is

Re: Review Request 49955: Disabled the `--registry_strict` master flag.

> On July 15, 2016, 7:26 p.m., Benjamin Mahler wrote: > > Could we clarify the description a bit? I'm having a hard time convincing > > myself that this makes sense in the world we'd like to move to. > > > > The strict flag was not intended as a mechanims for ensuring that > > partitioned

Re: Review Request 50017: Do not validate resource when add/subtract `Resources` object.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50017/#review142920 --- Patch looks great! Reviews applied: [50017] Passed command:

Re: Review Request 50208: Fixed a file descriptor leak bug while reading file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50208/#review142918 --- Patch looks great! Reviews applied: [50184, 50208] Passed

Re: Review Request 50199: Refactored fetcher cache directory creation.

> On July 20, 2016, 8:14 a.m., Joerg Schad wrote: > > src/launcher/fetcher.cpp, line 436 > > > > > > Do we really want to check and fail on this condition? In the previous > > iteration you would have skipped

  1   2   >