Review Request 54363: Added a test to ensure multi-role framework being removed properly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54363/ --- Review request for mesos, Benjamin Mahler, Guangya Liu, and Qian Zhang. Bugs:

Review Request 54362: Changed master to remove roles for a multi-role framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54362/ --- Review request for mesos, Benjamin Mahler, Guangya Liu, and Qian Zhang. Bugs:

Re: Review Request 54361: Added a test to ensure roles from multi-role framework are added.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54361/#review157965 --- Patch looks great! Reviews applied: [54359, 54360, 54361]

Re: Review Request 54356: Added implementation of `watch()` to the 'IOSwitchboard' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54356/ --- (Updated Dec. 5, 2016, 7:19 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 54355: Added implementation of `recover()` to the IOSwitchboard isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54355/ --- (Updated Dec. 5, 2016, 7:11 a.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 54356: Added implementation of `watch()` to the 'IOSwitchboard' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54356/ --- (Updated Dec. 5, 2016, 7:11 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 54354: Added path helpers for checkpointing the io switchboard pid.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54354/ --- (Updated Dec. 5, 2016, 7:10 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 54356: Added implementation of `watch()` to the 'IOSwitchboard' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54356/ --- (Updated Dec. 5, 2016, 7:10 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 54355: Added implementation of `recover()` to the IOSwitchboard isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54355/ --- (Updated Dec. 5, 2016, 7:10 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 54352: Added removal of unix domain socket path in IOSwitchboard::cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54352/ --- (Updated Dec. 5, 2016, 7:10 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54297/ --- (Updated Dec. 5, 2016, 7:09 a.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 54353: Added short circuit for `local` mode in `IOSwitchboard::connect()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54353/ --- (Updated Dec. 5, 2016, 7:10 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 54347: Cleaned up the 'IOSwitchboard.RedirectLog' test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54347/ --- (Updated Dec. 5, 2016, 7:09 a.m.) Review request for mesos and Anand Mazumdar.

Re: Review Request 54348: Fixed small bug in `IOSwitchboardServerProcess::acceptLoop()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54348/ --- (Updated Dec. 5, 2016, 7:09 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 54344: Added `setWindowSize()` to stout for setting a TTY's window size.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54344/ --- (Updated Dec. 5, 2016, 7:09 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 54344: Added `setWindowSize()` to stout for setting a TTY's window size.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54344/ --- (Updated Dec. 5, 2016, 7:06 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/#review157765 --- Ship it! I can take care of the addressing remaining minor

Re: Review Request 54361: Added a test to ensure roles from multi-role framework are added.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54361/ --- (Updated Dec. 5, 2016, 6:13 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 54354: Added path helpers for checkpointing the io switchboard pid.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54354/#review157963 --- Ship it! Ship It! - Jie Yu On Dec. 5, 2016, 12:38 a.m.,

Re: Review Request 54353: Added short circuit for `local` mode in `IOSwitchboard::connect()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54353/#review157962 --- Ship it! Ship It! - Jie Yu On Dec. 5, 2016, 12:38 a.m.,

Re: Review Request 54352: Added removal of unix domain socket path in IOSwitchboard::cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54352/#review157961 --- src/slave/containerizer/mesos/io/switchboard.cpp (lines 407 -

Re: Review Request 54294: Added an I/O switchboard test with TTY enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54294/ --- (Updated Dec. 5, 2016, 5:38 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 54293: Supported TTY in I/O switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54293/ --- (Updated Dec. 5, 2016, 5:37 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 54351: Allowed subprocess to take duplicated FDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54351/ --- (Updated Dec. 5, 2016, 5:36 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 54350: Added a DUP2 child hook to Subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54350/ --- (Updated Dec. 5, 2016, 5:36 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 54349: Added os::dup2 to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54349/ --- (Updated Dec. 5, 2016, 5:36 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 54292: Added os::setctty to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54292/ --- (Updated Dec. 5, 2016, 5:35 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 54289: Added a check to require I/O switchboard server for TTY support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54289/ --- (Updated Dec. 5, 2016, 5:33 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 54291: Added os::ptsname to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54291/ --- (Updated Dec. 5, 2016, 5:34 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 54290: Added a ErrnoFailure similar to ErrnoError.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54290/ --- (Updated Dec. 5, 2016, 5:34 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 54294: Added an I/O switchboard test with TTY enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54294/#review157960 --- Ship it! Ship It! - Kevin Klues On Dec. 5, 2016, 12:17

Re: Review Request 54293: Supported TTY in I/O switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54293/#review157959 --- Ship it! Ship It! - Kevin Klues On Dec. 4, 2016, 9:21 p.m.,

Re: Review Request 54294: Added an I/O switchboard test with TTY enabled.

> On Dec. 5, 2016, 2:10 a.m., Kevin Klues wrote: > > src/tests/containerizer/io_switchboard_tests.cpp, lines 308-309 > > > > > > Why not put this at the top with the other declaration for > >

Re: Review Request 54293: Supported TTY in I/O switchboard.

> On Dec. 5, 2016, 2:02 a.m., Kevin Klues wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp, line 248 > > > > > > Can you add a comment here about the difference between the two > > hashsets? Reading top

Re: Review Request 54351: Allowed subprocess to take duplicated FDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54351/#review157955 --- Ship it! The changes all make sense, but I agree with Kevin

Review Request 54359: Removed redundant empty statements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54359/ --- Review request for mesos, Benjamin Mahler and Guangya Liu. Repository: mesos

Review Request 54360: Changed master to add roles for a multi-role framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54360/ --- Review request for mesos, Benjamin Mahler, Guangya Liu, and Qian Zhang. Bugs:

Review Request 54361: Added a test to ensure roles from multi-role framework are added.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54361/ --- Review request for mesos, Benjamin Mahler, Guangya Liu, and Qiang Zhang. Bugs:

Re: Review Request 54351: Allowed subprocess to take duplicated FDs.

> On Dec. 5, 2016, 1:36 a.m., Kevin Klues wrote: > > 3rdparty/libprocess/src/subprocess.cpp, lines 330-344 > > > > > > I feel like moving this into the windows `createChildProcess()` > > function would make it more

Re: Review Request 54291: Added os::ptsname to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54291/#review157953 --- Ship it! Ship It! - Kevin Klues On Dec. 2, 2016, 6:29 p.m.,

Re: Review Request 54350: Added a DUP2 child hook to Subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54350/#review157952 --- Ship it! Ship It! - Benjamin Hindman On Dec. 4, 2016, 9:18

Re: Review Request 54292: Added os::setctty to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54292/#review157951 --- Ship it! Ship It! - Kevin Klues On Dec. 2, 2016, 6:29 p.m.,

Re: Review Request 54351: Allowed subprocess to take duplicated FDs.

> On Dec. 5, 2016, 1:36 a.m., Kevin Klues wrote: > > 3rdparty/libprocess/include/process/posix/subprocess.hpp, lines 332-384 > > > > > > Is this move actually related to this commit, or is it just an existing > >

Re: Review Request 54349: Added os::dup2 to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54349/#review157949 --- Ship it! Ship It! - Benjamin Hindman On Dec. 4, 2016, 9:17

Re: Review Request 54291: Added os::ptsname to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54291/#review157948 --- Ship it! Adding the TODO for `ptsname_r` on Linux SGTM as well

Re: Review Request 54349: Added os::dup2 to stout.

> On Dec. 5, 2016, 1:02 a.m., Kevin Klues wrote: > > Should we add an equivalent function for windows? I assume we will need one > > to make any child hooks we add to `Subprocess` cross platform. dup is posix specific. i think we will have posix specific hooks anyway (e.g., supervised and

Re: Review Request 54290: Added a ErrnoFailure similar to ErrnoError.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54290/#review157946 --- Ship it! Ship It! - Benjamin Hindman On Dec. 2, 2016, 6:29

Re: Review Request 54289: Added a check to require I/O switchboard server for TTY support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54289/#review157945 --- Ship it! Ship It! - Benjamin Hindman On Dec. 2, 2016, 6:29

Re: Review Request 54295: Added a synchronous version of loop for io::read/write/redirect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54295/ --- (Updated Dec. 5, 2016, 4:35 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 54291: Added os::ptsname to stout.

> On Dec. 2, 2016, 9:16 a.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/posix/os.hpp, line 480 > > > > > > We should be able to use a simple function-local static here and avoid > > the global leak

Re: Review Request 54356: Added implementation of `watch()` to the 'IOSwitchboard' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54356/#review157941 --- Patch looks great! Reviews applied: [54352, 54353, 54354, 54355,

Re: Review Request 54294: Added an I/O switchboard test with TTY enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54294/#review157939 --- src/tests/containerizer/io_switchboard_tests.cpp (lines 307 -

Re: Review Request 54293: Supported TTY in I/O switchboard.

> On Dec. 5, 2016, 2:02 a.m., Kevin Klues wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp, line 248 > > > > > > Can you add a comment here about the difference between the two > > hashsets? Reading top

Re: Review Request 54293: Supported TTY in I/O switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54293/#review157937 --- src/slave/containerizer/mesos/io/switchboard.hpp (line 126)

Re: Review Request 54351: Allowed subprocess to take duplicated FDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54351/#review157936 --- 3rdparty/libprocess/include/process/posix/subprocess.hpp (line

Re: Review Request 54350: Added a DUP2 child hook to Subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54350/#review157935 --- Ship it! Ship It! - Kevin Klues On Dec. 4, 2016, 9:18 p.m.,

Re: Review Request 54349: Added os::dup2 to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54349/#review157934 --- Ship it! Should we add an equivalent function for windows? I

Re: Review Request 54344: Added `setWindowSize()` to stout for setting a TTY's window size.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54344/ --- (Updated Dec. 5, 2016, 12:41 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 54352: Added removal of unix domain socket path in IOSwitchboard::cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54352/ --- (Updated Dec. 5, 2016, 12:39 a.m.) Review request for mesos and Jie Yu.

Review Request 54356: Added implementation of `watch()` to the 'IOSwitchboard' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54356/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6663

Review Request 54352: Added removal of unix domain socket path in IOSwitchboard::cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54352/ --- Review request for mesos and Jie Yu. Bugs: 6689

Review Request 54354: Added path helpers for checkpointing the io switchboard pid.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54354/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6688

Review Request 54355: Added implementation of `recover()` to the IOSwitchboard isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54355/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6688

Review Request 54353: Added short circuit for `local` mode in `IOSwitchboard::connect()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54353/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 54294: Added an I/O switchboard test with TTY enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54294/ --- (Updated Dec. 5, 2016, 12:17 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 54351: Allowed subprocess to take duplicated FDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54351/ --- (Updated Dec. 5, 2016, 12:16 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 54293: Supported TTY in I/O switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54293/ --- (Updated Dec. 4, 2016, 9:21 p.m.) Review request for mesos, Benjamin Hindman

Review Request 54351: Allowed subprocess to take duplicated FDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54351/ --- Review request for mesos, Benjamin Hindman and Kevin Klues. Bugs: MESOS-6470

Review Request 54350: Added a DUP2 child hook to Subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54350/ --- Review request for mesos, Benjamin Hindman and Kevin Klues. Bugs: MESOS-6470

Review Request 54349: Added os::dup2 to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54349/ --- Review request for mesos, Benjamin Hindman and Kevin Klues. Bugs: MESOS-6470

Re: Review Request 54013: Added user doc for nested container and task group.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54013/#review157928 --- Fix it, then Ship it! LGTM.

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54297/ --- (Updated Dec. 4, 2016, 7:17 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 54348: Fixed small bug in `IOSwitchboardServerProcess::acceptLoop()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54348/#review157929 --- Ship it! Ship It! - Jie Yu On Dec. 4, 2016, 7:35 a.m.,

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54297/#review157925 --- Fix it, then Ship it! I would file a follow up issue to add

Re: Review Request 54013: Added user doc for nested container and task group.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54013/#review157927 --- Gilbert, can you add [~neilc] as a reviewer too? - Anand

Re: Review Request 54013: Added user doc for nested container and task group.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54013/#review157926 --- docs/nested-container-and-task-group.md (line 303)