Re: Review Request 55604: CMake: Transitioned Libprocess to automatic source grouping.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55604/#review161824 --- Patch looks great! Reviews applied: [55022, 55023, 55024, 55030,

Re: Review Request 55604: CMake: Transitioned Libprocess to automatic source grouping.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55604/ --- (Updated Jan. 17, 2017, 6:42 a.m.) Review request for mesos, Andrew

Re: Review Request 55601: CMake: Added source groups for agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55601/ --- (Updated Jan. 17, 2017, 6:41 a.m.) Review request for mesos, Andrew

Re: Review Request 55602: CMake: Added source groups for master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55602/ --- (Updated Jan. 17, 2017, 6:41 a.m.) Review request for mesos, Andrew

Re: Review Request 55600: CMake: Transitioned Stout to automatic source grouping.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55600/ --- (Updated Jan. 17, 2017, 6:41 a.m.) Review request for mesos, Andrew

Review Request 55604: CMake: Transitioned Libprocess to automatic source grouping.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55604/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.

Re: Review Request 55602: CMake: Added source groups for master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55602/#review161818 --- Patch looks great! Reviews applied: [55022, 55023, 55024, 55030,

Review Request 55602: CMake: Added source groups for master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55602/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.

Review Request 55601: CMake: Added source groups for agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55601/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.

Review Request 55600: CMake: Transitioned Stout to automatic source grouping.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55600/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.

Review Request 55599: CMake: Added `GroupSource` function to automate IDE source grouping.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55599/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.

Re: Review Request 55480: Fix segfault when the executor sets a UUID that is not a valid v4 UUID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55480/#review161805 --- Patch looks great! Reviews applied: [55480] Passed command:

Re: Review Request 55480: Fix segfault when the executor sets a UUID that is not a valid v4 UUID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55480/ --- (Updated Jan. 16, 2017, 8:47 p.m.) Review request for mesos and Anand

Re: Review Request 55464: Made the Agent API able to handle containers nested at arbitrary levels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55464/#review161753 --- Looks good for the most part! Mostly minor cleanup comments.

Re: Review Request 55576: Fixes FutureTest.After3 flakiness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55576/#review161752 --- Patch looks great! Reviews applied: [55576] Passed command:

Re: Review Request 55480: Fix segfault when the executor sets a UUID that is not a valid v4 UUID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55480/#review161750 --- src/tests/executor_http_api_tests.cpp (line 635)

Re: Review Request 55456: Fixed include order in "launcher/executor.cpp".

> On Jan. 13, 2017, 12:33 p.m., Gastón Kleiman wrote: > > src/launcher/executor.cpp, line 82 > > > > > > According to our style guide, this should be the first include =) Good catch! - Alexander

Re: Review Request 55271: Disallow multi-role frameworks to change their roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55271/#review161737 --- Patch looks great! Reviews applied: [55381, 55571, 55271]

Re: Review Request 55576: Fixes FutureTest.After3 flakiness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55576/ --- (Updated Jan. 16, 2017, 3:34 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 55576: Fixes FutureTest.After3 flakiness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55576/ --- (Updated Jan. 16, 2017, 3:34 p.m.) Review request for mesos, Benjamin Bannier,

Review Request 55576: Fixes FutureTest.After3 flakiness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55576/ --- Review request for mesos, Benjamin Bannier, Benjamin Hindman, and Joris Van

Re: Review Request 55461: Made resource reservation validation multi-role aware.

> On Jan. 13, 2017, 4:15 p.m., Jay Guo wrote: > > src/master/master.cpp, lines 3944-3950 > > > > > > I think we explicitly disallow empyt role field? > >

Re: Review Request 55563: Added capabilities to master's Slave struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55563/#review161726 --- Patch looks great! Reviews applied: [55561, 55562, 55563]

Re: Review Request 55461: Made resource reservation validation multi-role aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55461/ --- (Updated Jan. 16, 2017, 1:27 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 55461: Made resource reservation validation multi-role aware.

> On Jan. 13, 2017, 9:15 a.m., Jay Guo wrote: > > src/master/master.cpp, lines 3944-3950 > > > > > > I think we explicitly disallow empyt role field? > >

Re: Review Request 55271: Disallow multi-role frameworks to change their roles.

> On Jan. 16, 2017, 5:58 a.m., Jay Guo wrote: > > src/master/master.cpp, line 2478 > > > > > > I think we don't necessarily have `framework` here if framework > > information hasn't been reconstructed from agent

Re: Review Request 55271: Disallow multi-role frameworks to change their roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55271/ --- (Updated Jan. 16, 2017, 12:28 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 55255: Added a test to check 'roles' is included in the `/state`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55255/#review161711 --- Patch looks great! Reviews applied: [55252, 55253, 55254, 55255]

Review Request 55571: Changed Master::Framework::updateFrameworkInfo so it can return errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55571/ --- Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu. Bugs:

Re: Review Request 55381: Added test for framework upgrading to multi-role capability.

> On Jan. 16, 2017, 12:37 p.m., Jay Guo wrote: > > src/tests/master_validation_tests.cpp, line 2559 > > > > > > I think this test is not valid since we currently don't have logic to > > check framework upgrade

Re: Review Request 55271: Disallow multi-role frameworks to change their roles.

> On Jan. 16, 2017, 12:58 p.m., Jay Guo wrote: > > src/master/master.cpp, lines 2491-2492 > > > > > > Note that you could use `framework.capabilities` here since > > https://reviews.apache.org/r/55021/ is landed.

Re: Review Request 55271: Disallow multi-role frameworks to change their roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55271/ --- (Updated Jan. 16, 2017, 10:54 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 55381: Added test for framework upgrading to multi-role capability.

> On Jan. 16, 2017, 5:37 a.m., Jay Guo wrote: > > src/tests/master_validation_tests.cpp, line 2559 > > > > > > I think this test is not valid since we currently don't have logic to > > check framework upgrade yet.

Re: Review Request 55271: Disallow multi-role frameworks to change their roles.

> On Jan. 16, 2017, 5:58 a.m., Jay Guo wrote: > > I wonder how we deal with default role `*` in multi-role scenario? I > > remember that we require `*` to be explicitly specified for a multi-role > > framework, is that still true? This is not how I read the design doc, but this is only

Re: Review Request 55271: Disallow multi-role frameworks to change their roles.

> On Jan. 14, 2017, 10:04 p.m., Guangya Liu wrote: > > src/master/master.cpp, line 2490 > > > > > > I think that you may want to > > ``` > > #include > > ``` This is already added as part of this

Review Request 55563: Added capabilities to master's Slave struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55563/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Guangya Liu.

Review Request 55562: Added Capability field to SlaveInfo protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55562/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Guangya Liu.

Re: Review Request 55562: Added Capability field to SlaveInfo protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55562/ --- (Updated Jan. 16, 2017, 5:35 p.m.) Review request for mesos, Benjamin Bannier,

Review Request 55561: Removed an unused variable in test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55561/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 55541: Replaced (another) recursive implementation with process::loop.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55541/#review161696 --- Fix it, then Ship it! 3rdparty/libprocess/src/http.cpp (line

Re: Review Request 55539: Replaced recursive implementation in http::Connection with loop.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55539/#review161697 --- Ship it! Ship It! - Alexander Rukletsov On Jan. 14, 2017,

Re: Review Request 55540: Re-enabled disabled test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55540/#review161694 --- src/tests/containerizer/io_switchboard_tests.cpp (line 465)