Re: Review Request 56270: Made the default executor launch multiple task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56270/#review164094 --- Patch looks great! Reviews applied: [56267, 56268, 56269, 56270]

Review Request 56268: Made `kill()` not invoke `shutdown()` in the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56268/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6296

Review Request 56270: Made the default executor launch multiple task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56270/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6296

Review Request 56267: Made `kill` not use pipelining in the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56267/ --- Review request for mesos and Vinod Kone. Bugs: mesos-6296

Re: Review Request 56251: Tightened assertions in sorter and allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56251/#review164067 --- Bad patch! Reviews applied: [56251, 56250, 56249, 56248, 56247,

Re: Review Request 55910: Prevent unintended mutation in the allocator.

> On Jan. 30, 2017, 8:34 p.m., Michael Park wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 387-391 > > > > > > Not yours, but do you know what's going on here? > > The comment doesn't seem to

Re: Review Request 55910: Prevent unintended mutation in the allocator.

> On Jan. 30, 2017, 3:31 p.m., Benjamin Bannier wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 128 > > > > > > nit: This could be set in the member declaration. Hm.. is that something we do? Most of

Re: Review Request 55910: Prevent unintended mutation in the allocator.

> On Jan. 27, 2017, 7:13 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 237-241 > > > > > > Just a nit here: It seems a bit strange to me here of getting roles as > > following: > >

Re: Review Request 55868: Cleanups to the allocator tests.

> On Jan. 26, 2017, 5:14 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 1950 > > > > > > Any reason you want to update here? This was a case where it was safe to use EXPECT instead

Re: Review Request 55863: Introduce a helper for injecting AllocationInfo into offer operations.

> On Jan. 30, 2017, 1:23 a.m., Michael Park wrote: > > src/common/protobuf_utils.cpp, lines 332-335 > > > > > > Is there a reason why we don't just mutate it in-place? > > ```cpp > > void

Re: Review Request 55863: Introduce a helper for injecting AllocationInfo into offer operations.

> On Jan. 28, 2017, 11:02 a.m., Guangya Liu wrote: > > src/common/protobuf_utils.cpp, lines 345-347 > > > > > > Since we do not support one `Resources` store a mix of allocated and > > unallocated resources, how

Review Request 56251: Tightened assertions in sorter and allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56251/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 56249: Cleaned up code style slightly in DRF sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56249/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 56248: Replaced use of ".get()" in master quota tests with "->".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56248/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 56247: Switched to implicit roles in master quota tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56247/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 56245: Fixed typos in name of test suite.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56245/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 56246: Fixed typos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56246/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 56195: Updated containerizer->launch path to close IOSwitchboard FDs on error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56195/#review164040 --- src/slave/containerizer/mesos/containerizer.cpp (line 1140)

Re: Review Request 55732: Added `--3way` option to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55732/#review164032 --- Fix it, then Ship it! support/apply-reviews.py (line 7)

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53791/#review164013 --- Patch looks great! Reviews applied: [53790, 54712, 54878, 53791]

Review Request 56237: Add `syntax = "proto2"; ` to the rest of the files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56237/ --- Review request for mesos, Deshi Xiao, Yong Tang, and Zhitao Li. Bugs:

Review Request 56238: Allow a newer version of google protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56238/ --- Review request for mesos, Deshi Xiao, Yong Tang, and Zhitao Li. Bugs:

Review Request 56236: Add `syntax = "proto2"` to some files automatically.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56236/ --- Review request for mesos, Deshi Xiao, Yong Tang, and Zhitao Li. Bugs:

Re: Review Request 54601: Replaced `int` with `int_fd` in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54601/#review164009 --- 3rdparty/stout/include/stout/os/mktemp.hpp (line 44)

Re: Review Request 54602: Replaced `int` with `int_fd` in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54602/#review164008 --- 3rdparty/libprocess/src/io.cpp (line 222)

Re: Review Request 55901: Added support for command health checks to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55901/#review164003 --- Patch looks great! Reviews applied: [55900, 55901] Passed

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53791/ --- (Updated Feb. 2, 2017, 5:32 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 55901: Added support for command health checks to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55901/ --- (Updated Feb. 2, 2017, 5:02 p.m.) Review request for mesos, Alexander

Re: Review Request 55900: Improved style in `HealthChecker`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55900/ --- (Updated Feb. 2, 2017, 4:54 p.m.) Review request for mesos, Alexander

Re: Review Request 56218: Added some check tests for default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56218/#review163972 --- Patch looks great! Reviews applied: [56208, 56209, 56210, 56211,

Re: Review Request 56144: Added unit test for http::Headers abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56144/#review163960 --- Patch looks great! Reviews applied: [56116, 56117, 54537, 56144]

Re: Review Request 55321: Introduced process::after.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55321/#review163959 --- 3rdparty/libprocess/Makefile.am (line 237)

Re: Review Request 55321: Introduced process::after.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55321/#review163955 --- 3rdparty/libprocess/include/Makefile.am (lines 15 - 16)

Re: Review Request 55322: Used process::after instead of process::RateLimiter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55322/#review163957 --- Ship it! Ship It! - Gastón Kleiman On Jan. 8, 2017, 7:49

Re: Review Request 56195: Updated containerizer->launch path to close IOSwitchboard FDs on error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56195/#review163956 --- Patch looks great! Reviews applied: [56195] Passed command:

Re: Review Request 55322: Used process::after instead of process::RateLimiter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55322/#review163954 --- Ship it! This will most likely fix

Re: Review Request 56188: Removed all instances of '.Times(1)' from libprocess tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56188/#review163953 --- Ship it! Ship It! - Jan Schlicht On Feb. 1, 2017, 10:26

Re: Review Request 56187: Removed all instances of '.Times(1)' from Mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56187/#review163952 --- Ship it! Ship It! - Jan Schlicht On Feb. 1, 2017, 10:26

Re: Review Request 56139: Removed redundant 'Times(1)' from master validation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56139/#review163951 --- Ship it! Ship It! - Jan Schlicht On Feb. 1, 2017, 1 a.m.,

Re: Review Request 56052: Added the 'Secret' protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56052/#review163950 --- Ship it! Ship It! - Jan Schlicht On Jan. 31, 2017, 11:44

Re: Review Request 56055: Added validation for 'LAUNCH_NESTED_CONTAINER_SESSION'.

> On Jan. 30, 2017, 10:24 a.m., Jan Schlicht wrote: > > src/tests/slave_validation_tests.cpp, line 282 > > > > > > Indent with 4 spaces. > > Greg Mann wrote: > Unfortunately, I think our style guide is

Review Request 56217: Added support for general checks to default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56217/ --- Review request for mesos, Gastón Kleiman and Vinod Kone. Bugs: MESOS-6906

Review Request 56218: Added some check tests for default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56218/ --- Review request for mesos, Gastón Kleiman and Vinod Kone. Bugs: MESOS-6906

Review Request 56216: Renamed health checker collection in default executor for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56216/ --- Review request for mesos, Gastón Kleiman and Vinod Kone. Bugs: MESOS-6906

Review Request 56213: Added check tests for command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56213/ --- Review request for mesos, Gastón Kleiman and Vinod Kone. Bugs: MESOS-6906

Review Request 56212: Added support for general checks to command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56212/ --- Review request for mesos, Gastón Kleiman and Vinod Kone. Bugs: MESOS-6906

Review Request 56215: Reused previous task status to generate a new one in default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56215/ --- Review request for mesos, Gastón Kleiman and Vinod Kone. Bugs: MESOS-6906

Review Request 56214: Hashed unacknowledged updates by UUID string in default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56214/ --- Review request for mesos, Gastón Kleiman and Vinod Kone. Bugs: MESOS-6906

Review Request 56211: Renamed health checker in command executor for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56211/ --- Review request for mesos, Gastón Kleiman and Vinod Kone. Bugs: MESOS-6906

Review Request 56210: Reused previous task status to generate a new one in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56210/ --- Review request for mesos, Gastón Kleiman and Vinod Kone. Bugs: MESOS-6906

Review Request 56208: Updated checks library with general check support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56208/ --- Review request for mesos, Gastón Kleiman and Vinod Kone. Bugs: MESOS-6906

Review Request 56209: Hashed unacknowledged updates by UUID string in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56209/ --- Review request for mesos, Gastón Kleiman and Vinod Kone. Bugs: MESOS-6906

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53791/#review163947 --- Patch looks great! Reviews applied: [53790, 54712, 54878, 53791]

Re: Review Request 56144: Added unit test for http::Headers abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56144/ --- (Updated Feb. 2, 2017, 12:40 a.m.) Review request for mesos, Avinash

Re: Review Request 54537: Support 'Basic' auth docker registry on Unified Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54537/ --- (Updated Feb. 2, 2017, 12:39 a.m.) Review request for mesos, Avinash

Re: Review Request 56116: Implemented new http::Headers abstraction for WWW-Authenticate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56116/ --- (Updated Feb. 2, 2017, 12:39 a.m.) Review request for mesos, Avinash

Re: Review Request 54537: Support 'Basic' auth docker registry on Unified Containerizer.

> On Feb. 1, 2017, 8:40 p.m., Jie Yu wrote: > > src/uri/fetchers/docker.cpp, line 801 > > > > > > s/type/scheme/ I would go with "Unsupported auth-scheme:", which might be more accurate. > On Feb. 1, 2017, 8:40