Re: Review Request 57254: Updated DRFSorter to support hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57254/ --- (Updated March 14, 2017, 5:59 a.m.) Review request for mesos, Benjamin

Re: Review Request 56475: Added a test for the 'CombinedAuthenticator'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56475/#review168866 --- Bad patch! Reviews applied: [56475, 56476, 56474] Failed

Re: Review Request 56475: Added a test for the 'CombinedAuthenticator'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56475/ --- (Updated March 14, 2017, 5:34 a.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 56476: Enabled loading multiple HTTP authenticators in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56476/ --- (Updated March 14, 2017, 5:32 a.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 56474: Added the 'CombinedAuthenticator'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56474/ --- (Updated March 14, 2017, 5:30 a.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 57574: Ensured the cgroup memory+swap limit is no less than the memory limit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57574/#review168863 ---

Re: Review Request 57574: Ensured the cgroup memory+swap limit is no less than the memory limit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57574/#review168864 ---

Re: Review Request 57575: Added a test to test the cgroup limit swap functionality.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57575/#review168861 --- Ship it! Ship It! - haosdent huang On March 14, 2017, 12:05

Re: Review Request 57574: Ensured the cgroup memory+swap limit is no less than the memory limit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57574/#review168856 --- Ship it! Ship It! - haosdent huang On March 14, 2017, 12:04

Re: Review Request 57491: Windows: Update libprocess CMake setup for Glog patch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57491/#review168853 --- 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake Lines

Re: Review Request 57575: Added a test to test the cgroup limit swap functionality.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57575/#review168851 --- Patch looks great! Reviews applied: [57574, 57575] Passed

Review Request 57575: Added a test to test the cgroup limit swap functionality.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57575/ --- Review request for mesos, Benjamin Mahler, haosdent huang, Ian Downes, and

Review Request 57574: Ensured the cgroup memory+swap limit is no less than the memory limit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57574/ --- Review request for mesos, Benjamin Mahler, haosdent huang, Ian Downes, and

Re: Review Request 57340: Remove adjustment code within Resources::apply.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57340/#review168539 --- Looks good, the changes to resources.cpp were done how? Are they

Re: Review Request 57269: Added a test to ensure allocation roles are exposed in master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57269/#review168844 --- src/tests/master_tests.cpp Lines 4369-4389 (patched)

Re: Review Request 57358: WIP: Fixed FD leak in SSL server socket cleanup.

> On March 13, 2017, 3:08 p.m., Benjamin Mahler wrote: > > Do you still need this? The description of the problem still stands, but, as we discussed offline, the fix will be applied to the `Queue` class rather than the socket implementation. - Joseph

Re: Review Request 57358: WIP: Fixed FD leak in SSL server socket cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57358/ --- (Updated March 13, 2017, 3:34 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 57269: Added a test to ensure allocation roles are exposed in master API.

> On March 6, 2017, 10:38 p.m., Benjamin Mahler wrote: > > src/tests/master_tests.cpp > > Lines 4292-4293 (patched) > > > > > > Are you planning to test the agent endpoint as well? > > Jay Guo wrote: > I

Re: Review Request 57358: Fixed FD leak in SSL server socket cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57358/#review168837 --- Do you still need this? - Benjamin Mahler On March 9, 2017,

Re: Review Request 57472: Removing deprecated ACLs `SetQuota` and `RemoveQuota`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57472/#review168830 --- Fix it, then Ship it! CHANGELOG Lines 5-9 (patched)

Re: Review Request 57386: Introduced changes to the authz protos needed for RemoveNestedContainer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57386/#review168834 --- include/mesos/authorizer/authorizer.proto Lines 174 (patched)

Re: Review Request 52944: Updated CLI pylint configuration to disable 'fixme' warnings.

> On March 12, 2017, 4:41 p.m., Kevin Klues wrote: > > @kaysoky Are you still ok shipping this? I can push it through myself if so. Yes, my first "Ship It!" still stands. You should be the one to push though. - Joseph --- This is an

Re: Review Request 52942: Updated CLI pylint configuration to ignore the 'netifaces' module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52942/#review168826 --- Ship it! Ship It! - Joseph Wu On March 12, 2017, 4:41 p.m.,

Re: Review Request 57560: Removed unnecessary curly braces wrapping case statements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57560/#review168822 --- What's the criteria for deeming such braces necessary or not?

Re: Review Request 57534: Added and implemented RegisterAgent ACL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57534/#review168816 --- Bad patch! Reviews applied: [57534, 57520] Failed command:

Re: Review Request 57560: Removed unnecessary curly braces wrapping case statements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57560/ --- (Updated March 13, 2017, 6:19 p.m.) Review request for mesos, Alexander

Re: Review Request 57341: Made the usage of C++ namespaces in 'slave/http.cpp' consistent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57341/ --- (Updated March 13, 2017, 6:19 p.m.) Review request for mesos, Alexander

Re: Review Request 57254: Updated DRFSorter to support hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57254/ --- (Updated March 13, 2017, 6:17 p.m.) Review request for mesos, Benjamin

Re: Review Request 57562: Added a missing header to fix 'make distcheck'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57562/#review168810 --- Bad patch! Reviews applied: [57562] Failed command: python

Re: Review Request 57254: Updated DRFSorter to support hierarchical roles.

> On March 10, 2017, 1:41 a.m., Michael Park wrote: > > src/master/allocator/sorter/drf/sorter.hpp > > Lines 68-70 (patched) > > > > > > It seems like changing the behavior around the members of the `clients` > >

Re: Review Request 57388: Added documentation for the 'RemoveNestedContainer' Agent API call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57388/#review168804 --- Ship it! Ship It! - Alexander Rukletsov On March 13, 2017,

Re: Review Request 57254: Updated DRFSorter to support hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57254/ --- (Updated March 13, 2017, 6:04 p.m.) Review request for mesos, Benjamin

Re: Review Request 57387: Implemented the Agent API call `RemoveNestedContainer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57387/#review168803 --- Ship it! Ship It! - Alexander Rukletsov On March 13, 2017,

Review Request 57564: Changed DRFSorter's representation of inactive clients.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57564/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Michael Park.

Re: Review Request 57341: Made the usage of C++ namespaces in 'slave/http.cpp' consistent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57341/#review168801 --- Ship it! Ship It! - Alexander Rukletsov On March 8, 2017,

Re: Review Request 57386: Introduced changes to the authz protos needed for RemoveNestedContainer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57386/#review168800 --- Ship it! Ship It! - Alexander Rukletsov On March 10, 2017,

Re: Review Request 57385: Introduced proto changes needed for the RemoveNestedContainer API call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57385/#review168798 --- Ship it! Ship It! - Alexander Rukletsov On March 13, 2017,

Re: Review Request 57560: Removed unnecessary curly braces wrapping case statements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57560/#review168799 --- Ship it! Ship It! - Alexander Rukletsov On March 13, 2017,

Re: Review Request 57384: Added `Containerizer::remove`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57384/#review168797 --- Ship it! Ship It! - Alexander Rukletsov On March 13, 2017,

Re: Review Request 57262: CMake: Added support for SSL-enabled builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57262/#review168786 --- Patch looks great! Reviews applied: [57260, 57261, 57262]

Review Request 57534: Added and implemented RegisterAgent ACL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57534/ --- Review request for mesos, Adam B, Anindya Sinha, and Alexander Rojas. Bugs:

Review Request 57520: Bumped up the number of args allowed in some libprocess templates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57520/ --- Review request for mesos and Michael Park. Bugs: MESOS-7097

Re: Review Request 57562: Added a missing header to fix 'make distcheck'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57562/#review168779 --- Ship it! Ship It! - Vinod Kone On March 13, 2017, 4:26

Review Request 57562: Added a missing header to fix 'make distcheck'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57562/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 53264: Added test for CNI port-mapper plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53264/ --- (Updated March 13, 2017, 4:03 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 57560: Removed unnecessary curly braces wrapping case statements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57560/#review168776 --- Ship it! Ship It! - Vinod Kone On March 13, 2017, 3:11

Re: Review Request 57469: Made the default executor populate volume mappings for disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57469/#review168773 --- Fix it, then Ship it! LGTM, but I want to make sure Jie

Re: Review Request 57474: Added test for authorization of hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57474/ --- (Updated March 13, 2017, 4:35 p.m.) Review request for mesos, Adam B and

Re: Review Request 57474: Added test for authorization of hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57474/#review168769 --- Bad review! Reviews applied: [57474, 57473, 57472, 57166, 56805,

Re: Review Request 56753: Implemented the JWT authenticator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56753/ --- (Updated March 13, 2017, 4:28 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 57261: CMake: Added configuration options for SSL builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57261/#review168767 --- Ship it! Ship It! - Joris Van Remoortere On March 3, 2017,

Re: Review Request 57262: CMake: Added support for SSL-enabled builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57262/#review168768 --- Ship it! Ship It! - Joris Van Remoortere On March 9, 2017,

Review Request 57560: Removed unnecessary curly braces wrapping case statements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57560/ --- Review request for mesos, Alexander Rukletsov and Vinod Kone. Bugs: MESOS-7120

Re: Review Request 57387: Implemented the Agent API call `RemoveNestedContainer`.

> On March 13, 2017, 12:05 p.m., Alexander Rukletsov wrote: > > src/authorizer/local/authorizer.cpp > > Lines 1005-1017 (patched) > > > > > > Please do not enclose the `case` block in `{}` for consistency. > >

Re: Review Request 57387: Implemented the Agent API call `RemoveNestedContainer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57387/ --- (Updated March 13, 2017, 2:36 p.m.) Review request for mesos, Adam B,

Re: Review Request 57388: Added documentation for the 'RemoveNestedContainer' Agent API call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57388/#review168762 --- Patch looks great! Reviews applied: [57384, 57385, 57386, 57341,

Re: Review Request 57384: Added `Containerizer::remove`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57384/ --- (Updated March 13, 2017, 2:25 p.m.) Review request for mesos, Alexander

Re: Review Request 56753: Implemented the JWT authenticator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56753/ --- (Updated March 13, 2017, 3:09 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 57384: Added `Containerizer::remove`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57384/#review168760 --- Ship it! Ship It! - Vinod Kone On March 13, 2017, 12:32

Re: Review Request 57473: Added support for authorization of Hierachical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57473/ --- (Updated March 13, 2017, 2:21 p.m.) Review request for mesos, Adam B and

Re: Review Request 57474: Added test for authorization of hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57474/ --- (Updated March 13, 2017, 2:18 p.m.) Review request for mesos, Adam B and

Re: Review Request 57473: Added support for authorization of Hierachical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57473/ --- (Updated March 13, 2017, 2:14 p.m.) Review request for mesos, Adam B and

Re: Review Request 56754: Implemented a JWT secret generator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56754/#review168758 --- Patch looks great! Reviews applied: [56665, 5, 56667, 56753,

Re: Review Request 57387: Implemented the Agent API call `RemoveNestedContainer`.

> On March 13, 2017, 12:05 p.m., Alexander Rukletsov wrote: > > src/authorizer/local/authorizer.cpp > > Lines 1005-1017 (patched) > > > > > > Please do not enclose the `case` block in `{}` for consistency. > >

Re: Review Request 57388: Added documentation for the 'RemoveNestedContainer' Agent API call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57388/ --- (Updated March 13, 2017, 12:38 p.m.) Review request for mesos, Alexander

Re: Review Request 57387: Implemented the Agent API call `RemoveNestedContainer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57387/ --- (Updated March 13, 2017, 12:37 p.m.) Review request for mesos, Adam B,

Re: Review Request 57385: Introduced proto changes needed for the RemoveNestedContainer API call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57385/ --- (Updated March 13, 2017, 12:34 p.m.) Review request for mesos, Alexander

Re: Review Request 57384: Added `Containerizer::remove`.

> On March 9, 2017, 9:16 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.cpp > > Lines 2395-2396 (patched) > > > > > > Error message here should not include 'containerId' because that's the > >

Re: Review Request 57384: Added `Containerizer::remove`.

> On March 8, 2017, 12:54 a.m., Jie Yu wrote: > > src/slave/containerizer/containerizer.hpp > > Lines 158 (patched) > > > > > > can we call it 'delete'? This is more consistent with > > `DeleteNestedContainer`

Re: Review Request 57384: Added `Containerizer::remove`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57384/ --- (Updated March 13, 2017, 12:32 p.m.) Review request for mesos, Alexander

Re: Review Request 57387: Implemented the Agent API call `RemoveNestedContainer`.

> On March 13, 2017, 12:05 p.m., Alexander Rukletsov wrote: > > src/authorizer/local/authorizer.cpp > > Lines 1005-1017 (patched) > > > > > > Please do not enclose the `case` block in `{}` for consistency. This is

Re: Review Request 57388: Added documentation for the 'RemoveNestedContainer' Agent API call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57388/#review168753 --- docs/operator-http-api.md Lines 3597 (patched)

Re: Review Request 57387: Implemented the Agent API call `RemoveNestedContainer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57387/#review168752 --- src/authorizer/local/authorizer.cpp Lines 1005-1017 (patched)

Re: Review Request 56754: Implemented a JWT secret generator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56754/ --- (Updated March 13, 2017, 12:03 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 57472: Removing deprecated ACLs `SetQuota` and `RemoveQuota`.

> On March 10, 2017, 9:50 a.m., Adam B wrote: > > CHANGELOG > > Lines 6 (patched) > > > > > > Please mention this in the docs/upgrades.md table as well. > > Benjamin Bannier wrote: > Did you forget to push the

Re: Review Request 57472: Removing deprecated ACLs `SetQuota` and `RemoveQuota`.

> On March 10, 2017, 9:50 a.m., Adam B wrote: > > CHANGELOG > > Lines 6 (patched) > > > > > > Please mention this in the docs/upgrades.md table as well. > > Benjamin Bannier wrote: > Did you forget to push the