Re: Review Request 57964: Added a test to verify metrics when shared resources are present.

2017-04-22 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57964/#review172745 --- Patch looks great! Reviews applied: [57963, 57964] Passed

Re: Review Request 58646: Fixed a style issue in v1 mesos.proto.

2017-04-22 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58646/#review172742 --- Patch looks great! Reviews applied: [58641, 58642, 58643, 58644,

Re: Review Request 57534: Added and implemented RegisterAgent ACL.

2017-04-22 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57534/#review172739 --- Ship it! Ship It! - Anindya Sinha On March 28, 2017, 8:24

Re: Review Request 57731: Fixed a test in MasterAuthorizationTest.

2017-04-22 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57731/#review172738 --- Ship it! Ship It! - Anindya Sinha On March 17, 2017, 3:55

Re: Review Request 57964: Added a test to verify metrics when shared resources are present.

2017-04-22 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57964/ --- (Updated April 22, 2017, 5 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 57964: Added a test to verify metrics when shared resources are present.

2017-04-22 Thread Anindya Sinha
> On April 21, 2017, 10:06 p.m., Jiang Yan Xu wrote: > > src/tests/persistent_volume_tests.cpp > > Lines 1174-1175 (patched) > > > > > > The comment doesn't seem right? Yes, ofcourse. Copy and paste issue. Fixed

Re: Review Request 57963: Metrics for used resources should incorporate shared resources.

2017-04-22 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57963/ --- (Updated April 22, 2017, 5 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 58640: Updated the Overwrite docker provisioner test for MESOS-7280.

2017-04-22 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58640/#review172735 --- Patch looks great! Reviews applied: [58640] Passed command: