Re: Review Request 60356: Tried to compile Mesos with Boost 1.6.4

2017-06-21 Thread David Carlier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60356/ --- (Updated June 22, 2017, 5:09 a.m.) Review request for mesos. Changes ---

Re: Review Request 60281: Added the adjusted `TaskInfo` into the `Operation` to be sent out.

2017-06-21 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60281/#review178623 --- src/master/master.cpp Line 4558 (original), 4558 (patched)

Re: Review Request 60283: Fixed `convertResourceFormat` uses with `validateAndUpgradeResources`.

2017-06-21 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60283/#review178622 --- src/master/master.cpp Line 4221 (original), 4221 (patched)

Review Request 60356: Tried to compile Mesos with Boost 1.6.4

2017-06-21 Thread David Carlier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60356/ --- Review request for mesos. Repository: mesos Description --- Making it

Re: Review Request 60356: Tried to compile Mesos with Boost 1.6.4

2017-06-21 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60356/#review178621 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 60284: Removed unused `convertResourceFormat` for `Operation`.

2017-06-21 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60284/#review178618 --- Patch looks great! Reviews applied: [60281, 60282, 60351, 60352,

Re: Review Request 60353: Allowed dashes in Python modules.

2017-06-21 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60353/#review178619 --- Bad patch! Reviews applied: [60353] Failed command: python

Re: Review Request 60279: Add constructor for ObjectApprover::Object.

2017-06-21 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60279/#review178615 --- Patch looks great! Reviews applied: [60279] Passed command:

Re: Review Request 60345: Windows: Set Unicode compilation flags.

2017-06-21 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60345/#review178614 --- Patch looks great! Reviews applied: [60291, 60292, 60293, 60294,

Re: Review Request 60280: Provide full path to the custom executor.

2017-06-21 Thread Aaron Wood via Review Board
> On June 21, 2017, 11:07 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 671-674 (patched) > > > > > > Sorry, I got confused. User should be the one setting argv[0]. So we > > don't need

Re: Review Request 60280: Provide full path to the custom executor.

2017-06-21 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/#review178612 --- Patch looks great! Reviews applied: [60280] Passed command:

Review Request 60353: Allowed dashes in Python modules.

2017-06-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60353/ --- Review request for mesos, Armand Grillet and Benjamin Bannier. Bugs:

Re: Review Request 60252: Fixed a bug that causes segfault in ProcessManager::finalize.

2017-06-21 Thread Joseph Wu
> On June 21, 2017, 11:42 a.m., Joseph Wu wrote: > > I agree this makes the finalization logic safer, but I don't see a way to > > add a `nullptr` to the `ProcessManager::processes` map. > > > > `ProcessManager::spawn` is the only location where the `processes` map is > > inserted, and this

Review Request 60352: Relaxed the resource format restriction for frameworks.

2017-06-21 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60352/ --- Review request for mesos and Neil Conway. Repository: mesos Description

Review Request 60351: Used `JSON::protobuf` to print resources not validated nor converted.

2017-06-21 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60351/ --- Review request for mesos and Neil Conway. Repository: mesos Description

Re: Review Request 60279: Add constructor for ObjectApprover::Object.

2017-06-21 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60279/#review178605 --- include/mesos/authorizer/authorizer.hpp Lines 74 (patched)

Re: Review Request 60331: Windows: Disable code using `os::shell()`.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60331/ --- (Updated June 21, 2017, 11:52 p.m.) Review request for mesos, Alexander

Re: Review Request 60252: Fixed a bug that causes segfault in ProcessManager::finalize.

2017-06-21 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60252/#review178603 --- Patch looks great! Reviews applied: [60252] Passed command:

Re: Review Request 60345: Windows: Set Unicode compilation flags.

2017-06-21 Thread Andrew Schwartzmeyer
> On June 21, 2017, 11:05 p.m., Mesos Reviewbot wrote: > > Bad patch! > > > > Reviews applied: [60345, 60344, 60343, 60342, 60341, 60340, 60339, 60338, > > 60337, 60336, 60335, 60334, 60333, 60332, 60331, 60330, 60329, 60328, > > 60327, 60326, 60325, 60324, 60323, 60322, 60321, 60320, 60319,

Re: Review Request 60104: Added rebooted flag to State.

2017-06-21 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60104/#review178601 --- src/slave/state.cpp Line 96 (original), 95 (patched)

Re: Review Request 60232: Linted support/mesos-split.py.

2017-06-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60232/#review178600 --- Fix it, then Ship it! I'll fixup before committing.

Re: Review Request 60231: Linted support/mesos-gtest-runner.py.

2017-06-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60231/#review178598 --- Ship it! Ship It! - Joseph Wu On June 20, 2017, 3:14 a.m.,

Re: Review Request 60104: Added rebooted flag to State.

2017-06-21 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60104/ --- (Updated June 21, 2017, 11:32 p.m.) Review request for mesos, Neil Conway,

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

2017-06-21 Thread Megha Sharma
> On June 21, 2017, 4:39 p.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp > > Lines 5798-5867 (original), 5798-5867 (patched) > > > > > > So all of this work is only useful for recovering frameworks, it looks > >

Re: Review Request 60230: Linted support/jsonurl.py.

2017-06-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60230/#review178596 --- Ship it! I can fix this up before committing.

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

2017-06-21 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60105/ --- (Updated June 21, 2017, 11:22 p.m.) Review request for mesos, Neil Conway,

Re: Review Request 60229: Linted support/generate-endpoint-help.py.

2017-06-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60229/#review178582 --- Fix it, then Ship it! I'll fixup before committing.

Re: Review Request 60227: Linted support/mesos-style.py.

2017-06-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60227/#review178589 --- support/mesos-style.py Lines 305-306 (patched)

Re: Review Request 60105: Added helper method recoverSlaveState.

2017-06-21 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60105/ --- (Updated June 21, 2017, 11:11 p.m.) Review request for mesos, Neil Conway,

Re: Review Request 60280: Provide full path to the custom executor.

2017-06-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/#review178586 --- src/slave/containerizer/mesos/launch.cpp Lines 671-674 (patched)

Re: Review Request 60346: Improved the documentation of 'TASK_LOST'.

2017-06-21 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60346/#review178588 --- Bad patch! Reviews applied: [60346] Failed command: python

Re: Review Request 60345: Windows: Set Unicode compilation flags.

2017-06-21 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60345/#review178587 --- Bad patch! Reviews applied: [60345, 60344, 60343, 60342, 60341,

Re: Review Request 60105: Added helper method recoverSlaveState.

2017-06-21 Thread Megha Sharma
> On June 21, 2017, 4:39 p.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp > > Lines 5945-5946 (patched) > > > > > > This comment seems to be misplaced, why does the code here cares? It > > just processes the

Re: Review Request 60280: Provide full path to the custom executor.

2017-06-21 Thread Aaron Wood via Review Board
> On June 21, 2017, 9:54 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 801 (patched) > > > > > > Why this is necessary? I think execvp will look into the current > > working directory?

Re: Review Request 60228: Linted support/apply-reviews.py.

2017-06-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60228/#review178570 --- Fix it, then Ship it! support/apply-reviews.py Lines 173-176

Re: Review Request 60280: Provide full path to the custom executor.

2017-06-21 Thread Aaron Wood via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/ --- (Updated June 21, 2017, 10:26 p.m.) Review request for mesos, Jie Yu, James

Re: Review Request 60252: Fixed a bug that causes segfault in ProcessManager::finalize.

2017-06-21 Thread Jiang Yan Xu
> On June 21, 2017, 11:42 a.m., Joseph Wu wrote: > > I agree this makes the finalization logic safer, but I don't see a way to > > add a `nullptr` to the `ProcessManager::processes` map. > > > > `ProcessManager::spawn` is the only location where the `processes` map is > > inserted, and this

Re: Review Request 60345: Windows: Set Unicode compilation flags.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60345/ --- (Updated June 21, 2017, 10:17 p.m.) Review request for mesos, Alexander

Review Request 60346: Improved the documentation of 'TASK_LOST'.

2017-06-21 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60346/ --- Review request for mesos and Neil Conway. Bugs: MESOS-7662

Review Request 60341: Windows: Changed job object names to `wstring`.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60341/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Review Request 60342: Windows: Made version info use Unicode.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60342/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Review Request 60345: Windows: Set Unicode compilation flags.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60345/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Re: Review Request 60280: Provide full path to the custom executor.

2017-06-21 Thread Aaron Wood via Review Board
> On June 21, 2017, 7:28 p.m., Aaron Wood wrote: > > Someone correct me if I'm wrong, but I don't think we need this anymore: > > ``` > > if (launchInfo.has_working_directory()) { > > Try chdir = os::chdir(launchInfo.working_directory()); > > if (chdir.isError()) { > > cerr <<

Review Request 60340: Windows: Made job object APIs use Unicode.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60340/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Review Request 60344: Windows: Require building with `_UNICODE` and `UNICODE`.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60344/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Review Request 60343: Windows: Made `process_entry()` use Unicode.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60343/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Review Request 60339: Windows: Deleted `os::hstrerror()` as it is unused.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60339/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Re: Review Request 60280: Provide full path to the custom executor.

2017-06-21 Thread Aaron Wood via Review Board
> On June 21, 2017, 9:54 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 801 (patched) > > > > > > Why this is necessary? I think execvp will look into the current > > working directory?

Review Request 60337: Windows: Made `os::user()` use Unicode.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60337/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Review Request 60338: Windows: Made `dynamiclibrary.hpp` use Unicode.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60338/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Review Request 60336: Windows: Made environment abstractions use Unicode.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60336/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Review Request 60335: Windows: Made `net.hpp` use Unicode.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60335/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Review Request 60334: Windows: Made `WindowsError` use Unicode.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60334/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Re: Review Request 60331: Windows: Disable code using `os::shell()`.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60331/ --- (Updated June 21, 2017, 10:13 p.m.) Review request for mesos, Alexander

Re: Review Request 60332: Windows: Fixed `fs::usage()` to support long paths.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60332/ --- (Updated June 21, 2017, 10:13 p.m.) Review request for mesos, Alexander

Review Request 60331: Windows: Disable code using `os::shell()`.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60331/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Review Request 60330: Windows: Fixed use of `get_system_env()` in containerizer.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60330/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Review Request 60327: Added `map<string, string>` explict cast to `Envp`.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60327/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Review Request 60332: Windows: Fixed `fs::usage()` to support long paths.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60332/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Review Request 60329: Windows: Replaced `CreateProcess()` with `create_process()` helper.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60329/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Review Request 60328: Windows: Added `create_process()` wrapper to `shell.hpp`.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60328/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Review Request 60326: Added `vector` explicit cast to `Argv`.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60326/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Review Request 60325: Windows: Replaced `ping` with `Start-Sleep`.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60325/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Re: Review Request 60324: Windows: Implemented `WSTRINGIFY()` to print exit codes.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60324/ --- (Updated June 21, 2017, 10:08 p.m.) Review request for mesos, Alexander

Re: Review Request 60324: Windows: Implemented `WSTRINGIFY()` to print exit codes.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60324/ --- (Updated June 21, 2017, 10:08 p.m.) Review request for mesos, Alexander

Review Request 60324: Windows: Implemented `WSTRINGIFY()` to print exit codes.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60324/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Review Request 60322: Windows: Fixed `os::rename()` to support long paths.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60322/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Review Request 60321: Windows: Fixed `fs::list()` to support long paths.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60321/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Review Request 60323: Windows: Fixed `process::createIoPath()` to support long paths.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60323/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Review Request 60318: Windows: Made `os::temp()` use UTF-16 system calls.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60318/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Review Request 60320: Windows: Cleaned up `os::var()`.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60320/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Re: Review Request 60317: Windows: Fixed `os::access()` to support long paths.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60317/ --- (Updated June 21, 2017, 10:05 p.m.) Review request for mesos, Alexander

Review Request 60317: Windows: Fixed `os::access()` to support long paths.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60317/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Review Request 60314: Windows: Fixed `os::rmdir()` to support long paths.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60314/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Review Request 60315: Windows: Fixed `os::open()` to support long paths.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60315/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Review Request 60313: Windows: Fixed `os::rm()` to support long paths.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60313/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Review Request 60311: Windows: Replaced use of `_stat()` with `os::stat::isdir()`.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60311/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Review Request 60310: Fixed fetcher to use `enum class FollowSymlink`.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60310/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Re: Review Request 60290: Handle EINVAL from the capabilities version check.

2017-06-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60290/#review178568 --- Ship it! Ship It! - Jie Yu On June 21, 2017, 8:52 p.m.,

Review Request 60308: Refactored `enum FollowSymlink` to an `enum class FollowSymlink`.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60308/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Re: Review Request 60227: Linted support/mesos-style.py.

2017-06-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60227/#review178566 --- Ship it! Ship It! - Joseph Wu On June 20, 2017, 8:41 a.m.,

Review Request 60307: Windows: Fixed `CreateSymbolicLink()` to support long paths.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60307/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Review Request 60305: Windows: Refactored `reparse_point_attribute_set()`.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60305/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Re: Review Request 60288: Fix ambient capability tests on older systems.

2017-06-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60288/#review178565 --- Ship it! Ship It! - Jie Yu On June 21, 2017, 8:25 p.m.,

Review Request 60300: Windows: Fixed `isdir()` and `isfile()` to support long paths.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60300/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Review Request 60299: Windows: Fixed `os::exists()` to support long paths.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60299/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Re: Review Request 60287: Remove unnecessary test logging.

2017-06-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60287/#review178564 --- Ship it! Ship It! - Jie Yu On June 21, 2017, 8:24 p.m.,

Review Request 60296: Windows: Added long path test.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60296/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Re: Review Request 60280: Provide full path to the custom executor.

2017-06-21 Thread Jie Yu
> On June 21, 2017, 7:28 p.m., Aaron Wood wrote: > > Someone correct me if I'm wrong, but I don't think we need this anymore: > > ``` > > if (launchInfo.has_working_directory()) { > > Try chdir = os::chdir(launchInfo.working_directory()); > > if (chdir.isError()) { > > cerr <<

Re: Review Request 60280: Provide full path to the custom executor.

2017-06-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/#review178562 --- src/slave/containerizer/mesos/launch.cpp Lines 671-674 (patched)

Review Request 60294: Windows: Added `os::LONGPATH_PREFIX` constant.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60294/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Re: Review Request 59930: Support RO mode for bind mount volumes with filesystem/linux isolator

2017-06-21 Thread Charles Raimbert
> On June 10, 2017, 8:09 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > > Lines 607 (patched) > > > > > > I found this might be related. Are we able to test on Debian

Re: Review Request 60293: Windows: Switched from `gethostname` to `GetComputerName`.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60293/ --- (Updated June 21, 2017, 9:53 p.m.) Review request for mesos, Jeff Coffler,

Re: Review Request 60292: Windows: Added a `wstring wide_stringify(string)` helper.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60292/ --- (Updated June 21, 2017, 9:53 p.m.) Review request for mesos, Alexander

Review Request 60293: Windows: Switched from `gethostname` to `GetComputerName`.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60293/ --- Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.

Review Request 60292: Windows: Added a `wstring wide_stringify(string)` helper.

2017-06-21 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60292/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich,

Re: Review Request 60124: Added a name to ballon framework to distinguish between instances.

2017-06-21 Thread Joseph Wu
> On June 15, 2017, 12:07 p.m., Armand Grillet wrote: > > src/examples/balloon_framework.cpp > > Line 464 (original), 469 (patched) > > > > > > Consistency wise, other tests have just `executor.set_name("Framework

Re: Review Request 60123: Minor clean up of the balloon framework.

2017-06-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60123/#review178558 --- Ship it! Ship It! - Joseph Wu On June 20, 2017, 6:17 a.m.,

Re: Review Request 60122: Printed the reason why offer is declined in disk full framework.

2017-06-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60122/#review178557 --- Ship it! Ship It! - Joseph Wu On June 15, 2017, 10:08 a.m.,

Re: Review Request 59464: Add Fetcher task total and failed fetch metrics.

2017-06-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59464/#review178543 --- Ship it! LGTM. I can add the comment mentioned below before

  1   2   >