Re: Review Request 61290: Linked `mesos` target to `stout` interface library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61290/#review182357 --- Ship it! [Tentative "Ship It!" as I review this entire chain.]

Re: Review Request 61463: Fixed a bug in the test `NamespacesIsolatorTest.ROOT_PidNamespace`.

> On Aug. 8, 2017, 8:05 a.m., Gastón Kleiman wrote: > > src/tests/containerizer/isolator_tests.cpp > > Line 176 (original), 176 (patched) > > > > > > `/proc/self/ns/ipc` is also a symlink, should we change this line

Re: Review Request 61289: Removed unnecessary includes of `StoutConfigure`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61289/#review182355 --- Ship it! [Tentative "Ship It!" as I review this entire chain.]

Re: Review Request 61288: Linked `libprocess` to `stout` interface library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61288/#review182353 --- 3rdparty/libprocess/src/CMakeLists.txt Line 115 (original)

Re: Review Request 61288: Linked `libprocess` to `stout` interface library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61288/#review182352 --- Ship it! [Tentative "Ship It!" as I review this entire chain.]

Re: Review Request 61287: Removed `GroupSource` from `stout`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61287/#review182351 --- Ship it! [Tentative "Ship It!" as I review this entire chain.]

Re: Review Request 61286: Added `stout` interface library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61286/#review182349 --- Ship it! [Tentative "Ship It!" as I review this entire chain.]

Re: Review Request 61433: Checked openssl and zlib as required libraries for Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61433/ --- (Updated Aug. 8, 2017, 12:44 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 61433: Checked openssl and zlib as required libraries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61433/ --- (Updated Aug. 8, 2017, 12:37 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 61098: Added unit tests for gRPC support in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61098/ --- (Updated Aug. 8, 2017, 12:36 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 61463: Fixed a bug in the test `NamespacesIsolatorTest.ROOT_PidNamespace`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61463/#review182344 --- Fix it, then Ship it!

Re: Review Request 61463: Fixed a bug in the test `NamespacesIsolatorTest.ROOT_PidNamespace`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61463/#review182343 --- Ship it! Ship It! - Gilbert Song On Aug. 7, 2017, 8:12

Re: Review Request 61284: Made `libprocess` use default linking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61284/#review182342 --- Ship it! [Tentative "Ship It!" as I review this entire chain.]

Re: Review Request 61428: Added pid ns sharing based on agent flag and protobuf message field.

> On Aug. 4, 2017, 5:33 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/namespaces/pid.cpp > > Lines 130 (patched) > > > > > > Could we reverse two logics above? so that we can avoid the size

Review Request 61484: Added a benchmark for ns::clone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61484/ --- Review request for mesos, Benjamin Mahler, Greg Mann, and Joseph Wu.

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61434/#review182340 --- Patch looks great! Reviews applied: [61434] Passed command:

Review Request 61483: Added a test using CMD health checks + DefaultExecutor w/ Docker image.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61483/ --- Review request for mesos, Alexander Rukletsov and Vinod Kone. Repository:

Re: Review Request 61477: Used async signal safe assert in ns::clone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61477/#review182336 --- Ship it! Ship It! - Joseph Wu On Aug. 7, 2017, 12:07 p.m.,

Re: Review Request 60003: Reduced copying in defer, dispatch and Future.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60003/#review182333 --- Patch looks great! Reviews applied: [60002, 60003] Passed

Re: Review Request 61476: Used clone instead of fork in ns::clone.

> On Aug. 7, 2017, 9:34 p.m., Greg Mann wrote: > > src/linux/ns.hpp > > Lines 538-539 (original), 585-586 (patched) > > > > > > Should this comment be removed? > > Greg Mann wrote: > Sorry, I mean maybe it

Re: Review Request 61476: Used clone instead of fork in ns::clone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61476/#review182329 --- Ship it! LGTM. Just needs some tweaks to comments (+ the ones

Re: Review Request 60511: Added MockMetadataManager and test concurrent prune and pull.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60511/ --- (Updated Aug. 7, 2017, 9:49 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 56721: Implemented pruneImages with a mark and sweep in docker store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56721/ --- (Updated Aug. 7, 2017, 9:48 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 61476: Used clone instead of fork in ns::clone.

> On Aug. 7, 2017, 9:34 p.m., Greg Mann wrote: > > src/linux/ns.hpp > > Lines 538-539 (original), 585-586 (patched) > > > > > > Should this comment be removed? Sorry, I mean maybe it should be updated to mention

Re: Review Request 61476: Used clone instead of fork in ns::clone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61476/#review182325 --- src/linux/ns.hpp Lines 577 (patched)

Re: Review Request 53993: Updated quota doc to support quota update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53993/#review182327 --- Patch looks great! Reviews applied: [52284, 53679, 53691, 52103,

Re: Review Request 61361: Replaced `MESOS_3RDPARTY_*` with `CMAKE_CURRENT_*_DIR`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61361/ --- (Updated Aug. 7, 2017, 1:58 p.m.) Review request for mesos. Repository:

Re: Review Request 61474: Removed an unused function in src/linux/ns.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61474/#review182324 --- Ship it! Looks like the last reference to this function was

Re: Review Request 61470: Agent log available with the `/agent/path`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61470/#review182323 --- Patch looks great! Reviews applied: [61470] Passed command:

Re: Review Request 61466: Added the test `ROOT_CGROUPS_LaunchNestedSharePidNamespace`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61466/#review182314 --- Patch looks great! Reviews applied: [61270, 61406, 61428, 61463,

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review182313 --- ping - Eric Chung On Aug. 3, 2017, 9:41 p.m., Eric Chung

Re: Review Request 61361: Replaced `MESOS_3RDPARTY_*` with `CMAKE_CURRENT_*_DIR`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61361/ --- (Updated Aug. 7, 2017, 1:05 p.m.) Review request for mesos. Changes ---

Re: Review Request 61137: Cleaned up style in example frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61137/#review182312 --- Patch looks great! Reviews applied: [61112, 61110, 6, 61137]

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review182310 --- We talked about 2 approaches and approach 2 seemed like a cleaner

Review Request 61477: Used async signal safe assert in ns::clone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61477/ --- Review request for mesos, Benjamin Mahler and Joseph Wu. Bugs: MESOS-7858

Review Request 61476: Used clone instead of fork in ns::clone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61476/ --- Review request for mesos, Benjamin Mahler and Joseph Wu. Bugs: MESOS-7858

Review Request 61474: Removed an unused function in src/linux/ns.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61474/ --- Review request for mesos, Benjamin Mahler and Joseph Wu. Bugs: MESOS-7858

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

> On Aug. 4, 2017, 7:18 p.m., Vinod Kone wrote: > > docs/health-checks.md > > Lines 110 (patched) > > > > > > s/1./2./ ? or is this markdown style? Yeah, actual numbers have no effect on the rendered HTML:

Re: Review Request 61458: Added documentation of parallel test execution config flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61458/#review182308 --- Patch looks great! Reviews applied: [6, 60646, 61458]

Re: Review Request 58898: Do not kill non partition aware tasks.

> On May 10, 2017, 11:24 p.m., Neil Conway wrote: > > My apologies for the delay in reviewing this. > > > > High-level comments: > > > > (a) Can we improve the description of the problem in the commit summary? It > > took me quite a while to figure out what is actually going on here. My > >

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Aug. 7, 2017, 6:23 p.m.) Review request for mesos and Jiang Yan Xu.

Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-7215

Re: Review Request 61272: Added a MockResourceProvider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61272/ --- (Updated Aug. 7, 2017, 8:15 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 58898: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58898/#review182300 --- Bad patch! Reviews applied: [58898] Failed command: python

Re: Review Request 61446: Added a test to verify a fix for MESOS-7863.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61446/#review182299 --- Patch looks great! Reviews applied: [61440, 61441, 61442, 61443,

Re: Review Request 61363: Rewrote `libprocess` CMake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61363/ --- (Updated Aug. 7, 2017, 10:43 a.m.) Review request for mesos. Changes ---

Re: Review Request 61357: Imported `libev` and `libevent` libraries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61357/ --- (Updated Aug. 7, 2017, 10:42 a.m.) Review request for mesos. Changes ---

Re: Review Request 60931: Added test cases for framework streaming events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60931/#review182292 --- Patch looks great! Reviews applied: [60928, 60929, 60930, 60931]

Re: Review Request 53993: Updated quota doc to support quota update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53993/ --- (Updated Aug. 7, 2017, 4:35 p.m.) Review request for mesos, Alexander

Re: Review Request 53993: Updated quota doc to support quota update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53993/ --- (Updated Aug. 7, 2017, 4:35 p.m.) Review request for mesos, Alexander

Re: Review Request 61455: Tweaked checker logs to avoid repeated information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61455/#review182282 --- Ship it! Ship It! - Gastón Kleiman On Aug. 7, 2017, 10:47

Review Request 61470: Agent log available with the `/agent/path`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61470/ --- Review request for mesos and Adam B. Bugs: MESOS-7864

Review Request 61466: Added the test `ROOT_CGROUPS_LaunchNestedSharePidNamespace`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61466/ --- Review request for mesos, Gastón Kleiman, Gilbert Song, Jie Yu, Kevin Klues,

Review Request 61465: Added test `NamespacesIsolatorTest.ROOT_SharePidNamespaceWhenDisallow`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61465/ --- Review request for mesos, Gastón Kleiman, Gilbert Song, Jie Yu, Kevin Klues,

Review Request 61464: Added a test `NamespacesIsolatorTest.ROOT_SharePidNamespace`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61464/ --- Review request for mesos, Gastón Kleiman, Gilbert Song, Jie Yu, Kevin Klues,

Review Request 61463: Fixed a bug in the test `NamespacesIsolatorTest.ROOT_PidNamespace`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61463/ --- Review request for mesos, Gastón Kleiman, Gilbert Song, Jie Yu, Kevin Klues,

Re: Review Request 61137: Cleaned up style in example frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61137/ --- (Updated Aug. 7, 2017, 1:53 p.m.) Review request for mesos and Alexander

Re: Review Request 61111: Extracted strings into constants in example frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6/ --- (Updated Aug. 7, 2017, 12:50 p.m.) Review request for mesos, Alexander

Review Request 61458: Added documentation of parallel test execution config flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61458/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-4809

Review Request 61455: Tweaked checker logs to avoid repeated information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61455/ --- Review request for mesos and Gastón Kleiman. Repository: mesos Description

Re: Review Request 60646: Modified handling of parallel test configure flag for documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60646/ --- (Updated Aug. 7, 2017, 12:30 p.m.) Review request for mesos and Till