Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Aug. 9, 2017, 4:55 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Aug. 9, 2017, 4:48 a.m.) Review request for mesos and Jiang Yan Xu.

Review Request 61517: Refactored OpenSSL library checks in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61517/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Till Toenshoff. Bugs: M

Re: Review Request 61433: Refactored OpenSSL library checks in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61433/ --- (Updated Aug. 9, 2017, 3 a.m.) Review request for mesos, Benjamin Bannier, Jie

Review Request 61516: Fixed `check` and `tests` targets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61516/ --- Review request for mesos and Joseph Wu. Repository: mesos Description ---

Review Request 61515: Updated `CompilationConfigure.cmake` for imported libraries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61515/ --- Review request for mesos and Joseph Wu. Repository: mesos Description ---

Re: Review Request 61511: Improved the readability of some assertions/expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61511/ --- (Updated Aug. 9, 2017, 1:01 a.m.) Review request for mesos, Benjamin Bannier, J

Review Request 61514: Removed moved/deleted CMake modules from libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61514/ --- Review request for mesos and Joseph Wu. Repository: mesos Description ---

Review Request 61513: Removed `Mesos3rdpartyConfigure` from `MesosConfigure`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61513/ --- Review request for mesos and Joseph Wu. Repository: mesos Description ---

Review Request 61512: Fixed up 3rdparty CMake modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61512/ --- Review request for mesos and Joseph Wu. Repository: mesos Description ---

Re: Review Request 61306: Enabled building Java artifacts with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61306/ --- (Updated Aug. 8, 2017, 5:56 p.m.) Review request for mesos. Changes ---

Re: Review Request 61347: Linked `stout-tests` to `googletest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61347/ --- (Updated Aug. 8, 2017, 5:55 p.m.) Review request for mesos. Changes ---

Re: Review Request 61291: Imported `glog` library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61291/ --- (Updated Aug. 8, 2017, 5:54 p.m.) Review request for mesos. Changes ---

Re: Review Request 61303: Imported `curl` library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61303/ --- (Updated Aug. 8, 2017, 5:53 p.m.) Review request for mesos. Changes ---

Re: Review Request 61327: Imported `zlib` library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61327/ --- (Updated Aug. 8, 2017, 5:51 p.m.) Review request for mesos. Changes ---

Re: Review Request 61309: Imported ZooKeeper library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61309/ --- (Updated Aug. 8, 2017, 5:52 p.m.) Review request for mesos. Changes ---

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61434/#review182456 --- docs/health-checks.md Lines 54-55 (original), 59-60 (patched)

Re: Review Request 61406: Introduced `--disallow_sharing_agent_pid_namespace` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61406/#review182455 --- Ship it! Ship It! - Gilbert Song On Aug. 6, 2017, 7:52 p.m.,

Review Request 61511: Improved the readability of some assertions/expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61511/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Vinod Kone. Repository:

Re: Review Request 61272: Added a MockResourceProvider.

> On Aug. 1, 2017, 10:37 p.m., Jie Yu wrote: > > src/tests/mesos.hpp > > Lines 2287-2291 (patched) > > > > > > This is a bit counter intuitive. I was expecting that > > MockResourceProvider will take a real Driver:

Re: Review Request 61483: Added a test using CMD health checks + DefaultExecutor w/ Docker image.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61483/#review182416 --- Ship it! Ship It! - Vinod Kone On Aug. 7, 2017, 10:47 p.m.,

Re: Review Request 61438: Improved `NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_VerifyDeviceAccess`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61438/#review182415 --- Ship it! Ship It! - Vinod Kone On Aug. 5, 2017, 12:06 a.m.,

Re: Review Request 61282: Added a test verifying that DefaultExecutor tasks can use nvidia GPUs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61282/#review182414 --- Ship it! Ship It! - Vinod Kone On Aug. 5, 2017, 12:05 a.m.,

Re: Review Request 61111: Extracted strings into constants in example frameworks.

> On Aug. 8, 2017, 4:35 p.m., Benno Evers wrote: > > src/examples/balloon_framework.cpp > > Line 520 (original), 524 (patched) > > > > > > No real issue, but I find it curious that our style guide basically > > forc

Re: Review Request 61287: Removed `GroupSource` from `stout`.

> On Aug. 8, 2017, 3:36 p.m., Cloudbase wrote: > > Patch looks great! > > > > Reviews applied: [61287] > > > > Logs available here: http://test.local Sorry about this comment! It was just a test. - Cloudbase --- This is an automatical

Re: Review Request 61287: Removed `GroupSource` from `stout`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61287/#review182395 --- Patch looks great! Reviews applied: [61287] Logs available here:

Re: Review Request 61110: Added name flag to balloon and disk full frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61110/#review182392 --- Ship it! - Benno Evers On Aug. 1, 2017, 10:20 a.m., Armand Gr

Re: Review Request 61111: Extracted strings into constants in example frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6/#review182390 --- Ship it! src/examples/balloon_framework.cpp Line 520 (original

Re: Review Request 61182: Sent a resource provider message when providers subscribe.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61182/#review182387 --- Looks great, only nitpicking here. Please rebase, `resource_provid

Re: Review Request 61180: Added a resource providers total resources to the subscribe call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61180/#review182383 --- Ship it! Ship It! - Jan Schlicht On Aug. 1, 2017, 7:42 p.m.,

Re: Review Request 61189: Added authorization for V1 events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61189/#review182380 --- There is a weakness in the implementation here. If the ACLs of a u

Re: Review Request 61493: Added a test `DefaultExecutorTest.MultiTaskgroupSharePidNamespace`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61493/ --- (Updated Aug. 8, 2017, 5:44 p.m.) Review request for mesos, Gastón Kleiman, Gil

Review Request 61493: Added a test `DefaultExecutorTest.MultiTaskgroupSharePidNamespace`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61493/ --- Review request for mesos. Repository: mesos Description --- Added a test

Re: Review Request 61463: Fixed a bug in the test `NamespacesIsolatorTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61463/ --- (Updated Aug. 8, 2017, 5:43 p.m.) Review request for mesos, Gastón Kleiman, Gil

Re: Review Request 61428: Added pid ns sharing based on agent flag and protobuf message field.

> On Aug. 5, 2017, 8:33 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/namespaces/pid.cpp > > Lines 130 (patched) > > > > > > Could we reverse two logics above? so that we can avoid the size ch

Re: Review Request 61428: Added pid ns sharing based on agent flag and protobuf message field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61428/ --- (Updated Aug. 8, 2017, 5:40 p.m.) Review request for mesos, Gastón Kleiman, Gil

Re: Review Request 61189: Added authorization for V1 events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61189/#review182374 --- src/master/master.hpp Lines 899 (patched)

Re: Review Request 58021: Added storage-related offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58021/ --- (Updated Aug. 8, 2017, 10:21 a.m.) Review request for mesos, Benjamin Bannier a