Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

2017-08-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review182841 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

2017-08-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review182839 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 61493: Added a test `DefaultExecutorTest.MultiTaskgroupSharePidNamespace`.

2017-08-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61493/#review182837 --- Bad patch! Reviews applied: [61270, 61406, 61428, 61463, 61464,

Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

2017-08-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review182838 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

2017-08-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review182836 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 61493: Added a test `DefaultExecutorTest.MultiTaskgroupSharePidNamespace`.

2017-08-13 Thread Qian Zhang
> On Aug. 12, 2017, 9:31 a.m., Gastón Kleiman wrote: > > src/tests/default_executor_tests.cpp > > Lines 1451-1452 (patched) > > > > > > What do you think about the following alternative? > > > >

Re: Review Request 61493: Added a test `DefaultExecutorTest.MultiTaskgroupSharePidNamespace`.

2017-08-13 Thread Qian Zhang
> On Aug. 12, 2017, 6:38 a.m., Gilbert Song wrote: > > src/tests/default_executor_tests.cpp > > Lines 1580 (patched) > > > > > > you may want to `strings::trim()`. Good catch! - Qian

Re: Review Request 61493: Added a test `DefaultExecutorTest.MultiTaskgroupSharePidNamespace`.

2017-08-13 Thread Qian Zhang
> On Aug. 12, 2017, 6:27 a.m., Gilbert Song wrote: > > src/tests/default_executor_tests.cpp > > Lines 1538-1542 (patched) > > > > > > Could we save the executor sandbox to a var and call `getSandboxPath()`?

Re: Review Request 61493: Added a test `DefaultExecutorTest.MultiTaskgroupSharePidNamespace`.

2017-08-13 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61493/ --- (Updated Aug. 14, 2017, 10:06 a.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 61466: Added the test `ROOT_CGROUPS_LaunchNestedSharePidNamespace`.

2017-08-13 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61466/ --- (Updated Aug. 14, 2017, 10:05 a.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 61465: Added test `NamespacesIsolatorTest.ROOT_SharePidNamespaceWhenDisallow`.

2017-08-13 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61465/ --- (Updated Aug. 14, 2017, 10:04 a.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 61464: Added a test `NamespacesIsolatorTest.ROOT_SharePidNamespace`.

2017-08-13 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61464/ --- (Updated Aug. 14, 2017, 10:03 a.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

2017-08-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review182835 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

2017-08-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review182834 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

2017-08-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review182833 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

2017-08-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review182832 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

2017-08-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review182831 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

2017-08-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review182830 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 61610: Changes in Mesos necessary for UPID immutability.

2017-08-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61610/#review182828 --- Bad patch! Reviews applied: [61609, 61610] Logs available here:

Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

2017-08-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review182827 --- Bad review! Error: No reviewers specified. Please find a

Review Request 61611: Added hashset::contains for iterable.

2017-08-13 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61611/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 61609: Refactored UPID to be immutable and updated libprocess as necessary.

2017-08-13 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61609/ --- Review request for mesos, Avinash sridharan and Benjamin Mahler. Repository:

Review Request 61610: Changes in Mesos necessary for UPID immutability.

2017-08-13 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61610/ --- Review request for mesos, Avinash sridharan and Benjamin Mahler. Repository:

Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

2017-08-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review182826 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

2017-08-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review182825 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

2017-08-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review182824 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

2017-08-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review182823 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

2017-08-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review182822 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

2017-08-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review182821 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

2017-08-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review182820 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

2017-08-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review182819 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

2017-08-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review182818 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

2017-08-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review182816 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

2017-08-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review182815 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

2017-08-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review182812 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

2017-08-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review182811 --- Bad review! Error: No reviewers specified. Please find a