Re: Review Request 61947: Implemented handling of resource provider offer operations.

2017-09-07 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61947/#review184930 --- Bad patch! Reviews applied: [61947, 61946, 61810, 58021, 58047,

Re: Review Request 62147: Added a comment about master sending a checkpointed resources message.

2017-09-07 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62147/#review184929 --- Ship it! src/master/master.cpp Lines 6617-6618 (patched)

Re: Review Request 62047: Allowed look up latest executor directory by virtual path.

2017-09-07 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62047/#review184928 --- Before I can commit this we need some tests, there is a bug below

Re: Review Request 62040: Also log attached virtual path in agent.

2017-09-07 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62040/#review184926 --- Fix it, then Ship it! src/slave/slave.cpp Lines 939-943

Re: Review Request 62174: Replace name with virtualPath in files API.

2017-09-07 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62174/#review184925 --- Ship it! Ship It! - Benjamin Mahler On Sept. 7, 2017, 9:16

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

2017-09-07 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/#review184920 --- ERROR: Failed to apply patch 60491. Please check

Re: Review Request 60496: Added socket checking to the network ports isolator.

2017-09-07 Thread James Peach
> On Sept. 5, 2017, 7:12 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 271-284 (patched) > > > > > > Mind to explain why running the loop inside the isolator

Re: Review Request 60496: Added socket checking to the network ports isolator.

2017-09-07 Thread James Peach
> On Aug. 17, 2017, 2:45 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 148-150 (patched) > > > > > > It seems we only care about `port`, so it might not be needed

Re: Review Request 60496: Added socket checking to the network ports isolator.

2017-09-07 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60496/ --- (Updated Sept. 8, 2017, 12:09 a.m.) Review request for mesos, Qian Zhang and

Re: Review Request 62176: Added cmake dependency check for libsasl2 on non-Windows platforms.

2017-09-07 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62176/#review184918 --- FAIL: Mesos tests failed to build. Please check

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

2017-09-07 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/#review184913 --- ERROR: Failed to apply patch 60491. Please check

Re: Review Request 62176: Added cmake dependency check for libsasl2 on non-Windows platforms.

2017-09-07 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62176/#review184908 --- src/CMakeLists.txt Lines 615-620 (original), 615-624 (patched)

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

2017-09-07 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62105/#review184912 --- 3rdparty/CMakeLists.txt Lines 193-195 (patched)

Re: Review Request 62106: Enabled CRAM MD5 Authentication on Windows and associated tests.

2017-09-07 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62106/#review184911 --- cmake/CompilationConfigure.cmake Lines 109-112 (original),

Re: Review Request 62047: Allowed look up latest executor directory by virtual path.

2017-09-07 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62047/#review184910 --- FAIL: Some Mesos tests failed. Please check

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

2017-09-07 Thread Benjamin Bannier
> On Sept. 7, 2017, 1:32 a.m., Jie Yu wrote: > > src/slave/slave.hpp > > Lines 658 (patched) > > > > > > I am not sure if keeping another field just for resoruce provider > > provided resources in the agent is a

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

2017-09-07 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- (Updated Sept. 8, 2017, 12:38 a.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 61528: Implemented a registrar for resource provider manager state.

2017-09-07 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61528/ --- (Updated Sept. 8, 2017, 12:36 a.m.) Review request for mesos, Jie Yu and Jan

Review Request 62176: Added cmake dependency check for libsasl2 on non-Windows platforms.

2017-09-07 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62176/ --- Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

2017-09-07 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/ --- (Updated Sept. 7, 2017, 9:57 p.m.) Review request for mesos, Qian Zhang and

Re: Review Request 60593: Added `network/ports` isolator recovery tests.

2017-09-07 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60593/ --- (Updated Sept. 7, 2017, 9:57 p.m.) Review request for mesos, Qian Zhang and

Re: Review Request 60593: Added `network/ports` isolator recovery tests.

2017-09-07 Thread James Peach
> On Aug. 23, 2017, 2:53 p.m., Qian Zhang wrote: > > src/tests/containerizer/ports_isolator_tests.cpp > > Lines 853 (patched) > > > > > > It seems there is no enough time left for this code because we stop the > >

Re: Review Request 60593: Added `network/ports` isolator recovery tests.

2017-09-07 Thread James Peach
> On Sept. 6, 2017, 12:19 p.m., Qian Zhang wrote: > > src/tests/containerizer/ports_isolator_tests.cpp > > Lines 741 (patched) > > > > > > Why do we need to explicitly set this flag to such a large number? I ended

Re: Review Request 60765: Added basic `network/ports` isolator tests.

2017-09-07 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60765/ --- (Updated Sept. 7, 2017, 9:57 p.m.) Review request for mesos, Qian Zhang and

Re: Review Request 60495: Added network ports isolator listen socket utilities.

2017-09-07 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60495/ --- (Updated Sept. 7, 2017, 9:50 p.m.) Review request for mesos, Qian Zhang and

Re: Review Request 60492: Added a `network/ports` isolator skeleton.

2017-09-07 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60492/ --- (Updated Sept. 7, 2017, 9:50 p.m.) Review request for mesos, Qian Zhang and

Re: Review Request 62047: Allowed look up latest executor directory by virtual path.

2017-09-07 Thread Zhitao Li
> On Sept. 6, 2017, 9:28 p.m., Benjamin Mahler wrote: > > src/slave/slave.cpp > > Lines 7466-7470 (original), 7484-7491 (patched) > > > > > > What was going on here originally with the two different calls? rebase

Re: Review Request 62047: Allowed look up latest executor directory by virtual path.

2017-09-07 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62047/ --- (Updated Sept. 7, 2017, 9:18 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 62040: Also log attached virtual path in agent.

2017-09-07 Thread Zhitao Li
> On Sept. 6, 2017, 8:57 p.m., Benjamin Mahler wrote: > > src/slave/slave.hpp > > Lines 377-378 (original), 377-379 (patched) > > > > > > How about path and virtualPath here and "virtual path" in the logging? > >

Review Request 62174: Replace name with virtualPath in files API.

2017-09-07 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62174/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-7899

Re: Review Request 62040: Also log attached virtual path in agent.

2017-09-07 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62040/ --- (Updated Sept. 7, 2017, 9:16 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 62166: Updated RC tagging+voting mechanism.

2017-09-07 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62166/#review184857 --- docs/release-guide.md Lines 162-164 (original), 162-164

Re: Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards.

2017-09-07 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62042/#review184871 --- ERROR: Failed to apply patch 61920. Please check

Re: Review Request 62166: Updated RC tagging+voting mechanism.

2017-09-07 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62166/#review184869 --- FAIL: Some Mesos tests failed. Please check

Re: Review Request 60890: WIP: Defined API for launching standalone containers.

2017-09-07 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60890/#review184866 --- Fix it, then Ship it! include/mesos/agent/agent.proto Lines

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

2017-09-07 Thread Jie Yu
> On Sept. 6, 2017, 11:32 p.m., Jie Yu wrote: > > src/slave/slave.hpp > > Lines 658 (patched) > > > > > > I am not sure if keeping another field just for resoruce provider > > provided resources in the agent is a

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

2017-09-07 Thread Jie Yu
> On Sept. 6, 2017, 11:32 p.m., Jie Yu wrote: > > src/slave/slave.hpp > > Lines 658 (patched) > > > > > > I am not sure if keeping another field just for resoruce provider > > provided resources in the agent is a

Re: Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards.

2017-09-07 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62042/ --- (Updated Sept. 7, 2017, 6:09 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards.

2017-09-07 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62042/#review184850 --- ERROR: Failed to apply patch 61920. Please check

Review Request 62166: Updated RC tagging+voting mechanism.

2017-09-07 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62166/ --- Review request for mesos, Anand Mazumdar, Till Toenshoff, Vinod Kone, and

Re: Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards.

2017-09-07 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62042/#review184847 --- I think this needs a rebase; I got a conflict in

Re: Review Request 61947: Implemented handling of resource provider offer operations.

2017-09-07 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61947/#review184844 --- ERROR: Failed to apply patch 57911. Please check

Re: Review Request 62162: Revert usage of `-isystem` flag.

2017-09-07 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62162/#review184834 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 62140: Shorten the default interval between disk-usage GCs.

2017-09-07 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62140/#review184836 --- FAIL: Some Mesos tests failed. Please check

Re: Review Request 62147: Added a comment about master sending a checkpointed resources message.

2017-09-07 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62147/#review184835 --- FAIL: Some Mesos tests failed. Please check

Re: Review Request 62148: Made the `stop()` logic in the scheduler library simpler.

2017-09-07 Thread Anand Mazumdar
> On Sept. 7, 2017, 3:33 p.m., Benjamin Hindman wrote: > > include/mesos/v1/scheduler.hpp > > Lines 25 (patched) > > > > > > Have we pulled in libprocess dependencies in public headers in the past? hmm, most of our

Re: Review Request 62148: Made the `stop()` logic in the scheduler library simpler.

2017-09-07 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62148/#review184823 --- include/mesos/v1/scheduler.hpp Lines 25 (patched)

Review Request 62162: Revert usage of `-isystem` flag.

2017-09-07 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62162/ --- Review request for mesos. Repository: mesos Description --- This flag

Review Request 62161: Update boost version.

2017-09-07 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62161/ --- Review request for mesos. Repository: mesos Description --- Update

Review Request 62160: Fix stout build with newer boost versions.

2017-09-07 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62160/ --- Review request for mesos. Repository: mesos Description --- Starting

Re: Review Request 62140: Shorten the default interval between disk-usage GCs.

2017-09-07 Thread Chun-Hung Hsiao
> On Sept. 7, 2017, 12:05 p.m., Alexander Rukletsov wrote: > > src/slave/constants.hpp > > Line 74 (original), 74 (patched) > > > > > > I know it is hard to justify specific values, but `1s` feels too > >

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

2017-09-07 Thread Benjamin Bannier
> On Sept. 7, 2017, 1:32 a.m., Jie Yu wrote: > > src/slave/slave.hpp > > Lines 658 (patched) > > > > > > I am not sure if keeping another field just for resoruce provider > > provided resources in the agent is a

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

2017-09-07 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- (Updated Sept. 7, 2017, 5:13 p.m.) Review request for mesos, Jie Yu and Jan

Review Request 62158: Rescinded offers possibly affected by updates to agent total resources.

2017-09-07 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62158/ --- Review request for mesos, Jie Yu and Jan Schlicht. Bugs: MESOS-7757

Re: Review Request 62148: Made the `stop()` logic in the scheduler library simpler.

2017-09-07 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62148/#review184820 --- FAIL: Some Mesos tests failed. Please check

Re: Review Request 61947: Implemented handling of resource provider offer operations.

2017-09-07 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61947/ --- (Updated Sept. 7, 2017, 2:27 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 62140: Shorten the default interval between disk-usage GCs.

2017-09-07 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62140/#review184814 --- src/slave/constants.hpp Line 74 (original), 74 (patched)

Re: Review Request 61558: Move duplicate comment closer to implementation.

2017-09-07 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61558/ --- (Updated Sept. 7, 2017, 12:06 p.m.) Review request for mesos and Alexander

Re: Review Request 62145: WIP: Implemented Standalone Container API.

2017-09-07 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62145/#review184812 --- ERROR: Failed to apply patch 61805 Reviews applied: [61805,

Re: Review Request 62047: Allowed look up latest executor directory by virtual path.

2017-09-07 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62047/#review184811 --- FAIL: Some Mesos tests failed. Please check

Re: Review Request 61495: Add documentation for possible task reasons.

2017-09-07 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61495/#review184810 --- Fix it, then Ship it! I'll fix the last issue and commit this

Re: Review Request 62106: Enabled CRAM MD5 Authentication on Windows and associated tests.

2017-09-07 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62106/#review184805 --- FAIL: Mesos tests failed to build. Please check