Re: Review Request 62336: Kicked in disk monitoring early during recovery.

2017-09-14 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62336/#review185469 --- FAIL: Some Mesos tests failed. Reviews applied: `['62252',

Re: Review Request 62344: Made `Slave::checkDiskUsage` return a `Future`.

2017-09-14 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62344/#review185467 --- FAIL: Some Mesos tests failed. Reviews applied: `['62252',

Re: Review Request 62252: Added `process::Executor::execute()`.

2017-09-14 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62252/ --- (Updated Sept. 15, 2017, 3:17 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 62336: Kicked in disk monitoring early during recovery.

2017-09-14 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62336/ --- (Updated Sept. 15, 2017, 2 a.m.) Review request for mesos, Benjamin Mahler,

Review Request 62344: Made `Slave::checkDiskUsage` return a `Future`.

2017-09-14 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62344/ --- Review request for mesos, Benjamin Mahler, Jie Yu, and Vinod Kone. Bugs:

Review Request 62343: Made `GarbageCollector::prune` return a `Future`.

2017-09-14 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62343/ --- Review request for mesos, Benjamin Mahler, Jie Yu, and Vinod Kone. Bugs:

Re: Review Request 62252: Added `process::Executor::execute()`.

2017-09-14 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62252/#review185464 --- 3rdparty/libprocess/include/process/executor.hpp Lines 62

Re: Review Request 62297: Moved pid namespace isolator doc to the isolators folder.

2017-09-14 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62297/#review185425 --- docs/isolators/namespaces-pid.md Lines 26 (patched)

Re: Review Request 62298: Moved disk du isolator doc to the isolators folder.

2017-09-14 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62298/#review185461 --- Fix it, then Ship it! docs/isolators/disk-du.md Lines 13

Re: Review Request 62299: Moved xfs disk isolator doc to the isolators folder.

2017-09-14 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62299/#review185460 --- Ship it! Ship It! - James Peach On Sept. 13, 2017, 8:49

Re: Review Request 62300: Moved docker runtime isolator doc to the isolators folder.

2017-09-14 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62300/#review185427 --- docs/isolators/docker-runtime.md Lines 24 (patched)

Re: Review Request 62302: Moved docker volume isolator doc to the isolators folder.

2017-09-14 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62302/#review185429 --- docs/docker-volume.md Line 291 (original), 291 (patched)

Re: Review Request 62301: Moved cgroups net_cls isolator doc to the isolators folder.

2017-09-14 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62301/#review185428 --- docs/isolators/cgroups-net-cls.md Lines 15 (patched)

Re: Review Request 62322: Added initial doc for container volumes.

2017-09-14 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62322/#review185456 --- docs/container-volume.md Lines 23 (patched)

Re: Review Request 62306: Added an index in the mesos containerizer doc about isolators.

2017-09-14 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62306/#review185435 --- docs/mesos-containerizer.md Lines 29 (patched)

Re: Review Request 62308: Added the description for the isolators section.

2017-09-14 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62308/#review185434 --- docs/mesos-containerizer.md Lines 18 (patched)

Re: Review Request 62336: [WIP] Kicked in disk monitoring early during recovery.

2017-09-14 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62336/#review185459 --- FAIL: Some Mesos tests failed. Reviews applied: `['62336']`

Re: Review Request 62214: Added JavaScript linter.

2017-09-14 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review185453 --- FAIL: Some Mesos tests failed. Reviews applied: `['62332',

Re: Review Request 62246: Added workaround for a docker bug in docker build helper.

2017-09-14 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62246/#review185448 --- FAIL: Some Mesos tests failed. Reviews applied: `['62246']`

Re: Review Request 62336: [WIP] Kicked in disk monitoring early during recovery.

2017-09-14 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62336/ --- (Updated Sept. 14, 2017, 7:17 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 62327: Checked TASK_KILLED in the test `ROOT_INTERNET_CURL_PortMapper`.

2017-09-14 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62327/#review185440 --- FAIL: Some Mesos tests failed. Reviews applied: `['62326',

Review Request 62336: Kicked in disk monitoring early during recovery.

2017-09-14 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62336/ --- Review request for mesos, Benjamin Mahler, Jie Yu, and Vinod Kone. Bugs:

Re: Review Request 62307: Added gpu/nvidia isolator to the index.

2017-09-14 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62307/#review185433 --- Ship it! Ship It! - James Peach On Sept. 13, 2017, 8:51

Re: Review Request 62305: Moved posix rlimits isolator doc to the isolators folder.

2017-09-14 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62305/#review185432 --- Ship it! Ship It! - James Peach On Sept. 13, 2017, 8:51

Re: Review Request 62246: Added workaround for a docker bug in docker build helper.

2017-09-14 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62246/#review185422 --- PASS: Mesos patch 62246 was successfully built and tested.

Re: Review Request 62322: Added initial doc for container volumes.

2017-09-14 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62322/#review185421 --- FAIL: Some Mesos tests failed. Reviews applied: `['62295',

Re: Review Request 62214: Added JavaScript linter.

2017-09-14 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/ --- (Updated Sept. 14, 2017, 3:59 p.m.) Review request for mesos, Benjamin Mahler

Review Request 62333: Added class for linters using a virtual environment.

2017-09-14 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62333/ --- Review request for mesos, Benjamin Mahler and Kevin Klues. Bugs: MESOS-7924

Review Request 62332: Linted JavaScript files.

2017-09-14 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62332/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-7978

Re: Review Request 62162: Revert usage of `-isystem` flag.

2017-09-14 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62162/ --- (Updated Sept. 14, 2017, 12:52 p.m.) Review request for mesos, Benjamin

Re: Review Request 62018: Updated logging::initialize to make flags optional.

2017-09-14 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62018/#review185394 --- Ship it! Ship It! - Andrei Budnik On Sept. 14, 2017, 8:34

Re: Review Request 62037: Added logging::initialize to main functions that use glog.

2017-09-14 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62037/#review185390 --- FAIL: Some Mesos tests failed. Reviews applied: `['62018',

Review Request 62327: Checked TASK_KILLED in the test `ROOT_INTERNET_CURL_PortMapper`.

2017-09-14 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62327/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-7975

Review Request 62326: Always send TASK_KILLED when the task is killed.

2017-09-14 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62326/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-7975

Re: Review Request 62037: Added logging::initialize to main functions that use glog.

2017-09-14 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62037/ --- (Updated Sept. 14, 2017, 8:36 a.m.) Review request for mesos, Andrei Budnik

Re: Review Request 62018: Updated logging::initialize to make flags optional.

2017-09-14 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62018/ --- (Updated Sept. 14, 2017, 8:34 a.m.) Review request for mesos, Andrei Budnik

Re: Review Request 62322: Added initial doc for container volumes.

2017-09-14 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62322/#review185382 --- FAIL: The filename, directory name, or volume label syntax is