Re: Review Request 62365: Added the missing isolators to the doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62365/#review185518 --- FAIL: Some Mesos tests failed. Reviews applied: `['62295', '62296

Re: Review Request 60496: Added socket checking to the network ports isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60496/#review185517 --- src/slave/containerizer/mesos/isolators/network/ports.cpp Lines 4

Re: Review Request 62322: Added initial doc for container volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62322/ --- (Updated Sept. 16, 2017, 1:50 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 62308: Added the description for the isolators section.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62308/ --- (Updated Sept. 16, 2017, 1:49 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 62302: Moved docker volume isolator doc to the isolators folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62302/ --- (Updated Sept. 16, 2017, 1:46 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 62301: Moved cgroups net_cls isolator doc to the isolators folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62301/ --- (Updated Sept. 16, 2017, 1:45 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 62300: Moved docker runtime isolator doc to the isolators folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62300/ --- (Updated Sept. 16, 2017, 1:44 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 62298: Moved disk du isolator doc to the isolators folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62298/ --- (Updated Sept. 16, 2017, 1:43 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 62297: Moved pid namespace isolator doc to the isolators folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62297/ --- (Updated Sept. 16, 2017, 1:42 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 62296: Moved shared filesystem isolator doc to the isolators folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62296/ --- (Updated Sept. 16, 2017, 1:41 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 62295: Moved port mapping isolator doc to the isolators folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62295/ --- (Updated Sept. 16, 2017, 1:40 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 62322: Added initial doc for container volumes.

> On Sept. 15, 2017, 12:05 a.m., James Peach wrote: > > docs/container-volume.md > > Lines 97 (patched) > > > > > > This explanation was not very clear to me. What is the problem you > > could solve with a symlink?

Re: Review Request 62306: Added an index in the mesos containerizer doc about isolators.

> On Sept. 15, 2017, 12:05 a.m., James Peach wrote: > > docs/mesos-containerizer.md > > Lines 29 (patched) > > > > > > Can you append the undocumented isolators to the list? > > > > - network/port_mapping > >

Review Request 62365: Added the missing isolators to the doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62365/ --- Review request for mesos, Gilbert Song and James Peach. Repository: mesos Des

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/#review185509 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 62214: Added JavaScript linter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review185507 --- Patch looks great! Reviews applied: [62332, 62333, 62214] Passed

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/#review185506 --- Patch looks great! Reviews applied: [60491, 60493, 60494, 60764,

Re: Review Request 62357: Updated logging initialization arguments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62357/#review185502 --- FAIL: Some Mesos tests failed. Reviews applied: `['62018', '62037

Re: Review Request 62358: Replaced xlocale.h with locale.h.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62358/#review185500 --- Ship it! Ship It! - Till Toenshoff On Sept. 15, 2017, 6:10 p

Re: Review Request 62358: Replaced xlocale.h with locale.h.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62358/ --- (Updated Sept. 15, 2017, 2:10 p.m.) Review request for mesos and Till Toenshoff

Review Request 62358: Replaced xlocale.h with locale.h.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62358/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-7980 https://issue

Re: Review Request 62336: Kicked in disk monitoring early during recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62336/#review185496 --- Patch looks great! Reviews applied: [62252, 62230, 62343, 62344,

Re: Review Request 62037: Added logging::initialize to main functions that use glog.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62037/#review185495 --- FAIL: Some Mesos tests failed. Reviews applied: `['62018', '62037

Review Request 62357: Updated logging initialization arguments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62357/ --- Review request for mesos, Andrei Budnik and Alexander Rukletsov. Bugs: MESOS-75

Re: Review Request 62322: Added initial doc for container volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62322/#review185491 --- Patch looks great! Reviews applied: [62295, 62296, 62297, 62298,

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/#review185483 --- Bad review! Error: No reviewers specified. Please find a reviewer

Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'.

> On Sept. 13, 2017, 2:34 a.m., Jie Yu wrote: > > src/common/resources.cpp > > Lines 185 (patched) > > > > > > hum, i think we also need to check? wondering if we need to fix the > > rest. > > ``` > > if (le

Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/ --- Review request for mesos. Repository: mesos Description --- This patch a

Re: Review Request 61528: Implemented a registrar for resource provider manager state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61528/ --- (Updated Sept. 15, 2017, 3:16 p.m.) Review request for mesos, Jie Yu and Jan Sc

Re: Review Request 62158: Rescinded offers possibly affected by updates to agent total resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62158/ --- (Updated Sept. 15, 2017, 3:15 p.m.) Review request for mesos, Jie Yu and Jan Sc

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- (Updated Sept. 15, 2017, 3:15 p.m.) Review request for mesos, Jie Yu and Jan Sc

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62212/#review185478 --- src/launcher/default_executor.cpp Line 1379 (original), 1396 (pat

Re: Review Request 62246: Added workaround for a docker bug in docker build helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62246/#review185477 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 13, 2017, 6

Re: Review Request 62214: Added JavaScript linter.

> On Sept. 11, 2017, 7:18 p.m., Benjamin Mahler wrote: > > support/mesos-style.py > > Lines 307-311 (patched) > > > > > > Similarly to my comment below, if we had some virtual env abstraction > > this could be runni

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

> On Sept. 6, 2017, 9 p.m., Qian Zhang wrote: > > src/tests/containerizer/ports_isolator_tests.cpp > > Lines 1051-1052 (patched) > > > > > > Can you please elaborate a bit about this? What do you mean for `the > >