Re: Review Request 62553: Fixed a flaky test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62553/#review186204 --- Patch looks great! Reviews applied: [62203, 62553] Passed

Re: Review Request 62554: Added the ability to prune the gone agent list from the registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62554/#review186194 --- PASS: Mesos patch 62554 was successfully built and tested.

Re: Review Request 62554: Added the ability to prune the gone agent list from the registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62554/#review186193 --- Patch looks great! Reviews applied: [62475, 62476, 62477, 62478,

Re: Review Request 59687: Added tests for recovering ContainerConfig.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59687/#review186192 --- Fix it, then Ship it! This patch LGTM.

Re: Review Request 55335: Backfilled required fields in TaskInfo in MesosContainerizer* tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55335/#review186191 --- src/tests/containerizer/mesos_containerizer_tests.cpp Line 714

Re: Review Request 62553: Fixed a flaky test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62553/#review186190 --- Fix it, then Ship it!

Re: Review Request 62554: Added the ability to prune the gone agent list from the registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62554/#review186189 --- src/master/flags.cpp Lines 610-629 (patched)

Re: Review Request 62531: Added authorization for 'MARK_AGENT_GONE' call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62531/#review186187 --- Ship it! Ship It! - Vinod Kone On Sept. 25, 2017, 5:22

Re: Review Request 62507: Added documentation about 'MARK_AGENT_GONE' call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62507/#review186186 --- Ship it! Ship It! - Vinod Kone On Sept. 22, 2017, 6:15

Re: Review Request 62481: Fixed tests impacted by no longer removing the agent symlink.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62481/#review186185 --- src/tests/slave_recovery_tests.cpp Line 3137 (original), 3137

Re: Review Request 62481: Fixed tests impacted by no longer removing the agent symlink.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62481/#review186184 --- src/tests/gc_tests.cpp Line 384 (original), 374 (patched)

Re: Review Request 62480: Added tests for the agent gone operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62480/#review186183 --- Ship it! Ship It! - Vinod Kone On Sept. 21, 2017, 8:28

Re: Review Request 62553: Fixed a flaky test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62553/#review186181 --- PASS: Mesos patch 62553 was successfully built and tested.

Re: Review Request 62479: Removed the logic for removing the latest symlink on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62479/#review186180 --- src/slave/slave.cpp Line 889 (original)

Re: Review Request 55334: Checkpoint and recover `ContainerConfig` in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55334/#review186159 --- could you rebase this chain? sorry for the delay, but thank you,

Re: Review Request 62478: Added the mark agent gone handler on the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62478/#review186177 --- src/master/http.cpp Lines 5312-5338 (patched)

Re: Review Request 62477: Added the gone agents to the master registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62477/#review186178 --- src/master/registry.proto Lines 60 (patched)

Re: Review Request 62477: Added the gone agents to the master registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62477/#review186176 --- src/master/master.hpp Lines 2306 (patched)

Re: Review Request 62477: Added the gone agents to the master registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62477/#review186174 --- Ship it! Ship It! - Vinod Kone On Sept. 21, 2017, 8:27

Re: Review Request 62476: Added the `REASON_AGENT_REMOVED_BY_OPERATOR` to the mesos protos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62476/#review186172 --- Ship it! Ship It! - Vinod Kone On Sept. 21, 2017, 9:38

Re: Review Request 62475: Added `MARK_AGENT_GONE` call to the v1 Master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62475/#review186171 --- Fix it, then Ship it! include/mesos/master/master.proto Lines

Review Request 62554: Added the ability to prune the gone agent list from the registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62554/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-7448

Review Request 62553: Fixed a flaky test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62553/ --- Review request for mesos, Gilbert Song and Jie Yu. Repository: mesos

Re: Review Request 61109: Used the default value when parsing an optional enum field from JSON.

> On Sept. 8, 2017, 11:59 p.m., James Peach wrote: > > This looks pretty reasonable to me. It's unfortunate that this will convert > > all invalid enum names into the default value, but AFAICT that is > > unavoidable. > > Benjamin Mahler wrote: > Since we're talking about optional enums,

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/#review186165 --- FAIL: Failed to apply the dependent review: 62282. Failed

Re: Review Request 62548: Reorganized and updated the contribution guidelines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62548/#review186161 --- Patch looks great! Reviews applied: [62548] Passed command:

Re: Review Request 59019: Updated the documentation for '--docker_registry' option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59019/#review186160 --- FAIL: Some Mesos tests failed. Reviews applied: `['59019']`

Re: Review Request 62252: Added `process::Executor::execute()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62252/ --- (Updated Sept. 25, 2017, 8:48 p.m.) Review request for mesos, Benjamin

Re: Review Request 59019: Updated the documentation for '--docker_registry' option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59019/#review186155 --- docs/configuration.md Lines 1516 (patched)

Re: Review Request 62252: Added `process::Executor::execute()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62252/#review186154 --- Fix it, then Ship it! Just a few minor cleanups and then I'll

Re: Review Request 61528: Implemented a registrar for resource provider manager state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61528/ --- (Updated Sept. 25, 2017, 9:42 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- (Updated Sept. 25, 2017, 9:42 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/ --- (Updated Sept. 25, 2017, 9:42 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 62548: Reorganized and updated the contribution guidelines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62548/#review186153 --- PASS: Mesos patch 62548 was successfully built and tested.

Re: Review Request 59019: Updated the documentation for '--docker_registry' option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59019/ --- (Updated Sept. 25, 2017, 7:22 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 62531: Added authorization for 'MARK_AGENT_GONE' call.

> On Sept. 25, 2017, 7:19 a.m., Mesos Reviewbot Windows wrote: > > FAIL: Some Mesos tests failed. > > > > Reviews applied: `['62475', '62476', '62477', '62478', '62479', '62480', > > '62481', '62507', '62531']` > > > > Failed command: `C:\mesos\src\mesos-tests.exe --verbose > >

Re: Review Request 62531: Added authorization for 'MARK_AGENT_GONE' call.

> On Sept. 25, 2017, 12:19 a.m., Mesos Reviewbot Windows wrote: > > FAIL: Some Mesos tests failed. > > > > Reviews applied: `['62475', '62476', '62477', '62478', '62479', '62480', > > '62481', '62507', '62531']` > > > > Failed command: `C:\mesos\src\mesos-tests.exe --verbose > >

Re: Review Request 59019: Updated the documentation for '--docker_registry' option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59019/#review186148 --- Fix it, then Ship it! could you also fix the doc at

Re: Review Request 62381: Removed `docker exec` when performing health checks in docker executor.

> On Sept. 19, 2017, 11:13 p.m., Gastón Kleiman wrote: > > src/tests/health_check_tests.cpp > > Lines 1121 (patched) > > > > > > I think that we have to use `TEST_F_TEMP_DISABLED_ON_WINDOWS` here. This test passes

Re: Review Request 62548: Reorganized and updated the contribution guidelines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62548/ --- (Updated Sept. 25, 2017, 6:02 p.m.) Review request for mesos, Andrew

Review Request 62548: Reorganized and updated the contribution guidelines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62548/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, and Vinod Kone.

Re: Review Request 62518: Fixed default executor handling of nested container status.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62518/#review186139 --- PASS: Mesos patch 62518 was successfully built and tested.

Re: Review Request 62214: Added JavaScript linter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review186138 --- PASS: Mesos patch 62214 was successfully built and tested.

Re: Review Request 62518: Fixed default executor handling of nested container status.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62518/#review186134 --- Patch looks great! Reviews applied: [62518] Passed command:

Re: Review Request 62518: Fixed default executor handling of nested container status.

> On Sept. 25, 2017, 12:42 a.m., Qian Zhang wrote: > > Why do we need to change those .py files? I do not see you mentioned it in > > the commit message. AFAICT `post-reviews` gets confused if you `git fetch` without doing a `git pull` and you end up including spurious changes. Removed them.

Re: Review Request 62518: Fixed default executor handling of nested container status.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62518/ --- (Updated Sept. 25, 2017, 3:21 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 62214: Added JavaScript linter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/ --- (Updated Sept. 25, 2017, 2:56 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 62333: Added class for linters using a virtual environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62333/ --- (Updated Sept. 25, 2017, 2:55 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 62333: Added class for linters using a virtual environment.

> On Sept. 19, 2017, 10:35 p.m., Benjamin Mahler wrote: > > support/mesos-style.py > > Lines 253-254 (patched) > > > > > > Is this clear to you? I don't understand why there is this distinction. > > My intuition

Re: Review Request 61212: Added CLI utility functions to verify addresses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61212/ --- (Updated Sept. 25, 2017, 2:26 p.m.) Review request for mesos and Kevin Klues.

Re: Review Request 61211: Added default configuration file for CLI tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61211/ --- (Updated Sept. 25, 2017, 2:03 p.m.) Review request for mesos and Kevin Klues.

Re: Review Request 60088: CLI: Added 'master' key as an acceptable key in config.toml.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60088/ --- (Updated Sept. 25, 2017, 2:03 p.m.) Review request for mesos and Kevin Klues.

Review Request 62544: Updated pylint to increase the maximum number of branches in a function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62544/ --- Review request for mesos and Kevin Klues. Repository: mesos Description

Re: Review Request 61528: Implemented a registrar for resource provider manager state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61528/#review186113 --- Fix it, then Ship it! Look great! Only found some nits.

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/#review186112 --- Fix it, then Ship it! src/slave/slave.cpp Lines 6619

Re: Review Request 62285: Added tombstone flag to NOP log action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62285/ --- (Updated Sept. 25, 2017, 2:05 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 62285: Added tombstone flag to NOP log action.

> On Sept. 25, 2017, 5:12 a.m., Jie Yu wrote: > > src/log/leveldb.cpp > > Lines 247 (patched) > > > > > > I would combine this condition with the condition in `else if` above. Done! > On Sept. 25, 2017, 5:12

Re: Review Request 62438: Ignored redundant agent resources updates in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62438/#review186109 --- Ship it! Ship It! - Jan Schlicht On Sept. 22, 2017, 5:03

Re: Review Request 62158: Rescinded offers possibly affected by updates to agent total resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62158/#review186108 --- Ship it! Ship It! - Jan Schlicht On Sept. 20, 2017, 4:24

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/#review186101 --- FAIL: Failed to apply the dependent review: 62282. Failed

Re: Review Request 61528: Implemented a registrar for resource provider manager state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61528/ --- (Updated Sept. 25, 2017, 12:27 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- (Updated Sept. 25, 2017, 12:28 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/ --- (Updated Sept. 25, 2017, 12:27 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 62531: Added authorization for 'MARK_AGENT_GONE' call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62531/#review186090 --- Patch looks great! Reviews applied: [62475, 62476, 62477, 62478,

Re: Review Request 62531: Added authorization for 'MARK_AGENT_GONE' call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62531/#review186088 --- FAIL: Some Mesos tests failed. Reviews applied: `['62475',