Re: Review Request 62214: Added JavaScript linter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review186770 --- Patch looks great! Reviews applied: [62333, 62214] Passed

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review186737 --- As I commented on the JIRA, we should probably bring the work for

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review186763 --- FAIL: Some Mesos tests failed. Reviews applied: `['61172']`

Re: Review Request 62698: Fixed the clang complation problem for the executor tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62698/#review186762 --- FAIL: Some Mesos tests failed. Reviews applied: `['62698']`

Re: Review Request 62687: Added utility function to get data from a master endpoint to CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62687/#review186760 --- Bad patch! Reviews applied: [62687, 62663] Failed command:

Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62213/#review186752 --- FAIL: Some Mesos tests failed. Reviews applied: `['62212',

Re: Review Request 62698: Fixed the clang complation problem for the executor tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62698/ --- (Updated Sept. 29, 2017, 10:18 p.m.) Review request for mesos, Benjamin

Re: Review Request 62698: Fixed the clang complation error for the executor tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62698/#review186749 --- Ship it! Ship It! - Benjamin Hindman On Sept. 29, 2017,

Review Request 62698: Fixed the clang complation error for the executor tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62698/ --- Review request for mesos, Benjamin Hindman and Vinod Kone. Repository: mesos

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/ --- (Updated Sept. 29, 2017, 9:25 p.m.) Review request for mesos, Armand Grillet,

Re: Review Request 61174: Added a test `ProtobufTest.ParseJSONUnrecognizedEnum`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61174/#review186742 --- Fix it, then Ship it! 3rdparty/stout/tests/protobuf_tests.cpp

Re: Review Request 62696: Updated error messages in `getMountNamespaceTarget()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62696/#review186741 --- PASS: Mesos patch 62696 was successfully built and tested.

Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62213/ --- (Updated Sept. 29, 2017, 7:48 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62212/ --- (Updated Sept. 29, 2017, 7:48 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

> On Sept. 15, 2017, 11:36 a.m., Andrei Budnik wrote: > > src/launcher/default_executor.cpp > > Line 1379 (original), 1396 (patched) > > > > > > If a default executor is allowed to call `launchGroup` more than

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

> On Sept. 13, 2017, 5:29 p.m., Andrei Budnik wrote: > > src/launcher/default_executor.cpp > > Line 326 (original), 332 (patched) > > > > > > Should we update the comment above? I think the comment is still

Re: Review Request 62168: Added a test using a file URI and the DefaultExecutor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62168/ --- (Updated Sept. 29, 2017, 12:06 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 62632: Added a test using Docker, a file URI, and the DefaultExecutor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62632/#review186722 --- Ship it! Ship It! - Vinod Kone On Sept. 27, 2017, 9:50

Re: Review Request 59987: Added protobuf map support.

> On Sept. 22, 2017, 11:19 p.m., Chun-Hung Hsiao wrote: > > 3rdparty/stout/include/stout/protobuf.hpp > > Lines 433 (patched) > > > > > > The key can also be of an integral type. > > Qian Zhang wrote: > Yeah, I

Re: Review Request 59987: Added protobuf map support.

> On Sept. 22, 2017, 11:14 p.m., Chun-Hung Hsiao wrote: > > 3rdparty/stout/include/stout/protobuf.hpp > > Lines 413 (patched) > > > > > > Not sure if it is cleaner to parse the map here because we're > >

Re: Review Request 61109: Used the default value when parsing an optional enum field from JSON.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61109/#review186710 --- Fix it, then Ship it! Thanks guys, let's just clarify the

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review186615 --- src/master/http.cpp Lines 324 (patched)

Re: Review Request 61174: Added a test `ProtobufTest.ParseJSONUnrecognizedEnum`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61174/#review186707 --- Fix it, then Ship it! 3rdparty/stout/tests/protobuf_tests.cpp

Review Request 62696: Updated error messages in `getMountNamespaceTarget()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62696/ --- Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jan Schlicht.

Re: Review Request 62479: Removed the logic for removing the latest symlink on the agent.

> On Sept. 26, 2017, 6:58 p.m., Vinod Kone wrote: > > Can you also add a blurb to CHANGELOG about the new semantics? I think it's > > worth calling out. > > Vinod Kone wrote: > don't forget this! Yep! I need to add the Agent Lifecycle feature to the `CHANGELOG`; so would do it as part

Re: Review Request 62638: Removed support for platforms without O_CLOEXEC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62638/#review186703 --- Patch looks great! Reviews applied: [62638] Passed command:

Re: Review Request 62554: Added the ability to prune the gone agent list from the registry.

> On Sept. 26, 2017, 10:11 p.m., Mesos Reviewbot Windows wrote: > > FAIL: Some Mesos tests failed. > > > > Reviews applied: `['62475', '62476', '62477', '62581', '62478', '62479', > > '62480', '62481', '62507', '62531', '62554']` > > > > Failed command: `C:\mesos\src\mesos-tests.exe --verbose

Re: Review Request 62326: Always send TASK_KILLED when the task is killed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62326/#review186697 --- Ship it! Ship It! - Gaston Kleiman On Sept. 29, 2017, 12:33

Re: Review Request 62661: Added --disable-libtool-wrapper configuration to Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62661/#review186696 --- PASS: Mesos patch 62661 was successfully built and tested.

Re: Review Request 62327: Checked TASK_KILLED in the test `ROOT_INTERNET_CURL_PortMapper`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62327/#review186695 --- Can you also add tests for command and default executors to test

Re: Review Request 62326: Always send TASK_KILLED when the task is killed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62326/#review186694 --- Ship it! Summary "Always send TASK_KILLED when the task is

Re: Review Request 62685: Updated the comments of TASK_FINISHED to make it more clear.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62685/#review186693 --- Ship it! Ship It! - Vinod Kone On Sept. 29, 2017, 7:32

Re: Review Request 62479: Removed the logic for removing the latest symlink on the agent.

> On Sept. 26, 2017, 6:58 p.m., Vinod Kone wrote: > > Can you also add a blurb to CHANGELOG about the new semantics? I think it's > > worth calling out. don't forget this! - Vinod --- This is an automatically generated e-mail. To

Re: Review Request 62554: Added the ability to prune the gone agent list from the registry.

> On Sept. 26, 2017, 10:11 p.m., Mesos Reviewbot Windows wrote: > > FAIL: Some Mesos tests failed. > > > > Reviews applied: `['62475', '62476', '62477', '62581', '62478', '62479', > > '62480', '62481', '62507', '62531', '62554']` > > > > Failed command: `C:\mesos\src\mesos-tests.exe --verbose

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review186685 --- src/python/lib/mesos/exceptions.py Lines 21 (patched)

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review186680 --- Looks like this needs a rebase. I can't get it to apply cleanly.

Re: Review Request 62214: Added JavaScript linter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review186679 --- PASS: Mesos patch 62214 was successfully built and tested.

Re: Review Request 59987: Added protobuf map support.

> On Sept. 23, 2017, 7:14 a.m., Chun-Hung Hsiao wrote: > > 3rdparty/stout/include/stout/protobuf.hpp > > Lines 413 (patched) > > > > > > Not sure if it is cleaner to parse the map here because we're > >

Re: Review Request 62661: Added --disable-libtool-wrapper configuration to Mesos.

> On Sept. 29, 2017, 12:30 p.m., Benjamin Bannier wrote: > > configure.ac > > Lines 234-238 (patched) > > > > > > We currently have two such comment blocks which are not identical, one > > in `configure.ac` and one

Re: Review Request 62214: Added JavaScript linter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/ --- (Updated Sept. 29, 2017, 1:28 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 62333: Added helper functions for linters using a virtual environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62333/ --- (Updated Sept. 29, 2017, 1:23 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 62661: Added --disable-libtool-wrapper configuration to Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62661/#review186668 --- PASS: Mesos patch 62661 was successfully built and tested.

Re: Review Request 62661: Added --disable-libtool-wrapper configuration to Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62661/#review186663 --- Fix it, then Ship it! configure.ac Lines 234-238 (patched)

Re: Review Request 62661: Added --disable-libtool-wrapper configuration to Mesos.

> On Sept. 28, 2017, 5:22 p.m., Benjamin Bannier wrote: > > configure.ac > > Lines 243 (patched) > > > > > > Let's not explicitly specify the different branches here and instead > > let autoconf handle it for us,

Re: Review Request 62687: Added utility function to get data from a master endpoint to CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62687/#review186660 --- FAIL: Failed to apply the dependent review: 62663. Failed

Re: Review Request 61174: Added a test `ProtobufTest.ParseJSONUnrecognizedEnum`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61174/#review186659 --- PASS: Mesos patch 61174 was successfully built and tested.

Review Request 62687: Added utility function to get data from a master endpoint to CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62687/ --- Review request for mesos and Kevin Klues. Repository: mesos Description

Re: Review Request 59987: Added protobuf map support.

> On Sept. 23, 2017, 7:19 a.m., Chun-Hung Hsiao wrote: > > 3rdparty/stout/include/stout/protobuf.hpp > > Lines 433 (patched) > > > > > > The key can also be of an integral type. Yeah, I had the same concern before.

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

> On Sept. 29, 2017, 5:33 a.m., Jie Yu wrote: > > src/tests/oversubscription_tests.cpp > > Lines 324-329 (original), 333-338 (patched) > > > > > > Do you need to update those tests? This particular test case

Re: Review Request 62158: Rescinded offers possibly affected by updates to agent total resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62158/ --- (Updated Sept. 29, 2017, 11:14 a.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- (Updated Sept. 29, 2017, 11:14 a.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 62655: Made 'UpdateSlaveMessage' a union of possible updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62655/ --- (Updated Sept. 29, 2017, 11:14 a.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 61174: Added a test `ProtobufTest.ParseJSONUnrecognizedEnum`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61174/ --- (Updated Sept. 29, 2017, 4:47 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 62326: Always send TASK_KILLED when the task is killed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62326/ --- (Updated Sept. 29, 2017, 3:33 p.m.) Review request for mesos, Anand Mazumdar

Review Request 62685: Updated the comments of TASK_FINISHED to make it more clear.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62685/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-7975

Re: Review Request 62326: Always send TASK_KILLED when the task is killed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62326/ --- (Updated Sept. 29, 2017, 2:55 p.m.) Review request for mesos, Anand Mazumdar