Re: Review Request 60511: Added MockMetadataManager and test concurrent prune and pull.

2017-10-03 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60511/#review187035 --- Patch looks great! Reviews applied: [55334, 55335, 59687, 56721,

Re: Review Request 60511: Added MockMetadataManager and test concurrent prune and pull.

2017-10-03 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60511/#review187032 --- PASS: Mesos patch 60511 was successfully built and tested.

Re: Review Request 62742: Handled discarded case in launch nested container handler.

2017-10-03 Thread Jie Yu
> On Oct. 3, 2017, 4:46 p.m., Zhitao Li wrote: > > src/slave/http.cpp > > Lines 2408-2409 (original), 2408-2409 (patched) > > > > > > It seems like this TODO has already been addressed? Is there still a > >

Re: Review Request 62733: Organized configuration documentation.

2017-10-03 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62733/ --- (Updated Oct. 3, 2017, 4:20 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 62732: Added CMake documentation.

2017-10-03 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62732/#review187021 --- TODO: Add link to this to the general "Documentation" page. It's

Re: Review Request 62287: Added Log::Reader::catchup() method.

2017-10-03 Thread Ilya Pronin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62287/ --- (Updated Oct. 4, 2017, 12:18 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 62286: Added CatchupMissing log process.

2017-10-03 Thread Ilya Pronin
> On Sept. 25, 2017, 5:36 a.m., Jie Yu wrote: > > src/log/recover.cpp > > Lines 652 (patched) > > > > > > Putting this in `recover.cpp|hpp` is very wierd. I am leaning towards > > moving this too `catchup.hpp|cpp`

Re: Review Request 62286: Added CatchupMissing log process.

2017-10-03 Thread Ilya Pronin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62286/ --- (Updated Oct. 4, 2017, 12:16 a.m.) Review request for mesos and Jie Yu.

Review Request 62761: Moved retry logic from RecoverProtocolProcess to RecoverProcess.

2017-10-03 Thread Ilya Pronin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62761/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7973

Review Request 62760: Exposed runRecoverProtocol() function in recover.hpp.

2017-10-03 Thread Ilya Pronin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62760/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7973

Re: Review Request 60511: Added MockMetadataManager and test concurrent prune and pull.

2017-10-03 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60511/#review187017 --- FAIL: /usr/bin/rm: cannot remove 'C:mesos/CMakeFiles': Directory

Re: Review Request 62742: Handled discarded case in launch nested container handler.

2017-10-03 Thread Jie Yu
> On Oct. 3, 2017, 6:48 p.m., Benjamin Mahler wrote: > > src/slave/http.cpp > > Lines 2408-2409 (original), 2408-2409 (patched) > > > > > > Should we also mention that a discarded launch (due to the http > >

Re: Review Request 62732: Added CMake documentation.

2017-10-03 Thread Andrew Schwartzmeyer
> On Oct. 2, 2017, 3:26 p.m., Joseph Wu wrote: > > docs/cmake-examples.md > > Lines 268 (patched) > > > > > > This should have been caught by the linter. Yeah... it should have, especially considering I wrote this

Re: Review Request 56721: Implemented pruneImages with a mark and sweep in docker store.

2017-10-03 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56721/ --- (Updated Oct. 3, 2017, 8:24 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 60511: Added MockMetadataManager and test concurrent prune and pull.

2017-10-03 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60511/ --- (Updated Oct. 3, 2017, 8:24 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 62661: Added --disable-libtool-wrapper configuration to Mesos.

2017-10-03 Thread Andrei Budnik
> On Oct. 3, 2017, 6:58 p.m., Kapil Arya wrote: > > So is the idea to turn on this flag for ASF CI builds? Yes, exactly. - Andrei --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 62661: Added --disable-libtool-wrapper configuration to Mesos.

2017-10-03 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62661/#review186991 --- Ship it! So is the idea to turn on this flag for ASF CI

Re: Review Request 62742: Handled discarded case in launch nested container handler.

2017-10-03 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62742/#review186989 --- Fix it, then Ship it! src/slave/http.cpp Lines 2408-2409

Re: Review Request 56721: Implemented pruneImages with a mark and sweep in docker store.

2017-10-03 Thread Zhitao Li
> On Oct. 3, 2017, 1:19 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp > > Lines 209-211 (patched) > > > > > > three scenarios: > > 1. checkpointed cache is

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

2017-10-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/#review186984 --- Ship it! Ship It! - Jie Yu On Sept. 29, 2017, 9:14 a.m.,

Re: Review Request 62158: Rescinded offers possibly affected by updates to agent total resources.

2017-10-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62158/#review186983 --- Fix it, then Ship it! src/master/master.cpp Line 6841

Re: Review Request 62655: Made 'UpdateSlaveMessage' a union of possible updates.

2017-10-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62655/#review186982 --- Fix it, then Ship it! src/master/master.cpp Lines 6841-6843

Re: Review Request 56721: Implemented pruneImages with a mark and sweep in docker store.

2017-10-03 Thread Zhitao Li
> On Oct. 3, 2017, 1:19 a.m., Gilbert Song wrote: > > src/slave/containerizer/containerizer.hpp > > Lines 156-157 (patched) > > > > > > maybe return failure in this virtual function by default? so that you > >

Re: Review Request 56721: Implemented pruneImages with a mark and sweep in docker store.

2017-10-03 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56721/ --- (Updated Oct. 3, 2017, 5:13 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 62648: Added a test for nested container resource limitations.

2017-10-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62648/#review186974 --- Fix it, then Ship it! src/tests/default_executor_tests.cpp

Re: Review Request 62616: Binary packaging for Centos 7.

2017-10-03 Thread Jie Yu
> On Oct. 3, 2017, 4:54 p.m., James Peach wrote: > > support/packaging/centos/6/mesos.spec > > Lines 56 (patched) > > > > > > ``` > > --enable-hardening \ > > --enable-port-mapping-isolator \ > >

Re: Review Request 62616: Binary packaging for Centos 7.

2017-10-03 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62616/#review186971 --- support/packaging/centos/7/mesos.spec Lines 33 (patched)

Re: Review Request 62616: Binary packaging for Centos 7.

2017-10-03 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62616/#review186959 --- I accidentally made most of my comments on the CentOS6 spec file,

Re: Review Request 62734: Added --markdown and --target-people to post-reviews.py.

2017-10-03 Thread Andrew Schwartzmeyer
> On Oct. 2, 2017, 4:50 p.m., Mesos Reviewbot Windows wrote: > > FAIL: Some Mesos tests failed. > > > > Reviews applied: `['62734']` > > > > Failed command: `C:\mesos\src\mesos-tests.exe --verbose > > --gtest_filter="-ContentType/MasterAPITest.EventAuthorizationFiltering/1"` > > > > All the

Re: Review Request 62647: Show resource limitations in mesos-execute.

2017-10-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62647/#review186970 --- Ship it! Ship It! - Jie Yu On Sept. 28, 2017, 12:19 a.m.,

Re: Review Request 62646: Propagated new wait response fields from the default executor.

2017-10-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62646/#review186966 --- Fix it, then Ship it! src/launcher/default_executor.cpp Lines

Re: Review Request 62644: Added resources to the TaskStatus message.

2017-10-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62644/#review186968 --- src/slave/slave.cpp Lines 6962-6965 (patched)

Re: Review Request 62644: Added resources to the TaskStatus message.

2017-10-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62644/#review186964 --- Ship it! Ship It! - Jie Yu On Sept. 28, 2017, 12:19 a.m.,

Re: Review Request 62742: Handled discarded case in launch nested container handler.

2017-10-03 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62742/#review186963 --- src/slave/http.cpp Lines 2408-2409 (original), 2408-2409

Re: Review Request 62643: Propagated the container termination to the agent API.

2017-10-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62643/#review186962 --- Fix it, then Ship it! include/mesos/agent/agent.proto Lines

Re: Review Request 62642: Propagated the termination info down the container tree.

2017-10-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62642/#review186960 --- Ship it! Ship It! - Jie Yu On Sept. 28, 2017, 12:20 a.m.,

Re: Review Request 62616: Binary packaging for Centos 7.

2017-10-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62616/#review186958 --- Here are some requirements that I would love to achieve as part

Re: Review Request 62641: Removed multiple reasons from ContainerTermination.

2017-10-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62641/#review186956 --- Ship it! Ship It! - Jie Yu On Sept. 28, 2017, 12:20 a.m.,

Re: Review Request 62640: Stopped keeping multiple limitations in MesosContainerizer.

2017-10-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62640/#review186955 --- Ship it! Ship It! - Jie Yu On Sept. 28, 2017, 12:20 a.m.,

Re: Review Request 62638: Removed support for platforms without O_CLOEXEC.

2017-10-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62638/#review186954 --- Ship it! Ship It! - Jie Yu On Sept. 27, 2017, 10:20 p.m.,

Re: Review Request 62696: Updated error messages in `getMountNamespaceTarget()`.

2017-10-03 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62696/#review186943 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 2, 2017,

Re: Review Request 62743: Synced the MTU for container eth0 in port mapping isolator.

2017-10-03 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62743/#review186942 --- PASS: Mesos patch 62743 was successfully built and tested.

Re: Review Request 62739: Added a test using DefaultExecutor + health check + persistent volume.

2017-10-03 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62739/#review186939 --- Patch looks great! Reviews applied: [62739] Passed command:

Re: Review Request 62743: Synced the MTU for container eth0 in port mapping isolator.

2017-10-03 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62743/#review186936 --- PASS: Mesos patch 62743 was successfully built and tested.

Re: Review Request 62742: Handled discarded case in launch nested container handler.

2017-10-03 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62742/#review186932 --- PASS: Mesos patch 62742 was successfully built and tested.