Re: Review Request 60467: Fixed race in configureSignal and installCtrlHandler.

2017-10-13 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60467/#review188061 --- Fix it, then Ship it! src/slave/posix_signalhandler.hpp Lines

Re: Review Request 56721: Implemented pruneImages with a mark and sweep in docker store.

2017-10-13 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56721/ --- (Updated Oct. 14, 2017, 3:11 a.m.) Review request for mesos, Gilbert Song,

Review Request 62997: Added checkpoint and recover capability for layers in provisioner.

2017-10-13 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62997/ --- Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu. Bugs:

Re: Review Request 62241: Added SchedulerHttpApiTest.UpdateHttpToPidSchedulerAndBack test.

2017-10-13 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62241/#review188053 --- Looks good, just a few minor things to clean up.

Re: Review Request 62240: Removed metrics removal from Master::failoverFramework().

2017-10-13 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62240/#review188052 --- Ship it! Ship It! - Anand Mazumdar On Sept. 12, 2017, 12:59

Re: Review Request 62777: Fixed build dependency for `protobuf_tests.proto`.

2017-10-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62777/#review188045 --- PASS: Mesos patch 62777 was successfully built and tested.

Re: Review Request 62973: Optimized RepeatedPtrField to vector conversion.

2017-10-13 Thread Dmitry Zhuk
> On Oct. 13, 2017, 7:06 p.m., Benjamin Mahler wrote: > > Ship It! > > Benjamin Mahler wrote: > I couldn't figure out where std::vector documents this optimization, so I > avoided declaring this was an optimization in favor of saying that this > allows for optimization if the vector

Re: Review Request 62616: Binary packaging for Centos 7.

2017-10-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62616/#review188029 --- PASS: Mesos patch 62616 was successfully built and tested.

Re: Review Request 60623: Converted "file://" URI handling to use new uri function.

2017-10-13 Thread Andrew Schwartzmeyer
> On Oct. 7, 2017, 8:37 p.m., Andrew Schwartzmeyer wrote: > > Same comment for style on summary as before, also missing description. Also > > URI is inconsistently capitalized ;) This still needs to be addressed. - Andrew --- This is

Re: Review Request 60628: Enabled fetcher_tests.cpp unit test module on Windows platform.

2017-10-13 Thread Andrew Schwartzmeyer
> On Oct. 13, 2017, 12:28 p.m., Andrew Schwartzmeyer wrote: > > src/tests/fetcher_tests.cpp > > Line 483 (original), 487 (patched) > > > > > > Was this URL using backslashes for some reason? This doesn't appear to

Re: Review Request 60622: Added new stout functions for path normalizaiton and URI conversion.

2017-10-13 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60622/#review188011 --- 3rdparty/stout/include/stout/path.hpp Lines 28-46 (patched)

Re: Review Request 60621: Added new stout capability: os::copyfile(source, dest).

2017-10-13 Thread Andrew Schwartzmeyer
> On Oct. 7, 2017, 7:56 p.m., Andrew Schwartzmeyer wrote: > > The commit message needs to be in the past tense, and generally you can > > ignore mentioning stout as the files imply it (though it still gets > > mentioned in commits a lot). E.g.:: > > > > > Added `os::copyfile(from, to)`. > > >

Re: Review Request 60620: Modifed os::write to write binary files on Windows.

2017-10-13 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60620/#review188007 --- This still needs a description (currently it's just a copy of the

Re: Review Request 60628: Enabled fetcher_tests.cpp unit test module on Windows platform.

2017-10-13 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60628/#review188003 --- As far as I can tell, this review is enabling the `mesos-fetcher`

Re: Review Request 62980: Added link anchors to all website headings.

2017-10-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62980/#review188004 --- PASS: Mesos patch 62980 was successfully built and tested.

Re: Review Request 60624: Enabled HDFS compilation and associated tests.

2017-10-13 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60624/#review188002 --- This review should be combined with #60626.

Re: Review Request 62973: Optimized RepeatedPtrField to vector conversion.

2017-10-13 Thread Benjamin Mahler
> On Oct. 13, 2017, 7:06 p.m., Benjamin Mahler wrote: > > Ship It! I couldn't figure out where std::vector documents this optimization, so I avoided declaring this was an optimization in favor of saying that this allows for optimization if the vector implementation leverages the distance

Re: Review Request 62980: Added link anchors to all website headings.

2017-10-13 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62980/#review188000 --- Patch looks great! Reviews applied: [62980] Passed command:

Re: Review Request 62973: Optimized RepeatedPtrField to vector conversion.

2017-10-13 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62973/#review187998 --- Ship it! Ship It! - Benjamin Mahler On Oct. 13, 2017, 1:20

Re: Review Request 62974: Disallowed combining resource providers and CheckpointResourcesMessage.

2017-10-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62974/#review187997 --- Ship it! Ship It! - Jie Yu On Oct. 13, 2017, 1:39 p.m.,

Re: Review Request 62777: Fixed build dependency for `protobuf_tests.proto`.

2017-10-13 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62777/ --- (Updated Oct. 13, 2017, 6:24 p.m.) Review request for mesos and Benjamin

Re: Review Request 62616: Binary packaging for Centos 7.

2017-10-13 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62616/ --- (Updated Oct. 13, 2017, 2:21 p.m.) Review request for mesos, Benno Evers, Till

Re: Review Request 62616: Binary packaging for Centos 7.

2017-10-13 Thread Kapil Arya
> On Oct. 6, 2017, 2:11 p.m., Benno Evers wrote: > > support/packaging/common/mesos-master.service > > Lines 7 (patched) > > > > > > If this is to be common for all packaging, probably it should be > >

Re: Review Request 62616: Binary packaging for Centos 7.

2017-10-13 Thread Kapil Arya
> On Oct. 3, 2017, 12:57 p.m., James Peach wrote: > > support/packaging/centos/7/mesos.spec > > Lines 33 (patched) > > > > > > Handling the SVN dependency is a bit quirky. If you do what you have > > done here, you

Re: Review Request 62616: Binary packaging for Centos 7.

2017-10-13 Thread Kapil Arya
> On Oct. 3, 2017, 12:54 p.m., James Peach wrote: > > I accidentally made most of my comments on the CentOS6 spec file, but they > > apply to the CentOS7 one too. I'm not sure how tractable it is to use the > > same spec file for both platforms, but combining them would be helpful if > > you

Re: Review Request 62616: Binary packaging for Centos 7.

2017-10-13 Thread Kapil Arya
> On Oct. 2, 2017, 1:17 p.m., Jie Yu wrote: > > Thanks for the comments, Jie! The updated scripts allow for building from a local tree from a command line. I'd add a README shortly. > On Oct. 2, 2017, 1:17 p.m., Jie Yu wrote: > > support/packaging/centos/6/Dockerfile > > Lines 5 (patched) >

Re: Review Request 62959: Added doc for filesystem isolators.

2017-10-13 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62959/#review187983 --- docs/container-volume.md Line 57 (original), 57 (patched)

Re: Review Request 62616: Binary packaging for Centos 7.

2017-10-13 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62616/ --- (Updated Oct. 13, 2017, 2:02 p.m.) Review request for mesos, Benno Evers, Till

Re: Review Request 62974: Disallowed combining resource providers and CheckpointResourcesMessage.

2017-10-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62974/#review187984 --- PASS: Mesos patch 62974 was successfully built and tested.

Re: Review Request 62965: Added doc for cgroups devices isolator.

2017-10-13 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62965/#review187980 --- Is there any interaction with capabilities or filesystem

Re: Review Request 62974: Disallowed combining resource providers and CheckpointResourcesMessage.

2017-10-13 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62974/#review187982 --- Patch looks great! Reviews applied: [62974] Passed command:

Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update.

2017-10-13 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62213/ --- (Updated Oct. 13, 2017, 5:01 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 62980: Added link anchors to all website headings.

2017-10-13 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62980/ --- (Updated Oct. 13, 2017, 4:58 p.m.) Review request for mesos, Greg Mann and

Review Request 62980: Added link anchors to all website headings.

2017-10-13 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62980/ --- Review request for mesos, Greg Mann and Vinod Kone. Repository: mesos

Re: Review Request 62973: Optimized RepeatedPtrField to vector conversion.

2017-10-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62973/#review187968 --- PASS: Mesos patch 62973 was successfully built and tested.

Re: Review Request 62973: Optimized RepeatedPtrField to vector conversion.

2017-10-13 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62973/#review187966 --- Patch looks great! Reviews applied: [62973] Passed command:

Re: Review Request 62880: Marked the agent as RESOURCE_PROVIDER capable.

2017-10-13 Thread Benjamin Bannier
> On Oct. 12, 2017, 5:39 p.m., Benjamin Bannier wrote: > > I would much prefer if we'd add another patch before this that modifies the > > agent to e.g., fail over should it receive a `CheckpointResourcesMessage` > > and has this capability. Offer operation feedback and > >

Review Request 62974: Disallowed combining resource providers and CheckpointResourcesMessage.

2017-10-13 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62974/ --- Review request for mesos, Jie Yu and Jan Schlicht. Bugs: MESOS-8058

Review Request 62973: Optimized RepeatedPtrField to vector conversion.

2017-10-13 Thread Dmitry Zhuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62973/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 62899: Added protobuf message passing benchmark.

2017-10-13 Thread Dmitry Zhuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62899/ --- (Updated Oct. 13, 2017, 12:55 p.m.) Review request for mesos and Benjamin

Re: Review Request 60467: Fixed race in configureSignal and installCtrlHandler.

2017-10-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60467/#review187956 --- PASS: Mesos patch 60467 was successfully built and tested.

Re: Review Request 62502: Added events to publish and unpublish resources.

2017-10-13 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62502/ --- (Updated Oct. 13, 2017, 2:01 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 60467: Fixed race in configureSignal and installCtrlHandler.

2017-10-13 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60467/#review187952 --- Patch looks great! Reviews applied: [60467] Passed command:

Re: Review Request 62502: Added events to publish and unpublish resources.

2017-10-13 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62502/ --- (Updated Oct. 13, 2017, 1:20 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 60467: Fixed race in configureSignal and installCtrlHandler.

2017-10-13 Thread Dmitry Zhuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60467/ --- (Updated Oct. 13, 2017, 10:47 a.m.) Review request for mesos, Alexander

Re: Review Request 62965: Added doc for cgroups devices isolator.

2017-10-13 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62965/#review187943 --- Bad patch! Reviews applied: [62965, 62959] Failed command:

Re: Review Request 62964: Re-organized the documentation table of contents.

2017-10-13 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62964/#review187938 --- Bad patch! Reviews applied: [62964] Failed command: python

Re: Review Request 62966: Add a couple libprocess examples.

2017-10-13 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62966/#review187936 --- Patch looks great! Reviews applied: [62966] Passed command: