Re: Review Request 62502: Added events to publish and unpublish resources.

> On Oct. 17, 2017, 8:48 p.m., Jie Yu wrote: > > include/mesos/resource_provider/resource_provider.proto > > Lines 38 (patched) > > > > > > No need for `UNPUBLISH` for now. Let's introduce it once we actually > >

Re: Review Request 62502: Added events to publish and unpublish resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62502/#review188455 --- FAIL: Failed to apply the dependent review: 62282. Failed

Re: Review Request 60471: Added tests for pruneImages for containerizer and provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60471/#review188454 --- FAIL: Mesos tests failed to build. Reviews applied: `['55334',

Re: Review Request 62903: Added a call to update total resources and pending operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62903/#review188452 --- Patch looks great! Reviews applied: [63001, 62903] Passed

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review188451 --- include/mesos/resource_provider/resource_provider.proto Lines

Re: Review Request 60890: Defined API for launching standalone containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60890/#review188449 --- include/mesos/agent/agent.proto Lines 230 (patched)

Re: Review Request 62142: Moved GPU resource validation into common file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62142/#review188448 --- Ship it! Ship It! - Jie Yu On Oct. 16, 2017, 11:43 p.m.,

Re: Review Request 60891: Added ACLs and AuthZ for standalone containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60891/#review188447 --- include/mesos/authorizer/acls.proto Lines 435-437 (patched)

Re: Review Request 60890: Defined API for launching standalone containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60890/#review188445 --- include/mesos/agent/agent.proto Lines 437-440 (patched)

Re: Review Request 62502: Added events to publish and unpublish resources.

> On Oct. 17, 2017, 8:48 p.m., Jie Yu wrote: > > include/mesos/resource_provider/resource_provider.proto > > Lines 38 (patched) > > > > > > No need for `UNPUBLISH` for now. Let's introduce it once we actually > >

Re: Review Request 60889: Added basic tests for launching standalone containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60889/#review188443 --- Ship it! Ship It! - Jie Yu On Oct. 16, 2017, 11:27 p.m.,

Re: Review Request 63018: Added filesystem layout for local resource providers.

> On Oct. 18, 2017, 12:37 a.m., Jie Yu wrote: > > src/slave/paths.hpp > > Lines 59 (patched) > > > > > > It would be nice to call out what will be stored under this directory. > > For instance, csi endpoint, and

Review Request 63095: Added the Getting Started landing page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63095/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 63093: Moved building docs to `building.md`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63093/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 62502: Added events to publish and unpublish resources.

> On Sept. 22, 2017, 7:05 p.m., Chun-Hung Hsiao wrote: > > include/mesos/resource_provider/resource_provider.proto > > Lines 56 (patched) > > > > > > Can you elaborate the needs of `uuid` and `framework_id`? We need

Re: Review Request 62502: Added events to publish and unpublish resources.

> On Oct. 17, 2017, 8:48 p.m., Jie Yu wrote: > > include/mesos/resource_provider/resource_provider.proto > > Lines 38 (patched) > > > > > > No need for `UNPUBLISH` for now. Let's introduce it once we actually > >

Re: Review Request 61536: Added network ports isolator socket utilities tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61536/#review188438 --- src/tests/containerizer/ports_isolator_tests.cpp Lines 99

Re: Review Request 62912: Added tests for RWMutex.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62912/#review188437 --- Patch looks great! Reviews applied: [62911, 62912] Passed

Re: Review Request 62912: Added tests for RWMutex.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62912/#review188434 --- PASS: Mesos patch 62912 was successfully built and tested.

Re: Review Request 60628: Enabled fetcher_tests.cpp unit test module on Windows platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60628/#review188433 --- src/launcher/fetcher.cpp Lines 192-211 (original), 198-209

Re: Review Request 63022: Imported resources from CSI plugins in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63022/ --- (Updated Oct. 18, 2017, 1:20 a.m.) Review request for mesos, James DeFelice,

Re: Review Request 63018: Added filesystem layout for local resource providers.

> On Oct. 18, 2017, 12:37 a.m., Jie Yu wrote: > > src/slave/paths.hpp > > Lines 59 (patched) > > > > > > It would be nice to call out what will be stored under this directory. > > For instance, csi endpoint, and

Re: Review Request 60626: Eliminated os::shell calls from HDFS for Windows compatibility.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60626/#review188428 --- Needs a description still. src/hdfs/hdfs.cpp Lines 125-134

Re: Review Request 63018: Added filesystem layout for local resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63018/#review188183 --- Fix it, then Ship it! src/slave/paths.hpp Lines 59 (patched)

Re: Review Request 62880: Marked the agent as RESOURCE_PROVIDER capable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62880/#review188426 --- Patch looks great! Reviews applied: [63001, 62877, 62878, 62879,

Re: Review Request 63017: Added storage resource provider information in ResourceProviderInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63017/#review188425 --- Ship it! Ship It! - Jie Yu On Oct. 16, 2017, 5:58 p.m.,

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/#review188422 --- FAIL: Failed to apply the dependent review: 60491. Failed

Re: Review Request 62903: Added a call to update total resources and pending operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62903/ --- (Updated Oct. 17, 2017, 11:45 p.m.) Review request for mesos, Benjamin

Re: Review Request 62880: Marked the agent as RESOURCE_PROVIDER capable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62880/#review188421 --- PASS: Mesos patch 62880 was successfully built and tested.

Re: Review Request 62880: Marked the agent as RESOURCE_PROVIDER capable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62880/ --- (Updated Oct. 17, 2017, 11:25 p.m.) Review request for mesos, Benjamin

Re: Review Request 62879: Stopped sending checkpoint resources message on agent re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62879/ --- (Updated Oct. 17, 2017, 11:25 p.m.) Review request for mesos, Benjamin

Re: Review Request 60624: Enabled HDFS compilation and associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60624/#review188418 --- src/tests/hdfs_tests.cpp Lines 55-57 (original), 55-60 (patched)

Re: Review Request 62878: Sent CheckpointResourcesMessage only when reregister with an old master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62878/ --- (Updated Oct. 17, 2017, 11:24 p.m.) Review request for mesos, Benjamin

Re: Review Request 62877: Added RESOURCE_PROVIDER agent capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62877/ --- (Updated Oct. 17, 2017, 11:24 p.m.) Review request for mesos, Benjamin

Re: Review Request 60623: Converted "file://" URI handling to use new uri function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60623/#review188417 --- Ship it! Ship It! - Andrew Schwartzmeyer On Oct. 16, 2017,

Re: Review Request 60622: Added new stout functions for path and URI conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60622/#review188414 --- 3rdparty/stout/include/stout/path.hpp Lines 45-52 (patched)

Re: Review Request 60621: Added new stout capability: os::copyfile(source, dest).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60621/#review188413 --- Ship it! Looks good to me other than some funky indentation.

Re: Review Request 60620: Modifed os::write to write binary files on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60620/#review188412 --- 3rdparty/stout/include/stout/os/write.hpp Lines 107 (patched)

Review Request 63094: Added resource sequence id for offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63094/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Chun-Hung Hsiao,

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/ --- (Updated Oct. 17, 2017, 10:10 p.m.) Review request for mesos, Benjamin

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 17, 2017, 10:02 p.m., Greg Mann wrote: > > include/mesos/mesos.proto > > Lines 2178 (patched) > > > > > > Let's make this `optional` to handle cases where we send > > `OfferOperationStatus` messages

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review188403 --- include/mesos/mesos.proto Lines 2178 (patched)

Re: Review Request 62911: Added a RWMutex to libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62911/#review188392 --- 3rdparty/libprocess/include/process/rwmutex.hpp Lines 28

Re: Review Request 62903: Added the `UPDATE_TOTAL_RESOURCES` call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62903/#review188396 --- include/mesos/resource_provider/resource_provider.proto Lines 94

Re: Review Request 63084: Fixed a missing transformResources case in master::updateSlave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63084/#review188398 --- PASS: Mesos patch 63084 was successfully built and tested.

Re: Review Request 63074: Changed return type of `ns::getns()` from `Try` to `Result`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63074/#review188395 --- src/linux/ns.hpp Lines 246 (patched)

Re: Review Request 62903: Added the `UPDATE_TOTAL_RESOURCES` call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62903/ --- (Updated Oct. 17, 2017, 8:50 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 62502: Added events to publish and unpublish resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62502/#review188386 --- include/mesos/resource_provider/resource_provider.proto Lines 38

Re: Review Request 62903: Added the `UPDATE_TOTAL_RESOURCES` call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62903/ --- (Updated Oct. 17, 2017, 8:29 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/ --- (Updated Oct. 17, 2017, 8:10 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 62912: Added tests for RWMutex.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62912/ --- (Updated Oct. 17, 2017, 7:56 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 62911: Added a RWMutex to libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62911/ --- (Updated Oct. 17, 2017, 7:56 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 62911: Added a RWMutex to libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62911/ --- (Updated Oct. 17, 2017, 7:55 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 60471: Added tests for pruneImages for containerizer and provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60471/#review188372 --- FAIL: Mesos tests failed to build. Reviews applied: `['55334',

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review188366 --- src/resource_provider/validation.cpp Line 59 (original), 59

Re: Review Request 60593: Added `network/ports` isolator recovery tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60593/ --- (Updated Oct. 17, 2017, 7:14 p.m.) Review request for mesos, Qian Zhang and

Re: Review Request 60766: Ignored containers that join CNI networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60766/ --- (Updated Oct. 17, 2017, 7:13 p.m.) Review request for mesos, Qian Zhang and

Re: Review Request 60888: Added recovery logic for standalone containers.

> On Oct. 17, 2017, 10:42 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.cpp > > Lines 850 (patched) > > > > > > Some isolator might be surprised by standalone containers. Is there a > > patch

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/ --- (Updated Oct. 17, 2017, 7:15 p.m.) Review request for mesos, Qian Zhang and

Re: Review Request 62891: Increased level of verbose logs for libprocess actor state transitions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62891/#review188363 --- Ship it! Seems fine to me, I’m more interested in the overall

Re: Review Request 62880: Marked the agent as RESOURCE_PROVIDER capable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62880/ --- (Updated Oct. 17, 2017, 7 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 62879: Stopped sending checkpoint resources message on agent re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62879/ --- (Updated Oct. 17, 2017, 7 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 62878: Sent CheckpointResourcesMessage only when reregister with an old master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62878/ --- (Updated Oct. 17, 2017, 6:59 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 16, 2017, 6:33 p.m., Greg Mann wrote: > > src/messages/messages.proto > > Lines 637-638 (patched) > > > > > > I think that this list should include pending operations, but should > > _not_ include

Re: Review Request 62877: Added RESOURCE_PROVIDER agent capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62877/ --- (Updated Oct. 17, 2017, 6:59 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63076: Windows: Fixed off-by-one error in long path support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63076/#review188361 --- Patch looks great! Reviews applied: [63076] Passed command:

Re: Review Request 63076: Windows: Fixed off-by-one error in long path support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63076/#review188360 --- PASS: Mesos patch 63076 was successfully built and tested.

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/ --- (Updated Oct. 17, 2017, 6:52 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/ --- (Updated Oct. 17, 2017, 6:49 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/ --- (Updated Oct. 17, 2017, 6:49 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63084: Fixed a missing transformResources case in master::updateSlave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63084/ --- (Updated Oct. 17, 2017, 6:38 p.m.) Review request for mesos, Benjamin Bannier

Review Request 63084: Fixed a missing transformResources case in master::updateSlave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63084/ --- Review request for mesos and Michael Park. Bugs: MESOS-8090

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 17, 2017, 5:59 p.m., Greg Mann wrote: > > src/messages/messages.proto > > Lines 633-639 (patched) > > > > > > I think we also need to include this field in the > > `ReregisterSlaveMessage`, right? That

Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62213/ --- (Updated Oct. 17, 2017, 6:14 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 17, 2017, 5:59 p.m., Greg Mann wrote: > > src/messages/messages.proto > > Lines 633-639 (patched) > > > > > > I think we also need to include this field in the > > `ReregisterSlaveMessage`, right? That

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review188350 --- src/messages/messages.proto Lines 633-639 (patched)

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review188340 --- include/mesos/mesos.proto Lines 2187-2195 (patched)

Re: Review Request 60888: Added recovery logic for standalone containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60888/#review188345 --- src/slave/containerizer/mesos/containerizer.cpp Lines 850

Re: Review Request 60888: Added recovery logic for standalone containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60888/#review188334 --- Fix it, then Ship it!

Re: Review Request 60471: Added tests for pruneImages for containerizer and provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60471/ --- (Updated Oct. 17, 2017, 5:06 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 62997: Added checkpoint and recover capability for layers in provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62997/ --- (Updated Oct. 17, 2017, 5:04 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 63035: Made `getMountNamespaceTarget` more reliable by ignoring exited childs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63035/#review188328 --- Patch looks great! Reviews applied: [63074, 63035] Passed

Review Request 63076: Windows: Fixed off-by-one error in long path support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63076/ --- Review request for mesos and Joseph Wu. Repository: mesos Description

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 17, 2017, 3:45 p.m., Jan Schlicht wrote: > > include/mesos/mesos.proto > > Lines 2187-2195 (patched) > > > > > > Is the master supposed to keep a `map > Offer::Operation>`? If not,

Re: Review Request 60471: Added tests for pruneImages for containerizer and provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60471/#review188324 --- FAIL: Failed to apply the dependent review: 62997. Failed

Re: Review Request 63035: Made `getMountNamespaceTarget` more reliable by ignoring exited childs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63035/#review188323 --- PASS: Mesos patch 63035 was successfully built and tested.

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review188286 --- include/mesos/mesos.proto Lines 2187-2195 (patched)

Re: Review Request 60471: Added tests for pruneImages for containerizer and provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60471/ --- (Updated Oct. 17, 2017, 3:31 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 62853: Added test for `PRUNE_IMAGES` operator API call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62853/ --- (Updated Oct. 17, 2017, 3:30 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 17, 2017, 1:17 p.m., James DeFelice wrote: > > include/mesos/mesos.proto > > Lines 111 (patched) > > > > > > unique in the context of the framework? or universally unique? in the context of the framework.

Re: Review Request 59987: Added protobuf map support.

> On Oct. 17, 2017, 7:15 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/protobuf.hpp > > Line 1 (original), 1 (patched) > > > > > > We should call out that we have a hard requirement on proto3 now in

Re: Review Request 62891: Increased level of verbose logs for libprocess actor state transitions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62891/#review188315 --- Patch looks great! Reviews applied: [62891] Passed command:

Re: Review Request 62891: Increased level of verbose logs for libprocess actor state transitions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62891/#review188314 --- PASS: Mesos patch 62891 was successfully built and tested.

Re: Review Request 63035: Made `getMountNamespaceTarget` more reliable by ignoring exited childs.

> On Oct. 16, 2017, 5:05 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/utils.cpp > > Line 75 (original), 75 (patched) > > > > > > I think we can make `ns::getns` return a `Result`. Returnning > > `None()`

Re: Review Request 63035: Made `getMountNamespaceTarget` more reliable by ignoring exited childs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63035/ --- (Updated Oct. 17, 2017, 1:45 p.m.) Review request for mesos, Alexander

Review Request 63074: Changed return type of `ns::getns()` from `Try` to `Result`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63074/ --- Review request for mesos, Alexander Rukletsov, Jie Yu, and Kevin Klues. Bugs:

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review188305 --- include/mesos/mesos.proto Lines 111 (patched)

Re: Review Request 62886: Increased level of some verbose logs from allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62886/#review188301 --- PASS: Mesos patch 62886 was successfully built and tested.

Re: Review Request 62886: Increased level of some verbose logs from allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62886/#review188296 --- Ship it! Ship It! - Till Toenshoff On Oct. 11, 2017, 1:29

Re: Review Request 62886: Increased level of some verbose logs from allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62886/#review188294 --- Patch looks great! Reviews applied: [62886] Passed command:

  1   2   >