Re: Review Request 63022: Imported resources from CSI plugins in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63022/ --- (Updated Oct. 19, 2017, 3:54 a.m.) Review request for mesos, James DeFelice,

Re: Review Request 63021: Added functions to launch CSI plugin in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63021/ --- (Updated Oct. 19, 2017, 3:49 a.m.) Review request for mesos, James DeFelice,

Re: Review Request 63017: Added storage resource provider information in ResourceProviderInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63017/ --- (Updated Oct. 19, 2017, 3:23 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63017: Added storage resource provider information in ResourceProviderInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63017/#review188629 --- include/mesos/v1/mesos.proto Lines 976 (patched)

Re: Review Request 63104: Added a helper to extract resources from storage operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63104/#review188625 --- src/common/protobuf_utils.hpp Lines 188 (patched)

Re: Review Request 63107: Added operation feedback for storage operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63107/#review188618 --- Not a complete review yet. Will take look again once existing

Re: Review Request 63095: Added the Getting Started landing page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63095/#review188622 --- Patch looks great! Reviews applied: [62548, 63093, 63095]

Re: Review Request 63094: Added resource version uuid for offer operations.

> On Oct. 18, 2017, 9:46 a.m., Benjamin Bannier wrote: > > include/mesos/resource_provider/resource_provider.proto > > Lines 56-66 (patched) > > > > > > I would prefer if we would not assume that this number changes

Re: Review Request 63094: Added resource version uuid for offer operations.

> On Oct. 18, 2017, 9:46 a.m., Benjamin Bannier wrote: > > include/mesos/resource_provider/resource_provider.proto > > Lines 56-66 (patched) > > > > > > I would prefer if we would not assume that this number changes

Re: Review Request 63094: Added resource version uuid for offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63094/ --- (Updated Oct. 19, 2017, 12:10 a.m.) Review request for mesos, Benjamin

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/ --- (Updated Oct. 19, 2017, 12:08 a.m.) Review request for mesos, Benjamin

Re: Review Request 62911: Added a RWMutex to libprocess.

> On Oct. 17, 2017, 9:56 p.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/include/process/rwmutex.hpp > > Lines 28 (patched) > > > > > > Did a scan of other libraries, interestingly these are named pretty > >

Re: Review Request 63095: Added the Getting Started landing page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63095/#review188591 --- PASS: Mesos patch 63095 was successfully built and tested.

Re: Review Request 62911: Added a RWMutex to libprocess.

> On Oct. 17, 2017, 9:56 p.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/include/process/rwmutex.hpp > > Lines 28 (patched) > > > > > > Did a scan of other libraries, interestingly these are named pretty > >

Re: Review Request 62980: Added link anchors to all website headings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62980/#review188573 --- Ship it! I just verified this using the web development Docker

Re: Review Request 63107: Added operation feedback for storage operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63107/#review188571 --- Bad patch! Reviews applied: [63107, 63106, 61947, 63105, 61946,

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

> On Oct. 17, 2017, 5:51 p.m., Greg Mann wrote: > > include/mesos/mesos.proto > > Lines 2187-2195 (patched) > > > > > > We also need to include a unique UUID for each operation status update, > > so that the

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review188565 --- Since we're designing the RP API, I'd prefer to only expose

Re: Review Request 63116: Mesos UI: fixed use of undefined variable for the pailer title.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63116/#review188559 --- PASS: Mesos patch 63116 was successfully built and tested.

Re: Review Request 62548: Reorganized and updated the contribution guidelines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62548/ --- (Updated Oct. 18, 2017, 7:36 p.m.) Review request for mesos, Andrew

Re: Review Request 62548: Reorganized and updated the contribution guidelines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62548/ --- (Updated Oct. 18, 2017, 7:35 p.m.) Review request for mesos, Andrew

Re: Review Request 62548: Reorganized and updated the contribution guidelines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62548/ --- (Updated Oct. 18, 2017, 7:23 p.m.) Review request for mesos, Andrew

Re: Review Request 63113: Fix flakyness in 'SlaveTest.ExecutorShutdownGracePeriod'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63113/#review188550 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 18, 2017,

Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62213/#review188553 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 18, 2017,

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62212/#review188554 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 12, 2017,

Re: Review Request 61855: Removed a stray trailing parenthesis from a validation error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61855/#review188552 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 6, 2017,

Re: Review Request 63116: Mesos UI: fixed use of undefined variable for the pailer title.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63116/#review188548 --- Ship it! Ship It! - Benjamin Mahler On Oct. 18, 2017, 5

Re: Review Request 63095: Added the Getting Started landing page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63095/ --- (Updated Oct. 18, 2017, 11:46 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 63093: Moved building docs to `building.md`.

> On Oct. 18, 2017, 3 a.m., Vinod Kone wrote: > > docs/getting-started.md > > Line 241 (original), 241 (patched) > > > > > > Should we move this to a "Running Mesos" section/page? This is not > > technically

Re: Review Request 63113: Fix flakyness in 'SlaveTest.ExecutorShutdownGracePeriod'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63113/#review188545 --- Patch looks great! Reviews applied: [63113] Passed command:

Re: Review Request 63094: Added resource sequence id for offer operations.

> On Oct. 18, 2017, 9:46 a.m., Benjamin Bannier wrote: > > include/mesos/resource_provider/resource_provider.proto > > Lines 56-66 (patched) > > > > > > I would prefer if we would not assume that this number changes

Re: Review Request 62980: Added link anchors to all website headings.

> On Oct. 18, 2017, 6:06 p.m., Andrew Schwartzmeyer wrote: > > I tested this out locally on my Mac, rebased and with my getting started > > doc changes just to test it out. It's all working as expected. Though > > perhaps instead of black, might a medium gray look better? I said `black` so

Re: Review Request 62980: Added link anchors to all website headings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62980/#review188538 --- Fix it, then Ship it! I tested this out locally on my Mac,

Re: Review Request 63113: Fix flakyness in 'SlaveTest.ExecutorShutdownGracePeriod'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63113/#review188540 --- PASS: Mesos patch 63113 was successfully built and tested.

Re: Review Request 62891: Increased level of verbose logs for libprocess actor state transitions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62891/#review188533 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 11, 2017,

Re: Review Request 62887: Increased level of some verbose logs from master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62887/#review188535 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 11, 2017,

Re: Review Request 62886: Increased level of some verbose logs from allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62886/#review188534 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 11, 2017,

Review Request 63116: Mesos UI: fixed use of undefined variable for the pailer title.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63116/ --- Review request for mesos, Alexander Rojas and Benjamin Mahler. Repository:

Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62213/ --- (Updated Oct. 18, 2017, 4:24 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 63114: Updated jQuery and Angular versions used in Makefile.am.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63114/ --- (Updated Oct. 18, 2017, 6:22 p.m.) Review request for mesos and Alexander

Review Request 63114: Updated jQuery and Angular versions used in Makefile.am.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63114/ --- Review request for mesos and Alexander Rojas. Repository: mesos Description

Re: Review Request 63107: Added operation feedback for storage operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63107/#review188506 --- FAIL: Failed to apply the dependent review: 62655. Failed

Re: Review Request 63035: Made `getMountNamespaceTarget` more reliable by ignoring exited childs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63035/#review188503 --- PASS: Mesos patch 63035 was successfully built and tested.

Review Request 63113: Fix flakyness in 'SlaveTest.ExecutorShutdownGracePeriod'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63113/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 63035: Made `getMountNamespaceTarget` more reliable by ignoring exited childs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63035/#review188497 --- Patch looks great! Reviews applied: [63074, 63035] Passed

Re: Review Request 63106: Added a metric value for received offer operation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63106/ --- (Updated Oct. 18, 2017, 4:39 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 63107: Added operation feedback for storage operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63107/ --- (Updated Oct. 18, 2017, 4:39 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 63105: Added 'apply' handlers for storage operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63105/ --- (Updated Oct. 18, 2017, 4:36 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 63104: Added a helper to extract resources from storage operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63104/ --- (Updated Oct. 18, 2017, 4:36 p.m.) Review request for mesos, Benjamin Bannier

Review Request 63107: Added operation feedback for storage operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63107/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Repository: mesos

Re: Review Request 63101: Upgrades jQuery used by Mesos WebUI to version 3.2.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63101/#review188488 --- Ship it! Ship It! - Armand Grillet On Oct. 18, 2017, 12:12

Re: Review Request 63102: Upgrades AngularJS used by Mesos WebUI to version 1.2.32.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63102/#review188487 --- PASS: Mesos patch 63102 was successfully built and tested.

Review Request 63106: Added a metric value for received offer operation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63106/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Repository: mesos

Re: Review Request 61947: Implemented handling of resource provider offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61947/ --- (Updated Oct. 18, 2017, 3:54 p.m.) Review request for mesos, Benjamin Bannier

Review Request 63105: Added 'apply' handlers for storage operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63105/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Repository: mesos

Re: Review Request 61946: Added validation of resource provider operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61946/ --- (Updated Oct. 18, 2017, 3:51 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 61810: Added a function to apply offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61810/ --- (Updated Oct. 18, 2017, 3:50 p.m.) Review request for mesos, Benjamin Bannier

Review Request 63104: Added a helper to extract resources from storage operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63104/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Repository: mesos

Re: Review Request 63074: Changed return type of `ns::getns()` from `Try` to `Result`.

> On Oct. 17, 2017, 9:11 p.m., Andrei Budnik wrote: > > src/linux/ns.hpp > > Lines 246 (patched) > > > > > > There might be a race when `stat` has failed, but a new process with > > the same PID is launched before

Re: Review Request 63095: Added the Getting Started landing page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63095/#review188478 --- Bad patch! Reviews applied: [63095, 63093, 62548] Failed

Re: Review Request 63101: Upgrades jQuery used by Mesos WebUI to version 3.2.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63101/ --- (Updated Oct. 18, 2017, 2:12 p.m.) Review request for mesos, Armand Grillet,

Re: Review Request 62214: Added JavaScript linter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review188477 --- PASS: Mesos patch 62214 was successfully built and tested.

Re: Review Request 62502: Added events to publish and unpublish resources.

> On Oct. 17, 2017, 10:48 p.m., Jie Yu wrote: > > include/mesos/resource_provider/resource_provider.proto > > Lines 38 (patched) > > > > > > No need for `UNPUBLISH` for now. Let's introduce it once we actually > >

Re: Review Request 62214: Added JavaScript linter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review188474 --- Patch looks great! Reviews applied: [62214] Passed command:

Re: Review Request 63102: Upgrades AngularJS used by Mesos WebUI to version 1.2.32.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63102/#review188473 --- Ship it! Ship It! - Armand Grillet On Oct. 18, 2017, 10:21

Re: Review Request 63101: Upgrades jQuery used by Mesos WebUI to version 3.2.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63101/#review188472 --- Ship it! Ship It! - Tomasz Janiszewski On Oct. 18, 2017,

Re: Review Request 63102: Upgrades AngularJS used by Mesos WebUI to version 1.2.32.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63102/#review188471 --- Ship it! Ship It! - Tomasz Janiszewski On Oct. 18, 2017,

Review Request 63102: Upgrades AngularJS used by Mesos WebUI to version 1.2.32.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63102/ --- Review request for mesos, Armand Grillet, Gaston Kleiman, and Tomasz

Review Request 63101: Upgrades jQuery used by Mesos WebUI to version 3.2.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63101/ --- Review request for mesos, Armand Grillet, Gaston Kleiman, and Tomasz

Re: Review Request 63093: Moved building docs to `building.md`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63093/#review188469 --- docs/getting-started.md Line 241 (original), 241 (patched)

Re: Review Request 63095: Added the Getting Started landing page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63095/#review188468 --- Fix it, then Ship it! site/source/getting-started.html.md

Re: Review Request 63094: Added resource sequence id for offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63094/#review188465 --- include/mesos/resource_provider/resource_provider.proto Lines

Re: Review Request 62781: Mesos UI: extract the agent URL generation to a function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62781/#review188467 --- src/webui/master/static/js/controllers.js Line 50 (original), 86

Re: Review Request 62214: Added JavaScript linter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review188466 --- FAIL: Failed to apply the dependent review: 62333. Failed

Re: Review Request 62214: Added JavaScript linter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/ --- (Updated Oct. 18, 2017, 9:23 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 62502: Added events to publish and unpublish resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62502/#review188464 --- Bad patch! Reviews applied: [62502, 61947, 61946, 61810, 58021,

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/#review188461 --- Fix it, then Ship it!

Re: Review Request 63095: Added the Getting Started landing page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63095/#review188460 --- FAIL: Failed to apply the dependent review: 62548. Failed

Re: Review Request 62903: Added a call to update total resources and pending operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62903/#review188459 --- PASS: Mesos patch 62903 was successfully built and tested.

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/#review188458 --- Patch looks great! Reviews applied: [60491, 60493, 60494, 60764,