Re: Review Request 65294: Support `revocable_resources` capability in `mesos-execute`.

2018-01-30 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65294/#review196553 --- Ship it! Ship It! - James Peach On Jan. 30, 2018, 12:03

Re: Review Request 65414: Added tests for `Resources.find` on revocable resources.

2018-01-30 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65414/#review196552 --- Fix it, then Ship it! src/tests/resources_tests.cpp Lines

Re: Review Request 65294: Support `revocable_resources` capability in `mesos-execute`.

2018-01-30 Thread Jason Lai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65294/#review196550 --- Ship it! Ship It! - Jason Lai On Jan. 30, 2018, 12:03 a.m.,

Re: Review Request 65316: Added test for delayed authorization during operator events.

2018-01-30 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65316/#review196549 --- PASS: Mesos patch 65316 was successfully built and tested.

Re: Review Request 65039: Tested reconciliation when operation is dropped en route to agent.

2018-01-30 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65039/#review196548 --- PASS: Mesos patch 65039 was successfully built and tested.

Re: Review Request 65039: Tested reconciliation when operation is dropped en route to agent.

2018-01-30 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65039/ --- (Updated Jan. 31, 2018, 2:57 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 65316: Added test for delayed authorization during operator events.

2018-01-30 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65316/ --- (Updated Jan. 31, 2018, 2:53 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 65315: Removed a redundant authorization helper class from the tests.

2018-01-30 Thread Greg Mann
> On Jan. 27, 2018, 1:25 a.m., Gaston Kleiman wrote: > > src/tests/mesos.hpp > > Lines 3177 (patched) > > > > > > Would `PermissiveObjectApprover` be a better name? I actually realized that the test class is

Re: Review Request 65315: Removed a redundant authorization helper class from the tests.

2018-01-30 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65315/ --- (Updated Jan. 31, 2018, 2:52 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 65428: Reduced the output from Maven during builds.

2018-01-30 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65428/#review196546 --- PASS: Mesos patch 65428 was successfully built and tested.

Re: Review Request 65427: Used unique CSI plugin names for SLRP tests.

2018-01-30 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65427/#review196545 --- PASS: Mesos patch 65427 was successfully built and tested.

Review Request 65428: Reduced the output from Maven during builds.

2018-01-30 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65428/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 65382: Reaped Docker executor only when it can be connected.

2018-01-30 Thread Qian Zhang
> On Jan. 31, 2018, 6:26 a.m., Vinod Kone wrote: > > The blocking review https://reviews.apache.org/r/65384/ seems non-existent? Yeah, that seems a bug in review board. So I posted it again as another patch: https://reviews.apache.org/r/65420/. - Qian

Re: Review Request 65382: Reaped Docker executor only when it can be connected.

2018-01-30 Thread Qian Zhang
> On Jan. 31, 2018, 6:25 a.m., Vinod Kone wrote: > > src/slave/containerizer/docker.cpp > > Lines 979 (patched) > > > > > > Do we return a "failed" container termination here? AFAICT, we return > > `None` on `wait`

Re: Review Request 65382: Reaped Docker executor only when it can be connected.

2018-01-30 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65382/ --- (Updated Jan. 31, 2018, 9:14 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 65333: Fixed errors in comments.

2018-01-30 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65333/ --- (Updated Jan. 31, 2018, 1:03 a.m.) Review request for mesos, Gaston Kleiman

Re: Review Request 65332: Tested that a CSI persistent volume can be used after recovery.

2018-01-30 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65332/ --- (Updated Jan. 31, 2018, 1:02 a.m.) Review request for mesos, Gaston Kleiman

Review Request 65427: Used unique CSI plugin names for SLRP tests.

2018-01-30 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65427/ --- Review request for mesos, Gaston Kleiman and Greg Mann. Bugs: MESOS-8399

Review Request 65426: Made gRPC calls wait for the channel to be ready.

2018-01-30 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65426/ --- Review request for mesos, Greg Mann and Jie Yu. Repository: mesos

Re: Review Request 65294: Support `revocable_resources` capability in `mesos-execute`.

2018-01-30 Thread Anish Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65294/#review196542 --- Ship it! Ship It! - Anish Gupta On Jan. 30, 2018, 12:03

Re: Review Request 65334: Added quota limit to the master API protos.

2018-01-30 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65334/ --- (Updated Jan. 31, 2018, 12:21 a.m.) Review request for mesos, Alexander

Re: Review Request 63991: Added helpers to create and forward offer operation updates.

2018-01-30 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63991/ --- (Updated Jan. 31, 2018, 12:13 a.m.) Review request for mesos, Benjamin

Re: Review Request 63990: Added the RESOURCE_PROVIDER capability to the agent.

2018-01-30 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63990/ --- (Updated Jan. 31, 2018, 12:12 a.m.) Review request for mesos, Benjamin

Re: Review Request 65347: Added missing protobuf include.

2018-01-30 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65347/#review196541 --- Ship it! Ship It! - Till Toenshoff On Jan. 26, 2018, 11:41

Re: Review Request 64849: Added authentication to some example frameworks.

2018-01-30 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64849/ --- (Updated Jan. 30, 2018, 11:59 p.m.) Review request for mesos, Alexander

Re: Review Request 65369: Added test to ensure v1 executor is shutdown upon initial task all-kill.

2018-01-30 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65369/#review196539 --- Looks good, I will wait to push the chain until there's also the

Re: Review Request 65423: Fixed duplicate protobuf linking in Python examples.

2018-01-30 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65423/#review196540 --- PASS: Mesos patch 65423 was successfully built and tested.

Re: Review Request 65382: Reaped Docker executor only when it can be connected.

2018-01-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65382/#review196538 --- The blocking review https://reviews.apache.org/r/65384/ seems

Re: Review Request 65420: Fixed a coding error in a log message of Docker containerizer.

2018-01-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65420/#review196537 --- Ship it! Ship It! - Vinod Kone On Jan. 30, 2018, 3:42 p.m.,

Re: Review Request 65382: Reaped Docker executor only when it can be connected.

2018-01-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65382/#review196536 --- Fix it, then Ship it! src/slave/containerizer/docker.cpp Line

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

2018-01-30 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64618/#review196535 --- PASS: Mesos patch 64618 was successfully built and tested.

Re: Review Request 65344: Updated the docs for agent ping timeout flags.

2018-01-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65344/#review196534 --- Ship it! Ship It! - Vinod Kone On Jan. 25, 2018, 9:18 p.m.,

Re: Review Request 65423: Fixed duplicate protobuf linking in Python examples.

2018-01-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65423/#review196533 --- Ship it! Ship It! - Vinod Kone On Jan. 30, 2018, 9:35 p.m.,

Review Request 65424: Improved task status acknowledgement logging messages.

2018-01-30 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65424/ --- Review request for mesos and Greg Mann. Bugs: MESOS-8184

Review Request 65423: Fixed duplicate protobuf linking in Python examples.

2018-01-30 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65423/ --- Review request for mesos, Armand Grillet, Benno Evers, and Vinod Kone. Bugs:

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

2018-01-30 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64618/ --- (Updated Jan. 30, 2018, 1:22 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 65362: Added a method to increment invalid scheduler API call counters.

2018-01-30 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65362/ --- (Updated Jan. 30, 2018, 1:21 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 65392: Document the namespace/uts isolator.

2018-01-30 Thread James DeFelice
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65392/#review196530 --- Ship it! Ship It! - James DeFelice On Jan. 29, 2018, 6:19

Re: Review Request 65391: Added a UTS namespace isolator.

2018-01-30 Thread James DeFelice
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65391/#review196529 --- Ship it! Ship It! - James DeFelice On Jan. 30, 2018, 12:05

Re: Review Request 65362: Added a method to increment invalid scheduler API call counters.

2018-01-30 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65362/#review196524 --- src/master/metrics.cpp Lines 498-506 (patched)

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

2018-01-30 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64618/#review196528 --- src/master/master.cpp Lines 5892-5893 (patched)

Re: Review Request 65420: Fixed a coding error in a log message of Docker containerizer.

2018-01-30 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65420/#review196527 --- PASS: Mesos patch 65420 was successfully built and tested.

Re: Review Request 65382: Reaped Docker executor only when it can be connected.

2018-01-30 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65382/ --- (Updated Jan. 30, 2018, 11:42 p.m.) Review request for mesos and Vinod Kone.

Review Request 65420: Fixed a coding error in a log message of Docker containerizer.

2018-01-30 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65420/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 65384: Fixed a coding error in a log message of Docker containerizer.

2018-01-30 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65384/ --- (Updated Jan. 30, 2018, 11:40 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 65384: Fixed a coding error in a log message of Docker containerizer.

2018-01-30 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65384/ --- (Updated Jan. 30, 2018, 11:37 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 65382: Reaped Docker executor only when it can be connected.

2018-01-30 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65382/ --- (Updated Jan. 30, 2018, 11:35 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 65416: Enabled gRPC in the RPM spec file.

2018-01-30 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65416/#review196523 --- Ship it! Ship It! - Kapil Arya On Jan. 29, 2018, 10:41

Re: Review Request 64387: Windows: Ported docker health check tests.

2018-01-30 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/ --- (Updated Jan. 30, 2018, 10:21 a.m.) Review request for mesos, Alexander

Review Request 65419: Fixed quoting issues in docker executor command checks.

2018-01-30 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65419/ --- Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston

Re: Review Request 65127: Windows: Enabled docker health checks.

2018-01-30 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/ --- (Updated Jan. 30, 2018, 10:18 a.m.) Review request for mesos, Alexander

Re: Review Request 65395: Refactored health checks to cleanly separate each different check.

2018-01-30 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65395/ --- (Updated Jan. 30, 2018, 10:06 a.m.) Review request for mesos, Alexander

Re: Review Request 65127: Windows: Enabled docker health checks.

2018-01-30 Thread Akash Gupta
> On Jan. 22, 2018, 9:55 p.m., Joseph Wu wrote: > > src/checks/checker_process.cpp > > Lines 479-481 (original), 479-487 (patched) > > > > > > This is a bit unexpected. Considering that these arguments will be > >

Re: Review Request 65394: Added separate structs for health check runtime and check types.

2018-01-30 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65394/ --- (Updated Jan. 30, 2018, 10:05 a.m.) Review request for mesos, Alexander