Re: Review Request 65515: Added rvalue reference Try::get overloads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65515/#review197248 --- Ship it! Ship It! - Michael Park On Feb. 5, 2018, 2:08 p.m.,

Re: Review Request 65515: Added rvalue reference Try::get overloads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65515/#review197246 --- 3rdparty/stout/include/stout/try.hpp Lines 73-86 (original), 73-1

Re: Review Request 65518: Reaped the container process directly in Docker executor.

> On Feb. 10, 2018, 2:21 a.m., Greg Mann wrote: > > src/docker/executor.cpp > > Lines 273-302 (patched) > > > > > > Could we validate this with a test? I think it would be possible to use > > a `MockDocker` which in

Re: Review Request 65518: Reaped the container process directly in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65518/#review197242 --- Patch looks great! Reviews applied: [65518] Passed command: expo

Re: Review Request 65518: Reaped the container process directly in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65518/#review197241 --- PASS: Mesos patch 65518 was successfully built and tested. Review

Re: Review Request 65518: Reaped the container process directly in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65518/ --- (Updated Feb. 12, 2018, 11:46 a.m.) Review request for mesos, Gaston Kleiman, G

Re: Review Request 65518: Reaped the container process directly in Docker executor.

> On Feb. 10, 2018, 8:55 a.m., Vinod Kone wrote: > > src/docker/executor.cpp > > Lines 277 (patched) > > > > > > s/never returns though/to never return although/ I see Greg suggests to change `returns` to `returning

Re: Review Request 65518: Reaped the container process directly in Docker executor.

> On Feb. 10, 2018, 10:21 a.m., Greg Mann wrote: > > src/docker/executor.cpp > > Lines 273-302 (patched) > > > > > > Could we validate this with a test? I think it would be possible to use > > a `MockDocker` which i

Re: Review Request 64211: Added options to build the Python CLI and run unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64211/#review197237 --- PASS: Mesos patch 64211 was successfully built and tested. Review

Re: Review Request 65503: Added bootstrap-table library for the WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65503/ --- (Updated Feb. 11, 2018, 4:15 p.m.) Review request for mesos and Benjamin Mahler

Re: Review Request 65503: Added bootstrap-table library for the WebUI.

> On Feb. 6, 2018, 3:26 a.m., Benjamin Mahler wrote: > > Looks good, couple of questions: > > > > (1) Doesn't this need to be part of the installation? I think you need to > > update the autotools and cmake builds? > > (2) Do we need to update LICENSE to include this new sub-component? 1) Corr

Re: Review Request 64211: Added options to build the Python CLI and run unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64211/ --- (Updated Feb. 11, 2018, 3:27 p.m.) Review request for mesos, Benjamin Bannier a