Re: Review Request 66235: Added a reference to MESOS-8557 to the default executor.

2018-03-22 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66235/#review199852 --- PASS: Mesos patch 66235 was successfully built and tested.

Re: Review Request 66232: Removed unnecessary/invalid checks from the default executor.

2018-03-22 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66232/#review199842 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66141: Fixed whitespace in SLRP tests.

2018-03-22 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66141/#review199839 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 66235: Added a reference to MESOS-8557 to the default executor.

2018-03-22 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66235/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-8557

Re: Review Request 66206: Used native protobuf map in Docker v1 image spec.

2018-03-22 Thread Qian Zhang
> On March 23, 2018, 2:39 a.m., Chun-Hung Hsiao wrote: > > include/mesos/docker/v1.proto > > Line 67 (original), 57 (patched) > > > > > > Since this is a public proto file, is there any endpoint or API that > >

Review Request 66234: Fixed variable shadowing in the default executor.

2018-03-22 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66234/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-8530

Re: Review Request 65962: Avoided copying `Owned` pointers in the default executor.

2018-03-22 Thread Gaston Kleiman
> On March 22, 2018, 6:13 a.m., Alexander Rukletsov wrote: > > src/launcher/default_executor.cpp > > Line 979 (original), 961 (patched) > > > > > > Not yours, but maybe you can fix this `taskId` variable shadowing

Review Request 66233: Made the default executor log kill failures.

2018-03-22 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66233/ --- Review request for mesos, Alexander Rukletsov, Joseph Wu, Qian Zhang, and Vinod

Re: Review Request 65694: Made the default executor's handling of kill escalations more robust.

2018-03-22 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65694/ --- (Updated March 22, 2018, 7:12 p.m.) Review request for mesos, Alexander

Review Request 66232: Removed unnecessary/invalid checks from the default executor.

2018-03-22 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66232/ --- Review request for mesos, Alexander Rukletsov, Joseph Wu, Qian Zhang, and Vinod

Review Request 66223: WIP.

2018-03-22 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66223/ --- Review request for mesos. Repository: mesos Description --- WIP.

Re: Review Request 66123: Temporarily disabled some default executor tests.

2018-03-22 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66123/#review199832 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66076: Used raw string literal in protobuf tests to avoid escaping.

2018-03-22 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66076/ --- (Updated March 23, 2018, 9:12 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 66076: Used raw string literal in protobuf tests to avoid escaping.

2018-03-22 Thread Qian Zhang
> On March 17, 2018, 5:40 a.m., Chun-Hung Hsiao wrote: > > 3rdparty/stout/tests/protobuf_tests.cpp > > Line 108 (original), 108 (patched) > > > > > > Not sure what style is better. How about > > ``` > >

Re: Review Request 66123: Temporarily disabled some default executor tests.

2018-03-22 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66123/ --- (Updated March 22, 2018, 6:05 p.m.) Review request for mesos, Alexander

Re: Review Request 66126: Refactored agent task launch for better composition [1/2].

2018-03-22 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66126/#review199824 --- Fix it, then Ship it! src/slave/slave.hpp Lines 176 (patched)

Re: Review Request 65876: Enabled `--fetch_stall_timeout` in curl-based URI fetcher plugins.

2018-03-22 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65876/#review199817 --- src/uri/fetchers/docker.cpp Line 96 (original), 96 (patched)

Re: Review Request 66230: Added test for adding/removing framework roles.

2018-03-22 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66230/#review199816 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

2018-03-22 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/#review199802 --- Halfway reviewing. Posting some comments first.

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

2018-03-22 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/ --- (Updated March 22, 2018, 3:36 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66230: Added test for adding/removing framework roles.

2018-03-22 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66230/#review199810 --- FAIL: Failed to apply the dependent review: 66229. Failed

Re: Review Request 66210: Added OS_LINUX guard for 'test_csi_plugin'.

2018-03-22 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66210/#review199808 --- Patch looks great! Reviews applied: [66210] Passed command:

Re: Review Request 65987: Allow nested containers in pods to have separate namespaces(Ref: MESOS-8534).

2018-03-22 Thread Sagar Patwardhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65987/ --- (Updated March 22, 2018, 9:16 p.m.) Review request for mesos and Jie Yu.

Review Request 66229: Implemented UPDATE_FRAMEWORK call.

2018-03-22 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66229/ --- Review request for mesos, Benjamin Mahler and Till Toenshoff. Bugs: MESOS-7258

Review Request 66230: Added test for adding/removing framework roles.

2018-03-22 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66230/ --- Review request for mesos, Benjamin Mahler and Till Toenshoff. Bugs: MESOS-7258

Review Request 66228: Added call/event for updating framework info.

2018-03-22 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66228/ --- Review request for mesos, Benjamin Mahler and Till Toenshoff. Bugs: MESOS-7258

Review Request 66227: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operator API.

2018-03-22 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66227/ --- Review request for mesos, Chun-Hung Hsiao and Gaston Kleiman. Bugs: MESOS-4965

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

2018-03-22 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/#review199796 --- Fix it, then Ship it! include/mesos/mesos.proto Lines 1962

Re: Review Request 66144: Enforced task launch order on the agent.

2018-03-22 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66144/ --- (Updated March 22, 2018, 12:07 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66060: Added end-to-end tests for operation feedback.

2018-03-22 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66060/ --- (Updated March 22, 2018, 12:06 p.m.) Review request for mesos, Chun-Hung

Re: Review Request 66120: Updated an agent test to use mock garbage collector.

2018-03-22 Thread Meng Zhu
> On March 22, 2018, 10:49 a.m., Greg Mann wrote: > > src/tests/slave_tests.cpp > > Lines 4813-4816 (original), 4817-4820 (patched) > > > > > > Remove double quotes around this comment. -- says greg :) sorry for

Re: Review Request 66206: Used native protobuf map in Docker v1 image spec.

2018-03-22 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66206/#review199795 --- include/mesos/docker/v1.proto Line 67 (original), 57 (patched)

Re: Review Request 66173: Add test for new `disk/xfs` kill functionality.

2018-03-22 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66173/#review199794 --- In one of the basic quota tests (maybe

Re: Review Request 66141: Fixed whitespace in SLRP tests.

2018-03-22 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66141/ --- (Updated March 22, 2018, 11:28 a.m.) Review request for mesos, Chun-Hung

Re: Review Request 66060: Added end-to-end tests for operation feedback.

2018-03-22 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66060/ --- (Updated March 22, 2018, 11:28 a.m.) Review request for mesos, Chun-Hung

Re: Review Request 66059: Added a `SendAcknowledgeOperationStatus` test action.

2018-03-22 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66059/ --- (Updated March 22, 2018, 11:27 a.m.) Review request for mesos, Chun-Hung

Re: Review Request 66057: Added a `createCallAcknowledgeOperationStatus()` test helper.

2018-03-22 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66057/ --- (Updated March 22, 2018, 11:27 a.m.) Review request for mesos, Greg Mann and

Re: Review Request 66056: Updated `CREATE_VOLUME()` helper to allow specifying an operation ID.

2018-03-22 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66056/ --- (Updated March 22, 2018, 11:27 a.m.) Review request for mesos, Greg Mann and

Re: Review Request 66058: Added v1 versions of some test helpers/matchers.

2018-03-22 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66058/ --- (Updated March 22, 2018, 11:27 a.m.) Review request for mesos, Chun-Hung

Re: Review Request 65994: Made the master forward operation status updates to the schedulers.

2018-03-22 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65994/ --- (Updated March 22, 2018, 11:27 a.m.) Review request for mesos, Greg Mann and

Re: Review Request 66140: Fixed bug in `Framework::removeOperation()`.

2018-03-22 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66140/ --- (Updated March 22, 2018, 11:26 a.m.) Review request for mesos, Greg Mann and

Re: Review Request 65993: Added evolve functions for operation status updates.

2018-03-22 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65993/ --- (Updated March 22, 2018, 11:26 a.m.) Review request for mesos, Greg Mann and

Re: Review Request 65300: Added master metrics for operation status acknowledgments handling.

2018-03-22 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65300/ --- (Updated March 22, 2018, 11:25 a.m.) Review request for mesos, Greg Mann and

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

2018-03-22 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64618/ --- (Updated March 22, 2018, 11:26 a.m.) Review request for mesos, Greg Mann and

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

2018-03-22 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review199778 --- src/slave/containerizer/mesos/isolators/xfs/disk.hpp Lines 77

Re: Review Request 66120: Updated an agent test to use mock garbage collector.

2018-03-22 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66120/#review199787 --- Fix it, then Ship it! src/tests/slave_tests.cpp Lines

Re: Review Request 66220: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

2018-03-22 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66220/#review199788 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66143: Refactored agent task launch for better composition [2/2].

2018-03-22 Thread Meng Zhu
> On March 21, 2018, 4:22 p.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 2386 (patched) > > > > > > Let's make this variable a reference instead to avoid the copy: > > > > ``` > > list&

Re: Review Request 66143: Refactored agent task launch for better composition [2/2].

2018-03-22 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66143/ --- (Updated March 22, 2018, 10:26 a.m.) Review request for mesos, Chun-Hung Hsiao

Review Request 66220: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

2018-03-22 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66220/ --- Review request for mesos, Chun-Hung Hsiao and Gaston Kleiman. Bugs: MESOS-4965

Review Request 66219: Added helper functions to create grow and shrink volume in test.

2018-03-22 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66219/ --- Review request for mesos, Chun-Hung Hsiao and Gaston Kleiman. Repository:

Review Request 66218: Ensured that agent does not delete volume upon grow or shrink.

2018-03-22 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66218/ --- Review request for mesos. Bugs: MESOS-4965

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

2018-03-22 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/ --- (Updated March 22, 2018, 9:27 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66210: Added OS_LINUX guard for 'test_csi_plugin'.

2018-03-22 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66210/#review199767 --- Ship it! Ship It! - Chun-Hung Hsiao On March 22, 2018, 9:37

Re: Review Request 66210: Added OS_LINUX guard for 'test_csi_plugin'.

2018-03-22 Thread Jan Schlicht
> On March 22, 2018, 3:27 p.m., Alexander Rukletsov wrote: > > What about CMake? There isn't CMake support for CSI yet. Patches for that are still in review. See my comments on https://reviews.apache.org/r/66163/ for making sure the this is addressed in the CMake patches. - Jan

Re: Review Request 66210: Added OS_LINUX guard for 'test_csi_plugin'.

2018-03-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66210/#review199764 --- What about CMake? - Alexander Rukletsov On March 22, 2018,

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

2018-03-22 Thread Harold Dost
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/ --- (Updated March 22, 2018, 2:11 p.m.) Review request for mesos and James Peach.

Re: Review Request 66173: Add test for new `disk/xfs` kill functionality.

2018-03-22 Thread Harold Dost
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66173/ --- (Updated March 22, 2018, 2:11 p.m.) Review request for mesos and James Peach.

Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'.

2018-03-22 Thread Alexander Rukletsov
> On March 22, 2018, 2:08 p.m., Alexander Rukletsov wrote: > > Ship It! Please use past simple in Summary for consistency. - Alexander --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'.

2018-03-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65571/#review199760 --- Ship it! Ship It! - Alexander Rukletsov On March 22, 2018,

Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'.

2018-03-22 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65571/#review199759 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 65962: Avoided copying `Owned` pointers in the default executor.

2018-03-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65962/#review199676 --- src/launcher/default_executor.cpp Line 979 (original), 961

Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'.

2018-03-22 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65571/ --- (Updated March 22, 2018, 12:06 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 66210: Added OS_LINUX guard for 'test_csi_plugin'.

2018-03-22 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66210/#review199750 --- PASS: Mesos patch 66210 was successfully built and tested.

Re: Review Request 66163: Built storage local resource provider with CMake.

2018-03-22 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66163/#review199747 --- src/examples/CMakeLists.txt Lines 55-58 (patched)

Review Request 66211: Added the fields `ExposedPorts` and `Volumes` into Docker v1 image spec.

2018-03-22 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66211/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-8718

Review Request 66212: Updated `ParseV1ImageManifest` to check `Volumes` and `ExposedPorts`.

2018-03-22 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66212/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-8718

Review Request 66210: Added OS_LINUX guard for 'test_csi_plugin'.

2018-03-22 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66210/ --- Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Jie Yu. Bugs:

Re: Review Request 66156: Compiled `csi.proto` when gRPC is disabled.

2018-03-22 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66156/#review199744 --- src/Makefile.am Line 2301 (original)

Re: Review Request 66207: Used native protobuf map in OCI v1 image spec.

2018-03-22 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66207/#review199745 --- Patch looks great! Reviews applied: [66206, 66207] Passed

Re: Review Request 66207: Used native protobuf map in OCI v1 image spec.

2018-03-22 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66207/#review199742 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

2018-03-22 Thread Harold Dost
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/ --- (Updated March 22, 2018, 7:43 a.m.) Review request for mesos and James Peach.

Review Request 66207: Used native protobuf map in OCI v1 image spec.

2018-03-22 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66207/ --- Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Gilbert Song.

Review Request 66206: Used native protobuf map in Docker v1 image spec.

2018-03-22 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66206/ --- Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Gilbert Song.