Re: Review Request 65665: Added operation state metrics in SLRP.

2018-04-11 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65665/ --- (Updated April 12, 2018, 5:15 a.m.) Review request for mesos, Benjamin

Re: Review Request 66163: Built storage local resource provider with CMake.

2018-04-11 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66163/ --- (Updated April 12, 2018, 5:15 a.m.) Review request for mesos, Andrew

Re: Review Request 66493: Made FreeBSD default to non-GNU ld.

2018-04-11 Thread David Forsythe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66493/ --- (Updated April 12, 2018, 5:13 a.m.) Review request for mesos, Andrew

Re: Review Request 65665: Added operation state metrics in SLRP.

2018-04-11 Thread Chun-Hung Hsiao
> On March 21, 2018, 1:12 p.m., Jan Schlicht wrote: > > src/resource_provider/storage/provider.cpp > > Lines 503 (patched) > > > > > > As this is only used as a helper in the constructor of `Metrics`, how > > about

Re: Review Request 66554: Updated Web UI controllers to have one file per controller.

2018-04-11 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66554/#review200969 --- Patch looks great! Reviews applied: [66553, 66554] Passed

Re: Review Request 65640: Fixed leaks and a race condition in `UriDiskProfileAdaptorTests`.

2018-04-11 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65640/ --- (Updated April 12, 2018, 3:37 a.m.) Review request for mesos, Alexander

Re: Review Request 65976: Allowed profiles to be missing from `DiskProfileAdaptor`.

2018-04-11 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65976/ --- (Updated April 12, 2018, 3:37 a.m.) Review request for mesos, Benjamin

Re: Review Request 65975: Sequentialize reconciliations of storage pools in SLRP.

2018-04-11 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65975/ --- (Updated April 12, 2018, 3:36 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

2018-04-11 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65594/ --- (Updated April 12, 2018, 3:35 a.m.) Review request for mesos, Benjamin

Re: Review Request 65974: Added comments and made some renaming in SLRP.

2018-04-11 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65974/ --- (Updated April 12, 2018, 3:33 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 65995: Declined unwanted offers in `RetryOperationStatusUpdate*` SLRP tests.

2018-04-11 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65995/ --- (Updated April 12, 2018, 3:31 a.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 66578: Windows: Ported more unit tests from `os_tests.cpp`.

2018-04-11 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66578/#review200965 --- PASS: Mesos patch 66578 was successfully built and tested.

Re: Review Request 61096: Building gRPC with CMake.

2018-04-11 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61096/ --- (Updated April 12, 2018, 3:22 a.m.) Review request for mesos, Andrew

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

2018-04-11 Thread Benjamin Mahler
> On April 10, 2018, 8:45 p.m., Benjamin Mahler wrote: > > include/mesos/v1/scheduler.hpp > > Lines 102-114 (patched) > > > > > > Hm.. why does this return an `Option`? > > > > If this is mesos Response

Re: Review Request 66457: WIP: Made resource provider API aware of workloads.

2018-04-11 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66457/#review200959 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 66578: Windows: Ported more unit tests from `os_tests.cpp`.

2018-04-11 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66578/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and

Re: Review Request 66462: Added new operation states to be used for status reconciliation.

2018-04-11 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66462/#review200957 --- Are all of these necessary for now? src/slave/slave.cpp Lines

Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction.

2018-04-11 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66437/ --- (Updated April 11, 2018, 7:06 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 66577: Enabled CSI proto compilation by default.

2018-04-11 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66577/#review200955 --- FAIL: Failed to apply the dependent review: 66398. Failed

Review Request 66577: Enabled CSI proto compilation by default.

2018-04-11 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66577/ --- Review request for mesos, Benjamin Bannier, Benno Evers, and Jie Yu. Bugs:

Review Request 66576: Added `STAGE_UNSTAGE_VOLUME` capability to the test CSI plugin.

2018-04-11 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66576/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-8717

Review Request 66575: Supported `STAGE_UNSTAGE_VOLUME` CSI node capability in SLRP.

2018-04-11 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66575/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-8717

Re: Review Request 63295: Update glog-0.3.3.patch to build on ARM.

2018-04-11 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63295/#review200953 --- Is this being upstreamed into glog? - Benjamin Mahler On Oct.

Review Request 66574: Updated filesystem layout for staging and mounting CSI volumes.

2018-04-11 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66574/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-8717

Re: Review Request 66493: Made FreeBSD default to non-GNU ld.

2018-04-11 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66493/#review200945 --- Fix it, then Ship it! cmake/CompilationConfigure.cmake Lines

Re: Review Request 66532: Added test for authorization actions for `UPDATE_VOLUME`.

2018-04-11 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66532/#review200943 --- PASS: Mesos patch 66532 was successfully built and tested.

Re: Review Request 66511: Updated tests due to change of containerizer's `destroy()` return type.

2018-04-11 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66511/#review200942 --- Patch looks great! Reviews applied: [66510, 66511] Passed

Re: Review Request 66554: Updated Web UI controllers to have one file per controller.

2018-04-11 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66554/#review200941 --- src/webui/app/agents/agent-browse-controller.js Lines 35

Re: Review Request 66553: Restructured Web UI.

2018-04-11 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66553/#review200940 --- Ship it! A little bit of history, "master" was there because

Re: Review Request 66511: Updated tests due to change of containerizer's `destroy()` return type.

2018-04-11 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66511/#review200938 --- Ship it! src/tests/containerizer.cpp Lines 533-540

Re: Review Request 66510: Unified return type of `wait` and `destroy` containerizer methods.

2018-04-11 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66510/#review200937 --- Ship it! Ship It! - Greg Mann On April 9, 2018, 3:44 p.m.,

Re: Review Request 66227: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operator API.

2018-04-11 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66227/ --- (Updated April 11, 2018, 2:21 p.m.) Review request for mesos, Chun-Hung Hsiao,

Review Request 66569: Added a test to verify that grow and shrink cannot be combined.

2018-04-11 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66569/ --- Review request for mesos, Chun-Hung Hsiao and Greg Mann. Bugs: MESOS-4965

Re: Review Request 66220: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

2018-04-11 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66220/ --- (Updated April 11, 2018, 2:19 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66219: Added helper functions to create grow and shrink volume in test.

2018-04-11 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66219/ --- (Updated April 11, 2018, 2:18 p.m.) Review request for mesos, Chun-Hung Hsiao,

Review Request 66568: Dropped GROW and SHRINK volume if combined with other operations.

2018-04-11 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66568/ --- Review request for mesos, Chun-Hung Hsiao and Greg Mann. Bugs: MESOS-4965

Re: Review Request 66173: Add test for new `disk/xfs` kill functionality.

2018-04-11 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66173/#review200931 --- I'm getting a test failure on

Re: Review Request 66541: Added default executor test for agent recovery without metadata.

2018-04-11 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66541/#review200930 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66538: Added unit test slave recovery for default executor tests.

2018-04-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66538/ --- (Updated April 11, 2018, 1:40 p.m.) Review request for mesos, Jie Yu, Kevin

Re: Review Request 66541: Added default executor test for agent recovery without metadata.

2018-04-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66541/ --- (Updated April 11, 2018, 1:40 p.m.) Review request for mesos, Jie Yu, Kevin

Re: Review Request 66562: Added test for local puller hdfs uri fetcher plugin.

2018-04-11 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66562/#review200928 --- PASS: Mesos patch 66562 was successfully built and tested.

Re: Review Request 64211: Added options to build the Python CLI and run unit tests.

2018-04-11 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64211/#review200926 --- Patch looks great! Reviews applied: [65585, 65705, 64211]

Re: Review Request 66541: Added default executor test for agent recovery without metadata.

2018-04-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66541/ --- (Updated April 11, 2018, 12:02 p.m.) Review request for mesos, Jie Yu, Kevin

Re: Review Request 66538: Added unit test slave recovery for default executor tests.

2018-04-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66538/ --- (Updated April 11, 2018, 12:01 p.m.) Review request for mesos, Jie Yu, Kevin

Re: Review Request 66538: Added unit test slave recovery for default executor tests.

2018-04-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66538/ --- (Updated April 11, 2018, 11:53 a.m.) Review request for mesos, Jie Yu, Kevin

Re: Review Request 66538: Added unit test slave recovery for default executor tests.

2018-04-11 Thread Gilbert Song
> On April 11, 2018, 7:14 a.m., Qian Zhang wrote: > > src/tests/default_executor_tests.cpp > > Lines 1427-1430 (patched) > > > > > > Why do we need to launch the executor using reserved resources? This > > seems

Re: Review Request 66230: Added test for adding/removing framework roles.

2018-04-11 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66230/#review200923 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66510: Unified return type of `wait` and `destroy` containerizer methods.

2018-04-11 Thread Greg Mann
> On April 10, 2018, 6:15 p.m., Greg Mann wrote: > > src/slave/containerizer/mesos/containerizer.cpp > > Line 2335 (original), 2336 (patched) > > > > > > Hmm I think it might be a bit more readable here and

Re: Review Request 66464: Implemented operation status reconciliation.

2018-04-11 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66464/#review200921 --- src/master/http.cpp Line 1115 (original), -1113 (patched)

Review Request 66561: Supported hdfs fetching in local puller.

2018-04-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66561/ --- Review request for mesos, Jie Yu and Qian Zhang. Repository: mesos

Review Request 66559: Made agent flag '--hadoop_home' as optional.

2018-04-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66559/ --- Review request for mesos, Jie Yu and Qian Zhang. Repository: mesos

Review Request 66562: Added test for local puller hdfs uri fetcher plugin.

2018-04-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66562/ --- Review request for mesos, Jie Yu and Qian Zhang. Repository: mesos

Review Request 66560: Added a new agent flag .

2018-04-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66560/ --- Review request for mesos, Jie Yu and Qian Zhang. Repository: mesos

Re: Review Request 66462: Added new operation states to be used for status reconciliation.

2018-04-11 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66462/ --- (Updated April 11, 2018, 10:58 a.m.) Review request for mesos and Greg Mann.

Re: Review Request 66554: Updated Web UI controllers to have one file per controller.

2018-04-11 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66554/#review200919 --- PASS: Mesos patch 66554 was successfully built and tested.

Re: Review Request 66468: Added tests for operation status reconciliation.

2018-04-11 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66468/#review200918 --- Ship it! Ship It! - Greg Mann On April 10, 2018, 9:56 p.m.,

Re: Review Request 66229: Implemented UPDATE_FRAMEWORK call.

2018-04-11 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66229/ --- (Updated April 11, 2018, 1:28 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 66228: Added Call for updating framework info.

2018-04-11 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66228/ --- (Updated April 11, 2018, 1:28 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 66511: Updated tests due to change of containerizer's `destroy()` return type.

2018-04-11 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66511/#review200913 --- PASS: Mesos patch 66511 was successfully built and tested.

Re: Review Request 65334: Added quota limit to the master API protos.

2018-04-11 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65334/#review200912 --- Ship it! - Meng Zhu On March 9, 2018, 5:46 p.m., Benjamin

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

2018-04-11 Thread James Peach
> On April 2, 2018, 8:30 p.m., Ilya Pronin wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Lines 393 (patched) > > > > > > This should be configurable. > > Harold Dost wrote: > So I had

Review Request 66554: Updated Web UI controllers to have one file per controller.

2018-04-11 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66554/ --- Review request for mesos, Benjamin Mahler and Till Toenshoff. Bugs: MESOS-8503

Review Request 66553: Restructured Web UI.

2018-04-11 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66553/ --- Review request for mesos, Benjamin Mahler and Till Toenshoff. Bugs: MESOS-8503

Re: Review Request 66511: Updated tests due to change of containerizer's `destroy()` return type.

2018-04-11 Thread Andrei Budnik
> On April 10, 2018, 6:28 p.m., Greg Mann wrote: > > src/tests/containerizer.cpp > > Lines 534-535 (original), 535-537 (patched) > > > > > > Indentation, here and elsewhere: > > ``` > > Future

Re: Review Request 66538: Added unit test slave recovery for default executor tests.

2018-04-11 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66538/#review200891 --- src/tests/default_executor_tests.cpp Lines 1427-1430 (patched)

Re: Review Request 66546: Prevent resubscription of resource providers with unknown IDs.

2018-04-11 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66546/#review200906 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66510: Unified return type of `wait` and `destroy` containerizer methods.

2018-04-11 Thread Andrei Budnik
> On April 10, 2018, 6:15 p.m., Greg Mann wrote: > > src/slave/containerizer/composing.cpp > > Line 376 (original), 378 (patched) > > > > > > Is it not possible to use `None()` here instead of > > `Option::none()`?

Re: Review Request 66545: Added admitted resource providers to the manager's registry.

2018-04-11 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66545/#review200903 --- src/resource_provider/manager.cpp Lines 668 (patched)

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

2018-04-11 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/#review200901 --- Bad patch! Reviews applied: [63370, 63368, 63366, 65462, 65461,

Re: Review Request 64211: Added options to build the Python CLI and run unit tests.

2018-04-11 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64211/#review200900 --- PASS: Mesos patch 64211 was successfully built and tested.

Review Request 66546: Prevent resubscription of resource providers with unknown IDs.

2018-04-11 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66546/ --- Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. Bugs: MESOS-7558

Review Request 66544: Remembered recovered and subscribed providers in ephemeral state.

2018-04-11 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66544/ --- Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jan Schlicht. Bugs:

Review Request 66545: Added admitted resource providers to the manager's registry.

2018-04-11 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66545/ --- Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jan Schlicht. Bugs:

Re: Review Request 66311: Implement recovery of resource provider manager.

2018-04-11 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66311/#review200898 --- PASS: Mesos patch 66311 was successfully built and tested.

Re: Review Request 66311: Implement recovery of resource provider manager.

2018-04-11 Thread Benjamin Bannier
> On April 10, 2018, 3:05 nachm., Jan Schlicht wrote: > > src/resource_provider/registrar.cpp > > Lines 97 (patched) > > > > > > `Registry` is in scope here and used without the namespace in other > > parts of this

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

2018-04-11 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/#review200894 --- FAIL: Failed to apply the dependent review: 63366. Failed

Re: Review Request 66311: Implement recovery of resource provider manager.

2018-04-11 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66311/ --- (Updated April 11, 2018, 9:30 a.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 66474: Updated minimum supported Linux kernel version.

2018-04-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66474/#review200890 --- Ship it! Ship It! - Gilbert Song On April 5, 2018, 5:21