Re: Review Request 66696: Updated documentation for operation feedback.

2018-04-20 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66696/#review201689 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66733: Added a new `RESIZE_VOLUME` agent capability.

2018-04-20 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66733/#review201680 --- Fix it, then Ship it! src/tests/master_tests.cpp Lines

Re: Review Request 66753: Windows: Fixed build with OpenSSL due to missing header.

2018-04-20 Thread Andrew Schwartzmeyer
> On April 20, 2018, 6:42 p.m., Mesos Reviewbot Windows wrote: > > FAIL: Some of the unit tests failed. Please check the relevant logs. > > > > Reviews applied: `['66753']` > > > > Failed command: `Start-MesosCITesting` > > > > All the build artifacts available at: > >

Re: Review Request 66753: Windows: Fixed build with OpenSSL due to missing header.

2018-04-20 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66753/#review201681 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66753: Windows: Fixed build with OpenSSL due to missing header.

2018-04-20 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66753/ --- (Updated April 20, 2018, 6:32 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 66753: Windows: Fixed build with OpenSSL due to missing header.

2018-04-20 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66753/#review201679 --- Fix it, then Ship it! Could you update the commit message to

Re: Review Request 66679: Made the master send operation status updates when dropping operations.

2018-04-20 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66679/#review201677 --- PASS: Mesos patch 66679 was successfully built and tested.

Re: Review Request 66696: Updated documentation for operation feedback.

2018-04-20 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66696/#review201675 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

2018-04-20 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66460/#review201673 --- Changed the return type to the following proto message: ``` /**

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

2018-04-20 Thread Gaston Kleiman
> On April 6, 2018, 2:13 p.m., Vinod Kone wrote: > > include/mesos/v1/scheduler.hpp > > Line 50 (original), 54-55 (patched) > > > > > > Since we don't guarantee backwards compat for this library, can we just > >

Re: Review Request 66468: Added tests for operation status reconciliation.

2018-04-20 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66468/ --- (Updated April 20, 2018, 5:03 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

2018-04-20 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66460/ --- (Updated April 20, 2018, 5:03 p.m.) Review request for mesos, Greg Mann and

Review Request 66753: Windows: Fixed build with OpenSSL due to missing header.

2018-04-20 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66753/ --- Review request for mesos, Akash Gupta, Chun-Hung Hsiao, and Joseph Wu.

Re: Review Request 66733: Added a new `RESIZE_VOLUME` agent capability.

2018-04-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66733/#review201658 --- include/mesos/mesos.proto Lines 997 (patched)

Re: Review Request 66577: Enabled CSI proto compilation by default.

2018-04-20 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66577/ --- (Updated April 20, 2018, 11:34 p.m.) Review request for mesos, Benjamin

Re: Review Request 66577: Enabled CSI proto compilation by default.

2018-04-20 Thread Chun-Hung Hsiao
> On April 20, 2018, 7:53 a.m., Benjamin Bannier wrote: > > src/Makefile.am > > Lines 1529-1536 (original), 1521-1525 (patched) > > > > > > We can merge these two blocks now. > > Chun-Hung Hsiao wrote: > I was

Re: Review Request 66749: Added more logging to agent recovery path.

2018-04-20 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66749/#review201668 --- PASS: Mesos patch 66749 was successfully built and tested.

Re: Review Request 66577: Enabled CSI proto compilation by default.

2018-04-20 Thread Chun-Hung Hsiao
> On April 20, 2018, 7:53 a.m., Benjamin Bannier wrote: > > src/Makefile.am > > Lines 1529-1536 (original), 1521-1525 (patched) > > > > > > We can merge these two blocks now. I was following the convention to

Re: Review Request 66727: Cherry-picked gRPC PR #15128 for Windows compilation.

2018-04-20 Thread Andrew Schwartzmeyer
> On April 20, 2018, 4:08 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/grpc-1.10.0.patch > > Lines 9-19 (patched) > > > > > > We discussed this a bit, and it's just... weird. gRPC should not be > > _requiring_

Re: Review Request 66051: Implemented operator API to grow and shrink persistent volume.

2018-04-20 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66051/ --- (Updated April 20, 2018, 4:18 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66532: Added test for authorization actions for `RESIZE_VOLUME`.

2018-04-20 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66532/ --- (Updated April 20, 2018, 4:17 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66531: Added new authorization for `ResizeVolume`.

2018-04-20 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66531/ --- (Updated April 20, 2018, 4:16 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

2018-04-20 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66568/ --- (Updated April 20, 2018, 4:15 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66727: Cherry-picked gRPC PR #15128 for Windows compilation.

2018-04-20 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66727/#review201665 --- Ship it! Ship It! - Andrew Schwartzmeyer On April 19, 2018,

Re: Review Request 66163: Built storage local resource provider with CMake.

2018-04-20 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66163/#review201664 --- Ship it! Ship It! - Andrew Schwartzmeyer On April 19, 2018,

Re: Review Request 61118: Building gRPC support in libprocess with CMake.

2018-04-20 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61118/#review201663 --- Ship it! Ship It! - Andrew Schwartzmeyer On April 19, 2018,

Re: Review Request 61096: Building gRPC with CMake.

2018-04-20 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61096/#review201662 --- Ship it! Ship It! - Andrew Schwartzmeyer On April 20, 2018,

Re: Review Request 66727: Cherry-picked gRPC PR #15128 for Windows compilation.

2018-04-20 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66727/#review201661 --- 3rdparty/grpc-1.10.0.patch Lines 9-19 (patched)

Re: Review Request 66696: Updated documentation for operation feedback.

2018-04-20 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66696/ --- (Updated April 20, 2018, 3:54 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 66466: Updated `RESERVE()` helper to allow specifying an operation ID.

2018-04-20 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66466/ --- (Updated April 20, 2018, 3:54 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 66467: Added a test helper for creating `RECONCILE_OPERATIONS` v1 calls.

2018-04-20 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66467/ --- (Updated April 20, 2018, 3:54 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 66465: Updated `using` statements in `tests/mesos.hpp`.

2018-04-20 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66465/ --- (Updated April 20, 2018, 3:54 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 66464: Implemented operation status reconciliation.

2018-04-20 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66464/ --- (Updated April 20, 2018, 3:53 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 66462: Added new operation states to be used for status reconciliation.

2018-04-20 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66462/ --- (Updated April 20, 2018, 3:53 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 66463: Added a master metric for operations reconciliation messages.

2018-04-20 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66463/ --- (Updated April 20, 2018, 3:53 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 66489: Cleaned up internal evolve functions.

2018-04-20 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66489/ --- (Updated April 20, 2018, 3:47 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 66459: Fixed bug in `Master::updateSlave()`.

2018-04-20 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66459/ --- (Updated April 20, 2018, 3:47 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 66461: Added an evolve function for `v1::scheduler::Response`.

2018-04-20 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66461/ --- (Updated April 20, 2018, 3:47 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 66458: Fixed handling of operations in `master::recoverFramework()`.

2018-04-20 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66458/ --- (Updated April 20, 2018, 3:47 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 66679: Made the master send operation status updates when dropping operations.

2018-04-20 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66679/ --- (Updated April 20, 2018, 3:47 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 66464: Implemented operation status reconciliation.

2018-04-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66464/#review201657 --- src/master/master.cpp Lines 8929-8933 (patched)

Re: Review Request 61096: Building gRPC with CMake.

2018-04-20 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61096/ --- (Updated April 20, 2018, 10:18 p.m.) Review request for mesos, Andrew

Review Request 66749: Added more logging to agent recovery path.

2018-04-20 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66749/ --- Review request for mesos, Chun-Hung Hsiao and Gaston Kleiman. Bugs: MESOS-8793

Re: Review Request 61096: Building gRPC with CMake.

2018-04-20 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61096/ --- (Updated April 20, 2018, 9:51 p.m.) Review request for mesos, Andrew

Re: Review Request 66230: Added test for adding/removing framework roles.

2018-04-20 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66230/#review201653 --- PASS: Mesos patch 66230 was successfully built and tested.

Re: Review Request 61096: Building gRPC with CMake.

2018-04-20 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61096/ --- (Updated April 20, 2018, 9:22 p.m.) Review request for mesos, Andrew

Re: Review Request 66726: Made CMake's `FindZLIB` module be able to find Zlib on Windows.

2018-04-20 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66726/#review201650 --- Ship it! Ship It! - Andrew Schwartzmeyer On April 19, 2018,

Re: Review Request 66230: Added test for adding/removing framework roles.

2018-04-20 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66230/ --- (Updated April 20, 2018, 4:19 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 66229: Implemented UPDATE_FRAMEWORK call.

2018-04-20 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66229/ --- (Updated April 20, 2018, 4:19 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 66228: Added Call for updating framework info.

2018-04-20 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66228/ --- (Updated April 20, 2018, 4:19 p.m.) Review request for mesos, Benjamin Mahler

Review Request 66746: Replaced protobuf-specific comparators with MessageDifferencer.

2018-04-20 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66746/ --- Review request for mesos, Benjamin Mahler and Till Toenshoff. Repository:

Re: Review Request 66173: Add test for new `disk/xfs` kill functionality.

2018-04-20 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66173/#review201647 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66725: Improved error message in the fetcher.

2018-04-20 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66725/#review201645 --- Patch looks great! Reviews applied: [66725] Passed command:

Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

2018-04-20 Thread Chun-Hung Hsiao
> On April 20, 2018, 12:57 p.m., Benjamin Bannier wrote: > > src/resource_provider/storage/provider.cpp > > Line 1010 (original), 1011 (patched) > > > > > > Nit: _pending operations_ should be specific enough as

Re: Review Request 66173: Add test for new `disk/xfs` kill functionality.

2018-04-20 Thread Harold Dost
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66173/ --- (Updated April 20, 2018, 6:49 p.m.) Review request for mesos and James Peach.

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

2018-04-20 Thread Harold Dost
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/ --- (Updated April 20, 2018, 6:48 p.m.) Review request for mesos and James Peach.

Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`.

2018-04-20 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66424/ --- (Updated April 20, 2018, 11:44 a.m.) Review request for mesos, Akash Gupta,

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

2018-04-20 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/ --- (Updated April 20, 2018, 11:40 a.m.) Review request for mesos, Chun-Hung

Review Request 66733: Added a new `RESIZE_VOLUME` agent capability.

2018-04-20 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66733/ --- Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

2018-04-20 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/ --- (Updated April 20, 2018, 11:38 a.m.) Review request for mesos, Chun-Hung

Re: Review Request 66423: Split `stout/os/open.hpp` into Windows and POSIX files.

2018-04-20 Thread Andrew Schwartzmeyer
> On April 18, 2018, 11:09 a.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/os/windows/open.hpp > > Lines 29-32 (patched) > > > > > > We won't need this note anymore (on the Windows header). That's true, but

Re: Review Request 62472: Fixed the ordering of Mesos containerizer isolators.

2018-04-20 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62472/#review201641 --- Ship it! Ship It! - Gilbert Song On April 19, 2018, 2:22

Re: Review Request 65976: Allowed profiles to be missing from `DiskProfileAdaptor`.

2018-04-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65976/#review201631 --- LGTM, but I wonder whether it would make sense to keep the

Re: Review Request 65975: Sequentialize reconciliations of storage pools in SLRP.

2018-04-20 Thread Benjamin Bannier
> On April 20, 2018, 3:27 p.m., Benjamin Bannier wrote: > > First round of reviews. > > > > I am not a big fan on how reconcilations are modelled here. The counting > > seems to lead to an incomplete encapsulation of correct behavior. I'd much > > rather see standard `libprocess` actor

Re: Review Request 65975: Sequentialize reconciliations of storage pools in SLRP.

2018-04-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65975/#review201629 --- First round of reviews. I am not a big fan on how reconcilations

Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

2018-04-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65594/#review201627 --- src/resource_provider/storage/provider.cpp Lines 1003 (patched)

Re: Review Request 65974: Added comments and made some renaming in SLRP.

2018-04-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65974/#review201625 --- Fix it, then Ship it!

Re: Review Request 65995: Declined unwanted offers in `RetryOperationStatusUpdate*` SLRP tests.

2018-04-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65995/#review201624 --- src/tests/storage_local_resource_provider_tests.cpp Lines

Re: Review Request 61096: Building gRPC with CMake.

2018-04-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61096/#review201623 --- This does currently not configure for me with `ENABLE_GRPC` (for

Re: Review Request 66311: Set up recovery code paths of resource provider manager.

2018-04-20 Thread Benjamin Bannier
> On April 19, 2018, 8 a.m., Chun-Hung Hsiao wrote: > > src/resource_provider/registrar.cpp > > Lines 193-203 (original), 194-203 (patched) > > > > > > How about moving this into

Re: Review Request 66311: Set up recovery code paths of resource provider manager.

2018-04-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66311/ --- (Updated April 20, 2018, 12:23 p.m.) Review request for mesos, Chun-Hung

Re: Review Request 66308: Delayed construction of the agent's resource provider manager.

2018-04-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66308/ --- (Updated April 20, 2018, 12:23 p.m.) Review request for mesos, Chun-Hung

Re: Review Request 66694: Updated the 1.6.0 CHANGELOG.

2018-04-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66694/#review201614 --- Ship it! Ship It! - Alexander Rojas On April 18, 2018, 8:45

Re: Review Request 66577: Enabled CSI proto compilation by default.

2018-04-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66577/#review201612 --- Fix it, then Ship it! src/Makefile.am Lines 1529-1536

Re: Review Request 66621: Add support for alg RS256 to JWT library.

2018-04-20 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66621/#review201613 --- Patch looks great! Reviews applied: [66621] Passed command: