Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

2018-04-24 Thread Chun-Hung Hsiao
> On April 23, 2018, 10:43 p.m., Greg Mann wrote: > > src/master/master.cpp > > Line 4512 (original), 4515-4527 (patched) > > > > > > I was just wondering - perhaps this code belongs in the validation > > function

Re: Review Request 66444: Windows: Deleted `stout/os/windows/signals.hpp`.

2018-04-24 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66444/#review201896 --- 3rdparty/stout/include/stout/os/signals.hpp Line 22 (original),

Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

2018-04-24 Thread Chun-Hung Hsiao
> On April 17, 2018, 10:52 p.m., Gaston Kleiman wrote: > > src/tests/persistent_volume_tests.cpp > > Lines 474-475 (patched) > > > > > > I see that Benjamin recently added this line and the corresponding > >

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

2018-04-24 Thread Chun-Hung Hsiao
> On April 23, 2018, 10:43 p.m., Greg Mann wrote: > > src/master/master.cpp > > Line 4512 (original), 4515-4527 (patched) > > > > > > I was just wondering - perhaps this code belongs in the validation > > function

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

2018-04-24 Thread Chun-Hung Hsiao
> On April 23, 2018, 10:43 p.m., Greg Mann wrote: > > src/master/master.cpp > > Line 4512 (original), 4515-4527 (patched) > > > > > > I was just wondering - perhaps this code belongs in the validation > > function

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

2018-04-24 Thread Chun-Hung Hsiao
> On April 16, 2018, 5:38 p.m., Gaston Kleiman wrote: > > src/master/master.cpp > > Lines 4931-4932 (patched) > > > > > > I'd change this to: > > > > > > ``` > > "Agent " + stringify(slave) + "

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

2018-04-24 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/#review201887 --- Fix it, then Ship it! src/master/master.cpp Lines 4905-4923

Re: Review Request 66790: Windows: Ported the rest of the `SubprocessTest` suite.

2018-04-24 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66790/#review201886 --- PASS: Mesos patch 66790 was successfully built and tested.

Re: Review Request 66733: Added a new `RESIZE_VOLUME` agent capability.

2018-04-24 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66733/#review201880 --- Fix it, then Ship it! src/tests/master_tests.cpp Lines

Re: Review Request 66546: Prevent resubscription of resource providers with unknown IDs.

2018-04-24 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66546/#review201879 --- src/tests/resource_provider_manager_tests.cpp Lines 1155

Re: Review Request 66545: Added admitted resource providers to the manager's registry.

2018-04-24 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66545/#review201878 --- src/tests/resource_provider_manager_tests.cpp Line 851

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

2018-04-24 Thread James Peach
> On April 2, 2018, 8:30 p.m., Ilya Pronin wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Lines 420 (patched) > > > > > > What about `QuotaPolicy::ENFORCING_PASSIVE`? The monitoring loop should

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

2018-04-24 Thread James Peach
> On March 27, 2018, 4:35 p.m., James Peach wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Line 362 (original), 414 (patched) > > > > > > `needed` is still the allocated quota so you don't need

Review Request 66790: Windows: Ported the rest of the `SubprocessTest` suite.

2018-04-24 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66790/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph Wu.

Re: Review Request 66309: Externalized creation of resource provider manager backing storage.

2018-04-24 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66309/#review201874 --- src/tests/resource_provider_manager_tests.cpp Line 823

Re: Review Request 66780: Removed redundant master flags in resource provider tests.

2018-04-24 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66780/#review201872 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction.

2018-04-24 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66437/#review201472 --- 3rdparty/stout/include/stout/os/windows/fd.hpp Line 82

Re: Review Request 66545: Added admitted resource providers to the manager's registry.

2018-04-24 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66545/#review201871 --- Ship it! Ship It! - Chun-Hung Hsiao On April 23, 2018,

Re: Review Request 66546: Prevent resubscription of resource providers with unknown IDs.

2018-04-24 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66546/#review201869 --- Ship it! Ship It! - Chun-Hung Hsiao On April 24, 2018, 7:28

Re: Review Request 66780: Removed redundant master flags in resource provider tests.

2018-04-24 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66780/#review201868 --- Ship it! Ship It! - Chun-Hung Hsiao On April 24, 2018, 7:28

Re: Review Request 66311: Set up recovery code paths of resource provider manager.

2018-04-24 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66311/#review201867 --- Ship it! Ship It! - Chun-Hung Hsiao On April 24, 2018, 7:28

Re: Review Request 66578: Windows: Ported more unit tests from `os_tests.cpp`.

2018-04-24 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66578/#review201865 --- Ship it! The cloexec and nonblock "ports" are a bit funny

Re: Review Request 66778: Fixed Master which generated updates with the latest task state.

2018-04-24 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66778/#review201864 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66778: Fixed Master which generated updates with the latest task state.

2018-04-24 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66778/#review201863 --- Patch looks great! Reviews applied: [66778] Passed command:

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

2018-04-24 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/ --- (Updated April 24, 2018, 2:16 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66733: Added a new `RESIZE_VOLUME` agent capability.

2018-04-24 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66733/ --- (Updated April 24, 2018, 2:16 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66444: Windows: Deleted `stout/os/windows/signals.hpp`.

2018-04-24 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66444/#review201861 --- Ship it! Ship It! - Joseph Wu On April 24, 2018, 1:41 p.m.,

Re: Review Request 66444: Windows: Deleted `stout/os/windows/signals.hpp`.

2018-04-24 Thread Andrew Schwartzmeyer
> On April 4, 2018, 10:22 a.m., Andrew Schwartzmeyer wrote: > > I think our other option is to just delete this file, and have > > `os/signals.hpp` include the POSIX version, but not the (deleted) Windows > > version, with a comment that none of it is (or will be) implemented. > > Joseph Wu

Re: Review Request 66444: Windows: Deleted `stout/os/windows/signals.hpp`.

2018-04-24 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66444/ --- (Updated April 24, 2018, 1:41 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 66545: Added admitted resource providers to the manager's registry.

2018-04-24 Thread Chun-Hung Hsiao
> On April 23, 2018, 9:30 p.m., Chun-Hung Hsiao wrote: > > src/resource_provider/manager.cpp > > Lines 685 (patched) > > > > > > Let's move the actual logic from r/66546 to this patch to make it > > self-contained.

Re: Review Request 66311: Set up recovery code paths of resource provider manager.

2018-04-24 Thread Benjamin Bannier
> On April 23, 2018, 9:43 p.m., Chun-Hung Hsiao wrote: > > src/resource_provider/manager.cpp > > Line 222 (original), 253-259 (patched) > > > > > > If this is not called elsewhere, how about not exposing this as a

Re: Review Request 66545: Added admitted resource providers to the manager's registry.

2018-04-24 Thread Benjamin Bannier
> On April 23, 2018, 11:30 p.m., Chun-Hung Hsiao wrote: > > src/resource_provider/manager.cpp > > Lines 685 (patched) > > > > > > Let's move the actual logic from r/66546 to this patch to make it > >

Re: Review Request 66546: Prevent resubscription of resource providers with unknown IDs.

2018-04-24 Thread Benjamin Bannier
> On April 23, 2018, 11:51 p.m., Chun-Hung Hsiao wrote: > > src/resource_provider/manager.cpp > > Lines 683-692 (patched) > > > > > > Let's move this to r/66545. I think this patch makes a lot of sense on its own,

Re: Review Request 66546: Prevent resubscription of resource providers with unknown IDs.

2018-04-24 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66546/ --- (Updated April 24, 2018, 9:28 p.m.) Review request for mesos, Chun-Hung Hsiao

Review Request 66780: Removed redundant master flags in resource provider tests.

2018-04-24 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66780/ --- Review request for mesos and Chun-Hung Hsiao. Repository: mesos Description

Re: Review Request 66311: Set up recovery code paths of resource provider manager.

2018-04-24 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66311/ --- (Updated April 24, 2018, 9:28 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66773: Windows: Fixed `os::stat::mtime()` to use `GetFileTime()`.

2018-04-24 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66773/#review201852 --- Patch looks great! Reviews applied: [66420, 66421, 66422, 66423,

Re: Review Request 66779: Inserted explicit moves in libprocess.

2018-04-24 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66779/ --- (Updated April 24, 2018, 8:58 p.m.) Review request for mesos and Alexander

Re: Review Request 66440: Replaced `open()` with `os::open()` in `http_proxy.cpp`.

2018-04-24 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66440/ --- (Updated April 24, 2018, 11:55 a.m.) Review request for mesos, Akash Gupta,

Re: Review Request 66773: Windows: Fixed `os::stat::mtime()` to use `GetFileTime()`.

2018-04-24 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66773/#review201850 --- PASS: Mesos patch 66773 was successfully built and tested.

Review Request 66778: Fixed Master which generated updates with the latest task state.

2018-04-24 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66778/ --- Review request for mesos, Andrei Budnik, Alexander Rukletsov, and Megha Sharma.

Re: Review Request 63372: Added documentation for memory profiling.

2018-04-24 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review201844 --- Have you rendered using our website renderer?

Re: Review Request 63372: Added documentation for memory profiling.

2018-04-24 Thread Alexander Rukletsov
> On April 23, 2018, 10:01 p.m., Alexander Rukletsov wrote: > > docs/memory-profiling.md > > Lines 98 (patched) > > > > > > comma after i.e. > > Benno Evers wrote: > Not according to the internet: >

Re: Review Request 66746: Replaced protobuf-specific comparators with MessageDifferencer.

2018-04-24 Thread Benjamin Mahler
> On April 24, 2018, 12:43 a.m., Benjamin Mahler wrote: > > I'm not sure this approach is tenable, we may in the future have two > > different `foo` fields with differing equality semantics. > > > > I was expecting that this patch would add an equality operator for specific > > types we want

Review Request 66773: Windows: Fixed `os::stat::mtime()` to use `GetFileTime()`.

2018-04-24 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66773/ --- Review request for mesos, Akash Gupta, John Kordich, and Joseph Wu. Bugs:

Re: Review Request 66666: Added MemoryProfiler to CHANGELOG.

2018-04-24 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6/ --- (Updated April 24, 2018, 4:41 p.m.) Review request for mesos and Alexander

Re: Review Request 63372: Added documentation for memory profiling.

2018-04-24 Thread Benno Evers
> On April 23, 2018, 10:01 p.m., Alexander Rukletsov wrote: > > docs/memory-profiling.md > > Lines 31 (patched) > > > > > > the bundled version? I think 'a' is correct here. > On April 23, 2018, 10:01 p.m.,

Re: Review Request 63372: Added documentation for memory profiling.

2018-04-24 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/ --- (Updated April 24, 2018, 2:40 p.m.) Review request for mesos and Alexander

Review Request 66776: Changed failure check for a call to os::system().

2018-04-24 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66776/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

2018-04-24 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66293/#review201819 --- Patch looks great! Reviews applied: [66481, 66258, 66591, 66259,

Re: Review Request 66608: Improved support for move-only types in `hashmap`.

2018-04-24 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66608/#review201817 --- Patch looks great! Reviews applied: [66608] Passed command:

Re: Review Request 66746: Replaced protobuf-specific comparators with MessageDifferencer.

2018-04-24 Thread Kapil Arya
> On April 23, 2018, 8:43 p.m., Benjamin Mahler wrote: > > I'm not sure this approach is tenable, we may in the future have two > > different `foo` fields with differing equality semantics. > > > > I was expecting that this patch would add an equality operator for specific > > types we want

Re: Review Request 66746: Replaced protobuf-specific comparators with MessageDifferencer.

2018-04-24 Thread Kapil Arya
> On April 23, 2018, 8:43 p.m., Benjamin Mahler wrote: > > I'm not sure this approach is tenable, we may in the future have two > > different `foo` fields with differing equality semantics. > > > > I was expecting that this patch would add an equality operator for specific > > types we want